[00:31:45] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, FR-Astropay, and 3 others: Remove fiscal number for Mexico form - https://phabricator.wikimedia.org/T129552#2159675 (Ejegg) Open>Resolved [00:32:43] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Using back button from AstroPay lands donor on unusable form - https://phabricator.wikimedia.org/T130673#2159676 (Ejegg) overlay is no longer there, but the card radio button is sele... [00:33:09] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: Catch exceptions in adapter constructor - https://phabricator.wikimedia.org/T129376#2159679 (Ejegg) Open>Resolved [00:33:15] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country, update l10n files - https://phabricator.wikimedia.org/T124329#2159680... [00:33:17] Fundraising-Backlog, FR-Astropay, Patch-For-Review, WMF-deploy-2016-03-29_(1.27.0-wmf.19): [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#2159681 (Ejegg) [00:34:10] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2159686 (Ejegg) Open>Resolved Phew, this is finally deployed! Thank you letter... [00:35:49] Fundraising-Backlog: Document templates on donate-wiki and payments-wiki - https://phabricator.wikimedia.org/T131219#2159688 (Ejegg) [00:36:34] gotta run! [02:23:16] (PS2) Eileen: CRM-18134 move api merge activity contact function to the BAO [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 [02:24:25] (CR) Eileen: "I just cleaned up the out of date dependency on this - now that the activity type is created on live this & the one that depends on it sho" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [02:25:13] (PS2) Eileen: CRM-18106 create activity against contact deleted by merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277449 [02:25:50] (CR) Eileen: "Note that the activity type now exists on live so we can deploy & close this one out" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277449 (owner: Eileen) [02:27:10] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#2159814 (Eileenmcnaughton) The a... [02:28:16] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2159815 (Eileenmcnaughton) a:Eileenmcnaughton [02:29:09] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2060277 (Eileenmcnaughton) This is a bit stalled on me not having figured out how to make... [02:32:10] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2159827 (Eileenmcnaughton) a:Eileenmcnaughton [02:36:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2159837 (Eileenmcnaughton) [02:36:27] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, and 2 others: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2159835 (Eileen... [02:38:03] (Abandoned) Eileen: CRM-18120 make acl query less debilitating [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277439 (https://phabricator.wikimedia.org/T130173) (owner: Eileen) [02:48:45] (Abandoned) Eileen: CRM-17435 Add option to generate drupal_7 directory version [wikimedia/fundraising/civicrm-core] - https://gerrit.wikimedia.org/r/252374 (owner: Eileen) [02:50:46] (PS2) Eileen: CRM-18178 exclude _bak & _backup tables from trigger creation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277441 [02:51:56] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Backport CRM-18178 exclude _bak & _backup tables from trigger creation - https://phabricator.wikimedia.org/T131221#2159841 (Eileenmcnaughton) [02:52:11] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Backport CRM-18178 exclude _bak & _backup tables from trigger creation - https://phabricator.wikimedia.org/T131221#2159857 (Eileenmcnaughton) [02:52:39] (PS3) Eileen: CRM-18178 exclude _bak & _backup tables from trigger creation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277441 (https://phabricator.wikimedia.org/T131221) [03:00:05] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Use a unique ID to store logging information per : https://issues.civicrm.org/jira/browse/CRM-18193 - https://phabricator.wikimedia.org/T131222#2159858 (Eileenmcnaughton) [03:04:56] (PS3) Eileen: CRM-18193 make unique ID for request available to php & mysql [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277440 (https://phabricator.wikimedia.org/T131222) [03:07:27] (Abandoned) Eileen: Fix Lybuns report logic to rely more on updated core report & untilise enhancements [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265216 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [03:14:10] (PS3) Eileen: CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277924 (https://phabricator.wikimedia.org/T131222) [03:15:18] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Sync relevant files with 4.7 to make porting easier - https://phabricator.wikimedia.org/T131223#2159880 (Eileenmcnaughton) [03:17:39] (PS2) Eileen: Fix for enable loggin in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T131223) [03:21:12] (PS3) Eileen: Fix for enable loggin in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T131223) [03:21:14] (PS2) Eileen: CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277929 (https://phabricator.wikimedia.org/T131222) [03:22:57] (PS2) Eileen: CRM-18193 add routine for converting log tables to support new log_conn_id format & hook spec [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T131222) [03:30:48] (PS1) Eileen: Fix variable name error that I just added [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280375 [03:32:04] (CR) Eileen: [C: 2] "Sneakily self reviewing since this is such a Homer Simpson moment on my part..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280375 (owner: Eileen) [03:33:07] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [04:12:08] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2159906 (Eileenmcnaughton) Turning logging on normally involves manually enabling the setting in the UI under administer... [04:17:58] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Ffx the logging code so that the triggers are not created in realtime if a setting is in play CRM-18212. - https://phabricator.wikimedia.org/T131224#2159907 (Eileenmcnaughton) [04:20:47] (PS3) Eileen: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T131224) [04:27:59] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deploy setting metadata updates & refresh the cache table. - https://phabricator.wikimedia.org/T131225#2159924 (Eileenmcnaughton) [04:31:30] (PS1) Eileen: Add settings metadata to support enabling logging functions [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280376 (https://phabricator.wikimedia.org/T131225) [06:12:38] (PS4) Eileen: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T131224) [06:13:45] (PS4) Eileen: CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277924 (https://phabricator.wikimedia.org/T131222) [06:13:47] (PS3) Eileen: CRM-18193 add routine for converting log tables to support new log_conn_id format & hook spec [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T131222) [06:13:49] (PS4) Eileen: CRM-18193 make unique ID for request available to php & mysql [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277440 (https://phabricator.wikimedia.org/T131222) [06:13:51] (PS4) Eileen: Fix for enable loggin in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T131223) [06:13:53] (PS3) Eileen: CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277929 (https://phabricator.wikimedia.org/T131222) [06:14:30] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Deploy setting metadata updates & refresh the cache table. - https://phabricator.wikimedia.org/T131225#2159979 (Eileenmcnaughton) [06:14:32] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Use a unique ID to store logging information per : https://issues.civicrm.org/jira/browse/CRM-18193 - https://phabricator.wikimedia.org/T131222#2159978 (Eileenmcnaughton) [06:17:22] (PS3) Eileen: CRM-18106 create activity against contact deleted by merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277449 (https://phabricator.wikimedia.org/T119426) [06:28:08] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Backport CRM-18178 exclude _bak & _backup tables from trigger creation - https://phabricator.wikimedia.org/T131221#2159993 (Eileenmcnaughton) https://gerrit.wikimedia.org/r/#/c/277441/ [06:30:45] (PS5) Eileen: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T131224) [06:34:40] (PS3) Eileen: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) [06:36:15] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [06:38:03] (PS4) Eileen: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) [06:39:36] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [06:40:39] (PS5) Eileen: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) [06:40:41] (PS6) Eileen: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T131224) [06:42:28] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [06:49:08] (PS3) Eileen: Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T131224) [06:51:19] (CR) jenkins-bot: [V: -1] Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [06:53:21] (PS2) Eileen: Also add 'Contact Deleted by Merge' on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280337 (https://phabricator.wikimedia.org/T119426) [07:21:50] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix the logging code so that it is in sync with 4.7 & the enable can be done by script - https://phabricator.wikimedia.org/T131228#2160037 (Eileenmcnaughton) [07:22:03] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix the logging code so that it is in sync with 4.7 & the enable can be done by script - https://phabricator.wikimedia.org/T131228#2160037 (Eileenmcnaughton) [07:28:03] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix the logging code so that it is in sync with 4.7 & the enable can be done by script - https://phabricator.wikimedia.org/T131228#2160056 (Eileenmcnaughton) [07:28:33] (PS1) Eileen: Sync logging enable routine with master to reflect porting of setting.create function [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280390 (https://phabricator.wikimedia.org/T131228) [07:41:31] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix slow activity query on logging tab - https://phabricator.wikimedia.org/T131229#2160057 (Eileenmcnaughton) [07:44:33] (PS1) Eileen: CRM-18096 Slow queries when rendering logging tab [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280391 (https://phabricator.wikimedia.org/T131229) [07:51:17] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Agree how we will deal with the trigger create mysql when we enable triggers - https://phabricator.wikimedia.org/T131230#2160081 (Eileenmcnaughton) [07:53:27] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback issues - https://phabricator.wikimedia.org/T131231#2160098 (Eileenmcnaughton) [07:55:48] (PS1) Eileen: Add trigger creation SQL for live DB [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280392 (https://phabricator.wikimedia.org/T131230) [08:06:49] (PS6) Eileen: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) [08:06:51] (PS4) Eileen: Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T131224) [08:08:35] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [08:08:54] (CR) jenkins-bot: [V: -1] Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [08:21:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out a process to set up our logging on people's dev installs. - https://phabricator.wikimedia.org/T131232#2160123 (Eileenmcnaughton) [08:22:43] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2127990 (Eileenmcnaughton) [08:23:57] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Agree how we will deal with the trigger create mysql when we enable triggers - https://phabricator.wikimedia.org/T131230#2160141 (Eileenmcnaughton) @Jgreen I'll need some input from you on this -... [08:25:27] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Improve the change log report - https://phabricator.wikimedia.org/T130164#2160142 (Eileenmcnaughton) I have an OK version of this on staging at the moment but I need to break it down & submit... [09:02:46] Fundraising-Backlog: Document templates on donate-wiki and payments-wiki - https://phabricator.wikimedia.org/T131219#2159688 (Peachey88) `&action=info` will give you a list of templates used on the page to make it easier to find what is used on the page. (example: https://www.mediawiki.org/w/index.php?title=... [10:57:07] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2160352 (jrobell) Thank you very much @ejegg for your work on this. I am sorry it end... [15:49:57] (CR) AndyRussG: "Great!! Heh just another silly inline comment..." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [16:17:50] (PS5) Cdentinger: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 [17:26:44] (CR) XenoRyet: "Response to inline comments" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [17:29:56] XenoRyet / cwd / AndyRussG|thnrgx : anything for Scrum of Scrums? [17:30:08] (PS3) Cdentinger: gateway_adapter&loadConfig() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 [17:30:10] ejegg: not for now, thx [17:30:10] (PS8) Cdentinger: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 [17:30:12] :) [17:30:18] ejegg: don't think so, thanks! [17:30:20] ejegg: na, I'm good. [17:30:41] k, thanks [17:38:28] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2159063 (Ejegg) a:Ejegg [17:40:46] (CR) Cdentinger: gateway_adapter&loadConfig() (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 (owner: Cdentinger) [17:59:49] awight: that patch is bad, surprised the tests are passing ^ [18:00:07] awight: nosequitor http://www.npr.org/sections/thesalt/2016/03/30/472167748/why-whole-foods-wants-a-slower-growing-chicken [18:00:07] i'll fix it up today, just don't +2 in the mean time :P [18:00:52] cwd: u can -1 it too, with ur newly returned gerrit powder! [18:00:58] or power [18:01:12] gerrit power powder [18:01:27] sorry to bud in, just an unsolicited suggestion [18:02:15] cwd: Did you see the kerfuffle on https://gerrit.wikimedia.org/r/#/c/277563 ? [18:02:32] I thought you were saying that the composer install *does* happen outside of our macro? [18:05:15] Hrmph...I will look after lunch [18:08:00] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: Document existing queue usage - https://phabricator.wikimedia.org/T121792#2161596 (awight) [18:10:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#2161600 (awight) [18:10:02] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: Document existing queue usage - https://phabricator.wikimedia.org/T121792#1888474 (awight) Open>Resolved a:awight [18:11:18] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2161641 (awight) Well, @Ottomata made us aware of an obstacle, but it seems to be the only blocker so fa... [18:18:50] Fundraising-Backlog, fundraising-tech-ops: [Epic] Provision high-availability Kafka cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2161694 (awight) [18:19:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Migrate a single, low-volume queue consumer to Kafka - https://phabricator.wikimedia.org/T130306#2161698 (awight) [18:22:20] Fundraising-Backlog: Pick a PHP Kafka client library - https://phabricator.wikimedia.org/T131268#2161707 (awight) [18:24:37] Fundraising-Backlog, FR-ActiveMQ: Pick a PHP Kafka client library - https://phabricator.wikimedia.org/T131268#2161724 (DStrine) [18:25:25] PHP Fatal error: Call to undefined method LargeDonationTest::setDisallowChangesToGlobalState() in /vagrant/srv/org.wikimedia.civicrm/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 732 [18:25:34] Fundraising-Backlog, FR-ActiveMQ: Write PHP-Queue module for Kafka - https://phabricator.wikimedia.org/T131269#2161726 (awight) [18:25:40] thoughts neone? [18:25:46] that's... odd [18:26:09] from within vagrant... pulled master [18:26:20] maybe submodules? [18:26:27] AndyRussG: it looks like a PHPUnit version problem [18:26:37] Hmmmm [18:26:52] try ./vendor/bin/phpunit [18:27:07] interesting, out of curiosity where'dja get this clue from? [18:27:50] cos that function only exists in the PHPUnit source code ;) [18:27:54] Fundraising-Backlog, FR-ActiveMQ: fundraising-tools queue operations should use Redis - https://phabricator.wikimedia.org/T130308#2161746 (DStrine) [18:27:56] it's not something we call [18:28:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Migrate a single, low-volume queue consumer to Kafka - https://phabricator.wikimedia.org/T130306#2161748 (DStrine) [18:28:11] Ah K hmmm [18:28:12] right [18:28:13] /vagrant/srv/org.wikimedia.civicrm$ vendor/bin/phpunit [18:28:13] PHPUnit 4.7.6 by Sebastian Bergmann and contributors. [18:28:13] .E....................FSPHP Fatal error: Class 'AdyenAuditProcessor' not found in /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/wmf_audit/tests/AdyenAuditTest.php on line 178 [18:28:15] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Patch-For-Review: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2161749 (DStrine) [18:28:15] I'm actually kind of weirded out by the whole thing [18:28:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-ActiveMQ: Payments should mirror outbound queue messages to both ActiveMQ and Redis - https://phabricator.wikimedia.org/T130287#2161750 (DStrine) [18:28:31] Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ: [Epic] Provision high-availability Kafka cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2161751 (DStrine) [18:28:43] fundraising-tech-ops, FR-ActiveMQ: install redis on lutetium for prototyping an activemq replacement - https://phabricator.wikimedia.org/T129491#2161753 (DStrine) [18:28:51] Fundraising-Backlog, FR-ActiveMQ, FR-Smashpig: Create SmashPig PhpQueueDataStore compatible with StompDataStore - https://phabricator.wikimedia.org/T129386#2161754 (DStrine) [18:28:53] AndyRussG: we might not be enabling the adyen_audit module [18:29:06] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Zapp, and 4 others: Spike: Split out ActiveMQ replacement tasks for making code changes - https://phabricator.wikimedia.org/T123247#2161756 (DStrine) [18:29:21] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, and 2 others: Document existing queue usage - https://phabricator.wikimedia.org/T121792#2161757 (DStrine) [18:29:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: CRM consumers should use the PHPQueue library - https://phabricator.wikimedia.org/T112832#2161759 (DStrine) [18:29:48] drush pm-disable....? [18:30:01] https://gerrit.wikimedia.org/r/#/c/280477/ [18:30:16] yeah, cd /srv/org.wikimedia.civicrm/drupal ; drush pm-enable adyen_audit [18:30:30] + the above patch for longer-term happiness [18:30:32] aaah right [18:30:40] gotcha [18:31:22] Fundraising-Backlog, FR-ActiveMQ: fundraising-tools queue operations should use Kafka - https://phabricator.wikimedia.org/T130308#2161761 (awight) [18:31:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, Epic, and 3 others: [Epic] Clean up "pending" queue usages - https://phabricator.wikimedia.org/T130897#2161765 (awight) [18:32:02] Fatal error: Class 'SmashPig\PaymentProviders\Adyen\Audit\AdyenAudit' not found in /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/wmf_audit/adyen/AdyenAuditProcessor.php on line 9 [18:32:19] awight: ^ :( [18:32:40] you need to... [18:32:42] gah [18:32:45] drush cc registry ? [18:32:54] wait. this is different. [18:34:07] try composer update at the crm/ level? But I assume you already did that? [18:34:12] ah no [18:34:20] Or maybe I did yesterday? hrmmggrr [18:34:37] It shouldn't have been recent. Does look like we're missing a class, though... [18:34:37] Ah no that was DI [18:37:15] Script bash tools/scripts/composer/dompdf-cleanup.sh handling the post-update-cmd event returned with an error [18:37:15] [RuntimeException] [18:37:15] Error Output: bash: tools/scripts/composer/dompdf-cleanup.sh: No such file or directory [18:37:18] AndyRussG: try "composer install" rather than update. something wicked in there [18:37:23] oh? wat [18:37:52] From /vagrant/srv/org.wikimedia.civicrm/civicrm ? [18:38:06] you should be one directory higher [18:38:15] sorry... there is crm and crm/civicrm [18:38:29] that was me overreacting to the old repo being called "drupal" [18:38:32] CRM? [18:38:37] no, crm [18:38:58] /vagrant/srv/org.wikimedia.civicrm is the root of the crm repo [18:39:22] I don't see a dir called just 'crm' [18:39:29] it's ^^ [18:39:40] try "git remote" in that dir and u will see... [18:39:51] /vagrant/srv/org.wikimedia.civicrm ? [18:40:13] Ah gotcha [18:41:05] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-ActiveMQ: Payments should mirror outbound queue messages to both ActiveMQ and Kafka - https://phabricator.wikimedia.org/T130287#2161786 (awight) [18:42:00] /vagrant/srv/org.wikimedia.civicrm$ composer update [18:42:00] You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug [18:42:00] Loading composer repositories with package information [18:42:00] Updating dependencies (including require-dev) [18:42:00] Your requirements could not be resolved to an installable set of packages. [18:42:00] Problem 1 [18:42:02] - wikimedia/smash-pig dev-master requires amzn/login-and-pay-with-amazon-sdk-php dev-master -> satisfiable by amzn/login-and-pay-with-amazon-sdk-php[dev-master]. [18:42:04] - wikimedia/smash-pig dev-master requires amzn/login-and-pay-with-amazon-sdk-php dev-master -> satisfiable by amzn/login-and-pay-with-amazon-sdk-php[dev-master]. [18:42:07] - Removal request for amzn/login-and-pay-with-amazon-sdk-php == 9999999-dev [18:42:09] - Installation request for wikimedia/smash-pig dev-master -> satisfiable by wikimedia/smash-pig[dev-master]. [18:42:13] sorry 4 the spam [18:43:29] Maybe I should pick up my shoes and glasses and move along...... [18:44:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ, FR-Smashpig: Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2161797 (awight) [18:45:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, and 2 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#1515750 (awight) [18:46:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, and 2 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#1515750 (awight) [18:46:28] Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ: [Epic] Provision high-availability Kafka cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2161818 (awight) [18:46:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, and 2 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#1515750 (awight) [18:46:32] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Patch-For-Review: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2132042 (awight) Open>Resolved [18:48:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Migrate a single, low-volume queue consumer to Kafka - https://phabricator.wikimedia.org/T130306#2161820 (awight) [18:49:04] Hmm getting rid of vendor and re-running composer install [18:49:47] Happily, I know that this works in CI, so there's an end in sight... [18:49:58] But fwiw I'm getting all the same errors as you, locally. [18:51:05] Hm! [18:51:46] NEway, I was just able to run some tests! After the composer install success, and the composer update error (^) I was forgetting to prefix phpunit w/ vendor/bin [18:52:10] Now running tests I get 3 errors and 1 failure [18:53:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Migrate a single, low-volume queue consumer to Kafka; pilot consumer dequeue loop - https://phabricator.wikimedia.org/T130306#2161833 (awight) [18:54:35] K I'm gonna just unlick this cookie: https://gerrit.wikimedia.org/r/#/c/277947/ [18:55:18] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Patch-For-Review: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2161838 (Ottomata) > No one at the WMF uses PHP to produce Kafka messages yet, Ah! That... [18:56:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ, FR-Smashpig: Formalize schema for all message types - https://phabricator.wikimedia.org/T131272#2161844 (awight) [18:57:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Migrate fredge to new queue - https://phabricator.wikimedia.org/T131273#2161859 (awight) [18:58:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, and 2 others: Migrate pending to new queue and finish cleanup - https://phabricator.wikimedia.org/T131274#2161875 (awight) [18:59:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ, and 2 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2161894 (awight) [18:59:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ, FR-Smashpig: Migrate donations to new queue - https://phabricator.wikimedia.org/T131277#2161921 (awight) [19:00:11] (CR) AndyRussG: Fix opt out fields for Civi imports (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [19:01:17] Fundraising-Backlog, FR-ActiveMQ: Migrate banner impressions to new queue and rewrite - https://phabricator.wikimedia.org/T131278#2161935 (awight) [19:02:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ: Migrate contribution tracking to new queue - https://phabricator.wikimedia.org/T131279#2161951 (awight) [19:03:06] (CR) XenoRyet: Fix opt out fields for Civi imports (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [19:08:11] (PS7) XenoRyet: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) [19:08:47] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2161991 (Ejegg) Seems to be 4 contributions failing over and over, all attached to deleted contac... [19:11:28] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Patch-For-Review: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2161993 (awight) Whoops, thanks for catching that slip! Yes, that's what I heard, just... [19:15:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ: Migrate contribution tracking to new queue - https://phabricator.wikimedia.org/T131279#2161951 (Ejegg) Does this include finding a new wiki-side source for unique order IDs? Kafka doesn't seem... [19:16:59] Fundraising-Backlog, FR-ActiveMQ: Write specialized delay queue and handlers - https://phabricator.wikimedia.org/T131282#2162012 (awight) [19:17:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ: Migrate contribution tracking to new queue - https://phabricator.wikimedia.org/T131279#2162039 (awight) Thanks! I'll add that to the description. [19:20:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ: Migrate contribution tracking to new queue - https://phabricator.wikimedia.org/T131279#2162053 (awight) [19:29:08] (PS8) Ejegg: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [19:34:34] (CR) Ejegg: [C: 2] "Normalized!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [19:35:03] ejegg: Thanks for the CR [19:35:10] yw [19:43:40] eileen: hi! I thought I'd "unlick" this cookie https://gerrit.wikimedia.org/r/#/c/277947/ [19:44:36] ...in the sense that, I was trying to CR, and got caught up in making tests run... and so I was a few hundred meters down the rabbit hole before I'd even begun to try to understand the change itself [19:45:03] I did start to understand bits of the civi codebase but it seems pretty vast [19:45:13] (did as in some months ago) [19:46:42] I'm happy to keep going, but it doesn't seem to be going fast, so if expediency is needed, I hope folks who know more might consider the cookie unlicked [19:46:44] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2162249 (Ejegg) Even better, these are from just two donors. 16251032 and 16487499 are associated... [19:48:02] does that make sense? [20:10:51] (CR) Ejegg: "I just noticed this is showing up in the 'Activity' dropdown on the contact screen. I think we need to update it with filter=1." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277447 (https://phabricator.wikimedia.org/T119246) (owner: Eileen) [20:11:39] ejegg: i'm just trying to get my head around https://gerrit.wikimedia.org/r/#/c/277563/5 ... iirc listing vendor explicitly was because of a relative path issue [20:11:50] but why run composer install anyhow? [20:13:49] cwd so we can pass tests that depend on un updated composer package [20:13:59] *an [20:14:14] before it's been merged into the submodule? [20:14:14] since we only check the change to composer.lock into master [20:14:31] or wait.. it's not a submodule on master? [20:14:32] and don't update the submodule till we're deploying [20:14:39] right, only deploy [20:14:55] gosh so how was vendor there at all? [20:15:06] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2159063 (MBeat33) @ejegg, cid=14806142 is also the 'freakish anomaly' from {T128389} fwiw [20:15:35] before we ran composer install, it was only there b/c you explicitly listed it [20:16:24] ooh right [20:16:38] so we can remove that dep if it's going to composer install [20:16:46] yep! [20:17:00] it's all coming back [20:18:25] wouldn't this make it possible to forget to update the vendor repo though? [20:18:39] hmm, I suppose it would [20:19:23] and that is a practice inherited from core right? a submodule rather than composer install on deploy [20:19:46] (not that i love the idea of deploy depending on composer) [20:19:52] IIRC we're only doing it that way b/c we don't want to run composer from production [20:20:08] that seems sane [20:21:36] what does jan mean by "composer merge plugin" ? [20:23:04] hmm, that I don't know [20:23:35] but... waitaminute, didn't I get something merged for this? [20:23:52] i remember his talk about signing composer packages so they could be installed on prod [20:23:58] i wonder if that has something to do with this [20:27:26] hmm, looks like a way to merge the core composer.json with extension composer.json files so you can install them all at once [20:29:00] ah that seems sort of smart [20:30:03] but isn't this problem easily solved by merging vendor changes first? [20:30:18] and then there's no worry about forgetting them before deploy [20:31:11] sure, that would solve it, but when you're tinkering with the external package as you develop the patch, it's a pain to have to update vendor so many times [20:31:34] I think that's why we got rid of the submodule in master in the first place [20:33:21] yeah... [20:34:18] i feel dumb for asking but why not just check vendor in with the repo? [20:34:51] i dunno - avoid bloat/clutter? [20:35:42] yeah it feels gross, but it would simplify some stuff [20:37:15] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [20:39:36] (PS5) Ejegg: Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [20:41:39] ejegg: vendor submodule updates seem like a rote operation that could be automated somehow [20:41:50] frig? [20:41:56] maybe? [20:42:16] it just seems like if we can rely on an automated composer install in CI [20:42:29] we can rely on an automated submodule commit [20:42:40] from frig, yes, but not during deployment [20:42:58] awight: yeah [20:43:09] no pulling random crap from the internet during deploy [20:43:22] cwd maybe during deployment just check that composer.lock matches vendor? [20:43:26] just trying to think of a way to couple the submodule update so it can't get forgotten [20:43:37] ejegg: that's a good idea [20:43:40] ejegg: good call [20:47:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Check that vendor matches composer.lock during fundraising_code_update - https://phabricator.wikimedia.org/T131313#2162630 (Ejegg) [20:48:22] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2162642 (awight) I'd love to what proportion of our visitors have LocalStorage-capable browsers. Falling back to cook... [20:52:47] PPena_: tooo slooow.... [20:52:58] Thank you for keeping the burners on, though! [20:53:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, and 2 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#2162657 (awight) [20:53:53] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Zapp, and 4 others: Spike: Split out ActiveMQ replacement tasks for making code changes - https://phabricator.wikimedia.org/T123247#1924535 (awight) Open>Resolved [20:54:11] Can I CR for anyone? [20:54:25] eileen: AndyRussG: ^ [20:54:41] awight: u bet! One sec... [20:55:11] AndyRussG: funny you should ask that.... [20:55:21] https://phabricator.wikimedia.org/T128869 [20:55:54] https://gerrit.wikimedia.org/r/#/c/277792/ [20:56:16] (and dependency, https://gerrit.wikimedia.org/r/#/c/277453/1 ) [20:56:22] eileen: ? [20:56:27] oh sorry it was awight asking & you replying [20:56:32] (PS2) Awight: Admin UI: Move JS and CSS for campaign pager to RL module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277453 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [20:56:42] eileen: np! :) [20:56:55] awight: all my dependency chains start from this one https://gerrit.wikimedia.org/r/#/c/280376/ [20:57:05] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#1532156 (Ejegg) Are we logging local storage failures now? Browser support is looking pretty good on caniuse, but I d... [20:57:25] AndyRussG: eileen: Okay, thanks! I'll focus on the CN then CRM review... [20:57:46] cool [21:04:48] (CR) Awight: "One tiny thing to clean up." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277453 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [21:07:05] (PS1) Ejegg: Send failmail when TY job can't find contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280580 (https://phabricator.wikimedia.org/T131200) [21:11:50] awight, ejegg: this is weird.... https://gerrit.wikimedia.org/r/#/c/278292/7..8/worldpay_gateway/config/payment_submethods.yaml [21:11:55] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2162704 (Ejegg) Testing locally shows merges correctly moving the _recur re... [21:12:05] this was a standard rebase and look what it did [21:12:28] i was wondering why the tests passed [21:12:39] wha? weird... [21:13:45] PS7 is the more correct one, PS8 was git rebase master... i don't understand why it removed those api_name lines [21:14:20] so strange... looks like it rebased PS1 instead of PS7 [21:14:24] diff(1)!!! [21:14:34] yeah it does [21:14:36] cripes [21:14:41] you can check out PS7 and try that again. [21:14:46] Did you rebase from the commandline? [21:15:02] yep, the button complained, but the shell did it non interactively [21:15:09] so i was immediately suspect [21:15:16] yyyeah [21:15:20] gonna relocate for prawning... back soon [21:15:37] awight: thx!! "onready closure is not necessary in RL modules." -> huh? [21:16:36] AndyRussG: You don't need the jQuery(document).ready thing [21:16:50] <_< [21:16:50] >_> [21:16:54] * awight double-checks that. [21:16:57] Heh [21:17:00] Fundraising-Backlog: CIVI access for Jerry Kim - https://phabricator.wikimedia.org/T131316#2162712 (Ppena) [21:17:19] Yeah we do a lot of the equivalent form, $( function ), elsewhere [21:17:32] In that particular case, it was copypasta from the old code [21:17:45] (since I was just moving it around) [21:18:32] Well, I can't really tell from reading the docs. [21:18:42] Mebbe worth asking someone who knows... [21:21:15] awight: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/5aa7ac36e00fd42194519268b04b9b7e8cb811b8/resources/subscribing/ext.centralNotice.display.js#L511-L513 [21:23:54] *scary*! [21:24:31] I'm pretty sure I remember it wasn't guaranteed, that this form was discussed with krinkle for the subscribing js code... [21:24:39] AndyRussG: counterexample, resources/src/mediawiki/mediawiki.checkboxtoggle.js [21:24:58] Fundraising-Backlog: SPRINT G (3/30 - 4/13) GOAL: Astropay Campaign Ready, Civi/DS bugs and redupe deploy - https://phabricator.wikimedia.org/T131160#2162738 (DStrine) [21:25:05] Interestingly, a lot of the infrastructure code doesn't seem to give a ... [21:25:05] (PS9) Cdentinger: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 [21:25:12] hehehe [21:25:26] ...even while binding to stuff on the page [21:25:29] That might explain some of our mystery fails [21:25:44] I would ping Krinkle if he were here... [21:25:45] Fundraising-Backlog: SPRINT H (4/13-4/27) GOAL: Adyen for new countries (Isreal, Ukraine and more!) - https://phabricator.wikimedia.org/T131161#2162739 (DStrine) [21:26:10] Fundraising-Backlog: SPRINT I (4/27-5/11) GOAL: Start Paypal Integration - https://phabricator.wikimedia.org/T131162#2162741 (DStrine) [21:26:28] Hmmm interesting [21:27:25] Oh he's around! knocking on his door now... [21:28:12] awight: come on down to #wikimedia-perf [21:28:32] only a few minutes left until the shrimp grooming... [21:28:54] oh i know what happened with that patch, i shouldn't have rebased onto master cause its dependency isn't merged yet [21:29:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Break out tasks for "Move CentralNotice stuff out of cookies" - https://phabricator.wikimedia.org/T131317#2162743 (DStrine) [21:29:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Break out tasks for "Move CentralNotice stuff out of cookies" - https://phabricator.wikimedia.org/T131317#2162743 (DStrine) [21:29:57] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#1532156 (DStrine) [21:31:43] dstrine: oopse I thought the meet was at 6, there in a minute [21:31:50] or 3 [21:32:19] talk plugin crashy again, gimme a minute [21:32:55] AndyRussG: meeting? [21:33:06] ah sorry [21:33:09] just saw text [21:39:45] Fundraising Sprint Freshmaking, Fundraising-Backlog: Sprint F Goal: Scope Q4 work, deal with some civi bugs - https://phabricator.wikimedia.org/T128678#2162771 (DStrine) Open>Resolved [21:47:45] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work, WMF FR: Ingenico ePayments Partners with Trustwave for PCI Compliance - https://phabricator.wikimedia.org/T129596#2162784 (DStrine) Open>Resolved [21:49:49] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Use consistent parameter and variable names in DI - https://phabricator.wikimedia.org/T130939#2162793 (Ejegg) Next step: delete the legacy code [21:52:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] Lybunt report could be faster - https://phabricator.wikimedia.org/T122024#2162817 (DStrine) [21:52:03] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#2162816 (DStrine) Open>Resolved [21:52:29] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Use consistent parameter and variable names in DI - https://phabricator.wikimedia.org/T130939#2162818 (Ejegg) [21:55:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2162834 (AndyRussG) [21:55:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2162853 (AndyRussG) [21:55:43] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2162852 (AndyRussG) [21:58:17] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#1912265 (DStrine) a:cwdent>DStrine [21:58:40] AndyRussG: Hey Andy [21:59:36] Seddon: hi! [22:00:21] AndyRussG: I was wondering whether you can give an idiots explanation to that particular ticket. The reasoning and implications going forward :) [22:02:06] Seddon: happy to explain, provide details, for sure! We're in our bi-weekly sprint planning meeting right now... [22:02:19] ahh apologies [22:02:30] Ah no apology necessary ;) [22:02:46] Should be done around 16:00 PST... What time zone are u in? [22:05:44] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2163114 (DStrine) a:DStrine>None [22:05:46] AndyRussG: Time and zoning of it I tend to see as an abstract construct for those who strive to achieve a work life balance :P [22:06:06] AndyRussG: I'll be present :) [22:07:27] Mmmm I just strive to avoid a total train life-work train wreck ;p [22:07:56] AndyRussG: I thrive off of the chaos [22:09:36] AndyRussG: I can only extremes. Total tranquility or something resembling the balkan states during the 1990s [22:09:48] Heheh [22:09:58] Wikimedia-Fundraising-CiviCRM: Enable ability to look up contacts by phone number - https://phabricator.wikimedia.org/T97372#2163372 (atgo) [22:10:10] Wikimedia-Fundraising-CiviCRM: Allow contacts to be called by their last name in Silverpop emails - https://phabricator.wikimedia.org/T86343#2163377 (atgo) [22:10:15] Fundraising Dash: Allow name of dash to stay on 1 line - https://phabricator.wikimedia.org/T93975#2163379 (atgo) [22:10:20] From 16:15 to 17:30 PST I'm busy but from then on most anytime is good. Or tomorrow morning... Whichever you prefer :) [22:14:53] Wikimedia-Fundraising-CiviCRM: Make "Primary" address default address to export - https://phabricator.wikimedia.org/T88446#2163466 (atgo) [22:19:19] Fundraising-Backlog: Mobile donation form: error entering valid email address - https://phabricator.wikimedia.org/T131323#2163485 (MBeat33) [22:19:50] Fundraising-Backlog: Mobile donation form: error entering valid email address - https://phabricator.wikimedia.org/T131323#2163498 (MBeat33) p:Triage>Normal [22:27:05] Fundraising-Backlog: SPRINT G (3/30 - 4/13) GOAL: Astropay Campaign Ready and redupe deploy - https://phabricator.wikimedia.org/T131160#2163526 (DStrine) [22:36:44] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2163555 (DStrine) [22:36:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Break out tasks for "Move CentralNotice stuff out of cookies" - https://phabricator.wikimedia.org/T131317#2163554 (DStrine) Open>declined [22:39:35] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback issues - https://phabricator.wikimedia.org/T131231#2163570 (DStrine) [22:39:37] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Agree how we will deal with the trigger create mysql when we enable triggers - https://phabricator.wikimedia.org/T131230#2163571 (DStrine) [22:39:39] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix slow activity query on logging tab - https://phabricator.wikimedia.org/T131229#2163572 (DStrine) [22:39:41] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Deploy setting metadata updates & refresh the cache table. - https://phabricator.wikimedia.org/T131225#2163574 (DStrine) [22:39:43] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix the logging code so that it is in sync with 4.7 & the enable can be done by script - https://phabricator.wikimedia.org/T131228#2163573 (DStrine) [22:39:45] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Ffx the logging code so that the triggers are not created in realtime if a setting is in play CRM-18212. - https://phabricator.wikimedia.org/T131224#2163575 (DStrine) [22:39:47] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Use a unique ID to store logging information per : https://issues.civicrm.org/jira/browse/CRM-18193 - https://phabricator.wikimedia.org/T131222#2163577 (DStrine) [22:39:49] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Sync relevant files with 4.7 to make porting easier - https://phabricator.wikimedia.org/T131223#2163576 (DStrine) [22:39:51] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Backport CRM-18178 exclude _bak & _backup tables from trigger creation - https://phabricator.wikimedia.org/T131221#2163578 (DStrine) [22:39:53] Fundraising Sprint G 2016, Fundraising-Backlog: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2163580 (DStrine) [22:39:55] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2163579 (DStrine) [22:39:57] Fundraising Sprint G 2016, Fundraising-Backlog: SPRINT G (3/30 - 4/13) GOAL: Astropay Campaign Ready and redupe deploy - https://phabricator.wikimedia.org/T131160#2163581 (DStrine) [22:39:59] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Use consistent parameter and variable names in DI - https://phabricator.wikimedia.org/T130939#2163582 (DStrine) [22:40:01] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Opt out field not working with Engage import - https://phabricator.wikimedia.org/T130768#2163583 (DStrine) [22:40:03] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Using back button from AstroPay lands donor on unusable form - https://phabricator.wikimedia.org/T130673#2163584 (DStrine) [22:40:05] Fundraising Sprint G 2016, Fundraising-Backlog: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2163585 (DStrine) [22:40:07] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Improve the change log report - https://phabricator.wikimedia.org/T130164#2163587 (DStrine) [22:40:10] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2163589 (DStrine) [22:40:11] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2163588 (DStrine) [22:40:14] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, and 6 others: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2163590 (DStrine) [22:40:16] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, and 3 others: Pull payment methods out of adapters - https://phabricator.wikimedia.org/T130056#2163591 (DStrine) [22:40:18] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2163593 (DStrine) [22:40:20] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, and 3 others: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotice - https://phabricator.wikimedia.org/T128869#2163592 (DStrine) [22:40:23] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, and 2 others: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#2163598 (DStrine) [22:40:25] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, and 3 others: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#2163597 (DStrine) [22:40:28] Fundraising Sprint Freshmaking, Fundraising Sprint G 2016, Fundraising-Backlog, FR-Paypal: Scope PayPal express checkout - https://phabricator.wikimedia.org/T113625#2163599 (DStrine) [22:45:02] looking at this channel makes me smile about all the email i didn't just get [23:01:41] :-) [23:08:59] dstrine: can you update the link on the front page to the new sprint? [23:10:01] cwd: LOL [23:10:03] eileen: done [23:11:02] thx [23:19:44] (CR) Awight: "This is a huge improvement, I would merge if not a WIP. The new logic might be a bit fragile, but certainly better than what we had befor" (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [23:21:25] (CR) Awight: [C: 2] Add settings metadata to support enabling logging functions [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280376 (https://phabricator.wikimedia.org/T131225) (owner: Eileen) [23:23:34] (CR) Awight: [C: 2] CRM-18193 make unique ID for request available to php & mysql [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277440 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:25:59] (Merged) jenkins-bot: Add settings metadata to support enabling logging functions [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280376 (https://phabricator.wikimedia.org/T131225) (owner: Eileen) [23:26:19] (CR) Awight: [C: 2] CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277924 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:27:24] (Merged) jenkins-bot: CRM-18193 make unique ID for request available to php & mysql [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277440 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:28:42] (CR) Awight: [C: 2] CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [23:29:48] (PS5) Awight: Fix to enable logging in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [23:29:58] (CR) Awight: [C: 2] Fix to enable logging in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [23:30:06] (PS4) Awight: CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277929 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:31:00] (CR) Awight: [C: 2] CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277929 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:31:24] (PS7) Awight: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [23:34:36] (CR) Awight: "Cool! It's breaking CI with what looks like a trigger-related error, though:" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [23:35:41] * awight is thrilled to see the civicrm CI running in parallel [23:36:09] :-) [23:36:28] (PS5) Awight: CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277924 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:36:37] (PS6) Awight: Fix to enable logging in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [23:36:43] (PS5) Awight: CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277929 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:36:45] (CR) jenkins-bot: [V: -1] Fix to enable logging in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [23:36:47] (CR) jenkins-bot: [V: -1] CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277929 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:39:25] (CR) Awight: [C: 2] Admin UI: Move JS and CSS for campaign pager to RL module (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277453 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [23:40:37] (CR) Awight: [C: 2] move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [23:40:52] (CR) Awight: "Needs manual rebase." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 (owner: Cdentinger) [23:40:54] (Merged) jenkins-bot: Admin UI: Move JS and CSS for campaign pager to RL module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277453 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [23:41:57] (Merged) jenkins-bot: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [23:42:13] (CR) Awight: [C: 2] gateway_adapter&loadConfig() (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 (owner: Cdentinger) [23:42:55] (PS3) Eileen: Also add 'Contact Deleted by Merge' on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280337 (https://phabricator.wikimedia.org/T119426) [23:42:57] (PS1) Eileen: Set filter = 2 on Contact Deleted By Merge activity type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280607 [23:44:04] (PS2) Eileen: Set filter = 1 on Contact Deleted By Merge activity type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280607 [23:44:06] (CR) Eileen: "Good point, added https://issues.civicrm.org/jira/browse/CRM-18327 and https://gerrit.wikimedia.org/r/#/c/280607/" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277447 (https://phabricator.wikimedia.org/T119246) (owner: Eileen) [23:44:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: CI: wikimedia/fundraising/crm/civicrm repo should automatically submit and merge after CR+2 V+2 - https://phabricator.wikimedia.org/T131330#2163845 (awight) [23:48:16] (CR) Awight: [C: 2] Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [23:48:31] (PS2) Awight: Add trigger creation SQL for live DB [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280392 (https://phabricator.wikimedia.org/T131230) (owner: Eileen) [23:49:02] (CR) Awight: [C: 2] "Fantastic!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280392 (https://phabricator.wikimedia.org/T131230) (owner: Eileen) [23:49:14] (PS2) Awight: CRM-18096 Slow queries when rendering logging tab [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280391 (https://phabricator.wikimedia.org/T131229) (owner: Eileen) [23:50:35] (Merged) jenkins-bot: Add trigger creation SQL for live DB [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280392 (https://phabricator.wikimedia.org/T131230) (owner: Eileen) [23:51:18] (CR) Awight: "Why is this called via the API and not as a normal schema update hook?" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [23:51:53] (CR) Awight: [C: 2] CRM-18096 Slow queries when rendering logging tab [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280391 (https://phabricator.wikimedia.org/T131229) (owner: Eileen) [23:52:03] (PS2) Awight: Sync logging enable routine with master to reflect porting of setting.create function [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280390 (https://phabricator.wikimedia.org/T131228) (owner: Eileen) [23:52:17] (CR) Awight: [C: 2] Sync logging enable routine with master to reflect porting of setting.create function [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280390 (https://phabricator.wikimedia.org/T131228) (owner: Eileen) [23:52:31] (PS3) Awight: CRM-18134 move api merge activity contact function to the BAO [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [23:53:25] (Merged) jenkins-bot: CRM-18096 Slow queries when rendering logging tab [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280391 (https://phabricator.wikimedia.org/T131229) (owner: Eileen) [23:53:38] (CR) Awight: [C: 2] CRM-18106 create activity against contact deleted by merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277449 (https://phabricator.wikimedia.org/T119426) (owner: Eileen) [23:54:00] (Merged) jenkins-bot: Sync logging enable routine with master to reflect porting of setting.create function [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280390 (https://phabricator.wikimedia.org/T131228) (owner: Eileen) [23:54:18] gtg! [23:54:43] (CR) Eileen: "because for a large site (e.g ours) it could take hours to do the conversion & there are a few places the normal evaluation is triggered f" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T131222) (owner: Eileen)