[00:09:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out a process to set up our logging on people's dev installs. - https://phabricator.wikimedia.org/T131232#2163911 (Eileenmcnaughton) [00:09:46] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2163910 (Eileenmcnaughton) [00:10:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out a process to set up our logging on people's dev installs. - https://phabricator.wikimedia.org/T131232#2160123 (Eileenmcnaughton) [00:10:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2163912 (Eileenmcnaughton) [00:10:32] (CR) Eileen: "It might sort itself out when this is merged https://gerrit.wikimedia.org/r/#/c/280336/" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [00:15:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out a process to set up our logging on people's dev installs. - https://phabricator.wikimedia.org/T131232#2163916 (Eileenmcnaughton) Note that buildkit affects peoples installs & the test environment so we probably want to get it right there - a... [00:37:21] (CR) AndyRussG: Admin UI: Move JS and CSS for campaign pager to RL module (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277453 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [05:23:20] Fundraising Tech Backlog: pay-lvs1001, barium, puppetrun - https://phabricator.wikimedia.org/T131338#2164102 (Dzahn) [07:41:52] (CR) JanZerebecki: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [12:52:07] Fundraising Tech Backlog: pay-lvs1001, barium, puppetrun - https://phabricator.wikimedia.org/T131338#2164657 (Jgreen) Thanks for acking. Puppet had crapped out and just needed a manual/forced run. [12:52:17] Fundraising Tech Backlog: pay-lvs1001, barium, puppetrun - https://phabricator.wikimedia.org/T131338#2164658 (Jgreen) Open>Resolved [13:24:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: CI: wikimedia/fundraising/crm/civicrm repo should automatically submit and merge after CR+2 V+2 - https://phabricator.wikimedia.org/T131330#2163833 (Paladox) If you want jenkins to test and merge in gate and submit you... [13:35:39] (CR) Paladox: "Thanks." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 (owner: Paladox) [13:35:50] (CR) Paladox: "check experimental" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 (owner: Paladox) [13:42:25] (PS4) Paladox: Add jshint and jsonlint to npm [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 [13:42:39] (CR) Paladox: "check experimental" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 (owner: Paladox) [14:00:03] (PS1) Paladox: Add package modern-syslog [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280665 [14:00:49] (CR) Paladox: "check experimental" [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280665 (owner: Paladox) [14:07:14] (CR) Paladox: "@Ejegg yesterday at the build 2016 for Microsoft, Microsoft announced Ubuntu is being installed into windows and they will include native " [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277793 (owner: Ejegg) [14:13:41] (CR) Paladox: "check experimental" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277793 (owner: Ejegg) [15:28:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Clean up AdminUI JS use of DOM ready closures - https://phabricator.wikimedia.org/T131360#2164930 (AndyRussG) [15:54:00] Fundraising-Backlog, Hovercards: Avoid z-index conflict with Central Notice and friends - https://phabricator.wikimedia.org/T131364#2165038 (dr0ptp4kt) [16:05:27] Fundraising-Backlog, Hovercards: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2165081 (dr0ptp4kt) [16:23:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2165185 (Jgreen) Open>Resolved sent! [16:24:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Engage User's Civi Certificate Not Working - https://phabricator.wikimedia.org/T131102#2165189 (Jgreen) Open>Resolved sent! [16:30:43] (PS5) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [16:34:02] Fundraising-Backlog, Hovercards: Avoid z-index conflict with HoverCards & Central Notice and friends - https://phabricator.wikimedia.org/T131364#2165197 (dr0ptp4kt) [16:36:18] Fundraising-Backlog, MobileFrontend: Avoid z-index conflict with mobile web link preview & Central Notice and friends - https://phabricator.wikimedia.org/T131372#2165211 (dr0ptp4kt) [16:38:24] Fundraising-Backlog, MobileFrontend: Measure impact of mobile web link preview on Central Notice interaction - https://phabricator.wikimedia.org/T131373#2165223 (dr0ptp4kt) [16:38:42] Fundraising-Backlog, MobileFrontend: Avoid z-index conflict with mobile web link preview & Central Notice and friends - https://phabricator.wikimedia.org/T131372#2165250 (dr0ptp4kt) [16:40:42] Fundraising-Backlog, MobileFrontend: Measure impact of mobile web link preview on Central Notice interaction - https://phabricator.wikimedia.org/T131373#2165255 (dr0ptp4kt) [16:40:44] Fundraising-Backlog, MobileFrontend: Avoid z-index conflict with mobile web link preview & Central Notice and friends - https://phabricator.wikimedia.org/T131372#2165211 (dr0ptp4kt) [16:41:47] Fundraising-Backlog, Hovercards: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2165278 (dr0ptp4kt) [16:41:49] Fundraising-Backlog, Hovercards: Avoid z-index conflict with HoverCards & Central Notice and friends - https://phabricator.wikimedia.org/T131364#2165279 (dr0ptp4kt) [16:46:09] (PS1) Paladox: Update the packages [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280688 [16:48:03] (PS4) Cdentinger: gateway_adapter&loadConfig() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 [16:57:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2165352 (LeanneS) @Jgreen Thank you! [17:08:35] Fundraising-Backlog, Hovercards: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2165397 (dr0ptp4kt) p:Triage>Normal [17:08:54] Fundraising-Backlog, Hovercards: Avoid z-index conflict with HoverCards & Central Notice and friends - https://phabricator.wikimedia.org/T131364#2165398 (dr0ptp4kt) p:Triage>Normal [17:10:34] Fundraising-Backlog, MobileFrontend: Measure impact of mobile web link preview on Central Notice interaction - https://phabricator.wikimedia.org/T131373#2165400 (dr0ptp4kt) p:Triage>Normal [17:12:26] Fundraising-Backlog, MobileFrontend: Avoid z-index conflict with mobile web link preview & Central Notice and friends - https://phabricator.wikimedia.org/T131372#2165422 (dr0ptp4kt) p:Triage>Normal [17:23:30] hey MBeat [17:23:42] what’s up? [17:23:49] i just forwarded you an email i got [17:23:57] i can reply, but i figure you've probably got the right thing to do.... [17:26:02] sure thing. generally you can either fwd anything like this to donate@wikimedia.org, or you if you want to reply, plug in the text of https://collab.wikimedia.org/wiki/Fundraising/Donor_Services_Documentation/Current_English_Macros#Donation_Security::English [17:45:15] (PS2) Cdentinger: Tiny cleanups [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/279072 (owner: Awight) [17:48:26] (CR) Cdentinger: [C: 2] Tiny cleanups [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/279072 (owner: Awight) [17:49:45] (Merged) jenkins-bot: Tiny cleanups [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/279072 (owner: Awight) [17:55:54] (PS1) Ejegg: Remove deprecated parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280696 (https://phabricator.wikimedia.org/T130939) [18:09:43] ejegg: are you worried about any of those deprecated params being hard coded anywhere, like banners? [18:10:01] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2165618 (Ejegg) Looks like 'UnrecordedCharge' is the tag to apply. It ad... [18:10:22] cwd they were [18:10:41] and also, the preferred params were being stuffed with unexpected data [18:11:07] so when I deployed the last patch that looked at the new params first, we confounded a couple dozen dutch would-be donors [18:11:20] heheh [18:11:21] and had to roll back while we tracked down the banner and donation landing page JS [18:11:32] ah yes that's what that was about [18:11:47] but now that we've got those updated, I figure we should remove the legacy stuff while we're thinking about it [18:11:58] good call [18:11:59] and finish cleaning up that JS (it's now sending both sets) [18:12:16] I looked at banners, donate.wm.o, and ways to give [18:12:21] those are all good. [18:12:39] and afaik all of the email links go straight to the donate.wm.o landing page [18:12:59] since we're using that page's stats to track how many emails get opened [18:14:43] (CR) Cdentinger: [C: 2] Remove deprecated parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280696 (https://phabricator.wikimedia.org/T130939) (owner: Ejegg) [18:14:45] dig it [18:15:37] adam approved this yesterday but it needed a gnarly rebase, probably should get new review in case something went wrong https://gerrit.wikimedia.org/r/#/c/278298/ [18:16:16] (Merged) jenkins-bot: Remove deprecated parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280696 (https://phabricator.wikimedia.org/T130939) (owner: Ejegg) [18:16:36] thanks for the CR! taking a look at loadConfig [18:16:55] ty [18:42:28] grrrit-wm seems to be taking a smoke break, but I just merged loadConfig [18:43:05] hehe, thanks! [18:44:37] yeah i agree about pulling those member vars, probably several small improvements we can make based on that patch [18:44:56] there are a _ton_ of other declarative config blocks that could be moved over pretty easily [18:45:19] can't wait! [18:45:51] currency lists seem like the next easiest thing [18:48:57] OK, I'm going to switch over to CRM - Eileen's got approximately a zillion patches waiting for review! [18:49:54] i have looked at a few but it's been forever since i civi'd [18:50:14] yeah, there's a lot to dig into [18:50:42] i hadn't even explored all the nooks and crannies before we updated to 4.6 [18:51:07] ejegg: this is what i used to make all those arrays into yaml: https://gist.github.com/caseydentinger/9a18792a1122f28ea731f30ebf381a64 [18:51:21] and just paste the stuff from the adapter into that class [18:52:02] heh, nice. preeeint it for me, Dumper! [18:52:16] what is the '3'? [18:53:07] hrm it had something to do with how far it will recurse [18:53:16] 3 was the magic number [18:53:19] ah, word [18:53:45] ok, i'm going to take fanny for a jog, she's hyper [19:04:03] Does anyone remember if we're allowed to pull one-liner blocks in MW javascript style? [19:04:12] Don't see it here... https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript [19:04:52] for example: [19:04:52] for (k in o) keyCount++; [19:05:14] hmm, i haven't seen a lot of that [19:05:40] but the benefits don't seem that great [19:05:46] what with minification [19:05:59] Yeah it'd just be ease of reading [19:06:12] But I looked at it and infact it looked uglier rrrrgg [19:06:53] * AndyRussG hears PB burbling [19:07:06] hehe [19:26:43] (PS7) Ejegg: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [19:28:22] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [19:33:57] (PS4) Ejegg: CRM-18134 move api merge activity contact function to the BAO [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [19:35:37] (PS14) Paladox: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:36:02] (CR) Paladox: "Is this ready to drop the WIP tag." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:37:26] (CR) jenkins-bot: [V: -1] [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:40:33] (CR) Ejegg: [C: 2] "API is much more sensible! TODO: update param descriptions now that this mine has been deactivated" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [19:41:21] (PS4) Ejegg: CRM-18106 create activity against contact deleted by merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277449 (https://phabricator.wikimedia.org/T119426) (owner: Eileen) [19:43:16] (PS15) Paladox: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:45:44] (CR) jenkins-bot: [V: -1] [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:48:26] (CR) Paladox: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:51:41] (CR) Paladox: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:53:15] (PS16) Paladox: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:55:16] (CR) jenkins-bot: [V: -1] [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:56:24] (PS1) Paladox: Remove three deprecated modules [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 [20:04:34] AndyRussG: ejegg standup? [20:04:44] dstrine: yep coming :) [20:06:12] (PS6) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [20:06:46] dstrine: oops, coming! [20:07:16] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Using back button from AstroPay lands donor on unusable form - https://phabricator.wikimedia.org/T130673#2165937 (DStrine) a:awight>None [20:12:25] ejegg: do you want us to call you? [20:21:29] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: remove Banco de Chile from CL/BT - https://phabricator.wikimedia.org/T131398#2166044 (DStrine) [20:23:27] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: WebPay as main processor for credit cards CL/BT - https://phabricator.wikimedia.org/T131400#2166089 (DStrine) [20:25:28] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: "go back" (volver) sometimes takes user to the TY page - https://phabricator.wikimedia.org/T131401#2166105 (DStrine) [20:40:23] (CR) Ejegg: [C: 2] "Wow, the magic that transmutes strings into the relevant pseudoconstant ids is pretty well hidden! Seems kind of dastardly to have it hap" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277449 (https://phabricator.wikimedia.org/T119426) (owner: Eileen) [20:57:42] (PS8) Awight: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [20:59:22] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [20:59:42] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: remove Banco de Chile from CL/BT - https://phabricator.wikimedia.org/T131398#2166278 (XenoRyet) a:XenoRyet [21:03:19] (CR) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [21:03:39] (CR) Awight: "This was merged without the line to actually invoke update_7210" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280607 (owner: Eileen) [21:04:20] (PS2) Awight: Enable setting to specify logging is handled offline [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280336 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [21:05:00] (CR) Awight: [C: 2] Enable setting to specify logging is handled offline [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280336 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [21:05:24] (CR) Awight: "PS 2: manual rebase" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280336 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [21:06:54] (Merged) jenkins-bot: Enable setting to specify logging is handled offline [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280336 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [21:07:09] (PS2) Awight: Add hook to define log tables, specifying INNODB & indexing contact fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [21:07:11] (CR) Ejegg: "Doesn't need to invoke 7210 on install 'cos 7200 is also fixed." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280607 (owner: Eileen) [21:07:58] (CR) Awight: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [21:08:16] nick ejegg|mtg [21:15:55] (CR) Awight: [C: 2] "That's a really nice hack! I'm not sure how techs will get alerted of new triggers after a schema change, but that can wait for followup " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [21:16:03] (PS5) Awight: Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [21:17:53] (Merged) jenkins-bot: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [21:18:07] (Merged) jenkins-bot: Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [21:18:09] (PS4) Awight: CRM-18193 add routine for converting log tables to support new log_conn_id format & hook spec [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [21:18:25] (CR) Awight: [C: 2] CRM-18193 add routine for converting log tables to support new log_conn_id format & hook spec [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [21:18:59] (PS2) Awight: Send failmail when TY job can't find contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280580 (https://phabricator.wikimedia.org/T131200) (owner: Ejegg) [21:19:30] (CR) Awight: [C: 2] "Auurgh..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280580 (https://phabricator.wikimedia.org/T131200) (owner: Ejegg) [21:19:42] (PS4) Awight: CRM-18178 exclude _bak & _backup tables from trigger creation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277441 (https://phabricator.wikimedia.org/T131221) (owner: Eileen) [21:19:50] (CR) Awight: [C: 2] CRM-18178 exclude _bak & _backup tables from trigger creation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277441 (https://phabricator.wikimedia.org/T131221) (owner: Eileen) [21:20:02] (PS2) Awight: Shorter selector for .hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280270 (owner: Ejegg) [21:20:13] (Merged) jenkins-bot: CRM-18193 add routine for converting log tables to support new log_conn_id format & hook spec [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [21:20:15] (CR) Awight: [C: 2] Shorter selector for .hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280270 (owner: Ejegg) [21:21:53] (Merged) jenkins-bot: Send failmail when TY job can't find contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280580 (https://phabricator.wikimedia.org/T131200) (owner: Ejegg) [21:22:54] (Merged) jenkins-bot: CRM-18178 exclude _bak & _backup tables from trigger creation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277441 (https://phabricator.wikimedia.org/T131221) (owner: Eileen) [21:22:58] (Merged) jenkins-bot: Shorter selector for .hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280270 (owner: Ejegg) [21:32:26] (PS1) Awight: [WIP] Try to fix missing exchange rate fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280763 [21:34:29] (CR) jenkins-bot: [V: -1] [WIP] Try to fix missing exchange rate fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280763 (owner: Awight) [21:37:56] (PS2) Awight: [WIP] Try to fix missing exchange rate fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280763 [21:40:22] (CR) jenkins-bot: [V: -1] [WIP] Try to fix missing exchange rate fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280763 (owner: Awight) [21:41:45] (CR) Awight: "I agree with @ejegg. However, we should run this tool on the DonationInterface repo, assuming there aren't any crazy contractual issues w" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/272214 (https://phabricator.wikimedia.org/T127608) (owner: Ori.livneh) [21:42:51] (CR) Awight: "@eileen: maybe I fixed the test wrong, but 150000 COP sounds like it did uncover a bug..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280763 (owner: Awight) [21:46:25] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: WebPay as main processor for credit cards CL/BT - https://phabricator.wikimedia.org/T131400#2166385 (XenoRyet) a:XenoRyet [21:47:02] (CR) Awight: Store refund mismatch converted to USD (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen) [21:54:57] (CR) Awight: [C: 2] Prevent notice in logs for custom hide cookie reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) (owner: AndyRussG) [21:55:01] (PS4) Awight: Prevent notice in logs for custom hide cookie reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) (owner: AndyRussG) [21:55:57] awight: thx! [21:56:31] (PS1) Awight: Compress PNGs using zopflipng [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280766 (https://phabricator.wikimedia.org/T127608) [21:56:51] (PS2) Awight: Compress PNGs using zopflipng [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280766 (https://phabricator.wikimedia.org/T127608) [21:59:09] (PS1) Awight: Deprecation notice [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/280767 [21:59:20] (CR) Awight: [C: 2] "Self-merging deprecation notice" [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/280767 (owner: Awight) [22:00:18] (Merged) jenkins-bot: Deprecation notice [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/280767 (owner: Awight) [22:03:00] http://the-toast.net/2016/03/31/beauty-advice-from-an-inspirational-woman/ [22:03:09] nick ejegg [22:03:37] derp [22:06:41] (PS1) Awight: Revert "Deprecation notice" [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/280770 [22:06:56] (CR) Awight: [C: 2] "Self-merging revert of silliness." [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/280770 (owner: Awight) [22:07:40] (Merged) jenkins-bot: Revert "Deprecation notice" [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/280770 (owner: Awight) [22:08:02] (CR) Eileen: "Right - I'm not sure I quite nailed the whole thing - I got stuck on making the exchange rates part work in CI & then wanted to be sure I " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen) [22:08:29] eileen: Hi! Feel free to squash my fixup commit, if it's helpful... [22:08:58] (CR) Awight: [C: 2] "Thank you for that cleanup!" [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/275557 (owner: Paladox) [22:09:02] (PS8) Awight: Add npm entry point [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/275557 (owner: Paladox) [22:09:33] (CR) Eileen: "Nice! That's the bug I was trying to replicate in the other patch!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280763 (owner: Awight) [22:10:21] hehehe glad I could "help" [22:11:15] Fundraising Sprint Ghostbusting , Fundraising-Backlog: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2142353 (awight) a:awight [22:12:34] (CR) Eileen: "Yeah - there should't be too many user actions that cause it - only adding custom fields but we normally do that by code don't we?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [22:13:42] (CR) Awight: "I think the Civi admins and Giant Rabbit occasionally add fields and even tables..." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [22:14:14] eileen: ^ I should also say, often what we do is write a .install field migration after the fact [22:15:02] (CR) Paladox: "Your welcome." [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/275557 (owner: Paladox) [22:15:52] awight: yep - thanks for that test one! [22:16:59] my pending column is looking very short now! [22:17:37] eileen: lmk if I missed anything you need this week [22:17:48] I think the remaining patches have outstanding questions [22:17:59] just checking [22:18:36] There is really just this one left [22:18:37] https://gerrit.wikimedia.org/r/#/c/277934/ [22:19:12] (CR) Eileen: "Patch per deployment not merged" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [22:20:10] (CR) Eileen: "Duh! IS merged" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [22:21:19] I think ejegg was wondering, "Curious how you figured out KEY_BLOCK_SIZE=4 - docs on calculating the minimum are hard to find." [22:21:46] oh yeah.... [22:21:57] awight: she dropped a link [22:22:00] which is just something I took from the discussion on JIRA [22:22:05] ah, k. I can CR that then [22:22:07] into a comment [22:22:23] it might be worth delving further - not sure [22:22:48] but, it seems 'OK' on staging :-) [22:23:05] (PS3) Awight: Add hook to define log tables, specifying INNODB & indexing contact fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [22:23:55] Hmm. I think the fast progress is fantastic, it only makes me nervous when we start talking about mass dedupe of our DB with a somewhat questionable and totally novel recovery mechanism ;) [22:24:15] Do you have ideas for how to prove to ourselves that this is safe? Maybe just burn-in? [22:25:20] well the storage of the data is fairly tested [22:25:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Can we use Ingenico currencies 'Temporarily removed for Wells Fargo' - https://phabricator.wikimedia.org/T131407#2166453 (Ejegg) [22:26:13] the revert action less so - I've started trying to schmooze my wip there - https://github.com/civicrm/civicrm-core/pull/8049/commits/0eb2d3a054c76761291f2d572d415bbb0c34c57a [22:26:26] (note the staging server has my WIP on that side) [22:27:58] (CR) Awight: [C: 2] Add hook to define log tables, specifying INNODB & indexing contact fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [22:28:54] The big issue with the revert that I've not yet covered is reverting multiple automatic merges - ie. do you want to just undo one pair of contacts or the entire merge. I have some thoughts on that. [22:30:54] (Merged) jenkins-bot: Add hook to define log tables, specifying INNODB & indexing contact fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [22:36:48] (PS1) Ejegg: Move currencies to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280776 [22:40:16] (CR) Awight: [C: 2] "I love this stuff! Thanks for preserving the comments, btw..." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280776 (owner: Ejegg) [22:40:46] thanks awight! [22:41:36] ejegg: please do see my comment at AstroPay getCurrencies, though... [22:41:44] (Merged) jenkins-bot: Move currencies to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280776 (owner: Ejegg) [22:41:54] looking [22:42:26] ejegg: awesome, did you use the yaml dumper? [22:42:36] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2166552 (Eileenmcnaughton) @awight has provided a fi... [22:42:37] looks more like a vim job ;) [22:42:49] cwd no, just 'cause I wanted to leave comments in [22:43:26] ah yeah, if the list isn't massive or too nested it's not too bad to do by hand [22:43:57] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Improve the change log report - https://phabricator.wikimedia.org/T130164#2166571 (Eileenmcnaughton) Revert changes here https://github.com/civicrm/civicr... [22:44:00] awight: the selection in astropay isn't unstaging, it's filtering on the data provided [22:44:36] ejegg: oooh thanks for pointing that out [22:44:46] I should not have the car keys... [22:44:50] hehe [22:45:04] (CR) Awight: Move currencies to config (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280776 (owner: Ejegg) [22:50:28] the-wub: Hey, yt? [22:51:35] awight: You might know this, too. [22:51:45] K4-713: hey [22:52:13] (CR) Awight: Add npm entry point [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/275557 (owner: Paladox) [22:52:19] (CR) Awight: [C: 2] Add npm entry point [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/275557 (owner: Paladox) [22:53:05] (Merged) jenkins-bot: Add npm entry point [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/275557 (owner: Paladox) [22:53:23] awight: Do you know where the public conversion rate data is, for individual campaigns? [22:53:48] This... may be a trick question. [22:54:42] * awight squnits at http://frdata.wikimedia.org/ [22:54:58] Does that have banner data in there? [22:55:15] K4-713: I don't think we have anything public, unless it's on frdata [22:55:20] Bwah [22:55:28] Take a look at http://frdata.wikimedia.org/campaign-vs-amount.csv [22:56:00] It doesn't have conversion rate... close but no. [22:56:03] Not hard to add, if we decide that can be public. [22:57:27] back in a few [22:57:30] It would be neat if it was... [22:57:39] Fundraising Sprint Ghostbusting , Fundraising-Backlog: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2166590 (awight) I was able to reproduce this locally, it's exactly as @CCogdill_WMF describes it. Once two contacts with different emails are merged, the new email... [22:58:08] K4|meeting: Do we have a process for reviewing variables that we want to take public? [23:01:59] Fundraising-Backlog: Review campaign conversion rate for public release - https://phabricator.wikimedia.org/T131413#2166606 (awight) [23:07:18] awight: whoa! where did that come from? http://frdata.wikimedia.org/ [23:07:37] AndyRussG: there's a nightly job that compiles that data... [23:07:44] Has that always been there? [23:07:49] Yah, for 3 years maybe [23:08:06] d'oh! /me facepalms [23:08:08] We planned to put a lot more stuff there, but the issues around leaking information about donors when sample sizes are small... get tricky [23:08:18] right... [23:08:27] Also, there is some other country-related stuff that becomes intra-political. [23:08:33] mmmmm [23:10:01] awight: my view is just get it out :) [23:11:43] awight: maybe this needs a jiggle? https://gerrit.wikimedia.org/r/#/c/257811/ [23:12:20] (PS1) Ejegg: Move var_map to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280783 [23:13:28] Seddon: I'd like to, but we try not to pants people without at least warning them first :p [23:13:50] awight: pants people? [23:15:18] Seddon: search "pantsing" [23:18:55] ejegg: thanks for bashing out all this yaml! love it [23:22:08] * awight chuckles about the next step, where we have declarative files describing which payment processors to use and their capabilities, etc. [23:22:11] thanks for enabling! [23:23:12] i think i actually really like modsecurity [23:23:49] it is arcane like only software hanging on to DSLs from the 90s can be [23:25:45] (PS1) Awight: is_deleted is another way to opt out ;) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) [23:26:04] ejegg: ^ ! [23:26:23] ooh [23:28:29] ejegg: I find it really hard to reason about that script... [23:28:36] (CR) Ejegg: "I think this will exclude any merged contacts since they'll have a deleted doppelganger with the same email" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) (owner: Awight) [23:28:42] yep... [23:28:57] burble... [23:29:09] :S [23:31:34] (CR) Awight: "confirmed. Okay, going for the slightly less easy patch now..." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) (owner: Awight) [23:48:41] (PS2) Ejegg: Move var_map to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280783 [23:56:52] (PS1) Ejegg: Move data constraints to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280790 [23:59:24] OK, I'm signing off for the evening. See you all tomorrow!