[00:01:34] (PS2) Awight: is_deleted is another way to opt out ;) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) [00:01:41] bubye! [00:14:26] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2166799 (CCogdill_WMF) Love the is_deleted rule, that makes a lot of sense to me. Thanks! Le jeudi 31 mars 2016, awight Fundraising-Backlog, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2166998 (awight) [05:27:58] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2167010 (awight) p:Triage>High [05:39:47] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2167015 (awight) [14:09:11] (CR) Florianschmidtwelzow: "Removing myself" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [14:21:35] Fundraising-Backlog, FR-Adyen: Fix: Adyen refund capacity for Japan - https://phabricator.wikimedia.org/T131507#2169032 (MBeat33) [17:16:42] (CR) Ejegg: [C: 1] "These were deprecated almost a year ago. I'd say any cached HTML should be long gone" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [17:18:26] (PS3) Ejegg: Compress PNGs using zopflipng [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280766 (https://phabricator.wikimedia.org/T127608) (owner: Awight) [17:19:16] (CR) Ejegg: [C: 2] "Looks like they all came through identical. That Yandex logo is huge!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280766 (https://phabricator.wikimedia.org/T127608) (owner: Awight) [17:24:09] (Merged) jenkins-bot: Compress PNGs using zopflipng [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280766 (https://phabricator.wikimedia.org/T127608) (owner: Awight) [17:41:56] (CR) Ejegg: [C: 1] "Looks correct. Suggested a possible speed up inline." (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) (owner: Awight) [17:50:48] (CR) Ejegg: [C: -1] "Thanks! Let's also exclude src/bower_modules/**/*.js and dist/**/*.js from checks (see gulpfile.js)" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 (owner: Paladox) [17:54:43] (PS1) XenoRyet: Astropay: remove Banco de Chile from CL/BT [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280949 (https://phabricator.wikimedia.org/T131398) [17:55:19] (CR) AndyRussG: [C: -2] "Removing a bunch of modules has been planned for a while, as a follow-up to last year's refactoring of CentralNotice client code. Sadly, w" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [17:58:00] (CR) Ejegg: [C: 2] "*poof*" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280949 (https://phabricator.wikimedia.org/T131398) (owner: XenoRyet) [17:59:37] (Merged) jenkins-bot: Astropay: remove Banco de Chile from CL/BT [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280949 (https://phabricator.wikimedia.org/T131398) (owner: XenoRyet) [18:00:15] Thanks ejegg. Got to it before it even made it to the review column. :) [18:00:57] (CR) AndyRussG: "Ooops!! I was confusing bannerController.mobile and bannerController.mobiledevice. These should be OK to remove then, in theory!! Just let" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [18:11:36] (PS1) XenoRyet: Astropay: WebPay as main processor for credit cards CL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280953 (https://phabricator.wikimedia.org/T131400) [18:12:31] (Abandoned) Reedy: Revert "Compress PNGs with zopflipng" [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/275555 (owner: Paladox) [18:13:24] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Using back button from AstroPay lands donor on unusable form - https://phabricator.wikimedia.org/T130673#2169831 (XenoRyet) a:XenoRyet [18:53:45] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: "go back" (volver) sometimes takes user to the TY page - https://phabricator.wikimedia.org/T131401#2166105 (Ejegg) This is a longstanding problem that needs a fix from AstroPay. The donor comes back to the result... [19:02:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2170105 (DStrine) @CaitVirtue and I just hashed this out. Please see below: * Rating: number or dropdown (what values?) ** TBD @MBrent and @CaitVirtue * Ask Amount: money (in USD?) ** yes *... [19:03:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2170112 (DStrine) [19:05:17] (PS2) Ejegg: Astropay: WebPay as main processor for credit cards CL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280953 (https://phabricator.wikimedia.org/T131400) (owner: XenoRyet) [19:05:30] (CR) Ejegg: [C: 2] Astropay: WebPay as main processor for credit cards CL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280953 (https://phabricator.wikimedia.org/T131400) (owner: XenoRyet) [19:11:43] (Merged) jenkins-bot: Astropay: WebPay as main processor for credit cards CL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280953 (https://phabricator.wikimedia.org/T131400) (owner: XenoRyet) [19:45:59] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2166998 (Ejegg) A bunch of files are stuck on some ancient BPAY transaction that the donor keeps trying to reuse. @MBeat33 is reachin... [19:46:10] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2170254 (Ejegg) a:Ejegg [20:04:23] computer does not want to join hangout for some reason [20:56:13] (PS1) Ejegg: Random cleanups [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281036 [20:58:21] hey MBeat did you respond to that guy who emailed me? [20:59:11] I wasn’t sure which if you wanted to take it, but I’ll fwd it to Zendek now, atgomez [21:00:11] (PS7) Ejegg: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [21:00:35] (CR) Ejegg: "PS7: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [21:01:43] (CR) jenkins-bot: [V: -1] Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [21:04:00] oh eoither way, just checking in before i respond [21:04:03] MBeat: [21:04:05] ^ [21:04:16] like not sure if oyu have some messaging you prefer [21:04:23] yes, that’s all set atgomez [21:04:55] you can fwd anything like to to donate@wmf [21:05:50] awesome, thanks! [21:06:04] np [21:10:15] (PS8) Ejegg: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [21:10:30] cwd I think that should pass tests ^^ [21:10:47] groovy [21:10:49] going to move the currencies to config in a new patch [21:10:54] :D [21:11:19] do i need a visa to go to italy? what is the difference between a visa and a passport? [21:11:35] no visa needed [21:11:39] ty [21:11:47] a visa is like permission from the country you want to visit [21:12:10] aah [21:12:14] i am not a savvy traveler :P [21:12:19] for europe, you mostly only need one if you're going to stay for mre than a few months [21:12:27] right on [21:12:35] my passport is expired but luckily the form didn't care [21:12:43] but i better get that ball rolling [21:13:06] ooh, yah [21:17:16] (PS9) Ejegg: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [21:17:38] cwd: https://travel.state.gov/content/passports/en/country/italy.html [21:18:27] ty atgomez [21:18:50] "blank pages on passport required" [21:18:55] what a strange future we live in [21:20:15] (PS1) Ejegg: Move Worldpay currencies to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281043 [21:38:09] (CR) Ejegg: "looks really good! One suggestion inline." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [21:38:25] gotta relocate - back soon! [22:00:59] (CR) Cdentinger: "Couple mostly unimportant comments. Also the hhvm test is hollering about "Undefined index: copyright" for some reason." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [22:24:34] (CR) Ejegg: "Sorry, I undid your lookup building in the latest PS since the staging helper couldn't see the array. I guess we could have it add the lo" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [22:37:53] (CR) AndyRussG: "Thanks much!!!! :)" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [22:38:47] ejegg: cwd: XenoRyet: hi! [22:39:00] (CR) Ejegg: "Copyright thing is failing because of I63cdc0a7fd51ca3a45dc2fd83b22eb58a8de520c . I'll see about setting that global." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [22:39:03] Howdy [22:39:07] Hi AndyRussG [22:39:39] yo [22:40:03] Any thoughts on DI review or tasks I might pick up? [22:41:22] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org (and all other email.donate.*?) from DNS - https://phabricator.wikimedia.org/T130414#2170841 (Dzahn) @CCogdill_WMF Sorry, i didn't get to this yet and now it's Friday again and i will b... [22:41:31] I don't have anything in review right now, so I'm no help there. [22:41:47] Ah K thx [22:42:03] ejegg: maybe we should give the staging helpers access to the config array somehow [22:42:11] seems like they should know about it? [22:42:14] cwd see the next commit! [22:42:42] nice [22:42:53] yeah i like that [22:42:57] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org (and all other email.donate.*?) from DNS - https://phabricator.wikimedia.org/T130414#2170843 (CCogdill_WMF) No problem, thanks for keeping me updated @Dzahn. Have a nice vacation! [22:43:50] cwd I'll do one more followon commit to restore the lookup table in config and use it in the staging helper [22:45:08] AndyRussG: maybe this one? https://phabricator.wikimedia.org/T131181 [22:48:52] (CR) Cdentinger: [C: 2] Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [22:56:48] (Merged) jenkins-bot: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [23:03:51] gotta go get the dog, back in a bit [23:06:55] ejegg: ah K cool, thx! [23:15:39] (PS1) Ejegg: Restore lookup table for WP submethod api name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281052 [23:19:36] (PS1) Ejegg: Use generalized lookup table builder for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054 [23:19:57] (CR) Ejegg: "Alternate solution: Ia62e10361d9b80534c23a5549013ac8f1dd6e0fa" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281052 (owner: Ejegg) [23:21:17] (PS2) Ejegg: Use generalized lookup table builder for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054 [23:28:23] seeya all. Have a good weekend [23:29:18] dstrine-away: cya! [23:29:31] (CR) Awight: Encapsulate Worldpay staging logic (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [23:30:01] ejegg: what is " ZD #215861" in https://phabricator.wikimedia.org/T131181? Is it a ticket? [23:34:05] Also, do I need some additional test creds to test iDEAL? I have general stuff for GlobalCollect [23:49:26] Fundraising-Backlog, FR-Adyen: Fix: Adyen refund capacity for Japan - https://phabricator.wikimedia.org/T131507#2171016 (MBeat33) Open>Resolved a:MBeat33 The PSP says this will be fixed by the end of the day. [23:58:12] (PS1) Awight: Rename config loading function to reflect its increased responsibilities [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281061 [23:58:14] (PS1) Awight: Default function defines data transformers from config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281062 [23:58:16] (PS1) Awight: Move data transformers to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281063 [23:58:51] (CR) jenkins-bot: [V: -1] Rename config loading function to reflect its increased responsibilities [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281061 (owner: Awight) [23:59:01] (CR) jenkins-bot: [V: -1] Default function defines data transformers from config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281062 (owner: Awight) [23:59:13] (CR) jenkins-bot: [V: -1] Move data transformers to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281063 (owner: Awight)