[12:53:07] fundraising-tech-ops, Operations, Traffic, Patch-For-Review: Decide what to do with *.donate.wikimedia.org subdomain + TLS - https://phabricator.wikimedia.org/T102827#2177434 (BBlack) Note this should get resolved via T130414 's https://gerrit.wikimedia.org/r/#/c/278353 [15:10:39] Fundraising-Backlog: Mobile donation form: error entering valid email address - https://phabricator.wikimedia.org/T131323#2177769 (MBeat33) p:Normal>High The donor in the screenshot is in Zendesk #217303, they used a Samsung S5 Neo with Firefox; we're also following up with the donor in #217369. Both s... [15:10:57] Fundraising-Backlog: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2177771 (MBeat33) [15:44:44] (PS1) Ejegg: Change MX dummy fiscal number to 13 digits [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281458 [15:45:42] (PS1) Ejegg: Add another method to GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281459 [16:01:05] (CR) Awight: "I'm not opposed to the method, but shouldn't we be pulling that data directly from the normalized array fed to the staging function?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281459 (owner: Ejegg) [16:09:30] (PS1) Awight: Rename $unstaged variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281461 [16:20:42] (CR) Awight: [C: 2] "More correct! Note the question about usage, though. Where should we draw the line between adapter-provided data and normalized donation" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281459 (owner: Ejegg) [16:22:01] (Merged) jenkins-bot: Add another method to GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281459 (owner: Ejegg) [16:25:33] (PS2) Awight: Change MX dummy fiscal number to 13 digits [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281458 (owner: Ejegg) [16:25:43] (CR) Awight: [C: 2] Change MX dummy fiscal number to 13 digits [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281458 (owner: Ejegg) [16:27:02] (Merged) jenkins-bot: Change MX dummy fiscal number to 13 digits [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281458 (owner: Ejegg) [16:46:37] RIP iceweasel! Ohnoes! [16:48:13] didn't they bury the hatchet about that? [16:54:20] Fundraising-Backlog: Write unit tests for the Silverpop export script - https://phabricator.wikimedia.org/T131770#2178199 (awight) [16:57:10] (CR) Awight: is_deleted is another way to opt out ;) (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) (owner: Awight) [17:18:39] cwd: yeah they did! just hit the Debian repo, or my laptop, today [17:19:11] After so many great times w/ Iceweasel now I feel sad [17:19:25] hehe [17:19:33] what was it all about? nonfree images or something? [17:28:41] hey awight are you in the office today? is dstrine here? :) [17:28:52] oh hey dstrine! for some reason my direct messages to you aren't working. [17:29:26] atgomez: I'm at home today, sorry! [17:29:32] no worries! i found him [17:32:01] Fundraising Sprint Ghostbusting , Fundraising-Backlog: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2178462 (AndyRussG) a:AndyRussG [17:35:48] eergh, libc is segfaulting. Reboot sequence initiated, wish me luck! [17:38:16] Ha. Civi can cause the segfault all day, it turns out--completely kills the hhvm service, even! [17:40:50] Maybe I need to sacrifice some RAM lambs? [17:46:25] phab appears down again...poor computer [17:47:04] That machine has seen things you wouldn't believe. [17:47:18] time to die... [17:48:14] (PS1) Ejegg: Only scream about missing parents for negative txns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281478 [17:49:29] (PS1) Ejegg: Fix some PHPDoc comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 [18:13:34] Fundraising Tech Backlog: please do a round of activemq cleanup - https://phabricator.wikimedia.org/T131787#2178536 (Jgreen) [18:13:45] cwd: awight yeah, https://phabricator.wikimedia.org/T131742 tl;dr: machine got hot hot, had to reapply thermal paste [18:13:50] apologies :) [18:14:13] That's hella real [18:14:34] i was just laughing about that [18:14:46] pretty awesome [18:15:00] heh,wow [18:15:02] phabricator comes crashing into the physical world [18:15:34] no icinga alerts from the temperature sensors though [18:15:36] * Krenair runs [18:21:13] This again... - wikimedia/donation-interface dev-master requires amzn/login-and-pay-with-amazon-sdk-php dev-master -> no matching package found. [18:21:33] awight: did your 'run composer' patch ever get merged? [18:21:49] oh wait, that's not in CI, is it? [18:21:56] let me see if I get the same [18:22:07] This is just locally... [18:22:13] awight: is that in crm? [18:22:16] yeah [18:22:24] might need the repo defined [18:22:25] ran into it last week, too, but I don't remember how I resolved it. [18:22:29] lemme see [18:22:54] It's been a bad morning for installing the crm repo... [18:22:57] Yep, I'll put a patch in a sec [18:23:17] My hhvm service dies immediately upon touching any Civi .php [18:23:29] with a segfault and empty stack traces! [18:23:37] thanks! [18:24:17] hehe, I vaguely remember just butchering the amnz dependency out of my vendor/**/composer.json [18:27:19] weird... Removal request for amzn/login-and-pay-with-amazon-sdk-php == 9999999-dev [18:28:49] oh, stability setting too, I think [18:29:38] derp... maybe if I list it explicityly in the 'require' ? [18:31:10] Of crm? [18:32:03] I see what you mean, now. It's coming from your forked repo, and that setting doesn't carry over to the parent repo? [18:32:13] err s/parent/crm/ [18:34:23] apparently not [18:35:24] Are we without K4 today? Indeed it'd be very house-moving-understandable... [18:36:22] (PS1) Ejegg: Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281485 [18:36:38] awight: that's a big leap for some packages ^^ [18:37:06] (CR) jenkins-bot: [V: -1] Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281485 (owner: Ejegg) [18:37:25] AndyRussG: She's around, no IRC though. Have to get her through gchat. [18:37:32] oh, we have require-dev checked into .lock... [18:37:56] XenoRyet: ah K great, thx :) [18:38:10] ejegg: good catch! [18:38:28] (PS2) Ejegg: Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281485 [18:38:53] awight: hmm, we should make this happen: https://gerrit.wikimedia.org/r/280125 [18:39:26] not that anything in crm uses the amazon adapter [18:40:07] but as of that ps, it's got incompatible amazon adapter & DI [18:40:20] (CR) jenkins-bot: [V: -1] Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281485 (owner: Ejegg) [18:40:27] hmph, I need to lobby harder for merge, or just start versioning my fork [18:40:38] Same with PHP-Queue... [18:41:12] I'd be happy to even rework my changes to make them more palatable [18:41:19] ah crap, some mediawiki dependent stuff made it onto the critical path [18:41:34] hmm? like backport troubles? [18:41:44] ooh, RequestContext, of course [18:41:56] damn, I wasn't thinking about crm at all when I did that refactor [18:41:57] (PS6) Awight: Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 [18:42:06] (CR) Awight: [C: 2] Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [18:42:24] oops, shall I un-submit? [18:42:33] nah, that one is fine [18:43:03] We just need to fix a bunch of DI to be usable under CRM again :( [18:43:36] $this->context = RequestContext::getMain(); [18:43:47] It's a dangerous game we're playing... we should really move any platform-independent code out of DI entirely. [18:44:06] yah, that's the goal, right? [18:44:38] ah cripes, this is gonna be a pain [18:46:04] well, let's see [18:47:28] hmm, i kinda want to deploy DI before we mess around any further [18:47:36] any objections? [18:47:38] ejegg: Is this a patch that's already merged? I don't see anything [18:47:43] ejegg: please do [18:48:02] awight: it's all that RequestContext and session stuff I did a month or two back [18:48:21] didn't add any new wrappers to WmfFramework :( [18:48:36] OK, lemme deploy and then I'll figure out what to do [18:49:25] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281487 [18:50:00] It's silly and mostly wasteful, but we can add the crm CI job to the DI pipeline, in the future... [18:50:03] any bets on need for revert? [18:50:19] aieee, gon b a big one [18:50:19] hehe, /me thumbs through race listings [18:50:38] (CR) Ejegg: [C: 2 V: 2] "here goes nuthin!" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281487 (owner: Ejegg) [18:50:49] Anyone know why legoktm was reverting the zopfligpng patches? [18:51:17] awight: yours, not the vendor one? [18:51:54] not mine, but in other repos... [18:53:24] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281489 [18:53:45] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281489 (owner: Ejegg) [18:53:49] (Merged) jenkins-bot: Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [18:55:12] no config changes needed for this deploy, right? [18:55:43] don't believe so [18:55:51] cool [18:59:38] !log updated payments-wiki from a9659965d8b55b11518680a1170242f311c7f1d2 to eac5f979099056ef142500570555771dfb1992c1 [18:59:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:01:20] so far, so good [19:01:25] not seeing much in errors [19:01:28] i was able to give $1 [19:01:32] through gc [19:01:36] yay! [19:02:05] amazon and paypal are redirecting ok [19:04:12] ty mail from jimmy again heheh [19:04:35] Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay: Astropay: 13 digit number will hide the fiscal number in mexico - https://phabricator.wikimedia.org/T131793#2178716 (DStrine) [19:04:42] Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay: Astropay: 13 digit number will hide the fiscal number in mexico - https://phabricator.wikimedia.org/T131793#2178728 (DStrine) p:Triage>High [19:05:12] (PS1) Awight: Python requirements file for installing dependencies [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/281491 [19:12:24] what do you think of dumping the DI/vendor submodule in favor of our core branch pointing to a vendor submodule with core + di dependencies? [19:12:32] hashar suggested it https://phabricator.wikimedia.org/T131264#2178710 [19:13:03] ejegg: +1 [19:13:20] I do worry about human error during deployment, though... [19:13:47] yeah, and no tests on the deploy branch... [19:14:06] That would make the DI change and vendor change even further away on the keyboard [19:14:13] gah [19:14:21] straitjacketed [19:14:21] loading all deps into one vendor? sounds interesting... [19:14:38] someone was looking into composer-merge-plugin, too? [19:14:51] ah, i should investigate that [19:14:53] ah yeah, i think that's purpose built for this no? [19:15:02] * awight curses that this is composer's entire job [19:15:22] heh [19:15:34] i would worry a little about merging cross project deps [19:15:44] Use case: Find the dependencies--oh, except when they're two levels deep. [19:16:09] to be fair does _anything_ actually do this properly? [19:16:30] "properly" might be too strong ;) [19:17:17] awight: Isn't the end goal to have the extensions actually be installable via composer? [19:17:19] i've never used a package manager that didn't at some point make me want to stab [19:17:32] that would make it do its job [19:17:44] ejegg: I donno, actually... [19:19:08] Seems like there should be a flag in composer.json which would do something similar to "repositories", but would let us take responsibility for provisioning a code directory and only asking composer to load dependencies. [19:19:17] meh [19:19:47] I'm so many rabbitholes in for the morning... [19:20:32] Writing mw-vagrant patches to provision fr-tools cos I can't keep hhvm alive on bare metal. [19:20:39] Plus there are yellowjackets. [19:20:58] damn, CL bank transfer erroring out [19:21:23] illegal offset type, huh [19:26:14] (PS3) Awight: is_deleted is another way to opt out ;) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) [19:26:42] ejegg: ^ That's ready for review again, thanks for the HAVING suggestion! [19:27:25] rockin! [19:27:39] just going to dig into this astropay thing a bit more [19:28:04] grr, totally not happening locally [19:28:34] ooh, oops, there it is [19:29:29] nice! [19:29:46] weird, how was this not an issue till now? [19:29:51] (CR) Awight: [V: 1] "Tested and works locally." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) (owner: Awight) [19:30:18] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay: Astropay: 13 digit number will hide the fiscal number in mexico - https://phabricator.wikimedia.org/T131793#2178772 (DStrine) [19:32:43] the code on donatewiki is FundraiserLandingPage right? [19:33:02] cwd: No, it's only onwiki, no RCS [19:33:08] ugh, that group array is not a long term viable solution [19:33:32] I think I need to split the webpay submethods [19:33:50] If you ever need a finger puppet to talk to about payment sub sub methods, call me up... [19:34:14] it's just a single astropay code that handles both bt and cc [19:34:14] awight: sorry what's RCS? [19:34:26] cwd: Revision control system [19:34:43] heh, besides the wiki history of course [19:34:47] There are probably a hundred abbreviations for the same thing, sorry [19:35:12] :) very true [19:35:42] oh, uhm...i'm looking for whatever inserts that first contribution tracking row [19:35:45] isn't that on donate? [19:35:58] cwd not any more [19:36:12] that only happens when they hit our form [19:36:39] cwd: (The referer is sent as part of the initial request from donatewiki js to the paymentswiki form) [19:37:12] somehow... maybe from banner js and not from donatewiki js at the moment :( [19:37:48] nuts [19:38:01] i was hoping to just save it there [19:38:13] i see it in the "paypalcontribution" hidden form on donate [19:38:36] but it lost the scent there [19:39:16] *i [19:40:09] Not finding it, myself... feel free to document this once the donkey tail is firmly affixed! [19:42:22] (PS1) Ejegg: Quit letting a submethod be in multiple groups [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281496 [19:42:55] * awight grimaces at banner templates coming from FR2013, FR2014, and FR2015 paths... [19:43:58] oh hey, I can finish cleaning up the banner / donate JS now [19:44:08] The form html https://meta.wikimedia.org/w/index.php?title=MediaWiki:FR2013/Resources/DropdownFormHtml has a hidden input for referrer... [19:46:57] err... crap. just noticing payments.error invalid ffnames with "payment_method":"cc","payment_submethod":"rtbt_ideal" [19:47:37] * awight braces for rollback [19:47:40] hmm yeah [19:48:44] !log rolled payments-wiki back to a9659965d8b55b11518680a1170242f311c7f1d2 [19:48:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:48:55] ok, let's see what that banner's sending [19:49:12] cwd: I think we'd need the-wub to help track down all the places we send referrer. [19:49:18] https://en.wikipedia.org/wiki/Main_Page?banner=B1516_0404_nlNL_dsk_p2_sm_txt_cnt [19:49:27] Maybe disabling the rule is the best workaround for now ... [19:49:47] You mean https://en.wikipedia.org/wiki/Main_Page?banner=B1516_0404_nlNL_dsk_p2_sm_txt_cnt&country=NL ? [19:50:26] ejegg: That banner actually gave me "payment_method=" [19:50:37] so "cc" must have come from your session... [19:50:48] awight: what's the problem with referrer? [19:50:55] wasn't my session... [19:50:58] default? [19:51:18] yeah that's easy enough, there is some ambiguity about what our actual obligation to this firewall is. how many rules can we turn off before we lose the compliance points? [19:51:32] ooh, weird, setting payment_method=rtbt on params, but '' in POST [19:51:43] the-wub: We've been tweaking some firewall rules, and one of the biggest false positives is caused by us embedding the "https://" URL into the query [19:51:51] the-wub: our firewall complains about any params with a protocol string at the beginning [19:52:02] because it looks like a cross domain resource request [19:52:21] cwd: maybe tweak the rule to allow the protocol. then? [19:52:24] kind of a silly heuristic imo but it's in the owasp ruleset [19:52:44] awight: well that's the whole rule so we may as well just disable it [19:52:47] I don't know of any requirements for how many of the rules we actually use! [19:52:50] k [19:53:09] awight: ah okay. I don't think we send referrers from banners though. we do from donatewiki (in fact I was just looking at that earlier today) [19:53:46] the-wub: if we just stripped the protocol string off on donate, that would satisfy modsecurity [19:54:05] afaik it just gets dumped into contribution_tracking right? [19:54:14] so we'd just have to inform anything consuming that data of the change [19:55:09] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: "go back" (volver) sometimes takes user to the TY page - https://phabricator.wikimedia.org/T131401#2178812 (awight) a:Ejegg [19:55:21] cwd, that sounds good to me. afaik we don't ever really use that data in production. I assumed it was for fraud investigation [19:55:51] ^ That's my understanding as well [19:56:00] great [19:56:26] the-wub: is that your territory? awight informed me that donate is not in git? [19:57:09] cwd: haha, it probably should be. but it's a wiki. I can change that now if you like? [19:57:26] hehehe [19:57:29] wat! [19:57:31] that would be great! we can see if anything blows up [19:58:28] I feel like I just witnessed a crime ;) [19:59:11] hehe [19:59:17] (CR) Awight: [C: 2] "TODO: refactor payment method stuff entirely." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281496 (owner: Ejegg) [20:01:14] (Merged) jenkins-bot: Quit letting a submethod be in multiple groups [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281496 (owner: Ejegg) [20:03:33] the-wub: our banner js hackery the other day wasn't quite complete - we should have also set form.payment_method.value on line 129 of https://meta.wikimedia.org/w/index.php?title=MediaWiki:FR2013/Resources/BannerFormCore.js [20:03:57] hmm, actually, it would be great if that wasn't duplicated on params + post [20:03:57] cwd: okay, referrer change is done [20:04:32] oops, standup. sorry, let me ponder the post parameters for a bit [20:04:36] ejegg: yeah. weirdly enough I was actually looking into clearing up that whole params/post mess today as well [20:04:43] woohoo! [20:05:27] the-wub: thank you! [20:06:34] the-wub: you can totally drop paymentmethod and submethod in favor of payment_method and payment_submethod now, if you like [20:07:03] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: "go back" (volver) sometimes takes user to the TY page - https://phabricator.wikimedia.org/T131401#2178842 (awight) a:Ejegg>XenoRyet [20:10:42] ejegg: really? from looking at GatewayFormChooser.php earlier I thought it was the other way around. or is that not used any more? [20:11:10] the-wub: we recently updated that to prefer payment_method and payment_submethod [20:11:28] then the stuff we tried to deploy today totally removed paymentmethod and submethd [20:12:57] we're just trying to standardize on the variable names we use internally [20:13:42] ah okay thanks ejegg. so the values I should be passing are: country, currency, payment_method, payment_submethod, recurring, gateway - correct? [20:13:54] (plus all the utm_* stuff) [20:14:35] lessee [20:15:38] the_wub currency_code instead of currency would be great [20:17:08] and you can still pass ffname when you want [20:18:15] ejegg: thanks [20:18:22] thank you! [20:18:58] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Astropay: "go back" (volver) sometimes takes user to the TY page - https://phabricator.wikimedia.org/T131401#2178864 (XenoRyet) a:XenoRyet>Ejegg [20:35:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Latest DonationInterface unusable under CRM - https://phabricator.wikimedia.org/T131798#2178881 (Ejegg) [20:43:11] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2178927 (awight) [20:45:35] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2178928 (awight) [20:45:42] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2178928 (awight) p:Normal>High [20:47:29] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2178965 (awight) [20:48:45] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Debug gateway account name handling - https://phabricator.wikimedia.org/T130852#2178967 (awight) [20:49:46] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2178969 (awight) [20:49:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change JPMorgan Import Field Values - https://phabricator.wikimedia.org/T131802#2178970 (LeanneS) [20:51:22] ejegg awight: hmmm... I just noticed I'm only ever getting visa and mastercard on the GC cc forms (before making any changes to my code as well) [20:51:25] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2178991 (awight) [20:51:27] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#2178990 (awight) [20:51:40] in the UK should have all 4 cc types [20:51:44] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#995314 (awight) [20:51:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#1918986 (awight) [20:52:33] awight ejegg : oh hang on false alarm. tried in an incognito window and it was fine. [20:52:38] sorry! [20:54:29] the-wub: no worries, please let me know if anything else looks wrong! [20:55:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2179018 (awight) [20:55:22] the-wub: i am still seeing a pretty good amount of the NL referer, but i can confirm when i go to donate i see it without the protocol. could it be getting set in a banner? [20:56:01] cwd could be cached, could be ppl who left a browser window open [20:56:02] cwd: can you tell what the utm_source is? [20:56:25] lemme see... [20:56:38] nah i don't see that much info [20:56:39] oh hey, might be cool if the utm_source included a revision # for the banner... [20:56:56] oh, but that wouldn't tell us about all the dependency scripts [20:57:07] these logs are pretty sparse and i don't think there's anything to correlate with others [20:57:41] maybe they will just throttle down though [20:58:40] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2179042 (awight) [20:59:39] ejegg: not a bad idea. but I'm wary of cramming yet more info into the utm_source [21:00:21] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Get Express Checkout test credentials - https://phabricator.wikimedia.org/T131805#2179043 (awight) [21:00:51] the-wub: yeah, let's not for now [21:01:39] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2179067 (awight) [21:02:00] cwd confirmed the expiration job is not clearing pending paypal recurring [21:02:26] added the settings to the table on https://www.mediawiki.org/wiki/Fundraising_tech/Message_queues#Components [21:03:26] the-wub: are you also updating the donatewiki js, or should I tackle that? [21:03:41] nice [21:03:44] that page is getting awesome [21:04:05] ejegg: I'll do that when I'm finished with the banner. they're actually quite similar [21:04:12] thanks the-wub ! [21:04:46] cwd definitely! thanks again for your documentary zeal awight [21:06:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Get Express Checkout test credentials - https://phabricator.wikimedia.org/T131805#2179092 (awight) The documentation mentions that, ``` In the Sandbox, you can always use the following signature:... [21:07:50] ejegg: here's a banner that ditches all the params and only sends stuff via POST with the new names. https://nl.wikipedia.org/?banner=B1516_0202_mlWW_dsk_p1_lg_sandbox&force=1&country=NL [21:07:53] not sure if it's actually better to use POST or GET here though. maybe GET since there's nothing sensitive? [21:08:18] the-wub: either way is fine by me! [21:08:19] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout transactions and data transformations - https://phabricator.wikimedia.org/T131807#2179093 (awight) [21:08:26] hmm, GET is easier to debug though [21:08:48] if it's not too big a hassle to switch [21:09:44] ejegg: that's what I thought too. and it's easy to change, just never did because we've always used post before [21:09:46] the-wub: form looks good, redirects perfectly [21:10:03] oh, just noticed it's got utm_key='' and utm_key='0' [21:10:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout controller - https://phabricator.wikimedia.org/T131808#2179108 (awight) [21:10:46] also, if frequency [21:11:18] is frequency=onetime a synonym for recurring=0? [21:11:43] I don't think the form chooser has ever looked at 'frequency', but let me check [21:13:23] confirmed we don't look at 'frequency' [21:16:14] ejegg: no, frequency is just what it's called in the user visible options. good spot on utm_key, fixing that now [21:16:29] ah, that makes sense [21:16:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout controller - https://phabricator.wikimedia.org/T131808#2179150 (awight) [21:18:02] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout controller - https://phabricator.wikimedia.org/T131808#2179108 (awight) [21:21:45] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout transactions and data transformations - https://phabricator.wikimedia.org/T131807#2179156 (awight) [21:21:49] ejegg: okay, fixed utm_key and changed to use GET. https://en.wikipedia.org/?banner=B1516_0202_mlWW_dsk_p1_lg_sandbox&force=1&country=NL [21:22:02] this looks okay to me now [21:23:05] looks great [21:23:08] awight: when your asus fried, what did it look like? did it not see the disks? [21:23:27] the-wub: ooh, recurring isn't getting set to 1 when I select monthly [21:26:21] cwd: I can't remember, thought maybe it was acting more like a bad sector, until that final reboot. [21:26:40] Then I was stuck at a boot error of course, cos RAID + LVM + FDE [21:26:48] does not like for one disk to go missing [21:27:56] oh so was it one of the disks that went bad? [21:28:03] i thought it was the disk controller or something [21:30:07] (PS1) Ejegg: AstroPay: look up method and submethod together [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 [21:31:01] (PS1) Ejegg: Cleanup: typo, imports, dynamic field [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281535 [21:34:06] (CR) Ejegg: [C: 2 V: 2] "Works for me too! I just realized we don't even need the _deleted table, but it'll be nice to have initially for debugging in production." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/280784 (https://phabricator.wikimedia.org/T130660) (owner: Awight) [21:36:07] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout controller - https://phabricator.wikimedia.org/T131808#2179194 (awight) Send RETURNFMFDETAILS results to fredge. [21:36:23] (PS5) Ejegg: Default function defines data transformers from config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281062 (owner: Awight) [21:40:13] ejegg: can you reply to astropay with exactly what you experienced with the 13 digit "fix"? [21:40:27] sure, can do! [21:40:32] thanks! [21:41:03] I was waiting to redeploy to reply to the list, but since that's taking a bit longer I'll just write to ppena and astropay now [21:41:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout transactions and data transformations - https://phabricator.wikimedia.org/T131807#2179197 (awight) [21:41:30] ejegg: okay, fixed recurring. and also fixed adding 'r' to the method in utm_source, so we can pick those out when looking at results [21:41:41] ah, cool! [21:43:24] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write adapter or payment method - https://phabricator.wikimedia.org/T131811#2179202 (awight) [21:44:22] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2179216 (awight) [21:44:30] the-wub: looks great! [21:45:46] ejegg: I think this change is all ready to go now. but it's late here, don't really want to start updating all our banners tonight (since I'll need to update the forms individually). will work on it tomorrow [21:46:41] the-wub: ah, ok. Thanks again! Let me know when that's all set [21:49:20] awight / cwd: going to revert deployment branch of DI [21:49:28] thank you for all your help! I really should have tackled this in January... [21:49:56] ejegg: sorry i haven't been following that too well, what's broken? [21:50:10] the-wub: heh, no prob! I should have coordinated with you better when I decided to mess with the incoming params... [21:50:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2179224 (awight) [21:50:24] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2179223 (awight) [21:50:49] cwd I just won't be able to redeploy today, so reverting to keep things consistent [21:51:11] yeah, what's the matter with the deploy though? was it those ffname errors? [21:51:33] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2179228 (awight) [21:51:35] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, I18n: Sort out PayPal language vs country - https://phabricator.wikimedia.org/T113819#2179225 (awight) Open>Resolved a:awight The docs for Express Checkout address this issue. It's truly awful, but well defined at least. https://de... [21:53:06] dstrine: Now that I've settled on an integration, I think that Express Checkout will be straightforward. I wanted to highlight this for you: https://phabricator.wikimedia.org/T131800 [21:53:21] (PS1) Ejegg: Revert "Merge master into deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281539 [21:53:38] Let's see how that merge revert worked... [21:53:43] I'm recommending that we push for a quick and ascetic "internal test" milestone, to prove that JPY is actually supported. [21:53:52] awight: yeah I saw that... excellent idea [21:53:56] k. [21:55:10] do you have an estimate for that? I see there is an epic blocking [21:55:11] dstrine: Also, do you want me to create Internal test / Limited test / Campaign milestones for EC? [21:55:35] The epic is just to "write PayPal EC integration" ;) [21:56:19] ... to make DonationInterface support the basic things, without all the peripheral work such as updating the listener. [21:56:42] My guess is 4-8 points for that [21:56:46] but is that epic a real blocker for the quick and dirty internal test? [21:57:33] gotta relocate - awight / cwd, deployment branch is still unsafe to deploy. I'll fix that after some food [21:58:00] @awight RE: milestone task creation, I can make them in about 30 minutes... heading to a meeting right now. [21:58:01] dstrine: Not quite sure what you mean--we could do something quicker and dirtier, but at some point we would be creating pure tech debt that wouldn't be reusable if we decide to go forward with the integration [21:58:15] thanks! [21:58:40] let's chat again in like.. 30 minutes [21:58:44] thanks for all this!! [21:59:34] dstrine: I would accept your challenge to strip the task down even further, but I think it's worthwhile to test both one-time and recurring, for example [22:00:39] I'm not pushing to strip anything down. I'm just trying to grok the current tasks and the best order for them [22:06:01] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179272 (DStrine) p:High>Unbreak! [22:06:10] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2179274 (awight) The audit script recovered, so I think this must have been done already? Thanks! [22:06:29] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2163485 (DStrine) adding to sprint. The Netherlands campaign runs until 4/26. We should at least look into this [22:06:44] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2163485 (awight) a:awight [22:07:04] rgh so we set referrer all over the place in DI also [22:07:15] i'm guessing it's complaining about the xhrs still [22:07:53] * awight tightens blinders [22:08:30] should be easy enough to track down [22:08:38] It sure did seem to be a widespread DRY scandal [22:10:21] i will do that in a bit, i need to run to the post office and get that passport renewal happening [22:12:10] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179311 (awight) I was hoping it was just a pattern= attribute that we were setting on the input, but that doesn't... [22:13:35] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179312 (awight) Nope--terrible guess. The error is coming from our server-side validation. [22:18:24] Fundraising-Backlog: Q3 GOALS! (January-March) Keep at top of Q3 column - https://phabricator.wikimedia.org/T117466#2179321 (DStrine) Open>Resolved [22:18:45] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2179323 (DStrine) [22:18:47] Fundraising-Backlog: Q3 GOALS! (January-March) Keep at top of Q3 column - https://phabricator.wikimedia.org/T117466#1775015 (DStrine) [22:19:46] Fundraising-Backlog, Epic: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2179326 (DStrine) [22:20:02] Fundraising-Backlog, Epic: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2179339 (DStrine) [22:20:04] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#995314 (DStrine) [22:20:42] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2179326 (DStrine) [22:21:23] (PS6) Eileen: Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) [22:21:24] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#2179341 (DStrine) [22:21:38] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#2179354 (DStrine) [22:21:41] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2179353 (DStrine) [22:22:37] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#2179370 (DStrine) [22:22:39] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#995314 (DStrine) [22:23:03] @awight check out the milestones I added to block this: https://phabricator.wikimedia.org/T87621 [22:24:01] (Abandoned) Eileen: [WIP] Try to fix missing exchange rate fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280763 (owner: Awight) [22:26:00] (CR) Eileen: "@awight I got this to work. The exchange rate had to be relevant to USD - & I tweaked the numbers." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen) [22:27:50] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2060277 (Eileenmcnaughton) I've put up a fix - I pr... [22:29:14] awight: I just took a quick look at https://phabricator.wikimedia.org/T130660 - but that is pending deployment not in review now? [22:29:42] dstrine: Thanks, I'll set blockers for those... [22:30:12] eileen: It's still waiting for CR. ejegg|food found an optimization, which I made this morning. [22:30:23] oh! He merged, nvm [22:31:04] :-) [22:31:59] somehow I missed the voting on the staff rep for the voting - but looks like my vote wasn't needed [22:32:11] staff rep for the ed search I mean [22:34:35] * Seddon really needs to switch off fundraising as a watch word when in this channel...... [22:34:54] :-) [22:50:55] same here [22:51:12] slightly disturbing, but the candidates were all amazing. [22:55:15] ccogdill: We have a patch to try for https://phabricator.wikimedia.org/T130660 [22:55:31] I'm gonna try to kick off a job now, so please keep an eye on tomorrow's import... [22:55:46] k sounds good [22:55:50] can’t wait! [22:55:56] thanks for the heads up [22:56:13] We'll see--that script is a bear. [22:56:46] Hopefully, we can write some test cases that'll should make it more maintainable, by reducing the number of bugs that regress. [22:57:15] not totally sure what that entails, but I like it! [22:57:39] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2179435 (Eileenmcnaughton) The query to find more o... [23:04:02] It's actually something you can try at home ;) -- if we have really small examples of things that can go wrong, e.g. deleted donors not being unsubscribed, then we can put that in a list of examples which get checked automatically every time we make unrelated changes, which might accidentally break other features. [23:06:38] (PS1) Awight: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/281557 [23:06:57] (CR) Awight: [C: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/281557 (owner: Awight) [23:07:11] (CR) Awight: [V: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/281557 (owner: Awight) [23:08:34] !log update fundraising tool from 1bc23cb4bfaf2a9d4d215aad79dd67d891b5d973 to d8c5cc0b399411efa3b0634fa891a236c3dbaab2 [23:08:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:09:57] ccogdill: Okay, the export should complete at around 7pm Pacific, I'll check it out and will ping you on the task. [23:10:18] oh that’s early! or earlier than silverpop runs it, at least [23:10:28] I’ll let you know how the import goes on my side tomorrow morning [23:10:32] awight: ejegg: cwd|afk: XenoRyet: hmmm I can't seem to get any iDEAL donations to work locally... Looking at https://phabricator.wikimedia.org/T131181 Apologies for the bother... [23:10:58] Most of the time I get the same error listed in the Phab task [23:11:34] AndyRussG: you mean when you try to choose a bank? [23:11:51] AndyRussG: Can you do a test CC donation? [23:12:18] awight: CC? [23:12:45] A credit card donation, with card no. 4111111111111111 [23:12:48] Fundraising Tech Backlog: please do a round of activemq cleanup - https://phabricator.wikimedia.org/T131787#2178536 (Ejegg) We definitely need to add more queues to the 'old message consume' job. Here's what it's currently clearing (queue name: age in days) pending: 20 limbospecial: 9 verified_damaged: 14... [23:14:45] awight: Ah K one sec [23:15:46] awight: should I put that in ffname or in payment_method? [23:16:03] dstrine: Do you know, are we supposed to be requiring name and email on iDeal payments forms? They seem to be optional. [23:16:29] AndyRussG: e.g. ?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=email-cc-vmaj&recurring=&utm_medium=sitenotice&utm_campaign=&utm_source=B1516_0404_nlNL_dsk_p2_sm_txt_cnt.no-LP.cc&language=en&country=NL¤cy_code=EUR&payment_method=&frequency=onetime&amount=5&amountGiven=&utm_key=0&uselang=en&payment_submethod= [23:18:08] (CR) Ejegg: [C: 2] "Looks good! Transformers generally shouldn't need constructor params, but if they do we can override." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281062 (owner: Awight) [23:19:15] awight: hmm that's giving me "Secure Connection Failed" in the iframe [23:19:39] (Merged) jenkins-bot: Default function defines data transformers from config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281062 (owner: Awight) [23:23:40] (PS2) Ejegg: Revert "Merge master into deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281539 [23:24:32] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179481 (awight) I'm seeing more strange behavior on this form. * Entering an invalid address in desktop Firefox c... [23:24:51] AndyRussG: Okay, I think both of your error are caused by the wrong kind of VPN. [23:24:59] awight: huh! [23:25:03] It's full VPN, eh [23:25:05] You need to use the "full" rather than "split" tunnel [23:25:13] it is already? [23:26:07] awight: 8d324cd62cb6 'Tiny cleanups' was deployment-only? [23:26:25] awight: yep [23:26:30] I reverted the merge and it was still there. don't see it in master [23:27:06] Fundraising Sprint Ghostbusting , Fundraising-Backlog: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2179494 (awight) [23:27:14] ejegg: d'oh, I thought I had abandoned that [23:27:29] well, PS2 of the revert undoes it along with the rest [23:27:49] thx, I'll port that to master [23:27:52] awight: oh here's more details from the iframe error: Error code: SSL_ERROR_RX_RECORD_TOO_LONG [23:27:55] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179496 (DStrine) @awight T128693 is not in the sprint and currently at 4 points. Is there a short term fix? The... [23:28:05] (PS3) Ejegg: Revert "Merge master into deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281539 [23:28:21] (CR) Ejegg: [C: 2 V: 2] Revert "Merge master into deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281539 (owner: Ejegg) [23:28:58] (PS1) Awight: Tiny cleanups [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281566 [23:29:48] AndyRussG: $wgGlobalCollectGatewayURL = 'https://ps.gcsip.nl/wdl/wdl'; [23:29:51] ? [23:29:56] not .com ? [23:30:33] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281567 [23:30:36] awight: yep exactly [23:30:51] Lemme check out the network tab on the iphrame [23:30:54] requests [23:30:56] yikes... [23:30:56] or request [23:31:08] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281567 (owner: Ejegg) [23:31:45] OK, deployment branch matches deployed payments code again [23:32:19] Thank you! [23:33:32] (PS6) Ejegg: Move data transformers to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281063 (owner: Awight) [23:36:25] I do get the igenico animated gif [23:36:46] (PS2) Ejegg: Move most error mapping into config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281081 (owner: Awight) [23:37:11] (CR) Ejegg: [C: 2] "Looks good!" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281063 (owner: Awight) [23:38:35] back in a few! [23:39:05] (Merged) jenkins-bot: Move data transformers to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281063 (owner: Awight) [23:39:53] * Seddon pokes dstrine [23:40:23] * dstrine waves at @Seddon [23:41:08] Seddon: ? [23:41:57] it's 12:41am in the UK ... [23:41:58] dstrine: since you are now in post proper, it would be good to chat :) [23:42:29] dstrine: time is a concept for lesser beings who appreciate a work life balance :P [23:43:33] yeah sure. I am slowly talking to stakeholders. I'm about to sign off for today and I may have jury duty this week. Is this a normal time for you or should I schedule something in the morning (Pacific)? [23:43:51] * awight stops and grabs popcorn [23:44:21] dstrine: something more morning :) I like to avoid encouraging PST for my bodyclock [23:44:59] Seddon: ok will do. However it may be late this week or next ... just FYI [23:45:00] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback issues - https://phabricator.wikimedia.org/T131231#2179528 (Eileenmcnaughton) Based... [23:45:10] dstrine: lets push to next [23:45:34] * Seddon throws popcorn at awight [23:45:47] (CR) Ejegg: [C: 2] "legit! I regret allowing callables..." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281081 (owner: Awight) [23:46:26] AndyRussG|thnrgx: I'm not having much insight into the bug you're describing, other than that you should check that the PAYMENTPRODUCT value is changing as you try each bank. If not, then maybe something in your session is stuck on Knab? [23:46:26] Seddon: I just sent an invite [23:47:12] awight: so you preferred the generalized lookup table builder, just moved to a helper? [23:47:18] (Merged) jenkins-bot: Move most error mapping into config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281081 (owner: Awight) [23:47:36] awight: I did some checks locally on https://phabricator.wikimedia.org/T131231 based on previous discussion [23:49:19] ejegg: Sorta... I'm just obsessed with moving things out of the base adapter class. [23:49:40] sure, sounds good! [23:49:42] Building the lookup is fine... [23:49:54] will make a helper [23:50:30] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2179535 (Eileenmcnaughton) [23:50:32] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix the logging code so that it is in sync with 4.7 & the enable can be done by script - https://phabricator.wikimedia.org/T131228#2179533 (Eileenmcnaughton) Open>Resolved Th... [23:51:38] eileen: Good to hear that the rollback happens normally when the log tables are in a separate db! I would still worry that without 2-phase commit, we can get into a situation where the main db has rolled back, but the log db does not... but that's probably too rare to care about. [23:54:41] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179541 (awight) Specific steps to reproduce the first bug I mentioned above: * Go to https://payments.wikimedia.o... [23:55:06] awight: I'm on the fence about it - because I've been saved in the past by info from the logging tables telling me what was rolled back but should not have been [23:56:33] Thanks for the reminder, yeah that convinces me. [23:58:02] (PS6) Ejegg: Use generalized lookup table builder for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054