[00:01:29] (CR) Awight: [C: 2] "/me is chagrined to have complained about where a 3 statement function lives." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054 (owner: Ejegg) [00:01:35] (PS7) Awight: Use generalized lookup table builder for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054 (owner: Ejegg) [00:04:22] awight: oops, didn't add that to autoload! [00:04:46] we're so '90s... [00:05:08] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback issues - https://phabricator.wikimedia.org/T131231#2160098 (Eileenmcnaughton) No ac... [00:06:42] awight: hmm K good idea about checking that it's changing right. Session is fresh each time (or, I'm deleting local cookies, tho maybe I should delete globalcollect ones too) [00:06:43] pushed it for review while grrrit-wm was blinking [00:06:56] awight: https://gerrit.wikimedia.org/r/281574 adds arrayhelper to autoload [00:07:11] (PS2) Awight: Add ArrayHelper to autoload [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281574 (owner: Ejegg) [00:07:11] or... I can amend ps7, huh? [00:07:21] (CR) Awight: [C: 2] Add ArrayHelper to autoload [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281574 (owner: Ejegg) [00:07:43] awight: lemme just amend ps7 [00:07:59] godspeed :) [00:08:56] (PS8) Ejegg: Use generalized lookup table builder for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054 [00:08:59] (CR) jenkins-bot: [V: -1] Add ArrayHelper to autoload [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281574 (owner: Ejegg) [00:09:35] (CR) Awight: [C: 2] Use generalized lookup table builder for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054 (owner: Ejegg) [00:09:58] thanks for the tango! [00:11:05] * awight bows at the honor [00:11:17] (Abandoned) Awight: Add ArrayHelper to autoload [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281574 (owner: Ejegg) [00:11:38] * ejegg holds rose in teeth [00:11:58] (PS1) Cdentinger: remove protocol string from referrer param [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281576 [00:12:01] full on warner brothers... [00:12:15] (Merged) jenkins-bot: Use generalized lookup table builder for WP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281054 (owner: Ejegg) [00:12:27] Meanwhile, I can't tell if this iDeal mousetrap is set with fast-kill or slow-kill bait [00:13:06] (PS2) Ejegg: Tiny cleanups [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281566 (owner: Awight) [00:13:10] The form is damaged in laughable ways tho [00:14:01] (Abandoned) Ejegg: Restore lookup table for WP submethod api name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281052 (owner: Ejegg) [00:14:43] (CR) Ejegg: [C: 2] Tiny cleanups [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281566 (owner: Awight) [00:16:13] (Merged) jenkins-bot: Tiny cleanups [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281566 (owner: Awight) [00:17:31] sorry i missed what went wrong with the deploy today. was it those ffname errors? [00:19:56] does anything in today's probs affect me pushing civi & crm updates? [00:20:34] cwd: As far as I saw, it was a missing payment_method param, which turned out to be a glitch in a donatewiki script, but ejegg might have more to say [00:20:45] eileen: No, I think the coast is clear! [00:20:49] cool [00:20:58] cwd an extra payment_method post var, actually [00:21:21] we had old + new params on the qs, plus an extra set in post [00:21:34] but the POST payment_method was empty [00:21:56] and POST apparently trumps querystring when you getVal on a MW request [00:22:08] this was due to donationinterface code? or donatewiki? [00:22:21] cwd that particular thing was banners [00:22:35] and I changed DI to stop looking at the old param [00:22:47] when the new param was blank [00:23:22] so the-wub told me he was planning to sort all that param stuff out today anyway [00:23:22] hehe, thank you for clarifying! [00:23:37] and now he's got it sending everything via GET, which will be nice and loggable [00:23:44] oh i gotcha, so we will just wait for that and then the new code will be fine? [00:23:56] ooh that'll be great for donor services as well [00:24:07] yep, he's going to finish all the banners and donatewiki tomorrow morning [00:24:10] good for general cleanliness too [00:25:17] (CR) Ejegg: [C: 2] "Looks good! Bummer the original currency + amount didn't just work." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen) [00:25:51] i think this will stop the vast majority of modsecurity's complaining: https://gerrit.wikimedia.org/r/#/c/281576/1 but please lmk if anyone knows of an unintended consequence [00:27:33] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179558 (awight) The "nothing happens" bug is caused by client-side validation which is written for the "red highl... [00:29:10] (CR) Ejegg: "please check GatewayPage.php line 365 - might need to strip something off the start of $wgServer" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281576 (owner: Cdentinger) [00:29:47] (CR) Ejegg: "oops, never mind!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281576 (owner: Cdentinger) [00:32:12] (PS1) Awight: Trim email during normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281581 (https://phabricator.wikimedia.org/T131323) [00:33:34] (CR) jenkins-bot: [V: -1] Trim email during normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281581 (https://phabricator.wikimedia.org/T131323) (owner: Awight) [00:38:23] whoa, what triggered that? [00:39:03] I'm boggled [00:39:18] yea [00:39:22] weird [00:39:34] (PS2) Awight: Trim email during normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281581 (https://phabricator.wikimedia.org/T131323) [00:39:38] rewrote it even more gingerly ^ [00:43:02] cool, looks like front end validation doesn't care about trailing space [00:43:58] There are still some problems, though... client-side validation can fail without a trace, and results in a Nothing Happens situation. [00:44:48] insidious [00:47:04] gonna sign off for now, might drop in again later [00:49:22] i definitely don't get why a blank email address would cause those failures [00:50:43] I didn't see a blank email address cause any problems yet--actually, it should be required and fail validation, but that part isn't working, either. [00:51:15] but your new patch set that made the tests pass, what's the deal there? [00:51:48] ah--I donno! I was thinking, maybe the value was null and I was surprising everything by turning null into empty string. [00:52:21] i guess that must be it [00:52:25] non-linear [00:52:44] That explanation does just scream "tech debt", tho... [00:53:20] heh yeah [00:54:56] also a language where null is regularly an empty string [00:55:50] Fundraising-Backlog, FR-Ingenico: Rewrite Ingenico forms without webitects code - https://phabricator.wikimedia.org/T131821#2179586 (awight) [00:56:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Ingenico: Rewrite Ingenico forms without webitects code - https://phabricator.wikimedia.org/T131821#2179598 (awight) [00:56:23] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2179600 (awight) Remaining bugs should be fixed in T131821 [00:57:49] whoops, worked too much today! see ya tomorrow [01:02:56] (PS1) Eileen: CiviCRM submodule update: improvements to support logging & reversal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281583 [01:03:32] (CR) Eileen: [C: 2] "submodule update, self merging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281583 (owner: Eileen) [01:05:20] (Merged) jenkins-bot: CiviCRM submodule update: improvements to support logging & reversal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281583 (owner: Eileen) [01:09:22] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/281584 [01:09:57] ejegg|away: XenoRyet I think I've grabbed some of your patches in this https://gerrit.wikimedia.org/r/#/c/281584/ - but I think they are OK to go? [01:10:19] ie https://gerrit.wikimedia.org/r/#q,4b5f413,n,z Fix opt out fields for Civi imports [01:10:30] & https://gerrit.wikimedia.org/r/#q,c105217,n,z Send failmail when TY job can't find contribution [01:10:49] eileen: Yea, mine is good to go [01:11:30] cool [01:17:37] (CR) Eileen: [C: 2] "self-approving, merge commit" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/281584 (owner: Eileen) [01:29:00] !log Updating CiviCRM from bfe563f2451725e734d6ddbddb3be716463a3512 to 4cc17b635eb84204cced107d5de78533cc5ce06c [01:29:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:49:23] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2159063 (Eileenmcnaughton) After deploying this loads of failmail kicked... [02:04:14] (PS1) Eileen: Fix source field on partial refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281585 (https://phabricator.wikimedia.org/T127929) [02:06:04] (CR) Eileen: "This contact is an example of one of the 5 that need fixing (manually I propose) - civicrm/contact/view?reset=1&cid=14813855" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281585 (https://phabricator.wikimedia.org/T127929) (owner: Eileen) [02:06:31] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2179652 (Eileenmcnaughton) [02:06:33] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Backport CRM-18178 exclude _bak & _backup tables from trigger creation - https://phabricator.wikimedia.org/T131221#2179651 (Eileenmcnaughton) Open>R... [02:06:58] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix the logging code so that it is in sync with 4.7 & the enable can be done by script - https://phabricator.wikimedia.org/T131228#2179654 (Eileenmcnaughton) [02:07:00] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2179656 (Eileenmcnaughton) [02:07:02] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Use a unique ID to store logging information per : https://issues.civicrm.org/jira/browse/CRM-18193 - https://phabricator.wikimedia.org/T131222#2179655 (Eileenmcnaught... [02:07:04] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Deploy setting metadata updates & refresh the cache table. - https://phabricator.wikimedia.org/T131225#2179653 (Eileenmcnaughton) Open>Resolved [02:07:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2179658 (Eileenmcnaughton) [02:07:20] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2127955 (Eileenmcnaughton) Open>Resolved [02:07:31] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2127955 (Eileenmcnaughton) [02:07:33] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Sync relevant files with 4.7 to make porting easier - https://phabricator.wikimedia.org/T131223#2179659 (Eileenmcnaughton) Open>Resolved [02:07:44] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2127955 (Eileenmcnaughton) [02:07:46] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Use a unique ID to store logging information per : https://issues.civicrm.org/jira/browse/CRM-18193 - https://phabricator.wikimedia.org/T131222#2159858 (Eileenmcnaught... [02:08:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#1614185 (Eileenmcnaughton) [02:08:02] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, and 2 others: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#2179663 (Eileenmcnaughton) Open>Resol... [02:08:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#1614185 (Eileenmcnaughton) [02:08:16] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix slow activity query on logging tab - https://phabricator.wikimedia.org/T131229#2179665 (Eileenmcnaughton) Open>Resolved [02:08:33] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2127990 (Eileenmcnaughton) [02:08:35] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Ffx the logging code so that the triggers are not created in realtime if a setting is in play CRM-18212. - https://phabricator.wikimedia.org/T131224#2179667 (E... [04:58:17] doubt anyone's around, i think turning off the thank you job would shut up the fail mail but it looks like just 2 broken messages so i dunno if it's worth it [04:58:57] i will be awake for like 15 minutes if anyone wants to tell me to shut the job off [05:21:00] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Opt out field not working with Engage import - https://phabricator.wikimedia.org/T130768#2179764 (XenoRyet) @LeanneS The fix for this has been deployed. Give it a tr... [05:23:39] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2179765 (Eileenmcnaughton) I was wrong about them having stopped - I jus... [05:28:53] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback issues - https://phabricator.wikimedia.org/T131231#2179770 (Eileenmcnaughton) Note... [05:31:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Allow mismatched refunds - https://phabricator.wikimedia.org/T89437#2179771 (Eileenmcnaughton) @awight @Ejegg I feel like we can close this as I think it's now happening..... Thoughts? [05:34:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2086989 (Eileenmcnaughton) Note that if this is NOT done before turning logging on on LIVE then it will be necessary to get Jeff to run the amended trigger sql when creating the new fields [15:59:10] Fundraising-Backlog, Hovercards: Avoid z-index conflict with HoverCards & Central Notice and friends - https://phabricator.wikimedia.org/T131364#2180751 (Pcoombe) There's no z-index set on CentralNotice itself. I've adjusted all our fundraising banners to have z-index: 110, which lets Hovercards cover t... [16:05:22] (CR) Ejegg: [C: 2] "Looks good! Can you think of any fields we /shouldn't/ trim?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281581 (https://phabricator.wikimedia.org/T131323) (owner: Awight) [16:07:45] (Merged) jenkins-bot: Trim email during normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281581 (https://phabricator.wikimedia.org/T131323) (owner: Awight) [16:09:36] ejegg: Lmk if I can do anything to help with the DI deployments today... [16:09:44] Thanks! [16:10:15] Right, I should do that sooner rather than later... let me get the vendor repo all set [16:11:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add all used custom Civi fields to install scripts - https://phabricator.wikimedia.org/T131858#2180784 (Ejegg) [16:14:38] ejegg: Happy to take that off your hands, and you can just babysit the payment_method thing [16:14:52] already on it, but thanks! [16:15:17] k! well--I also have a horse in the race, pls try to merge https://gerrit.wikimedia.org/r/281581 into the fracas [16:15:36] yep, it made it just under the wire! [16:16:35] nice that composer asks 'reinstall instead?' now when the .git dir is missing, instead of just bombing out [16:17:03] oh gosh if we're merging stuff before the deploy i got one [16:17:12] which is that? [16:17:35] we can definitely deploy again soon! [16:18:02] ah, the referrer thing? [16:18:19] i guess that looks pretty harmless [16:18:57] yeah that one [16:19:24] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay: Astropay: 13 digit number will hide the fiscal number in mexico - https://phabricator.wikimedia.org/T131793#2180812 (awight) @Ejegg I think you did try this, in changeset https://gerrit.wikimedia.org/r/#/c/28... [16:20:37] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay: Astropay: 13 digit number will hide the fiscal number in mexico - https://phabricator.wikimedia.org/T131793#2180815 (Ejegg) This is about to be redeployed, but I tested it during the brief time it was up yest... [16:21:06] (PS1) Ejegg: Update dependencies [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/281680 [16:21:27] awight: does that referrer thing look good to you too? [16:21:44] https://gerrit.wikimedia.org/r/#/c/281576/ [16:21:50] we'll just want to update any filter rules we have in prod [16:22:10] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback issues - https://phabricator.wikimedia.org/T131231#2180817 (awight) That sounds goo... [16:22:15] ejegg: what filter rules do you mean? [16:22:30] there's a fraud filter that looks at referrers [16:23:18] oh hrm, should i update that first? will it care if the protocol is gone? [16:23:40] the rules are all in settings, so I'll update any that have protocols when I deploy [16:23:45] cwd: Did you make a decision about disabling the rule vs changing referrer everywhere? [16:24:38] awight: well that change just is pretty minimal so i thought i'd try it [16:24:58] i'm sure that the more rules we can leave on the better the audit will go [16:25:22] (PS2) Ejegg: remove protocol string from referrer param [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281576 (owner: Cdentinger) [16:25:23] cwd: ok cool [16:25:38] ejegg: I remember the rule you're referring to, but don't see it in the config! [16:26:16] CustomFiltersRefRules [16:27:08] ejegg: cwd: I confirmed that the ^ referrer rules use regexes and already don't include the protocol [16:27:19] thanks awight [16:28:47] (CR) Ejegg: [C: 2] "But what if they get here from a gopher server?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281576 (owner: Cdentinger) [16:29:15] nice [16:29:17] thanks! [16:30:15] (CR) Awight: remove protocol string from referrer param (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281576 (owner: Cdentinger) [16:30:42] (Merged) jenkins-bot: remove protocol string from referrer param [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281576 (owner: Cdentinger) [16:33:57] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Move normalization into the DataTransformers - https://phabricator.wikimedia.org/T131860#2180854 (awight) [16:34:33] awight: i just copied that regex out of the modsec rule [16:34:47] so it'd have the same quirks if there are any [16:34:59] haha they're fancy [16:35:02] i agree that it's silly [16:40:35] ccogdill: Have you gotten the chance to review the silverpop export yet? [16:40:50] hey awight, yes, everything looked fine! [16:40:53] Unfortunately, we purge those files aggressively, so I'm unable to compare today's results to yesterday [16:40:56] really! great [16:41:04] & we're getting the new unsubscribe entries? [16:41:06] you seem surprised :p [16:41:13] hehe only a lot [16:42:00] looks like we got like 1k new records on the unsubscribe list? [16:42:14] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, and 6 others: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2180894 (awight) @Ejegg I'm happy to pick up the Adyen staging... [16:42:15] that’s a lot for one day, but I’d guess that’s expected w/the new rule implemented, yeah? [16:42:27] ccogdill: That sounds very low, actually [16:42:43] it should have added everyone with a deleted contact, and no active contact using the same email. [16:43:39] hmm… well [16:44:05] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281684 [16:44:07] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281685 [16:44:07] I’m not sure :/ is there some way to get me a list of records that were expected to be added last night? [16:44:25] ccogdill: I just checked and only 25k contacts have been deleted [16:44:33] Which makes our results a bit more likely. [16:44:34] The first of those two^^ is restoring the stuff I reverted yesterday [16:44:51] ccogdill: Yes, I think I can point you to the list [16:44:54] I’m happy to do some spot checking if you can get me a list :) [16:45:18] oh is it in silverpop_deleted? [16:46:03] hmm so I’d need a deletion date [16:46:44] cool, amazon sandbox donation still works with the updated client [16:47:10] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281684 (owner: Ejegg) [16:47:38] ccogdill: yes, it's silverpop_deleted, but at 990 rows I think we can assume that these account for the 1k of new records [16:47:47] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281685 (owner: Ejegg) [16:48:14] oh yes that sounds perfect [16:48:20] The stuff I'm more concerned about is, whether the other 24k deleted contacts are actually dupes of a silverpop_deleted record or an active email... [16:48:39] I bet most are dupes of active emails [16:48:44] We could always just wait for complaints ;) [16:48:47] based on my merging experience… [16:49:15] (CR) Ejegg: [C: 2 V: 2] Update dependencies [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/281680 (owner: Ejegg) [16:49:22] riiight--is_deleted includes everything that's ever been merged. [16:49:31] ok, I'm happy again, thanks! [16:50:05] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2180903 (awight) Open>Resolved [16:50:23] awight: (been merged and the existing contact has a different email) [16:50:59] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2180907 (awight) [16:51:17] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281689 [16:51:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#2180909 (awight) [16:51:44] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2180908 (awight) [16:52:28] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2179326 (awight) [16:52:30] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Debug gateway account name handling - https://phabricator.wikimedia.org/T130852#2180912 (awight) [16:53:05] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281689 (owner: Ejegg) [16:53:18] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2180927 (awight) [16:54:21] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2180931 (awight) [16:54:23] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#2180930 (awight) [16:55:54] ejegg: well, silverpop_deleted is the group you describe, but the 25k of civicrm_contact.is_deleted=1 records are probably mostly the same email as the record which survived the merge [16:56:02] Fundraising Tech Backlog, Fundraising-Backlog, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384#2180939 (awight) [16:56:04] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#2180938 (awight) [16:56:18] dstrine: I'd like to pull an EC or queue task into the sprint. Want to check sanity? [16:59:23] about to deploy! [17:00:01] !log updated payments wiki from a9659965d8b55b11518680a1170242f311c7f1d2 to cc298682f7ee9f43f5be863c6078e1c2ba70e3e6 [17:00:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:01:00] cool, real Amazon donation went through [17:01:16] nothing in the error log so far [17:01:50] gc worked, looking good [17:02:18] seeing paypal donations complete OK [17:02:54] hooray! [17:03:10] * ejegg is guardedly optimistic [17:04:05] worldpay is still unreachable... [17:04:17] but that's not this deploy's fault [17:04:27] is that the new IPs thing? [17:04:33] yeah [17:07:00] awight: there are a few things that are ever-so slightly higher priority. 1.) can youhelp at all on astropay work? 2.) there are several high priority and super frustrating civi bugs in sprint +1 column. 3.) Adyen in new countries is still higher priority tahn Paypal since there are campaing that need adyen in May: https://phabricator.wikimedia.org/T128812 [17:07:24] wow sorry for the typos [17:07:33] dstrine: Cool, thank you for the leads [17:07:51] awight: ejegg: cwd: XenoRyet: hey... anyone know where globalcollect error codes might be documented? [17:08:09] AndyRussG|thnrgx: I've got a PDF, one sec [17:08:16] ejegg: cool thx! [17:09:06] AndyRussG: are you on the fundraising filesrv? [17:09:21] I have gotten that to work at one time, yeah..... [17:09:25] [dstrine: 1) I don't see any AP tasks in sprint +1, and the ones in the current sprint won't benefit from extra help] [17:09:42] ok [17:09:46] AndyRussG: I'll just email it [17:09:52] Ah great thx! [17:10:41] dstrine: 2) is this what you were thinking of? https://phabricator.wikimedia.org/T122411 [17:10:52] awight:I as jsut about to type that :) [17:10:57] hehe k [17:11:09] "I was just about to type that" [17:11:34] ccogdill: would be very happy is that was solved [17:11:36] but spell checker was not enabled :p [17:11:47] asdfjlksadj [17:11:53] please please! [17:12:43] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2180997 (awight) [17:12:56] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#1903592 (awight) a:awight [17:15:16] ejegg: thx much! [17:15:21] Mmm going vpn [17:15:23] yw [17:16:00] ohhh, i think i see why they wanted random #s - getting 'user blacklisted' with the dummy fiscal # now [17:16:09] nother patch coming up [17:19:05] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2181007 (awight) @CCogdill_WMF I'm pretty surprised, but we currently aren't doing anything with the is_prim... [17:19:09] ccogdill: (ping ^) [17:19:31] ejegg: that's silly [17:19:49] oh yah, I meant to follow up on that... [17:19:50] so there's a chance we hit blacklisted fiscal IDs even with this hack :( [17:20:02] bah, yep [17:20:19] what are the odds ;) [17:23:38] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2181010 (CCogdill_WMF) Yikes @awight, this is_primary thing has come up before. The more I think about it, th... [17:24:25] Anyone want to check on their local stup that they're getting the same error codes as me for iDEAL? [17:24:46] Here's the URL I'm using: http://payments.wiki.local.wmftest.net:8080/wiki/Special:GlobalCollectGateway?title=Special%3AGlobalCollectGateway&ffname=rtbt-ideal&language=en&country=NL&frequency=onetime&amountGiven=&uselang=en&bannerhistlog=d45364f1b2d607fb [17:25:10] (same as in bug https://phabricator.wikimedia.org/T131181) [17:25:42] For bank ABN AMRO, I get 400880, IDEAL_APPLICATION_ERROR [17:26:30] For bank ING, I get 430900, NO VALID PROVIDERS FOUND FOR COMBINATION MERCHANTID.... (same error mentioned in the bug) [17:26:42] The doc sez in both cases to contact GC [17:27:09] I think a reasonable step before that is to inspect the data being sent to GC [17:27:32] But before that maybe I should see if there isn't something oozy with my setup [17:27:37] Does that make sense? [17:27:45] Thx in advance!! [17:29:09] AndyRussG: Sure, lemme try some local stuff... [17:29:16] awight: thx much! [17:43:15] (PS1) Ejegg: Actually random dummy fiscal number for MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281697 (https://phabricator.wikimedia.org/T131793) [17:48:22] (CR) Awight: "Just one comment about pushing the AstroPay hack into a subclass... I'm fine with merging if you'd rather not do that, though." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281697 (https://phabricator.wikimedia.org/T131793) (owner: Ejegg) [17:48:55] awight: subclassing now [17:49:11] actually, just adding another class. it's fine to have both [17:49:43] k [17:52:17] (PS2) Ejegg: Actually random dummy fiscal number for MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281697 (https://phabricator.wikimedia.org/T131793) [17:54:16] ejegg: I think you did want to subclass, cos the other branch of the conditional should still apply to other countries, right? [17:54:35] awight: got both transformers in the config [17:54:46] ooh thx [17:55:34] That's so saucy... staging encapsulation starting to pay off. [17:55:45] luvin it! [17:56:00] (CR) Awight: [C: 2] "Now if only that worked on the tax paperwork..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281697 (https://phabricator.wikimedia.org/T131793) (owner: Ejegg) [17:58:03] (Merged) jenkins-bot: Actually random dummy fiscal number for MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281697 (https://phabricator.wikimedia.org/T131793) (owner: Ejegg) [18:02:36] (PS1) Ejegg: Explicitly turn off fallback currency for tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281702 [18:03:26] (CR) Awight: [C: 2] "Better to set that global in the test that requires it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281702 (owner: Ejegg) [18:03:31] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281703 [18:03:58] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281703 (owner: Ejegg) [18:05:02] (CR) Ejegg: "unfortunately, setMwGlobals barfs if the global was previously unset" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281702 (owner: Ejegg) [18:05:10] aaargh. [18:05:36] So much for our cascading globals. [18:05:38] yah, actually let me try fixing that in core and see who yells [18:06:07] Maybe write a new function setMwGlobalsForce or something [18:06:24] hmm, or add a param? [18:06:27] allowUnset [18:06:31] (yuck :) ) [18:06:40] I'm becoming allergic to boolean params [18:06:57] k [18:09:00] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281705 [18:09:26] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281705 (owner: Ejegg) [18:11:07] (Merged) jenkins-bot: Explicitly turn off fallback currency for tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281702 (owner: Ejegg) [18:11:58] !log updated payments wiki from cc298682f7ee9f43f5be863c6078e1c2ba70e3e6 to d50c1b15f3d09c4724d7ad28e3668368ac8112be [18:12:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:14:57] phooey, no 'continue' button on the single-submethod form [18:18:07] AndyRussG: I'm still stuck at "nothing happens", but did notice that your URL is missing amount and currency [18:18:25] maybe you have those in your session / through POST data? [18:18:48] rgh, got one locally [18:19:05] awight: I'm using private windows now... [18:19:26] using the URL provided in the bug. Yeah each time it asks the amount and I fill it in... [18:20:55] k. That URL must have been the real one a donor went to, so half the data was sent via POST [18:21:08] awight, AndyRussG it's currency_code now [18:21:10] I think the-wub is actually fixing that this week, so that everything is sent over GET [18:21:19] just fixed it this morning [18:21:40] ah huh interesting [18:21:46] I'm seeing strangeness locally, donation amount is empty for http://payments.wiki.local.wmftest.net:8080/w/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=rtbt-ideal-noadd&recurring=&payment_method=rtbt&payment_submethod=rtbt_ideal&utm_source=Waystogive.default~default~default~default~control.rtbt.rtbt_ideal&utm_medium=Waystogive&utm_campaign=C11_Waystogive&utm_key=&lang [18:21:52] uage=en&country=NL&returnto=Thank_You%2Fen&amountGiven=¤cy_code=EUR&frequency=onetime&amount=3&uselang=en [18:21:55] grr [18:21:58] however, the live site works [18:22:35] must be session [18:22:43] * awight exasperates a bit [18:27:28] dstrine: Please keep me in the loop wrt iDeal--I need to leave for a few hours. Thanks! [18:27:49] posting in other chat.. [18:28:11] AndyRussG: fwiw, clearing the cookies didn't help, I still have an empty amount... [18:29:12] Hmmmm [18:49:49] speaking of session frustrations, I think Amazon is also losing the amount when switching from another gateway [18:50:33] yeah... it's that session reset on gateway swap [18:50:44] maybe that should keep amount + currency? [18:51:26] or re-harvest everything from the query after clearing session [18:58:48] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Continue button sometimes missing on form load - https://phabricator.wikimedia.org/T131874#2181375 (Ejegg) [18:59:23] (PS1) Ejegg: Force continue button when submethods hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281719 (https://phabricator.wikimedia.org/T131874) [19:00:05] cwd: can't replicate the problem locally, but I'm getting it on prod now (only in firefox) [19:00:11] ^^ [19:00:20] Think this should fix it [19:01:04] hmm, wait, that's not working... [19:04:46] oh, duh, looking at deploy branch [19:11:08] Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Continue button sometimes missing on form load - https://phabricator.wikimedia.org/T131874#2181418 (Ejegg) [19:24:21] fundraising-tech-ops, Security-Team: Update OpenVAS packages on Bismuth - https://phabricator.wikimedia.org/T128200#2181493 (csteipp) Open>Resolved repo packages updated, bismuth updated. Updated docs on collabwiki to make updating faster next time. [19:39:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Preserve SOME info on gateway switch - https://phabricator.wikimedia.org/T131881#2181552 (Ejegg) [19:41:48] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2181566 (DStrine) [19:42:00] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work, and 2 others: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2181567 (DStrine) [19:43:05] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2158454 (DStrine) note: we have take Ideal down until this can be sorted out [19:58:58] my mic is broken [19:59:08] Ohnoes [19:59:12] Sign language? [19:59:36] Typing + facial expressions in lieu of emoticons? [19:59:38] gonna have to be [20:00:05] (instead of emoticons in lieu of facial expressions...) [20:11:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Allow mismatched refunds - https://phabricator.wikimedia.org/T89437#2181732 (Ejegg) Open>Resolved a:Ejegg Sure, sounds good! [20:13:32] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback issues - https://phabricator.wikimedia.org/T131231#2181749 (Eileenmcnaughton) yeah... [20:43:03] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2158454 (Sjoerddebruin) >>! In T131181#2181566, @DStrine wrote: > note: we have take Ideal down until this can... [20:50:29] (PS1) Ejegg: Fix CO fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281746 [20:50:53] cwd XenoRyet anyone for review? ^^ [20:51:12] Sure, looks like a quick one. [20:53:43] (CR) XenoRyet: [C: 2] Fix CO fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281746 (owner: Ejegg) [20:54:01] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2181954 (Ejegg) oof... I should make it set a no_thank_you reason after... [20:55:06] Thanks XenoRyet ! What do you think of this one? https://gerrit.wikimedia.org/r/281719 [20:55:26] Yea, let me take a look at that too, see if we can get it out. [20:56:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico: GlobalCollect audit: lots of "impossible" errors for refunds - https://phabricator.wikimedia.org/T120430#1853782 (Ejegg) Plot twist: most of those aren't refunds. https://gerrit.wikimedia.org/r/281478 [20:56:41] (PS2) Ejegg: Only scream about missing parents for negative txns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281478 (https://phabricator.wikimedia.org/T120430) [20:56:48] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2181969 (Eileenmcnaughton) Do you think we should enable the "CiviCRM: a... [20:57:23] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, and 2 others: GlobalCollect audit: lots of "impossible" errors for refunds - https://phabricator.wikimedia.org/T120430#2181971 (Ejegg) a:Ejegg [20:57:48] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review, WMF-deploy-2016-04-05_(1.27.0-wmf.20): Astropay: remove Banco de Chile from CL/BT - https://phabricator.wikimedia.org/T131398#2181976 (Ejegg) Open>Resolved [20:58:00] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review, WMF-deploy-2016-04-05_(1.27.0-wmf.20): Astropay: WebPay as main processor for credit cards CL/BT - https://phabricator.wikimedia.org/T131400#2181977 (Ejegg) Open>Resolved [20:58:11] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, and 3 others: Pull payment methods out of adapters - https://phabricator.wikimedia.org/T130056#2181980 (Ejegg) Open>Resolved [20:58:23] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, and 6 others: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2181981 (Ejegg) Open>Resolved [20:58:42] (Merged) jenkins-bot: Fix CO fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281746 (owner: Ejegg) [20:59:38] (CR) XenoRyet: [C: 2] Force continue button when submethods hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281719 (https://phabricator.wikimedia.org/T131874) (owner: Ejegg) [21:01:41] (CR) jenkins-bot: [V: -1] Only scream about missing parents for negative txns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281478 (https://phabricator.wikimedia.org/T120430) (owner: Ejegg) [21:01:56] hmm [21:02:29] oho, github is offline for maintenance [21:02:47] /world takes afternoon off [21:03:05] :-) [21:06:41] (Merged) jenkins-bot: Force continue button when submethods hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281719 (https://phabricator.wikimedia.org/T131874) (owner: Ejegg) [21:06:53] thanks again XenoRyet [21:07:01] No worries, happy to help [21:20:13] https://github.com/blog/2144-gpg-signature-verification [21:20:51] oh cool [21:21:19] just don't invite any NSA spooks to your key signing parties [21:21:44] hehe [21:24:55] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2182047 (DStrine) @Sjoerddebruin We're working with the payment processor and hope to have a fix soon. We u... [21:52:57] dstrine: did you ping Jeff - or should I? [21:53:17] I did [21:53:56] it's ~6pm for him now [21:56:44] gotta relocate, back soon! [23:06:31] Are the Redis and pupetrun emails anything to be worried about? [23:07:40] ¯\_(ツ)_/¯ [23:07:46] i can't get to those boxes [23:09:30] okee [23:10:56] (CR) Cdentinger: Fix some PHPDoc comments (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [23:13:01] (PS1) Ejegg: Send failmail and set no_thank_you on TY errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281842 (https://phabricator.wikimedia.org/T131200) [23:13:12] (CR) Cdentinger: AstroPay: look up method and submethod together (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 (owner: Ejegg) [23:14:06] (CR) Cdentinger: [C: 2] Cleanup: typo, imports, dynamic field [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281535 (owner: Ejegg) [23:14:25] (CR) Ejegg: Fix some PHPDoc comments (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [23:14:48] (Merged) jenkins-bot: Cleanup: typo, imports, dynamic field [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281535 (owner: Ejegg) [23:15:14] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2182327 (Ppena) @Pcoombe can we remove BPay from banners/donate wiki? This is completely broken{F3834732} [23:15:44] (CR) Ejegg: "Would be awesome if SmashPig and DI could share config files. But... maybe later?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 (owner: Ejegg) [23:16:03] ejegg: i think the type hints are "catchable fatal errors" in php right? [23:16:13] one of my favorite php-isms [23:19:38] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2166998 (Ejegg) Open>Resolved [23:19:57] cwd :P [23:20:23] (PS3) Ejegg: Only scream about missing parents for negative txns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281478 (https://phabricator.wikimedia.org/T120430) [23:21:54] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2182352 (Ejegg) @Eileenmcnaughton Yeah, let's give us admins trash-picki... [23:23:52] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281847 [23:24:21] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281847 (owner: Ejegg) [23:25:42] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281849 [23:26:03] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281849 (owner: Ejegg) [23:29:59] cwd: ejegg do you know what the redis and pupetrun emails means? What do we use them for? [23:30:07] !log updated payments wiki from d50c1b15f3d09c4724d7ad28e3668368ac8112be to bbf36d804220b61b8eb7e5bf7a9c427d98ae1aaa [23:30:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:31:06] it looks like they are being sent every 5 minutes [23:31:18] dstrine: they should be telling us whether redis is working on the payments cluster [23:31:35] the logs aren't as noisy as I'd think if it was down [23:31:42] ok [23:31:46] but I can't get on the payments box [23:31:54] is this more of a jeff thing? [23:31:56] Jeff_Green would have to [23:31:58] yah [23:31:59] kk [23:32:20] if this goes on for another hour, should I call him or something? [23:33:05] err, might be a good time to pester him already... [23:33:18] cwd are you monitoring the owasp errors? [23:33:32] looks like it doesn't like some characters in the Amazon cookies [23:34:08] I'll text him [23:34:13] ejegg: yeah i noticed that [23:34:37] oh that makes sense now [23:34:43] i was wondering why it was seeing an amazon cookie [23:35:49] anyway yea we might want to loosen that rule up a bit before turning it on [23:35:57] cool [23:36:21] do they come back from amazon with that cookie or something? [23:36:27] set to our domain? [23:37:56] I sent Jeff a text [23:40:02] well i gotta roll, good luck! [23:40:11] Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Continue button sometimes missing on form load - https://phabricator.wikimedia.org/T131874#2181375 (Ejegg) Open>Resolved