[00:04:12] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Ingenico: iDEAL cancel returns donor to Thank You page - https://phabricator.wikimedia.org/T131904#2182480 (awight) [00:07:06] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work, and 2 others: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2182499 (awight) [00:07:08] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2182500 (awight) [00:07:10] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2182501 (awight) [00:14:53] awight: hey! when iDEAL asks for XMLs, that should be from our server logs (are they available?) or from local dev, or doesn't matter? [00:15:12] XenoRyet: ^ ? [00:16:08] AndyRussG: hi! [00:16:26] Yeah, that usually means, they want a copy of our server logs, where an XML snippet is printing [00:16:29] *ed [00:16:53] Ingenico has been getting better about that--there's a long history :D [00:17:14] sort of a joke for a while, cos the XMLs are exactly what we already sent them [00:20:31] hahah interesting [00:20:51] Yeah in my local XMLs I didn't see anything relevant other than error code and message [00:20:57] They have a system now, however, and if you send them the order ID they can get a complete API history. [00:21:07] awight: quick pointer to the logs? [00:21:09] Huh? [00:21:22] Ah so I could do it locally? [00:21:24] yeah... but I don't begrudge them a copy of the XML, if we can provide it [00:21:42] locally, it's in /var/log/syslog [00:22:05] Assuming you've enabled $wgDonationInterfaceUseSyslog, regrettably. [00:25:19] awight enabled that where? [00:29:20] In LocalSettings.php, if you're talking about a local environment. [00:29:32] (production is already enabled) [00:30:11] * awight laments how much is left unsaid at https://www.mediawiki.org/wiki/Extension:DonationInterface [00:32:08] ah right [00:34:07] awight: funny I don't have that in my local settings but I do get logs in syslog... maybe it's puppet-enabled [00:35:47] Ah it's in the melifluously named vagrant/settings.d/wikis/paymentswiki/settings.d/puppet-managed/10-DonationInterface.php [00:36:14] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work, and 2 others: Mobile donation form: error entering valid email address NL-iDEAL - https://phabricator.wikimedia.org/T131323#2163485 (awight) Open>Resolved I've fixed the first guess at the ca... [00:37:25] AndyRussG: that's a pretty fancy word [00:37:59] bd808: a fancy word for fancy fundraising [00:38:03] and yeah the config file layout is a bit baroque [00:38:21] baroque, like melifluous baroque music? [00:39:02] sorry didn't mean to be griping, btw :) [00:39:14] :) https://en.wikipedia.org/wiki/File:1710-15_de_Matteis_Triumph_of_the_Immaculate_anagoria.JPG [00:43:39] nice! [00:44:58] awight: I don't see XML in the syslog [00:45:57] AndyRussG: which syslog? [00:46:02] try "RETURNED FROM CURL:HTTP/1.1" [00:46:03] AndyRussG: did you see David's comment on the other channel : "When someone asks us for "the XML's" that usually means it's a non technical person relaying a message to us" [00:46:28] awight: yeah sorry I was looking wrong [00:46:41] oh! I do that all day :| [00:46:58] A bit of a programmer's hunch [00:47:04] eileen1: no I missed that one! [00:47:22] makes sense tho [00:52:13] awight: well there are certainly successful globalcollect donations from NL [00:53:52] Interesting! Recently? [00:54:15] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2182575 (awight) >>! In T122411#2181010, @CCogdill_WMF wrote: > Just to be sure -- there's no way that a cont... [01:11:04] * awight hides in shame [01:11:05] hehehe [01:11:21] AndyRussG: it turns out, "809" is the Ingenico payment method ID for iDEAL [01:11:29] so of course everything matches, it's not the bank. [01:12:11] Ah hmm K interesting [01:12:48] grep -w 430900 payments-globalcollect | grep -vw 801 [01:12:51] Knab... [01:29:55] (PS1) Awight: Remove Knab from iDEAL options [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281866 (https://phabricator.wikimedia.org/T131181) [01:34:23] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, Patch-For-Review: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2158454 (awight) There is a workaround submitted for review, which is worth review and me... [01:38:23] cwd|afk: You have any WIPs for this one? https://phabricator.wikimedia.org/T128693 [01:39:33] Aww, your search doesn't work, https://gerrit.wikimedia.org/r/#/q/owner:%22Cdentinger+%253Ccdentinger%2540wikimedia.org%253E%22,n,z [01:39:51] ha, it does but errors anyway [01:40:16] cwd|afk: found it! https://gerrit.wikimedia.org/r/#/c/274334/ [01:42:38] (PS8) Awight: WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger) [01:42:44] (CR) Awight: "PS 8: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger) [01:44:06] (CR) jenkins-bot: [V: -1] WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger) [01:54:35] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, Patch-For-Review: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2182615 (awight) TODO: The error codes we ran into should be added to the Ingenico error_... [02:14:56] (PS1) Awight: WIP issuer patch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281871 [02:14:58] (PS1) Awight: WIP remove quotes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281872 [02:15:00] (PS1) Awight: WIP Move issuers into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281873 [02:16:47] (CR) jenkins-bot: [V: -1] WIP remove quotes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281872 (owner: Awight) [02:17:10] (CR) jenkins-bot: [V: -1] WIP issuer patch [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281871 (owner: Awight) [02:17:47] (CR) jenkins-bot: [V: -1] WIP Move issuers into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281873 (owner: Awight) [07:25:29] (PS1) Awight: WIP Playing with payment method, trying to understand how to fix the two-level method hierarchy. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281883 [07:27:05] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Move IDEAL forms to Mustache templates - https://phabricator.wikimedia.org/T128693#2083009 (awight) After peeking at this, I think it needs to be specced out... [07:27:06] (CR) jenkins-bot: [V: -1] WIP Playing with payment method, trying to understand how to fix the two-level method hierarchy. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281883 (owner: Awight) [07:29:23] (PS1) Awight: [WIP] double up on exclusion logic--treat !is_primary the same as is_deleted [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/281884 (https://phabricator.wikimedia.org/T122411) [07:46:46] (PS1) Awight: Split out contribution save hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281889 (https://phabricator.wikimedia.org/T122411) [07:46:48] (PS1) Awight: Whitespace + readability [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281890 [07:46:50] (PS1) Awight: [WIP] Stub contact save hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281891 (https://phabricator.wikimedia.org/T122411) [07:49:22] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2182776 (awight) @Eileenmcnaughton I'll go ahead and implement this as a hook, but I'm... [08:05:11] Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-Ingenico: iDEAL form doesn't display red error borders or text - https://phabricator.wikimedia.org/T131913#2182779 (awight) [09:59:39] (CR) Pcoombe: [C: 2] Remove Knab from iDEAL options [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281866 (https://phabricator.wikimedia.org/T131181) (owner: Awight) [10:12:31] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2183046 (Pcoombe) @Ppena Done. [10:17:01] (Merged) jenkins-bot: Remove Knab from iDEAL options [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281866 (https://phabricator.wikimedia.org/T131181) (owner: Awight) [15:22:39] (CR) Matěj Suchánek: Fix source field on partial refunds (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281585 (https://phabricator.wikimedia.org/T127929) (owner: Eileen) [15:41:36] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, and 2 others: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2183702 (DStrine) [15:41:47] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Ingenico: Give error feedback when iDeal cannot connect to bank - https://phabricator.wikimedia.org/T92567#2183703 (DStrine) [15:41:56] Fundraising-Backlog, FR-Ingenico: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#2183704 (DStrine) [16:06:30] AndyRussG: cwd ejegg awight had a fix for knab. He asked (via email) if anyone could deploy it when they got in. Does anyone seeing and/or have the ability to deploy? [16:06:54] saw that email, what is knab? [16:06:55] dstrine: yes we should deploy it... Just getting an e-mail ready [16:06:57] oh, let me take a look [16:07:00] * cwd checks the repo [16:07:02] cwd: yeah [16:07:03] * dstrine continues with the typos [16:07:36] thanks all! [16:07:42] This morning on the log no successful donations with Knab [16:07:58] ah so just removing an option [16:08:36] AndyRussG the-wub: had ideal up briefly but it may still have been broken [16:08:58] Ideal was removed again [16:08:59] dstrine: I'm seeing a lot of successful donations via ideal this morning [16:09:08] Or at least, successful according to the XML in syslog [16:09:09] At least, I don't see it on the landing page [16:09:58] cool well i'm happy to deploy this [16:10:07] 3002 ideal with OK result in syslog over a nearly 8 hour period this morning [16:10:12] (PS1) Cdentinger: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281957 [16:10:30] vs 52 with a NOK result, mostly from Knab [16:10:36] over the same period [16:11:47] (PS1) Cdentinger: Update extensions/DonationInterface/ submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281958 [16:12:14] (CR) jenkins-bot: [V: -1] Update extensions/DonationInterface/ submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281958 (owner: Cdentinger) [16:12:54] dang it [16:13:28] tried to push the submodule update before DI merged. doesn't work! [16:14:02] (CR) Cdentinger: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281957 (owner: Cdentinger) [16:14:07] good to know anyway [16:14:37] so just for the record: the banks had been working on previous days. I tested on my own yesterday. but as I tested the list of "Other banks" were not working and then a little later, the entire list of banks stopped working. And now the brief availability of ideal this morning is showing a bunch of successful results... is this a pattern of inconsistency [16:14:37] on their end? [16:15:28] or rather, is that a pattern worth noting in general (regardless of cause)? [16:15:29] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/281957 (owner: Cdentinger) [16:15:44] i don't really know...is this a case where we are using an old technology that they wish we would upgrade? [16:16:07] dstrine: hmm interesting I was thinking of looking for time-grouped failures [16:16:10] cwd: I'm unsure but that's a good question [16:16:14] (Abandoned) Cdentinger: Update extensions/DonationInterface/ submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281958 (owner: Cdentinger) [16:17:42] (PS1) Cdentinger: Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281959 [16:19:31] (CR) Cdentinger: [C: 2] Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/281959 (owner: Cdentinger) [16:27:24] dstrine: oops thos numbers above are double what they should be [16:27:33] Still the same ratio [16:28:31] ok but that is still a patter of a bunch of successes. [16:30:08] the-wub: can you remember the time frame in which ideal was available? MBeat I'm wondering what DS saw during that time. [16:30:14] !log updated payments from bbf36d804220b61b8eb7e5bf7a9c427d98ae1aaa to 6dbd26ce56f416af07655f9c500023096678450b [16:30:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:32:33] dstrine: yep [16:33:05] deploy looks ok, i don't see no knab bank [16:35:07] yep, successfully commented out [16:36:54] kind of a mix so far today, dstrine - we are seeing iDEAL error tickets but it’s hard to pin down exactly what donors are seeing. ty cwd and all for knab removal [16:40:28] dstrine: I restored it at 0956 UTC today. it's still up [16:40:30] you bet! [16:42:53] cwd: woohoo [16:55:24] (PS2) Cdentinger: AstroPay: look up method and submethod together [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 (owner: Ejegg) [16:55:59] rebooting for kernel update, brb [16:57:33] thanks MBeat and the-wub for the info [16:58:09] thanks cwd AndyRussG and ejegg for the deploy! [17:13:27] Hey all, fr-online wants to run astropay 1 hour test (except mexico) at 10:30. is someone available to watch? [17:14:32] i'm supposed to be in scrum of scrums for the start [17:14:38] or does is need active watching? [17:14:45] but i can have it in a terminal [17:15:08] ok thanks. [17:15:32] speaking of which, any scrum of scrums news awight AndyRussG cwd XenoRyet ? [17:15:48] Na, not from me. [17:15:55] ejegg: nope thx tho! [17:16:03] ejegg: maybe--Education Program needs a rails contractor this quarter... [17:16:08] I can explain more in a few. [17:16:55] ejegg: good here! [17:17:31] ok awight, i'm all ears [17:20:18] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, and 2 others: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2184150 (AndyRussG) This morning @Pcoombe re-enabled iDEAL. According to the serv... [17:31:13] dstrine: hey I'm here [17:31:52] awight - just tell ppl to ask you if interested in rails for ed program? [17:32:03] ejegg: The deal is basically, AndyRussG|thnrgx and I were supporting the Education Program work, and both had to drop it like a hot brick at the end of the scheduled month. [17:32:22] ejegg: EP suddenly found itself some contractor cash ( :( probably from quitting )\ [17:32:39] so now they need to spend that by July. I'd love to jump in, but... have this job thing ;) [17:32:41] aww [17:32:56] k, I'll float the idea [17:33:01] They desperately need to find a contractor who can help finish that work--Tighe Flanagan is the contact there [17:33:35] He's talking to Sage Ross (Wiki Education Foundation) about WEF being that contractor, I'm not sure which is better, though [17:33:38] thanks! [17:43:18] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2184218 (DStrine) @awight and I talked. it may actually be... [17:43:59] Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-Ingenico: iDEAL form doesn't display red error borders or text - https://phabricator.wikimedia.org/T131913#2184221 (DStrine) [17:44:01] Fundraising-Backlog, FR-Ingenico: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#2184220 (DStrine) [17:45:24] (PS1) Ejegg: Update form settings for CL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281968 [17:46:52] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#2184226 (DStrine) [17:51:49] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Ingenico: Give error feedback when iDeal cannot connect to bank - https://phabricator.wikimedia.org/T92567#1114921 (DStrine) There is a second case too: Steps: * Fill in all correct information * Select a ba... [17:52:05] Fundraising Sprint Ghostbusting , Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Give error feedback when iDeal cannot connect to bank - https://phabricator.wikimedia.org/T92567#2184246 (DStrine) [17:52:48] getting a little logspam, this should help: https://gerrit.wikimedia.org/r/281968 [17:54:01] (CR) Cdentinger: [C: 2] Update form settings for CL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281968 (owner: Ejegg) [17:54:26] ty cwd [17:54:47] np [17:55:45] (Merged) jenkins-bot: Update form settings for CL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281968 (owner: Ejegg) [17:57:13] Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-Ingenico: iDEAL form doesn't display red error borders or text - https://phabricator.wikimedia.org/T131913#2182779 (awight) a:awight [17:59:02] uh, oh. Error: fredge astropay-34825191.0: Data in field payment_submethod is too [17:59:31] too... [17:59:37] "cash_provencia_pagos" [17:59:44] too long [18:00:22] Grr, it gets field length from SQL introspection, so we need a migration. [18:05:39] Aiee! And the field is already 32 chars in production. [18:12:17] (PS1) Awight: Extend the fredge payment_submethod column to 32 chars [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281971 [18:15:26] ccogdill: did you bring a lunch today? or want to walk and get something? [18:15:39] awight I’m wfh today :D [18:15:44] hah! [18:15:51] nice day for it, I hope you have a balcony [18:15:56] I brought my armchair out on the balcony and now I can’t seem to leave [18:16:00] haha exactly [18:16:08] that's amazing. I've been stuck at home for days for the same reason. [18:16:13] "stuck" [18:16:23] I put a couch on the porch. It's the greatest... [18:17:13] we seem to have similar styles [18:17:20] outdoor furntiture be damned! [18:18:17] hehe, exactly. That's what tarps are for. [18:20:32] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2184312 (CCogdill_WMF) Cool @awight, thanks! > select count(*) from civicrm_contact c... [18:22:20] awight: ooh, dang [18:32:53] awight: it still runs the alter table command when the column is already 32 wide [18:33:08] mariadb is smart enough not to do the whole copy thing though, right? [18:33:11] really?? [18:33:16] ah, that's fine [18:33:21] yeah, I tried locally on a db of 3M rows [18:33:28] the actual alter takes forever [18:33:36] but alter 32 is a no-op on production. [18:34:41] cool [18:35:25] (CR) Ejegg: [C: 2] "Looks good, still runs the alter table but seems to be quick when no change is needed." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281971 (owner: Awight) [18:36:57] (PS1) Awight: [WIP] Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) [18:38:21] (CR) jenkins-bot: [V: -1] [WIP] Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) (owner: Awight) [18:40:02] AndyRussG|thnrgx: I'm getting your bug (I think) now, all iDEAL redirects return an error 430900 [18:42:40] awight|lunch: u mean locally? [19:27:19] ejegg: didja see my reply to ur comment here? any thoughts? https://gerrit.wikimedia.org/r/#/c/277792/6/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js [19:28:58] AndyRussG: oh right, I just wanted to make sure tabbing + space triggered the click event... [19:29:21] ejegg: ah hmm tabbing... Didn't think of or try that.... [19:29:43] I assume it would, though enter wouldn't (unless focus were on the button) [19:29:43] will test right quick [19:29:48] Ah nice thx! [19:30:18] remember the patch is still marked WIP... I was just thinking, I wonder if we should add some tests before deploying? [19:34:08] like browser tests? [19:36:01] (CR) Ejegg: [WIP] Admin UI: Optimize handling of changes to campaigns via list (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [19:36:44] ejegg: or phpunit and qunit [19:37:04] ah yes [19:37:30] thx 4 the CR :) [19:37:48] do u think phpunit/qunit should go in the same Gerrit change, or separately? [19:37:56] I guess separate is cleanr [19:37:59] hmm, there's a lot of DOM manipulation here [19:38:36] yep [19:38:36] guess you could test setChange [19:40:06] yea [19:40:07] I'd definitely merge as-is if it weren't still marked WIP [19:40:47] ejegg: K I'll un-WIP and we can discuss weather rain or snow... sorry I mean, whether tests or no tests prior to deploy [19:41:01] sound good? [19:41:33] yep! [19:50:17] AndyRussG: yes, locally [19:54:19] (PS2) Awight: Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) [19:54:35] Anyone free to review? ^ [19:54:46] looking [19:54:56] I wasn't able to complete the redirect due to mysterious local failure :( [19:55:03] but it acted the same with master as with my patch. [19:56:06] Fundraising Sprint Ghostbusting , Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Give error feedback when iDEAL cannot connect to the bank or on other errors - https://phabricator.wikimedia.org/T92567#1114921 (awight) p:Normal>High a:aw... [19:56:13] (CR) jenkins-bot: [V: -1] Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) (owner: Awight) [19:56:32] ejegg: oh... I should fix that test failure though [19:57:01] probably a good idea :) [20:01:41] (PS3) Awight: Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) [20:04:04] AndyRussG: standup? [20:07:17] dstrine: oops coming! [20:33:20] ejegg|mtg: cwd: When would be a good time to chat about Mustache forms and payment methods? [20:34:23] awight: 3:30 your time work? [20:34:40] great! cwd that good for you [20:34:41] ? [20:35:35] is that in 2 hours? [20:35:45] yep [20:35:50] yep, wfm [20:35:55] thanks [20:38:25] awight: in the mean time do you want to merge the ideal for spruce ups? [20:38:29] *form [20:38:36] sure! [20:39:08] should this be moved to "Done" and closed? Or does it include getting the Knab bank re-activated? https://phabricator.wikimedia.org/T131181 [20:40:06] AndyRussG: Good question--I suppose it's done, and the followup work is in https://phabricator.wikimedia.org/T128692 [20:40:51] awight: K... and if GC finds it can re-enable Knab we'll see what that entails when it happens, I guess? [20:40:55] whatever this intra-line diff gerrit uses is ridiculous [20:40:59] dstrine: sound good? ^ [20:41:56] cwd: download the patch, then: [20:41:56] #!/bin/bash [20:41:56] git difftool -d $1~1 $1 & [20:42:23] I call it difftooldir [20:43:07] though I have other nicknames for it when I'm feeling blue [20:43:19] hehe [20:43:50] i know there are folks among us not using git-review or gerrit at all [20:44:08] Mmm I think so [20:44:31] but i haven't dredged up the motivation because ostensibly we're moving to phab [20:44:57] I confess I didn't like github on the WikiEdu Dashboard project. It made for messier history I think [20:45:27] Maybe it was how I was using it [20:45:30] * AndyRussG continues to repeat self [20:45:42] Rather how the project was using it [20:46:38] cwd: I agree that the gerrit diff is awful, but have you tried ignore whitespace and unified vs side-by-side? [20:46:58] I guess what I mean is, show me a better diff ;) [20:48:17] Fundraising-Backlog, Hovercards: Avoid z-index conflict with HoverCards & Central Notice and friends - https://phabricator.wikimedia.org/T131364#2184728 (dr0ptp4kt) Thanks, @Pcoombe! @jhobs, would you be able to confirm whether HoverCards will properly overlay QuickSurveys? [20:48:32] i have been robotically clicking on side-by-side... [20:48:56] yeah i prefer unified, generally [20:49:17] but i should also add the markup is broken and line wrapping at 50% container width [20:49:32] ha [20:49:36] on chromeos [20:50:27] personally I like the wrapping, but you can just crank Columns up to 1000 [20:51:00] Intraline difference doesn't seem to work, I haven't tried that before [20:51:52] is it 80chars that it's wrapping at? [20:53:25] 100 [20:53:26] Ok, I figure I'll ask in here. I just received a re-validation request for the shop.wikimedia.org ssl certificate. So I need to know who to chat with about this =] [20:53:42] (my next step was emailing ops/engineering list but irc is always easier first step) [20:53:45] cwd: you get into the Preferences pane? [20:53:56] Anyone know who handles the shopify stuff for us? [20:53:59] robh: lemme see, it's a contractor... looking [20:54:04] awesome =] [20:54:18] we just changed ssl vendors since last year, so I need to sync up with them to get them a new private key and ssl cert. [20:54:58] robh: Gretchen Holtman, will PM the email when I find it [20:55:03] awight: i dont think its even a valid request, since we're using the glovalsign cert now [20:55:10] i think its just digicert trying to get us back, but i cannot be certain [20:55:21] so i want to make sure neitehr the contractor nor shopify is attempting to renew the digicert cert is all =] [20:55:25] (non emergency) [20:55:56] Thanks for looking out for us! [20:56:04] thx for the contact info =] [21:02:04] awight: i only see rows... but it is really of no consequence [21:02:12] just vacuuming the gerrit cat [21:02:20] AndyRussG: and awight so we removed knab. but are we assuming it's just not available anymore or could we investigate bringing it back? [21:02:21] i will actually examine the content of the patch now [21:02:58] dstrine: I think we'll wait to see if GC finds something on their end? [21:03:19] So we'll close the task and see what follow-up follows when we hear back from them, I think [21:03:35] AndyRussG: ok I will make sure we ask them specifically to investigate knab [21:03:43] I don't see any new Knabs in the log since the deploy went out, so that worked [21:03:54] dstrine: next step there might be that ticket about finding a method to ping the banks [21:04:07] Huh intresting [21:04:09] GC said they have one, but awight thought of another way? [21:04:27] cwd: awight had some ideas about making it easy to enable or disable banks via config or even params passed from banners [21:04:40] I think "saucey" was the adjective he used [21:04:40] ooh, ok [21:04:45] sound about right [21:05:04] cwd: it didn't sound like we could implement the ping in time for this campaign [21:05:17] i think it also costs money per request? [21:05:21] relative to other things [21:05:29] yeah $ too [21:06:16] i feel like that would be the Right Way to tell when knab comes back [21:07:00] (PS1) Awight: Reuse common error display code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) [21:07:08] One more for review ^ [21:07:54] looking [21:08:27] (CR) jenkins-bot: [V: -1] Reuse common error display code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:09:03] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, and 2 others: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2184806 (AndyRussG) Closing, since the deployed patch seems to have effectively r... [21:09:10] * awight burns entrails in honor of our unit tests [21:09:15] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, and 2 others: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2184807 (AndyRussG) Open>Resolved [21:10:52] https://sadbastard.org/images/approve2.gif [21:11:10] (PS2) Awight: Reuse common error display code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) [21:12:40] grunt job works out of the box. /me blinks [21:13:25] Fundraising Sprint Ghostbusting , Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Fix "Notice: Undefined index: next_time_24h in SpecialHideBanners.php" - https://phabricator.wikimedia.org/T120890#2184835 (AndyRussG) [21:14:25] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, and 2 others: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2184842 (MBeat33) Thank you, @AndyRussG [21:14:32] (CR) jenkins-bot: [V: -1] Reuse common error display code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:14:38] dstrine: I put this in the sprint, in Pending Dee, since the patch was just merged and we can deploy when we do other CN [21:14:41] https://phabricator.wikimedia.org/T120890 [21:15:29] AndyRussG: so it was fixed along with something else? [21:15:41] (nope, grunt gave me a false positive) [21:16:00] awight: is this complaining about old code that had never been pushed through CI before or something? [21:16:37] (PS3) Awight: Reuse common error display code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) [21:16:39] yeah [21:16:40] dstrine: no it was worked on a few Springs ago, and though the patch was merged kinda recently [21:16:42] killin me [21:16:47] (CR) Ejegg: "Looks good so far, just trying to figure out what else should be changed at the same time, and what should just be deleted. Webitects2nd-" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:16:52] AndyRussG okee [21:17:12] "style errors" [21:17:18] * cwd goosesteps [21:17:31] (CR) Awight: "I'm going for lightest touch, fwiw..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:18:10] cwd: you have obtained the newest model of Youth Party insignia, correct? [21:18:25] * cwd salutes [21:18:38] (PS7) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [21:18:39] your parents are disloyal to the folk. [21:18:56] and your dog's breath smells like salsa. [21:19:17] * cwd dramatic moral quandary w/ voiceover [21:19:26] * awight reports self [21:19:57] ? [21:21:16] (CR) Ejegg: "good call, just worrying that the -US version will now have duplicate errors, since it runs both scripts. Trying to test locally..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:21:22] (PS8) AndyRussG: Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [21:21:26] AndyRussG: We're guffawing at marginally helpful but overwhelmingly pedantic lint errors in https://integration.wikimedia.org/ci/job/npm-node-4.3/4178/console [21:21:57] ejegg: Thanks for the thorough look! [21:22:34] ahahahah [21:22:41] I do that actually [21:22:51] * AndyRussG 's brain smells well washed [21:22:52] ejegg: How does -US get loaded? [21:23:14] ooh I see [21:23:32] on further investigation... looks like it doesn't [21:23:45] formsettings has no payment methods enabled for that form [21:23:49] seems disjoint from the rtbt forms, happily [21:24:02] we should take a few passes at that cruft, verily. [21:24:13] yarp [21:24:29] hmm, does anyone know who I talk to if my VPN isn’t connecting? :/ [21:24:47] I'd say just make mustache versions of everything so we can delete it all without too much investigation [21:24:53] ccogdill: OIT [21:24:56] ccogdill: probably office IT? [21:25:03] okay cool, thanks ejegg! [21:25:08] ejegg: for real [21:25:09] and awight :) [21:25:35] ccogdill: ... the hidden dangers of working from a balcony :) [21:25:45] I know :( [21:33:27] (CR) Ejegg: [C: 2] "OK, looks like all of the forms that would be loading both this js and other validation are disabled in formsettings due to having no paym" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:34:11] Here's an easy one... https://gerrit.wikimedia.org/r/#/c/281491/ [21:37:33] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2184928 (CCogdill_WMF) Got it :) I guess this won't trigger any major influx of opt-out... [21:39:20] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2184947 (awight) @CCogdill_WMF Actually, you were right, there should be a flood of op... [21:39:36] awight: i have no experience with that repo :( [21:39:53] we can decline this old thing, eh? https://phabricator.wikimedia.org/T19108 [21:40:21] It's effectively done, as regards underlying need [21:40:34] cwd: It's just python packaging... I might be wrong about the structure, though--the Python bits of that repo are tightly coupled, so maybe I don't want packaging in a subdir. [21:40:58] AndyRussG: woohoo, that's an old one! [21:41:12] * AndyRussG is cleaning out browser tabs.... [21:41:26] brings back memories? [21:41:59] Updated vagrant links for new params: https://gerrit.wikimedia.org/r/282059 [21:42:11] so many years... so many tears. [21:42:13] * AndyRussG dries a tear watching the last snowfal [21:42:15] snowfall [21:42:53] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2184955 (CCogdill_WMF) Okay okay really got it this time. Let me know what day I should... [21:44:25] (PS4) Ejegg: Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) (owner: Awight) [21:45:29] (PS2) Awight: Double up on exclusion logic--treat !is_primary the same as is_deleted [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/281884 (https://phabricator.wikimedia.org/T122411) [21:46:23] (CR) Ejegg: [C: 2] "Looks good! TODO: validate that they chose a bank on client side." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) (owner: Awight) [21:46:36] (PS4) Ejegg: Reuse common error display code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:48:22] (Merged) jenkins-bot: Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281974 (https://phabricator.wikimedia.org/T131913) (owner: Awight) [21:48:42] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Opt out field not working with Engage import - https://phabricator.wikimedia.org/T130768#2184963 (LeanneS) @XenoRyet It worked! Thanks for fixing. [21:49:12] (Merged) jenkins-bot: Reuse common error display code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282001 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:49:31] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Opt out field not working with Engage import - https://phabricator.wikimedia.org/T130768#2184973 (XenoRyet) Open>Resolved [21:49:57] (CR) Ejegg: [C: 2 V: 2] "Nice! Looks like just the thing." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/281884 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [21:51:58] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2184978 (awight) [21:52:21] gotta relocate, back soon! [21:52:44] ejegg|afk: Can this be deployed? Update form settings for CL [21:53:49] no worries, I'm picking around it for now. [21:54:05] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282061 [21:54:07] (PS1) Awight: Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282062 (https://phabricator.wikimedia.org/T131913) [21:54:09] (PS1) Awight: Reuse common error display code [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282063 (https://phabricator.wikimedia.org/T92567) [21:54:17] (CR) Awight: [C: 2] Reuse common error display code [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282063 (https://phabricator.wikimedia.org/T92567) (owner: Awight) [21:54:23] (CR) Awight: [C: 2] Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282062 (https://phabricator.wikimedia.org/T131913) (owner: Awight) [21:54:30] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282061 (owner: Awight) [21:55:59] (PS1) Awight: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/282065 [21:56:08] (CR) Awight: [C: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/282065 (owner: Awight) [21:56:15] awight: yes, totally deployable [21:56:18] oops! [21:56:21] k I'll add that [21:56:54] (CR) Awight: [V: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/282065 (owner: Awight) [21:57:18] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282061 (owner: Awight) [21:57:24] !log update fundraising-tools from d8c5cc0b399411efa3b0634fa891a236c3dbaab2 to b114b7174c3bd9bf53cd44bf55397049a03b96fb [21:57:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:57:32] (Merged) jenkins-bot: Bring iDEAL forms more in line with our newer RapidHtml forms [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282062 (https://phabricator.wikimedia.org/T131913) (owner: Awight) [21:58:01] (PS1) Awight: Update form settings for CL [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282066 [21:58:13] (CR) Awight: [C: 2] Update form settings for CL [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282066 (owner: Awight) [22:00:20] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2184978 (awight) @CCogdill_WMF I've split the export piece of the parent task out so we can deploy... [22:01:10] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2185043 (CCogdill_WMF) Great, I'll get back to you after the import happens in the morning! Thanks v... [22:01:12] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/282068 [22:01:22] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/282068 (owner: Awight) [22:02:36] (Merged) jenkins-bot: Update form settings for CL [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/282066 (owner: Awight) [22:02:41] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Move old Ingenico audit files - https://phabricator.wikimedia.org/T131426#2185047 (awight) Resolved>Open Happened again... [22:05:26] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/282070 [22:05:36] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/282070 (owner: Awight) [22:19:11] Fundraising-Backlog, FR-Ingenico: Failure to regenerate Order ID on iDEAL form - https://phabricator.wikimedia.org/T131983#2185087 (awight) [22:19:28] (CR) Cdentinger: [C: 2] Enable syslog on OSX [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277793 (owner: Ejegg) [22:21:57] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/282070 (owner: Awight) [22:22:03] awight, ejegg, can someone clear a gerrit/zuul thing up for me? [22:23:22] some repos, if i hit publish comments, will run the build and submit if successful. some will not submit until i press submit. some, if i press submit, will merge immediately without running the build. is that correct? [22:23:23] cwd: It's hung right now, greg-g says they've almost ifxed it [22:23:42] nothing's hung [22:23:46] cwd: A kitten dies when we press "force submit" [22:23:47] look at https://integration.wikimedia.org/zuul/ [22:24:01] it's waiting for the wikibase patch to merge, which is unfortunately a slow test [22:24:12] cwd yep, settings are different for different repos [22:24:14] greg-g: Why is there a non-parallel step in there? [22:24:16] force submit? [22:24:24] is that the same as "publish and submit" ? [22:24:38] please don't force-submit unless an actual emergency [22:24:40] yeah [22:24:46] it breaks things [22:25:01] but then we have some repos that won't merge until you go back and press submit post-build [22:25:05] that has burned me [22:25:48] awight: i would really appreciate you giving me/us more than 1 minute to tell you not to do that [22:26:05] this casuses problems for everyone else now, instead of you just waiting another 8 minutes or whatever [22:27:07] (he apologized in -releng) ;) [22:27:09] greg-g: agreed--doing my apologizing in the releng channel! [22:27:11] hehe [22:27:14] :) [22:27:48] now, at the same time, those wikibase tests are slow as ass [22:29:55] * cwd hears yelling, hides in closet [22:30:25] related: https://phabricator.wikimedia.org/T126670 [22:30:55] * greg-g refrains from making an off-color 'parents-who-fight' joke [22:31:30] i did my best dancing around it [22:31:52] is this what it sounds like when doves cry on irc? [22:32:37] https://sadbastard.org/images/sad.gif [22:32:39] ejegg: well done sir [22:34:21] !log update fundraising-crm from 4cc17b635eb84204cced107d5de78533cc5ce06c to a20ac4c64e195732a27d0e9cfd33f0c23f4a8d4e [22:34:21] Not expecting to hear !log here [22:34:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:34:35] stashbot: who that is [22:34:38] stashbot: help [22:35:28] stashbot: where is your configuration? [22:36:20] !log drupal update wmf_fredge_qc:7003 [22:36:20] Not expecting to hear !log here [22:36:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:37:47] MBeat: the-wub: I'm deploying some iDEAL usability improvements, buckle yr seatbelts... [22:38:09] thanks, awight, helmet’s on too [22:38:13] !log update payments from 6dbd26ce56f416af07655f9c500023096678450b to f71d3fbc7b8331b0427748b3fd358b5e2fc626fa [22:38:14] Not expecting to hear !log here [22:38:19] hey awight any interest in attending _your own meeting you scheduled_ [22:38:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:38:29] awight: stashbot is my bot [22:38:43] I guess I need to teach it about your SAL [22:38:46] deployed. [22:38:47] hehe [22:38:51] bd808: thanks! [22:38:56] cwd: aaargh [22:39:30] :) [22:39:54] awight: so !log here goes to the prod SAL? [22:40:00] bd808: yep! [22:43:59] stashbot is the shizz [22:46:25] hmm [22:49:10] !log Testing stashbot response in #wikimedia-fundraising [22:49:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:49:37] awight: all better now -- https://tools.wmflabs.org/sal/log/AVPtw98E1EdYBLP_7ksN [23:04:56] bd808: fast work, thanks! [23:06:03] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Form chooser should query gatway capabilities to route donation - https://phabricator.wikimedia.org/T131989#2185307 (Ejegg) [23:06:29] I'll breathe easier now :p [23:15:11] Fundraising-Backlog, FR-Ingenico: Consider moving rtbt_ideal to be a top-level payment method - https://phabricator.wikimedia.org/T131994#2185391 (awight) [23:15:23] Fundraising-Backlog, FR-Ingenico: Consider moving rtbt_ideal to be a top-level payment method - https://phabricator.wikimedia.org/T131994#2185403 (awight) [23:15:42] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Render rapidfail error forms with mustache - https://phabricator.wikimedia.org/T131995#2185404 (Ejegg) [23:16:10] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Form chooser should query gatway capabilities to route donation - https://phabricator.wikimedia.org/T131989#2185434 (awight) This lets us incrementally remove form chooser settings when they are completely redundant with gateway config. [23:47:03] eileen: I was hoping to get your input on https://phabricator.wikimedia.org/T122411#2182776 [23:47:25] I don't see any harm in saving old email addresses for contacts--does this seem wasteful or invasive to you, though? [23:47:39] Would you suggest I implement this as a save hook, or as a core Civi feature? [23:49:35] awight: there is no harm in it - we would also be able to retrieve that info from the logging tables if we wanted. [23:50:56] (Abandoned) Awight: WIP remove audit cruft [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220711 (owner: Awight) [23:51:00] I recall in the past adding an address history tab to the contact record for someone [23:52:10] eileen: So, perhaps I make a core patch to * Add "Old" location type * On save, old addresses are moved to that type and we create a new civicrm_email record for the new primary email? [23:53:45] awight: I think it would be an extension rather than a core patch - I feel like you would unearth a long discussion at minimum for a core patch on that [23:54:21] hehe [23:54:37] Adding a report to retrieve that info from the log tables would probably be less contentious but people already do wierd & wonderful things with their location types... [23:55:01] ok, good advice. extension rather than wmf_civicrm hook? [23:55:57] (Abandoned) Awight: DO NOT MERGE Move GC audit module to _old [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/220680 (https://phabricator.wikimedia.org/T86090) (owner: Awight) [23:56:48] awight: well just adding to our hook is the easiest [23:56:58] setting up an extension is more caring / sharing [23:57:24] Or, last option is that I expose that data from the civicrm_log_email table [23:57:36] I don't really like that option, although it's a nice hack [23:57:50] hmm. maybe I'll warm up to it, actually [23:58:25] Using slowly changing dimension data in Civi natively would be a great step forward. [23:58:26] I don't think it's so much a hack - in that it's accessing the audit trail of emails a person has had