[00:02:23] indeed i do [00:02:35] mwalker: btw hi! i am casey and i work here now [00:03:05] cwd: my brother is remodeling a bathroom and sent me a text today that said "from my experience everyone who lived/worked anywhere before you is an asshole who did weird shit to the place" [00:04:02] eileen: Hi! I just noticed a funny thing about the Civi generated SQL, [00:04:05] ../civicrm/sql/civicrm_data.mysql:UPDATE civicrm_domain SET version = '4.6.11'; [00:04:36] bd808: [write code|work on houses] like your successor is a violent psychopath [00:04:52] !! [00:05:00] * awight catches breath [00:05:09] I've been chastised for using that one before [00:05:09] * cwd looks over shoulder [00:05:48] also your regex doesn't parse ;) [00:07:03] bd808: which one? [00:07:39] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2188906 (awight) I found at least one huge bug so far, that the primary email for a deleted contact... [00:08:01] "[write code|work on houses]" should be "(write code|work on houses)" unless you only want to match a single character [00:08:15] oh heh that one [00:08:29] * cwd been neck deep in sed all day [00:08:51] I guess technically it parses so my well actually deserves a well actually [00:09:09] but several characters are redundant! [00:09:55] I read `sed` as `sad`; noticed my error; decided they were interchangeable [00:10:29] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2188911 (awight) @CCogdill_WMF One thing we could do to improve our lot is, keep a master unsubscr... [00:10:36] * cwd squints at for loop syntax [00:11:10] bd808: what don't people like about the psycho advice? [00:11:51] insensitive to persons who have actually been harassed or feared harassment apparently [00:12:25] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2188912 (CCogdill_WMF) @awight that sounds like a great tool for me and Donor Services, I'm behind y... [00:13:32] bd808: "write code like linus is going to review it" [00:14:10] (PS1) Ejegg: Clear up some ffname logspam [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282301 (https://phabricator.wikimedia.org/T132119) [00:15:28] cwd: ouch, yeah. [00:16:23] Fundraising Sprint Ghostbusting , Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: 'Try again' links lead to bad ffname logspam - https://phabricator.wikimedia.org/T132119#2188921 (Ejegg) [00:21:25] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Astropay: "go back" (volver) sometimes takes user to the TY page - https://phabricator.wikimedia.org/T131401#2188926 (Ejegg) Open>Resolved Fixed on AstroPay's side - now returns a failure code, so... [00:58:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Epic] Maintain a master unsubscribe list - https://phabricator.wikimedia.org/T132121#2188958 (awight) [01:12:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Epic] Maintain a master unsubscribe list - https://phabricator.wikimedia.org/T132121#2188981 (CCogdill_WMF) Date added to the list *is* helpful - although that data exists on the silverpop side as the date they "opt in" to the suppression list. Thanks... [01:14:57] (PS1) Awight: Don't export Contact ID [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282303 [01:14:59] (PS1) Awight: [WIP] Simplify export by not explicitly tracking opt-outs [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 [01:19:18] cwd: A chicken just edited silverpop_export... [01:19:40] Their new thing is to act semi-domesticated and do things indoors. [01:21:19] haha, did it peck your keyboard? [01:52:13] It's a strategy [01:52:56] I think there's a clause in our contracts that forbids boiling and eating contributors [01:57:09] I'm definitely having second thoughts, if I can subcontract this thing... [01:57:24] gotta run, but I'll be pecking at the keyboard later tonight :-/ [02:00:17] (PS2) Awight: [WIP] Simplify export by not explicitly tracking opt-outs [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 [02:38:03] (PS2) AndyRussG: Remove three deprecated modules [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [02:42:39] (CR) AndyRussG: "Just removed the modules from the SkinMinervaDefaultModules hook handler, too." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [03:25:23] (CR) AndyRussG: kvStoreMaintenance: Refactor to use requestIdleCallback (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [05:26:02] (PS3) Awight: [WIP] Simplify export by not explicitly tracking opt-outs [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 [05:26:04] (PS1) Awight: Escape paging IDs [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282308 [05:33:35] (PS4) Awight: Simplify export by not explicitly tracking opt-outs [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 [05:42:21] (PS5) Awight: [DO NOT MERGE] Calculate opt-outs using change log [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 (https://phabricator.wikimedia.org/T122411) [05:42:23] (PS2) Awight: Escape paging IDs [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282308 [05:42:25] (PS2) Awight: Don't export Contact ID [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282303 [11:08:00] (CR) Paladox: "Your welcome." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [11:09:41] (CR) Paladox: Remove three deprecated modules (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/280715 (owner: Paladox) [13:45:47] (CR) AndyRussG: "Cool!! :) Just a minor comment and some musings..." (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [15:25:16] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2190660 (CCogdill_WMF) Uh oh @awight, the unsubscribe file import didn't happen last night in Silver... [17:24:24] Hi! Wringing out a few hours of work today... [17:27:49] hi awight ! [17:28:37] awight: you think this is enough to stop the max_attempts errors: https://gerrit.wikimedia.org/r/282297 ? [17:33:21] ejegg: wow, elegant fix! [17:33:59] (CR) Awight: [C: -1] "Great idea! My only criticism is that the log message will be incorrect." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282297 (https://phabricator.wikimedia.org/T131983) (owner: Ejegg) [17:34:37] good call, we should distinguish those [17:36:44] gotta clean some barf zones for 10 min [17:40:06] Ohnoes! [17:46:40] (PS3) Ejegg: AstroPay: look up method and submethod together [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 [17:47:06] cd [17:47:28] * ejegg has focus issues [17:49:39] hehe. I do like when we accidentally emit subconscious into IRC [17:49:44] mine usually sounds like "ls" [17:49:48] ls ls ls [17:50:03] like a whispering breeze [17:53:52] ejegg: you see my moon shot btw? https://gerrit.wikimedia.org/r/#/c/282304/ [17:54:41] nice! [17:57:09] It all hinges on whether we can stop collecting information about opted out contacts, I should probably get ccogdill to bless that part [17:57:36] So simple, though. We gather all email addresses we've ever seen, and subtract the active ones. [17:58:36] yeah, very nice! [18:02:09] (PS2) Ejegg: Minimalist iDEAL order id refresh fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282297 (https://phabricator.wikimedia.org/T131983) [18:03:00] (CR) Awight: [C: 2] Minimalist iDEAL order id refresh fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282297 (https://phabricator.wikimedia.org/T131983) (owner: Ejegg) [18:12:59] (Merged) jenkins-bot: Minimalist iDEAL order id refresh fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282297 (https://phabricator.wikimedia.org/T131983) (owner: Ejegg) [18:14:09] (PS1) Ejegg: Minor PHPDoc cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282406 [18:15:42] What is ew? [18:15:58] E-wallet [18:15:59] "For cash, rtbt, ew, refresh order ID on repeats" [18:16:02] Ahhh K [18:16:10] ooh, but I show abandon that [18:16:12] *should [18:16:12] Which adapter is that [18:16:19] Ahh hmm [18:16:20] globalcollect [18:16:31] but there was a lazier fix that awight just merged [18:16:48] Ah K so https://gerrit.wikimedia.org/r/#/c/282295/ no more.... [18:16:59] Glad I asked! [18:17:08] (Abandoned) Ejegg: WIP For cash, rtbt, ew, refresh order ID on repeats [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282295 (https://phabricator.wikimedia.org/T131983) (owner: Ejegg) [18:17:51] any non-abandon-destined DI patches wanting of review? [18:18:25] https://gerrit.wikimedia.org/r/282301 [18:19:01] https://gerrit.wikimedia.org/r/282229 https://gerrit.wikimedia.org/r/282231 https://gerrit.wikimedia.org/r/282300 [18:19:18] none especially important [18:19:53] Ah k.... any more important than others? [18:20:33] ...or anything else important DI-related that u can think of that I could do? [18:21:04] Or maybe I should turn CentralNotice-y [18:21:06] I guess the sessionVelocity ones are most useful (...29 and ...31) [18:21:27] K thx! [18:24:18] (CR) Ejegg: "good thinking! Don't need to pass the $type param through though" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281889 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [18:25:42] (PS2) Awight: Split out contribution save hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281889 (https://phabricator.wikimedia.org/T122411) [18:28:39] (PS3) Ejegg: Split out contribution save hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281889 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [18:31:01] (CR) Ejegg: "phooey, needs manual rebase" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281890 (owner: Awight) [18:31:18] (CR) Ejegg: [C: 2] Split out contribution save hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281889 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [18:31:44] (PS2) Ejegg: Fix source field on partial refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281585 (https://phabricator.wikimedia.org/T127929) (owner: Eileen) [18:32:45] (PS3) Ejegg: Fix source field on partial refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281585 (https://phabricator.wikimedia.org/T127929) (owner: Eileen) [18:33:16] (CR) Ejegg: [C: 2] Fix source field on partial refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281585 (https://phabricator.wikimedia.org/T127929) (owner: Eileen) [18:36:40] (Merged) jenkins-bot: Fix source field on partial refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281585 (https://phabricator.wikimedia.org/T127929) (owner: Eileen) [18:37:14] (PS6) Awight: [DO NOT MERGE] Calculate opt-outs using change log [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 (https://phabricator.wikimedia.org/T122411) [18:42:54] (PS2) Awight: Whitespace + readability [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281890 [19:21:54] (CR) Ejegg: "really good stuff! a few trivial things noted inline, but could merge right now" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [19:29:11] (CR) Ejegg: [C: 2] "thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281890 (owner: Awight) [19:36:18] (PS1) XenoRyet: Allow clicking on payment method to submit form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282416 (https://phabricator.wikimedia.org/T130673) [19:41:01] (CR) Awight: [C: 2] AstroPay: look up method and submethod together (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 (owner: Ejegg) [19:42:16] (Merged) jenkins-bot: AstroPay: look up method and submethod together [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 (owner: Ejegg) [19:42:38] (CR) Ejegg: AstroPay: look up method and submethod together (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/281534 (owner: Ejegg) [19:44:40] ejegg: That begs the question... now that we're reinforcing DI as the canonical place for adapter definitions, the dependency on SmashPig is backwards. [19:45:43] the dependency that doesn't exist yet? yeah... [19:46:32] Hmm, so maybe the things thatuse SmashPig are responsible for providing config [19:46:48] huh. [19:46:58] since different use cases will stiore them in different places [19:47:11] e.g. variable_get vs LocalSettings [19:48:10] (PS1) Ejegg: Explanatory comment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/282418 [19:51:20] (PS2) Ejegg: Python requirements file for installing dependencies [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/281491 (owner: Awight) [19:51:44] I think we need to be more clear about the separation of responsibilities. Listener and audit stuff certainly belongs with the API controller and config [19:51:59] I'd like for DonationInterface to be some forms and nothing else [19:52:20] all adapter things would be in SmashPig [19:52:38] which... yeah would provide some way to override default config from various sources [19:52:55] awight: you workin today? [19:53:07] (CR) Awight: [C: 2] Explanatory comment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/282418 (owner: Ejegg) [19:53:36] dstrine: yep! trying to catch up on Tuesday's hooky [19:53:38] (Merged) jenkins-bot: Explanatory comment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/282418 (owner: Ejegg) [19:53:42] * dstrine waves [19:53:44] ok [19:54:33] ejegg: hey... could I bug u for a quick outline of how to smoke test https://gerrit.wikimedia.org/r/#/c/282229/ ? [19:54:45] (CR) Awight: [C: 2] Minor PHPDoc cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282406 (owner: Ejegg) [19:55:19] sure AndyRussG|thnrgx [19:55:32] btw, what is thnrgx? [19:55:48] Heh, been wondering that myself [19:56:10] It's a nonsensical nickname suffix that I try to use when I'm not really here, though just now I am here and I had forgotten to change back to my normal self ;p [19:56:23] (Merged) jenkins-bot: Minor PHPDoc cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282406 (owner: Ejegg) [19:56:27] (CR) Ejegg: [C: 2 V: 2] "Shrink-wrapped!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/281491 (owner: Awight) [19:56:47] Not much meaning other than nonsensical and looks a little like "thing" or "things" [19:56:57] Rrrrg now I'll have to find a new one! [19:57:07] heh [19:57:29] (PS2) Awight: Clear up some ffname logspam [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282301 (https://phabricator.wikimedia.org/T132119) (owner: Ejegg) [19:57:48] Might also have been reminiscent of a Bill the Cat utterance [19:58:13] (CR) Awight: [C: 2] "This is great. We could take it one step further, and rather than pass the ffname into that session function, have a parameterless functi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282301 (https://phabricator.wikimedia.org/T132119) (owner: Ejegg) [19:58:14] AndyRussG: so, you'll need to set up a distinct fraud logger in config and turn on session velocity filter [19:58:38] then hammer the 'continue' button on e.g. the globalcollect form [19:58:53] don't even need to be hitting the real api [19:59:11] since it checks the filter before curling [19:59:38] K [19:59:44] oh wait, no need to configure the logging [19:59:49] * AndyRussG searches through globals w "Fraud" in their name [19:59:52] just look at the prefix in syslog [20:00:17] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#1207635 (XenoRyet) @ejegg Looks to me like it is. I'm getting red text errors when leaving out email or any other contact info, and the... [20:00:26] (Merged) jenkins-bot: Clear up some ffname logspam [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282301 (https://phabricator.wikimedia.org/T132119) (owner: Ejegg) [20:01:13] $wgDonationInterfaceEnableIPVelocityFilter = true ? [20:01:22] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Unplanned-Sprint-Work, FR-Ingenico: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#2191599 (awight) Woot! [20:02:20] (CR) Ejegg: "like putting ffname in session_addDonorData (and perhaps renaming the fn)?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282301 (https://phabricator.wikimedia.org/T132119) (owner: Ejegg) [20:03:01] (CR) Awight: [C: 2] "Nifty!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282300 (https://phabricator.wikimedia.org/T131401) (owner: Ejegg) [20:04:40] (Merged) jenkins-bot: Maintenance script to get AstroPay payment status [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282300 (https://phabricator.wikimedia.org/T131401) (owner: Ejegg) [20:55:49] (CR) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [20:55:53] (PS7) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [21:12:58] (PS7) Awight: [DO NOT MERGE] Calculate opt-outs using change log [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 (https://phabricator.wikimedia.org/T122411) [21:13:00] (PS3) Awight: Escape paging IDs [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282308 [21:13:02] (PS3) Awight: Don't export Contact ID [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282303 [21:22:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2191769 (DStrine) more info on some attributes: * Expected Close Date: date regular date field * Close Date: date regular date field [21:22:21] (CR) Ejegg: "fraid we need to check in the modernsyslog/build folder too, due to the way we deploy. I should make this submodule only exist on the dep" [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280665 (owner: Paladox) [21:24:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2191784 (DStrine) Please note, this task had described a "rating" field but we have struck that field for now. [21:24:42] (PS8) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [21:24:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2191785 (DStrine) [21:26:05] (CR) Ejegg: "think we merged the alternate version of this" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/280124 (owner: Awight) [21:28:54] (PS2) Ejegg: Add package modern-syslog [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280665 (owner: Paladox) [21:33:09] (CR) Ejegg: "To be consistent, is an UnstagingHelper now a NormalizationHelper?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281461 (owner: Awight) [21:39:30] (CR) Ejegg: [C: 2] NFC preliminary tidy up for CRM-18332 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/282085 (owner: Eileen) [21:42:39] (CR) Awight: "> To be consistent, is an UnstagingHelper now a NormalizationHelper?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281461 (owner: Awight) [21:45:29] (PS2) Awight: Rename $unstaged variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281461 [21:45:45] (CR) Awight: "PS 2: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281461 (owner: Awight) [21:52:25] relocating [21:53:25] (CR) Krinkle: "Real data!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [22:07:03] (PS9) AndyRussG: Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [22:08:29] (CR) AndyRussG: "Thanks much!!" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [22:11:24] grr. darn thinkpad gets stuck in sleep mode maybe 1 out of 5 times I close the lid [22:12:20] ejegg: That's annoying. Incentive to not be so macos about suspending, though :) [22:12:48] heh [22:13:07] I'm still headscratching about this normalization helper you suggested... [22:13:40] Wondering, maybe it does make sense to keep those functions in one place because by definition they are always desired? [22:13:56] I'm not sure it's legitimate to override a normalization, basically. [22:15:35] (PS1) Awight: [WIP] Split normalizations into helper objects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282436 [22:17:02] (CR) jenkins-bot: [V: -1] [WIP] Split normalizations into helper objects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282436 (owner: Awight) [22:25:14] hmm [22:27:28] (PS2) Awight: [WIP] Split normalizations into helper objects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282436 [22:28:27] those with ops-y knowledge, ideas on how to grab a list of cookie names we're seeing on production? Also, thoughts on whom to ping on #wikimedia-operations? [22:28:39] * AndyRussG sees a mass of nicknames... [22:28:39] (CR) jenkins-bot: [V: -1] [WIP] Split normalizations into helper objects [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282436 (owner: Awight) [22:29:03] awight: ejegg: cwd: XenoRyet: ^ ? [22:29:36] AndyRussG: I've only ever gone by my own prod cookies [22:29:52] Hmmm K [22:30:22] thx :) [22:31:43] Hmmm maybe Varnish [22:47:08] AndyRussG|a-whey: I don't think that's an easy list to get, it might not even be logged. [22:47:23] Interesting question! [23:20:16] (PS9) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [23:23:36] (CR) Krinkle: [C: -1] "Regardless of the inline comments, this still misses items ocasionally due to the bad assumption that the start index remains accurate aft" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [23:30:30] I'm going to head out. have a good weekend everyone! [23:47:28] (PS10) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [23:50:09] (CR) Krinkle: "Pulling out comment from https://gerrit.wikimedia.org/r/#/c/254326/6/resources/subscribing/ext.centralNotice.kvStoreMaintenance.js" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle)