[00:08:33] AndyRussG: Looks like nice things to fix! [00:09:40] awight: yeah! You mean about CN update, right? (sorry my computer battery ran out of juice a few minutes ago...) [00:11:43] (PS1) Awight: [WIP] Import errors are logged and recoverable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/283112 (https://phabricator.wikimedia.org/T88460) [00:12:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#2201782 (awight) a:atgo>awight [00:13:02] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#1012246 (awight) The patch above will log error line... [00:16:06] AndyRussG: any opportunity to clean up things that affect Analytics and Ops! [00:19:19] Hmmm right... Huh I guess I hadn't thought of it in terms of them being "affected" by outsanding patches... [00:19:45] If you mean the mixin param on /beacon/impression, I don't think it anyone was injured [00:20:12] I guess the other one might have been a logs annoyance, probly should've gone out sooner, agreed on that one, if that's what u mean [00:22:33] Just read my email, gotta go [01:52:04] (CR) Eileen: "Yeah - I agree with you about the order being a bit odd. I might yet change it again upstream to be in the constructor which is where it r" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/282086 (owner: Eileen) [02:16:56] (PS1) Eileen: Follow up to 'Sync Logging_Schema with upstream incl comma from CRM-17685' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283119 (https://phabricator.wikimedia.org/T131223) [02:17:39] (CR) Eileen: "OK - here is what was wrong with it" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/282090 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [02:21:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Task for 1 Jan (or thereabouts) adjust CiviCRM search range - https://phabricator.wikimedia.org/T132540#2201941 (Eileenmcnaughton) [02:22:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Task for 1 Jan (or thereabouts) adjust CiviCRM search range - https://phabricator.wikimedia.org/T132540#2201953 (Eileenmcnaughton) [09:21:37] (PS1) Eileen: CRM-18404 Rebuild triggers not including all tables [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283138 [12:10:38] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2202808 (Jgreen) > 10:32 am just reading this > https://dev.mysql.com/doc/refman/5.7/... [15:10:53] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/283198 [15:11:54] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/283198 (owner: AndyRussG) [15:28:03] (CR) Krinkle: "Hm.. I think the Promise handling isn't test code, but actually a useful interface. I'll go ahead and implement the limited key-collection" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [15:35:51] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/283198 (owner: AndyRussG) [15:46:42] (PS13) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [16:24:19] (PS14) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [16:27:54] (CR) Krinkle: "The promise interface is more prominent now that we have two separate idle consumers. Promise is the only sensible way to separate these t" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [16:38:04] morning ejegg! did you happen to just get an email from differential? [16:38:04] (PS1) Ejegg: Fix copypaste errors in Adyen cancel method [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/283219 [16:38:30] hi cwd, let me check [16:39:00] hey look at that, i did! [16:39:25] neat [16:39:32] .arcconfig, huh? will review! [16:39:44] yep, that's the only file you need to start using arc [16:40:00] and *apparently* if we land something from phab it will merge into gerrit [16:40:18] i haven't actually seen this happen yet but it would mean we could just start using diff for review any time [16:40:30] oho, i like! [16:40:46] and once we're solid with that process we can actually move the code to being hosted in phab so that it can maintain permission sets and so on [16:42:05] so mutable history is what other WMF teams are using? [16:44:54] yeah, immutable actually seems kind of dumb, it adds superfluous merge commits every time [16:44:59] ah, word [16:45:09] with mutable you can squash em automagically too [16:45:30] hmm, dunno when we'd actually want that, but ok [16:45:50] yeah i haven't played with that yet [16:46:11] a nice thing about this setup is that if you are a repo admin you can just push to the repo [16:46:21] cool [16:46:26] so for things that you'd self+2 you don't have to bother with review [16:46:38] but all the admins get some sort of alert if you push [16:46:50] would be good in emergencies too [16:46:55] not have to wait for CI etc [16:46:59] yeah, for sure [16:48:15] i still think this machine readable commit message shit is ridiculous [16:48:34] you mean the change-id [16:48:37] ? [16:48:55] yeah, but phab does even more of that type of thing [16:49:06] there are several pieces of data in there [16:49:52] i don't understand why these apps don't make use of databases for this purpose [16:50:05] you could put it in sqlite and it'd still be in the repo [16:51:30] huh, but it would have to change with each commit, right? [16:51:39] almost seems messier [16:52:07] would be nice if it was just an extensible field like the commit signature [16:52:32] what would have to change? [16:53:18] i dunno, haven't looked into the details of how git stores commits [16:53:30] i just mean, use the sha1 to associate stuff with commits in a db [16:53:52] but it would be cool if there was a place to stash extra commit metadata that wasn't the commit message [16:54:50] ejegg: cwd: XenoRyet: dstrine: just deployed all pending updates to CentralNotice about 45 min ago [16:55:03] \o/ [16:55:04] Good times [16:55:18] Yeah! [16:55:22] oh, nice [16:55:30] Hopefully no wikipedias will crash as a result [16:55:33] All looks good so far :) [16:55:51] i am trying to think of a reason just using the sha1 as a key in sqlite would suck [16:56:08] and storing whatever metadata there [16:56:28] you could totally use native git objects (i think gerrit actually does that) [16:56:37] but i'm not educated enough for that [16:57:16] but the sqlite db would change with each commit, right? [16:57:30] and if it's in the repo, you're adding an extra file to each commit [16:57:47] then reverts get weird, for one thing [16:57:50] i suppose that's true [16:59:49] gerrit wouldn't be too bad if it wasn't for git-review, jgit, and the front end [16:59:58] AndyRussG: YAY! [17:00:26] srsly, front end is the worst [17:02:51] cwd so differential will generate a change id when it pushes to gerrit or something? [17:03:06] beats me! [17:03:16] i mean, i don't think it will interact with gerrit at all [17:03:21] i think it just has rights to push to that repo [17:03:31] oh huh [17:04:01] missing change IDs will be problematic when we try to merge to deployment [17:04:19] oh how come? [17:04:42] well, if we try to do push the merge through gerrit anyway [17:05:05] oh right... [17:05:36] well i guess we could do that part in gerrit still [17:05:48] but yeah that's fugly [17:06:16] those would be a great use of just pushing to the repo [17:06:29] huh, I think we probably shouldn't mix review systems in one repo for now [17:07:22] i just think it'd be better to get used to this system gradually than cutting over one day and being traumatized [17:08:10] how about we start with a lower traffic repo like tools? [17:08:39] and switch over completely for that one? [17:09:26] yeah [17:09:41] couldn't we just do the deployment merge through arc too? [17:09:57] seems like it'd be basically the same PITA it is now :P [17:10:04] cwd sure, could do [17:10:33] let's just not force ourselves to do that in DI till we've all agreed to switch over [17:11:33] can you think of a problem if we did for instance just one commit and deploy through phab in the middle of using gerrit? [17:11:48] besides seeing something funny in the history [17:11:55] trying to think of anything that could actually break [17:13:22] hm, not totally sure, but I know gerrit assumes change IDs exist [17:14:05] i'd just prefer to try potentially-repo-scrambling things on something less critical [17:14:17] yeah, i wonder if it would ever have to know about those commits [17:16:44] Fundraising Sprint Ghostbusting , Fundraising Tech Backlog, Unplanned-Sprint-Work: please do a round of activemq cleanup - https://phabricator.wikimedia.org/T131787#2204038 (Ejegg) p:Triage>High a:Ejegg [17:19:26] Fundraising Sprint Ghostbusting , Fundraising Tech Backlog, Unplanned-Sprint-Work: please do a round of activemq cleanup - https://phabricator.wikimedia.org/T131787#2204047 (Ejegg) Added these four and re-ran 'old message consume' job pending_paypal.20 pending_paypal_recurring.20 payments_init_damag... [17:25:26] oh hey, any news for scrum of scrums cwd XenoRyet AndyRussG ? [17:25:32] ejegg: nothing here, thx much [17:25:37] k [17:25:38] Nope, nothing from me. [17:25:42] nope, thx [17:25:47] word, thanks! [17:40:12] Fundraising Sprint Ghostbusting , Fundraising Tech Backlog, Unplanned-Sprint-Work: please do a round of activemq cleanup - https://phabricator.wikimedia.org/T131787#2204131 (Jgreen) That brought us down from 80GB to 59GB (configured capacity is 120GB) so it's a big improvement. [17:44:09] no deploys to main cluster next week, because of datacenter switchover [17:45:10] also, please try out this new thing for labs VM management: horizon.wikimedia.org [17:48:51] also: new browser stats graphs at https://browser-reports.wmflabs.org/ [17:50:43] neat! [17:51:51] http://classicprogrammerpaintings.tumblr.com/ [17:57:56] (CR) Cdentinger: [C: 2] Fix copypaste errors in Adyen cancel method [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/283219 (owner: Ejegg) [18:06:43] (Merged) jenkins-bot: Fix copypaste errors in Adyen cancel method [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/283219 (owner: Ejegg) [18:32:44] Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2204405 (awight) Those queries look fine! BTW, you might want to take the space out from between "--raw", or omit "-- raw" entirely since it's currently not doing anything. Running that... [18:36:28] Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2204433 (awight) @CCogdill_WMF Confirmed, that something evil is happening. ``` select count(*) from drupal.contribution_tracking where utm_source like 'sp5108%'; 5167 select sum(count)... [18:47:00] (PS2) Awight: Import errors are logged and recoverable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/283112 (https://phabricator.wikimedia.org/T88460) [18:50:49] awight: yes phab is supposedly able to push to the repo gerrit hosts, but ejegg convinced me it's probably not a good idea, at least with such a critical repo [18:51:40] +1, I'd start a wee bit smaller. Frig is good! We can write some tests for that, even... [18:51:52] ah--but frig isn't in gerrit. [18:52:12] yeah... ejegg suggested tools [18:52:14] was thinking maybe tools for starters? [18:52:31] That one only has linters, no tests, but sounds good to me! [18:53:03] tests for frig sounds fun [18:53:07] I mean. same thing from a $? == 0 perspective [18:54:03] cwd: we could start with just the pyflakes sorta thing [18:54:32] hehe pep8 goes crazy [18:54:51] pep8 frig/ | wc -l [18:54:51] 112 [18:54:59] bro u pep8 me? [18:55:03] It's mostly that funky MediaWiki spacing [18:57:38] it does sound kind of verby. or like a tonic that people put in their drinks to soothe toothaches. [19:04:22] i think people should be free to style their syntax within the bounds of the language [19:04:56] if you don't want that use a language with strict syntax [19:05:00] imo [19:05:30] I'm fine with it. We just need a .pep8 config that describes oru patois [19:05:33] *our [19:05:56] oh, i thought it was pretty formalized [19:06:08] what pep8 wants [19:11:15] huh. I guess we can only disable rules [19:11:34] and config goes into tox.ini [19:11:49] Least of our worries, either way. I was just looking for an easy lint to run [19:15:08] Fundraising-Backlog: Write tests for frig - https://phabricator.wikimedia.org/T132618#2204570 (cwdent) [19:39:14] (PS1) Awight: Script to dump GET_DIRECTORY results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283266 [19:41:21] (CR) jenkins-bot: [V: -1] Script to dump GET_DIRECTORY results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283266 (owner: Awight) [19:52:59] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: Summary of campaign settings changes is not logged in CentralNotice logs when modified using Special:CentralNotice ... - https://phabricator.wikimedia.org/T110315#2204711 [19:56:10] (PS1) Awight: ISSUERID is alphanumeric due to SEPA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283276 (https://phabricator.wikimedia.org/T131904) [19:56:40] (PS2) Awight: ISSUERID is alphanumeric due to SEPA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283276 (https://phabricator.wikimedia.org/T131904) [19:56:42] (PS3) Awight: [WIP] Donors using Ingenico should always return to the resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283093 (https://phabricator.wikimedia.org/T131904) [19:56:44] (PS2) Awight: [WIP] Ingenico uses generic response handling controller [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283105 (https://phabricator.wikimedia.org/T131904) [19:56:46] (PS2) Awight: Script to dump GET_DIRECTORY results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283266 [19:59:26] Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2204723 (DStrine) [20:00:21] (CR) jenkins-bot: [V: -1] [WIP] Donors using Ingenico should always return to the resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283093 (https://phabricator.wikimedia.org/T131904) (owner: Awight) [20:00:26] (CR) jenkins-bot: [V: -1] [WIP] Ingenico uses generic response handling controller [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283105 (https://phabricator.wikimedia.org/T131904) (owner: Awight) [20:19:43] Seddon: hi! how's it going? [20:26:56] * Seddon waves to AndyRussG [20:34:17] Seddon: hi! mmm apologies for not having gotten back to you sooner about your questions on the cookie task} [20:34:37] If you still have questions, pls lmk when you'd like to talk about it :) [20:36:08] Seddon: mmm also wanted to ask: we just deployed some changes to CentralNotice, and often in such cases I've been sending a message to centralnotice-admins mailing list... But maybe now you'd prefer to do that? Either way is fine w/ me of course [20:37:11] AndyRussG: Makes sense for me to :) [20:38:12] K! The most significant update was changes to code that works the Admin UI for this task: https://phabricator.wikimedia.org/T128869 [20:38:34] Users shouldn't see anything different, but if suddenly things start not working, that'd be important to hear ;p [20:46:50] I'm gonna take a walk and be online in a couple of hours... [20:46:56] Anything I can help with before I run? [20:48:35] Seddon: Also yesterday dstrine pointed me to a really interesting-looking page u made about CentralNotice planning, which I skimmed briefly, but now I can't find it... rrrg 8p [20:50:15] AndyRussG: https://meta.wikimedia.org/wiki/CentralNotice/Process_Review [20:51:06] Seddon: right! thx much :) I'll dig in and hopefully might have some relevant feedback sooooon [20:56:26] AndyRussG: Alot of it is non-technical, some is just identifying already identified issues [20:56:42] AndyRussG: There is a big chunk around process and documentation [20:57:39] Seddon: looks like it's also mentioning lots of needs that could receive technical support tho? [21:00:42] AndyRussG: yeah, my biggest ones are improved metrics and also improvements relating to conflicting campaigns (campaign fallback the biggest and some sort of integrated calendar and request process) [21:01:13] Seddon: yeah there's light-years of room for improvement [21:01:17] on those and other points [21:02:09] One task that's out that, but that keeps getting put off, and that could also be modified, was to plan how to reach a well-founded mid- and long-term roadmap [21:02:50] AndyRussG: I would love to be involved in tha [21:02:52] that* [21:02:59] amazing! [21:04:09] Seddon: https://phabricator.wikimedia.org/T108747 [21:04:22] Seddon: and AndyRussG re fallback and metrics: they are definitely noted. Also RE roadmap: I want to discuss how to get the community involved in a constructive and scalable way. I plan to schedule time to talk about just that in a few weeks [21:04:25] We put "RFC" but it wouldn't necessarily have to be that process [21:04:45] But the idea would be somehow arrive at a methodology for teasing out the deeper longer-term requirements here [21:05:01] ^ dstrine yeah! [21:08:31] AndyRussG & dstrine actually I have a small request now I think about it, could I be subscribed on all CN tickets going forward? [21:08:55] Fer sure [21:09:07] I think dstrine is our Phabricator expert for that [21:12:56] Seddon: first off, join the CN project here: https://phabricator.wikimedia.org/project/members/291/ [21:13:17] that should give you an email any time a task is created or edited with CN project on it [21:14:23] second... I was going to advise one more thing that truly automatically adds you as a subscriber... but you probably don't want it. [21:15:15] try joining the project first.. it's lighter weight and probably gives you what you need ... emails [21:16:43] dstrine I like the sound of things I don't want :P [21:18:48] Seddon: so you want to be cc'd on all tasks automatically? [21:20:42] Seddon: I haven't used this personally but try "herald rules" https://www.mediawiki.org/wiki/Phabricator/Help/Herald_Rules [21:22:38] (CR) Ejegg: [C: 2] "seems to work" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283119 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [21:28:58] (Merged) jenkins-bot: Follow up to 'Sync Logging_Schema with upstream incl comma from CRM-17685' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283119 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [21:35:06] Fundraising Sprint Ghostbusting , Fundraising Tech Backlog, Unplanned-Sprint-Work: please do a round of activemq cleanup - https://phabricator.wikimedia.org/T131787#2205064 (Ejegg) Open>Resolved [21:53:30] Fundraising Sprint Ghostbusting , Fundraising-Backlog: SPRINT G (3/30 - 4/13) GOAL: Astropay Campaign Ready and redupe deploy - https://phabricator.wikimedia.org/T131160#2205133 (DStrine) Open>Resolved [22:03:22] (CR) Ejegg: [C: -1] "This is calling validation twice now, which pops up two alerts when anything is wrong. Maybe click should only fire if the selection isn'" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282416 (https://phabricator.wikimedia.org/T130673) (owner: XenoRyet) [22:04:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Use LocalStorage instead of cookies whenever possible - https://phabricator.wikimedia.org/T132639#2205213 (AndyRussG) [22:05:15] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LcoalStorage or delete them - https://phabricator.wikimedia.org/T132640#2205231 (AndyRussG) [22:06:25] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#1532156 (AndyRussG) Removed story points because this is now a tracking task (See blocked-by for subtasks.) [22:06:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LcoalStorage or delete them - https://phabricator.wikimedia.org/T132640#2205251 (AndyRussG) [22:06:47] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Use LocalStorage instead of cookies whenever possible - https://phabricator.wikimedia.org/T132639#2205252 (AndyRussG) [22:06:49] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2205250 (AndyRussG) [22:07:56] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2205258 (DStrine) [22:07:58] Fundraising Sprint H 2016, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2205259 (DStrine) [22:08:00] Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2205261 (DStrine) [22:08:02] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Unplanned-Sprint-Work, and 3 others: Failure to regenerate Order ID on iDEAL form - https://phabricator.wikimedia.org/T131983#2205264 (DStrine) [22:08:04] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Document mass email - https://phabricator.wikimedia.org/T132369#2205263 (DStrine) [22:08:07] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: iDEAL cancel returns donor to Thank You page - https://phabricator.wikimedia.org/T131904#2205266 (DStrine) [22:08:09] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2205265 (DStrine) [22:08:11] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Unplanned-Sprint-Work, and 3 others: Astropay: 13 digit number will hide the fiscal number in mexico - https://phabricator.wikimedia.org/T131793#2205267 (DStrine) [22:08:13] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve whether putting the logging tables in a separate DB will cause ACID compliance /rollback iss... - https://phabricator.wikimedia.org/T131231#2205270 [22:08:15] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2205269 (DStrine) [22:08:18] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, and 2 others: Agree how we will deal with the trigger create mysql when we enable triggers - https://phabricator.wikimedia.org/T131230#2205271 (DStrine) [22:08:20] Fundraising Sprint H 2016, Fundraising-Backlog: SPRINT H (4/13-4/27) GOAL: Adyen for new countries (Isreal, Ukraine and more!) - https://phabricator.wikimedia.org/T131161#2205273 (DStrine) [22:08:22] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, and 3 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2205272 (DStrine) [22:08:23] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, and 3 others: Using back button from AstroPay lands donor on unusable form - https://phabricator.wikimedia.org/T130673#2205274 (DStrine) [22:08:27] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, and 2 others: Improve the change log report - https://phabricator.wikimedia.org/T130164#2205277 (DStrine) [22:08:29] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2205278 (DStrine) [22:08:31] Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit: Some Ingenico refunds & cancels not reaching Civi - https://phabricator.wikimedia.org/T130129#2205279 (DStrine) [22:08:33] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint H 2016, Fundraising-Backlog, and 3 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2205281 (DStrine) [22:08:35] Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, and 2 others: Add 'Cancelled' type for refund messages - https://phabricator.wikimedia.org/T129714#2205280 (DStrine) [22:08:36] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, and 4 others: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotic... - https://phabricator.wikimedia.org/T128869#2205282 [22:08:40] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2205284 (DStrine) [22:08:42] Fundraising Sprint H 2016, Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2205283 (DStrine) [22:08:44] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2205287 (DStrine) [22:08:46] Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Permissions issue? "You do not have permission to access this page" - https://phabricator.wikimedia.org/T122519#2205290 (DStrine) [22:08:48] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2205288 (DStrine) [22:08:49] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, and 3 others: Fix "Notice: Undefined index: next_time_24h in SpecialHideBanners.php" - https://phabricator.wikimedia.org/T120890#2205289 (DStrine) [22:08:53] Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: GlobalCollect audit: lots of "impossible" errors for refunds - https://phabricator.wikimedia.org/T120430#2205291 (DStrine) [22:08:54] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint H 2016, and 4 others: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#2205292 (DStrine) [22:11:42] Fundraising Sprint H 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LcoalStorage or delete them - https://phabricator.wikimedia.org/T132640#2205231 (DStrine) [22:12:09] Fundraising Sprint H 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Use LocalStorage instead of cookies whenever possible - https://phabricator.wikimedia.org/T132639#2205299 (DStrine) [22:24:00] (PS15) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [22:30:04] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Permissions issue? "You do not have permission to access this page" - https://phabricator.wikimedia.org/T122519#1906367 (Eileenmcnaughton) a:Eileenmcnaughton [22:45:53] (PS16) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [22:48:06] hemming and hawing! [22:48:07] oh well [22:48:08] ciao for now! [22:50:21] hehehe [22:50:24] good luck! [22:51:21] awight: I missed Jeff today & probably can't be around early enough to catch him tomorrow but I need to get to the bottom of whether replication + triggers is a blocker [22:52:33] I did log this .. https://phabricator.wikimedia.org/T132527 [22:55:47] eileen: I'm happy to pick up the request for you, but yeah lemme understand better... [22:55:54] So mixed replication does seem sketchy. [22:56:11] I think we're using it over row-based, because it's probably lower bandwidth [22:56:38] I'm not sure what test Jeff was suggesting [22:56:56] awight: no - I guess I'll just have to try to catch him [22:57:24] eileen: Would you like me to just determine whether Jeff thinks it's a blocker to enabling logging [22:57:44] awight: if you are able to catch him then it would be good [22:57:52] I could possibly get up early & try [22:58:05] No worries--it's each for me! [22:58:08] *easy [22:58:12] :-) [22:58:19] but I want to make sure I have your question straight [22:59:07] I think the situation is that he is possibly going to do some digging to make sure he doesn't see any problems with the triggers in our replication scenario [22:59:39] so I guess I want to know whether he is actively looking into it or how best he thinks we can resolve that question [22:59:48] ok, that's clear. I'll discuss it with him tomorrow AM and post the log on that task. [22:59:54] cool [23:00:14] It does seem like quite the gotcha [23:00:24] I think he had a decent solution though, [23:00:52] I guess we haven't addressed whether the replication is accurate enough [23:00:52] yeah - one thing that might help is replacing the DB name in the trigger with a variable [23:00:57] k [23:01:23] unfortunately I don't have much experience of mysql replication [23:01:25] Yeah the second part seems pretty cut and dry, though, that we need to set up triggers on the replica if we promote it to master [23:01:33] me neither, it's all evil magick [23:01:35] I think only 1 Fuzion customer uses it [23:01:57] How does the cut over work? [23:02:04] It... hasn't yet [23:02:05] does someone run a script [23:02:09] is it automagic [23:02:16] I think it involves a few hours of manual work [23:02:16] does it actually not work :-) [23:02:17] Since we ended early, I'm also going to head out for the day. Gotta get to Berkeley campus! [23:02:35] OK - if it involves manual work then the triggers can just be a step in the process [23:02:47] We had a scenario a few months ago where we might have wanted to fail over, but Jeff made it sound like a serious investment [23:03:09] I think even the production Wikimedia cluster is in failover infancy, c.f. recent emails. [23:03:16] ah… [23:03:22] +1 > the triggers can just be a step in the process [23:03:33] dstrine-away: See you tomorrow! [23:04:04] If there are NOT any real blockers then we should look to scheduling an outage at a time that suits Jeff [23:04:21] eileen: OK cool, I'll put that on my agenda for ambushing him ;) [23:04:25] :-) [23:04:47] ambushing is important [23:05:44] That gets the most honest answers :p [23:06:35] well except when people ambush me I say things like 'I'll get it done by the end of the week' meaning 'I will hide from you from the end of the week onwards' [23:06:41] lol [23:07:30] (PS1) Cdentinger: add new worldpay row types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/283351 [23:08:00] (CR) Awight: [C: 2] add new worldpay row types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/283351 (owner: Cdentinger) [23:08:41] dang yo [23:09:23] (CR) Awight: "We do have a "type" field to distinguish between refunds and chargebacks. That should be extended in queue2civicrm to include cancellatio" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/283351 (owner: Cdentinger) [23:09:50] hehe [23:10:17] * awight|afk disengages ambush mode [23:11:01] i will also bug jeff to move some of those files back to incoming [23:18:02] (Merged) jenkins-bot: add new worldpay row types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/283351 (owner: Cdentinger) [23:24:38] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 3 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2205464 (cwdent) This fix, while not comprehensive, will probab...