[00:05:31] I my not see you tomorrow but the tasks look ok :) [06:15:12] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2209092 (jcrespo) Without much context: * Triggers created on... [12:10:14] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2209558 (Jgreen) done! [16:02:27] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2210550 (cwdent) Thanks, I think these are finally done! @MBea... [16:47:24] (CR) Ejegg: CRM-18215 Fix grouping so that Merge activities are not sometimes lost (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/282094 (owner: Eileen) [16:55:31] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2210780 (MBeat33) thank you @cwd, it looks like there are a few... [16:58:48] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, and 2 others: Add 'Cancelled' type for refund messages - https://phabricator.wikimedia.org/T129714#2113667 (cwdent) a:cwdent [17:05:29] (PS1) Ejegg: Remove email export geonames db config [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/283688 [17:25:49] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2210855 (cwdent) Thanks @MBeat33 -- looks like those are all af... [17:28:29] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2210860 (MBeat33) Awesome, thanks @cwdent [17:36:12] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#1012246 (Ejegg) @awight, it seems like it might be a... [17:48:34] cwd, when you disable a role in vagrant, do you expect it to delete all the folders and dbs on next provision? [17:50:41] ejegg: hmmm, i don't know [17:50:55] i guess that's a puppet question? [17:51:35] i'm inclined to think that it would not clean up that stuff [17:52:03] ah, gotcha [17:52:16] asking tyler [17:52:32] just stop services and ports [17:53:09] yeah he confirms it will not remove [17:53:22] k [17:53:31] vagrant destroy && vagrant up would do it [17:54:13] yah, so gotta nuke the whole box to freshly reprovision a role [17:54:55] yeah :-\ [17:54:57] slow [17:57:22] yeah, i don't have the patience to develop vagrant roles... [17:57:41] i guess if I knew puppet better I might be able to retry one at a time [18:02:04] the lxc backend for vagrant is probably a lot faster [18:02:15] i haven't tried it because nfs [18:02:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-Vagrant: assert statements in latest Civi break wmf_civicrm install in vagrant - https://phabricator.wikimedia.org/T132810#2210974 (Ejegg) [18:03:18] cwd can you add lxc-configured roles in mediawiki vagrant? [18:04:34] ejegg: yeah you just use lxc instead of virtualbox on the back end, so it's not running its own kernel or anything, basically GNU in a chroot [18:04:46] but afaik everything else should work the same [18:05:15] oh cool [18:05:21] https://github.com/wikimedia/mediawiki-vagrant/blob/master/support/README-lxc.md [18:05:56] thanks! [18:06:33] you bet! lmk how it goes if you try it, it's probably worth installing nfs [18:13:02] (PS3) Ejegg: Script to dump GET_DIRECTORY results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283266 (owner: Awight) [18:14:00] (CR) Ejegg: [C: 2] "I dig this growing library of utility scripts and the nudges they give us towards library-ization." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283266 (owner: Awight) [18:15:31] (Merged) jenkins-bot: Script to dump GET_DIRECTORY results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283266 (owner: Awight) [18:30:52] (CR) Ejegg: "Wow, it was nice of them to keep supporting the numeric format till now. Let's update the code of commented-out Knab too, in case they get" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283276 (https://phabricator.wikimedia.org/T131904) (owner: Awight) [20:41:00] (PS5) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) [20:41:33] (CR) Ejegg: "PS5: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [20:43:01] (CR) jenkins-bot: [V: -1] Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [20:48:06] (PS6) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) [21:12:39] (PS7) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) [21:13:58] (CR) Ejegg: "oops, earlier versions wouldn't have worked for the main use case, as they didn't process referrers passed in on GET or POST variables" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [21:39:04] (CR) Cdentinger: [C: 1] "I dig this, truncating WMF referrers is both privacy respecting and will stop many legitimate requests from tripping OWASP rules (mostly b" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [21:41:46] thanks! [21:43:50] yeah! interested to see what adam's concern is... [21:43:57] (CR) Ejegg: "I'm hoping we can be smart enough with the regexes that we don't nuke fraud indicators. But let me fix that WS in any case." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [21:44:41] hrm fraud indicators yeah...maybe we could just make those checks on donatewiki against the actual header? [21:45:14] course i guess we'd have to pass the fraud score in the request which is not really useful [21:52:53] (PS8) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) [21:53:55] (CR) Ejegg: "PS8: Whitespace fix" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [22:00:23] (PS1) Ejegg: Whitespace fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283754 [22:15:15] (PS1) Ejegg: Guard against undefined variable and index errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283756 [23:01:50] (CR) Cdentinger: [C: 2] Whitespace fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283754 (owner: Ejegg)