[00:24:56] (PS17) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [14:44:05] Fundraising-Backlog: Ingenico: iDEAL form error with Abn-Amro bank - https://phabricator.wikimedia.org/T132680#2214092 (MBeat33) Testing this bank today on the form, it appears to be working again. [15:38:04] the-wub: hi! how's it going? I guess no issues with the new Special:CentralNotice code for modifying campaigns from the list? Have you had the chance yet to modify more several at a time? [15:39:30] AndyRussG: it seems fine so far. haven't done any more bulk changes, but will let you know if I do and anything goes wrong [15:39:48] the-wub: cool! great to hear ;) [15:39:52] thx much [16:12:08] (PS5) Glaisher: Add help link to Special:CentralNotice and Special:CentralNoticeBanners/edit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831 [16:13:02] (CR) Glaisher: "Bump again. It would be nice if this 2 line change could be reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831 (owner: Glaisher) [17:30:39] MBeat PPena jessicarobell ejegg : banners just went up in Mexico [17:30:56] great, ty the-wub [17:31:32] Haribaaa! :) Thanks the-wub [17:36:29] seem a little delayed, but I'm starting to see donations in civi :) [17:48:25] Fundraising Tech Backlog: eliminate or modify cases where we append a timestamp as a GET argument for a static object such as page-fade.png - https://phabricator.wikimedia.org/T132941#2214767 (Jgreen) [17:49:12] Fundraising Tech Backlog: eliminate or modify cases where we append a timestamp as a GET argument for a static object such as page-fade.png - https://phabricator.wikimedia.org/T132941#2214782 (Jgreen) [17:51:16] (PS3) XenoRyet: Allow clicking on payment method to submit form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282416 (https://phabricator.wikimedia.org/T130673) [17:53:14] (CR) XenoRyet: "I'm thinking that the behavior we're looking for here doesn't actually need to listen for the change event, I think just the click event g" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282416 (https://phabricator.wikimedia.org/T130673) (owner: XenoRyet) [17:53:40] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2214823 (awight) [18:08:54] the-wub jessicarobell yeah I see some trnxs in, seems slow though, and no cash trnx yet... MBeat any complains? [18:09:36] nothing yet, PPena [18:09:58] PPena: would cash donations show up yet? plenty of people seem to be clicking it [18:10:25] oh sorry im checking on the completed ones [18:10:33] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2214939 (AndyRussG) A query of the banner history logs on Had... [18:10:33] obvisouly we wont see them- gimme a sec [18:12:13] the-wub ok yeah plenty of attempts [18:12:16] uff ! [18:17:57] (PS1) Cdentinger: Support cancell?ed donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/284011 (https://phabricator.wikimedia.org/T129714) [18:19:31] (PS1) Cdentinger: Pass more transaction types. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284012 (https://phabricator.wikimedia.org/T129714) [18:28:22] the-wub: I'm seeing about 2 cash transactions per minute, watching the payments-initial log records at the the point where we redirect to AstroPay. [18:30:13] awight: that's surprisingly low. I see about 20 per minute in contribution_tracking [18:30:52] ooh? [18:30:53] hm [18:32:00] Sounds like a problem. I just squinted at the log to confirm. [18:34:10] Also confirmed the numbers you mentioned from contribution_tracking. [18:36:13] awight I see aroun 300 cash tentatives [18:38:25] PPena: That sounds like the number of people I see redirecting to AP with method=cash [18:38:39] PPena: Actually, I see 94 tentatives [18:40:33] PPena: They begin at 17:35 UTC-- lmk if you want to compare individual banks or anything. [18:44:50] awight yeah I see almst 300. but they pending so wont show on CIVI [18:45:05] should I sent youa report (only with order IDs and non PII info? [18:52:59] PPena: That would be great, thanks. [18:53:07] awight done [18:53:12] O_O :) [18:56:50] PPena: the-wub: I see now--I was wrong about when we store the payments-initial log message. We actually store it when the donor returns from AP, so the 60% drop-off makes sense there. [18:57:05] awight cool [18:57:20] Lemme get a better number for how many cash donors we redirected [18:57:31] ah, thanks awight! good to know [18:57:54] We redirected 382 people. [18:59:41] we've got 1790 in contribution_tracking so far [18:59:49] (for "cash") [19:00:30] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Consider finalizing AstroPay cash methods before redirect - https://phabricator.wikimedia.org/T132956#2215169 (awight) [19:01:17] ^ There's a task for changing how we do payments-initial reporting. [19:02:02] Does 20% attempt per click conversion sound reasonable for cash methods? [19:03:12] tbh I have no idea. PPena? [19:04:47] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, FR-ActiveMQ: Pick a PHP Kafka client library - https://phabricator.wikimedia.org/T131268#2215212 (awight) [19:07:10] Fundraising-Backlog, FR-ActiveMQ: Write Debian packaging for arnaud-lb/php-rdkafka - https://phabricator.wikimedia.org/T132957#2215218 (awight) [19:13:36] maybe gerrit should make patches expire at a certain level of inactivity [19:14:45] :( [19:14:49] There goes my collection [19:16:44] hehe [19:17:02] well maybe just a UI switch between "needs review" and "is chilling here" [19:17:32] nothing wrong with saving things for later [19:17:37] That I can get behind. Maybe just amend the commit summary with [WIP] [19:18:10] yeah [19:18:35] a thing that happens is there is a conversation on a patch without consensus and then it just rots forever [19:19:22] That should feed directly into small electric shocks [19:19:50] it could be a heuristic for patch scoring as a service [19:20:08] was the last thing that happened here a couple of comments? [19:22:38] so let's say you need points to submit a patch, and you get points for review, but the price of submitting a patch is proportionate to the amount of stuff the needs review [19:22:51] *that needs [19:23:31] "gamified" code review [19:24:07] you lose your review points if the patch gets rolled back [19:24:18] +tax [19:31:10] Fundraising-Backlog: Astropay MX form: minimum amount error - https://phabricator.wikimedia.org/T132959#2215283 (MBeat33) [19:32:21] cwd: So um... are you hinting that there's some CR I should be doing? ;) [19:33:23] haha no just ruminating on my own list of pendings [19:34:37] * awight throws a sheet over my CR history [19:46:00] Fundraising-Backlog, FR-Worldpay: Worldpay Audit Parser should catch more stuff - https://phabricator.wikimedia.org/T129917#2215323 (cwdent) [19:46:02] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, and 3 others: Add 'Cancelled' type for refund messages - https://phabricator.wikimedia.org/T129714#2215325 (cwdent) [19:58:17] eileen: so the merge activities are worth special treatment because they provide the link to the other contact? [19:58:47] ejegg: you mean in the report? [19:59:05] yeah [19:59:30] well prior to that change there was only report links on updates not inserts of any kind [19:59:56] I thought using the merge to give the link made some sort of sense [19:59:57] right [20:00:18] It's worth noting that if 60 contacts are merged at once they would ALL show at the moment [20:00:22] I have 2 thoughts on that [20:00:23] ok, cool, just wanted to make sure I understood why that type of activity was more important [20:00:33] 1) pass the contact ids to the report url [20:00:34] or [20:00:48] 2) set the uniqueid for each merge action [20:00:58] hmm, I like 2 better [20:01:05] seems more transactional [20:01:23] yeah, the only downside is that if you DID want to revert a whole batch you would have lost that option [20:01:34] but it feels a bit safer [20:01:57] ah, right [20:02:09] yeah, you really wouldn't want to revert half a merge [20:02:37] like move a bunch of contributions to the deleted contact, but leave it deleted [20:03:53] it's more like each pair of contacts would get a unique id [20:03:59] so, if you merged 90 pairs [20:04:00] ejegg: cwd: eileen: awight|food: running a bit late... [20:05:14] would you want to revert one pair or 90? [20:05:27] huh, hard to tell [20:21:15] the-wub awight|food yes, sounds reasonable for Cash [20:21:57] MBeat any feedback on Astro? [20:22:25] one error in the form re: minimum amount; one donor unsure what currency they’d donated in [20:22:59] that’s it so for - also it looks like new MC credit card donations can be refunded easily, which is cool [20:23:16] *so far, MX [20:30:42] i forgot to mention, i'm going to a couple days of the reading team offside in estes, the week of 5/1 [20:31:05] specific dates tbd [20:33:01] nice! [20:43:16] awight: if [20:43:30] i move it to after you are off to India! [20:44:57] no you are just off - Anne is off to India [20:45:02] eileen: hehe I was wondering [20:45:18] I'm going to a much more mundane tropical dystopia: Hawaii [20:45:25] :-) [20:46:45] so you would be in the office possibly thurs 9 but not fir 10 [20:47:55] What days are these? [20:48:11] Ah, yeah I'll be in Thurs 5/12 [20:48:17] (PS2) Ejegg: Support cancell?ed donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/284011 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [20:49:25] OK it's probably still worth swapping til after [20:54:35] (CR) Ejegg: [C: 2] "Looks good. TODO: not throw exception on missing original contribution or complain about scammed $$ when status is cancelled. Probably st" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/284011 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [20:57:26] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, FR-ActiveMQ: Pick a PHP Kafka client library - https://phabricator.wikimedia.org/T131268#2215650 (awight) [21:02:36] (CR) Ejegg: [C: -1] "need to add cases to the switch above" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284012 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [21:06:29] (PS4) Ejegg: Allow clicking on payment method to submit form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282416 (https://phabricator.wikimedia.org/T130673) (owner: XenoRyet) [21:07:24] (CR) Ejegg: [C: 2] "Works, and click event is just fine for accessibility!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282416 (https://phabricator.wikimedia.org/T130673) (owner: XenoRyet) [21:08:14] (PS2) Ejegg: CRM-18215 Fix grouping so that Merge activities are not sometimes lost [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/282094 (owner: Eileen) [21:12:51] (CR) Cdentinger: "The new entries fall into the same refund block, is that what you mean?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284012 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [21:12:59] (Merged) jenkins-bot: Allow clicking on payment method to submit form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/282416 (https://phabricator.wikimedia.org/T130673) (owner: XenoRyet) [21:18:39] awight: so, reading through this https://phabricator.wikimedia.org/T132527 I don't feel much wiser [21:19:21] ah [21:19:40] reading jcrespo's response now... [21:20:56] ejegg: this method "Patch Set 2: Patch Set 1 was rebased" - did you just rebase the normal way & do 'git review' or is there some gerrit magic behind that comment [21:22:01] eileen: I would interpret that as a confirmation that we're fine if we use row-based replication. [21:23:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] Lybunt report could be faster - https://phabricator.wikimedia.org/T122024#2215758 (Eileenmcnaughton) @DStrine I think we can close this based on the email discussion [21:23:35] didn't Jeff say we were using mixed? [21:23:54] I mean the key thing is what is our 'oh fuck' plan [21:24:10] which I think is basically that Jeff has to manually delete all the triggers [21:24:30] eileen: Why delete triggers? [21:24:40] if the triggers were causing problems [21:24:43] ah [21:24:44] yeah [21:24:50] it emergency response plan [21:24:51] we stop all jobs and delete triggers. [21:25:03] one option would be just to set up triggers off one table first [21:25:05] & logging [21:25:13] and just check that it doesn't blow up [21:25:15] For failover, jcrespo made it sound pretty wholesome: we should already have triggers created on the replica. [21:25:16] for a day or 2 [21:25:23] that's a nice idea. [21:25:36] if we did that we'd pick a less critical table [21:25:51] civicrm_setting [21:26:01] which we can restore from backup [21:26:24] sure, then we can poke at the replica to see if triggers were created there... [21:26:42] it's worth noting that civicrm_setting changes more often than it really shold [21:26:44] should [21:26:50] (which I consider to be a bug) [21:27:02] but that might make it a good candidate for testing on [21:27:14] (they store navigation data in there too) [21:28:47] sounds perfect--restoring that table from a backup wouldn't cause many tears to be shed, I assume? [21:29:20] eileen: that was a rebase via the gerrit UI [21:31:10] ejegg: ah now I see it - I wasn't looking at one that needed a rebase - cool [21:31:20] (CR) Ejegg: "the switch statement setting $queue right at the top of the normalize fn doesn't include CHARGED_BACK or CANCELLED, so it'll still throw J" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284012 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [21:31:24] awight: nah - that table should rarely change in ways that matter [21:31:35] (and preferably only via upgrade script) [21:34:36] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2215799... [21:36:23] (Merged) jenkins-bot: CRM-18215 Fix grouping so that Merge activities are not sometimes lost [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/282094 (owner: Eileen) [21:37:54] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2215803 (Eileenmcnaughton) a:Eileenmcnaughton [21:46:19] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2215825 (Eileenmcnaughton) @awight and I discussed this and fe... [21:47:57] (CR) Cdentinger: "They are there, added in I6daf69a7159434a35572f3ba7ed2a74fb6bcebf8, fall into the same case as REFUNDED. Sorry if I'm misunderstanding..." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284012 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [21:49:26] (CR) Ejegg: [C: 2] "Oops! Sorry, I thought I had the latest pulled down." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284012 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [21:50:06] (Merged) jenkins-bot: Pass more transaction types. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284012 (https://phabricator.wikimedia.org/T129714) (owner: Cdentinger) [22:06:51] (PS3) Eileen: CRM-18214 Add link to detail report for contact merge activities, with oid if applicable. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/282095 [22:07:11] ty ejegg|food! [22:13:22] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2215920 (awight) @jcrespo Thanks for the thorough response!... [22:17:13] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2215952 (Eileenmcnaughton) NB in answer to > What if you del... [22:33:04] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, FR-ActiveMQ: Pick a PHP Kafka client library - https://phabricator.wikimedia.org/T131268#2216088 (awight) [22:38:37] we could use the jenkins interface to move audit files around [22:39:09] wat. [22:39:25] Or just g+wx the dirs [22:39:28] yeah [22:40:02] I'm a fan of umask 002 everywhere ;) [22:40:59] why read when you could edit [22:41:24] LESS=vim [22:41:37] hehe [22:43:02] i notice the globalcollect audit has no output [22:43:07] does it log somewhere? [22:43:52] hrm, it should have quite a bit of output. [22:44:20] It's got an ftp hash style single-character running tab of activity, then at the end will print summary information and details about problem transactions. [22:44:28] That's not being captured in the Jenkins logs? [22:45:07] i don't see anything in the web console [22:45:29] http://jenkins/job/Globalcollect WR1 Log Audit/768/consoleFull [22:45:30] ? [22:46:43] oh hrm [22:47:11] ok 4/11 and backwards appear empty to me [22:48:41] O_o [22:48:47] so they are [22:48:56] Maybe check the filesystem? [22:49:27] i can't see /var/lib/jenkins [23:02:21] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ: [Epic] Provision high-availability Kafka cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2216191 (awight) @Jgreen I'm not feeling very warm nor fuzzy about the bleeding-edge comp... [23:12:39] (PS3) Ejegg: ISSUERID is alphanumeric due to SEPA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283276 (https://phabricator.wikimedia.org/T131904) (owner: Awight) [23:12:46] well i gotta get working on the bathroom [23:12:49] just a couple more days... [23:12:54] (CR) Ejegg: [C: 2] ISSUERID is alphanumeric due to SEPA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283276 (https://phabricator.wikimedia.org/T131904) (owner: Awight) [23:15:53] (Merged) jenkins-bot: ISSUERID is alphanumeric due to SEPA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283276 (https://phabricator.wikimedia.org/T131904) (owner: Awight) [23:16:05] (PS1) Ejegg: Also update commented-out bank code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284105 (https://phabricator.wikimedia.org/T131904) [23:17:47] (CR) Awight: [C: 2] "That's the one, thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284105 (https://phabricator.wikimedia.org/T131904) (owner: Ejegg) [23:23:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, and 2 others: Write HHVM glue and Debian packaging for PHP Kafka client library - https://phabricator.wikimedia.org/T132985#2216228 (awight) [23:24:24] (Merged) jenkins-bot: Also update commented-out bank code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284105 (https://phabricator.wikimedia.org/T131904) (owner: Ejegg) [23:24:34] (CR) Ori.livneh: [C: 1] kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [23:25:54] Headed to the landless workers' event, see you tomorrow!