[00:00:26] Fundraising-Backlog: Chart data fields for data retention purposes - https://phabricator.wikimedia.org/T130763#2226040 (kevinator) [00:03:24] (PS6) Awight: [WIP] Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [00:28:47] (CR) Awight: "experimental" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [00:29:08] (CR) Awight: "check experimental" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [00:36:59] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Continuous-Integration-Config, FR-ActiveMQ, FR-Smashpig: SmashPig CI should run phpunit - https://phabricator.wikimedia.org/T133248#2226085 (awight) [00:58:46] Fundraising-Backlog, FR-ActiveMQ, FR-Smashpig: Create SmashPig PhpQueueDataStore compatible with StompDataStore - https://phabricator.wikimedia.org/T129386#2226140 (awight) [00:58:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ, and 2 others: Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2226141 (awight) [00:58:55] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2161797 (awight) [00:59:14] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ: Write pending queue consumer and schema - https://phabricator.wikimedia.org/T133197#2226144 (awight) a:awight>None [00:59:28] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2161797 (awight) a:awight [00:59:55] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2226147 (awight) a:awight [01:00:10] On to dishes! [01:53:38] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2226162 (Eileenmcnaughton) I have managed to get dedupe to run on staging through the UI + the batch button in the UI I get 6... [01:55:21] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2226165 (Eileenmcnaughton) As an aside I think that once I finalise those changes I've done to get the screen to load we could... [02:18:49] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2226197 (Eileenmcnaughton) I managed to port the 4.7 code to get info about the conflicts - here is an example conflicts";s:32... [03:04:13] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Enhance mustache state/province dropdown - https://phabricator.wikimedia.org/T133253#2226217 (Ejegg) [03:05:26] (PS1) Ejegg: Change message key of Canada province prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284620 (https://phabricator.wikimedia.org/T133253) [03:05:28] (PS1) Ejegg: Allow single-parameter WmfFramework::messageExists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) [03:05:30] (PS1) Ejegg: Localize subdivisions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284622 (https://phabricator.wikimedia.org/T133253) [03:05:32] (PS1) Ejegg: Persist state/province selection, localize prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284623 (https://phabricator.wikimedia.org/T133253) [03:09:25] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2226246 (Ejegg) Note to self: revise patch so that errors wh... [03:16:32] (PS6) Ejegg: Initial reorganization of js for new forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284508 (https://phabricator.wikimedia.org/T86248) [04:02:16] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2226283 (Eileenmcnaughton) I have done a hacky- trial hook to eliminate these & succeeded in about half the contacts merging wi... [04:10:41] (PS1) Ejegg: WIP pass errors in to getForm() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284626 [04:30:10] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2226293 (Eileenmcnaughton) So, my thinking is the steps that are required 1) Add & test api on core to allow us to retrieve po... [04:37:19] (PS1) Ejegg: DRY up validate_personal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284627 (https://phabricator.wikimedia.org/T107363) [05:06:34] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix logging hook name - https://phabricator.wikimedia.org/T133257#2226319 (Eileenmcnaughton) [13:44:31] heads up: I disabled fundraising campaigns until after the datacenter switch is done [14:18:20] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2162834 (Pcoombe) One other important use of cookies that I d... [15:11:51] the-wub: how did the CentralNotice interface work 4 the campaign disabling? [15:12:26] AndyRussG: was fine once again [15:12:38] fantastic! \o/ [15:44:41] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2227506 (AndyRussG) >>! In T131319#2227327, @Pcoombe wrote: >... [15:45:02] the-wub: ^ fyi :) [15:45:07] ejegg: hi! ^ :) [15:49:33] hello AndyRussG [15:50:11] o/ [18:49:11] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets, impression limiting and large banner limiting - https://phabricator.wikimedia.org/T132639#2228269 (AndyRussG) [19:02:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] Lybunt report could be faster - https://phabricator.wikimedia.org/T122024#2228316 (DStrine) Open>Resolved [19:09:28] (CR) Ejegg: [C: 2] "Thanks!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284612 (owner: Awight) [19:10:59] (Merged) jenkins-bot: Straighten out test namespaces; reusable config setup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284612 (owner: Awight) [19:11:33] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2228339 (cwdent) @MBeat33 curious results for the ones I i... [19:12:15] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Sprint-72-N: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2228342 (dr0ptp4kt) [19:15:11] (CR) Ejegg: [C: 2] "Ooh, good catch. Surprised we haven't been bitten by this one yet given the queue cleanup and adyen job runner are on the same box" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284614 (owner: Awight) [19:15:54] (Merged) jenkins-bot: Validate config paths when loading cached values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284614 (owner: Awight) [19:18:40] (PS1) Ejegg: Namespace one last test file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284741 [19:33:29] ejegg: i see what was happening with those audit files with your name on them, they are 664 somehow even though everything else in that dir is 644 [19:34:00] i was super confused when it let me move them [19:37:02] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2228389 (AndyRussG) [19:37:35] (PS2) Ejegg: CRM-18404 Rebuild triggers not including all tables [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283138 (owner: Eileen) [19:38:43] (CR) Ejegg: [C: 2] "Oh, this looks like a better way. And moving the function-level static is a bonus!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283138 (owner: Eileen) [19:41:11] (Merged) jenkins-bot: CRM-18404 Rebuild triggers not including all tables [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283138 (owner: Eileen) [19:47:25] awight|lunch, ejegg, XenoRyet -- boat load of stuff in the hopper for donationinterface, anyone mind if i deploy? [19:47:41] Fine by me. [19:47:44] ah crap, the stuff i actually need to deploy is smashpig [20:04:52] cwd oh right, I changed the mode on those to let you [20:06:27] but how were you able to write them? the rest of the files are -w [20:06:43] I think I manually moved them out of incoming [20:06:58] (CR) Awight: "I think the config is shared, actually--this change was to support testing cases." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284614 (owner: Awight) [20:08:18] (CR) Awight: [C: 2] "Good find! I'm a little worried about relying on the autoloader, cos composer's trying to add an "exclude: Tests" line to the .lock file." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284741 (owner: Ejegg) [20:17:17] (Merged) jenkins-bot: Namespace one last test file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284741 (owner: Ejegg) [20:23:15] (CR) Ejegg: "found something for your type checking" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [20:29:07] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#2228532 (Ejegg) [20:32:33] awight|aargh: sorry i forgot you are out tomorrow [20:32:48] I'll put something on the calendar for monday [20:33:30] (CR) Ejegg: [C: -1] "Oh hey, validate_personal already does this for GlobalCollect forms, and gives us red text instead of alerts. See I944246c74eb for a first" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284532 (https://phabricator.wikimedia.org/T112323) (owner: Ejegg) [20:34:53] dstrine: Actually, I'll be working 1/2 day tomorrow so that would be perfect. [20:35:14] dstrine: I'm nervous about what's happening with the queue work, a check-in would be helpful for me [20:35:15] awight: would the morning or afternoon work better for you [20:35:23] let's say morning [20:35:26] ok [20:35:53] awight: I sent a meeting invite [20:36:18] I'm going to check out for the afternoon [20:36:52] good idea--have a nice nap! [20:38:44] awight: thanks! I think I'll just be a zombie until the evening. gotta reset the clock [20:39:03] good plan ;) [20:43:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Smashpig, Technical-Debt: Spike: Can we move the Ingenico orphan rectifier to a server outside the payments cluster? - https://phabricator.wikimedia.org/T130894#2228640 (awight) [20:44:51] I just discovered a fun work board: https://phabricator.wikimedia.org/project/board/609/ [20:52:43] (PS1) Ejegg: Rename 'getStompMessageFields' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284761 [20:56:42] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Continuous-Integration-Config, FR-ActiveMQ, and 2 others: SmashPig CI should run phpunit - https://phabricator.wikimedia.org/T133248#2228713 (awight) Open>Invalid It was already working! [20:56:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig: [Epic] Rewrite all queue clients to use a single shim library, improve library - https://phabricator.wikimedia.org/T133108#2228715 (awight) [20:58:27] Has anyone seen K4-713? [21:02:56] (PS7) Awight: [WIP] Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [21:09:27] not today [21:10:07] harrumph [21:14:15] (CR) Awight: [WIP] Integrate with PHP-Queue (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [21:14:56] Jeff_Green: are you happy to move the outage 24 hours earlier per Jessica's response (awight dstrine-away) [21:15:49] wfm! [21:19:04] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2228949 (cwdent) Here is the current line-up: Missing ref... [21:20:01] eileen1 so monday evening EST? [21:25:27] Jeff_Green yes that seems to work better for Jessica & I didn't get the feeling it would be worse for anyone else [21:25:50] If that's good for you I'll send an email amending the outage [21:26:01] eileen1: yep it's fine by me! [21:26:22] ok - I'll do that then - do you want me to stick it in your calendar? [21:30:02] eileen1: sure, thank you! [21:34:39] ok Jeff_Green awight outage updated & email sent [21:55:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: List all of the places we've extended CiviCRM - https://phabricator.wikimedia.org/T133356#2229132 (awight) [22:00:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: List all of the places we've extended CiviCRM - https://phabricator.wikimedia.org/T133356#2229132 (Eileenmcnaughton) Are you meaning patches / hacks to the core corebase or modules / extensions Esp the former might be quite timely because I'm currently... [22:03:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: List all of the places we've extended CiviCRM - https://phabricator.wikimedia.org/T133356#2229208 (awight) Interesting! Your comments at https://gerrit.wikimedia.org/r/#/c/235359/ are a great start for the former. I was sort of assuming that those wer... [22:10:07] hey awight ejegg, my meeting just ended! can meet earlier if you want [22:13:43] ccogdill: sure, I'm in the call, take yr time [22:15:08] k joining now [22:18:28] be there in a sec [22:44:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: List all of the places we've extended CiviCRM - https://phabricator.wikimedia.org/T133356#2229392 (Eileenmcnaughton) yeah probably time to update those notes [22:55:57] i am gonna peace out and get started on the bathroom. should be the last long night. later! [23:09:30] see you tomorrow! [23:10:24] (PS8) Awight: [WIP] Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [23:11:09] (CR) jenkins-bot: [V: -1] [WIP] Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [23:25:10] (CR) Ejegg: [C: -1] "on second thought, let's stop using 'emailAdd' as the form field and rename the keys to make it clear which is the field label and which i" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284509 (owner: Ejegg) [23:29:54] (PS1) Ejegg: WIP inline errors for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284835 (https://phabricator.wikimedia.org/T107363) [23:31:47] (CR) jenkins-bot: [V: -1] WIP inline errors for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284835 (https://phabricator.wikimedia.org/T107363) (owner: Ejegg)