[10:06:30] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [10:07:03] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234528 (Jgreen) [10:07:46] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [10:08:24] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [10:09:02] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [10:10:01] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234536 (Jgreen) p:Triage>Normal [14:20:02] (PS8) Zfilipin: Migration of browsertests* Jenkins jobs to selenium* jobs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) [14:24:14] (CR) Zfilipin: [C: 2] Migration of browsertests* Jenkins jobs to selenium* jobs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) (owner: Zfilipin) [14:25:44] (Merged) jenkins-bot: Migration of browsertests* Jenkins jobs to selenium* jobs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) (owner: Zfilipin) [14:51:43] Fundraising Tech Backlog, Fundraising-Backlog, Operations, Traffic, Patch-For-Review: Switch Varnish's GeoIP code to libmaxminddb/GeoIP2 - https://phabricator.wikimedia.org/T99226#1287413 (fgiunchedi) looks like this was waited for until the fundraising was over, can it be resumed now? also w... [15:04:50] Fundraising Tech Backlog, Fundraising-Backlog, Operations, Traffic, Patch-For-Review: Switch Varnish's GeoIP code to libmaxminddb/GeoIP2 - https://phabricator.wikimedia.org/T99226#1287413 (BBlack) It's mostly been blocked on lack of anyone having time to work on it, too. At this point, it's... [15:05:28] Fundraising Tech Backlog, Fundraising-Backlog, Operations, Traffic, Patch-For-Review: Switch Varnish's GeoIP code to libmaxminddb/GeoIP2 - https://phabricator.wikimedia.org/T99226#2235278 (BBlack) [15:11:29] (PS1) Zfilipin: Removed unnecessary VERSION from ci.yml file [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285190 (https://phabricator.wikimedia.org/T128190) [15:12:19] (CR) Zfilipin: [C: 2] Removed unnecessary VERSION from ci.yml file [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285190 (https://phabricator.wikimedia.org/T128190) (owner: Zfilipin) [15:54:40] AndyRussG: I asked or some data from analytics about browser versions but I don't think I'll get it for a while. You said you were leaning toward keeping the cookie fall back. I really think we should go that route if it's not too much of a hassle. do we need to make more tasks for this? [15:54:56] dstrine: hi! thx for doing that :) [15:55:12] I'm going to town with the cookie fallback right now in fact [15:55:28] ok great. which task are you tracking this in? [15:55:45] Polls say 97% chance people cookie fallback will win this one [15:55:53] : [15:55:56] :) [15:56:42] Well the plan part is here, I guess I should update that to say the cookie option is all but chosen https://phabricator.wikimedia.org/T131319 [15:56:51] (that does seem to be the case) [15:57:13] The task I'm coding on is this one: https://phabricator.wikimedia.org/T132639 [15:57:35] (the patch there is an early draft which I'll abandonate) [15:58:50] ok do you want to claim T132639? [15:58:51] T132639: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets, impression limiting and large banner limiting - https://phabricator.wikimedia.org/T132639 [15:59:54] also should this still be in the sprint? https://phabricator.wikimedia.org/T132640 [16:01:05] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets, impression limiting and large banner limiting - https://phabricator.wikimedia.org/T132639#2235625 (... [16:01:30] dstrine: yeah [16:01:41] I can start on that one while this is in review [16:01:57] They go together, also [16:04:38] ok cool. Thanks for all the info. I'm just getting my head around this. Now that there is direction to this, Is this likely to spill over into the next sprint or longer? There is a great deal of interest in the banner fallback work after this so I'm just trying to gauge timing. [16:06:11] dstrine: at the least deployment, and maybe review and review-followup, will spill into the next sprint, yeah [16:06:59] Yrrglpphttht the banner fallback might not be easy [16:06:59] ok cool. This helps me move a few things around in the backlog. Thanks! [16:07:15] * AndyRussG leaves back burner in brain on "simmer" [16:07:21] dstrine: thank u much!! [16:07:27] AndyRussG: re fallback... yeah I think we should investigate and no make any promises for a bit [16:07:50] but I would like to et everyone on the same page before we start anything [16:08:03] I'm a bit hesitant to further compicate a system that's begging for re-organization and better abstractions [16:08:04] man I cannot type today [16:08:18] But I understand that feature could be quite useful [16:08:24] AndyRussG: sure [16:09:46] in other news... the AC is on full blast in the office and I can't find the controls. I'm freezing over here :P [16:10:07] dstrine: ohnoes... Blankets? [16:12:02] ugh it's only my side of the building. the other side is warm and stuffy. [16:12:18] Hmmm [16:12:22] Fans? [16:12:46] Migrate to a midpoint? [16:13:45] yeah.. maybe migrate [16:16:26] Fundraising-Backlog: We should not lock composer deps to dev-master - https://phabricator.wikimedia.org/T133556#2235681 (cwdent) [16:20:11] I've been trying to work outside of late but most times it's been a bit chilly still [16:25:33] (CR) Ejegg: [C: 2] "More consistent is good" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [16:36:19] new ubuntu version is out, gonna try an upgrade [16:52:32] (PS2) Florianschmidtwelzow: Replace usage of wfSetupSession() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/282479 (https://phabricator.wikimedia.org/T132251) [17:39:14] Fundraising-Backlog: SPRINT K (5/25- 6/8) GOAL: Continue Paypal, dedupe exact matches? - https://phabricator.wikimedia.org/T133570#2236087 (DStrine) [17:40:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2236100 (DStrine) [17:40:40] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#2236105 (DStrine) [18:06:31] (PS13) Awight: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [18:11:11] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Continuous-Integration-Config, Unplanned-Sprint-Work, FR-ActiveMQ: Run PHPUnit on PHP-Queue repo - https://phabricator.wikimedia.org/T133574#2236211 (awight) [18:14:16] huh, mysql upgrade problems [18:14:44] That sounds terrible [18:15:11] hoping it's something simple and dumb [18:15:16] I've only achieved satisfaction by dumping all data to .sql and reimporting, when that stuff goes wrong [18:15:45] There's the one where debian scripts assume a stock backdoor root password... [18:15:47] not too painful, I guess [18:15:53] aw man [18:16:43] ejegg: on your laptop you mean? [18:16:45] Looks something like this: https://mirzmaster.wordpress.com/2009/01/16/mysql-access-denied-for-user-debian-sys-maintlocalhost/ [18:16:52] cwd yep [18:17:09] drag [18:17:17] yeah i'm pretty sold on vagrant because of stuff like that [18:17:49] oh huh, 2016-04-25T18:14:34.853844Z 0 [ERROR] Function 'innodb' already exists [18:18:19] horrors! [18:18:39] (CR) Awight: "recheck" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [18:18:42] seems maybe going from 5.6 to 5.7 some things are now plugins [18:18:47] or vice versa [18:20:19] (CR) jenkins-bot: [V: -1] Support "queue" as an alias for "db_table" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [18:23:48] (PS1) Awight: Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) [18:24:41] (CR) jenkins-bot: [V: -1] Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) (owner: Awight) [18:26:44] (PS2) Awight: Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) [18:27:48] (CR) jenkins-bot: [V: -1] Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) (owner: Awight) [18:32:45] (PS1) Awight: Try PHP_CodeSniffer for style consistency [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285222 [18:33:31] (CR) jenkins-bot: [V: -1] Try PHP_CodeSniffer for style consistency [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285222 (owner: Awight) [18:45:35] (PS2) Awight: Enable PHP_CodeSniffer for style consistency [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285222 [18:46:29] (CR) jenkins-bot: [V: -1] Enable PHP_CodeSniffer for style consistency [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285222 (owner: Awight) [18:55:16] http://www.su-tesla.space/ [19:00:29] (PS3) Awight: Make MediaWiki-compatible style changes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285222 [19:00:31] (PS1) Awight: [WIP] Enable PHP_CodeSniffer for style consistency [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 [19:01:29] also stumbled on this little upgrade annoyance: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817172 [19:01:40] otr plugin now in wrong dir [19:01:40] (CR) jenkins-bot: [V: -1] [WIP] Enable PHP_CodeSniffer for style consistency [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 (owner: Awight) [19:02:18] cwd: http://www.slate.com/content/dam/slate/blogs/future_tense/2013/10/03/tesla_fire_video_nhtsa_can_t_investigate_model_s_battery_fire_due_to_shutdown/1380814893.jpg.CROP.promo-mediumlarge.jpg [19:02:34] I think they've got them set to ignite the logo first, so photos are not so damning [19:03:21] >2013 [19:03:34] do they still do this? i have heard nothing but good things about safety... [19:03:47] I'm sure you get something nice for that price... [19:05:46] i'm interested to see how the model 3 does [19:06:00] Fundraising-Backlog, MediaWiki-Codesniffer, FR-Smashpig: Write mutant code style config for SmashPig, or fully adopt MediaWiki style - https://phabricator.wikimedia.org/T133576#2236348 (awight) [19:06:07] Fundraising-Backlog, MediaWiki-Codesniffer, FR-Smashpig: Write mutant code style config for SmashPig, or fully adopt MediaWiki style - https://phabricator.wikimedia.org/T133576#2236360 (awight) p:Triage>Low [19:21:00] (PS3) Awight: Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) [19:22:12] (CR) jenkins-bot: [V: -1] Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) (owner: Awight) [19:22:36] (PS4) Awight: Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) [19:23:39] (CR) jenkins-bot: [V: -1] Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) (owner: Awight) [19:24:16] (PS5) Awight: Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) [19:27:38] (PS5) Awight: Support auto_commit=false; pop deletes [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [19:27:39] (PS2) Awight: Support "queue" as an alias for "db_table" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 [19:27:41] (PS2) Awight: Add a timestamp column; specify MySQL syntax [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284988 [19:42:15] XenoRyet: did you get all that? I changed from wired to wireless and got dis/reconnected [19:42:34] Na, looks like it didn't come through. [19:53:09] (CR) Ejegg: [C: 2] "looks reasonable" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) (owner: Awight) [19:54:16] (CR) jenkins-bot: [V: -1] Clean up enough that composer test job will run [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) (owner: Awight) [19:54:19] (CR) jenkins-bot: [V: -1] Support "queue" as an alias for "db_table" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [19:58:36] (CR) Awight: "recheck" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285220 (https://phabricator.wikimedia.org/T133574) (owner: Awight) [19:59:06] awight|lunch: is the csv test not cleaning up after itself? [20:00:00] It should be [20:00:26] This is closer than I wanted to look at that class, though [20:00:45] it rewinds and re-reads the whole file repeatedly... [20:35:07] (PS1) Eileen: Update CiviCRM submodule for logging changes & activity view fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285254 [20:35:49] Be back in 10 [20:36:48] (CR) Eileen: "Submodule update, self approving" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285254 (owner: Eileen) [20:36:57] (CR) Eileen: [C: 2] Update CiviCRM submodule for logging changes & activity view fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285254 (owner: Eileen) [20:41:07] cwd: is your patch 4f5f562 Support cancell?ed donations [20:41:08] good to be deployed? [20:41:27] I'll push out now with the civicrm submodule update if it is [20:41:51] eileen: it needs an update in vendor...was just working on that [20:42:01] actually working on automating that :P [20:42:15] one second [20:43:50] rgh my repo is all hacked up right now [20:44:23] but i guess it shouldn't hurt anything to deploy civi without the smashpig change [20:44:28] just won't get used yet [20:44:39] cwd up to you - I can include or exclude [20:45:00] eileen: why don't you exclude in that case [20:45:07] cwd sure [20:45:12] thanks [20:45:27] i'll roll both things before long [20:47:18] (PS1) Eileen: CRM-18193 add default log_conn values for when interacting with mysql outside of CiviCRM. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 [20:49:51] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2236918 (awight) I've created a generic wrapper in SmashPig, `FifoDataStor... [20:49:56] (PS1) Eileen: Update CiviCRM submodule for logging changes & activity view fix [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285276 [20:50:40] (CR) Awight: "recheck" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [20:51:14] (CR) Awight: "resubmit" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [20:52:06] (CR) Awight: "resubmit" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [20:52:14] maybe that's not a thing... [20:52:47] (CR) Awight: "recheck" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [20:57:49] (CR) Hashar: "recheck" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [21:01:03] (CR) Hashar: "There is a problem with Gerrit. Zuul can't clone from wikimedia/fundraising/php-queue :( Can you poke #wikimedia-releng about it ? I am a" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [21:01:23] (CR) Eileen: [C: 2] "Self merging - master to deployment" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285276 (owner: Eileen) [21:01:51] (CR) Awight: "Thanks for noticing my little moment here :) Sure, I'll ask around. Probably something I did, such as removing Jenkins-bot as a reviewer" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [21:02:13] ejegg: Can u CR jiggle https://gerrit.wikimedia.org/r/#/c/284987/ at some point? [21:03:48] (CR) Hashar: "recheck" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [21:04:09] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2236940 (awight) [21:04:57] Actually I'm not going to push that stuff to live just before I go to the dentist - will do when back now [21:05:16] awight: abandon this ? https://gerrit.wikimedia.org/r/#/c/243088/ [21:07:43] (Abandoned) Awight: Create campaign option group [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243088 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [21:12:22] Fundraising-Backlog, FR-Smashpig, Technical-Debt: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2236963 (awight) [21:12:28] Fundraising-Backlog, FR-Smashpig, Technical-Debt: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2236976 (awight) See also T129706 [21:15:29] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2224734 (awight) a:awight [21:16:28] Oooh, that sucks. Where do we get SmashPig config from when using it as a vendor library for DonationInterface? [21:16:52] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Smashpig, Technical-Debt: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2236983 (awight) [21:17:19] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Smashpig, Technical-Debt: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2236963 (awight) a:awight [21:23:13] awight: oops, will do! [21:23:47] (CR) Ejegg: [C: 2] Support "queue" as an alias for "db_table" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [21:23:59] awight: hmm, which config? [21:24:57] (Merged) jenkins-bot: Support "queue" as an alias for "db_table" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284987 (owner: Awight) [21:27:34] awight: it looks like the civi submodule had a deployment branch years ago but we don't use it anymore, is that accurate? [21:37:31] cwd: I guess so... thought we were using it recently, but it seems not! [21:38:06] ¯\_(ツ)_/¯ [21:38:33] frig dug it up in the yard [21:38:46] hehe, I'm sure there's still some marrow on it [21:40:17] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2237042 (CCogdill_WMF) Hi, any update on... [21:42:10] ok now i'm definitely thinking a yaml config file for frig is going to be better than relying on any defaults [21:42:13] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2237048 (awight) @CCogdill_WMF So sorry... [21:42:29] cwd: like, checked into the repo? That sounds perfect. [21:42:35] (into the target repo) [21:43:21] oh yeah that's ever better [21:43:56] well actually [21:44:05] * cwd gets yak and razor [21:44:51] i was thinking it'd be pretty nice to have each target described underneath a key [21:45:00] in case you have 2 installs of the same project in different configurations [21:45:02] like smash pig [21:45:18] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2237053 (CCogdill_WMF) Okay thanks for t... [21:45:19] so something can be a submodule over here, and a vendor dep over there [21:46:00] however gleaning information from pwd is also a good workflow [21:46:16] cwd: What if we specified SmashPig subfunkiness in crm/.frig.yaml? [21:46:31] We would just override the things that matter to crm. [21:46:40] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237058 (CCogdill_WMF) Resolved>Open Reopening this task as it does not appear to be resolved. CID 7116613 w/email domain planet.nl wa... [21:47:13] yeah that would work too [21:48:18] (CR) Ejegg: [C: 2] "looks good. are you not using timestamp type column because you want the flexibility to set it to things other than now? good catch on the" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284988 (owner: Awight) [21:49:26] (Merged) jenkins-bot: Add a timestamp column; specify MySQL syntax [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284988 (owner: Awight) [21:51:24] (CR) Awight: "Ooh indexes, good point." [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284988 (owner: Awight) [21:54:49] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237083 (awight) @CCogdill_WMF Do you happen to have the CID of the deleted contact, or can you PM me the old email? I'm having a hard time fi... [22:01:53] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237097 (awight) I think the issue is that the old email was somehow destroyed entirely. We'll be able to pick up these cases with the code th... [22:04:05] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237101 (awight) Next case to investigate: CID 3946006 was deleted and merged into CID 15159738. [22:09:27] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237138 (awight) In the CID 3946006 case, the email is present in silverpop_excluded and in silverpop_export with opted_out=1, so it should hav... [22:10:47] (CR) Ejegg: "guess it's just as well to keep the timestamp column generic. also, i missed an undefined var in my first review." (1 comment) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284988 (owner: Awight) [22:12:05] (PS1) Awight: Typo [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285296 [22:16:15] awight: ejegg this is what Tim picked up in the weekend - https://gerrit.wikimedia.org/r/#/c/285263/ - it doesn't have to be merged for today's test but I've edited the code at https://phabricator.wikimedia.org/T132527 [22:17:02] eileen: ooh, good catch [22:17:26] yeah yay for Tim [22:19:31] (CR) Ejegg: [C: 2] Typo [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285296 (owner: Awight) [22:19:42] (CR) Awight: "Comment typo :)" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [22:21:21] eileen: thanks for the heads up on the Civi maintenance [22:21:52] awight: should we take campaigns down at 3:45? [22:22:12] (CR) Eileen: CRM-18193 add default log_conn values for when interacting with mysql outside of CiviCRM. (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [22:23:40] dstrine: I think 5 minutes should be plenty. That needs to be documented somewhere, actually... [22:23:52] okee [22:24:05] (Merged) jenkins-bot: Typo [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285296 (owner: Awight) [22:25:09] dstrine: Hmm, it used to be a matter of how long it took for the BannerRandom caches to purge, but now the limiting factor is probably people leaving their browser open and clicking on the donate link minutes later. [22:25:25] Just muttering... [22:25:36] lol it's cool :) [22:29:51] (CR) Ejegg: "good for our use case, but the other public methods should also be transactional for consistency. also, any reason not to use http://php." (2 comments) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [22:30:27] !log Updating civicrm [22:30:27] from 2f40e829195dec1cec71d08dc9c656eb247631ae to 15a0086eef78f16110eba358a28ef78b51a385e1 [22:30:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:30:42] (PS6) Awight: [WIP] Support auto_commit=false; pop deletes [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [22:30:52] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237265 (CCogdill_WMF) My mistake @awight, Silverpop is showing the unsubscribe in one place and not in another. Looks like this is working. Sh... [22:31:00] (CR) Awight: "Thanks! I'll put this back in the TODO bucket" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [22:32:34] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Permissions issue? "You do not have permission to access this page" - https://phabricator.wikimedia.org/T122519#1906367 (Eileenmcnaughton) @CaitVirtue I just pushed out a fix for this - it was affecting act... [22:33:15] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237275 (awight) @CCogdill_WMF I think the first case is something different--in that case, the old email address completely disappeared, which... [22:35:29] Fundraising Sprint Ghostbusting , Fundraising-Backlog, Patch-For-Review: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2237276 (CCogdill_WMF) Open>Resolved [22:38:47] (PS2) Eileen: CRM-18193 add default log_conn values for when interacting with mysql outside of CiviCRM. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 [22:40:09] awight: cwd and ejegg do any of you know who worked on the worldpay form for israel? [22:40:42] dstrine: lemme see... [22:40:45] i made the france one work with mustache but i don't think that's related [22:41:03] dstrine: I think it was a long time ago since we touched that. [22:41:07] No one, basically. [22:41:41] XenoRyet: needs the hebrew text. atgomez mentioned it should be in the worldpay code but we are unsure [22:41:47] hmmm [22:42:09] It will be in translation messages, not in code but yeah the old form will have pointers to the messages. one moment [22:42:20] Yea, that sounds like what I need. [22:42:42] what awight said :) [22:43:13] https://payments.wikimedia.org/index.php?title=Special:WorldpayGateway&country=IL&amount=3¤cy_code=ILS&uselang=he [22:43:15] Not much there. [22:43:20] * dstrine waves at atgomez [22:43:29] Here are the message names, https://payments.wikimedia.org/index.php?title=Special:WorldpayGateway&country=IL&amount=3¤cy_code=ILS&uselang=qqx [22:43:39] hmm, that looks broken [22:44:09] oh, that's using the mustache form [22:44:12] yeah, sorry: https://payments.wikimedia.org/index.php?title=Special:WorldpayGateway&country=IL&amount=30¤cy_code=ILS&uselang=he&payment_method=cc [22:44:15] oh??? [22:44:46] yup! [22:45:02] Even with the payment method, we get no CC fields [22:45:23] and get errors on submit [22:45:53] dstrine: I think the answer is, there are no special messages to salvage from WorldPay [22:46:34] (CR) Eileen: CRM-18193 add default log_conn values for when interacting with mysql outside of CiviCRM. (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [22:47:26] (CR) Eileen: "Also note I updated the sql in https://phabricator.wikimedia.org/T132527#2215825 - that's the sql we will run today for our trial enable" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [22:47:39] XenoRyet: can you use the text in awight last link? [22:48:18] XenoRyet: ejegg pointed out that WorldPay is using the Mustache forms at this point, there's nothing to cannibalize actually. [22:48:23] * atgomez waves at dstrine [22:48:41] huh, i thought it was only doing that for specific ffnames... [22:49:07] Yea, Adyen is on Mustache too, and I've actually got our side of the form in Hebrew already, just trying to figure out how to get the iframe in hebrew as well. [22:49:10] We need that, right? [22:49:14] oh, maybe that's the only ffname in config for now? [22:49:19] ooo youch [22:49:34] the iframe is owned by Adyen, so they would have to support Hebrew. [22:49:54] They have default text for a lot of languages, I think... [22:49:57] They don't officially, but I thought I saw something about a workaround that I was trying to chase down. [22:50:18] oh man, no support? [22:50:21] boo [22:50:27] Not according to their docs anyway. [22:50:28] Yah not listed in https://docs.adyen.com/developers/hpp-manual#createaskin [22:50:35] Lots of lanugages, but no Hebrew. [22:51:55] grrr how did we come to the conclusion that hebrew was available? [22:53:18] Not sure. No Japanese either, though they do have Ukrainian and several flavors of French. [22:53:54] wow I got into Jenkins first attempt [22:55:20] dstrine: https://phabricator.wikimedia.org/T124228 that looks like it's describing a way to sort of manually do the translations, I think, but the link is broken and I can't quite tell what it was supposed to be pointing at. [22:55:35] so awight tell me the plan [22:55:52] I got into Jenkins - we shut down the queues from there… [22:55:57] XenoRyet: yeah, you can add languages from the skin settings [22:56:00] & drupal into mtce mode... [22:57:03] click on skins, then the skin code, then scroll to the bottom and click 'Edit Language Files' under extra options [22:57:13] but it's not gonna be fun [22:57:49] we'll need to figure out which of the messages we need for all the payment methods we hope to use [22:58:01] Yea, that's what I was trying to find. [22:58:21] probably don't need the 'pay with 7-Eleven' messages [22:58:27] also, what? [22:58:33] heh [22:58:37] haha [22:59:04] i remember paying for rides like that when i was a teenager, "i'll buy you a slurpee" [22:59:28] eileen: Hi! sorry I was looking at CentralNotice stuff [22:59:34] had no idea America has our own convenience-store based payment systems [22:59:45] eileen: yep, disable all jobs in the queue consumer tab... [22:59:53] ok - I can do that bit... [22:59:58] I'll look to remind myself whether we need to turn off more things. [23:00:25] eileen: Hold up... [23:00:34] Jeff_Green: can you shutdown jenkins for us? [23:00:42] eileen: ^ that's the fast way to do it [23:00:51] eileen: it turns out, we need *all* jobs disabled [23:00:56] hey [23:00:57] I see there is a prepare for shutdonw [23:00:57] yeah [23:01:15] thank you! [23:01:19] campaigns are off [23:01:24] a jenkins job "killall -9 jenkins" would probably do it :-P [23:01:42] killall java [23:02:39] looks good! [23:03:49] i just remembered I need to do the privs for the new table [23:03:50] I'll put the drupal site into mtc mode [23:03:55] cool [23:04:04] is there a proper checklist we're working from? [23:04:14] https://phabricator.wikimedia.org/T132527#2215825 [23:04:19] thx [23:04:20] that's for the create [23:04:23] we just need to [23:04:37] 1) create the table & insert into it as the www mysql user [23:04:52] & then 2) create the triggers as a more special user [23:05:01] ok [23:05:05] & the look at whether log tables are updating when we edit things [23:05:35] alright. doing db privs [23:05:36] & then humm & harr about whether the replication looks good and whether we now feel comfortable [23:06:11] as long as we can just drop the table if things go awry i'm less worried :-) [23:06:50] it's more dropping the triggers [23:07:07] ie the tables don't make any diff if the triggers aren't there [23:08:25] I wonder what happens if the user database on the slave is not the same as the user database on the master [23:09:37] we concluded the triggers use row replication in a mixed-replication scenario right? [23:09:55] We hope so [23:09:56] if that's the case it will probably just work, but if it were statement based it might explode [23:10:38] when you say mixed … what parts are statement based? [23:11:10] we're using "mixed replication" rather than row or statement [23:11:17] ok [23:11:28] which means mysql decides based on context which flavor to employ [23:11:48] ah right - I wasn't clear if you configured the mix at all [23:12:20] we need to be careful to use —skip-triggers in backups to be restored on staging [23:12:30] as the db name is in the trigger [23:12:38] right [23:13:32] we should have a blocking ticket to document formal protocols for various replication/restore scenarios [23:14:29] we should probably schedule a session & write them up as a group since we'd think of different things [23:14:47] yeah, totally [23:16:35] Jeff_Green: I could plan an early start tomorrow & we could look at 4pm your time , awight ejegg [23:16:53] eileen: I can do that [23:16:59] eileen: what's this about--are we aborting? [23:17:13] Sorry if I missed the party [23:17:14] no - talking about a documentation writing session [23:17:23] ah. :) awesome [23:18:25] ok grants are done [23:18:56] cool - so I can get a cli using drush for the table create [23:19:04] ok [23:21:19] I just did drush sqlc [23:21:25] & show databases; [23:21:30] and I don't see log_civicrm [23:21:38] on barium [23:22:32] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2237353 (Jgreen) [23:22:46] eileen: oh, i'll create it [23:22:57] done [23:23:53] I still don't see it so I think you need to give ermission on it [23:23:54] p [23:24:09] aren't you operating as user civicrm? [23:24:35] hmm - I'll have to check - I used drupal drush sqlcli - maybe there are 2 users [23:24:53] yeah there are [23:25:05] which user was it operating as? [23:25:17] I think for awight's patch the user drupal needs access too [23:25:39] ok, one moment [23:25:46] drush sql-cli is user drupal [23:25:49] drush civicrm-sql-cli is civicrm [23:25:58] ha [23:26:06] nothing confusing about that at all :-P [23:26:08] yep as civi I can see it! [23:26:21] but I think user drupal needs access too [23:26:28] yep, fixing [23:27:02] OK I've done the bit that needs to be done as the mysql user [23:27:07] user drupal probably does not, but it won't hurt [23:27:20] so the next bit is those triggers … https://phabricator.wikimedia.org/T132527#2215825 [23:29:30] so Jeff_Green you can see the sql you need to run now? [23:30:08] drupal user has select,insert,update,delete,create,drop now -- same as for the civi db itself [23:30:17] looking at trigger sql... [23:31:12] alright, i see it. ready? [23:31:42] yep [23:32:10] done [23:32:28] ok - I'm going to turn 'display backtrace' off in the UI... [23:32:38] saved ok [23:34:04] OK - so I can see the change in log_civicrm [23:34:05] select * from log_civicrm_setting WHERE id = 174\G [23:34:23] so what can we do to check replication looks unscathed? [23:34:37] well [23:34:53] * awight leans forwards [23:34:55] we'll know pretty quick if it fails :-) [23:36:03] i haven't looked very closely at the triggers, but they're all inserts afaik right? [23:36:16] yep [23:37:07] so we can check the other db's to make sure the inserts happened properly before firing serious load at it [23:37:29] As an aside, the setting I changed was id 175 not 174, but it logged 174 due to the created_date changing…. I think I can treat that as a bug & fix it [23:37:44] (created_date can be added to the ignore list) [23:38:34] awight, ejegg, i am ending up with some pretty brain damaged history here https://phabricator.wikimedia.org/D214 cause i'm pretty confused about how arc decides to amend a diff vs. make a new one. i think the sane way to develop with this workflow is local topic branches for everything that each map to a change in phab [23:38:35] (PS1) Awight: [WIP] Simplify config overrides read YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) [23:39:24] cwd: Sounds good! Some of us have become unhealthily fond of amending, though ;) [23:39:51] yeah, you can totally do that too [23:39:53] then squash them on merge to master? [23:40:10] a nice thing about phab is you can have it auto-squash on merge [23:40:21] well...it might be nice, we'll have to see [23:40:26] Jeff_Green: I read your last statement as I should stand by while you check - is that how you intended it? [23:40:26] but it _could_ be nice [23:40:33] (CR) jenkins-bot: [V: -1] [WIP] Simplify config overrides read YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) (owner: Awight) [23:40:41] eileen: I am checking [23:40:44] :-) [23:41:02] lutetium lookw like it got the updates fine, 231 rows [23:41:16] including the changed ones? [23:41:38] When I created it the rows went in with log_action = 'Initialization' [23:41:52] Then a few got added as 'Update' via the triggers [23:41:54] eileen: ok, you might want to look as well [23:42:06] yeah if it's on lutetium I can [23:42:35] yes, you have select privs there for log_civicrm [23:42:41] cool [23:43:25] looks the same to me on both machines [23:43:31] me too :-) [23:43:38] checking db1008 [23:44:37] looks fine [23:44:50] I see no reason to be concerned about replication at the moment [23:44:53] yay [23:45:09] I'm going to try something that I think will put some more traffic on that table [23:45:31] ok [23:46:06] SELECT * FROM log_civicrm_setting WHERE log_action = 'Update'\G [23:46:13] now gives 245 rows on each [23:46:20] which seems good [23:46:58] eileen: do the table settings look appropriate to you? [23:47:06] innodb which is good :-) [23:47:18] not sure what we want for charset & collate [23:48:00] I think the charset & collate are consistent with the live db [23:48:05] k [23:48:34] I think we can turn things back on [23:48:34] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Unplanned-Sprint-Work: Frig should handle composer stuff - https://phabricator.wikimedia.org/T133402#2237456 (cwdent) [23:48:55] eileen: ok [23:49:01] awight: ^^ [23:49:12] eileen: and Jeff_Green can campaigns come back as well? [23:49:15] eileen: i created a ticket to set up nightly backups for this table [23:49:24] I saw that - yay [23:49:25] dstrine: yes [23:49:34] ok doing that now.. [23:49:46] (not that I care about the one existing table but from next week there will be real data in there) [23:49:59] drupal is now out of mtc [23:50:01] eileen: I'll try to get to that in the next couple days [23:50:01] so cool! eileen, omg thanks for thinking to do this on a pilot table. [23:50:20] let me know when you want jenkins back online [23:50:30] I think now... [23:50:44] +1 [23:50:46] awight: there is one risk on the pilot table I'm thinking how to manage [23:51:04] hmmm [23:51:07] oh no [23:51:09] the code determines if you have old or new style logging tables by looking to see if any exist already [23:51:14] start: Job is already running: jenkins [23:51:19] Jeff_Green: hehe [23:51:22] i forgot about jenkins_watcher [23:51:23] sigh [23:51:30] so we didn't take it all down? [23:51:46] it was down, but briefly [23:51:47] Fortunately, that probably didn't cause any corruption [23:51:52] (this time!) [23:52:07] watcher runs every 5 min [23:52:09] no, very much a trial run [23:52:26] but we need to remember to slay jenkins watcher when we do this for real [23:52:37] eileen: ah. We can delete triggers and tables, then? [23:52:49] it's been a long time since I looked at that, I wonder if jenkins still falls over periodically [23:53:04] awight: yeah 2 options - 1 is to delete & re-create, other is to hack the code so it just does it new style [23:53:27] actually there is another option which is to tinker with settings [23:53:55] I'm somewhat inclined towards the hack option because if it starts creating them wrong it will be slow [23:54:05] I think the first option is a winner as well [23:54:19] :-) [23:54:27] OK - shall we tell people it's all up & go? [23:54:28] We can wait a bit, to burn in the table if you think that's helpful [23:54:35] I think so! [23:54:46] yeah I was assuming we would leave that table there for now [23:54:48] dstrine: How goes the CentralNotice mousing? [23:55:16] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2237481 (Jgreen) [23:55:26] Jeff_Green: dstrine awight just to be clear - campaigns & jenkins are re-enabled now? [23:55:40] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2237353 (Jgreen) [23:55:42] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2237482 (Jgreen) [23:55:49] jenkins is running [23:56:36] dstrine: you turned campaigns back on? [23:57:07] eileen: I just turned them on a second ago [23:57:18] cool I can email people [23:58:09] thanks!