[00:24:47] cwd: Dang. I just realized that Redis doesn't support commitOffset natively, we would have to keep track of the number of elements to pop :,-[ [00:27:11] or it's back to row status in the pending db [00:27:56] awight: ah yeah because there's no numerical index? [00:28:22] they are not intrinsically in any order [00:30:01] interesting, they have a primitive for doing the pending queue thing you were describing, http://redis.io/commands/rpoplpush [00:30:42] oh that's kind of awesome [00:31:16] plus it looks like it's pronounced rapopplepush [00:32:09] that could make the client operation a lot simpler [00:36:38] hehe [00:37:42] (PS1) Cdentinger: update wikimedia/smash-pig to 6ac4bba6aad3013bf2ddf967806f6b7f5e3647e7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285560 [00:38:22] awight: ^ that was done with frig, reading and writing that yaml file ends up encoding a couple unicode chars. what do you think? from what i've read it's actually "more correct" [00:39:09] oh totally, for json that's the way to go [00:39:12] Cool!! [00:39:25] The utf is probably just a newer version of composer? [00:41:07] * awight prepares self dogfooding symlinks [00:42:38] cwd: This is totally perverse, and I hate myself for suggesting it, but how about an async version, pop( $callback = null ) where $callback is a function( $message ) throws Exception [00:43:15] the rollback or commitOffset happens within pop(), depending on whether the callback throws an error. [00:44:34] I think that even gives us 2PC, as long as the backend's commit can't fail ;) [00:47:56] awight: the utf has to do with reading it into python as an object and writing the file again [00:48:05] oh wat [00:48:07] I like it [00:48:23] Although we'll see those lines toggle a thousand times I'm sure [00:48:28] the old dirty diff [00:48:37] hrm yeah i wonder if composer will change it back [00:49:21] far as i can think that pop sounds good [00:50:16] It's horrible but does seem to solve all the issues I had so far. [00:50:21] i guess it would only change back if we composer update, which we don't as of now [00:50:26] (jumping back and forth) [00:51:25] * Pretty clear what it does, * backwards compatible with other queue APIs * Backend implementation is not coupled to a specific control flow [00:51:43] cwd: We should be composer updating, but in its own commit IMO [00:52:11] we should certainly...but i think it's blocked by that "don't pin to dev-master" bug [00:53:16] dag. right [00:55:42] composer.lock is pandora's box, once one diverges from composer.json the whole semver thing is shot [00:56:16] that being said, the whole semver thing is based on trusting random sources to properly implement the spec [00:57:15] so i made frig replace the sha1 in .lock with whatever is active in vendor. seemed like the shortest path to a usable thing. [00:57:46] Maybe frig could even emulate a working "dev-master" thing. but I wouldn't wish that on anyone [00:58:15] The idea of frig wrapping a packagist version bump was very interesting... [00:58:22] gotta run in a minute [00:58:49] yeah me too [00:58:57] hopefully this tool can grow with us [00:59:12] but the smashpig deploy is down to like 3 commands [00:59:50] awesome! [01:14:49] more fun tomorrow! [01:18:57] dstrine-meeting: Just to keep you in the loop before I sign off, it looks like Adyen may have stealth support for Hebrew, so we may not need to get translations after all. [02:07:08] (PS1) AndyRussG: [WIP] Mixed storage for buckets [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) [02:16:26] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2241843 (AndyRussG) Patches for review for T132639 follow Pro... [02:17:34] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2205231 (AndyRussG) a:AndyRussG [02:52:48] (PS9) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [02:53:58] (CR) jenkins-bot: [V: -1] New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [04:20:10] (PS10) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [04:21:13] (CR) jenkins-bot: [V: -1] New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [04:22:42] (CR) Awight: [C: 2] "This is thrilling! A todo for frig, it would be classy to include a courtesy listing of the submodule commits if this is a fast-forward f" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285560 (owner: Cdentinger) [04:24:53] (CR) Awight: "Uh, never mind it turns out I have no idea what I'm talking about. This commit message is perfect." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285560 (owner: Cdentinger) [04:29:27] (Merged) jenkins-bot: update wikimedia/smash-pig to 6ac4bba6aad3013bf2ddf967806f6b7f5e3647e7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285560 (owner: Cdentinger) [05:52:15] (PS1) Eileen: CRM-18842 Dedupe query: remove OR join in favour of more performant UNION [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132296) [12:10:52] (CR) Glaisher: [C: -1] CRM-18842 Dedupe query: remove OR join in favour of more performant UNION (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132296) (owner: Eileen) [13:23:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2242795 (AndyRussG) [15:47:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2243148 (PerfektesChaos) === TL;DR === If the ##getDependencies()## method at //CNChoiceDataResourceLoaderModule.php// would have been accessed everything would have... [15:55:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2243168 (PerfektesChaos) === Questionnaire addendum === * Is it still happening? ** ~~currently silent~~, but there have been intermittent calm periods ** Wed, Apr 27... [16:18:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MobileFrontend, Reading-Web: Measure impact of mobile web link preview on Central Notice interaction - https://phabricator.wikimedia.org/T131373#2243277 (MBinder_WMF) [16:18:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MobileFrontend, Reading-Web: Avoid z-index conflict with mobile web link preview & Central Notice and friends - https://phabricator.wikimedia.org/T131372#2243278 (MBinder_WMF) [16:18:38] Fundraising-Backlog, Hovercards, Reading-Web, Reading-Web-Sprint-72-N: Avoid z-index conflict with HoverCards & Central Notice and friends - https://phabricator.wikimedia.org/T131364#2243279 (MBinder_WMF) [16:25:26] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2243507 (AndyRussG) K, I just got the error going to https://de.wikipedia.org/wiki/Wikipedia:... [16:27:50] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2243584 (AndyRussG) p:Triage>Unbreak! [16:33:57] (PS1) AndyRussG: choiceData always checks for mw.centralNotice object [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285671 (https://phabricator.wikimedia.org/T133765) [16:35:30] cwd: ejegg: dstrine: XenoRyet|afk: ^ unbreak now CN issue on production. Patch is out, pinging operations... ;p [16:35:56] Hi AndyRussG ! I'll take a look [16:36:05] ejegg: woohoo thx much! [16:36:12] saw that ticket, sounds like fun stuff [16:38:08] hehe I think it's some weird RL issue where it's not processing dependencies in the right order [16:38:27] Unlikely to be our fault, that code has been working fine for a while... [16:38:35] (CR) Ejegg: [C: 2] "Looks correct! Might want to update the comment that says .display will always create it in a follow-on patch." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285671 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [16:39:20] ooh, so it may not be our fault, huh? [16:40:15] ejegg: thx! yeah I think something is either changed or wonky w/ RL [16:40:53] RL expects this to return code and eval? [16:41:33] cwd: the PHP code spits out JS to be executed, yeah [16:41:50] RL has all kinds of mechanisms for loading code, and should do so in the right order... [16:41:56] hmm, just looking at how .display acts when mw.centralNotice is already defined [16:42:18] if it /is/ defined, it does this: $.extend( mw.centralNotice, cn ); [16:42:27] cn = mw.centralNotice; [16:42:40] the extend part looks totally fine [16:42:46] ejegg: yeah, display itself is unable to know ahead of time [16:43:10] however from the perspective of choiceData it should be predictible [16:43:17] but I wonder if the cn reassignment could lead to two different objects existing in parallel [16:43:45] because some of the functions called on cn.blah() call other functions without the cn prefix [16:43:46] mmm in theory no, that code has been good for like over a year... [16:44:11] is that just because RL has been loading it first? [16:44:43] Yeah RL should load dependencies of a module first [16:45:14] So for display, it's not predictible if that or other things (like campaign mixins) that may also check for mw.centralNotice will load first or later [16:45:27] But choiceData should be at the top of the dependency chain [16:45:55] ah, I see, all of those functions that are being called without the cn. prefix aren't actually accessing any of the cn state variables via closure [16:47:41] u see the following line that resets the cn variable, eh? [16:49:34] yep, I was just looking at e.g. displayTestingBanner calling setUpDataProperty, and had thought setUpDataProperty was defined inside the cn object, rather than being outside it [16:50:26] then I actually checked on all of the things that are called without explicit scope, and realized none of them were inside the cn object [16:52:32] ejegg: ah yeah right, those are all "private" functions [16:52:48] (Merged) jenkins-bot: choiceData always checks for mw.centralNotice object [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285671 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [16:53:15] gonna make patch straight on to wmf_deploy [16:53:23] woohoo [16:54:53] (PS1) AndyRussG: choiceData always checks for mw.centralNotice object [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/285674 (https://phabricator.wikimedia.org/T133765) [16:56:25] Maybe I'll wait to see stuff on the beta cluster before merging that one tho... [17:05:31] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2244016 (AndyRussG) Looking more closely, it seems the ext.centralNotic... [17:06:11] (CR) AndyRussG: [C: -2] "This may not help, still investigating..." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/285674 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [17:11:25] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web, Reading-Web-Sprint-72-N: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2244050 (MBinder_WMF) [17:20:15] dstrine: I'm in the office--but wanted to ask, u think this is a productive meeting for me to attend? [17:20:28] Sorry to use you as a human shield. [17:21:14] awight, AndyRussG, XenoRyet, cwd: any news for scrum of scrums? [17:21:25] Na, not from here. [17:21:25] nope! ty [17:21:26] naw [17:21:58] k, cool [17:22:12] ejegg: no thx, other than the emergency bug. It looks like a deeper RL issue. ext.centralNotice.display isn't even being loaded! [17:22:28] awight: fyi https://phabricator.wikimedia.org/T133765 :) [17:22:45] ooh, sounds serious! I'll see what they're saying about it [17:22:50] Happens pretty consistently on de.wikipedia.org [17:23:03] AndyRussG: oh dear [17:23:13] yurp 8p [17:23:22] Not our fault, but fer sure on our plate [17:23:42] aww, where did stashbot go? [17:24:00] ejegg: stashbot only responds to a bare number, it seems. T133765 [17:24:01] T133765: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765 [17:24:11] ah, I see [17:24:44] I'd like to get the title when an URL is pasted, as long as it doesn't match a phab or gerrit notification [17:27:27] AndyRussG: should ext.centralNotice.display be a dependency of ext.centralNotice.choiceData? [17:27:42] oh, I see... dynamically set [17:28:01] ejegg: yep [17:28:21] Trying to find where the dependencies are described in the RL startup JS [17:40:23] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Unplanned-Sprint-Work: Frig should handle composer stuff - https://phabricator.wikimedia.org/T133402#2244208 (cwdent) [17:43:57] think i'm about ready to deploy smashpig with frig [17:44:06] * awight tightens hard hat [17:45:45] it will now update the vendor submodule: https://phabricator.wikimedia.org/D216 [17:46:47] it does not auto push commits for review but will alert you with output that they need it [17:47:06] one day at a time ;) [17:47:08] AndyRussG: Thiemo says getModifiedHas is outdated and we should use getDefinitionSummary [17:48:06] ejegg: ahhh K that sounds likely related... [17:49:43] awight: sorry I had everything closed during meeting. It was the usual full fundraising retro. [17:50:06] dstrine: It's actually fun to go to those and the standups, but I... have work to do [17:50:10] attendance wasn't mandatory or anything [17:50:11] Thanks for taking one for the team ;) [17:50:39] (PS1) Cdentinger: Updated smashpig for worldpay audit [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/285684 [17:50:40] there were a few of us there. notes are on the invite if you want to review [17:51:20] (PS1) Cdentinger: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285685 [17:53:27] ejegg, awight - either of you feel compelled to check over those magic merges? [17:54:01] * awight cackles and rubs hands [17:55:36] (CR) Awight: [C: 2] "Looks correct! Looks like it doesn't have a frig-generated commit message, though?" [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/285684 (owner: Cdentinger) [17:56:00] awight: correcto, i actually made that one poll for input [17:56:06] "please tell me what happened to vendor" [17:56:26] guessing at it would be pretty nasty [17:57:53] awight: do you mind if we wait till later to deploy this? i'm supposed to meet the nerds for lunch. [18:00:21] (CR) Awight: [C: -1] "Maybe I'm getting confused here, but I don't see crm/vendor SHA 37f4a4f7bc9f9b399c656f36a7d0864056ffd067 anywhere. Seems like that should" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285685 (owner: Cdentinger) [18:00:49] cwd: No rush from my side--I'll hold off on merging deployment things, then [18:01:27] awight: yeah you're right...weird [18:01:32] i will figure that out in a bit [18:01:34] thanks! [18:05:37] (Merged) jenkins-bot: Updated smashpig for worldpay audit [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/285684 (owner: Cdentinger) [18:20:01] ejegg: Aww man. Dependency injection gone awry... I'm trying to rewrite the SmashPig Amazon test config as YAML, but __DIR__ is biting me. You have any thoughts about how else to initialize the mock clients? [18:20:58] huh, tricky [18:21:40] hehe, we seem to be the only public repo using those classes [18:21:57] which classes? [18:22:31] the Mock* ones [18:23:19] d'oh. responseDirectory is used literally, no opportunity to replace tokens or anything [18:23:36] Maybe I can force the cwd to be something known [18:23:41] and we can use relative paths. [18:25:39] Fundraising-Backlog: Donation form error: Monthly selection is too sticky - https://phabricator.wikimedia.org/T133794#2244439 (MBeat33) [18:26:01] Fundraising-Backlog: Donation form error: Monthly selection is too sticky - https://phabricator.wikimedia.org/T133794#2244452 (MBeat33) p:Triage>Normal [18:29:03] ejegg: workedaround! [18:29:30] ah, relative paths was my first thought too! [18:30:32] awight: ohh, the Mock things are only in my fork... [18:31:31] wow, nice addition! [18:32:07] I think I forked too hard to ever get upstreamed though... broke the old class names [18:32:29] That'll do it :p [18:32:50] guess I should make that back-compatible and lobby for merge [18:33:29] They sounded receptive, from my vague recollection of that thread [18:34:43] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2242086 (Jdlrobson) The problem is for some reason under certain circum... [18:36:24] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Amazon, FR-Smashpig: Get Amazon SDK changes upstreamed - https://phabricator.wikimedia.org/T133795#2244475 (Ejegg) [18:40:14] (PS5) Awight: [WIP] Simplify config overrides read YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) [18:41:28] (CR) jenkins-bot: [V: -1] [WIP] Simplify config overrides read YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) (owner: Awight) [18:42:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search fails with database syntax error - https://phabricator.wikimedia.org/T133796#2244495 (awight) [18:45:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search by country fails with database syntax error - https://phabricator.wikimedia.org/T133796#2244508 (awight) [18:50:16] (PS14) Awight: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [18:50:18] (PS6) Awight: [WIP] Simplify config overrides read YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) [18:55:31] (PS7) Awight: Simplify configuration and read from YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) [18:58:17] dstrine-lunch: grab me for lunch if you're headed this way! [19:00:40] (PS11) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [19:01:58] (PS12) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [19:14:28] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2244643 (AndyRussG) Thanks so much @Jdlrobson!!! Yeah, so far it looks... [19:14:29] (PS13) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [19:14:31] (PS2) Awight: Check success in push and create table if necessary [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 [19:19:45] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2244659 (AndyRussG) Actually seems inconsistent now, tried the second U... [20:04:01] awight|meeting: re that weird submodule update, i think i must have commit to a branchless state [20:29:34] Fundraising-Backlog: SPRINT I (4/27-5/11) GOAL: Start Paypal Integration And start dedupe exact matches - https://phabricator.wikimedia.org/T131162#2244797 (DStrine) [20:31:12] Fundraising-Backlog: setup civi 4.7 on staging - https://phabricator.wikimedia.org/T133806#2244798 (DStrine) [20:33:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2244813 (DStrine) [20:33:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup civi 4.7 on staging - https://phabricator.wikimedia.org/T133806#2244825 (DStrine) [20:34:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2244827 (DStrine) [20:35:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2244840 (DStrine) [20:35:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2244813 (DStrine) [20:35:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2244813 (DStrine) [20:36:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2244845 (DStrine) [20:36:58] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2244846 (DStrine) [20:38:53] (PS2) Eileen: CRM-18842 Dedupe query: remove OR join in favour of more performant UNION [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) [20:39:40] awight|meeting: sorry I'm stuck in the east bay today. I gotta run to something right after work [20:39:47] (CR) Eileen: CRM-18842 Dedupe query: remove OR join in favour of more performant UNION (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [20:47:26] (PS1) Cdentinger: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285723 [20:51:02] aargh, new mysql enforces a lock name limit shorter than the names used by Civi [20:51:24] ugh [20:52:34] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2244903 (AndyRussG) Here is a Curl that seems to consistently get the w... [20:52:38] well, I'm going to relocate upstream for prawning [20:53:04] ejegg|afk: haha "upstream..." [20:54:26] * awight looks up the lifecycle of shrimp [20:55:02] Fundraising-Backlog, Security-Data-Mapping: FR Tech Data Map - https://phabricator.wikimedia.org/T133236#2244910 (awight) [20:56:30] Fundraising-Backlog, Security-Data-Mapping: Team writes draft data map - https://phabricator.wikimedia.org/T133810#2244911 (awight) [20:56:51] awight: i had vendor not on any branch when i pulled the new code [20:56:55] pretty sure that's what happened [20:57:47] can we revert the vendor change that already merged or is that awful? [20:58:28] cwd: aah wat [20:59:02] i just wanted to try it again with the change i made and see if that still happened [20:59:04] I'm not even sure how that part could have gone wrong [20:59:20] reflog shows nothing for that commit [21:00:45] awight: i imagine composer install vs. deployment branch would end up with a bunch of changes not on any branch right? [21:00:57] if you don't check the submodule out to master first [21:00:58] cwd: Maybe you can just manipulate your origin remote, if you want to revert just to test frig [21:01:09] set-url origin to a local thing and screw with master there? [21:01:19] yeah i can do that [21:01:35] If it gets nasty though, feel free to mangle git of course [21:02:18] I don't know what happens with submodules when you switch branches. I've seen so many different things, I'm not sure what to trust. [21:02:59] well it's not on any branch normally, and i think you can commit to that state with the idea of cherry picking them elsewhere [21:03:37] here's RL-caching-fun https://phabricator.wikimedia.org/T133765#2244903 [21:04:32] wat [21:04:37] cwd: you're blowing my mind. [21:05:06] oh--right, if you do a clean checkout of crm#deployment, you'll get crm/vendor#master, but it will be locked to a rev and not the branch [21:05:09] yeah i mean when you pin to a commit it is not in the context of a branch [21:05:14] gotcha [21:05:21] so no amount of pullinig can move you to a bad revision [21:05:46] yah [21:05:54] and you can commit to that branchless state but you can't do anything with those commits anywhere but your local repo unless you pull em to a branch and push somewhere tracked [21:05:59] so that must have been what happened [21:06:04] but i'm surprised gerrit didn't explode... [21:07:00] anyway i did this by hand and i think it should be the right thing https://gerrit.wikimedia.org/r/#/c/285723/ [21:07:14] i changed frig and will test elsewhere [21:07:24] I'm pretty sure git review will push them on the master branch--that's only determined by .gitreview, and not by the actual git branch. [21:07:44] oh yeah good point [21:08:47] oh shit so i guess that makes sense, on top of gerrit that floating commit would have been the one we saw [21:09:03] but when it was not on a branch the sha was what got pushed to crm submodules [21:09:04] (CR) Awight: [C: 1] "That's right. leaving the CR+2 for you to deploy!" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285723 (owner: Cdentinger) [21:09:25] it was the same change but in a different context had a different sha [21:09:28] i guess [21:09:28] The branch doesn't matter for anything AFAICT [21:09:41] maybe you made two of the commits? [21:10:01] yeah the branch doesn't matter but the content of the code does [21:10:12] and if it's not on a branch it has no history? [21:10:18] it does [21:10:38] a branch is just a sticky symbol pointing to a tip revision [21:11:04] oof, yeap [21:11:18] Sorry, I'm like speaking in truisms now [21:11:33] the gospel of git [21:11:39] hehe [21:11:54] It's true. Everyone who claims to explicate git turns out to be a huge weirdo [21:12:11] what it takes to survive [21:12:19] i have no more proof that git is true or false than any of the bible stories [21:13:20] awight: so uhh...crm should be deployable now right? [21:13:42] once i +2 that i mean [21:13:52] Looks good! [21:13:59] (CR) Cdentinger: [C: 2] update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285723 (owner: Cdentinger) [21:14:16] (Merged) jenkins-bot: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/285723 (owner: Cdentinger) [21:17:13] awight: normal to see a bunch of modified files in vendor because of perms? [21:17:27] Fundraising-Backlog: investigate any fr-tech work associated with hovercard test - https://phabricator.wikimedia.org/T133406#2244989 (Pcoombe) @awight Not sure I understand why we would use C and D buckets? My plan was just to use the same banner for everyone in our campaign. That banner would check a JS va... [21:18:31] cwd: yah, that is annoying eh [21:19:07] a little spooky [21:19:23] (PS14) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [21:19:54] aha, totten has a patch for the lock name problem https://issues.civicrm.org/jira/secure/attachment/46970/patch.txt [21:20:06] it's troubling in general when merging a bunch of commits into vendor turns into one big commit [21:20:21] but i don't know what the answer to that would be [21:20:31] ok i'm gonna deploy this real quick like [21:21:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search by country fails with database syntax error - https://phabricator.wikimedia.org/T133796#2244993 (CaitVirtue) I will encounter this error roughly once per week, and each time will have to run the report for every state/region in that coun... [21:22:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search by country fails with database syntax error - https://phabricator.wikimedia.org/T133796#2244994 (CaitVirtue) p:Triage>High [21:22:04] !log updated civicrm from 15a0086eef78f16110eba358a28ef78b51a385e1 to 777a91b8f9f6003a3eebdb8f2c73e45cc2bfb4a4 [21:22:11] lucky 7s [21:22:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:22:16] :-) [21:22:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search by country fails with database syntax error - https://phabricator.wikimedia.org/T133796#2244495 (CaitVirtue) [21:23:11] anyone interested in the CN issue, chatting now w/ bblack and Roan on -operations... [21:23:32] does not appear to have exploded civi [21:24:14] (PS3) Awight: Change message key of Canada province prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284620 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:24:41] (CR) Awight: [C: 2] Change message key of Canada province prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284620 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:24:51] (PS3) Awight: Allow single-parameter WmfFramework::messageExists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:25:28] (CR) Awight: [C: -1] "Need to make the change in gateway_common/WmfFramework.drupal.php as well." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:28:17] (PS4) Ejegg: Allow single-parameter WmfFramework::messageExists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) [21:28:58] (CR) Awight: Localize subdivisions (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284622 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:29:05] (CR) Ejegg: "ah, good catch! I sure don't want to make master MORE incompatible" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:32:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2245053 (Eileenmcnaughton) [21:32:40] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve the change log report - https://phabricator.wikimedia.org/T130164#2245051 (Eileenmcnaughton) Open>Resolved I'm going... [21:34:13] (CR) Ejegg: Localize subdivisions (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284622 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:34:15] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: create protocols and documentation for various civicrm database backup/restore/failov... - https://phabricator.wikimedia.org/T133617#2237501 [21:35:49] ejegg: meeting? [21:35:59] AndyRussG: meeting? [21:36:11] sorry, one sec! [21:36:28] dstrine: coming! [21:37:06] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2245108 (Eileenmcnaughton) [21:37:08] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Agree how we will deal with the trigger create mysql when we enable triggers - https://phabricator.wikimedia.org/T131230#2160081 (Eileenmcnaughton) Ope... [21:37:48] (Merged) jenkins-bot: Change message key of Canada province prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284620 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [21:47:48] Fundraising-Backlog: Donation form error: Monthly selection is too sticky - https://phabricator.wikimedia.org/T133794#2245142 (Pcoombe) @MBeat33 Weird, I did manage to reproduce this but can't immediately find the cause. Will poke at it a bit more tomorrow. [22:01:32] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 3 others: Using back button from AstroPay lands donor on unusable form - https://phabricator.wikimedia.org/T130673#2245156 (Ejegg) Open>Resolved p:Triage... [22:01:43] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 3 others: AstroPay should be the preferred payment method for supported countries - https://phabricator.wikimedia.org/T133181#2245158 (Ejegg) Open>Resolved [22:01:51] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Unplanned-Sprint-Work, Easy, and 3 others: Astropay errors should be red text and not popup - https://phabricator.wikimedia.org/T107363#2245159 (Ejegg) Open>Resolved [22:01:53] Fundraising-Backlog, FR-Astropay, Patch-For-Review: [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#2245161 (Ejegg) [22:05:46] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2245182 (DStrine) [22:05:48] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, and 3 others: Add 'Cancelled' type for refund messages - https://phabricator.wikimedia.org/T129714#2245179 (DStrine) Open>Resolved [22:05:50] Fundraising-Backlog, FR-Worldpay: Worldpay Audit Parser should catch more stuff - https://phabricator.wikimedia.org/T129917#2245181 (DStrine) [22:06:50] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, FR-Ingenico, and 2 others: Failure to regenerate Order ID on iDEAL form - https://phabricator.wikimedia.org/T131983#2245187 (Ejegg) Open>Resolved Saw 1 of those errors on 4/24 and one on 4/26,... [22:09:13] (PS1) Cdentinger: set payment_method on refunds etc [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285763 [22:09:53] (CR) jenkins-bot: [V: -1] set payment_method on refunds etc [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285763 (owner: Cdentinger) [22:13:35] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2245216 (Eileenmcnaughton) [22:13:37] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update trigger mysql in git to reflect latest change from upstream (connection_id) - https://phabricator.wikimedia.org/T133745#2245215 (Eileenmcnaughton) [22:14:14] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, and 2 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2237353 (Eileenmcnaughton) Hi Jeff, Are we definitely... [22:16:08] (PS2) Cdentinger: set payment_method on refunds etc [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285763 [22:19:00] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Unplanned-Sprint-Work: Frig should handle composer stuff - https://phabricator.wikimedia.org/T133402#2245220 (cwdent) Open>Resolved [22:21:08] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog: SPRINT H (4/13-4/27) GOAL: Adyen for new countries (Israel, Ukraine and more!) - https://phabricator.wikimedia.org/T131161#2245230 (DStrine) Open>Resolved [22:23:53] Fundraising-Backlog: Donation form error: Monthly selection is too sticky - https://phabricator.wikimedia.org/T133794#2245243 (MBeat33) Thank you, @Pcoombe [22:25:10] Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2245244 (DStrine) [22:25:12] Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup civi 4.7 on staging - https://phabricator.wikimedia.org/T133806#2245245 (DStrine) [22:25:14] Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search by country fails with database syntax error - https://phabricator.wikimedia.org/T133796#2245246 (DStrine) [22:25:16] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update trigger mysql in git to reflect latest change from upstream (connection_id) - https://phabricator.wikimedia.org/T133745#2245248 (DStrine) [22:25:18] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2245247 (DStrine) [22:25:20] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, and 2 others: create protocols and documentation for various civicrm database backup/restore/failover scenarios - https://phabricator.wikimedia.org/T133617#2245250 (... [22:25:22] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, and 3 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2245251 (DStrine) [22:25:24] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Write a hook to skip the calculated tables from conflict consideration - https://phabricator.wikimedia.org/T133625#2245249 (DStrine) [22:25:26] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Unplanned-Sprint-Work, and 3 others: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2245252 (DStrine) [22:25:28] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Continuous-Integration-Config, and 3 others: Run PHPUnit on PHP-Queue repo - https://phabricator.wikimedia.org/T133574#2245253 (DStrine) [22:25:31] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix logging hook name - https://phabricator.wikimedia.org/T133257#2245254 (DStrine) [22:25:32] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Enhance mustache state/province dropdown - https://phabricator.wikimedia.org/T133253#2245255 (DStrine) [22:25:35] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2245257 (DStrine) [22:25:38] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2245259 (DStrine) [22:25:41] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Spike: Consider finalizing AstroPay cash methods before redirect - https://phabricator.wikimedia.org/T132956#2245258 (DStrine) [22:25:44] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets, impression limitin... - https://phabricator.wikimedia.org/T132639#2245260 [22:25:48] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, and 3 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2245261 (DStrine) [22:25:50] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2245264 (DStrine) [22:25:52] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2245263 (DStrine) [22:25:54] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Document mass email - https://phabricator.wikimedia.org/T132369#2245265 (DStrine) [22:25:56] Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn logging on on live - https://phabricator.wikimedia.org/T132056#2245266 (DStrine) [22:25:58] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2245267 (DStrine) [22:25:59] Fundraising Sprint I 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write adapter or payment method - https://phabricator.wikimedia.org/T131811#2245268 (DStrine) [22:26:02] Fundraising Sprint I 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout controller - https://phabricator.wikimedia.org/T131808#2245269 (DStrine) [22:26:12] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Formalize schema for all message types - https://phabricator.wikimedia.org/T131272#2245274 (DStrine) [22:26:13] Fundraising Sprint I 2016, Fundraising-Backlog: SPRINT I (4/27-5/11) GOAL: Start Paypal Integration And start dedupe exact matches - https://phabricator.wikimedia.org/T131162#2245277 (DStrine) [22:26:14] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2245275 (DStrine) [22:26:18] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, and 3 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2245276 (DStrine) [22:26:20] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, and 3 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2245278 (DStrine) [22:26:22] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, and 2 others: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2245280 (DStrine) [22:26:27] Fundraising Sprint I 2016, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Adyen job runner log prepending too many IDs - https://phabricator.wikimedia.org/T129946#2245286 (DStrine) [22:26:30] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2245288 (DStrine) [22:26:32] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, and 3 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2245287 (DStrine) [22:26:35] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Permissions issue? "You do not have permission to access this page" - https://phabricator.wikimedia.org/T122519#2245290 (DStrine) [22:26:38] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2245291 (DStrine) [22:26:41] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising Tech Backlog, Fundraising-Backlog, and 4 others: Don't make donors guess minimum donation amount - https://phabricator.wikimedia.org/T105618#2245293 (DStrine) [22:26:44] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Style fields more cleanly for when donor enters form without currency or amount - https://phabricator.wikimedia.org/T113306#2245292 (DStrine) [22:26:47] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint I 2016, Fundraising-Backlog, and 3 others: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#2245295 (DStrine) [22:27:55] Fundraising Sprint I 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced search by country fails with database syntax error - https://phabricator.wikimedia.org/T133796#2244495 (Eileenmcnaughton) a:Eileenmcnaughton [22:42:39] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup civi 4.7 on staging - https://phabricator.wikimedia.org/T133806#2245345 (Eileenmcnaughton) a:Eileenmcnaughton [22:43:10] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2245347 (Eileenmcnaughton) a:Eileenmcnaughton [22:47:38] (PS3) Cdentinger: set payment_method on refunds etc [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285763 (https://phabricator.wikimedia.org/T129265) [22:50:08] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn logging on on live - https://phabricator.wikimedia.org/T132056#2245386 (Eileenmcnaughton) a:Eileenmcnaughton [22:50:44] awight|meeting: close this? https://phabricator.wikimedia.org/T132527 [22:51:21] based on our pre-deploy... [22:52:03] eileen: yes! [22:53:18] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 2 others: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2245395 (Eileenmcnaughton) [22:53:20] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 3 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2245393 (Eileenmcnaughton) Open>Resol... [22:53:42] I'm gonna walk home + work later... see you! [22:54:04] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 3 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2245399 (Eileenmcnaughton) @DStrine I was go... [22:56:06] i gotta go pick up the wife and dog but will also check in later [23:13:44] I gotta run too. I'll check email much later tonight. [23:43:02] (PS1) Eileen: Change label from 'Save' to 'Update' on report options. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285773 (https://phabricator.wikimedia.org/T99837) [23:43:04] (PS1) Eileen: add test for contact.merge action [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285774 (https://phabricator.wikimedia.org/T115426) [23:43:06] (PS1) Eileen: CRM-17422 fix - Change in custom field search behaviour impacting on performance [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285775 (https://phabricator.wikimedia.org/T99842) [23:43:08] (PS1) Eileen: Comment out trigger creation [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285776 [23:43:10] (PS1) Eileen: Don't create SQL function at runtime [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285777 (https://phabricator.wikimedia.org/T117044) [23:43:12] (PS1) Eileen: Give contribution date range a tighter layout [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285778 (https://phabricator.wikimedia.org/T116420) [23:43:14] (PS1) Eileen: Add a setting to disable the dedupe on edit [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285779 (https://phabricator.wikimedia.org/T117172) [23:43:16] (PS1) Eileen: Fix slow search on transaction ID (remove wildcard) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285780 (https://phabricator.wikimedia.org/T117492) [23:43:18] Apologies all I think what I just did will damage your inboxes [23:43:18] (PS1) Eileen: Fix slow search on email - remove wildcard [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285781 [23:43:20] (PS1) Eileen: CRM-17466 - Refine error message [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285782 [23:43:22] (PS1) Eileen: Footer tpl cleanup [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285783 [23:43:24] (PS1) Eileen: Add deprecation comments to 4.2 custom api [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285784 [23:43:26] (PS1) Eileen: Fix report criteria not showing in output mode [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285785 [23:43:28] (PS1) Eileen: Fix save a copy behaviour on report [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285786 [23:43:30] (PS1) Eileen: CRM-17536 fix quicksearch label for when email search is disabled [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285787 (https://phabricator.wikimedia.org/T118036) [23:43:32] (PS1) Eileen: CRM-17537 use name label only when search excludes email [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285788 [23:43:34] (PS1) Eileen: Fix slow email search [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285789 [23:43:36] (PS1) Eileen: Fix link to output report as print [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285790 [23:43:38] (PS1) Eileen: CRM-17464 remove deadlock inducing query [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285791 (https://phabricator.wikimedia.org/T119447) [23:43:40] (PS1) Eileen: CRM-17454 fix slow dedupe query [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285792 (https://phabricator.wikimedia.org/T116886) [23:43:42] (PS1) Eileen: Fix reports save a copy link [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285793 (https://phabricator.wikimedia.org/T117166) [23:43:43] I've just put our patches in review for the core-based repo [23:43:44] (PS1) Eileen: CRM-17644 fix caching on tax rates to still cache if none set [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285794 (https://phabricator.wikimedia.org/T119986) [23:43:46] (PS1) Eileen: CRM-17620 expose payment data for contributions in the UI [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285795 (https://phabricator.wikimedia.org/T116317) [23:43:48] (PS1) Eileen: fix missing arg on upgrade [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285796 (https://phabricator.wikimedia.org/T116877) [23:43:50] (PS1) Eileen: CRM-17680 fix core Lybunt to sort by the sort field (and add last year field to the list) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285797 (https://phabricator.wikimedia.org/T119911) [23:43:52] (PS1) Eileen: CRM-17680 fix core Lybunt to show last-year total [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285798 (https://phabricator.wikimedia.org/T119909) [23:43:54] (PS1) Eileen: CRM-17675 set date AND time to 'now' when refunding contributions [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285799 (https://phabricator.wikimedia.org/T116317) [23:43:56] (PS1) Eileen: CRM-17641 backport Civi class in order to support other backports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285800 (https://phabricator.wikimedia.org/T116724) [23:43:56] (which I will self approve as it's just git wrangling) [23:43:58] (PS1) Eileen: Fix generated SQL [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285801 [23:44:00] (PS1) Eileen: CRM-17691 do not use default return properties from search screen [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285802 (https://phabricator.wikimedia.org/T120892) [23:44:02] (PS1) Eileen: Free the DAO, if it comes back it's yours [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285803 (https://phabricator.wikimedia.org/T120892) [23:44:04] (PS1) Eileen: CRM-17691 when doing a query to retrieve ids for export ... only retrieve the ids [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285804 (https://phabricator.wikimedia.org/T120892) [23:44:06] (PS1) Eileen: CRM-17691 add the campaign id to selector even though it ? is not used? [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285805 (https://phabricator.wikimedia.org/T121284) [23:44:08] (PS1) Eileen: (merged into 4.6.11) Backport FinancialTrxn api [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285806 (https://phabricator.wikimedia.org/T116317) [23:44:10] (PS1) Eileen: (merged into 4.6.11) Backport EntityFinancialTrxn api [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285807 (https://phabricator.wikimedia.org/T116317) [23:44:12] (PS1) Eileen: (merged into 4.7) Whitespace only. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285808 (https://phabricator.wikimedia.org/T120332) [23:44:14] (PS1) Eileen: (backport from 4.7) CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285809 (https://phabricator.wikimedia.org/T116724) [23:44:16] (PS1) Eileen: Partial backport of DB initialisation fixes. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285810 (https://phabricator.wikimedia.org/T116724) [23:44:18] (PS1) Eileen: CRM-17806 Class-api: Check if constant is defined before defining it [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285811 (https://phabricator.wikimedia.org/T123333) [23:44:20] (PS1) Eileen: (proposed for 4.7) CRM-17439 layout changes for advanced search panes [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285812 (https://phabricator.wikimedia.org/T120332) [23:44:22] (PS1) Eileen: (patch already in 4.7) CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285813 (https://phabricator.wikimedia.org/T116317) [23:44:24] (PS1) Eileen: (merged into 4.7) CRM-17627 Set transaction date correctly for refunds [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285814 (https://phabricator.wikimedia.org/T116317) [23:44:26] (PS1) Eileen: (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285815 (https://phabricator.wikimedia.org/T116317) [23:44:28] (PS1) Eileen: (merged into 4.7) CRM-17700 allow contribution get to bypass permissions [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285816 (https://phabricator.wikimedia.org/T121284) [23:44:30] (PS1) Eileen: CRM-17751 add refund trxn to forms [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285817 (https://phabricator.wikimedia.org/T116317) [23:44:32] (PS1) Eileen: Hack out credit note calculation [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285818 (https://phabricator.wikimedia.org/T123305) [23:44:34] (PS1) Eileen: Back port changes to support altering indexes in an upgrade-proof way [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285819 (https://phabricator.wikimedia.org/T122947) [23:44:36] (PS1) Eileen: CRM-17951 (merged into 4.7) Add function to safe-add option values in upgrade [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285820 (https://phabricator.wikimedia.org/T124979) [23:44:38] (PS1) Eileen: CRM-17177. die() instead of trigger_error() when accessed via web. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285821 [23:44:40] (PS1) Eileen: Added is_view check to prevent editing read only custom fields. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285822 [23:44:42] (PS1) Eileen: Reworked patch to be smaller and error proof. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285823 [23:44:44] (PS1) Eileen: CRM-17733 Update DOMPDF to 0.6.2 [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285824 [23:44:46] (PS1) Eileen: Add Entity Financial Account api [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285825 (https://phabricator.wikimedia.org/T124979) [23:44:48] (PS1) Eileen: CRM-17951 preliminary refactoring to improve code legibility [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285826 [23:44:50] (PS1) Eileen: Search speed fix - partial backport of CRM-17492 [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285827 (https://phabricator.wikimedia.org/T123418) [23:44:52] (PS1) Eileen: CRM-17951 ( merged into 4.7) add support for Chargeback contribution status and having an account relationship for refunds. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285828 (https://phabricator.wikimedia.org/T124979) [23:44:54] (PS1) Eileen: CRM-17951 form fixes to make chargeback more consistent with refund behaviour [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285829 [23:44:56] (PS1) Eileen: CRM-17951 form fixes for chargeback [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285830 (https://phabricator.wikimedia.org/T124979) [23:44:58] (PS1) Eileen: CRM-17951 (merged into 4.7) modify transaction view to show the financial account of the transaction [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285831 (https://phabricator.wikimedia.org/T124979) [23:45:00] (PS1) Eileen: Fix error when updating completed transaction. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285832 (https://phabricator.wikimedia.org/T124979) [23:45:02] (PS1) Eileen: Stop adding duplicate sql to developer tab [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285833 [23:45:04] (PS1) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285834 (https://phabricator.wikimedia.org/T123671) [23:45:06] (PS1) Eileen: CRM-18091 disambiguate TRUE as not meaning 'backtrace' [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285835 [23:45:08] (PS1) Eileen: CRM-18094 output queries for debugging using print_r rather than the crufty var_dump routine. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285836 [23:45:10] (PS1) Eileen: CRM-18093 point query debugging to separate log file [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285837 [23:45:12] (PS1) Eileen: CRM-18095 cache the debugLogger to save some file_exists checks [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285838 [23:45:14] (PS1) Eileen: CRM-18109 towards removal of unindexed queries [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285839 [23:45:16] (PS1) Eileen: Stop bypassing caching for state_province abbreviation [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285840 (https://phabricator.wikimedia.org/T120892) [23:45:18] (PS1) Eileen: CRM-17748 Expose options['result_buffering'] to CRM_Core_DAO [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285841 (https://phabricator.wikimedia.org/T120892) [23:45:20] (PS1) Eileen: Return more rows per query and use unbuffered query to manage the memory [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285842 (https://phabricator.wikimedia.org/T120892) [23:45:22] (PS1) Eileen: Cast var to an array to avoid an e-Notice [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285843 [23:45:24] (PS1) Eileen: CRM-18125 remove country_id from filter where state_province_id is present [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285844 (https://phabricator.wikimedia.org/T120892) [23:45:26] (PS1) Eileen: CRM-18112 - Additional permission for editing "api_key" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285845 [23:45:28] (PS1) Eileen: CRM-18246 Lybunt group clause not being included in temp table due to order of operations [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285846 (https://phabricator.wikimedia.org/T123671) [23:45:30] (PS1) Eileen: Increase time out while doing exports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285847 (https://phabricator.wikimedia.org/T120892) [23:45:32] (PS1) Eileen: Further time limit increase on exports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285848 (https://phabricator.wikimedia.org/T120892) [23:45:34] (PS1) Eileen: sync with 4.7 [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285849 (https://phabricator.wikimedia.org/T130161) [23:45:36] (PS1) Eileen: CRM-18104 Hook for defining log tables. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285850 (https://phabricator.wikimedia.org/T130161) [23:45:39] (PS1) Eileen: CRM-18180 allow non-standard table names in logging reports [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285851 (https://phabricator.wikimedia.org/T130161) [23:45:40] (PS1) Eileen: CRM-18213 remove hard-coding of DAO names [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285852 [23:45:42] (PS1) Eileen: CRM-18213 remove hard-coded DAO names [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285853 [23:45:44] (PS1) Eileen: Add tests for logging functionality to ensure the tables are still creating well [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285854 (https://phabricator.wikimedia.org/T130161) [23:45:46] (PS1) Eileen: Add settings metadata to support enabling logging functions [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285855 (https://phabricator.wikimedia.org/T131225) [23:45:48] (PS1) Eileen: CRM-18193 make unique ID for request available to php & mysql [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285856 (https://phabricator.wikimedia.org/T131222) [23:45:50] (PS1) Eileen: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285857 (https://phabricator.wikimedia.org/T131224) [23:45:53] (PS1) Eileen: CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285858 (https://phabricator.wikimedia.org/T131222) [23:45:55] (PS1) Eileen: Fix to enable logging in multisite [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285859 (https://phabricator.wikimedia.org/T131223) [23:45:57] (PS1) Eileen: CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285860 (https://phabricator.wikimedia.org/T131222) [23:45:59] (PS1) Eileen: Add trigger creation SQL for live DB [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285861 (https://phabricator.wikimedia.org/T131230) [23:46:01] (PS1) Eileen: CRM-18096 Slow queries when rendering logging tab [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285862 (https://phabricator.wikimedia.org/T131229) [23:46:03] (PS1) Eileen: Sync logging enable routine with master to reflect porting of setting.create function [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285863 (https://phabricator.wikimedia.org/T131228) [23:46:05] (PS1) Eileen: CRM-18134 move api merge activity contact function to the BAO [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285864 [23:46:07] (PS1) Eileen: CRM-18106 create activity against contact deleted by merge [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285865 (https://phabricator.wikimedia.org/T119426) [23:46:09] (PS1) Eileen: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285866 (https://phabricator.wikimedia.org/T131224) [23:46:11] (PS1) Eileen: Remove commenting [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285867 (https://phabricator.wikimedia.org/T131224) [23:46:13] (PS1) Eileen: CRM-18193 add routine for converting log tables to support new log_conn_id format & hook spec [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285868 (https://phabricator.wikimedia.org/T131222) [23:46:15] (PS1) Eileen: CRM-18178 exclude _bak & _backup tables from trigger creation [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285869 (https://phabricator.wikimedia.org/T131221) [23:46:17] (PS1) Eileen: NFC preliminary tidy up for CRM-18332 [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285870 [23:46:19] (PS1) Eileen: CRM-18332 add first cut of api for revert actions [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285871 [23:46:21] (PS1) Eileen: CRM-18360 Expose logging data through GET api [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285872 [23:46:23] (PS1) Eileen: CRM-18193 Make log_date optional for revert / retrieving changes where uniqueID is in play [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285873 [23:46:25] (PS1) Eileen: CRM-18193 remove arbitrary setting of log_date when not provided. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285874 [23:46:27] (PS1) Eileen: Sync Logging_Schema with upstream incl comma from CRM-17685 [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285875 (https://phabricator.wikimedia.org/T131223) [23:46:29] (PS1) Eileen: Fix call to Setting.getvalue [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285876 [23:46:31] (PS1) Eileen: Follow up to 'Sync Logging_Schema with upstream incl comma from CRM-17685' [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285877 (https://phabricator.wikimedia.org/T131223) [23:46:33] (PS1) Eileen: CRM-18366 Fix contact logging detail to show all related changes & revert all related changes [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285878 [23:46:35] (PS1) Eileen: CRM-18193 do not require log_date [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285879 [23:46:37] (PS1) Eileen: CRM-18193 do not pass log_date_id to detail report if the log_conn_id is sufficient [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285880 [23:46:39] (PS1) Eileen: CRM-18215 Fix grouping so that Merge activities are not sometimes lost [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285881 [23:46:41] (PS1) Eileen: CRM-18409 fix inability to view activity if source contact is deleted [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285882 (https://phabricator.wikimedia.org/T122519) [23:46:43] (PS1) Eileen: CRM-18214 Add link to detail report for contact merge activities, with oid if applicable. [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285883 [23:46:45] (PS1) Eileen: CRM-17983, CRM-18401 sanitise post params on activity tab [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285884 [23:46:47] (PS1) Eileen: CRM-18404 Rebuild triggers not including all tables [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285885 [23:46:53] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Permissions issue? "You do not have permission to access this page" - https://phabricator.wikimedia.org/T122519#2245543 (Eileenmcnaughton) Open>Resolved Cai... [23:49:26] (CR) Eileen: [C: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285773 (https://phabricator.wikimedia.org/T99837) (owner: Eileen) [23:49:48] (CR) Eileen: [V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285773 (https://phabricator.wikimedia.org/T99837) (owner: Eileen) [23:51:50] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285774 (https://phabricator.wikimedia.org/T115426) (owner: Eileen) [23:52:09] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285775 (https://phabricator.wikimedia.org/T99842) (owner: Eileen) [23:52:51] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285776 (owner: Eileen) [23:53:09] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285777 (https://phabricator.wikimedia.org/T117044) (owner: Eileen) [23:53:25] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285778 (https://phabricator.wikimedia.org/T116420) (owner: Eileen) [23:53:45] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285779 (https://phabricator.wikimedia.org/T117172) (owner: Eileen) [23:54:01] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285780 (https://phabricator.wikimedia.org/T117492) (owner: Eileen) [23:54:27] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285781 (owner: Eileen) [23:54:42] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285782 (owner: Eileen) [23:54:58] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285783 (owner: Eileen) [23:55:12] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285784 (owner: Eileen) [23:55:30] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285785 (owner: Eileen) [23:55:45] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285786 (owner: Eileen) [23:56:12] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285787 (https://phabricator.wikimedia.org/T118036) (owner: Eileen) [23:56:52] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285788 (owner: Eileen) [23:57:12] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285789 (owner: Eileen) [23:57:28] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285790 (owner: Eileen) [23:57:44] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285791 (https://phabricator.wikimedia.org/T119447) (owner: Eileen) [23:58:03] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285792 (https://phabricator.wikimedia.org/T116886) (owner: Eileen) [23:58:19] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285793 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [23:58:34] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285794 (https://phabricator.wikimedia.org/T119986) (owner: Eileen) [23:59:11] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285795 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:59:26] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285796 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [23:59:42] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285797 (https://phabricator.wikimedia.org/T119911) (owner: Eileen)