[00:00:02] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285798 (https://phabricator.wikimedia.org/T119909) (owner: Eileen) [00:00:22] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285799 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:00:38] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285800 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [00:00:52] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285801 (owner: Eileen) [00:01:07] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285802 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [00:01:24] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285803 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [00:01:39] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285804 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [00:01:55] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285805 (https://phabricator.wikimedia.org/T121284) (owner: Eileen) [00:02:11] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285806 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:02:27] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285807 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:02:48] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285808 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [00:03:02] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285809 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [00:03:16] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285810 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [00:03:30] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285811 (https://phabricator.wikimedia.org/T123333) (owner: Eileen) [00:03:44] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285812 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [00:03:57] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285813 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:04:13] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285814 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:04:29] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285815 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:04:43] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285816 (https://phabricator.wikimedia.org/T121284) (owner: Eileen) [00:04:57] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285817 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:05:11] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285818 (https://phabricator.wikimedia.org/T123305) (owner: Eileen) [00:05:26] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285819 (https://phabricator.wikimedia.org/T122947) (owner: Eileen) [00:05:40] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285820 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:05:56] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285821 (owner: Eileen) [00:06:35] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285822 (owner: Eileen) [00:06:51] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285823 (owner: Eileen) [00:07:04] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285824 (owner: Eileen) [00:07:33] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285825 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:16:00] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285826 (owner: Eileen) [00:16:17] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285827 (https://phabricator.wikimedia.org/T123418) (owner: Eileen) [00:16:32] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285828 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:16:48] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285829 (owner: Eileen) [00:17:02] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285830 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:18:00] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285831 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:18:22] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285832 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:18:37] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285833 (owner: Eileen) [00:18:53] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285834 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [00:19:09] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285835 (owner: Eileen) [00:19:26] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285836 (owner: Eileen) [00:19:48] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285837 (owner: Eileen) [00:20:02] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285838 (owner: Eileen) [00:20:17] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285839 (owner: Eileen) [00:21:14] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285842 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [00:21:18] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285843 (owner: Eileen) [00:21:34] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285844 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [00:21:50] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285845 (owner: Eileen) [00:22:04] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285846 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [00:22:21] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285847 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [00:22:38] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285848 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [00:23:02] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285849 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [00:23:18] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285850 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [00:23:31] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285851 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [00:23:46] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285852 (owner: Eileen) [00:24:01] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285853 (owner: Eileen) [00:24:14] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285854 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [00:24:33] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285855 (https://phabricator.wikimedia.org/T131225) (owner: Eileen) [00:24:47] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285856 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [00:25:10] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285857 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [00:25:23] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285858 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [00:25:36] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285859 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [00:25:50] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285860 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [00:26:05] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285861 (https://phabricator.wikimedia.org/T131230) (owner: Eileen) [00:26:21] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285862 (https://phabricator.wikimedia.org/T131229) (owner: Eileen) [00:26:36] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285863 (https://phabricator.wikimedia.org/T131228) (owner: Eileen) [00:26:53] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285864 (owner: Eileen) [00:27:08] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285865 (https://phabricator.wikimedia.org/T119426) (owner: Eileen) [00:27:22] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285866 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [00:27:37] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285867 (https://phabricator.wikimedia.org/T131224) (owner: Eileen) [00:27:51] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285868 (https://phabricator.wikimedia.org/T131222) (owner: Eileen) [00:28:05] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285869 (https://phabricator.wikimedia.org/T131221) (owner: Eileen) [00:28:18] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285870 (owner: Eileen) [00:28:32] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285871 (owner: Eileen) [00:28:46] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285872 (owner: Eileen) [00:29:00] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285873 (owner: Eileen) [00:29:27] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285874 (owner: Eileen) [00:29:42] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285875 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [00:30:00] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285876 (owner: Eileen) [00:30:14] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285877 (https://phabricator.wikimedia.org/T131223) (owner: Eileen) [00:30:30] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285878 (owner: Eileen) [00:30:45] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285879 (owner: Eileen) [00:31:01] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285880 (owner: Eileen) [00:31:19] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285881 (owner: Eileen) [00:31:32] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285882 (https://phabricator.wikimedia.org/T122519) (owner: Eileen) [00:31:47] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285883 (owner: Eileen) [00:32:03] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285884 (owner: Eileen) [00:32:21] (CR) Eileen: [C: 2 V: 2] "This is just bringing an approved, deployed patch from our deployed civicrm code repo to the civicrm-core repo, which is based on the upst" [wikimedia/fundraising/civicrm-core] (civi-4.6.9) - https://gerrit.wikimedia.org/r/285885 (owner: Eileen) [00:47:26] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 3 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2245668 (Jgreen) Yes, let's go same db. [00:50:39] hooray, no 2-phase commit issues! [01:05:19] (PS15) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [01:07:33] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Continuous-Integration-Config, and 3 others: Run PHPUnit on PHP-Queue repo - https://phabricator.wikimedia.org/T133574#2245726 (awight) [01:07:42] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Continuous-Integration-Config, and 3 others: Run PHPUnit on PHP-Queue repo - https://phabricator.wikimedia.org/T133574#2236211 (awight) Open>Resolved [01:11:44] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2245749 (AndyRussG) [01:53:32] oh man, Civi's got issues under HHVM too ... kills the service and dumps core when I hit the contribution search page [01:53:56] would they be the same issues as under php7? [01:56:09] php7 refuses to run it due to something eval'ed in DBObject ... lemme see [01:56:32] hhvm gets a lot closer - a lot of pages work [01:58:02] there is an reference on the fields functions in the DAOs that is not 5.7 compatible I think [01:58:07] although it may only grumble [01:59:44] ah, here it was: syntax error, unexpected 'clone' (T_CLONE), expecting identifier (T_STRING) or '(' in require_once() (line 1 of /home/elliott/src/php/fundraising/crm/civicrm/packages/DB/DataObject.php(207) : eval()'d code) [02:00:41] oh look, there's a comment at the top of that class with a workaround for Zend Optimiser segfaults. [02:01:52] :-) [02:02:52] oooh, it's assuming that if PHP version doesn't start with '5', it must be lower, and need some shims [02:03:17] hehe, windows 9 issues [02:03:50] opps [02:04:12] easy fix though! [02:05:31] ah, already corrected in core [02:05:53] using version_compare [02:06:09] upstream civi core? [02:06:18] yep, master at least [02:06:37] let's see if the fix got applied to 4.6 recently [02:07:56] cool [02:08:12] err, wait, i was looking at a different spot... [02:08:16] let me check again [02:08:19] I'm kinda trying to get us onto latest 4.6 update sooni [02:10:22] ah, nope, looks like it'll still hit the problem block [02:10:44] :-( [02:11:09] because function_exists('clone') still returns false in php7 [02:11:16] if you want to try on the latest civicrm codebase http://dist.civicrm.org/by-date/latest/4.7.7-rc/ [02:11:24] but I suspect clone is still used.. [02:12:48] well, still an easy fix. The whole else block down there has gotta be for versions less than 5 [02:16:49] oh, derp.. packages is ignored, I had to set that up. Lemme get the latest of /that/ [02:17:30] and.... it's not civi core at all [02:17:43] 2009 version of http://pear.php.net/package/DB_DataObject [02:17:56] eek, that could be a scary upgrade [02:19:58] yeah discussion about change have gone on for years… [02:20:29] no clone shim at all in the new version [02:21:53] civi doesn't need php4, so I guess there must be some more controversial changes [02:22:43] aha, https://github.com/civicrm/civicrm-packages/pull/147 [02:24:47] might as keep things interesting and run php7 for civi and hhvm for mw. [02:25:06] but... not tonight. See ya on the flipside! [08:54:46] (PS16) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [13:38:22] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2248507 (PerfektesChaos) > how do things look on your end? * Th... [14:52:15] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Permissions issue? "You do not have permission to access this page" - https://phabricator.wikimedia.org/T122519#2248703 (DStrine) [15:30:47] (CR) Glaisher: CRM-18842 Dedupe query: remove OR join in favour of more performant UNION [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [15:59:45] (PS1) Ejegg: Replace misleading fiscal number abbr [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/285978 [16:12:57] (CR) Katie Horn: [C: 2] "Yay, unambiguous non-abbreviations!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/285978 (owner: Ejegg) [16:13:00] (CR) Cdentinger: [C: 2] Replace misleading fiscal number abbr [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/285978 (owner: Ejegg) [16:13:11] doh [16:13:23] i hope that doesn't confuse zuul [16:13:37] Too many agreements? [16:13:54] I guess maybe we don't have that problem much. [16:13:56] :p [16:14:01] hehe [16:14:37] (CR) Cdentinger: Replace misleading fiscal number abbr [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/285978 (owner: Ejegg) [16:15:00] there we go [16:15:25] (Merged) jenkins-bot: Replace misleading fiscal number abbr [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/285978 (owner: Ejegg) [16:18:29] cool, I'll just do a mini-deploy [16:20:03] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/285982 [16:20:26] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/285982 (owner: Ejegg) [16:21:33] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/285983 [16:21:46] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/285983 (owner: Ejegg) [16:41:05] !log updated payments-wiki from 16ed5af8c8544ea1c8d837ae16585eba4cbbfd4e to c502ab2f6b6ff914d67503a664d36076fdc32dcf [16:41:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:42:10] ok, no longer misleading Colombian donors [17:09:15] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2249058 (AndyRussG) > >how do things look on your end? >Thanks... [18:17:50] (PS1) Ejegg: Use consistent field labels in error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286011 (https://phabricator.wikimedia.org/T133706) [18:24:42] cwd or XenoRyet : mind taking a look at https://gerrit.wikimedia.org/r/#/c/281084/ ? [18:24:53] awight and I have both worked on it [18:26:30] I'm writing some client-side fiscal # validation, and I'd like to have the rules in just one place [18:26:52] but that patch moves them in the back end [18:28:31] sure [18:29:02] ejegg: want to hit me back? https://gerrit.wikimedia.org/r/#/c/285763/ [18:29:18] super simple, but i don't see how refunds ever worked before... [18:29:37] sure thing! [18:30:47] Also, I'm still running into the wall on getting that Adyen iframe to show. If either one of you has a quick second to just see if you can get it to display locally, that'd be helpful. Just make extra sure the problem actually is on my end. [18:31:13] wait, refunds need payment type now? That was never part of the message before: https://wikitech.wikimedia.org/wiki/Fundraising/Normalized_donation_messages#Refunds [18:32:02] ejegg: it crashed into something that was requiring payment method yeah [18:32:58] let me dig it up [18:53:37] cwd you had a good nginx/hhvm setup running mediawiki, right? [18:53:56] yep! need any configs? [18:54:05] yes please! [18:54:30] I'm getting 'could not connect' half the time, and just the text 'run();' otherwise [18:54:45] heh [18:55:01] new ubuntu must be systemd right? have you checked the journal? [18:55:05] wanna email me your nginx mediawiki site config? [18:55:34] the hhvm service logs its crashes to syslog [18:55:51] and I'm not seeing any of those when I hit the mediawiki site [18:58:09] ejegg: i have a super pared down host file right here: https://tools.wmflabs.org/paste/view/81be2ae3 [18:58:15] thanks! [19:08:21] working like a charm, thanks again cwd! [19:08:37] you bet! [19:09:53] (Abandoned) Cdentinger: set payment_method on refunds etc [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285763 (https://phabricator.wikimedia.org/T129265) (owner: Cdentinger) [19:10:47] XenoRyet: OK, now that I can run mediawiki at all, I can get the Adyen iframe to open just fine [19:15:51] ejegg: Alright, must be something with my set up. Thanks for checking. [19:16:32] lemme try messing with a parameter and see if I get the error HTML in an comment like I was getting before [19:18:10] I did find an old thread where cwd was getting set up and got the error when merchantAccount and/or skinCode was left off. I'm pretty sure I have those set properly though. [19:29:39] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make it impossible for people to send us their credit card number - https://phabricator.wikimedia.org/T133937#2249557 (Ejegg) [19:30:09] Jeff_Green: T133937 [19:30:10] T133937: Make it impossible for people to send us their credit card number - https://phabricator.wikimedia.org/T133937 [19:30:51] ejegg: great [19:45:10] (PS6) Cdentinger: Explore encapsulating validation along with transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281084 (owner: Awight) [19:48:41] ejegg: name still says "exploring" but unless you have reservations i feel like that's good to go [19:49:03] explore even [19:49:33] word, I'll update the commit message [19:50:14] :) [19:50:51] (PS7) Ejegg: Encapsulate validation along with transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281084 (owner: Awight) [19:54:54] XenoRyet: https://gerrit.wikimedia.org/r/286021 [19:55:49] oh, another explanatory vagrant patch: https://gerrit.wikimedia.org/r/283693 [19:56:13] Huh, looks like I don't have +2 authority for vagrant. [19:56:31] oh weird [19:56:31] I +1d though. [19:56:41] cwd do you have +2 on the vagrant repo? [19:57:01] (CR) Cdentinger: [C: 2] "Great idea, and minimally invasive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281084 (owner: Awight) [19:57:08] i don't think so [19:57:15] ah, odd [19:57:29] oh nm i guess i do! [19:58:20] (Merged) jenkins-bot: Encapsulate validation along with transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281084 (owner: Awight) [19:58:46] thanks! [20:36:21] (PS1) Cdentinger: test cancel [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286026 [21:19:18] (CR) Ejegg: [C: 2] test cancel [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286026 (owner: Cdentinger) [21:20:06] (Merged) jenkins-bot: test cancel [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286026 (owner: Cdentinger) [21:31:38] (PS1) Cdentinger: BaseAuditProcessor&record_is_cancel() [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286061 [21:32:56] (CR) Ejegg: "I really like the new interface! Just a couple comments." (3 comments) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [21:34:56] (PS1) Raimond Spekking: Revert "Localisation updates from https://translatewiki.net." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286064 [21:35:40] (CR) Ejegg: [C: 2] "The Alphabet Allocation Board has approved your request for 'x'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286061 (owner: Cdentinger) [21:38:19] (Merged) jenkins-bot: BaseAuditProcessor&record_is_cancel() [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286061 (owner: Cdentinger) [21:38:45] (CR) Ejegg: "Thanks! Should we restore the unrelated changes that were rolled back along with the fiscal number label breakage, or will the magical tr" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286064 (owner: Raimond Spekking) [21:40:09] hehe, thanks ejegg ! [21:40:17] (CR) Ejegg: "Also, does L10n-bot auto-merge everything with a commit message like that? Yikes!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286064 (owner: Raimond Spekking) [21:40:32] heh, anytime [21:41:43] whee, got crm working under php7.0 and mediawiki working under hhvm, both via nginx. Now to get xdebug back... [21:44:19] can anybody look at https://gerrit.wikimedia.org/r/284623 and dependencies? I'd like to mess with some of those same files for validation [21:52:43] (PS1) Cdentinger: update wikimedia/smash-pig to bc16fd9c319c8ca7e8795883f1e45ba51c0bd9e5 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286069 [21:56:12] (PS1) Cdentinger: Update smashpig, test worldpay cancels [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/286071 [21:56:54] crap [21:57:15] something went badly and i have to be in this review meeting for the rest of the day [21:58:14] (Abandoned) Cdentinger: Update smashpig, test worldpay cancels [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/286071 (owner: Cdentinger) [21:58:21] (Abandoned) Cdentinger: update wikimedia/smash-pig to bc16fd9c319c8ca7e8795883f1e45ba51c0bd9e5 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286069 (owner: Cdentinger) [22:43:59] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Continuous-Integration-Config, and 3 others: Run PHPUnit on PHP-Queue repo - https://phabricator.wikimedia.org/T133574#2250199 (DStrine) [22:44:02] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 3 others: Reassure ourselves about triggers & replication - https://phabricator.wikimedia.org/T132527#2250200 (DStrine) [22:46:02] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Continuous-Integration-Config, and 2 others: Run PHPUnit on PHP-Queue repo - https://phabricator.wikimedia.org/T133574#2250201 (DStrine) [22:46:04] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog: Frig should handle composer stuff - https://phabricator.wikimedia.org/T133402#2250202 (DStrine) [22:46:06] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay, and 2 others: AstroPay should be the preferred payment method for supported countries - https://phabricator.wikimedia.org/T133181#2250203 (DStrine) [22:46:09] Fundraising Sprint Hermit Crab Husbandry, Fundraising-Backlog, Easy, FR-Astropay, and 2 others: Astropay errors should be red text and not popup - https://phabricator.wikimedia.org/T107363#2250205 (DStrine) [22:46:10] the dumb thing i did was actually yesterday. i didn't actually merge master in before deploying :P [22:46:59] it was a complicated frig failure and i tried to clean up manually and instead didn't do anything [22:47:15] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2250206 (DStrine) [22:47:18] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Smashpig, and 2 others: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2250207 (DStrine) [22:47:20] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Enhance mustache state/province dropdown - https://phabricator.wikimedia.org/T133253#2250208 (DStrine) [22:47:23] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Patch-For-Review: Style fields more cleanly for when donor enters form without currency or amount - https://phabricator.wikimedia.org/T113306#2250209 (DStrine) [22:47:25] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#2250210 (DStrine) [22:47:31] (PS1) Cdentinger: update wikimedia/smash-pig to bc16fd9c319c8ca7e8795883f1e45ba51c0bd9e5 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286086 [22:50:58] XenoRyet: do you have a sec to look at https://gerrit.wikimedia.org/r/284623 and the two it depends on? [22:54:53] (PS1) Cdentinger: Update smash pig, worldpay audit test cancel [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/286089 [22:54:59] (PS1) Cdentinger: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/286090 [22:56:15] I'm going to leave early and beat the bart insanity. I'm mostly writing reviews today. I'll be scanning email and chat. [23:09:45] (PS5) Cdentinger: Allow single-parameter WmfFramework::messageExists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [23:12:25] (CR) Cdentinger: [C: 2] Allow single-parameter WmfFramework::messageExists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [23:12:53] thanks cwd ! [23:12:54] ls [23:12:58] derp [23:13:07] :) [23:18:14] ejegg: would you mind just looking over those merges for smashpig? the deploy i did yesterday was useless, i updated vendor but didn't use the changes [23:18:29] cwd: sure thing! [23:18:34] i took the reins from frig half way through and i guess i got confused [23:18:49] i'm happy to self merge em i'd just love a second set of eyes [23:19:57] Updating vendor just for a unit test? [23:20:02] oh, you're testing frig [23:20:13] yeah [23:20:15] (Merged) jenkins-bot: Allow single-parameter WmfFramework::messageExists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284621 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [23:20:36] but also the vendor update yesterday didn't get the corresponding code in crm [23:20:46] that merge should take care of it [23:20:49] (CR) Ejegg: [C: 2 V: 2] "looks like it worked!" [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/286089 (owner: Cdentinger) [23:21:55] (CR) Ejegg: [C: 2] update wikimedia/smash-pig to bc16fd9c319c8ca7e8795883f1e45ba51c0bd9e5 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286086 (owner: Cdentinger) [23:21:59] (PS3) Cdentinger: Localize subdivisions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284622 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [23:23:24] ejegg: also i have no clue why that civicrm update appeared twice [23:23:36] i stared at it for awhile with adam but can't explain it [23:23:41] it appears to be no-op [23:23:52] hmm, i didn't notice [23:24:19] (Merged) jenkins-bot: update wikimedia/smash-pig to bc16fd9c319c8ca7e8795883f1e45ba51c0bd9e5 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286086 (owner: Cdentinger) [23:25:30] it landed twice on deployment, i think it was because of a cherry pick that made one commit land out of order [23:25:48] cwd ohh, that would make sense [23:26:24] or... maybe eileen applied the submodule update directly in deployment? [23:26:41] there's no merge after it in the history [23:27:19] nah, same timestamp as master commit [23:27:33] guess it must be the order [23:27:34] and both deployment commits [23:27:37] baffling [23:27:51] ehh, I'm not too worried [23:27:53] ls [23:27:58] argh [23:28:00] hehe [23:31:00] (CR) Ejegg: [C: 2 V: 2] "Merge looks good! Thanks for automating some drudgery." [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/286090 (owner: Cdentinger) [23:32:48] thanks! i'll deploy that after this meeting [23:34:59] (CR) Cdentinger: [C: 2] Localize subdivisions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284622 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [23:45:57] (Merged) jenkins-bot: Localize subdivisions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284622 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [23:51:38] (PS4) Cdentinger: Persist state/province selection, localize prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284623 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [23:57:37] argh i forgot to add new files when committing vendor [23:58:01] also i guess smashpig doesn't run its tests in CI [23:58:21] wait, what did you forget? [23:58:42] https://gerrit.wikimedia.org/r/#/c/286089/ [23:58:46] cancel.txt in there [23:59:02] oh right... [23:59:08] dang, sorry I missed that! [23:59:12] err, it's in smash pig it just didn't make it into vendor because frig didnt' do git add . [23:59:16] not your fault! [23:59:25] i'm not sure if git add . is a thing it should do... [23:59:36] well actually i guess it probably can in that context [23:59:50] it checks out deployment and blows the directory away and submodule init