[00:00:06] yeah, just the specific subdir in vendor should be fine [00:00:14] then runs composer install so any new files that land there can probably safely be added [00:01:24] right on [00:05:51] (PS1) Cdentinger: forgot this file, frig needs to git add . [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/286103 [00:06:23] (PS1) Cdentinger: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/286104 [00:08:19] Fundraising-Backlog: Frig should manage new files somehow - https://phabricator.wikimedia.org/T133963#2250354 (cwdent) [00:08:58] (CR) Cdentinger: [C: 2] forgot this file, frig needs to git add . [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/286103 (owner: Cdentinger) [00:09:46] (CR) Cdentinger: [C: 2] update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/286104 (owner: Cdentinger) [00:11:02] (Merged) jenkins-bot: forgot this file, frig needs to git add . [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/286103 (owner: Cdentinger) [00:11:04] (Merged) jenkins-bot: update vendor submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/286104 (owner: Cdentinger) [00:11:06] ejegg: i was hoping to have deployed this awhile ago, i have to leave in under an hour but would like to get this out so it doesn't sit all night. do you have a preference? [00:12:04] i have to run a quick errand, but i can babysit the deploy after that (like 20 min) [00:13:08] ok i'm gonna push it up, i'll be here for awhile yet [00:13:12] if anything blows up i'll roll back [00:15:15] from 777a91b8f9f6003a3eebdb8f2c73e45cc2bfb4a4 to b386a6821c71310950ccdcdcf2616add727e1af4!log updated civicrm [00:15:23] haha [00:15:33] !log updated civicrm from 777a91b8f9f6003a3eebdb8f2c73e45cc2bfb4a4 to b386a6821c71310950ccdcdcf2616add727e1af4 [00:15:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:15:43] yoda paste [00:20:46] (PS15) Awight: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [00:20:48] (PS8) Awight: Simplify configuration and read from YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) [00:24:31] (PS16) Awight: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [00:24:32] (PS9) Awight: Simplify configuration and read from YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) [00:26:13] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2250377 (cwdent) I just updated the parser an... [00:34:16] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2250390 (awight) a:awight>None [00:35:31] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 5 others: [Epic] Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2250398 (awight) [00:38:26] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Implement AtomicReadBuffer for choice of PHP-Queue backend - https://phabricator.wikimedia.org/T133964#2250409 (awight) [00:38:43] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 3 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2250427 (awight) [00:38:45] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Implement AtomicReadBuffer for choice of PHP-Queue backend - https://phabricator.wikimedia.org/T133964#2250426 (awight) [00:43:12] ejegg: deploy seems fine, and it worked this time. still didn't find all the missing refunds but i think it's just a matter of moving basically everything back to incoming and running again [00:44:35] great! [00:46:25] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2250436 (awight) [00:46:45] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2250453 (awight) [00:47:12] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2250436 (awight) [00:48:06] okay, well i'm gonna head out but i'll have my phone in case whatever [00:48:09] see ya! [00:54:07] cwd|afk: chow--sorry to have missed you! [01:04:10] (PS17) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [01:06:02] (CR) Awight: "@ejegg Thanks for the reviews, I dwelled a bit longer over the details in PS 17 and made the fixes you suggested." (1 comment) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [01:33:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Use PHP namespaces in DonationInterface code - https://phabricator.wikimedia.org/T133969#2250521 (awight) [01:49:51] (PS1) Ejegg: WIP: Client-side fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286110 [01:51:41] (PS2) Ejegg: WIP: Client-side fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286110 [01:57:30] (PS2) Ejegg: WIP Use consistent field labels in error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286011 (https://phabricator.wikimedia.org/T133706) [01:57:32] (PS1) Ejegg: Let mw.msg do the string replacements for us [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286113 [02:05:49] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write adapter or payment method - https://phabricator.wikimedia.org/T131811#2250561 (awight) [02:05:56] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write adapter or payment method - https://phabricator.wikimedia.org/T131811#2179202 (awight) a:awight [02:06:15] (CR) Ejegg: [C: 1] "Awesome! Just one optional stylistic thing." (2 comments) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [02:27:30] (CR) Awight: New interface for atomic reads (1 comment) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [02:28:03] ejegg|away: Note that I swapped the patches around just to confuse everyone :) [02:29:07] (PS18) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [02:29:31] err, never mind different repo. [02:29:58] (PS1) Awight: [WIP] Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [02:30:00] (PS1) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [02:30:59] ejegg|away: I started soul searching about how to separate the sub-integrations, but looking at paypal_legacy.adapter.php, there's really nothing left in common. Which is great! [02:31:09] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [02:31:19] (CR) jenkins-bot: [V: -1] [WIP] Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [02:31:20] The only question, I think, is how to deal with the adapter short code and stuff. [04:00:53] Fundraising Sprint Internet Exploring, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: choiceData RL module hashes are flapping - https://phabricator.wikimedia.org/T133971#2250594 (AndyRussG) [04:01:53] (PS1) AndyRussG: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286119 (https://phabricator.wikimedia.org/T133765) [05:02:40] Fundraising Sprint Internet Exploring, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: choiceData RL module hashes are flapping - https://phabricator.wikimedia.org/T133971#2250622 (Catrope) I was able to verify that this is due to ordering. I sent repea... [05:08:46] (PS1) AndyRussG: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286126 (https://phabricator.wikimedia.org/T133765) [05:09:54] (Abandoned) AndyRussG: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286119 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [05:10:32] (CR) jenkins-bot: [V: -1] Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286126 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [05:25:16] (PS2) AndyRussG: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286126 (https://phabricator.wikimedia.org/T133765) [05:41:11] (CR) Catrope: [C: 1] Ensure consistent ordering of choiceData for RL module hashes (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286126 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [05:49:28] (PS3) AndyRussG: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286126 (https://phabricator.wikimedia.org/T133765) [05:51:10] (CR) Catrope: [C: 2] Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286126 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [05:52:20] (CR) Raimond Spekking: "@Ejegg: "or will the magical translation process sync them up again?" -> Yes, with the next run next night." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286064 (owner: Raimond Spekking) [05:53:01] (Merged) jenkins-bot: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286126 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [15:50:27] `/nick cwd [16:05:38] cwd: I'm coming to think that my ideal patch is either all positive, almost all negative, or an even measure of both. [16:06:03] hehe, do you mean SLOC? [16:08:44] yes just SLOC, I haven't come to a verdict on whether a positive or negative emotional content to a patch is a good thing or not :0 [16:09:28] is what you're saying, the best approach will be to reuse very little of the current infrastructure? [16:13:49] (PS19) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [16:13:55] ^ comment creep [16:15:14] cwd: That sounds nice too, but I guess how I feel about any infrastructure is that our integration should be done in a minimum number of lines, with some orthogonal supporting classes being either added or removed [16:15:38] ...which can be many lines, it's just the integration that should be minimal [16:16:19] as in, don't make it disrupt the current work flow? [16:19:37] cool. yeah that works for me [16:19:48] unless we're removing the current work flow ;) [16:19:48] i would agree with that, we can iterate towards the "best thing" [16:19:56] yeah that too [16:20:11] but minimally invasive surgery is best if it is workable [16:20:45] I also like AndyRussG's technique of building the future core library in the wings, attempting to do that myself with the paypal_ec adapter [16:21:49] I'll make classes which could be moved to into a payment provider directory in SmashPig, and paypal_express.adapter.php is just a gluey skeleton. [16:21:51] boo! and thx, interesting hadn't thought of it like that... [16:22:22] awight: cwd: XenoRyet|lunch: dstrine: didja see this 'un? https://phabricator.wikimedia.org/T133971 [16:22:23] AndyRussG: hehe well I thought you had said so, if a bit more eloquently [16:22:53] Wow, it's really a ResourceLoader blizzard! [16:23:06] maybe it was the half of my brain that's asleep now [16:23:14] Yeah dunno if this stuff isrelated [16:27:34] AndyRussG: Next week is fine, I know you're busy, but at some point would love to hear your opinion of https://gerrit.wikimedia.org/r/#/c/284977/19/src/PHPQueue/Interfaces/AtomicReadBuffer.php [16:28:06] awight: sure! [16:28:19] I'm trying to write this data source interface to be both minimal and trivially compatible with Kafka [16:28:40] thanks! [16:28:44] Ah hmm k... np! [16:38:01] (CR) Ejegg: [C: -1] "That Exception you're trying to catch needs a namespace" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 (owner: Awight) [16:39:08] ejegg: hi! I'm thinking that the EC gateway has nothing in common with the legacy PayPal one... did a patch last night which puts them in parallel subdirectories. I'm going to switch main classes and config directories on account config, but haven't yet decided how to deal with sharing the gateway short name, or how the subdirectory routing takes place. [16:39:52] https://gerrit.wikimedia.org/r/#/c/286116/ [16:40:52] awight: yeah, gateway short name is tricky [16:41:49] (PS3) Awight: Check success in push and create table if necessary [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 [16:42:52] (CR) Awight: "ejegg: Thanks! I've made that mistake a few times in this code base, turns out it's dangerous to have class names (c.f. PDO) which mask c" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 (owner: Awight) [16:43:15] (PS20) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [16:43:50] awight: a whole new adapter? [16:43:53] ejegg: I really do want to reuse "paypal" for any integration [16:44:03] cwd: As it turns out, there is zero overlap between the two [16:44:26] Everything in there, config/ directory especially, is specific to paypal_legacy [16:44:40] i'd actually like to see how a brand new one could be structured with the new abstractions [16:44:46] and maybe some additional ones [16:44:48] so what are all the issues with sharing a short name? [16:45:10] Will we have transaction ID collision? [16:45:24] ooh no, but that's a thing we should avoid on principle [16:45:43] HAHA I just caught one of my chickens tending a contraband nest [16:45:45] I guess we do need to note which integration was used for each txn [16:45:50] cute. [16:45:51] awight: another one? [16:45:53] yah! [16:46:13] oh heh I have a good short anectode for standup, will save it [16:46:21] not chicken-implicated [16:46:24] heh [16:46:50] That's awesome, the nest is among some dinosaur-egg formed river rocks [16:47:04] She's trying to hide it in broad daylight [16:48:11] that's awesome [16:48:16] cwd: Hell yeh. I'm going to try to lever some experimental improvements out of this paypal_ec fire drill for sure. [16:48:54] I want a PayPalExpressNvpApi class to wrap basically everything about the integration [16:48:56] (PS4) Ejegg: Check success in push and create table if necessary [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 (owner: Awight) [16:49:46] (CR) Ejegg: [C: 2] Check success in push and create table if necessary [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 (owner: Awight) [16:50:11] ejegg: cwd: if anyone wants to grab a queue thing with my name on it, please do with no hesitation. [16:50:27] (CR) Ejegg: "oh, that 'XXX' comment can probably go now" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 (owner: Awight) [16:50:28] It'll only take me a few minutes to upload everything I've discovered about any of those tasks [16:50:33] so we do need to distinguish new from old, for ease of refunds / reference / etc [16:50:49] (Merged) jenkins-bot: Check success in push and create table if necessary [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 (owner: Awight) [16:50:50] cool, I'll try to grab one today [16:51:12] (PS21) Ejegg: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [16:51:28] (CR) Awight: "deja vu. I swear I've made these edits, and lost on a branch somewhere in the bowels of git." [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/285556 (owner: Awight) [16:51:41] ejegg: There are more interesting ones still unassigned, btw! [16:52:55] ejegg: for sure. Could all that live behind gateway_account? [16:53:48] oh yeah, that seems like exactly the place! [16:54:03] also, gateway_account should really be a component of the unique txn id [16:54:06] I'm not thrilled about maintaining trxn_id as a unique thing... [16:54:15] It's baroque as it is [16:54:37] There are already two primary IDs for each transaction, which is a pity [16:54:50] so yeah, a compound key is silly [16:54:56] I mean a concatenated one [16:55:15] I think eileen will agree that we might be able to remove that constraint in Civi core [16:55:56] we need some good solid definitions of what a txn is, anyway [16:56:22] Hmm. or maybe not, just thinking about how much code might rely on trxn_id to be a primary key [16:56:23] The Amazon payments system has some useful concepts [16:56:41] what those are? [16:56:52] let's see... [16:58:56] 'order reference' is the parent [16:59:36] (PS22) Awight: New interface for atomic reads [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/284977 (https://phabricator.wikimedia.org/T131271) [16:59:56] cool. That maps to our contribution_tracking_id [17:00:09] d'oh, I mean 'billing agreement' [17:00:24] But. :( I guess we have to maintain our own abstraction as a separate entity from theirs [17:00:26] that's the top-level one which corresponds to a single visit to our site [17:00:33] * awight stops mapping [17:00:49] https://images-na.ssl-images-amazon.com/images/G/01/EPSDocumentation/PayWithAmazon/AutoPayIntegrationGuide/img_APAGuide_PaymentObjectsNew_v2.png [17:01:00] oh nice, thanks [17:02:07] I think that's broken down far enough to cover all the integrations I've seen so far [17:02:08] This is causing vague reminiscence--weren't you suggesting at one point making this the conceptual hierarchy of record for our system as well? [17:02:22] yeah, it seemed like it could encapsulate everything [17:02:37] I haven't revisited it since 4.6 though [17:02:47] should see how it meshes with the new financial structure [17:03:30] Getting the CRM in on the deal does seem key [17:03:41] AndyRussG: sorry I'm in review-writing land :P I saw that task. If it's part of the crash work then please keep going. Thanks for the heads up. Also... as awight and I said... unbreak now stuff is part of the workday. Don't feel like you have to make up other work or something. The cookies are already stale ;) [17:04:43] ah right, the CRM financial stuff is more focused on internal accounting stuff like our own different accounts [17:04:47] ejegg: So, does a one-time payment have a billing agreement? [17:04:59] dstrine: k... ;) [17:05:10] lemme see... [17:05:35] eh not worth looking it up [17:05:52] awight: nah, it's in our code, easy enough [17:07:18] Looks like we go straight to the order reference on one-time payments [17:07:36] just a heads up. I'll be in review-writing land for parts of today. Apologies if my responses are delayed. [17:08:19] dstrine: Good thing I'm not in the office to distract you ;) [17:08:40] * awight prepares to distract anyway [17:08:58] there^^^ [17:09:12] * dstrine-afk walks away... [17:10:40] * awight ruefully surveys empty fundraising bullpen in mind's eye [17:11:40] yeah, so the new CRM structure works pretty well with this [17:13:47] contribution = order reference [17:14:09] capture and refund are financial_trxn [17:14:24] billing agreement is contribution_recur [17:14:57] I think authorizations only need to be tracked in the short term [17:15:11] till we confirm capture of the funds [17:15:19] then we want to use the capture ID for refunds [17:15:47] right, and we don't want to record anything in Civi that's not cpatured [17:16:37] ooh, that spurious generic error message in the fiscal_number slot isn't coming from one of my WIP patches [17:17:11] afraid it might be from that validation encapsulating patch that I hassled people into merging [17:19:00] sorry--"RL" phone jacked [17:19:48] no worries, just filling pixels [17:19:53] PP EC has some time-based tokens which will be fun. [17:20:01] oho [17:20:12] what kind of expiration? [17:20:39] actually, so does amazon [17:20:45] So far, it seems to be between steps of a workflow, so we can get away with local variables, but I think recurring will take its own longer-term token [17:20:56] but their JS widgets have convenience functions to deal with expiry [17:21:21] the API is sort of impenetrable though. What we're using is simple enough, but it's got dozens of params we probably don't need yet [17:21:35] probably something we have to refresh on each recurring charge, huh? [17:21:42] so it's taking me a while to see which we'll use [17:22:01] I bet we do have to refresh. should know by today... [17:22:44] Hrm. Just had a dastardly thought about cntributin.trxn_id [17:23:40] ... We can always rely on the timestamp to ensure uniqueness, so theoretical collisions would only matter if we're querying that column for a txn_id [17:24:12] But we can make sure that all of our trxn grouping or queries use the wmf_contribution_extra.gateway_txn_id column. [17:24:28] *grimace* plus gateway and gateway_account [17:24:44] yeah [17:25:31] I guess we should know the gateway_account when we do anything with a txn_id [17:25:34] sigh [17:32:10] Omg, I just noticed that this clutch of eggs among river rocks is mostly not hers--they're the ducks'. [17:32:19] aww [17:33:11] ejegg: gotcha, you need to create some mysql dbs if you want to run the unit tests for those queue patches [17:33:19] otherwise the tests are skipped [17:33:38] ah, right [17:34:34] for php-queue/test/PHPQueue/Backend/PDOTest.php, it's grant all on phpqueuetest.* to your default user [17:35:34] for SmashPig/Tests/FifoDataStoreTest.php, grant all on test.* to test@localhost identified by '' [17:38:27] (PS17) Awight: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [17:44:45] (PS1) Jforrester: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/286183 (https://phabricator.wikimedia.org/T133765) [17:47:45] Fundraising-Backlog: Donation form error: Monthly selection is too sticky - https://phabricator.wikimedia.org/T133794#2251789 (Pcoombe) Okay, it appears that DonationInterface stores recurring in the session, so if a donor has previously attempted a recurring donation, and then gone back, then it might get s... [17:48:57] d'oh [18:13:19] hmm, should we distinguish between fields that we need to validate on the way in, and fields that we only need to validate after form submission? [18:14:28] so, amount should be validated immediately, but fiscal_number can be skipped till the form is submitted [18:15:51] ehh, nvm [18:18:46] hehe [18:30:23] (PS1) Ejegg: Fix spurious and non-specific fiscal number error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286196 [18:31:48] (PS3) Ejegg: Client-side fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286110 [18:31:50] (PS5) Ejegg: Persist state/province selection, localize prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284623 (https://phabricator.wikimedia.org/T133253) [18:32:49] Anyone for code review? https://gerrit.wikimedia.org/r/286196 needs to be merged to make master deployable. [18:33:36] Fundraising-Backlog, Security-Data-Mapping: FR Tech Data Map - https://phabricator.wikimedia.org/T133236#2251886 (SPong) [18:34:29] (CR) Awight: [C: 2] Fix spurious and non-specific fiscal number error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286196 (owner: Ejegg) [18:35:21] Fundraising-Backlog: Donation form error: Monthly selection is too sticky - https://phabricator.wikimedia.org/T133794#2251895 (MBeat33) Open>Resolved a:MBeat33 Thank you, @Pcoombe. I tested this in a couple of browsers and no longer get the error - huzzah! [18:35:55] (Merged) jenkins-bot: Fix spurious and non-specific fiscal number error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286196 (owner: Ejegg) [18:36:11] thanks! [18:39:43] I'm glad we're at least jiggling things to find an equilibrium [18:48:49] (PS2) Catrope: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/286183 (https://phabricator.wikimedia.org/T133765) (owner: Jforrester) [18:48:58] (CR) Catrope: [C: 2] Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/286183 (https://phabricator.wikimedia.org/T133765) (owner: Jforrester) [18:50:57] (Merged) jenkins-bot: Ensure consistent ordering of choiceData for RL module hashes [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/286183 (https://phabricator.wikimedia.org/T133765) (owner: Jforrester) [18:52:19] (PS2) Awight: [WIP] Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [18:52:20] (PS2) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [18:52:23] (PS1) Awight: DRY donation form title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286197 [18:52:24] (PS1) Awight: Get adapter class in a more adaptable way [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286198 [18:54:10] (CR) jenkins-bot: [V: -1] [WIP] Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [18:54:30] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, and 2 others: Write adapter for Express Checkout - https://phabricator.wikimedia.org/T131811#2251945 (awight) [18:54:36] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [19:04:32] (PS3) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [19:04:34] (PS3) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [19:04:50] Spammer. [19:10:07] argh, thought I had an awesome way to send generic validation rules to the client side (yeah, reinventing) [19:10:26] but the punctuation-stripping is killing me [19:11:05] dual server+client validation very much resembles The Ring [19:11:22] throw that thing down the first volvano you come to [19:11:32] aww [19:12:15] I mean, have fun while you're at it ;) but there's a thin line beyond which you will go crazy [19:12:29] i just want consistent error messages without reinventing ResourceLoader's message infrastructure to support country fallbacks... [19:12:55] * awight resists a sigh [19:13:25] * awight gives ejegg a stuffed comfort bear [19:13:59] * ejegg hugs bear [19:14:00] I empathize, brother. The special casing makes my eyeballs freeze over every time [19:14:49] well, if I make the regex more horrible I can probably achieve the same result... [19:15:08] I feel like we're just not approaching the country variations at the right level, in general [19:15:55] * awight the tingling of a solution at hand recedes into distance [19:17:02] Something like... the stuff we're doing per country should be abstracted to allow us to plug in any variation and have it mutate everything that happens [19:17:37] a transformer... [19:18:29] Friends, this was me > Verification code to reset PayPal password [19:18:46] Lmk if anyone out there actually possesses the developer.paypal.com credentials for fr-tech [19:18:51] otherwise I'll proceed with the reset [19:19:23] HAHA. [19:19:25] it was me. [19:19:29] I had the password already. [19:23:02] ejegg: awight: cwd|afk: XenoRyet: dstrine-afk: RL fix for CN from yesterday is about to be deployed by RoanK. [19:23:14] cool--looks like an elegant fix! [19:24:29] AndyRussG: cool! [19:24:50] dstrine: yeah should be fun [19:25:08] well it's all relative... [19:25:48] It's hard to look at PHP array functions and call "elegant" [19:26:12] spaghetti monster city is a cathedral next to them [19:26:43] * dstrine thinks of the great noodle in the sky [19:26:49] sorta work related ... everyone has to deal with unexpected maintenance : http://www.bbc.com/news/world-europe-36173247 [19:27:57] the small weasel accelerator... [19:28:21] There's a weasle in the codebase, I swear that's why it's not working [19:29:30] My mind instantly went to Pauly Shore movies. [19:33:54] Off topic in a less excellent way--I think the peer review nomination form is going to be annoyingly disabled later today--https://docs.google.com/a/wikimedia.org/forms/d/1kzglWQExdwLO8f_aBa9L2_Fzb5ndHG0C7x7XDTnpehY/viewform [20:03:43] ejegg: we can hear you [20:05:22] AndyRussG: meeting? [20:05:32] dstrine: yeah coming! [20:33:01] (PS1) Ejegg: WIP Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 [20:33:09] ejegg: nm, 1.8G not 18G of images [20:33:50] dstrine: actually that was a good question! this afternoon I was only expecting there to be three here (our two + a friend of Cecilia) but when I opened the door there were five! (Sofia also brought two friends impromptu) [20:34:02] * AndyRussG dreams of a co-working space [20:34:51] +2 kids, -1 adult [20:35:17] (CR) jenkins-bot: [V: -1] WIP Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [20:36:53] cwd stil a hefty amount of gifs! [20:37:17] cwd: the motherlode is behind a paywall? [20:38:10] casey needs a new pair of shoes [20:42:35] awight, ejegg -- would you guys like to talk about frig at some point? it's getting pretty usable but it would still be easy to let it fall by the wayside [20:42:55] sure! [20:43:03] yeah, I'd love a demo [20:43:15] That would be the right format for me as well ;) [20:43:28] is this afternoon good? i could do it whenever [20:44:29] Nowish would be great for me [20:44:35] yeah, same here [20:44:50] great! [20:45:02] i'll set up a meeting [20:47:44] just email u guise [20:52:40] ejegg: u want to join? [20:52:52] we are in here now...but there was a time zone thing [20:52:56] oh, will do! [20:52:58] i think it listed as mtn for something [20:52:59] ejegg: awight: Mariana also is here, so it's 2 adults vs. 5 kids, we're still outnumbered [20:53:11] AndyRussG: It's a scary feeling [20:53:27] indeed [20:54:18] well now 1 of the kids was fetched by her parent, and the 2 remaining older ones went to the park, but the 2 younger ones still here are kinda going bonkers [20:54:36] Of course it's not my kid's fault [20:54:45] Mariana is trying to calm them with cookie making [21:01:52] (PS2) Ejegg: Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 [21:10:18] (CR) Ejegg: "See generalized alternative here: https://gerrit.wikimedia.org/r/#/c/286214/" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286110 (owner: Ejegg) [21:12:10] (CR) Ejegg: "This is a generalized alternative to Ic5c30db7c2c2e2b38f7a9ce9fe - merge one or the other." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:16:28] (PS3) Ejegg: Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 [21:32:23] my friend's telling folks about the company he works for that just moved into this space, gonna check that out for a bit [21:34:24] ejegg|afk: http://ecolo.org/documents/documents_in_english/Rickover.pdf [21:42:16] ejegg|afk, awight - actually that was an expected and appropriate failure with a meaningful error message. the local commit was of course unavailable for install via composer [21:42:32] i just ignored the output because i assume that everything is bad [21:43:40] probably wouldn't be trying to deploy that before it got reviewed and merged normally [21:53:32] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2252485 (DStrine) [21:53:34] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Implement AtomicReadBuffer for choice of PHP-Queue backend - https://phabricator.wikimedia.org/T133964#2252486 (DStrine) [21:54:24] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: choiceData RL module hashes are flapping - https://phabricator.wikimedia.org/T133971#2252487 (DStrine) [21:54:38] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: choiceData RL module hashes are flapping - https://phabricator.wikimedia.org/T133971#2250594 (DStrine) [22:04:31] I got to do an errand before traffic gets hellacious, have a fun weekend! [22:06:04] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Use PHP namespaces in DonationInterface code - https://phabricator.wikimedia.org/T133969#2252499 (Danny_B) [22:18:17] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Tech Backlog, Fundraising-Backlog, and 4 others: Don't make donors guess minimum donation amount - https://phabricator.wikimedia.org/T105618#2252669 (Ejegg) [22:19:22] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Adyen job runner log prepending too many IDs - https://phabricator.wikimedia.org/T129946#2252689 (Ejegg) [22:19:47] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Adyen job runner log prepending too many IDs - https://phabricator.wikimedia.org/T129946#2120639 (Ejegg) a:Ejegg [22:54:36] Fundraising-Backlog: Frig should manage new files somehow - https://phabricator.wikimedia.org/T133963#2252791 (cwdent) Open>Resolved a:cwdent Actually there is only one case but it wasn't very obvious. The only time (so far) new or deleted files will be automatically committed is when composer i... [23:06:55] (PS1) Ejegg: Use TaggedLogger instead of static calls [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286254 (https://phabricator.wikimedia.org/T129946) [23:06:57] (PS1) Ejegg: Zap logger enterContext / leaveContext / renameContext [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286255 (https://phabricator.wikimedia.org/T129946) [23:08:04] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Patch-For-Review: Adyen job runner log prepending too many IDs - https://phabricator.wikimedia.org/T129946#2252866 (Ejegg) [23:27:00] I'm going to head out. Have a good weekend [23:56:05] ejegg: i added a help message here that explains the lay of the land: https://github.com/caseydentinger/frig/blob/master/frig.py [23:56:52] it might be easier to spot TODOs in the summary than staring at the code [23:57:22] cause it's based on my workflow and i think we all do subtly different things [23:57:38] i bet [23:58:20] i'm still flipping my mediawiki extensions and extensions.deploy dirs between dev and deploy [23:59:24] I'll take a glance now and look harder at it Monday morning