[00:00:40] now I'm in that limbo. In theory there is not much I can do for 90 mins - but it feels like if I don't check what table we are up to every 5 minutes it will all fall aprt [00:01:06] haha [00:01:22] (contribution table BTW) [00:01:24] eileen: clearly you need to spend the next 90 minutes perfecting a poller to monitor progress and alert you [00:01:33] That is a dilemma--the stress of not knowing, or of not blinking [00:01:47] ha [00:01:51] export to etherpad... [00:02:23] question: is there some way to configure jenkins ~not~ to run all the jobs at once after a blackout? [00:02:30] darn it [00:02:56] the big tables take 5 -15 mins each - so it progresses just fast enough to keep some level of interest [00:03:11] (PS4) Ejegg: CRM-18193 add default log_conn values for when interacting with mysql outside of CiviCRM. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [00:03:12] I'm pessimistic that any useful thing was designed into Jenkins [00:03:50] perhaps a flight simulator is jammed in there somewhere, or pong [00:04:00] eileen: Dastardly! civi migrate progress tomagotchi frontend [00:04:52] (PS5) Ejegg: CRM-18193 default log_conn values for interacting with mysql outside of CiviCRM. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [00:08:25] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [00:09:07] (PS1) Eileen: Remove wmf EntityTag.getdetails api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286548 (https://phabricator.wikimedia.org/T133806) [00:09:21] up to email... [00:10:52] (Merged) jenkins-bot: CRM-18193 default log_conn values for interacting with mysql outside of CiviCRM. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285263 (owner: Eileen) [00:18:48] So how do I see where the data for this is coming from civicrm/contact/view/contribution?reset=1&id=16827686&cid=15220095&action=view&context=contribution&selectedChild=contribute - I'm interested to see where we are getting incorrect post code info from [00:19:40] eileen: check the Source* fields, you mean? [00:19:53] They should be in a custom table on that screen [00:20:08] yeah - but the original data - is it in queue2civicrm_log [00:20:18] hmm? [00:20:34] We don't use that much, although you could [00:20:56] Usually, I would figure out the source using the custom fields, then search for IDs in the appropriate log [00:21:16] yeah but what I mean is we have put their address in the postal_code [00:21:24] is that because paypal sent it to us like that [00:21:33] or is it mis-mapped [00:23:58] if the former then I think that is a possible case to say the core postal_code field should be longer - but so far I have only found invalid data to support our extension of that field length [00:24:17] (PS1) Ejegg: Truncate lock names for MySQL 5.7 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286549 [00:25:05] (PS1) Ejegg: Fix PHP version check to stop 7.0 breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 [00:25:40] oh, interesting. [00:26:29] eileen: curses! The legacy IPN listener doesn't do enough logging for us to get anything useful from there, actually. [00:26:46] (CR) Eileen: "This is the patch set we wound up merging to 4.6 for that ... https://github.com/civicrm/civicrm-core/pull/7984" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286549 (owner: Ejegg) [00:26:48] But if you want I could dig through the audit files to at least see if paypal has the info wrong [00:27:12] awight: ok - where are they? I guess I can look for that info on collab [00:27:31] no hang on I found it in the table I mentioned [00:28:24] select * from queue2civicrm_log WHERE cid = 24323442; [00:28:38] eileen: TRR-20160407.01.008.CSV: fwiw [00:28:40] seems to indicate paypal collected it wrong & passed it back wrong [00:28:47] oh huh! [00:29:31] The zip code looks right to me, from the audit data [00:29:55] (CR) Ejegg: "Ooh, that one comes with informative comments too!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286549 (owner: Ejegg) [00:36:41] (PS1) Ejegg: CRM-17846 - Fixing lock name to be less than 64 characters for MySQL 5.7 compatibility (#7984) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286551 [00:37:35] (Abandoned) Ejegg: Truncate lock names for MySQL 5.7 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286549 (owner: Ejegg) [00:38:39] (PS2) Ejegg: Fix PHP version check to stop 7.0 breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 [00:42:31] (CR) Eileen: "If we are going to solve this differently than the patch that has gone into core we should upstream our version ..." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 (owner: Ejegg) [00:43:25] (CR) Eileen: "NB - I think your patch is more correct - it's just a question of whether it crosses the 'care enough' threshhold" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 (owner: Ejegg) [00:48:18] (PS3) Ejegg: Fix PHP version check to stop 7.0 breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 [00:49:06] (CR) Eileen: [C: 2] "Fair call!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 (owner: Ejegg) [00:49:46] (CR) Ejegg: "Nope, definitely don't care about correctness in a copy of a lib from 2009! Changed this patch to match." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 (owner: Ejegg) [00:50:06] word! first ACK=success from PayPal EC [00:50:23] eileen: thanks for pointing me to the existing solutions! [00:50:30] :-) [00:50:49] (Merged) jenkins-bot: Fix PHP version check to stop 7.0 breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286550 (owner: Ejegg) [00:50:59] that lock one was pretty hard to make sense of! [00:51:13] i realized i didn't want to try to keep my local fixes outside of the gitstream [00:51:37] yeah - I did actually prepare a version of our code over the latest 4.6 yesterday [00:51:50] but, I'm loath to push it out at the same time as the other big change [00:51:59] so, have not put it up [00:52:16] sounds prudent [00:52:20] :-) [00:52:57] there were a few conflicts - so there was some risk & it might have given the logging change a bad name if we concurrently broke something [00:53:26] heh, gotta be PR-savvy with these big deploys [00:53:44] yeah [00:54:09] hehe [00:57:03] Fundraising-Backlog, fundraising-tech-ops: Document paymentswiki config VCS on collabwiki - https://phabricator.wikimedia.org/T134221#2258432 (awight) [00:58:14] (PS6) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [01:00:29] awight: wow, already getting txns through the new system? [01:02:49] Just the first API call, but it has a psychological impact at least [01:04:08] we are up to log_civicrm_line_item [01:05:19] Sounds like all the big ones are done! [01:06:30] yep should start to pick up pace now... [01:09:55] log_civicrm_subscription_history [01:11:02] (CR) Ejegg: "Huh, so PrevNextCache is like a big scratch table used for multiple kinds of session-y manipulations." (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285325 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [01:14:32] (CR) Eileen: Backport markConflicts code (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285325 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [01:18:30] eileen: I'm getting lured to the swingset for a minute, back in 10! [01:19:34] Jeff_Green: we are about a round of swingset from the end of the big process [01:20:19] ok [01:31:00] (PS1) Eileen: CRM-17984. Ensure input for subtype is valid; if not then do not use it to filter custom fields. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286557 [01:31:02] (PS1) Eileen: CRM-17984 test to demonstrate breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286558 [01:31:04] (PS1) Eileen: Fix the RC regrsision [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286559 [01:31:06] (PS1) Eileen: CRM-5507 CRM-17984 fix regression when subType var is not leaking [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286560 [01:31:08] (PS1) Eileen: Fix Strict warning discovered in testing [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286561 [01:31:10] (PS1) Eileen: CRM-17983, CRM-18401. Input validation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286562 [01:31:12] (PS1) Eileen: CRM-17983 fix for contactRelationships query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286563 [01:31:14] (PS1) Eileen: Minimal check to validate relationship params. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286564 [01:31:16] (PS1) Eileen: CRM-17983, CRM-18401. Input validation. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286565 [01:31:18] (PS1) Eileen: CRM-17983, CRM-18401 - Swap loose/strict escaping [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286566 [01:31:20] (PS1) Eileen: CRM-18469, CRM-17984 - getTree - No more pass by reference [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286567 [01:31:22] (PS1) Eileen: Further pass-by-ref fixes following on from customGroup signature change [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286568 [01:31:24] (PS1) Eileen: CRM-18469, CRM-17984 - getTree regression on multiple integers separated by the cnrtl char [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286569 [01:31:26] (PS1) Eileen: CRM-17983 Fix error in data type as found by Dave [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286570 [01:31:28] (PS1) Eileen: Bare minimum patch for 4.6 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286571 [01:31:30] (PS1) Eileen: Fixed 2 other issues. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286572 [01:31:32] (PS1) Eileen: Cleanup to have same behaviour as 4.7. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286573 [01:31:35] (PS1) Eileen: Typo fix. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286574 [01:31:36] Jeff_Green: have you completed 15 cos I think we are up to 16 [01:31:37] (PS1) Eileen: Further custom tree regression fix, where the label does not match the name the name is the key to use [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286575 [01:31:58] ha, ready [01:32:41] ok I haven't pull that mysql onto barium - do you want me to do that or are you happy grabbing it from wherever? [01:33:16] it's the exact same sql as lutetium? [01:33:37] yep [01:33:49] for now I can use that [01:34:56] cool [01:35:39] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286576 [01:37:07] back again [01:37:39] awight: Jeff is turning the triggers on… [01:38:21] (PS7) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [01:38:41] eileen: ready? [01:38:54] (CR) jenkins-bot: [V: -1] Fixed 2 other issues. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286572 (owner: Eileen) [01:39:15] Jeff_Green: yep! [01:39:32] done [01:39:47] ok... [01:39:48] 435 triggers created [01:40:15] time to merge my mum [01:40:47] d'oh, I have no perms to mess with /var/lib/jenkins [01:42:07] ok - that looks fine civicrm/report/instance/68?reset=1&log_conn_id=572801cfe9960&cid=1220574&oid=4961909&alteredName=Lesley%20McNaughton%20[Contact%20Merged]&alteredBy=emcnaughton@wikimedia.org&alteredById=11863262§ion=2 [01:42:38] awight: Jeff_Green we are up to step 18 [01:45:18] awight: I can probably bulk disable them if you want [01:47:45] hmm I've spotted something I don't like - but it's a UI thing - not a problem with our deploy [01:50:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe revert follow up - link to a merge that I did from my record is confusing - https://phabricator.wikimedia.org/T134224#2258506 (Eileenmcnaughton) [01:51:18] Ok Jeff_Green are we happy ? Are we turning things back on? [01:51:30] i'm waiting for you [01:51:38] i'm not worried about replication [01:51:46] Well I edited my name & reverted is so there is functionality! [01:51:56] I think we are good [01:52:14] I'd like to slow-start the first queue job... [01:52:48] Jeff_Green: It would be more fun if you could bulk disable, rather than the mad dash to disable all from the GUI as they're firing [01:54:08] awight done [01:55:02] wow! [01:55:18] * awight is at loss for words [01:55:24] so ah, Jenkins can be reenabled then [01:56:08] (CR) Eileen: [C: 2] "self-merging, submodule update" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286576 (owner: Eileen) [01:56:38] how about dedupe cron? [01:56:53] Actually... we can leave that off [01:57:10] It's the road not taken [01:57:14] ok [01:58:19] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/286578 [01:58:50] jinx is up [01:58:54] hehe [01:59:45] gah going back and forth between vi, etherpad, python, puppet, and perl is melting my brain [02:00:19] Hard to hold onto what is reality... [02:00:39] i'm worried that realitiy is going to end up being java or something [02:01:22] Put me back in the shadowy cave! [02:03:53] enabling the donations queue consumer with a limit of 5 records [02:08:13] I have an email to fr-all ready to send once we can say that everything really is back up [02:08:48] Consuming worked perfectly, and log table data even has correct extended latin characters [02:08:53] I'll turn all jobs on [02:09:59] (CR) Eileen: [C: 2] "Self-approving as this is a merge to deployment" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/286578 (owner: Eileen) [02:11:58] Jeff_Green: looks like some db perms might have changed? [02:12:10] oh? [02:12:22] the fr_stats user is unable to connect to ... something [02:12:41] oh this is trying to hit fundraising-read db [02:12:58] Maybe replication is still down and those are disabled? [02:13:08] Disabling that job for now. [02:13:24] !log Updating civicrm from f5e8f98d07a2280118b7153bc342bf52ee67edd5 to d32032965f2a45d24f1eaeb352eb6bfd6641753c [02:13:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:13:36] (that deploy was just tidy up) [02:13:52] awight the db could still be chewing on the long queries, but I don't see how that would look like an auth failure [02:14:43] Jeff_Green: nvm me. I completely misread the log [02:14:50] ok [02:14:56] There's no logging for what actually broke. [02:16:14] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 2 others: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2258615 (Eileenmcnaughton) [02:17:33] Fundraising-Backlog: Fundraiser statistics export job is failing - https://phabricator.wikimedia.org/T134229#2258616 (awight) [02:19:54] eileen: Jeff_Green: Jenkins jobs look good. Paymentswiki needs to be reenabled, then I can turn campaigns on [02:20:02] awight: ok [02:20:08] cool [02:23:06] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Verify that the contact modified date trigger is installed - https://phabricator.wikimedia.org/T118346#2258628 (Eileenmcnaughton) [02:23:42] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Verify that the contact modified date trigger is installed - https://phabricator.wikimedia.org/T118346#1797852 (Eileenmcnaughton) I verified this by editing a contact & checking the m... [02:24:01] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn logging on on live - https://phabricator.wikimedia.org/T132056#2258631 (Eileenmcnaughton) [02:24:07] Fundraising Sprint Internet Exploring, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Revisit triggers. We probably want them. - https://phabricator.wikimedia.org/T117055#2258632 (Eileenmcnaughton) [02:24:10] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Question & Possible Task: Is there a more detailed change log than the one on the contact summary page? - https://phabricator.wikimedia.org/T88447#2258633 (Eileenmcnaughton) [02:24:14] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Update trigger mysql in git to reflect latest change from upstream (connection_id) - https://phabricator.wikimedia.org/T133745#2258634 (Eileenm... [02:24:28] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 2 others: create protocols and documentation for various civicrm database backup/restore/failover ... - https://phabricator.wikimedia.org/T133617#2258636 [02:25:50] ok paymentswiki is back [02:26:17] !log CentralNotice fundraising campaigns reenabled after CiviCRM maintenance [02:26:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:26:46] So I should fire my email now I believe.... [02:26:59] totes. [02:27:02] Hi fives! [02:28:06] OK so 21 can be crossed off [02:28:31] & then we just have 24 left ? [02:28:51] Jeff_Green: is replication back to normal? [02:29:04] checking [02:29:32] ah--I can probably see that in ganglia huh [02:29:55] it looks like db1008 caught up around 1:45 [02:33:47] I guess I'll just sit back and watch for thunderclouds... [02:38:06] ok Jeff_Green , awight - so where are we at? standing down? still checking things? does anyone have any updates to the wiki page for next time? [02:38:37] I'm content [02:38:55] only think still hanging afaik is civi deduper [02:39:00] Was gonna procrastinate adding to the wiki, but it does seem like the right time is now [02:39:01] oh deprecated [02:39:03] nm [02:39:17] yeah ….. [02:39:43] it might be good just to throw the contentent of that etherpad in a linked wiki page for posterity? [02:40:08] on the wiki? or on the phab? [02:40:46] I was thinking wiki because phab search is terrible and we can never find anything there [02:41:06] :-) [02:47:15] ok Jeff_Green I added that [02:47:28] thanks [02:47:39] marisa [02:49:57] how long should we wait before reenabling replication to fdb2001? [02:50:54] oveja [02:51:16] [that is Mari doing spelling] [02:51:22] :-) [02:51:46] what do we gain by waiting? A chance to see if there is any awful corruption? [02:51:57] eileen: right [02:52:24] hmm - well are we talking 'maybe leave it for days' [02:52:34] we can if we want [02:52:38] or, until after next backup [02:52:46] or that [02:52:53] but we can just restore from backup, anyway... [02:52:59] or if we're really confident, we could do it now [02:53:00] The biggest risk is that new data stops coming in [02:53:12] the replica is just a convenient way to deploy the backup, right? [02:53:33] yes, and it's right at the moment where we start the outage [02:53:41] oh actually... [02:53:58] i'll just flip it on tomorrow once fdb2001 itself runs a backup [02:54:03] cool! [02:54:18] ok [05:20:39] Fundraising-Backlog: Fundraiser statistics export job is failing - https://phabricator.wikimedia.org/T134229#2258797 (awight) Open>Invalid Fixed itself... [05:22:48] (PS10) Awight: Simplify configuration and read from YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) [12:58:09] (PS2) Ejegg: Remove wmf EntityTag.getdetails api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286548 (https://phabricator.wikimedia.org/T133806) (owner: Eileen) [12:58:44] (PS3) Ejegg: Remove wmf EntityTag.getdetails api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286548 (https://phabricator.wikimedia.org/T133806) (owner: Eileen) [13:00:12] (CR) Ejegg: [C: 2] "Looks good. I see the single use removed in October (I0b5df043ef993)." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286548 (https://phabricator.wikimedia.org/T133806) (owner: Eileen) [13:02:01] (Merged) jenkins-bot: Remove wmf EntityTag.getdetails api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286548 (https://phabricator.wikimedia.org/T133806) (owner: Eileen) [14:27:42] (PS1) Ejegg: use Interface, not API [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286658 [14:37:29] (PS11) Ejegg: Simplify configuration and read from YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) (owner: Awight) [14:41:39] (CR) Ejegg: [C: 2] Simplify configuration and read from YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) (owner: Awight) [14:49:08] (Merged) jenkins-bot: Simplify configuration and read from YAML [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285317 (https://phabricator.wikimedia.org/T133601) (owner: Awight) [14:50:34] (PS2) Ejegg: DRY donation form title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286197 (owner: Awight) [14:55:59] (CR) Ejegg: [C: 2] "Thanks! Handy that you only have to remove it from en and qqq json files." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286197 (owner: Awight) [14:58:10] (CR) Ejegg: "Looking good. Did you want to update this for the new popAtomic backend method? I can take it over if you'd rather focus on express check" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [14:58:25] (Merged) jenkins-bot: DRY donation form title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286197 (owner: Awight) [15:39:43] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Smashpig, and 2 others: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2260400 (awight) [15:42:52] (CR) Awight: "@ejegg: I'm thinking, this is where we write dequeueLoop, and we don't implement pop() or commit()..." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [15:54:25] (CR) Ejegg: "Makes sense. I'm thinking dequeueLoop takes a callback and optional time & numeric limits." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [15:55:56] (CR) Awight: "Yes! And to answer your other question, if you think this is the fun part you should go ahead and take it over. If you're on to somethin" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [15:56:07] (PS18) Awight: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) [15:56:31] (CR) jenkins-bot: [V: -1] Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [16:10:18] (CR) Ejegg: "Looks good, but we should inspect our other merge hooks to see what needs to change (probably in another commit). There's a bit at the bot" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [16:10:59] (PS2) Ejegg: Use TaggedLogger instead of static calls [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286254 (https://phabricator.wikimedia.org/T129946) [16:14:28] (PS2) Ejegg: Zap logger enterContext / leaveContext / renameContext [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286255 (https://phabricator.wikimedia.org/T129946) [16:14:47] (CR) Ejegg: "PS2: manual rebase" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286255 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [16:16:29] (PS2) Ejegg: Adyen capture job refers to interface, not concrete class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286658 [17:03:26] dstrine: Our meeting disappeared w/o notification? [17:03:41] just making sure I'm crazy! [17:03:45] oh noes [17:03:59] I deleted it [17:04:02] dstrine: we have a meeting just now? [17:04:12] also, hi! [17:04:26] dstrine: ah hmm yeah I see it on one calendar but not on another... [17:04:27] haha, well here's the link https://plus.google.com/hangouts/_/wikimedia.org/quick-chat-on?authuser=0 [17:04:39] oh okay, we are having that then? [17:05:08] It seems like a good idea to me, still [17:05:19] I can.... dstrine? Or was there a rason for the deletion? [17:05:46] ejegg|afk: i have been looking at https://gerrit.wikimedia.org/r/#/c/284623/3 but how do i get a mustache form with states? [17:06:00] AndyRussG: no it was a mistake can you click on the hangout link above? [17:06:12] dstrine: ah ok one sec [17:06:47] (PS1) Ejegg: Little bit of post-yaml-patch cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286686 [17:07:17] cwd hmm, lemme see what I was using [17:07:49] (CR) jenkins-bot: [V: -1] Little bit of post-yaml-patch cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286686 (owner: Ejegg) [17:08:39] i only saw US, AU, and CA in the subdivisions [17:08:44] and thought those were all GC? [17:10:15] cwd oh right, adyen! [17:13:29] oh yeah! nice [17:23:10] (PS2) Ejegg: Little bit of post-yaml-patch cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286686 [17:28:15] Fundraising-Backlog: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2260911 (AndyRussG) [17:31:25] (CR) Awight: [C: 2] Little bit of post-yaml-patch cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286686 (owner: Ejegg) [17:33:21] (Merged) jenkins-bot: Little bit of post-yaml-patch cleanup [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286686 (owner: Ejegg) [17:36:50] Fundraising-Backlog: investigate any fr-tech work associated with hovercard test - https://phabricator.wikimedia.org/T133406#2260993 (DStrine) Open>Resolved [17:36:52] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-72-N: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2260994 (DStrine) [17:37:02] Fundraising-Backlog: investigate any fr-tech work associated with hovercard test - https://phabricator.wikimedia.org/T133406#2230881 (DStrine) created: T134286 [17:46:44] (PS7) Cdentinger: Persist state/province selection, localize prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284623 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [17:49:20] (CR) Cdentinger: [C: 2] "Looks good/Works good" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284623 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [17:50:44] (Merged) jenkins-bot: Persist state/province selection, localize prompt [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284623 (https://phabricator.wikimedia.org/T133253) (owner: Ejegg) [18:03:47] thanks cwd! [18:04:37] sure! checking out these client side validation approaches now [18:05:44] Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2261096 (Pcoombe) [18:06:20] Fundraising-Backlog: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2260911 (Pcoombe) [18:06:22] Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2261111 (Pcoombe) [18:06:40] Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2261096 (Pcoombe) [18:15:53] (PS8) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [18:15:55] (PS1) Awight: Defaults and comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286702 [18:15:57] (PS1) Awight: Support query_string response parsing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286703 [18:18:56] Muttering aloud... we really need to do something better when handling incoming result page redirects. [18:19:31] which breakage is currently annoying you? [18:19:32] Those are like a long request-response pair, where we do token checking to make sure the client hasn't done anything crazy [18:19:42] ejegg: hehe--trolled :) [18:20:25] I need to make additional API calls after return from redirect. I can only squeeze them into processReponse at the moment, which is terrible. [18:20:27] ...and make sure we confuse any donors that take too long to come back from the processor :( [18:20:35] Not a cool place to add controller code and tail recursion [18:20:45] seriously. [18:21:50] I'm still on board with the comment in handleResultRequest, that we should just check tokens and then run do_transaction in a way that parses the existing URL data rather than making another call [18:26:41] (PS1) Ejegg: Fix table creation in strict mode [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286707 [18:27:40] (CR) Awight: [C: 2] Fix table creation in strict mode [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286707 (owner: Ejegg) [18:28:02] thanks! [18:29:37] Hey ah, I can't find Logger::debug lines anywhere, do you have settings to surface those? [18:29:54] in DI? [18:29:56] I tried an rsyslogd.conf line to send all *.debug to /var/log/debug and no dice [18:29:59] yeah [18:30:09] I think it's wgDonationInterfaceDebugLog=true [18:30:15] HM ok thanks [18:31:08] hmm, not seeing that tho [18:31:15] Oh that totally worked. sheesh [18:31:59] jeez... it's never been in DonationInterface.php [18:32:14] but the old logging code + my rewrite took it as gospel [18:32:22] (Merged) jenkins-bot: Fix table creation in strict mode [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286707 (owner: Ejegg) [18:32:50] good find! I'll add that to the main file [18:33:01] thanks! [18:33:05] Seems kind of legacy now, I'll comment about it [18:35:19] (PS19) Ejegg: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [18:35:37] So that's just a version of your patch without commit() [18:35:59] Seems like a vanilla FifoDataStore could still be handy [18:36:29] For what? [18:36:38] pop() is hella sketchy [18:36:51] push, anyway [18:37:10] Agreed about that [18:37:27] but kind of feel we should hide the knives wrt. pop [18:37:30] The things that drop messages in queues don't need a StompDataStore or even a popAtomic-capable thing [18:37:55] You could split the interface up, maybe [18:38:29] exactly [18:38:51] AtomicReadBuffer and MagicalVanishingWriteBuffer [18:39:03] So, the pending consumer /only/ needs the AtomicReadBuffer [18:39:26] and will use PDO to insert into DB [18:40:01] facilitated by some sort of DequeueLooper [18:40:22] yah [18:40:37] Everything that's looking in the pending queue will replace those lookups with PDO [18:41:14] and the things that call StompDataStore::queueAddObj will call FifoDataStore::push [18:41:19] cool [18:41:57] oh dear--PP is returning a "token" param and it totally destroys our own token checking logic [18:42:05] oh man [18:42:27] why don't we just set a cookie for that? [18:42:59] ehh, not going to chase that rabbit right now [18:43:12] I'll find a way [18:43:25] It's already in the session, I think I'll just damage the parts that look in other places [18:43:56] err - it's in the session so we can compare it with the request, right? [18:44:26] good point ;) [18:49:07] (PS20) Ejegg: Integrate with PHP-Queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [18:49:33] added a warning comment on pop() ^^ [18:50:29] What's the use case for pop? [18:56:57] ehh, guess I just feel silly about the alternative data store name :) [19:03:03] oh hey, nice feature for testing PDO stuff: $pdo = new PDO('sqlite::memory:'); [19:04:04] woohoo! [19:04:18] I don't think sqlite is a default extension, though [19:04:29] ah well [19:04:56] oh hey it is [19:04:58] http://php.net/manual/en/sqlite3.installation.php [19:05:05] sweet! [19:05:36] definitely not gonna wrap PDO in anything for mockability then! [19:10:07] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2261348 (cwdent) @MBeat33: after patching up... [19:12:16] (PS9) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [19:13:34] (PS1) Awight: Document $wgDonationInterfaceDebugLog global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286711 [19:47:29] (PS10) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [19:47:32] (PS1) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [19:48:04] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [19:48:14] (CR) jenkins-bot: [V: -1] Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [19:52:35] (PS1) Ejegg: WIP QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 [19:59:27] Fundraising Sprint Internet Exploring, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect - https://phabricator.wikimedia.org/T134310#2261489 (AndyRussG) [19:59:46] Fundraising Sprint Internet Exploring, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect - https://phabricator.wikimedia.org/T134310#2261505 (AndyRussG) a:AndyRussG [20:01:23] Fundraising-Backlog: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2261511 (AndyRussG) a:AndyRussG [20:06:43] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2261527 (MBeat33) Thanks, @cwdent, this is lo... [20:06:56] Fundraising-Backlog: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2261533 (DStrine) [20:07:57] Fundraising-Backlog, fundraising-tech-ops: Document paymentswiki config VCS on collabwiki - https://phabricator.wikimedia.org/T134221#2258432 (awight) [20:08:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe revert follow up - link to a merge that I did from my record is confusing - https://phabricator.wikimedia.org/T134224#2258506 (DStrine) [20:09:55] Fundraising-Backlog, fundraising-tech-ops: Document paymentswiki config VCS on collabwiki - https://phabricator.wikimedia.org/T134221#2261546 (DStrine) [20:10:51] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: AstroPay: internal exception caused by currency - https://phabricator.wikimedia.org/T134214#2261547 (DStrine) [20:12:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2261553 (DStrine) [20:12:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2258250 (DStrine) a:Jgreen [20:12:51] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Enable Express Checkout on production account - https://phabricator.wikimedia.org/T134201#2261555 (DStrine) [20:13:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Write CiviCRM extension to view pending db records - https://phabricator.wikimedia.org/T134191#2261557 (DStrine) [20:13:30] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2261558 (cwdent) Thanks @MBeat33 - still wait... [20:13:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Write CiviCRM extension to view pending db records - https://phabricator.wikimedia.org/T134191#2257493 (DStrine) [20:14:41] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Regression: no longer validating gateway-specific required fields server side - https://phabricator.wikimedia.org/T134189#2261560 (DStrine) [20:14:46] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Regression: no longer validating gateway-specific required fields server side - https://phabricator.wikimedia.org/T134189#2257398 (DStrine) [20:15:57] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout controller - https://phabricator.wikimedia.org/T131808#2261564 (awight) Response handling for the gateway Result page is really bad... [20:17:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Use PHP namespaces in DonationInterface code - https://phabricator.wikimedia.org/T133969#2261580 (DStrine) [20:18:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make it impossible for people to send us their credit card number - https://phabricator.wikimedia.org/T133937#2261584 (DStrine) p:Triage>Normal [20:18:36] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make it impossible for people to send us their credit card number - https://phabricator.wikimedia.org/T133937#2249557 (DStrine) [20:18:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can't change donation from "refund" to "chargeback" - https://phabricator.wikimedia.org/T134312#2261589 (cwdent) [20:19:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make it impossible for people to send us their credit card number - https://phabricator.wikimedia.org/T133937#2249557 (DStrine) [20:20:20] Fundraising-Backlog, Security-Data-Mapping: Team writes draft data map - https://phabricator.wikimedia.org/T133810#2261603 (DStrine) [20:20:51] MBeat: i just made https://phabricator.wikimedia.org/T134312 -- with that in mind do you think it's ok to close the WP ticket? [20:22:19] Fundraising-Backlog, Security-Data-Mapping: FR Tech Data Map - https://phabricator.wikimedia.org/T133236#2225863 (DStrine) p:Triage>Normal [20:22:31] Fundraising-Backlog, Security-Data-Mapping: FR Tech Data Map - https://phabricator.wikimedia.org/T133236#2225863 (DStrine) [20:23:15] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Amazon, FR-Smashpig: Get Amazon SDK changes upstreamed - https://phabricator.wikimedia.org/T133795#2261621 (DStrine) [20:23:42] Fundraising-Backlog, FR-ActiveMQ: Upstream whatever we can to PHP-Queue - https://phabricator.wikimedia.org/T133754#2261623 (DStrine) [20:24:20] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2261628 (MBeat33) Cool. One thing that might... [20:26:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can't change donation from "refund" to "chargeback" - https://phabricator.wikimedia.org/T134312#2261632 (DStrine) [20:50:03] huh, booted from hangout and can't get back in [20:50:39] ah, looks like meeting's about over anyway [20:51:16] aww it just got good :p [20:52:00] ejegg: u got zen desk [20:52:02] ? [20:52:12] cwd yep [20:54:02] cwd: MBeat can get you an account btw [20:54:15] oh i got one [20:54:39] just soliciting ejegg's expertise [20:55:00] taking a look [20:55:22] thanks! [20:55:37] i gotta run home and check on the electrical progress, back shortly [21:31:12] (CR) Ejegg: "hmm, this has dwindled to just a mechanism to combine arrays of instantiation arguments." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [21:32:38] well, I guess it still is a way to keep the PHPQueue dependency in one place. But that feels like more layers of wrpper than we need [21:32:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: How do reversed chargebacks reconcile? - https://phabricator.wikimedia.org/T134317#2261793 (cwdent) [21:33:21] MBeat: made a task for your last comment ^ if you'd like to add any more details [21:33:24] (CR) Awight: [C: 1] "I would merge it. Awaiting crosscheck..." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [21:33:39] thx, cwd [21:33:45] MBeat: ok to close the first WP audit one? [21:33:54] totes [21:33:59] thanks! [21:34:07] thank you [21:34:09] a momentous occasion [21:34:30] r.i.p. [21:34:50] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2261805 (cwdent) [21:35:13] awight: I'm almost inclined to just put the PHPQueue class name and all the inst-args in the config [21:35:23] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2100102 (cwdent) Open>Resolved [21:37:09] SF people just got an email about a protest downtown through this afternoon. I'm going to catch bart before any silliness happens. I'll be back on shortly [21:47:08] ejegg: I like it! [21:47:18] and abandon that patch entirely... [21:47:29] i don't mean to denigrate the work that went into PS1-PS19! [21:47:34] haha [21:47:37] I enjoy it [21:47:40] valuable research... [21:48:22] (PS11) Awight: [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [21:48:30] plus a good amount of haphazard flailing [21:48:42] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [21:48:50] always fun! [21:54:41] (CR) Eileen: "Yes, I think I do need to evaluate those other patches further & make sure we have some unit tests I think." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [21:55:54] ejegg: so if it's not clear - all the patches from May 3 (after https://gerrit.wikimedia.org/r/286557 ) are from that new release patch-set & are related. I [21:56:58] yep, you had good breadcrumbs in the shared commit message! [21:57:30] time for my 6 pm relocation, back in a bit! [22:02:19] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2261979 (Eileenmcnaughton) Here is an interesting extension wh... [22:03:05] (PS12) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [22:03:25] (CR) jenkins-bot: [V: -1] Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [22:03:38] Just got an EC transaction through to completion, at least. [22:17:36] (PS2) Ejegg: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 [22:19:04] (CR) jenkins-bot: [V: -1] QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (owner: Ejegg) [22:19:15] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Failure to queue a message should prompt a dramatic attempt to rescue the data - https://phabricator.wikimedia.org/T134322#2261998 (awight) [22:21:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: How do reversed chargebacks reconcile? - https://phabricator.wikimedia.org/T134317#2262013 (MBeat33) p:Triage>Normal [22:27:05] (PS1) AndyRussG: Don't fail hard on dependencies error for ext.centralNotice.startUp [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286762 (https://phabricator.wikimedia.org/T134310) [22:27:18] Fundraising Sprint Internet Exploring, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect - https://phabricator.wikimedia.org/T134310#2262062 (AndyRussG) [22:35:24] hmm, a bit more work than I though to add sqlite support to PDO backend [22:36:13] too bad! [22:36:52] More that just the create table switch, I bet... [22:37:10] little bit, might almost have it [22:38:17] sqlite to build mock dbs during test? [22:39:46] Yeah--a much needed improvement to janky mysql stuff [22:40:03] It was janky, you had to at least create the database and give a user permissions. [22:46:55] yeah, seems like a cool idea [22:47:10] might not support every feature but the adapter can handle that [22:49:09] I've been into this creepy idea lately, that driver classes can be whatever they want, and they implement several tiny interfaces or not, depending on what we've written so far and the limitations of the backend. [22:49:18] Maybe it's an antipattern, I donno [22:57:59] i think i understand what you mean [22:59:10] (PS1) Awight: Helper function to unstage the keys of an array [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 [22:59:12] (PS1) Awight: PayPal EC gets donor details back using API call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286766 (https://phabricator.wikimedia.org/T131811) [22:59:41] (CR) jenkins-bot: [V: -1] Helper function to unstage the keys of an array [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 (owner: Awight) [22:59:53] (CR) jenkins-bot: [V: -1] PayPal EC gets donor details back using API call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286766 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [23:00:33] duck typing using interfaces--when I say it that way, :( [23:02:06] (PS2) Awight: Get adapter class in a more adaptable way [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286198 [23:02:08] (PS4) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [23:02:10] (PS13) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [23:02:12] (PS2) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [23:02:14] (PS2) Awight: Helper function to unstage the keys of an array [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 [23:02:16] (PS2) Awight: PayPal EC gets donor details back using API call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286766 (https://phabricator.wikimedia.org/T131811) [23:02:18] (PS2) Awight: Defaults and comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286702 [23:02:20] (PS2) Awight: Support query_string response parsing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286703 [23:03:39] yeah, i don't think there's anything wrong with that, it's all in the execution [23:03:46] the ugly stuff has to go somewhere [23:08:49] that would be kind of a good pun about duck typing, it's all in the execution [23:09:28] as in...run time type checking [23:09:39] https://sadbastard.org/images/tsch.gif [23:11:13] (PS2) AndyRussG: Don't fail hard on dependencies error for ext.centralNotice.startUp [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286762 (https://phabricator.wikimedia.org/T134310) [23:14:22] That's a funny gif... especially if you watch closely [23:16:03] XenoRyet: I know you still working on the formatting for Hebrew ... I was wondering if the other Adyen forms were done (ukraine, France, Japan) [23:17:54] dstrine: Technically no, but Ukraine and France will be next to no effort once I get the finishing touches on Israel. Japan is going to take more effort due to the language being unsupported. [23:18:35] XenoRyet: ok thanks just wondering [23:18:44] Yea, no worries. [23:24:49] (PS1) Ejegg: WIP SQLite support for PDO backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286773 [23:25:51] (CR) jenkins-bot: [V: -1] WIP SQLite support for PDO backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286773 (owner: Ejegg) [23:43:04] (PS2) Ejegg: SQLite support for PDO backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286773 [23:47:04] awight: finally cleared that WP task out so i have nothing assigned in this sprint. would you like to see me pick something queue related up, or paypal? [23:47:13] dstrine also [23:47:41] headed to estes of course so who knows what that will entail [23:48:09] cwd: congrats [23:49:32] :) [23:49:34] cwd: priorities for campaigns would be adyen and then paypal ... XenoRyet do you need any help prepping the intermediate stuff for an early test? [23:49:55] dstrine: Not as of the moment. I'll reach out if I run into anything. [23:50:12] Really just one last little thing I'm trying to get right. [23:50:33] cool I'mm just thinking of stuff.. [23:50:44] cwd: there is always stuff in the review column [23:51:43] cool, i'll jump in there [23:53:00] dstrine: Oh, I did just look at the ticket and it doesn't look like Amir responded yet. It would be good to get confirmation that the iframe does indeed read correctly. [23:53:32] XenoRyet: yeah I was about to follow up via email [23:53:42] Cool [23:54:36] cwd: Oh hey yeah review is going nova, thank you! [23:59:14] XenoRyet: sent!