[00:05:39] (PS1) Awight: Record final gateway_txn_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286777 (https://phabricator.wikimedia.org/T131811) [00:08:08] Done for the day, see you Thursday! [00:09:41] i'm taking off also, ttyl! [00:16:14] me too [00:24:46] (PS1) Awight: Amount is displayed correctly in PayPal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286778 (https://phabricator.wikimedia.org/T131811) [00:25:05] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, and 2 others: Write adapter for Express Checkout - https://phabricator.wikimedia.org/T131811#2262243 (awight) [00:26:16] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, and 2 others: Write adapter for Express Checkout - https://phabricator.wikimedia.org/T131811#2179202 (awight) This can complete a basic transaction. Feel free to object,... [01:55:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Sync our buildkit with upstream - https://phabricator.wikimedia.org/T126266#2262314 (Eileenmcnaughton) I got our wmf stuff merged https://github.com/civicrm/civicrm-buildkit/pull/248 I believe the only difference still to be reconciled is drush. We sw... [01:58:26] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2262316 (AndyRussG) Hi! Here's a separate task to make... [11:25:33] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2263403 (Amire80) Hi, The Hebrew text is correctly... [11:38:08] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2263432 (jrobell) Thank you for working on this tech... [15:14:16] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect - https://phabricator.wikimedia.org/T134310#2264240 (DSt... [15:15:24] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect - https://phabricator.wikimedia.org/T134310#2261489 (DSt... [15:16:07] Fundraising-Backlog: Fundraiser statistics export job is failing - https://phabricator.wikimedia.org/T134229#2264253 (DStrine) [15:16:10] Fundraising-Backlog: Frig should manage new files somehow - https://phabricator.wikimedia.org/T133963#2264255 (DStrine) [15:16:12] Fundraising-Backlog: Donation form error: Monthly selection is too sticky - https://phabricator.wikimedia.org/T133794#2264256 (DStrine) [15:16:14] Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Cron failure on payments1001 - https://phabricator.wikimedia.org/T133703#2264257 (DStrine) [16:30:04] psych. I am working today. [16:31:59] how come? [16:33:00] oh just a silly misunderstanding [16:33:25] Michelle needed some parent coverage, so I jumped on it being for the whole day--but, ahem... Mari has school on Wednesdays [16:33:28] :( [16:33:47] like pre school or what? [16:33:50] yah [16:33:53] it's pretty cool [16:33:54] neat [16:34:03] They jump on trampolines and speak only in Spanish [16:34:22] + take some pretty rugged field trips, on the subway and stuff [16:34:26] trampolín [16:34:30] :D [16:34:34] that's cool [16:34:48] It's hilariously all they really want to do at that age [16:35:17] i am up at the hotel in estes with tyler and a bunch of people i don't know [16:35:41] great! [16:35:52] also i bought that van on the way in [16:35:55] productive morning [16:35:58] Good bandwagon to jump on [16:36:13] rad, the beginning of the end [16:36:53] i hope not! [16:37:28] the end of the beginning [16:37:43] the catalyst in a transition from sedentary to nomadic living [16:38:02] https://www.youtube.com/watch?v=X_0hjyO6fFk [16:38:48] the realtor who helped me buy my house was my landlord for 5 years before that, and now he's going to manage renting my house when we leave [16:39:12] haha the original robber baron [16:39:34] Hope that part is uneventful [16:40:20] yeah me too [16:40:32] or at least only eventful for him [16:48:43] ;) sweet revenge [16:49:01] "and make sure to keep the sidewalk clean" [16:50:40] (CR) Ejegg: [C: 2] Get adapter class in a more adaptable way [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286198 (owner: Awight) [16:53:55] i have +2 on mw-vagrant [16:53:59] i don't feel qualified for that [16:54:05] (Merged) jenkins-bot: Get adapter class in a more adaptable way [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286198 (owner: Awight) [16:56:11] (PS2) Cdentinger: Guard against undefined variable and index errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283756 (owner: Ejegg) [16:59:37] cwd: then hold off until you do :p [17:00:18] too late! [17:00:24] https://gerrit.wikimedia.org/r/#/c/283691/ [17:00:26] was bold [17:00:43] perfect! [17:00:58] TODOs in gerrit should count double... [17:11:45] (CR) Ejegg: [C: 1] "Looks good, let's just add this to the docstring on GatewayType::getResponseType listing valid values." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286703 (owner: Awight) [17:17:37] (PS1) Awight: Comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286918 [17:22:25] (CR) Cdentinger: [C: 2] Guard against undefined variable and index errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283756 (owner: Ejegg) [17:24:25] (CR) Ejegg: "Thanks for the doc! Regarding the TODO though, I don't think Monolog has a built-in config file, just ways to set preferences in code lik" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286711 (owner: Awight) [17:26:45] (Merged) jenkins-bot: Guard against undefined variable and index errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283756 (owner: Ejegg) [17:30:54] (PS2) Cdentinger: Align amount and currency inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284596 (https://phabricator.wikimedia.org/T113306) (owner: Ejegg) [17:32:43] (PS5) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [17:32:45] (PS14) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [17:32:47] (PS3) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [17:32:49] (PS3) Awight: Helper function to unstage the keys of an array [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 [17:32:51] (PS3) Awight: Defaults and comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286702 [17:32:53] (PS3) Awight: Support query_string response parsing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286703 [17:33:52] cwd: Here's a tool I need--a script to abandon gerrit patches when you "fixup" in git rebase -i [17:34:04] (Abandoned) Awight: Comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286918 (owner: Awight) [17:34:22] (Abandoned) Awight: Amount is displayed correctly in PayPal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286778 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [17:34:24] (CR) Cdentinger: [C: 2] "This has been making me twitch forever." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284596 (https://phabricator.wikimedia.org/T113306) (owner: Ejegg) [17:34:37] (Abandoned) Awight: Record final gateway_txn_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286777 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [17:34:57] (Abandoned) Awight: PayPal EC gets donor details back using API call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286766 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [17:35:00] awight: like if you "squash" something that has a corresponding patch waiting? [17:35:02] any news for scrum of scrums awight XenoRyet|afk cwd AndyRussG|m ? [17:35:09] cwd: exactly [17:35:16] hmm interesting [17:35:24] ejegg|afk: i am at the reading offsite if anyone cares! [17:36:15] cool [17:40:06] awight: looks doable! [17:40:57] post-rewrite hook: [17:40:59] The hook receives a list of the rewritten commits on stdin, in the format [17:41:01] SP [ SP ] LF [17:43:34] cwd: shezamm! [17:43:46] (PS6) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [17:43:48] (PS15) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [17:43:50] (PS4) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [17:47:39] (Merged) jenkins-bot: Align amount and currency inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284596 (https://phabricator.wikimedia.org/T113306) (owner: Ejegg) [17:52:37] (PS4) Ejegg: Support query_string response parsing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286703 (owner: Awight) [17:52:53] (CR) Ejegg: [C: 2] "Awesome, thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286703 (owner: Awight) [17:54:30] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Patch-For-Review: Style fields more cleanly for when donor enters form without currency or amount - https://phabricator.wikimedia.org/T113306#2265016 (Ejegg) [18:01:09] (Merged) jenkins-bot: Support query_string response parsing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286703 (owner: Awight) [18:04:16] (CR) Ejegg: "Certainly a handy function! Two things: directly using config['var_map'] instead of $this->var_map -- we should be consistent here since " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 (owner: Awight) [18:06:55] (CR) Ejegg: [C: 2] Defaults and comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286702 (owner: Awight) [18:13:34] ejegg: Good catch--I hadn't thought about that, but yeah we have to migrate how we read and write to these duplicated variables all at once (at least per variable), not incrementally. [18:14:09] yah, more inertia factor [18:14:18] ugh or implement accessors. [18:14:21] -1 [18:16:32] (CR) Ejegg: [C: -1] "Distinguisable! Just needs one more wmf_ on the Mustache template." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [18:18:11] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2265116 (XenoRyet) Getting the proper RTL alignment... [18:21:09] (PS7) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [18:21:11] (PS16) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [18:21:13] (PS5) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [18:21:15] (PS4) Awight: Helper function to unstage the keys of an array [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 [18:21:17] (PS4) Awight: Defaults and comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286702 [18:23:03] zuul looks really unhappy about that [18:23:23] caught under the cascade [18:25:27] oh good--those shadow jobs didn't blossom into full ones [18:25:59] * awight keeps an eye on https://gerrit.wikimedia.org/r/#/c/286702/ [18:26:27] (CR) Ejegg: [C: 2] Defaults and comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286702 (owner: Awight) [18:26:54] that'll do it! [18:28:12] ejegg: This is naughty, but I'm open to the idea of deploying the PP EC gateway pretty much as is for an early internal test... [18:28:43] Just to find out sooner if we really really can accept JPY [18:29:01] They did swear up and down that legacy PP could... when it could not [18:29:17] (Merged) jenkins-bot: Defaults and comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286702 (owner: Awight) [18:29:48] (CR) Ejegg: [C: 2] "Nice! Could definitely use this in resultswitchers" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 (owner: Awight) [18:30:09] hehe, good guess [18:30:28] ejegg: I've also been thinking about splitting do_transaction in half. [18:31:04] I think the boundary should be at, waiting for a response from the remote API [18:31:13] or uh maybe not [18:31:21] maybe after receiving the data [18:31:52] hmm, isn't that 'processResponse'? [18:32:01] pretty much! [18:32:01] (Merged) jenkins-bot: Helper function to unstage the keys of an array [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 (owner: Awight) [18:32:58] There is a whole lotta do_transaction_internal that muddies the control flow, though [18:33:12] awight: we had the half-baked astropay and adyen adapters out before anyone was using them for real, don't see why new paypal should have to wait [18:33:50] I'd love to see the new structure! [18:36:53] There must be a best practice for this... [18:40:43] "Malformed gateway definition." that is a crazy exception to catch in do_transaction_internal. [18:47:01] * awight climbs out of rabbithole [18:47:23] One hell of a rabbit must live in there [18:49:57] (PS1) Ejegg: Restore check_not_empty [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286934 (https://phabricator.wikimedia.org/T134189) [18:51:30] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Helper for transaction response errors - https://phabricator.wikimedia.org/T134420#2265152 (awight) [18:52:55] let's deploy everything up to the token rename just to clear the runway. Mind evaluating this partial revert for inclusion? https://gerrit.wikimedia.org/r/286934 [18:55:51] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Extract processResponse call from do_transaction_internal - https://phabricator.wikimedia.org/T134421#2265166 (awight) [19:13:53] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Regression: no longer validating gateway-specific required fields server side - https://phabricator.wikimedia.org/T134189#2265238 (Ejegg) [19:15:51] ejegg: Do you have an example form that was affected? I'm not seeing anything immediately [19:16:35] let me see... [19:17:08] worldpay, maybe. [19:17:30] yep [19:18:24] (CR) Awight: [C: 2] "Confirmed that worldpay.api is validating name fields now." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286934 (https://phabricator.wikimedia.org/T134189) (owner: Ejegg) [19:18:49] aha, thanks! [19:19:40] Sure, a live test sounds appropriate [19:19:56] The token thing needs down time as I mentioned... [19:20:20] (Merged) jenkins-bot: Restore check_not_empty [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286934 (https://phabricator.wikimedia.org/T134189) (owner: Ejegg) [19:20:35] I suppose we can deprecate gently actually--cos PP EC is not active yet, so no gateways will be sending a "token". [19:20:38] Lemme do that [19:20:55] oh, yeah, soft transition would be nice! [19:21:10] well, I'll deploy the backlog now anyway [19:21:16] oh thank you! [19:24:42] (PS8) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [19:24:44] (PS17) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [19:24:46] (PS6) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [19:25:17] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/286945 [19:25:28] ejegg: fyi https://gerrit.wikimedia.org/r/#/c/286716/5..6/gateway_common/gateway.adapter.php,unified [19:29:11] (CR) Ejegg: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/286945 (owner: Ejegg) [19:30:46] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/286945 (owner: Ejegg) [19:33:21] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/286946 [19:33:38] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/286946 (owner: Ejegg) [19:34:01] (PS9) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [19:34:03] (PS18) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [19:34:05] (PS7) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [19:34:10] That's the one. [19:37:10] (PS1) XenoRyet: Adyen form for Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) [19:38:55] (CR) jenkins-bot: [V: -1] Adyen form for Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [19:39:10] (CR) Awight: QueueConsumer for AtomicReadBuffers (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (owner: Ejegg) [19:40:50] (CR) Awight: [C: 2] "no-op" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286658 (owner: Ejegg) [19:41:11] (PS3) Awight: Use TaggedLogger instead of static calls [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286254 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [19:42:47] (Merged) jenkins-bot: Adyen capture job refers to interface, not concrete class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286658 (owner: Ejegg) [19:43:22] (CR) Ejegg: QueueConsumer for AtomicReadBuffers (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (owner: Ejegg) [19:44:11] (CR) Awight: Adyen capture job refers to interface, not concrete class (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286658 (owner: Ejegg) [19:44:39] (PS4) Awight: Use TaggedLogger instead of static calls [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286254 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [19:45:22] (CR) Awight: [C: 2] "up with RIIA, down with RIAA!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286254 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [19:45:31] (PS3) Awight: Zap logger enterContext / leaveContext / renameContext [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286255 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [19:46:35] (Merged) jenkins-bot: Use TaggedLogger instead of static calls [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286254 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [19:47:59] (CR) Awight: [C: 2] "Reactor core contained!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286255 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [19:49:00] ejegg|brb: sorry to have fallen so far behind on code review! [19:49:22] (PS4) Awight: Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [19:49:39] (Merged) jenkins-bot: Zap logger enterContext / leaveContext / renameContext [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286255 (https://phabricator.wikimedia.org/T129946) (owner: Ejegg) [19:50:02] (PS2) Awight: Rename 'getStompMessageFields' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284761 (owner: Ejegg) [19:50:29] (CR) Awight: [C: 2] "gopher: stomped!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284761 (owner: Ejegg) [19:51:28] (PS9) Awight: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [19:52:57] (Merged) jenkins-bot: Rename 'getStompMessageFields' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/284761 (owner: Ejegg) [19:55:48] (PS2) AndyRussG: [WIP] Mixed storage for buckets [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) [19:58:56] (CR) Awight: [C: 1] "Not merging per ongoing discussion on the task." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [19:59:09] (PS10) Awight: [DO NOT MERGE] Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [20:00:28] (PS4) Awight: Client-side fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286110 (owner: Ejegg) [20:04:15] awight: very curious if you think either of those client side validation patches are the right way to go [20:05:01] ejegg: meeting? [20:05:52] ejegg: I was just gonna ask. Sure, lemme look [20:06:09] oh sure! [20:06:13] yeah, didn't see it in cal [20:14:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Tests, User-zeljkofilipin: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2265493 (DStrine) [20:33:52] (PS1) Ejegg: Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 [20:35:08] (CR) jenkins-bot: [V: -1] Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [20:35:23] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 2 others: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2265576 (DStrine) [20:35:39] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 2 others: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2263303 (DStrine) [20:36:09] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Regression: no longer validating gateway-specific required fields server side - https://phabricator.wikimedia.org/T134189#2265586 (Ejegg) [20:42:24] (PS10) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [20:42:26] (PS19) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [20:42:28] (PS8) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [20:42:30] (PS1) Awight: Remove soft transition for old "token" parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286996 [20:46:24] (PS1) Ejegg: PHPdoc fix [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286997 [20:49:59] (CR) Awight: [C: 2] "call me Ishmael" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286997 (owner: Ejegg) [20:51:02] (Merged) jenkins-bot: PHPdoc fix [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286997 (owner: Ejegg) [21:03:47] (CR) Awight: [C: -1] "I like where this is going, just have some concerns about consistency and staticness." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:04:43] (CR) Awight: [C: -1] "I like the other one much better, holding out for that solution." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286110 (owner: Ejegg) [21:06:03] (CR) Ejegg: "ah, true, static is unneeded!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:18:43] (PS5) Ejegg: Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 [21:20:08] (CR) Ejegg: "Thanks for the suggestions! Implemented in PS5" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:20:41] (CR) Awight: Generalized client-side validation (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:20:48] (Abandoned) Ejegg: Client-side fiscal number validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286110 (owner: Ejegg) [21:21:07] (PS6) Awight: Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:23:18] (Abandoned) Ejegg: WIP Use consistent field labels in error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286011 (https://phabricator.wikimedia.org/T133706) (owner: Ejegg) [21:24:15] (Abandoned) Ejegg: Let mw.msg do the string replacements for us [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286113 (owner: Ejegg) [21:26:40] (CR) Awight: [C: 2] "Great! It even works in translation." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:27:02] woohoo! [21:28:22] (Merged) jenkins-bot: Generalized client-side validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286214 (owner: Ejegg) [21:28:38] That'll be a nice one to have in the patch kit [21:29:10] heh, does make it harder to decide what to call these auxiliaries [21:29:29] I'd like to cut the "Helper" verbiage as well... [21:29:57] DonationDataRules ? [21:30:16] warmer... [21:30:24] ...ValidationRule, TransformationRule, etc? [21:30:38] DataLogic [21:30:58] * awight thumbs through vagary of vaguisms [21:32:04] I'd like to emphasize that there's something liminal about these rules, they're all about moving data from one place to another [21:35:09] 8-point spike: name things [21:35:36] hehe [21:37:10] !log updated payments-wiki from c502ab2f6b6ff914d67503a664d36076fdc32dcf to 8962b558b5eb5a4dba91be7ed7649b532fa4ee35 [21:37:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:39:18] so far so good [21:42:19] (PS11) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [21:42:21] (PS20) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [21:42:23] (PS2) Awight: Remove soft transition for old "token" parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286996 [21:42:25] (PS9) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [21:44:57] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Clean up confusing and repeated code in the PayPal express adapter - https://phabricator.wikimedia.org/T134445#2265825 (awight) [21:46:15] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2265841 (awight) [21:46:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2265871 (awight) [21:46:50] Fundraising-Backlog, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#2265870 (awight) [21:48:05] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2265878 (awight) ping: This one is ready... [21:48:24] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2265880 (awight) [21:48:27] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn logging on on live - https://phabricator.wikimedia.org/T132056#2265879 (awight) Open>Resolved [21:48:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2265881 (awight) [21:53:04] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Review actions taken for various Ingenico error codes - https://phabricator.wikimedia.org/T134449#2265901 (Ejegg) [21:53:17] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2265916 (awight) a:awight>None [21:53:38] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Implement AtomicReadBuffer for choice of PHP-Queue backend - https://phabricator.wikimedia.org/T133964#2265917 (awight) a:awight>None [21:53:47] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 3 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2265919 (awight) a:awight>None [21:54:41] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Write Express Checkout transactions and data transformations - https://phabricator.wikimedia.org/T131807#2265922 (awight) Open>Invalid Turned out t... [21:54:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2265924 (awight) [21:54:54] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic, FR-PayPal-ExpressCheckout, FR-Paypal: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2148322 (awight) [21:55:37] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Get Express Checkout test credentials - https://phabricator.wikimedia.org/T131805#2265933 (awight) [22:01:16] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Upgrade code to use credential-based authentication - https://phabricator.wikimedia.org/T134451#2265967 (awight) [22:03:31] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Upgrade code to use certificate-based authentication - https://phabricator.wikimedia.org/T134451#2265981 (awight) [22:04:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2265984 (awight) [22:05:11] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2265985 (awight) [22:05:23] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Internal Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2178928 (awight) [22:06:02] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2265987 (awight) [22:06:04] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2214823 (awight) [22:06:16] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2214823 (awight) [22:07:57] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2214823 (awight) [22:10:00] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2265997 (awight) Postponing to sprint +2 again, on account of not being supported in Japan: > Buyer Account in: Japan, China (... [22:11:01] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2265998 (awight) [22:11:06] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Enable Express Checkout on production account - https://phabricator.wikimedia.org/T134201#2265999 (awight) [22:11:25] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Add "in-context" integration - https://phabricator.wikimedia.org/T132944#2214823 (awight) [22:11:53] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Debug gateway account name handling - https://phabricator.wikimedia.org/T130852#2266001 (awight) Not sure we have to do this. Creating a subtask to investigate. [22:13:30] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Spike: Decide whether PayPal Express Checkout is a new gateway, payment method, or account name. - https://phabricator.wikimedia.org/T134452#2266003 (awight) [22:24:44] (PS2) Ejegg: CRM-17984. Ensure input for subtype is valid; if not then do not use it to filter custom fields. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286557 (owner: Eileen) [22:26:04] awight: mind looking at this upstream Civi patch? I need to keep re-applying it locally to test eileen's stuff https://gerrit.wikimedia.org/r/#/c/286551/ [22:27:12] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, and 2 others: Write adapter for Express Checkout - https://phabricator.wikimedia.org/T131811#2266036 (awight) Schedule an outage when we deploy this, we don't want donors... [22:27:18] ejegg: sure [22:28:15] (CR) Awight: [C: 2] CRM-17846 - Fixing lock name to be less than 64 characters for MySQL 5.7 compatibility (#7984) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286551 (owner: Ejegg) [22:29:50] thanks! [22:30:00] I know the feeling [22:30:35] Although rebase -i and keeping a handle on my named branch matching development head, I'm finally sort of sitting comfortable with git [22:30:41] (Merged) jenkins-bot: CRM-17846 - Fixing lock name to be less than 64 characters for MySQL 5.7 compatibility (#7984) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286551 (owner: Ejegg) [22:31:22] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2266044 (awight) [22:31:35] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2265841 (awight) [22:32:33] (PS3) Ejegg: CRM-17984. Ensure input for subtype is valid; if not then do not use it to filter custom fields. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286557 (owner: Eileen) [22:33:27] (CR) Ejegg: [C: 2] "looks legit, doesn't break things. can't see where this could have been exploited tho" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286557 (owner: Eileen) [22:34:20] (PS2) Ejegg: CRM-17984 test to demonstrate breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286558 (owner: Eileen) [22:36:37] (CR) Ejegg: [C: 2] CRM-17984 test to demonstrate breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286558 (owner: Eileen) [22:37:54] (Merged) jenkins-bot: CRM-17984. Ensure input for subtype is valid; if not then do not use it to filter custom fields. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286557 (owner: Eileen) [22:38:27] (PS2) Ejegg: Fix the RC regrsision [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286559 (owner: Eileen) [22:38:40] (PS2) Ejegg: CRM-5507 CRM-17984 fix regression when subType var is not leaking [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286560 (owner: Eileen) [22:39:43] (Merged) jenkins-bot: CRM-17984 test to demonstrate breakage [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286558 (owner: Eileen) [22:39:58] (CR) Ejegg: [C: 2] Fix the RC regrsision [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286559 (owner: Eileen) [22:40:18] (CR) Ejegg: [C: 2] CRM-5507 CRM-17984 fix regression when subType var is not leaking [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286560 (owner: Eileen) [22:40:29] (PS2) Ejegg: Fix Strict warning discovered in testing [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286561 (owner: Eileen) [22:40:55] (CR) Ejegg: [C: 2] Fix Strict warning discovered in testing [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286561 (owner: Eileen) [22:41:07] (PS2) Ejegg: CRM-17983, CRM-18401. Input validation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286562 (owner: Eileen) [22:41:58] (Merged) jenkins-bot: Fix the RC regrsision [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286559 (owner: Eileen) [22:42:00] (Merged) jenkins-bot: CRM-5507 CRM-17984 fix regression when subType var is not leaking [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286560 (owner: Eileen) [22:46:04] (PS2) XenoRyet: Adyen form for Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) [22:47:26] (PS2) Ejegg: CRM-17983 fix for contactRelationships query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286563 (owner: Eileen) [22:47:52] (Merged) jenkins-bot: Fix Strict warning discovered in testing [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286561 (owner: Eileen) [22:48:03] (PS2) Ejegg: Minimal check to validate relationship params. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286564 (owner: Eileen) [22:54:18] (CR) Ejegg: [C: -1] "even after pulling in all the following patches, I get mysqlOrderByDirection is not a recognised (camel cased) data type, since the case d" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286562 (owner: Eileen) [23:11:38] (PS1) AndyRussG: Fix browser tests for choiceData ordering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/287029 (https://phabricator.wikimedia.org/T134366) [23:11:51] awight: ^ :) [23:12:23] ejegg|away: cwd: XenoRyet: ^ [23:12:28] Easy fix for browser tests [23:12:54] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 3 others: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2266105 (AndyRussG) [23:14:21] (CR) Awight: [C: 2] "Nice fix!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/287029 (https://phabricator.wikimedia.org/T134366) (owner: AndyRussG) [23:14:32] awight: thx! [23:14:36] Hehe it felt so elegant! [23:14:41] banner one for low [23:14:47] banner three for high [23:14:53] banner NaN for as a kite [23:15:18] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2266107 (XenoRyet) [23:15:50] (Merged) jenkins-bot: Fix browser tests for choiceData ordering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/287029 (https://phabricator.wikimedia.org/T134366) (owner: AndyRussG) [23:20:30] * awight hangs a key on the string [23:21:17] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 3 others: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2263303 (hashar) I have hit the Rebuil... [23:21:26] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 3 others: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2266125 (AndyRussG) [23:22:21] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 3 others: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2263303 (AndyRussG) Open>Resolv... [23:23:35] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, and 3 others: RSpec::Expectations::ExpectationNotMetError in CentralNotice Selenium Jenkins job - https://phabricator.wikimedia.org/T134366#2263303 (AndyRussG) Thx @hashar!!