[00:14:52] out. [00:14:54] (PS1) Awight: [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [00:17:17] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [01:51:53] (CR) Ejegg: [C: 2] "Never mind - found it in I2e1b0e2e879c009 !" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286562 (owner: Eileen) [01:53:33] (Merged) jenkins-bot: CRM-17983, CRM-18401. Input validation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286562 (owner: Eileen) [01:54:51] (CR) Ejegg: [C: 2] CRM-17983 fix for contactRelationships query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286563 (owner: Eileen) [01:56:23] (Merged) jenkins-bot: CRM-17983 fix for contactRelationships query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286563 (owner: Eileen) [01:57:24] (CR) Ejegg: [C: 2] Minimal check to validate relationship params. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286564 (owner: Eileen) [01:57:38] (PS2) Ejegg: CRM-17983, CRM-18401. Input validation. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286565 (owner: Eileen) [01:59:32] (Merged) jenkins-bot: Minimal check to validate relationship params. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286564 (owner: Eileen) [02:23:22] (CR) Ejegg: [C: 2] CRM-17983, CRM-18401. Input validation. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286565 (owner: Eileen) [02:23:30] (PS2) Ejegg: CRM-17983, CRM-18401 - Swap loose/strict escaping [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286566 (owner: Eileen) [02:25:00] (Merged) jenkins-bot: CRM-17983, CRM-18401. Input validation. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286565 (owner: Eileen) [02:25:06] (PS2) Ejegg: CRM-18469, CRM-17984 - getTree - No more pass by reference [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286567 (owner: Eileen) [02:29:00] (CR) Ejegg: [C: 2] "default to safer, nice" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286566 (owner: Eileen) [02:32:57] (CR) Ejegg: [C: 2] CRM-18469, CRM-17984 - getTree - No more pass by reference [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286567 (owner: Eileen) [02:33:11] (PS2) Ejegg: Further pass-by-ref fixes following on from customGroup signature change [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286568 (owner: Eileen) [02:33:24] (Merged) jenkins-bot: CRM-17983, CRM-18401 - Swap loose/strict escaping [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286566 (owner: Eileen) [02:34:49] (CR) Ejegg: [C: 2] "still a few left in civiEngage, not that we use that" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286568 (owner: Eileen) [02:35:04] (PS2) Ejegg: CRM-18469, CRM-17984 - getTree regression on multiple integers separated by the cnrtl char [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286569 (owner: Eileen) [02:36:28] (CR) Ejegg: [C: 2] "That's a long constant for a comma!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286569 (owner: Eileen) [02:36:36] (PS2) Ejegg: CRM-17983 Fix error in data type as found by Dave [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286570 (owner: Eileen) [02:37:11] (CR) Ejegg: [C: 2] "Thanks, Dave!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286570 (owner: Eileen) [02:38:35] (PS2) Ejegg: Bare minimum patch for 4.6 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286571 (owner: Eileen) [02:39:45] (CR) Ejegg: [C: 2] "safer!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286571 (owner: Eileen) [02:39:59] (PS2) Ejegg: Fixed 2 other issues. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286572 (owner: Eileen) [02:40:23] (Merged) jenkins-bot: CRM-18469, CRM-17984 - getTree - No more pass by reference [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286567 (owner: Eileen) [02:40:25] (Merged) jenkins-bot: Further pass-by-ref fixes following on from customGroup signature change [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286568 (owner: Eileen) [02:40:27] (Merged) jenkins-bot: CRM-18469, CRM-17984 - getTree regression on multiple integers separated by the cnrtl char [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286569 (owner: Eileen) [02:40:29] (Merged) jenkins-bot: CRM-17983 Fix error in data type as found by Dave [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286570 (owner: Eileen) [02:41:26] (Merged) jenkins-bot: Bare minimum patch for 4.6 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286571 (owner: Eileen) [02:42:06] (CR) jenkins-bot: [V: -1] Fixed 2 other issues. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286572 (owner: Eileen) [02:43:08] (CR) Ejegg: [C: 2 V: 2] "Would have been nice to squash this with I4462c07a64b5562, but since I can force-merge..." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286572 (owner: Eileen) [02:43:21] (PS2) Ejegg: Cleanup to have same behaviour as 4.7. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286573 (owner: Eileen) [02:49:52] (CR) Ejegg: [C: 2] Cleanup to have same behaviour as 4.7. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286573 (owner: Eileen) [02:50:06] (PS2) Ejegg: Typo fix. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286574 (owner: Eileen) [02:50:42] (CR) Ejegg: [C: 2] "makes the twitching stop!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286574 (owner: Eileen) [02:50:52] (PS2) Ejegg: Further custom tree regression fix, where the label does not match the name the name is the key to use [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286575 (owner: Eileen) [02:51:33] (Merged) jenkins-bot: Cleanup to have same behaviour as 4.7. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286573 (owner: Eileen) [02:52:30] (Merged) jenkins-bot: Typo fix. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286574 (owner: Eileen) [02:52:40] (CR) Ejegg: [C: 2] Further custom tree regression fix, where the label does not match the name the name is the key to use [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286575 (owner: Eileen) [02:54:37] (Merged) jenkins-bot: Further custom tree regression fix, where the label does not match the name the name is the key to use [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286575 (owner: Eileen) [02:56:50] (CR) Ejegg: "Yep, that's the sole non-calculated field, and if there are ever conflict, we always want to resolve by setting it true. So I think the s" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [03:14:35] (PS1) Ejegg: Remove unused astropay js [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287039 [03:14:37] (PS1) Ejegg: Remove unused css resources [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287040 [03:31:29] (PS1) Ejegg: WIP localize card label alt/title attributes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287041 [03:37:38] (PS1) Ejegg: WIP pending table schema [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 [04:01:50] (PS3) Ejegg: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 [04:01:52] (PS1) Ejegg: WIP non-stomp-specific job queue consumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 [04:03:08] (CR) jenkins-bot: [V: -1] QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (owner: Ejegg) [04:03:31] (CR) jenkins-bot: [V: -1] WIP non-stomp-specific job queue consumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (owner: Ejegg) [04:28:44] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2266462 (Ejegg) [04:31:04] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 3 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2266463 (Ejegg) a:Ejegg [04:32:52] Fundraising Sprint Internet Exploring, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Patch-For-Review: Adyen job runner log prepending too many IDs - https://phabricator.wikimedia.org/T129946#2266466 (Ejegg) [04:33:04] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Enhance mustache state/province dropdown - https://phabricator.wikimedia.org/T133253#2266467 (Ejegg) [04:33:27] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Regression: no longer validating gateway-specific required fields server side - https://phabricator.wikimedia.org/T134189#2266468 (Ejegg) [04:33:29] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2016-05-08_(1.28.0-wmf.1): Style fields more cleanly for when donor enters form without currency or amount - https://phabricator.wikimedia.org/T113306#2266469 (Eje... [04:35:35] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Enhance mustache state/province dropdown - https://phabricator.wikimedia.org/T133253#2266470 (Ejegg) Open>Resolved [04:35:57] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Regression: no longer validating gateway-specific required fields server side - https://phabricator.wikimedia.org/T134189#2266471 (Ejegg) Open>Re... [04:38:05] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2016-05-08_(1.28.0-wmf.1): Style fields more cleanly for when donor enters form without currency or amount - https://phabricator.wikimedia.org/T113306#2266473 (Eje... [04:38:57] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2016-05-08_(1.28.0-wmf.1): Style fields more cleanly for when donor enters form without currency or amount - https://phabricator.wikimedia.org/T113306#1661342 (Eje... [04:40:34] (PS2) Ejegg: WIP pending table schema [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) [04:41:02] (PS4) Ejegg: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (https://phabricator.wikimedia.org/T133965) [04:42:33] (CR) jenkins-bot: [V: -1] QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg) [04:42:45] (CR) Ejegg: "Maybe this should have an option to shunt messages to a designated damage queue on exception instead of bailing out." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg) [09:16:07] (CR) Awight: "Oh, cool!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (owner: Ejegg) [09:19:46] (CR) Awight: "Never mind everything after the "oh, cool"! This is just a drop-in replacement for StompJobRunner, and the polymorphic thing is existing " [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (owner: Ejegg) [14:02:35] Fundraising-Backlog: Deploy changes to Spanish Thank you letter - https://phabricator.wikimedia.org/T134489#2267119 (jrobell) [15:33:47] Fundraising Sprint Internet Exploring, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Revisit triggers. We probably want them. - https://phabricator.wikimedia.org/T117055#2267403 (DStrine) [15:33:49] Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Question & Possible Task: Is there a more detailed change log than the one on the contact summary page? - https://phabricator.wikimedia.org/T88447#2267404 (DStrine) [17:09:26] (PS3) Ejegg: SQLite support for PDO backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286773 [17:15:08] hi ejegg [17:15:26] hi cwd [17:15:35] how's the offsite? [17:15:40] MBeat reports donors in CO getting fiscal number errors, i notice the rule that deployed yesterday say it needs to be 11-14 chars [17:15:51] in the screenshot he sent me it is 8 chars [17:15:58] it is fun! [17:16:07] the weather is beautiful, i thought it would be cooler up here [17:16:31] reading team's challenges are a lot like ours [17:16:43] and probably just about every tech team's tbh [17:17:42] oh shoot, let me check... [17:18:08] I didn't think I changed any rules in that deployment [17:19:29] damn, you're right! [17:19:30] yeah it looked like the code was just shuffled around [17:19:52] something get lost in the shuffle? [17:19:56] ohh, awight started on that encapsulation experiment a while ago [17:20:08] before I fixed the code in DataValidator [17:20:19] Lemme correct that real quick [17:20:43] aaah right on [17:20:48] Dang, I thought I had tests to make sure I didn't screw that up again! [17:22:45] annnd... no CO numbers in the test data provider [17:22:48] worth sticking the validation rules in config ya think? [17:22:58] ejegg: heh well that makes sense then [17:23:20] at least it is working as expected [17:28:44] ejegg, is this reverted now? [17:30:17] MBeat: just pushing the patch for review now [17:30:28] thank you [17:30:37] (PS1) Ejegg: Fix CO fiscal number validation rules (again) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287117 [17:32:15] cwd if you're not already on it, mind taking a look? ^^ [17:32:20] yep [17:32:23] thanks! [17:32:30] i should just mentioned, the screenshot i saw didn't have any dashes in the number [17:32:34] does the regex care about that? [17:32:44] *mention [17:32:48] nope, that's all stripped [17:33:04] nice [17:33:15] (CR) Cdentinger: [C: 2] Fix CO fiscal number validation rules (again) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287117 (owner: Ejegg) [17:34:32] (Merged) jenkins-bot: Fix CO fiscal number validation rules (again) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287117 (owner: Ejegg) [17:34:40] Thanks! I'll deploy as a cherry-pick [17:35:35] (PS1) Ejegg: Fix CO fiscal number validation rules (again) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/287118 [17:36:02] (CR) Ejegg: [C: 2 V: 2] Fix CO fiscal number validation rules (again) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/287118 (owner: Ejegg) [17:37:01] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/287120 [17:37:30] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/287120 (owner: Ejegg) [17:38:07] (CR) Ejegg: [V: 2] Update DonationInterface [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/287120 (owner: Ejegg) [17:40:00] !log updated payments-wiki from 8962b558b5eb5a4dba91be7ed7649b532fa4ee35 to b16c3cb0e12aacb49b91974d693c401dcaa9cca9 [17:40:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:55:57] Fundraising-Backlog, fundraising-tech-ops: Strine needs access to lutetium (spelling?) - https://phabricator.wikimedia.org/T134511#2267825 (DStrine) [18:02:34] (PS1) Ejegg: popAtomic doesn't run callback if queue is empty [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287126 [18:05:52] (PS5) Ejegg: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 [18:07:18] (CR) jenkins-bot: [V: -1] QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (owner: Ejegg) [18:07:55] ^^^ just needs its php-queue dependencies merged, in case anyone wants to review them [18:08:14] https://gerrit.wikimedia.org/r/286773 [18:08:23] https://gerrit.wikimedia.org/r/287126 [18:21:39] (PS6) Ejegg: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 [18:22:42] (CR) jenkins-bot: [V: -1] QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (owner: Ejegg) [18:23:55] XenoRyet: wanna trade CR? Got a couple of php-unit patches that are holding up SmashPig tests from passing [18:24:00] I mean php-queue [18:24:04] https://gerrit.wikimedia.org/r/286773 [18:24:07] https://gerrit.wikimedia.org/r/287126 [18:24:17] Sure, I'll take a look. [18:24:26] Thanks! [18:24:52] Here's that Adyen one: https://gerrit.wikimedia.org/r/#/c/286949/ [18:25:00] looking! [18:28:39] (CR) Ejegg: "Oh hey, just noticed 'defineReturnValueMap' that should either go away or be used here." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286765 (owner: Awight) [18:47:27] (CR) Ejegg: [C: -1] "Let's put the addressRequired array in one place (maybe even config?)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [18:52:28] (CR) XenoRyet: [C: 2] SQLite support for PDO backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286773 (owner: Ejegg) [18:53:35] (Merged) jenkins-bot: SQLite support for PDO backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/286773 (owner: Ejegg) [18:54:59] (CR) XenoRyet: [C: 2] popAtomic doesn't run callback if queue is empty [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287126 (owner: Ejegg) [18:56:02] (Merged) jenkins-bot: popAtomic doesn't run callback if queue is empty [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287126 (owner: Ejegg) [18:57:03] (PS1) Ejegg: Generalized client-side val: don't break if empty [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287130 [18:58:51] XenoRyet: just caught some serious breakage from one of my patches that merged yesterday ^^^ [18:59:05] very glad I deployed that fix this morning as a cherry-pick! [19:05:21] Heh, yea. [19:14:37] (CR) XenoRyet: [C: 2] Generalized client-side val: don't break if empty [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287130 (owner: Ejegg) [19:16:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: [Tracking] CentralNotice: reducing initial JS load? - https://phabricator.wikimedia.org/T133741#2268209 (Danny_B) [19:19:54] (Merged) jenkins-bot: Generalized client-side val: don't break if empty [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287130 (owner: Ejegg) [19:27:13] (PS1) Ejegg: Better validation for donation.api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287135 (https://phabricator.wikimedia.org/T134527) [19:27:35] XenoRyet: wanna look at that one too? ^^^ [19:28:23] (PS7) AndyRussG: [WIP] Mixed storage for impression diet and large banner limit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) [19:41:33] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2268268 (CCogdill_WMF) Hey @MBeat, have... [19:48:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: Banner editor should be more consistent with other editing (tracking) - https://phabricator.wikimedia.org/T116140#2268290 (Danny_B) [19:59:02] (PS1) Ejegg: WIP no more alert() for API errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 [20:00:35] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2268305 (MBeat33) @CCogdill_WMF , the em... [20:00:52] (CR) jenkins-bot: [V: -1] WIP no more alert() for API errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (owner: Ejegg) [20:04:03] dstrine: there in a sec [20:09:36] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2268330 (CCogdill_WMF) Thanks for the ex... [20:11:21] (PS7) Ejegg: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 [20:24:20] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2016-05-08_(1.28.0-wmf.1): Style fields more cleanly for when donor enters form without currency or amount - https://phabricator.wikimedia.org/T113306#2268383 (Eje... [20:33:51] (PS8) AndyRussG: Mixed storage for impression diet and large banner limit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) [20:44:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, Performance-Team, Traffic: Spike: CentralNotice: Verify that our Special:HideBanners cookie storm works as efficiently as possible - https://phabricator.wikimedia.org/T117435#2268418 (chasemp) p:Triage>Normal [20:48:03] (CR) XenoRyet: [C: 2] Better validation for donation.api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287135 (https://phabricator.wikimedia.org/T134527) (owner: Ejegg) [20:48:49] (PS9) AndyRussG: Mixed storage for impression diet and large banner limit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) [20:49:42] (Merged) jenkins-bot: Better validation for donation.api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287135 (https://phabricator.wikimedia.org/T134527) (owner: Ejegg) [20:50:01] thanks XenoRyet [20:51:40] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Errors from api calls should not be displayed with multiple alert popups - https://phabricator.wikimedia.org/T134530#2268433 (Ejegg) [20:52:14] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2268446 (MBeat33) The most recent one I... [20:57:03] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2268451 (CCogdill_WMF) Sounds good, than... [21:01:52] (PS2) Ejegg: Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) [21:27:37] (PS3) Ejegg: Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) [21:28:02] ^^^ actually pretty good at this point [21:28:36] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Errors from api calls should not be displayed with multiple alert popups - https://phabricator.wikimedia.org/T134530#2268547 (Ejegg) a:Ejegg [21:29:05] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Errors from api calls should not be displayed with multiple alert popups - https://phabricator.wikimedia.org/T134530#2268433 (Ejegg) [21:36:41] (PS1) Ejegg: WIP pending queue consumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) [21:37:22] back in a bit... [21:38:55] (PS10) AndyRussG: Mixed storage for impression diet and large banner limit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) [21:38:57] (PS3) AndyRussG: Mixed storage for buckets [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) [21:40:33] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets, impres... - https://phabricator.wikimedia.org/T132639#2268574 [21:40:54] ^ ejegg|afk cwd|afk XenoRyet out of WIP! :) [21:41:39] Nice. I'm hunkered down on other stuff right now, but I'll see if I can poke at it later. [21:59:39] XenoRyet: cool, thx much! [22:10:34] (CR) Awight: "Interesting--I'm quite surprised that you went for the fixed schema. Do you have thoughts about the benefits that gives us, vs a text fie" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [22:15:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2268639 (Jgreen) a:Jgreen>CaitVirtue Caitlin, I'm inclined to close this ticket at this point. Judging f... [22:18:13] Fundraising-Backlog, fundraising-tech-ops: Finish config file centralization for Fundraising systems - https://phabricator.wikimedia.org/T113301#1661263 (Jgreen) We've got a pretty good handle on file-based config now, based on the localsettings git repo on boron which is now auto-tweezed by fundraising_... [22:20:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2268664 (CaitVirtue) Is the process documented somewhere? And what triggers it? [22:22:29] (PS11) AndyRussG: Mixed storage for impression diet and large banner limit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) [22:22:31] (PS4) AndyRussG: Mixed storage for buckets [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) [22:24:13] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2268678 (awight) SORRY! I meant ready f... [22:26:29] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, and 2 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2268680 (CCogdill_WMF) Oh... oops! My mi... [22:26:31] (PS4) Awight: Unsubscribe old emails; fix is_primary bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) [22:27:41] (PS5) Awight: Unsubscribe old emails; fix is_primary bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) [22:28:09] Ping ^ that one could use code review... [22:28:37] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2268681 (AndyRussG) [22:28:52] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2268682 (AndyRussG) [23:07:32] (PS2) Awight: [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [23:07:34] (PS1) Awight: Implement IsoDate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287150 [23:09:09] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [23:10:54] Fundraising-Backlog, fundraising-tech-ops: Finish config file centralization for Fundraising systems - https://phabricator.wikimedia.org/T113301#2268720 (awight) Open>Resolved a:awight Oh wow, you did the auto-tweezing already! Let's hope that --shared does its thing. [23:14:54] (CR) Ejegg: "Oh yeah, that would be way easier! I guess I thought part of the task was to standardize the fields. But this way it would be a real pain " [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [23:18:35] ejegg: I'm interested in this idea of queues having schemas, though [23:18:43] validating messages would be rad. [23:19:21] Tables would have different columns... it looks like that's where you were going? [23:19:27] yep, but altering tables is slightly less rad [23:19:40] The jobs-requests queue might be better as a db table, too... [23:19:49] schema evolution is the worst [23:19:50] awight: yeah, I was thinking we'd try to set this stuff in stone [23:20:01] but that's never really possible... [23:20:06] doesn't kafka come with a layer for schema migration?... [23:20:16] I've added at least two things to the pending messages [23:20:20] ejegg: I think it almost might be possible [23:20:32] we do rely on a high degree of backward-compatibility [23:20:56] so the big issue would be keeping the old paypel pending messages in the same table [23:20:57] It does bother me that some of this is unDRY with CiviCRM custom schema as well, but meh... [23:21:08] paypal pending is history. [23:21:12] 'cause they share almost nothing [23:21:14] oh [23:21:19] hrm what is this? [23:21:21] subscriptions? [23:21:23] what happens with existing subscriptions? [23:21:29] uh wut [23:21:40] * awight looks at paypal pending [23:21:41] current paypal recurring donors [23:21:54] so this is the "SAR" file... [23:21:55] can we migrate them over to EC recurring? [23:21:58] subscription action [23:22:10] no, we can't migrate subscriptions. good point [23:22:16] nevar [23:22:29] we have ones who are effectively anonymous to us... [23:22:49] not landing in Civi cos I suck... [23:22:50] so yah, I think your indexed columns + json blob is the way to go [23:23:00] I'm just being lazy [23:23:09] but it does allow us to cut a lot of corners [23:23:14] sign of an experiences coder, right? [23:23:20] *experienced [23:23:23] or, we could have a schema of all field names going to varchar. [23:23:55] ejegg: What are your thoughts about these schemas, though? [23:24:20] Nah, I think as long as we can select by gateway + id, we can assume the consumer knows how to decode their own json blobs [23:24:45] But if we have schemas... [23:24:47] I do think we want to quit sending anything we're not using [23:25:25] An aside, I love how Wordpress does schema migrations. [23:25:37] howzzat? [23:25:39] They just add, delete and alter tables to make them match the target version's schema [23:26:07] It would be a nice compromise to echo a warning, that explains how the schema would be migrated and to confirm [23:26:18] i think that's what mysql_upgrade does for the system tables [23:26:23] nice! [23:26:38] the master's tools [23:26:54] yeah, until the internally-generated script fails halfway with a useless error message... [23:27:02] hehe [23:27:30] seriously, beware of 5.6 -> 5.7 [23:27:42] That's the beauty of the street as hell merge though, the only error condition is if you don't have permissions to make the change [23:27:45] oh? [23:27:48] that sounds bad [23:28:09] I know now that you have to do a text backup of yr mysql if you expect to survive every upgrade. [23:28:11] something with the user table wasn't going through [23:28:24] oh god [23:28:28] and you had to dive into the bowels? [23:28:36] general_log at least pointed me to the right area [23:28:49] yeah, manual user table alters [23:29:26] which weren't quite so scary once I learned about the --skip-grant-tables free for all option [23:30:08] but after doing that, the rest of the upgrade went smoothly [23:30:27] awight: ejegg: hey! dunno if u saw, now out of WIP: https://gerrit.wikimedia.org/r/#/c/285336/ https://gerrit.wikimedia.org/r/#/c/285571/ [23:30:35] hehehe [23:30:38] nice flag [23:30:39] since it was doing the compare and make like target schema algo [23:30:42] * AndyRussG chides self for not such gentle prodding [23:30:54] hi AndyRussG , I'll take a look [23:31:01] ejegg: hey! thx much!!!!! :) [23:31:26] AndyRussG: Hi! [23:31:39] awight: hey :) [23:31:45] You should feel free to lob gift-wrapped bricks over the garden gate any time! [23:32:01] or brick-wrapped gifts? [23:32:22] * AndyRussG ties bricks in a bow [23:32:26] like in super mario brothers? [23:32:54] yeah except you have to play using the Gerrit UI [23:33:18] i hear that twitch channel is pretty quiet [23:33:27] AndyRussG: What a great cookie dishing patch! I hope mw-core can reuse... [23:33:43] Or are we grabbing non-CN cookies as well? [23:34:10] awight: heh thx... not yet, but the fallback mechanism could be implemented [23:34:15] in core [23:34:20] dunno if they'll want to tho [23:35:27] Maybe they can just ditch their old cookies. I suppose they'll have to clean up the mess at least. [23:36:15] awight: yeah dunno if anything other than CN will be permitted to cookie... I guess maybe [23:36:35] back a little later!! thx again :) [23:42:05] hehe, when I tell my ide to annotate CN source history it's like the Nigerian flag - alternating Green and Wight [23:42:15] cute! [23:42:32] CN really is a team sport [23:42:40] such a burden to carry on one's own... [23:45:38] d'oh! I lost logger->debug messages again [23:45:50] * AndyRussG|souper snickers and goes back to setting the table [23:46:15] setting the table with snickers?