[00:14:22] (CR) Ejegg: "Code looks pretty solid! I can only pick on a few typos, and all but one are in comments." (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [00:30:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, Epic, and 3 others: Deprecate old pending queues - https://phabricator.wikimedia.org/T133433#2268919 (Danny_B) [00:32:33] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Clean up confusing and repeated code in the PayPal express adapter - https://phabricator.wikimedia.org/T134445#2268948 (Danny_B) [00:44:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Encapsulate OrderId logic - https://phabricator.wikimedia.org/T130809#2268960 (Danny_B) [00:45:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-ActiveMQ, and 2 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2268961 (Danny_B) [00:47:18] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Extract processResponse call from do_transaction_internal - https://phabricator.wikimedia.org/T134421#2268963 (Danny_B) [00:50:03] (PS12) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [00:50:05] (PS21) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [00:50:07] (PS3) Awight: Remove soft transition for old "token" parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286996 [00:50:09] (PS10) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [00:50:11] (PS3) Awight: [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [00:50:13] (PS1) Awight: Catch nefarious bug with staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287155 [00:50:15] (PS1) Awight: Comment about concerning query string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 [00:50:17] (PS1) Awight: PayPal Express Checkout: support locale well enough to get ja_JP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287157 (https://phabricator.wikimedia.org/T131811) [00:50:59] ejegg: Here's an accidental processor 'sploit for your amusement: https://gerrit.wikimedia.org/r/#/c/287156/ [00:51:07] not urgent, afaict... [00:51:52] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Helper for transaction response errors - https://phabricator.wikimedia.org/T134420#2268980 (Danny_B) [00:53:04] (CR) jenkins-bot: [V: -1] Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [00:53:14] (CR) jenkins-bot: [V: -1] Remove soft transition for old "token" parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286996 (owner: Awight) [00:53:26] oh yeah? [00:53:57] Pretty sure we're not urlencoding our outbound api calls [00:54:12] (CR) jenkins-bot: [V: -1] Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [00:54:14] (CR) jenkins-bot: [V: -1] Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [00:54:42] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [00:55:12] (CR) jenkins-bot: [V: -1] PayPal Express Checkout: support locale well enough to get ja_JP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287157 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [00:55:24] (CR) jenkins-bot: [V: -1] Comment about concerning query string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 (owner: Awight) [00:56:56] (CR) jenkins-bot: [V: -1] Catch nefarious bug with staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287155 (owner: Awight) [01:00:33] (PS2) Awight: Catch nefarious bug with staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287155 [01:01:02] ejegg: It just got extremely spooky. https://gerrit.wikimedia.org/r/#/c/287155/2/paypal_gateway/config/transformers.yaml,unified [01:01:40] I ran through the workflow and indeed, PayPal never uses cents as the amount unit. [01:01:53] So we've been relying on wrongness... [01:02:00] (CR) jenkins-bot: [V: -1] Catch nefarious bug with staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287155 (owner: Awight) [01:02:17] Hopefully it's something I introduced with the staging encapsulation? [01:02:43] wait, we haven't been charging pp donors 100x, have we? [01:03:00] No--but it's been using the non-staged data [01:04:42] omg I'm hitting so much undead code [01:06:37] slay it! [01:08:12] * awight waves a chainsaw into the dimness [01:08:25] the dearth of light [01:08:56] best of luck with that! I think I'm done for the eve [01:09:18] I'll be around a bit tomorrow, see ya! [01:09:25] see ya [01:23:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2269000 (Jgreen) Documentation is here: https://collab.wikimedia.org/wiki/Fundraising/Engineering/SSL_Client_Au... [02:19:26] (PS13) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [02:19:28] (PS22) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [02:19:30] (PS4) Awight: Remove soft transition for old "token" parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286996 [02:19:32] (PS3) Awight: Catch nefarious bug with staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287155 [02:19:34] (PS11) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [02:19:36] (PS2) Awight: Comment about concerning query string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 [02:19:38] (PS4) Awight: [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [02:19:40] (PS2) Awight: PayPal Express Checkout: support locale well enough to get ja_JP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287157 (https://phabricator.wikimedia.org/T131811) [02:19:42] (PS1) Awight: Move chunk of Worldpay logic into a staging class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287159 [02:19:44] (PS1) Awight: Formatting, comments, robustness [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287160 [02:24:35] (CR) jenkins-bot: [V: -1] [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [02:47:58] (PS12) AndyRussG: Mixed storage for impression diet and large banner limit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) [02:48:00] (PS5) AndyRussG: Mixed storage for buckets [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) [02:48:36] (CR) AndyRussG: "Thx much!!!" (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [03:08:33] (PS5) Awight: [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [04:45:35] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2269180 (awight) [04:52:45] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2269182 (awight) The recurring workflow looks bad and is confusi... [04:53:05] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2269183 (awight) @Ppena you might want to take a look at the com... [04:59:06] (PS14) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [04:59:08] (PS23) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [04:59:10] (PS5) Awight: Remove soft transition for old "token" parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286996 [04:59:12] (PS12) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [04:59:14] (PS3) Awight: Encode query string values properly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 [04:59:16] (PS6) Awight: [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [04:59:18] (PS3) Awight: PayPal Express Checkout: support locale well enough to get ja_JP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287157 (https://phabricator.wikimedia.org/T131811) [04:59:20] (PS1) Awight: Implement IsoDate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287171 [05:00:03] (Abandoned) Awight: Implement IsoDate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287150 (owner: Awight) [05:15:58] (PS4) Awight: [DO NOT MERGE] Encode query string values properly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 [14:44:52] Fundraising Tech Backlog, Fundraising-Backlog, Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912#2270104 (Jgreen) [15:48:12] Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Errors from api calls should not be displayed with multiple alert popups - https://phabricator.wikimedia.org/T134530#2270277 (DStrine) [17:17:27] XenoRyet: any luck with the debugger? [17:17:50] Not yet. I'm just booting up for the morning. [17:18:31] Hold on, just got some family news I have to deal with [17:34:19] ppena_: hi! [17:34:49] ppena_: I have some working prototypes for PP EC, and wanted to check in with you about the workflow [17:35:11] ppena_: https://phabricator.wikimedia.org/T134446#2269182 [17:35:22] * awight wonders which is the real PPena [17:43:54] Fundraising Tech Backlog, Design-Research-Backlog, Design Research and product team collaboration: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#2270589 (ggellerman) [17:44:27] Fundraising Tech Backlog, Design-Research-Backlog, Design Research and product team collaboration: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#1230461 (ggellerman) + @DStrine + Fundraising Tech Backlog @DStrine Is this still of interest? T... [18:06:43] Fundraising Tech Backlog, Design-Research-Backlog, Design Research and product team collaboration: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#2270648 (awight) @Pcoombe Hi, there's an opportunity to work with design and design-research on our p... [18:16:14] hah. multiple drag and drop uploads to Phabricator appear in "first comes first" order, according to how they upload [18:16:25] Fundraising Tech Backlog, Design-Research-Backlog, Design Research and product team collaboration: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#2270681 (awight) I'd also personally love to see work done on the desktop forms as well. One of our... [18:16:50] Fundraising Tech Backlog, Fundraising-Backlog, Design-Research-Backlog, MediaWiki-extensions-DonationInterface, Design Research and product team collaboration: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#2270682 (awight) [19:17:30] (CR) Ejegg: "Looks like an elegant solution! Did we decide we actually do need (one of the) contact IDs for the unsubscribe table?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [19:23:31] (CR) Awight: "@ejegg The last I remember, we do not need contact id in the excluded email list. However, the patch seems to go through some trouble to " [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [19:25:52] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2270773 (AndyRussG) It s... [19:26:14] woohoo, more mysql 5.7 changes [19:26:27] what now? [19:26:43] it now acts like mssql wrt non-aggregated, non-grouped columns in select list [19:26:58] think i cn change that mode back though [19:27:17] Expression #2 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'silverpop.ex.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by [19:28:02] That's sort of reasonable... but yeah behavior change yuck [19:28:34] Dang, I hate to think how we would have to rewrite the query [19:29:04] min(ex.id) oughtta do it [19:29:21] and be deterministic! [19:29:27] I guess there's no constraint that unique columns are 1:1 [19:29:37] yah that is simple [19:29:57] stupid... software-mandated improvements ;) [19:30:04] hehe [19:30:55] oh, I guess max(id) to be consistent with our dedupe logic [19:31:33] that's odd. I can't wait to be done with that [19:32:44] My crystal ball actually doesn't specify whether we can ever make that code go away, come to think of it... [19:32:57] cos there will always be temporary email conflicts, eh [19:38:07] (CR) Ejegg: [C: -1] "Needs an extra db setting / replacement for log_civicrm" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [19:40:59] (CR) Ejegg: "Also added a dummy email address w/no contact ID to unsubscribes, maybe from UID 1:" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [19:41:46] (PS6) Awight: Unsubscribe old emails; fix is_primary bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) [19:42:14] d'oh! [19:42:37] (CR) Awight: "PS6 doesn't fix the dummy line..." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [19:47:13] (PS3) Ejegg: Pending table schema [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) [20:06:03] awight you free? No biggie since this is supposed to be your day off [20:11:32] (CR) Ejegg: "Code looks solid - just a question about necessity of migrating older legacy cookies." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [20:42:25] dstrine: oops--yeah sorry I'm cramming these peer reviews [20:42:53] awight: lol yeah that was everyone else's updates too :) [20:43:04] hehe [20:48:18] (CR) Awight: "Nice multikeys!" (5 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [21:02:05] (PS1) Ejegg: Catch prepare($sql) exceptions on missing table [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287286 [21:04:11] (CR) jenkins-bot: [V: -1] Catch prepare($sql) exceptions on missing table [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287286 (owner: Ejegg) [21:05:00] huh, not catchable in 5.3 [21:06:43] (PS2) Ejegg: Catch prepare($sql) exceptions on missing table [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287286 [21:08:39] procrastiworking? workrastination? [21:14:10] (PS1) Ejegg: Damaged message queue for QueueConsumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) [21:15:02] glad to see it's not just me [21:15:14] (CR) jenkins-bot: [V: -1] Damaged message queue for QueueConsumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg) [21:19:25] dang, I can't find my 2015-16 goals anywhere :( [21:19:37] what. uh, oh--self-reviews are due today as well? [21:19:50] i think so... [21:19:57] so says the email horn [21:20:01] other thing that offends me: PayPal seems to be returning two HTTP headers [21:20:05] kill me now [21:20:10] blecch [21:23:07] (PS1) AndyRussG: Slurp and delete defunct cookies on every pageview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/287289 (https://phabricator.wikimedia.org/T132640) [21:23:58] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete the... - https://phabricator.wikimedia.org/T132640#2271132 [21:52:43] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Update audit parser for PayPal Express Checkout - https://phabricator.wikimedia.org/T134605#2271152 (awight) [21:53:23] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-WMF-Audit: Update audit parser for PayPal Express Checkout - https://phabricator.wikimedia.org/T134605#2271171 (awight) [22:09:33] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint UB40, Fundraising-Backlog, and 2 others: Documentation: overview of new CN code and instructions for CN admins - https://phabricator.wikimedia.org/T111386#2271198 (Danny_B) [22:09:45] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, and 5 others: Document how the new queueing stuff will work - https://phabricator.wikimedia.org/T96434#2271199 (Danny_B) [22:22:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout: Spike: Do we need a custom payment page style? - https://phabricator.wikimedia.org/T134609#2271247 (awight) [22:59:32] * awight explodes with relief [22:59:48] Heads-up re: Sunday deadline for reviews [23:00:07] * awight goes immediately back to procrastination [23:00:42] Heh, don't tell me that, I'm almost done. ;- [23:00:48] ;-) [23:01:48] haha just kidding aye [23:10:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout: Spike: Do we need a custom payment page style? - https://phabricator.wikimedia.org/T134609#2271327 (awight) Open>Invalid It's just logos and colors, nvm. [23:24:25] (CR) Awight: "Formalized!" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg) [23:25:00] (PS15) Awight: Move legacy PayPal stuff into a subdirectory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286116 (https://phabricator.wikimedia.org/T131811) [23:25:02] (PS24) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) [23:25:04] (PS6) Awight: Remove soft transition for old "token" parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286996 [23:25:06] (PS13) Awight: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) [23:25:08] I'm going to sign off for today. Have a good weekend [23:25:08] (PS2) Awight: Implement IsoDate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287171 [23:25:10] (PS5) Awight: Encode query string values properly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 (https://phabricator.wikimedia.org/T134586) [23:25:12] (PS7) Awight: [WIP] PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [23:25:14] (PS4) Awight: PayPal Express Checkout: support locale well enough to get ja_JP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287157 (https://phabricator.wikimedia.org/T131811) [23:25:19] dstrine: bubye, stay dry! [23:25:38] awight: thanks! [23:54:45] (CR) Ejegg: "thanks for the feedback!" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg) [23:57:29] (CR) Awight: Damaged message queue for QueueConsumer (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg) [23:59:12] (CR) Ejegg: "good point about the nullability - guess I was assuming these all came from the payments cluster, but of course we're using this queue for" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)