[14:47:37] <wikibugs>	 Fundraising-Backlog, Hovercards, Reading-Web-Backlog: Avoid z-index conflict with  HoverCards & Central Notice and friends - https://phabricator.wikimedia.org/T131364#2276277 (dr0ptp4kt)
[15:21:18] <wikibugs>	 Wikimedia-Fundraising-CiviCRM: Rename drush thank you task - https://phabricator.wikimedia.org/T134771#2276464 (Ejegg)
[15:33:38] <wikibugs>	 Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-72-N: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2276569 (dr0ptp4kt) This task should be updated with the variable name expo...
[15:35:45] <wikibugs>	 Fundraising-Backlog, Hovercards: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2276574 (DStrine)
[15:36:19] <wikibugs>	 Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-73-O: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2276578 (dr0ptp4kt)
[16:06:37] <grrrit-wm>	 (PS1) Ejegg: Move test code to test support [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/287653 (https://phabricator.wikimedia.org/T133712)
[16:07:04] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Move queue2civicrm_generate_message to test support - https://phabricator.wikimedia.org/T133712#2276734 (Ejegg) a:Ejegg
[16:16:00] <grrrit-wm>	 (PS8) Ejegg: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (https://phabricator.wikimedia.org/T133965)
[16:19:11] <AndyRussG|m>	 the-wub: hi! quick question: just to check, no FR campaigns last over many months, during which time you'd want to keep buckets for the campaign stable, right? That is, it's true there's no such thing?
[16:21:01] <the-wub>	 AndyRussG|m: no, we have low level tests that have lasted many months. I think that's mainly due to lack of attention in updating them though
[16:28:07] <grrrit-wm>	 (PS2) Ejegg: Damaged message queue for QueueConsumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965)
[16:28:45] <grrrit-wm>	 (PS3) Ejegg: Damaged message queue for QueueConsumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965)
[16:30:29] <AndyRussG|m>	 the-wub: anything worth keeping the buckets stable for that may have been around since October of last year or so?
[16:32:40] <AndyRussG>	 the-wub: the reason is this: I'd like to remove backwards-compatbility for the old-format buckets_by_campaign bucket cookie
[16:32:47] <grrrit-wm>	 (CR) Krinkle: Don't fail hard on dependencies error for ext.centralNotice.startUp (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286762 (https://phabricator.wikimedia.org/T134310) (owner: AndyRussG)
[16:32:51] <grrrit-wm>	 (CR) Krinkle: [C: -1] Don't fail hard on dependencies error for ext.centralNotice.startUp [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286762 (https://phabricator.wikimedia.org/T134310) (owner: AndyRussG)
[16:33:36] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2276867 (Krinkle) p:Unbreak!>High
[16:35:22] <the-wub>	 AndyRussG: the longest running ones have been since early November. however I hope to get them changed in the next couple of weeks. and it's probably not a big deal if we mix the buckets for them anyway
[16:37:47] <AndyRussG>	 the-wub: k yeah that's what I imagined... Yeah the bucket mixing would only take place for the small percentage of users who got and still will get those campaigns, and who got them before the cookie transition, and have never come to the site and gotten a campaign since (the only scenario in which they'd still have the old cookie with useful data)
[16:39:55] <AndyRussG>	 Oddly the centralnotice_buckets_by_campaign cookie is still seen at least a little on production, but likely it's due to some caching or cookie expiry wonkiness and not because it has anything we care about anymore
[16:44:13] <the-wub>	 AndyRussG: that sounds fine then
[16:44:21] <AndyRussG>	 the-wub: cool beans, thx much!
[16:44:31] * AndyRussG puts beans in the fridge
[16:50:48] <grrrit-wm>	 (PS2) Ejegg: Job runner for generic queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (https://phabricator.wikimedia.org/T133965)
[17:03:34] <grrrit-wm>	 (PS3) Ejegg: Job runner for generic queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (https://phabricator.wikimedia.org/T133965)
[17:04:28] <grrrit-wm>	 (PS4) Ejegg: Damaged message queue for QueueConsumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965)
[17:10:48] <grrrit-wm>	 (PS3) AndyRussG: Don't fail hard on dependencies error for ext.centralNotice.startUp [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286762 (https://phabricator.wikimedia.org/T134310)
[17:11:50] <grrrit-wm>	 (CR) AndyRussG: "Thx!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/286762 (https://phabricator.wikimedia.org/T134310) (owner: AndyRussG)
[17:20:36] <grrrit-wm>	 (PS1) AndyRussG: Always warn in console using mw.log.warn() instead of mw.log() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/287668
[17:35:47] <grrrit-wm>	 (PS6) AndyRussG: Mixed storage for buckets [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639)
[17:37:04] <grrrit-wm>	 (CR) AndyRussG: "Thx much!!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG)
[17:39:02] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2277230 (AndyRussG) Should we mark this as resolved?
[18:19:06] <wikibugs>	 Fundraising-Backlog, Wikimedia-Shop, Unplanned-Sprint-Work: Fix login issue with Shopify store - https://phabricator.wikimedia.org/T134796#2277332 (awight)
[18:20:00] <wikibugs>	 Fundraising-Backlog, Wikimedia-Shop, Unplanned-Sprint-Work: Fix login issue with Shopify store - https://phabricator.wikimedia.org/T134796#2277346 (awight)
[18:20:13] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Shop, Unplanned-Sprint-Work: Fix login issue with Shopify store - https://phabricator.wikimedia.org/T134796#2277332 (awight)
[18:25:28] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Shop, Unplanned-Sprint-Work: Fix login issue with Shopify store - https://phabricator.wikimedia.org/T134796#2277393 (awight) @GHoltman I was able to register a new customer account using the updated link.  Please let me know if...
[18:28:13] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Shop, Unplanned-Sprint-Work: Fix login issue with Shopify store - https://phabricator.wikimedia.org/T134796#2277413 (GHoltman) I was able to create a new account.
[18:31:52] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Shop, Unplanned-Sprint-Work: Fix login issue with Shopify store - https://phabricator.wikimedia.org/T134796#2277426 (awight) Open>Resolved Great, thank you!
[18:33:44] <ejegg>	 awight: so... pending_paypal is only written to + read from within the same process? I can't see what consumes messages that we somehow failed to verify the first time.
[18:34:06] <awight>	 I'm not sure about that queue.
[18:34:11] <awight>	 I'd believe it's a loopback though
[18:34:25] <awight>	 Probably the old message archiver is its consumer of last resort
[18:34:28] <awight>	 if that's what you mean?
[18:34:46] <ejegg>	 Yeah, I don't think anything else reads from it
[18:34:55] <awight>	 scandalous...
[18:35:11] <ejegg>	 So it's like a place to put messages in case of error, but the leftovers are never examined
[18:35:14] <awight>	 I feel like we're trimming one hell of a polyp
[18:35:21] <awight>	 aha
[18:36:02] <ejegg>	 unless there's something in paypal audit processing...
[18:36:21] <awight>	 nope
[18:36:50] <ejegg>	 the correlation id is randomly generated in the IPN listener
[18:36:55] <awight>	 ejegg: fwiw, I'm medium-confident that the second table on the Message queues page does capture all of the places we touch queues
[18:37:24] <ejegg>	 heh, with blanks and questionmarks for pending_paypal*
[18:38:44] <ejegg>	 awight: I'm writing https://www.mediawiki.org/wiki/Fundraising_tech/Pending_queue_consumers
[18:38:55] <ejegg>	 to figure out just what kind of indexes we'd use
[18:39:55] <ejegg>	 oh, I should include the limbo queues you've marked as
[18:40:03] <ejegg>	 deprecate in favor of pending
[18:40:34] <awight>	 ejegg: well the first table has question marks, but not the second
[18:40:49] <ejegg>	 ohh, got it!
[18:41:06] <awight>	 at least, I was hoping the second table would be an exhaustive inventory of code that does (de)queueing
[18:41:54] <awight>	 I see you're doing a much better job of documenting in that new page though.  Awesome!
[18:42:12] <ejegg>	 just trying to get the id formats nailed down
[18:42:56] <ejegg>	 so yeah, it's only the pp listener that does anything with the pending_paypal queues
[18:43:08] <ejegg>	 and... it seems to be basically write-only
[18:43:16] <ejegg>	 till the expiration job
[18:43:32] <ejegg>	 where did you get the '20% of messages are ever read'?
[18:44:18] <awight>	 Just from a napkin calculation on the enqueued vs dequeued ratio
[18:44:30] <awight>	 So it's only valid for this incarnation of the ActiveMQ process...
[18:44:39] <ejegg>	 oh huh, so that includes the expiration job
[18:44:55] <awight>	 *no* idea how anything dequeued--didn't you just add that queue to the archive job a few weeks ago?
[18:45:06] <awight>	 Maybe that 20% came from a manual cleanout years ago.
[18:45:20] <ejegg>	 oh yeah, that was just taking up space
[18:45:21] <awight>	 gave me the jeebies, is all I know
[18:45:42] <ejegg>	 or... hm, there's code to delete the message after successful validation
[18:45:49] <ejegg>	 but I guess that's not always reached
[18:46:37] <ejegg>	 still, this is successful validation within the same IPN message processing thread
[18:47:14] <ejegg>	 totally useless unless we wanted to do something with them manually
[18:47:29] <awight>	 gack
[18:47:45] <awight>	 That would be a nice outcome, to remove the message queueing entirely
[18:48:25] <ejegg>	 yep!
[18:48:52] <ejegg>	 If they're cool, they'll resend when we don't give them a 200
[18:49:38] <ejegg>	 ok, i'mma grab some lunch
[19:57:54] <grrrit-wm>	 (PS4) Ejegg: Pending table schema [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197)
[19:58:47] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-PayPal-ExpressCheckout, FR-Paypal: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2277796 (awight) a:awight
[20:11:48] <ejegg>	 dstrine: XenoRyet|afk cwd|afk anybody for standup?
[20:12:20] <dstrine>	 ejegg:  I am tied up in another meeting :(
[20:12:30] <dstrine>	 awight|mtg:  is around
[20:12:43] <ejegg>	 ok, no worries!  Wanted to make sure we were in the right channel
[20:19:57] <ejegg>	 Gerrit-be-nice-to-me Chrome extension: https://chrome.google.com/webstore/detail/gerrit-be-nice-to-me/oafiggfcmbkeopoihflmjkhlligaefcd
[20:39:06] <awight>	 AndyRussG: just shared the Privacy by Design doc w u
[20:40:08] <grrrit-wm>	 (PS5) Awight: Pending table schema [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[20:42:26] <grrrit-wm>	 (CR) Awight: [C: -1] "More tiny criticisms." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[20:45:56] <grrrit-wm>	 (PS6) Ejegg: Pending table schema [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197)
[20:46:34] <grrrit-wm>	 (CR) Ejegg: Pending table schema (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[20:48:11] <grrrit-wm>	 (CR) Awight: [C: 2] "Hehe, finally enough slop to make me happy." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[20:49:47] <grrrit-wm>	 (Merged) jenkins-bot: Pending table schema [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287042 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[21:09:25] <grrrit-wm>	 (PS4) Ejegg: Job runner for generic queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (https://phabricator.wikimedia.org/T133965)
[21:11:10] <AndyRussG>	 awight: cool thx!
[21:17:51] <grrrit-wm>	 (PS5) Ejegg: Job runner for generic queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (https://phabricator.wikimedia.org/T133965)
[21:17:53] <grrrit-wm>	 (PS1) Ejegg: Use config for maintenance defaults [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287754
[21:30:19] <grrrit-wm>	 (CR) Awight: [C: 2] "Yes! Seems to be just what we need. I'm curious how we invoke a QueueConsumer, but that can come in a later patch." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:30:30] <grrrit-wm>	 (PS9) Awight: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:30:53] <grrrit-wm>	 (PS5) Awight: Damaged message queue for QueueConsumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:35:33] <wikibugs>	 fundraising-tech-ops: Blank page at https://payments.wikimedia.org - https://phabricator.wikimedia.org/T134818#2278255 (Krenair) that's in frack  also it seems to be using non-standard MW URLs?
[21:36:20] <grrrit-wm>	 (CR) Awight: [C: 2] Damaged message queue for QueueConsumer (4 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:37:35] <grrrit-wm>	 (CR) Awight: Damaged message queue for QueueConsumer (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:38:38] <grrrit-wm>	 (Merged) jenkins-bot: QueueConsumer for AtomicReadBuffers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/286718 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:38:40] <grrrit-wm>	 (Merged) jenkins-bot: Damaged message queue for QueueConsumer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287288 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:46:09] <grrrit-wm>	 (PS2) Ejegg: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197)
[21:46:24] <ejegg>	 relocating, be back soon
[21:46:27] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[22:07:52] <grrrit-wm>	 (Abandoned) Awight: [DO NOT MERGE] Calculate opt-outs using change log [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282304 (https://phabricator.wikimedia.org/T122411) (owner: Awight)
[22:07:57] <grrrit-wm>	 (PS7) Awight: Unsubscribe old emails; fix is_primary bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411)
[22:08:43] <awight>	 ejegg|afk: I was wrong about which was active... ^ should be correct now
[22:25:10] <wikibugs>	 fundraising-tech-ops: Blank page at https://payments.wikimedia.org - https://phabricator.wikimedia.org/T134818#2278676 (Platonides) yes, I also noticed their ~~heresy ~~ugly urls.
[22:28:16] <wikibugs>	 fundraising-tech-ops: Blank page at https://payments.wikimedia.org - https://phabricator.wikimedia.org/T134818#2278220 (awight) Thanks for creating this task!  The best redirect would probably be to https://donate.wikimedia.org/  Looping in @Pcoombe for confirmation...
[22:30:24] <awight>	 ejegg: I'm blocked on PayPal stuff for the moment--how can I be most helpful with the queues?  CR?
[22:30:57] <ejegg>	 sure, if there's anything you haven't reviewed yet!
[22:31:07] <ejegg>	 I'm just addressing some of your latest comments
[22:31:26] <grrrit-wm>	 (PS2) Awight: Use config for maintenance defaults [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287754 (owner: Ejegg)
[22:32:02] <grrrit-wm>	 (CR) Awight: [C: 2] "Fancy!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287754 (owner: Ejegg)
[22:32:10] <grrrit-wm>	 (PS6) Awight: Job runner for generic queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[22:33:51] <grrrit-wm>	 (Merged) jenkins-bot: Use config for maintenance defaults [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287754 (owner: Ejegg)
[22:39:42] <grrrit-wm>	 (PS1) Ejegg: Use key as default queue name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287782
[22:40:11] <awight>	 Aww, I get   fatal: reference is not a tree: d1daf1ae268c47ce3f946da4d9b434696ef6ee0f
[22:40:24] <awight>	 trying to composer install the amzn library for SmashPig
[22:40:32] <ejegg>	 oh dang
[22:41:20] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Use key as default queue name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287782 (owner: Ejegg)
[22:41:40] <awight>	 no worries, I'll hack it out for now
[22:41:51] <awight>	 it could be my old composer...
[22:42:56] <ejegg>	 shoot, I definitely didn't mean to update .lock
[22:43:10] <ejegg>	 also, having trouble finding that rev anywhere local even
[22:44:10] <ejegg>	 what the heck?
[22:44:32] <ejegg>	 ohhh.. I bet I did back-alley surgery on the wrong dependency revision
[22:44:43] <ejegg>	 it's probably a php-queue rev
[22:45:03] <ejegg>	 yep
[22:45:11] <ejegg>	 fixing...
[22:48:27] * awight adjusts blinders
[22:48:56] <grrrit-wm>	 (PS1) Ejegg: Fix bungled composer.lock refs [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287786
[22:49:57] <grrrit-wm>	 (CR) Awight: [C: 2] "I jiggled some local config and... it mostly worked!" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[22:50:06] <ejegg>	 shoot, gotta rest my arm for a bit
[22:50:16] <awight>	 wounded?
[22:50:21] <ejegg>	 and bring the ergo kb onto the porch
[22:50:36] <ejegg>	 just been doing too much typing right on the lil lappy kb
[22:50:42] <awight>	 yuck!
[22:50:49] <ejegg>	 back in 15 or so!
[22:51:20] <grrrit-wm>	 (CR) Awight: [C: 2] "Works now." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287786 (owner: Ejegg)
[22:56:58] <grrrit-wm>	 (Merged) jenkins-bot: Job runner for generic queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287044 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[22:57:00] <grrrit-wm>	 (Merged) jenkins-bot: Fix bungled composer.lock refs [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287786 (owner: Ejegg)
[23:06:46] <wikibugs>	 fundraising-tech-ops: Norton-secured shield on payments.wikimedia.org - https://phabricator.wikimedia.org/T134824#2278841 (Krenair)
[23:09:39] <wikibugs>	 fundraising-tech-ops: Norton-secured shield on payments.wikimedia.org - https://phabricator.wikimedia.org/T134824#2278404 (awight) Thanks for the heads-up on that link!Our information about the lock is outdated enough to be anecdotal, but department wisdom is that donors really like seeing the lock, for no r...
[23:22:10] <awight>	 Anyone seen this CentralNotice error before? --  Call to undefined method ObjectCache::getMainStashInstance
[23:23:20] <awight>	 ugh nvm
[23:23:57] <awight>	 It's cos my mediawiki-core is on the payments branch
[23:24:02] <awight>	 I was not thinking
[23:25:17] <ejegg>	 one more fix for php-queue: https://gerrit.wikimedia.org/r/287286
[23:25:38] <ejegg>	 gotta catch the ex a little earlier for jit table creation
[23:30:41] <AndyRussG>	 awight: ejegg: I started looking at https://gerrit.wikimedia.org/r/#/c/282106 but it's clear to me that I can't say much without understanding the workings of a lot of stuff that I really know very little about
[23:31:12] <ejegg>	 ah, I think I'm about ready to +2 that one
[23:31:21] <ejegg>	 I'll give it one more lookover
[23:31:23] <AndyRussG>	 ejegg: ah K that's good to hear!
[23:31:54] <AndyRussG>	 I mean, I'm happy to learn what's needed if silverpop review is where it's at, but it'd take a while
[23:32:20] <ejegg>	 heh, no worries
[23:32:33] <awight>	 AndyRussG: I'm trying to give https://gerrit.wikimedia.org/r/#/c/285336/ some CR... still floundering with my mediawiki, unfortunately.
[23:32:59] <awight>	 But I'll try to create some legacy count cookies then run your patch, if that sounds like a useful test?
[23:33:12] <AndyRussG>	 awight: ah cool beans! many thx in advance
[23:33:45] <AndyRussG>	 awight: that's easy btw... just checkout master and enable a campaign w/ banner diet
[23:34:49] <AndyRussG>	 then temporarily hack kvStore.isAvailable() to always return false
[23:35:35] <AndyRussG>	 Then set $wgCentralNoticeCategoriesUsingLegacy to include the name of your test campaign
[23:35:50] <AndyRussG>	 then visit ur local site
[23:36:15] <AndyRussG>	 That should get you some authentic legacy biscuits
[23:36:40] <awight>	 excellent, thanks for the breadcrumbs!
[23:37:08] <AndyRussG>	 awight: likewise, looking forward to excellent scathing critiques
[23:37:40] <AndyRussG>	 https://phabricator.wikimedia.org/project/board/1977/query/WCLwAqk3Yzie/
[23:37:46] <awight>	 haha hardly
[23:37:59] <AndyRussG>	 ^ (current sprint filtering for DI)
[23:38:30] <awight>	 Yeah I hope that stuff lands safely...
[23:38:35] <AndyRussG>	 I'm much happier to grab a DI patch to review, since I already know a decent amount about that part of our systemz, learning curve'd be less steep
[23:38:48] <AndyRussG>	 Gotta sup! I'll get backsckrill though... thx again! :)
[23:38:49] <grrrit-wm>	 (PS2) Ejegg: Use key as default queue name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287782
[23:38:54] <awight>	 That sounds great to me
[23:39:11] <AndyRussG|souper>	 cool thx!
[23:39:17] * awight O_os at "backskrill"
[23:41:13] <grrrit-wm>	 (CR) Awight: [C: 2] "Oh! Mebbe this was a MySQL 5.7 change..." [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287286 (owner: Ejegg)
[23:42:45] <ejegg>	 heh, is that when you look back at the log of shrimp prawning?
[23:43:00] <grrrit-wm>	 (Merged) jenkins-bot: Catch prepare($sql) exceptions on missing table [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287286 (owner: Ejegg)
[23:44:28] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice default campaign date is in the wrong timezone - https://phabricator.wikimedia.org/T134833#2279004 (awight)
[23:48:30] <awight>	 I'm thinking it's when someone on IRC owes you money
[23:50:24] <awight>	 Argh, looks like I have good choiceData, but no banner.  mw.centralNotice.choiceData = [{"name":"c1","start":1462143660,"end":1464307260,"preferred":1,"throttle":100,"bucket_count":1,"geotargeted":false,"banners":[{"name":"b1","bucket":0,"weight":25,"category":"c1","display_anon":true,"display_account":true,"devices":["desktop"]}],"mixins":{"impressionDiet":{"cookieName":"cook1","maximumSeen"
[23:50:30] <awight>	 :10,"restartCycleDelay":0,"skipInitial":0}}}];mw.loader.state( {
[23:53:08] <awight>	 gotta commute.  I'll shuffle around a bit more later tonight...