[00:13:44] (CR) Ejegg: "Found a few problems" (4 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [00:14:10] (CR) Ejegg: [C: -1] Unsubscribe old emails; fix is_primary bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [00:16:09] (PS3) Ejegg: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) [00:23:32] (PS4) Ejegg: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) [00:23:34] (PS1) Ejegg: Fix defaults for QueueJobRunner [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287871 [00:29:55] (PS1) Ejegg: Rearrange processing wrapper for dequeue loop [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287872 [00:38:37] (CR) Ejegg: [C: -1] "I'm spooked that this passes tests... some of the adapters (e.g. Amazon) never even call parent::do_transaction" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287155 (owner: Awight) [00:45:36] (CR) Ejegg: "How about this to guarantee fresh staged data on demand without too much flapping: addRe*Data() clears out the staged array, and getData_s" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287155 (owner: Awight) [00:45:56] good evening all! [06:08:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Language lists have diverged in CentralNotice campaign admin - https://phabricator.wikimedia.org/T134844#2279536 (awight) [06:10:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Language lists have diverged in CentralNotice campaign admin - https://phabricator.wikimedia.org/T134844#2279548 (awight) It's possible that I upgraded MediaWiki core or CLDR, but that scenario is also likely to take place on production s... [06:11:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Language lists will diverge in CentralNotice campaign admin - https://phabricator.wikimedia.org/T134844#2279549 (awight) [06:43:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: New GeoIP service endpoint that returns JSON, not JSONP - https://phabricator.wikimedia.org/T134845#2279567 (awight) [07:32:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: New GeoIP service endpoint that returns JSON, not JSONP - https://phabricator.wikimedia.org/T134845#2279608 (awight) As you can tell, I barely know enough about CORS to write this bug. But I changed the ext.centralNotice.geoIP.js ajax call to use... [07:40:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: New GeoIP service endpoint that returns JSON, not JSONP - https://phabricator.wikimedia.org/T134845#2279609 (awight) This is a known bug in jQuery 1.x, see Krinkle's work here! https://github.com/jquery/jquery/issues/2413 [08:26:30] (CR) Awight: [C: -1] "I just started testing, and the following things seem to work correctly:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [08:28:38] (CR) Awight: "gargh." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [08:34:45] (CR) Awight: "We could eliminate the cons by making damaged queue rejection the only behavior :) It sort of is the only correct thing to do, in softwar" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287872 (owner: Ejegg) [12:25:54] (CR) Aklapper: "@AWight / @MWalker: Who can decide on this patch (merge; re-review; abandon; add "[WIP]" prefix)?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/110047 (owner: Mwalker) [12:25:59] (CR) Aklapper: "@AWight: Who can decide on this two-liner patch (merge; re-review; abandon; add "[WIP]" prefix)? This patch has been sitting in Gerrit for" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 (owner: Awight) [12:59:26] fundraising-tech-ops: Blank page at https://payments.wikimedia.org - https://phabricator.wikimedia.org/T134818#2280490 (Pcoombe) Redirecting to https://donate.wikimedia.org/ sounds sensible to me [13:01:11] (CR) Ejegg: "Hmm, you don't think the right behavior is ever to bail out of the loop (leaving the failed message on the regular queue)? Seems like it'" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287872 (owner: Ejegg) [13:09:17] (PS1) Ejegg: PDO: create/delete table doesn't need arg [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287942 [13:09:24] Fundraising Tech Backlog, Fundraising-Backlog, Design-Research-Backlog, MediaWiki-extensions-DonationInterface, Design Research and product team collaboration: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#2280560 (Pcoombe) @awight I don'... [13:11:18] (CR) jenkins-bot: [V: -1] PDO: create/delete table doesn't need arg [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287942 (owner: Ejegg) [13:57:39] (CR) Ejegg: "recheck" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/287942 (owner: Ejegg) [17:27:08] (CR) Ejegg: [C: 1] "Huzzah for more encapsulation! And it seems to work. But this feels like it's not exactly staging. How about a RequestAuthenticationProvid" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287159 (owner: Awight) [17:36:48] (PS2) Ejegg: Adjust hook in our CiviCRM to reflect name change in upstream QA [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286378 (https://phabricator.wikimedia.org/T133257) (owner: Eileen) [17:37:13] (CR) Ejegg: [C: 2] "Better name!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286378 (https://phabricator.wikimedia.org/T133257) (owner: Eileen) [17:39:02] (Merged) jenkins-bot: Adjust hook in our CiviCRM to reflect name change in upstream QA [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/286378 (https://phabricator.wikimedia.org/T133257) (owner: Eileen) [17:49:57] Fundraising-Backlog: Deploy config files from git - https://phabricator.wikimedia.org/T121443#2281882 (cwdent) @Jgreen did this just get incidentally resolved? [17:50:05] (CR) Awight: "I think I'm confused about which type of cookies we're migrating with this patch. Running with kvStorage hacked to think that I don't hav" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [17:51:12] Fundraising-Backlog: Deploy config files from git - https://phabricator.wikimedia.org/T121443#1879056 (awight) Is this a duplicate of T113301 ? [17:53:01] Fundraising-Backlog: Deploy config files from git - https://phabricator.wikimedia.org/T121443#2281889 (cwdent) [17:53:03] Fundraising-Backlog, fundraising-tech-ops: Finish config file centralization for Fundraising systems - https://phabricator.wikimedia.org/T113301#2281891 (cwdent) [17:54:57] (CR) Awight: "That sounds good--but wouldn't that interface have the same method signature as a staging helper? I'm also uneasy about assuming that aut" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287159 (owner: Awight) [18:08:27] (PS6) Awight: bump PayPal "classic api" version [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 [18:09:00] (CR) Awight: "fr-tech: This should be good to go, see the reference to confirm that 124 is the latest API version:" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 (owner: Awight) [18:16:20] (Abandoned) Awight: Remove HTML Entities from Civi Contacts Table [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/110047 (owner: Mwalker) [18:25:02] (CR) Awight: Unsubscribe old emails; fix is_primary bug (4 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [18:29:42] Fundraising Tech Backlog: another round of activemq queue decrufting needed - https://phabricator.wikimedia.org/T134916#2282095 (Jgreen) [18:31:46] (CR) Ejegg: [C: 1] "Looks good! Now that I've merged the civi patch, want to roll a submodule update in with this one just to make sure they don't get separa" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/286379 (https://phabricator.wikimedia.org/T133257) (owner: Eileen) [18:42:46] Is the crm master in working condition? I'm getting burned by \nFatal error: Cannot access private property Civi\\Core\\Transaction\\Frame::$state [18:49:38] (PS8) Awight: Unsubscribe old emails; fix is_primary bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) [19:20:38] (CR) Ejegg: [C: 2] "Yes! This looks like the silver bullet." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [19:20:56] (Merged) jenkins-bot: Unsubscribe old emails; fix is_primary bug [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/282106 (https://phabricator.wikimedia.org/T122411) (owner: Awight) [19:22:34] (CR) AndyRussG: "Thx @Awight!! Here are some replies:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [19:23:13] (PS1) Ejegg: Aggregate contact ID in select (MySQL 5.7 fix) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/288030 [19:43:34] (PS1) Ejegg: WIP popAtomic for Stomp [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/288037 [20:00:10] (CR) Ejegg: [C: 1] "cool! Since the clauses ensure distinct-ness, would UNION ALL be even faster?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [20:03:14] ejegg: AndyRussG meeting? [20:03:20] dstrine: yeah coming! [20:03:32] dstrine: hah thought it was at 4:03... [20:04:01] oh sorry I guess this one starts 3 minutes earlier :P [20:04:09] I can change it later [20:04:59] sorry, I'll be on in a sec! [20:09:47] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-WMF-Audit: Update audit parser for PayPal Express Checkout - https://phabricator.wikimedia.org/T134605#2282549 (DStrine) p:Triage>Normal [20:14:41] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Review actions taken for various Ingenico error codes - https://phabricator.wikimedia.org/T134449#2282568 (awight) [20:15:40] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Review actions taken for various Ingenico error codes - https://phabricator.wikimedia.org/T134449#2282571 (DStrine) p:Triage>Normal [20:16:30] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Clean up confusing and repeated code in the PayPal express adapter - https://phabricator.wikimedia.org/T134445#2282579 (awight) p:Triage>Normal [20:17:11] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Extract processResponse call from do_transaction_internal - https://phabricator.wikimedia.org/T134421#2282592 (awight) p:Triage>Normal [20:17:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Helper for transaction response errors - https://phabricator.wikimedia.org/T134420#2282597 (awight) p:Triage>Normal [20:18:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Failure to queue a message should prompt a dramatic attempt to rescue the data - https://phabricator.wikimedia.org/T134322#2282600 (awight) [20:18:45] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Failure to queue a message should prompt a dramatic attempt to rescue the data - https://phabricator.wikimedia.org/T134322#2282602 (DStrine) p:Triage>Normal [20:25:02] Fundraising-Backlog, fundraising-tech-ops: Strine needs access to lutetium (spelling?) - https://phabricator.wikimedia.org/T134511#2282618 (Jgreen) I will set up your account and follow up with you via IRC/email with some setup steps. We also need to have OIT issue you a yubikey, I can get that request s... [20:30:33] Fundraising-Backlog, fundraising-tech-ops: Strine needs access to lutetium (spelling?) - https://phabricator.wikimedia.org/T134511#2282660 (Jgreen) the OIT ticket is #10831 [20:31:10] (CR) Eileen: "Interesting - I didn't know about UNION ALL - I leanrt something." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [20:36:38] (PS7) Cdentinger: bump PayPal "classic api" version [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 (owner: Awight) [20:58:04] AndyRussG: soo... I've checked out CentralNotice HEAD^, my campaign is in the legacy category, and I've enabled impressionDiet. Not seeing these cookies yet... [20:58:08] I'll keep digging around [20:58:36] awight: are u sure it's in legacy [20:58:50] HEAD^ on which branch? [20:58:56] U can just get master [20:59:03] ok [20:59:32] Also your impressionDiet needs an identifier in that case [20:59:42] That was the only way u could get a legacy diet cookie [21:00:00] I have one--the cookie I get however is impression_diet_cook1 which I believe is a newer cookie [21:00:04] and there's no -wait cookie [21:00:20] The legacy cookie would just be "cook1" and "cook1-wait", right? [21:01:39] awight: yeah u should get both [21:01:42] confirmed that CN gets useCookies=true, so it's picking up the legacy flag [21:01:43] Which browser are you using? [21:02:17] FF dev tools have been all wonky for me, had to use Chrome [21:02:22] to get good cookie info [21:02:44] Looks like a scope problem [21:02:50] Lots of times in FF resources panel, cookies listed are document.cookie are not the same [21:03:02] But I don't understand why [21:03:17] When I stepped into storeCounts, useCookies was suddenly false... doing that again now. [21:03:46] Sorry are you on master or on the new patches? [21:04:05] First let's make sure you've got good legacy cookies--should indeed have both cook1 and cook1-wait [21:05:14] On the old master, useCookies should not be getting weird values... [21:05:19] Sorry--okay the issue was that I had kvStoreCounts data, so that unset the useCookies flag at impressionDiet.js line 209 [21:05:21] Maybe you have more than one local campaign? [21:05:34] I'll kill the kvStore again [21:06:09] awight: aaaah yeah that was another old complication that should soon slip into amnesia land [21:06:32] That was 'cause bye accident at one time we migrated some FR campaigns to LS, and we didn't want to un-migrate [21:06:49] Sorry I forgot about that one! [21:06:53] will clear localStorage... [21:07:00] K [21:08:20] got em! [21:08:54] cool! [21:18:51] (CR) Awight: [C: 2] "Note to self, the legacy cookies look like:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [21:18:56] (PS13) Awight: Mixed storage for impression diet and large banner limit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285336 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [21:19:08] (PS7) Awight: Mixed storage for buckets [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/285571 (https://phabricator.wikimedia.org/T132639) (owner: AndyRussG) [21:20:10] (CR) Cdentinger: [C: 2] bump PayPal "classic api" version [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 (owner: Awight) [21:20:16] Heh yeah those were the legacy dayz [21:20:53] (Merged) jenkins-bot: bump PayPal "classic api" version [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 (owner: Awight) [21:21:55] When cookies were cookies, buckets were buckets and LocalStorage was just a fantasious glimmer in the eyes of dreamers gazing into the firey purple sunset [21:23:51] Always carry a towel! [21:27:17] For wiping away big wet LocalStorage tears [21:28:31] (CR) Awight: [C: 2] Aggregate contact ID in select (MySQL 5.7 fix) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/288030 (owner: Ejegg) [21:28:34] (PS2) Awight: Aggregate contact ID in select (MySQL 5.7 fix) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/288030 (owner: Ejegg) [21:29:30] AndyRussG: OK I'll do similar QA for the bucket patch... [21:29:58] awight: cool beans thx!! Note that in that case your campaign doesn't have to be in Legacy to get cookies in the new code [21:30:09] I'm experiencing a slow query on dev that I don't think is on live [21:30:22] what kind of query? [21:30:26] Great--it looks pretty straightforward, thanks to breadcrumbs about versions [21:30:31] I can figure out why it's slow (it's getting the count for the activities tab) [21:30:45] but all the code I look at that relates to it seems untouched [21:30:48] does explain reveal anything? [21:30:50] huh, for a single contact? [21:31:10] (the code you reviewed last week hasn't gone out to live) [21:31:47] yeah single contact - 3000+ activities but still [21:31:50] (contact is me) [21:32:20] actually perhaps that's it. I have done a bunch of merges & hence have activities causing this to show up [21:32:20] gonna relocate, back in a bit [21:33:15] OK - other contacts load faster - so likely pre-existing point of slowness but now affects my record [21:33:35] (CR) Ejegg: [C: 2] Formatting, comments, robustness [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287160 (owner: Awight) [21:33:52] (I can fix it but trying to decide if it should hold up deploying new code / be a prioritiy) [21:37:54] I doubt the power users look at their own records too much [21:38:00] I wouldn't worry about it [21:38:13] yeah - I'll leave it for now [21:38:22] I can load other people's records fine [21:38:53] there has been some fall out from those security patches so I was trying to check if we were affected in any way [21:39:10] albeit config-specific fallout [21:40:20] here https://github.com/civicrm/civicrm-core/pull/8301 [21:47:41] back later! [22:00:53] (CR) Ejegg: "Looks pretty straightforward! Might have swapped || for &&" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/287289 (https://phabricator.wikimedia.org/T132640) (owner: AndyRussG) [22:01:44] oh hey, doors opening in a minute. Back in a while! [22:42:40] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/288111 [23:45:46] (PS2) Cdentinger: Remove unused astropay js [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287039 (owner: Ejegg) [23:48:50] (CR) Cdentinger: [C: 2] Remove unused astropay js [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287039 (owner: Ejegg) [23:50:51] (Merged) jenkins-bot: Remove unused astropay js [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287039 (owner: Ejegg) [23:51:40] (PS2) Cdentinger: Remove unused css resources [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287040 (owner: Ejegg) [23:53:40] (CR) Cdentinger: [C: 2] Remove unused css resources [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287040 (owner: Ejegg) [23:54:59] (Merged) jenkins-bot: Remove unused css resources [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287040 (owner: Ejegg) [23:56:31] (PS1) Awight: Bump version minor during cookie migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/288135