[00:00:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Consider pre-upgrading some queries for 4.7 - https://phabricator.wikimedia.org/T135084#2287786 (Eileenmcnaughton) [00:05:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Consider pre-upgrading some queries for 4.7 - https://phabricator.wikimedia.org/T135084#2287808 (Eileenmcnaughton) [00:10:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Consider pre-upgrading some queries for 4.7 - https://phabricator.wikimedia.org/T135084#2287825 (Eileenmcnaughton) [00:13:10] https://www.youtube.com/watch?v=XazXyL-Ybjo - WMF Executive Director Office Hours [01:13:16] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2287887 (AndyRussG) [01:13:18] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2287885 (AndyRussG... [01:15:17] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Make a plan for moving stuff out of cookies - https://phabricator.wikimedia.org/T131319#2162834 (AndyRussG... [01:18:04] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 2 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2287923 (... [01:23:54] (CR) Cdentinger: "It appears that curl sends the expect header if the body is >1kb, so is it better to strip that or accept/ignore the continue header? Sin" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 (https://phabricator.wikimedia.org/T134586) (owner: Awight) [01:36:44] Fundraising Sprint Jabberwock Slaying: CentralNotice: finalize list of wild useless cookies for slurp, and push config change - https://phabricator.wikimedia.org/T135090#2287937 (AndyRussG) [01:37:13] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: CentralNotice: finalize list of wild useless cookies for slurp, and push config change - https://phabricator.wikimedia.org/T135090#2287951 (AndyRussG) [01:38:57] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 2 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2287953 (... [01:39:52] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 2 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete them - https://phabricator.wikimedia.org/T132640#2205231 (... [07:20:08] (CR) XenoRyet: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [15:36:43] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2289418 (Jgreen) The tables are alre... [16:14:45] (PS4) Cdentinger: Adyen form for Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [16:27:19] Fundraising Sprint Jabberwock Slaying: Give CIVICRM ADMIN and FR Tech permission to Delete activities - https://phabricator.wikimedia.org/T135076#2289634 (CaitVirtue) Yes, i see it and it works. Thanks! [16:37:00] awight: looks like mysql was stopped on the CI host [16:37:16] is why 5.3 test was failing [17:01:44] oh wow, thanks for finding that! [17:44:33] cwd: awight|orientati ejegg AndyRussG any thoughts on my adyen email? [17:44:59] looking now... [17:45:05] yeah i was looking at it, then CI was broken [17:45:14] dstrine: also looking... [17:45:21] cwd: oh sorry :( [17:45:40] it's fixed now, it just would have prevented that patch from merging [17:45:54] Ah, I'll take another look at the patch! [17:47:03] thanks all... any work on this gets us closer to a possible france alternative ... also the Israel campaign is now on 5/31. so we don't have a ton of time to test. [17:47:25] ejegg, the only thing i was wondering about is if overrides would be cleaner than duplication here: https://gerrit.wikimedia.org/r/#/c/286949/4/adyen_gateway/config/payment_submethods.yaml [17:47:55] but i am loath to put more config in the controller code [17:48:25] and not sure how it would get structured as further config [17:48:31] Right, I think we don't want to add more payment submethod keys [17:48:45] Since those have to be added in SmashPig and CRM too [17:50:08] I think the simplest solution would be to override something to mutate the config in memory [17:50:50] yeah [17:51:28] it would be nice if it wasn't a magic word in the controller but that probably doesn't really matter [17:52:26] Well, I was thinking of another config file [17:52:43] like address_required.yaml [17:56:30] What's the condition? address is required depending on country? [17:57:50] i think so? [17:58:05] ejegg: cwd: That looks like custom business logic -> override function, no? [17:58:57] yeah [17:59:50] nuts. I have to do a chicken food errand... [18:00:04] garbage empty? [18:00:10] hehehe [18:00:13] food for chicken or chickens for food? [18:00:20] The culture orientation was good, I'd recommend it to anyone who hasn't done one yet [18:00:21] or food for chickens for food? [18:00:34] cool! [18:00:53] (CR) Ejegg: [C: -1] "Let's not add the extra submethod codes, since those carry through the whole pipeline (SmashPig, DonationInterface). Also, I think this st" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [18:00:58] It's a good question--If I drive directly away from San Francisco, the food is 50# for $12. If I drive to Berkeley instead, it's $40 and organic. people food essentially [18:06:54] cwd: does that suggestion seem good to you? [18:15:47] ejegg: sorry i was helping a random woman strap a dog house to her car roof [18:16:06] yeah i like that, good balance of normalized but still readable [18:16:10] the dog likes it up there! [18:16:20] hehehe [18:16:29] wasn't that mitt romney? [18:16:31] yah [18:16:52] so good [18:17:26] he wasn't so hard to take down... [18:19:38] (PS1) Ejegg: Add order ID to pending queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 [18:25:34] (PS2) Ejegg: WIP popAtomic for Stomp [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/288037 [18:34:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2290266 (Jgreen) Open>Resolved this is done [18:42:24] (PS1) Ejegg: Add order ID to fake pending messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288448 [18:43:20] (PS6) Ejegg: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) [18:43:22] (PS3) Ejegg: Fix defaults for QueueJobRunner [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287871 [18:43:24] (PS1) Ejegg: Ensure numeric time and message limits [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) [19:01:25] (PS3) Ejegg: WIP popAtomic for Stomp [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/288037 [19:09:07] (CR) jenkins-bot: [V: -1] WIP popAtomic for Stomp [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/288037 (owner: Ejegg) [19:17:48] fundraising-tech-ops, Operations, Ops-Access-Requests: Frack (boron and bismuth) access for Darian Patrick - https://phabricator.wikimedia.org/T135165#2290365 (Jgreen) p:Triage>High a:Jgreen [19:20:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2290375 (Jgreen) Civi generates a sql script to set up triggers, and we've discussed storing that in gerrit as the canonical source of trigger happiness.... [19:20:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2290376 (Jgreen) p:Triage>Normal [19:21:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Deploy Redis 3 to frack - https://phabricator.wikimedia.org/T120464#2290378 (Jgreen) p:Triage>High [19:21:55] Fundraising-Backlog, fundraising-tech-ops: Strine needs access to lutetium (spelling?) - https://phabricator.wikimedia.org/T134511#2290379 (Jgreen) Open>Resolved the access part is ready to go but we still have a little desktop setup to do, closing this ticket in the meantime [19:25:50] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 4 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2290397 (awight) [19:25:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Deploy Redis 3 to frack - https://phabricator.wikimedia.org/T120464#2290396 (awight) [19:26:14] (CR) Catrope: [C: 2] Use GUI read-only errors instead of DB class errors [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/284217 (owner: Aaron Schulz) [19:30:18] (Merged) jenkins-bot: Use GUI read-only errors instead of DB class errors [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/284217 (owner: Aaron Schulz) [19:41:50] ejegg: Want to chat about queue backend? Jeff grabbing that Redis 3 task was a good wake-up call... [19:42:09] sure! [19:42:59] Lessee. I think the main requirements are maintainability and stability. [19:43:46] failover, good PHP API [19:44:12] Not to be all processy, but what's a good way to put down our notes? Maybe a spreadsheet? [19:44:28] sure, I'll make a gdoc [19:46:27] and yeah totally, thanks--high availability is a must have [19:46:53] Although I think we're willing to do manual failover as long as there's something like replication, so that a backup is always warm [19:48:35] ok, that works for me [19:49:48] A sad concession to reality... [19:50:39] For those playing at home: https://docs.google.com/spreadsheets/d/1V2UpHdTH4FaTRQ3SZOoTikyA8HHsjTEYwxMNHu9YsCI/edit?ts=5734dd9c#gid=0 [19:51:18] thx! [19:52:37] we're ruling out any other JMS backend/client? [19:55:32] I don't think we need to rule anything out [19:55:40] other than MySQL [19:55:44] and ActiveMQ [20:04:39] (CR) Jdlrobson: "I'm having a cleanup of Gerrit and this patch is still open. Any value in keeping this 1 year old WIP?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/105159 (owner: Awight) [20:05:45] (PS3) Jdlrobson: WIP: (FR #1285) Munge logs for source metadata [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/105159 (owner: Awight) [20:07:04] be at standup in one sec... [20:13:15] (CR) Jdlrobson: "Still a WIP almost 3 years later?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/97891 (owner: Awight) [20:19:35] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2290605 (Eileenmcnaughton) @awight a... [20:33:51] ccogdill: heads up, I'm going to try deploying the fixes for T122411, and will run the export job to test it [20:33:51] T122411: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411 [20:33:59] weeeeee [20:34:02] can’t wait, thanks awight [20:36:30] Fundraising Sprint Jabberwock Slaying: Give CIVICRM ADMIN and FR Tech permission to Delete activities - https://phabricator.wikimedia.org/T135076#2290652 (Eileenmcnaughton) Open>Resolved [20:36:49] (Abandoned) Awight: WIP: DonationInterface refactor: pull all the declarative stuff together [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/65003 (owner: Awight) [20:37:03] (CR) Awight: [C: -2] [WIP] GatewayAdapter::isSupported [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64872 (owner: Awight) [20:37:39] (Abandoned) Awight: [WIP] Refactor controller logic into adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63932 (owner: Awight) [20:38:03] (CR) Awight: [C: -2] WIP tests for the return_value_map [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/86790 (owner: Awight) [20:38:08] (CR) Awight: [C: -2] WIP dedupe report [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/93429 (owner: Awight) [20:41:36] (PS1) Awight: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/288511 [20:41:59] (CR) Awight: [C: 2 V: 2] Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/288511 (owner: Awight) [20:42:51] (Abandoned) Awight: WIP barebones banner impression log parser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/53279 (owner: Awight) [20:43:41] (CR) Awight: [C: -2] WIP (FR #807) Recurring contributions keep the original contribution's gateway account name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/96675 (owner: Awight) [20:43:50] (CR) Awight: [C: -2] WIP ridiculous hack to link from damaged messages to a helpful contribution search [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/97891 (owner: Awight) [20:44:05] (Abandoned) Awight: WIP: (FR #1285) Munge logs for source metadata [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/105159 (owner: Awight) [20:45:36] (CR) Awight: [C: -2] WIP: DonationForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/61929 (owner: Awight) [20:45:47] (CR) Awight: [C: -2] WIP device filtering in GlobalAllocation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/63100 (owner: Awight) [20:46:21] (CR) Awight: [C: -2] [WIP] Transparent workaround for access control [extensions/DonationInterface] (php54_test_adapter_collapse) - https://gerrit.wikimedia.org/r/133509 (owner: Awight) [20:46:31] (CR) Awight: [C: -2] WIP Simplify recurring code a bit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137467 (owner: Awight) [20:47:00] (CR) Awight: [C: -2] WIP Expose parsing without side-effects [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/143249 (owner: Awight) [20:47:08] (Abandoned) Awight: WIP offline tests pass [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/161576 (owner: Awight) [20:47:34] (Abandoned) Awight: WIP Updates to JP Morgan report formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/184700 (https://phabricator.wikimedia.org/T86682) (owner: Awight) [20:47:44] (CR) Awight: [C: -2] [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [20:48:22] (CR) Awight: [C: -2] Add "composer test" entry point [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/195375 (owner: Awight) [20:48:31] (CR) Awight: [C: -2] WIP Add "composer test" entry point [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/195485 (owner: Awight) [20:48:54] (CR) Awight: [C: -2] TODO Less special-casing in DataValidator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200096 (owner: Awight) [20:50:09] (CR) Awight: [C: -2] [WIP] Version number indicates we are on the fundraising branch [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/209856 (owner: Awight) [20:50:24] (CR) Awight: [C: -2] Test message injection takes URL directly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/210279 (owner: Awight) [20:50:32] (CR) Awight: [C: -2] WIP tests for the orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211065 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [20:50:38] (CR) Awight: [C: -2] WIP Move some shared functions into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/222699 (owner: Awight) [20:50:58] (PS3) Awight: Remove legacy config [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236058 [20:52:03] (Merged) jenkins-bot: Merge master into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/288511 (owner: Awight) [20:53:21] !log update fundraising-tools from b114b7174c3bd9bf53cd44bf55397049a03b96fb to 53f6fe635dd8cc451b86788018e53f418b690b00 [20:53:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:54:51] ccogdill: K, the test job is running. It should finish around 5pm Pacific, and will upload to IBM. [20:55:02] I just got a job failed email awight :/ [20:55:10] "Build failed in Jenkins: Silverpop emails - update and export #741" [20:55:18] that was fast, at least [20:55:23] haha yep [20:55:29] configuration... [21:07:53] fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2290776 (Jgreen) [21:08:13] fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2290791 (Jgreen) Open>Resolved p:Triage>Unbreak! [21:16:33] fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2290811 (Jgreen) Resolved>Open closed by accident [21:17:04] ccogdill: Okay, *now* the export is running for reals [21:18:15] fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2290820 (Jgreen) looks like /dev/sda failed: [1509411.577517] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK [1509411.577519] sd 0:0:0:0: [sda] CDB:... [21:25:28] (CR) Awight: [C: -2] Make it harder to keep session data when in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234718 (owner: Awight) [21:27:15] (Abandoned) Awight: WIP Remove alterFunctionMissing stuff [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242062 (owner: Awight) [21:27:23] (CR) Awight: [C: -2] WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [21:27:58] (CR) Awight: [C: -2] WIP some things to READ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/252709 (owner: Awight) [21:28:45] (CR) Awight: [C: -2] [WIP] Add country switcher to GlobalCollect forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260229 (https://phabricator.wikimedia.org/T96047) (owner: Awight) [21:29:02] (CR) Awight: [C: -2] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [21:29:11] (CR) Awight: [C: -2] [WIP] Remove old staging code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277989 (owner: Awight) [21:29:40] (CR) Awight: [C: -2] "Needs manual rebase." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279302 (owner: Awight) [21:29:53] (Abandoned) Awight: [WIP] Mirror to Kafka [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279744 (https://phabricator.wikimedia.org/T130304) (owner: Awight) [21:31:55] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Security-Data-Mapping: Rough draft of data flow map - https://phabricator.wikimedia.org/T133810#2290868 (awight) [21:37:39] (PS2) Ejegg: Fix time and message limits [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) [21:39:20] wikibugs: EC continue button is known issue? [21:39:24] (CR) jenkins-bot: [V: -1] Fix time and message limits [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg) [21:40:05] Fundraising Tech Backlog, Fundraising-Backlog, Design-Research-Backlog, MediaWiki-extensions-DonationInterface, Design Research and product team collaboration: How can we create the best mobile credit card experience? - https://phabricator.wikimedia.org/T96962#2290885 (awight) @Ppena Would y... [21:40:30] https://medium.com/frog-and-toad-are-cofounders [21:40:42] (PS3) Ejegg: Fix time and message limits [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) [21:41:42] (CR) AndyRussG: [C: 2] "Woohoo!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236058 (owner: Awight) [21:42:54] fwiw we leaned on beanstalk heavily at formerjob and regretted it every day [21:42:58] cwd: good stuff! [21:43:10] cwd yeah, I just saw it doesn't do replication [21:43:28] 'good stuff' was to the frog + toad parody... [21:43:29] there is also basically no visibility into the queue [21:43:34] hehe whew [21:44:18] oh there are some updates here too http://welcometobusinesstown.tumblr.com/ [21:45:41] aww, richard scarey style! [21:47:02] (Merged) jenkins-bot: Remove legacy config [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236058 (owner: Awight) [21:52:22] back in a little bit! [22:04:22] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/288523 [22:05:10] (CR) Eileen: [C: 2] "Merge commit from master, self-approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/288523 (owner: Eileen) [22:05:15] ejegg: hi...! For smoke-testing https://gerrit.wikimedia.org/r/#/c/287139/ [22:05:26] Hi AndyRussG [22:05:29] should I somehow test it out with more than one error? [22:06:02] So far I see it works when I get the generic "There was an error processing your request." when going to the iFrame [22:06:21] Would be cool if you could test with a field-specific error [22:06:26] In that case I do see the difference w/ master [22:06:42] but you'd have to find something that's validated harder on the server [22:06:42] Hmm such as? [22:06:48] Yeah hmm right [22:06:57] oh, I know, you can try putting a fake CC# into a few fields [22:07:03] 4111111111111111 [22:07:08] passes the luhn check [22:07:32] hey - I kind of forgot to deploy that code an hour ago - but deploying now & I feel like something looks different [22:07:42] eileen: oh? [22:07:55] yeah it's normal re civicrm -but also says [22:07:55] I don't think I've merged any crm stuff today [22:07:56] Here's what we're planning to do this run: [22:07:56] Config Tree (/srv/localsettings) [22:07:56] ee74416b4d134e89cd250f94ff3978332fe0ab65 --> head [22:08:14] I don't feel like I normally see the config tree stuff when I deploy [22:08:19] oh, Jeff_Green was just telling awight what's up with that [22:08:28] ejegg: K... going VPN so I can get an iFrame I guess... [22:08:38] AndyRussG: you shouldn't need that [22:08:50] No? [22:09:12] perhaps it's a test to see if we notice what's on the screen or we blindly click no [22:09:17] by API errors, I just mean the forms that make an AJAX call to the mediawiki API [22:09:25] instead of a full page form post [22:10:03] And if there are validation errors, we shouldn't be making calls to the processor [22:10:30] I'm wait & see if awight or jeff_green can confirm I should ignore it before hitting go [22:10:56] ejegg: K right... lemme see [22:11:07] eileen: should be some updated info in the motd on the deploy server [22:11:14] though I haven't read it yet... [22:13:49] eileen: That's a new step in deployment. [22:14:00] ok…? [22:14:16] Jeff_Green wrote a script that copies from /srv/localsettings, where fr-devs can edit as their own user [22:14:23] See the README there... [22:14:26] ejegg: for Adyen I'm getting the api error "Unrecognized parameter: 'token'" [22:14:36] oh really? [22:14:39] lemme see [22:14:39] ok - so we need some sort of update here https://collab.wikimedia.org/wiki/Fundraising/Engineering#Deploy_Fundraising_Code [22:14:40] eileen: long story short, you're OK to deploy the config [22:14:41] (seen on the console in browser, in result from api request) [22:14:51] eileen: yes! [22:15:00] ejegg: nothing in the syslog [22:15:15] http://payments.wiki.local.wmftest.net:8080/w/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=&uselang=en&language=en¤cy_code=USD&amount=10&country=US&payment_method=cc [22:15:48] The call to the api does indeed have a token param [22:16:23] Didn't do a composer update on DI, just tried that now [22:17:05] (PS1) Ejegg: Remove some unused and redundant i18n keys [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 [22:17:15] !log Updating civicrm from d32032965f2a45d24f1eaeb352eb6bfd6641753c to 6e3581692bb81c2c507612e7cd66dcdf78ef3cc0 [22:17:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:17:33] Hmm no change there [22:18:34] ah so in future we will update civicrm.settings that way [22:21:04] AndyRussG: weird, I get that error even on master [22:21:11] I'll roll a fix into that patch [22:22:00] ejegg: K... whew! glad I'm not just wasting others' time with my own setup issues, anyway [22:23:58] (PS4) Ejegg: Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) [22:25:24] (CR) jenkins-bot: [V: -1] Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) (owner: Ejegg) [22:25:59] d'oh! [22:27:13] aw man, really needs that i18n key, huh? [22:27:57] (PS5) XenoRyet: Adyen form for Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) [22:29:23] * ejegg waves dead chicken [22:29:38] (PS5) Ejegg: Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) [22:35:58] hey ejegg I think I accidentally brought this task into the sprint. did we want to close it or punt it? https://phabricator.wikimedia.org/T105618 [22:36:28] dstrine: there's a patch in review for it [22:36:36] ejegg: still getting an error [22:36:47] AndyRussG: oh really? What now? [22:36:53] Now less specific, just "There was an error processing your request." [22:36:53] ejegg: ok right [22:36:59] Nothing more in the api response [22:37:10] The patch does insert it in the form tho [22:37:10] * dstrine backs away from T105618 [22:37:16] AndyRussG: that's with the 4 + 15 1s in the street address? [22:37:49] wat? [22:38:06] 15 1s? [22:38:09] And where does the 4 go? [22:38:16] ejegg: ^ [22:39:09] AndyRussG: to trigger a field validation error, you put something that looks like a cc# into the street address field [22:39:26] the easiest one to remember is 4111111111111111 [22:39:36] that passes the checksum for credit cards [22:40:37] ejegg: ah right... I didn't get that that should go in the address field [22:40:44] that's one of the extra checks we do server side that we don't do client site, so you can still post the form [22:40:53] I'm not getting any non-error state to get an iframe tho [22:41:37] AndyRussG: hmm, ut-oh. Lemme try [22:43:09] So, w/ the faux cc for address, I do get two errors in the json response, and both are displayed in-form [22:43:31] general:"There was an error processing your request." [22:43:31] street:"Please correct the errors in your street address" [22:43:39] So in that sense the patch looks good! [22:43:40] ugh, weird, I'm getting a lingering general error message too [22:43:47] let me check master [22:43:55] K [22:44:00] (PS6) XenoRyet: Adyen form for Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) [22:44:17] yeah still don't see anything in the syslog also [22:44:52] yep, busted in master too... Something I did in the api validation [22:45:02] ohhhh, XenoRyet ran into this one! [22:45:20] and I think his current patch will fix it [22:45:26] lemme rebase locally [22:47:25] * XenoRyet reads backscroll [22:47:40] Yea, that looks like the same one. [22:47:50] yep, totally works. [22:48:46] (PS6) Ejegg: Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) [22:49:20] (CR) Ejegg: "Rebased on top of fix for bogus required field validation" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) (owner: Ejegg) [22:49:23] * AndyRussG git review -d 's [22:50:55] (CR) jenkins-bot: [V: -1] Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) (owner: Ejegg) [22:51:31] bah, bogus mysql connection errors again [22:51:44] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) (owner: Ejegg) [22:53:03] ejegg: probably means mysql fell over on the CI host, i can fix that, one sec... [22:53:32] oh, it's the php53-only error [22:53:47] do the hhvm tests use something else for db? [22:54:32] cwd, ejegg: I started the dead mysql on integration-slave-precise-1011 [22:54:45] thanks bd808! [22:55:00] the php53 tests are all that is still running on the precise hsots [22:55:12] Not sure why mysql has been croaking there lately [22:55:13] oh, different host, gotcha [22:55:30] thanks bd808! [22:56:04] somebody should probably open a ticket to bug hashar about this if he's not already aware [22:56:20] (CR) Ejegg: [C: 2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [22:56:36] Rad [22:57:14] bd808: did they pull 5.3 after precise? [22:57:51] yeah. I think 5.4 actually shipped about a week after the precise freeze [22:57:58] php 5.3 is ooooold [22:58:39] yeah [22:58:41] LTS releases are a horrible way to get your language runtime constraints [22:59:07] now that core is 5.5+ precise is being phased out of CI [22:59:28] we still need it for the older release branches though [23:00:04] bd808: all the FR code actually runs fine on 5.5 or hhvm, afaik the PCI headache is the only reason we haven't upgraded [23:00:29] hhvm will give you a 5-10x perf boost [23:00:46] yep, i think we all run it in dev [23:00:54] do you actually still run on 5.3 somewhere in prod? [23:01:02] yep... [23:01:07] all the payments boxes are 5.3 [23:01:27] and they are a bureaucratic mess to upgrade [23:01:54] although jeff just told me he was gonna get me logins [23:02:05] so i might have a better perspective on the reality soon [23:02:37] precise will be EOL next april [23:02:43] so don't wait too long [23:03:17] i also have ambitions of getting the payments cluster on the deploy train, or at least not too far behind it [23:04:35] * bd808 is glad to not work in a PCI environment any more and wishes that and SARB-OX on no one [23:05:42] (Merged) jenkins-bot: Adyen form for Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286949 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [23:06:09] at formerjob we had to maintain some level of compliance but it was nothing compared to here [23:06:57] Kount ($DAYJOB-1) was PCI-DSS level 1 audited. We handled PII including PANs for 70+ merchants [23:07:30] 2 weeks of on site autit every year. such fun! [23:07:51] blech [23:08:25] at sparkfun we stored credit card numbers and everything and they didn't care [23:08:49] After year 3 we had remediated all the real problems. The problem with that became that the auditors were under pressure to find problems. [23:09:02] so they would invent random concerns [23:09:28] Like "your hardware tokens refresh too quickly" [23:09:31] (PS3) Ejegg: Fix indentation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286491 (owner: Awight) [23:09:58] that is what i have noticed here, it is not a bunch of rules you have to comply with, it is the arbitrary opinion of a consultant [23:10:02] or "you don't have a certified anti-virus solution on these FreeBSD servers" [23:10:30] * cwd grits teeth [23:10:34] * cwd checks clamav log [23:10:50] still empty [23:11:06] (CR) Ejegg: [C: 2] "Alignment: lawful left-justified" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286491 (owner: Awight) [23:11:40] You need a duck [23:11:41] http://blog.codinghorror.com/new-programming-jargon/ [23:13:07] hehe, nice [23:13:39] dstrine: The Adyen patch just merged, FYI. [23:13:46] oooh [23:13:58] thanks XenoRyet !!! [23:14:15] ejegg had a lot to do with it too. :-) [23:14:23] thanks ejegg too! [23:14:44] when would that be deployed? [23:14:51] (Merged) jenkins-bot: Fix indentation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286491 (owner: Awight) [23:16:04] Good question. I think there might be one or two other patches about to come out of review that would be good to go along with it, but we don't necessarily have to wait, I don't think. [23:18:03] ok [23:20:35] I don't know what the rest of the day looks like or ya'll. I know it's not cool to deploy on fridays... but if we could be ready for a test early monday, that would be awesome. Advancement people in Europe can coordinate that with Israeli testers tomorrow and early monday [23:22:36] I sort of want to try for a quick patch to get France and Ukraine as well, but we don't strictly need that. [23:23:02] XenoRyet: is that something you can sneak in right now? [23:23:10] Probably [23:23:31] Should just be adding country codes to things, then some quick testing. [23:23:56] I don't want to micromanage a deploy but is this all doable today? [23:24:42] I'm rusty on deployment process, so either someone else do the deploy or walk me through it, but yea, seems doable to me. [23:25:14] France and Ukraine would be great to throw in there too [23:25:25] who do you need help from? [23:25:26] Give me like 20 mins, I'll see what I can do. [23:25:33] ok cool [23:25:49] Just someone to review when it's done, and someone to help with the deploy. [23:25:51] I want to be sensitive to anyone in later time zones [23:26:36] If ejegg or cwd has time to do the deploy now, we can go with that and the France/Ukraine thing can go Monday. [23:26:55] i was just checking on it, there is a shit ton of stuff to go out [23:26:59] one sec... [23:28:52] (PS1) Ejegg: Harmonize required field calculation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288542 [23:29:10] (CR) jenkins-bot: [V: -1] Harmonize required field calculation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288542 (owner: Ejegg) [23:30:24] (PS7) Ejegg: Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) [23:31:28] well I don't want to push it if it's late for anyone or other changes make it risky [23:32:01] it should be pretty straightforward [23:33:17] cwd ok, is it cool to sneak in France and Ukraine or just got with what's there? It's totally up to you all [23:33:21] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/288543 [23:33:51] dstrine: didn't Ukraine have some special language fallback requirements? [23:34:11] That would definitely take some more coding [23:34:13] english, not russian [23:34:30] i mean is should default to english [23:34:49] Right, we're just using the default mw language fallback rules [23:35:01] ok cool [23:35:20] ah, should i wait? [23:35:22] not sure if those have uk fall back to ru or what... [23:35:35] cwd I don't think that would get done tonight [23:35:53] No, certainly not. [23:35:57] Just France then? [23:36:52] word, i'll push the current stuff up [23:37:13] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/288543 (owner: Cdentinger) [23:37:55] (PS1) Cdentinger: Update DonationInterface [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/288544 [23:37:56] cwd wait, I think XenoRyet still wants to add france to the form settings [23:38:21] shoot sorry i thought this was all one change [23:38:34] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/288543 (owner: Cdentinger) [23:38:39] also, I double checked, and MessagesUk does indeed fall back to 'ru' [23:38:57] so we'll get to mess with the language fallback logic! [23:39:27] Which we probably need to do anyway, there's still wrongness in our WmfFramework i18n [23:39:52] (Abandoned) Cdentinger: Update DonationInterface [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/288544 (owner: Cdentinger) [23:43:33] (PS1) XenoRyet: Adyen in France [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288547 [23:43:53] There's the tiny one to turn France on if someone wants to CR real fast. [23:44:30] ejegg ^ [23:45:20] on it [23:46:30] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 2 others: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2291417 (X... [23:47:23] ejegg, XenoRyet - if it's gonna be soon I won't bother reverting that merge and just pile another on top [23:47:27] (CR) Ejegg: [C: -1] "Wanna snag the carte bleu settings from worldpay's submethod config?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288547 (owner: XenoRyet) [23:47:52] Does Adyen work with them? [23:48:00] ooh, good question [23:48:11] Figured the other three were safe, but not sure about that one. [23:48:42] We could just roll with this now, and do a payment method update patch later when we know more. [23:48:49] It'd do for internal testing. [23:49:15] yah, just still needs that currency code fixed [23:49:21] cwd: Yea, just a few more minutes. [23:49:53] and... looks like no carte bleu in our activated payment methods. I'll mention that to PPena [23:50:37] (PS2) XenoRyet: Adyen in France [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288547 [23:50:52] Currency code fixed [23:50:58] I need to step away for like ~15 minutes but I'll be right back [23:54:12] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 2 others: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2291421 (X... [23:55:37] ejegg: Wanna take another quick look there? [23:55:47] will do [23:55:53] Thanks [23:56:42] (PS3) Ejegg: Adyen in France [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288547 (owner: XenoRyet) [23:56:59] (CR) Ejegg: [C: 2] Adyen in France [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288547 (owner: XenoRyet) [23:59:28] (Merged) jenkins-bot: Adyen in France [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288547 (owner: XenoRyet) [23:59:44] cwd: That last one merged. Fire when ready [23:59:53] kk! one moment