[00:00:36] (PS1) Cdentinger: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/288553 [00:00:56] (PS1) Cdentinger: Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/288554 [00:02:55] (CR) Cdentinger: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/288553 (owner: Cdentinger) [00:03:51] XenoRyet: were there any config changes? [00:04:22] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/288553 (owner: Cdentinger) [00:04:22] No, not from me. [00:04:36] groovy [00:04:44] (CR) Cdentinger: [C: 2] Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/288554 (owner: Cdentinger) [00:06:16] anyone got a link for testing this baby on live? [00:06:39] Yea, one sec [00:07:23] I'll do a quick check of those validation changes to make sure I didn't break AstroPay fiscal stuff again [00:08:09] https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=he&language=he¤cy_code=ILS&amount=10&country=IL [00:08:14] Word!! [00:08:21] mazel tov [00:09:25] That doesn't look quite right though. It's got the address fields. [00:09:31] cwd: hey, yes should be as before [00:09:40] Jeff_Green: thanks! sorry for creepin on your bash :P [00:09:52] haha it confused me for a minute there :-) [00:09:58] XenoRyet: I don't think cwd deployed yet [00:09:59] you're deploying payments? [00:10:04] yep [00:10:12] cool. [00:10:25] ah, thought he was done. I'll just wait longer ;-) [00:10:53] core CI build takes forever... [00:11:07] Just got overexcited to see it on live. [00:11:13] hehe [00:11:16] feelsgoodman [00:11:51] wtf: https://gerrit.wikimedia.org/r/#/c/288554/ [00:11:56] shouldn't this auto submit on +2? [00:12:26] it hasn't been for me either [00:12:36] i swear it used to [00:12:42] you just click submit? [00:13:00] yeah, I thought it did too, and yeah, I've just clicked submit the last few times [00:13:15] I think that's what "gate-and-submit" is supposed to mean. [00:13:17] c.f. https://phabricator.wikimedia.org/rCIZC31fc347f8da2b518e2862266d6faedf59db22315 [00:13:54] i'll make a bug, antoine is super responsive [00:17:31] !log updated payments from b16c3cb0e12aacb49b91974d693c401dcaa9cca9 to 1af7208b4c7387a701f9ce83e33483d1e19213cb [00:17:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:17:47] testing fiscal # validation.... [00:19:18] Adyen form looks good. [00:19:53] client-side fiscal validation is cool for AR & BR [00:20:02] error log is mum [00:22:03] cool, CO/CL/UY check out [00:22:10] How many ILS = USD did I just donate :( [00:22:17] i can't seem to get the adyen iframe to load [00:22:21] thank you! [00:22:29] cwd on production? [00:22:40] It loaded for me. Took a second, but it did come up. [00:22:43] nm it's privacy badger [00:22:47] ahh [00:22:47] cwd: I thought I had some non-clickiness with the Visa button, but when I really concentrated and gave it a good click, I did get the iframe [00:23:08] XenoRyet: hi-five! [00:23:16] Thanks [00:23:18] woo! [00:23:24] congrats! [00:23:26] Nice to get that out [00:23:30] Holy cow--you may actually have slain the Jabberworldpay this sprint [00:23:43] * awight dances on the pyre [00:23:43] ok, I gotta scoot, but I'll be pingable in this channel [00:23:47] thanks all!!! [00:24:13] Have fun, don't get into trouble this week :p [00:24:20] I also saw a delay with israel form laoding the CC part but that doesn't seem too bad [00:24:25] O frabjous day! Callooh! Callay!' [00:24:29] dstrine: Also, to answer your question from standup today: The team's geographic center is in St. George, Utah [00:24:30] thanks ejegg !!! [00:24:42] XenoRyet: good to be precise [00:24:52] XenoRyet: how did you figure it? [00:25:04] also, we should all meet there some day [00:25:06] There's a little web app that does it. [00:25:11] cool [00:25:14] http://www.geomidpoint.com/ [00:25:27] cool [00:26:51] XenoRyet: I's sensing an offsite opportunity ... especially since it's close to vegas [00:27:04] moab! [00:27:06] Yep, I can see it. [00:27:07] well thanks cwd XenoRyet and ejegg|away !!! [00:27:18] No worries. Happy to have it done. [00:28:26] well I gotta run [00:28:42] I guess I'll put the task back in the backlog and unlick the cookie, since Ukraine and Japan still need doing, and that's more work than can fit in tomorrow. [00:28:42] seeya tomorrow [00:28:46] See ya [00:30:49] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 2 others: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2086811 (X... [00:50:34] ok well everything seems sane, it's dinner time in longmont [01:10:02] (PS2) Awight: Stop sending item category [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288253 (https://phabricator.wikimedia.org/T134446) [01:10:04] (PS8) Awight: PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [01:10:43] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2291592 (awight) Most of the support is in this patch... [01:11:57] cwd|afk: Sorry I missed work hours, but I wanted to share my broad strategy wrt PP Express Checkout. My thought was to try and push all our patches through code review and get an early internal test, bloody edges and everything. [01:13:04] Cos, the biggest risks IMO cannot be estimated until we're using the live system, and discover 1) whether in fact JP payments will go through their financial backend, and 2) if that damn recurring workflow irons itself out. [01:26:16] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 3 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2291608 (awight) Deplo... [01:30:46] (PS1) Awight: Remove old table [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/288562 [01:37:59] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2291624 (awight) [01:47:07] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2291642 (awight) Another twist--we're paging the export by email, so the paging query needs to properly pri... [01:47:55] (PS1) Awight: Revert "Unsubscribe old emails; fix is_primary bug" [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/288565 [01:48:07] (CR) Awight: [C: 2] Revert "Unsubscribe old emails; fix is_primary bug" [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/288565 (owner: Awight) [01:48:24] (Merged) jenkins-bot: Revert "Unsubscribe old emails; fix is_primary bug" [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/288565 (owner: Awight) [01:48:55] !log rollback fundraising-tools from 53f6fe635dd8cc451b86788018e53f418b690b00 to e2978024e6f6b6881d087ac5d07e4c40f7374709 [01:49:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:49:33] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 3 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2291656 (awight) Fun n... [01:55:01] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2291668 (awight) a:awight>None [01:56:22] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2291672 (Eileenmcnaughton) Any idea where the bad data is coming from? [01:56:53] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2291673 (awight) For now, I think that skipping these rows would be fine. Maybe anything with non-ascii ch... [01:59:14] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 7 others: [Epic] Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2291674 (awight) a:awight>None [02:52:35] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2291690 (Eileenmcnaughton) I'm reviewing our wmf hack on the civicrm_prevnext_cache table. It is intended as a pe... [02:56:56] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2291692 (Eileenmcnaughton) Interestingly in 4.7 code I can find no calls to the CRM_Core_BAO_PrevNextCache::retri... [08:11:28] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2291918 (awight) The email may be correctly encoded, I haven't checked that yet. There are only a handful... [08:33:01] (CR) Awight: Backport markConflicts code (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285325 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [08:38:40] (CR) Eileen: Backport markConflicts code (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285325 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [08:45:18] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 4 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2291947 (awight) [09:06:04] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 4 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2291975 (awight) I'll cast my vote for Redis 2... [09:14:39] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2291984 (awight) If it does turn out to be a performance issue, a union might be the next thing to try, but I'm h... [09:20:54] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2291998 (Eileenmcnaughton) I'm definitely still finding my way through this code! Until I tried on staging today... [14:17:46] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2292651 (faidon) [15:07:32] fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2292794 (Jgreen) >>! In T135178#2292645, @Cmjohnson wrote: > @jgreen, We will need to scheduled down time to replace the disk. Also, > please make sure gru... [15:48:03] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2292898 (Ejegg) even domain names can be utf-8 now! [15:56:49] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2292925 (awight) A thing that occurred to me: the donor names are certainly in unicode and are exported, so... [16:15:43] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2292949 (CCogdill_WMF) I haven't looked at this task in awhile... It's possible this is actually a problem... [16:21:09] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2292976 (awight) Naw, this is a bug in the python export script. Good idea though, to export from the civi... [16:22:14] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2292977 (CCogdill_WMF) Bah sorry, I'm confusing tasks here! Will retreat... [16:23:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Have Civi export name data in UTF-8 format - https://phabricator.wikimedia.org/T90834#2292981 (CCogdill_WMF) *This* is the task I meant to update re: utf-8... I haven't looked at this task in awhile... It's possible this is actually a probl... [16:51:24] (CR) AndyRussG: [C: 2] "Works as advertised!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) (owner: Ejegg) [16:53:14] (Merged) jenkins-bot: Inline errors instead of alert()s for API calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287139 (https://phabricator.wikimedia.org/T134530) (owner: Ejegg) [16:54:52] thanks AndyRussG ! [16:56:23] (PS2) Ejegg: Harmonize required field calculation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288542 [16:58:37] (CR) jenkins-bot: [V: -1] Harmonize required field calculation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288542 (owner: Ejegg) [16:59:10] (PS7) Cdentinger: Encode query string values properly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 (https://phabricator.wikimedia.org/T134586) (owner: Awight) [17:04:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Have Civi export name data in UTF-8 format - https://phabricator.wikimedia.org/T90834#2293097 (CaitVirtue) @LeanneS or @RLewis Can one of you take a look at this and assess and prioritize for our needs? thx! [17:05:04] (CR) Cdentinger: [C: 2] "We can revisit semantics later but I think it's worth pushing forward here." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 (https://phabricator.wikimedia.org/T134586) (owner: Awight) [17:06:38] (Merged) jenkins-bot: Encode query string values properly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287156 (https://phabricator.wikimedia.org/T134586) (owner: Awight) [17:06:44] ejegg: np! [17:08:05] (PS3) Ejegg: Harmonize required field calculation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288542 [17:13:08] (PS1) XenoRyet: Carte Bleu for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288631 (https://phabricator.wikimedia.org/T128812) [17:14:21] ejegg: Based on PP's email, I did that ^ [17:16:30] cool [17:20:17] (PS2) Ejegg: Whitespace fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283754 [17:20:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Have Civi export name data in UTF-8 format - https://phabricator.wikimedia.org/T90834#2293113 (RLewis) I just tested this in Civi by searching for all donors from Sweden who donated $500 and over, then exported and opened the csv file in Excel... [17:21:46] (PS2) Ejegg: Carte Bleu for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288631 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [17:23:42] (CR) Ejegg: [C: 2] "Oughtta work!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288631 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [17:25:15] (Merged) jenkins-bot: Carte Bleu for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288631 (https://phabricator.wikimedia.org/T128812) (owner: XenoRyet) [17:27:05] (CR) Ejegg: [C: 2 V: 2] Remove old table [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/288562 (owner: Awight) [17:28:03] (PS3) Ejegg: CRM-18842 Dedupe query: remove OR join in favour of more performant UNION [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [17:29:39] (CR) XenoRyet: [C: 2] Whitespace fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283754 (owner: Ejegg) [17:30:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy: Have Civi export name data in UTF-8 format - https://phabricator.wikimedia.org/T90834#2293126 (RLewis) Hmm @CaitVirtue i'm not sure if this is a quick fix for when we next need to do international mailings/emails but I just opened the csv file... [17:31:36] (Merged) jenkins-bot: Whitespace fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/283754 (owner: Ejegg) [17:33:19] (CR) Ejegg: [C: 2] "Improvement!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [17:35:14] (Merged) jenkins-bot: CRM-18842 Dedupe query: remove OR join in favour of more performant UNION [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285585 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [17:43:16] (PS2) Ejegg: Add order ID to pending queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 (https://phabricator.wikimedia.org/T133195) [17:46:38] (PS3) Ejegg: Aggregate contact ID in select (MySQL 5.7 fix) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/288030 [17:47:22] (CR) Ejegg: [C: -2] "Valuable research!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/284597 (https://phabricator.wikimedia.org/T131271) (owner: Awight) [18:08:21] thanks XenoRyet and ejegg for the carte bleu fix.... I'm guessing that'll go out monday? [18:09:51] dstrine: Yep [18:10:05] ejegg: cool [18:10:18] actually, that's technically just config file changes now, so if it's important to have early, we could push iit out today [18:20:08] PPena: is saying it's not a blocker for internal test [18:21:02] ejegg: can you confirm if I'm editing the link correctly for france? I'm using the following link but the CC information loads in English: https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=FR&language=FR¤cy_code=FRS&amount=10&country=FR [18:21:57] this is what I see: http://screencast.com/t/czU98woMub8W [18:23:00] dstrine correct [18:27:37] dstrine: weird, that looks like a good link... [18:28:38] lemme see if we actually send language, or if they just guess it in the iframe by their own means [18:30:29] (PS1) Ejegg: Fix AstroPay case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288639 [18:33:57] we are posting a 'shopperLocale' field, and it's 'en' now [18:34:04] so... i'll make a phab task [18:37:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Allow custom fallback message language - https://phabricator.wikimedia.org/T135254#2293336 (Ejegg) [18:39:55] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Send correct shopperLocale to Adyen - https://phabricator.wikimedia.org/T135255#2293365 (Ejegg) [18:40:21] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen, Unplanned-Sprint-Work: Send correct shopperLocale to Adyen - https://phabricator.wikimedia.org/T135255#2293377 (Ejegg) a:Ejegg [18:47:39] ejegg: so there is a bug? [18:48:10] nm I see the task [18:48:28] sure looks that way on prod, but I'm having trouble reproducing it locally [18:49:10] PPena: check out my screen shot above. The CC information section of the french form is displaying in english [18:49:57] do you still want to ask french testers to do an internal test? [18:55:24] dstrine: oh man, it's case sensitivity [18:55:36] also, gotta fix the currency in that link [18:56:10] https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=fr&language=fr¤cy_code=EUR&amount=2&country=FR [19:00:18] oh lol I just typed fr :P [19:00:47] we should definitely still fix that... [19:07:57] (PS1) Ejegg: Language query params shouldn't be case sensitive [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288647 (https://phabricator.wikimedia.org/T135255) [19:09:09] That oughtta do it ^^^ if anyone's up for some quick CR [19:39:30] ejegg: I had to update my local config to successfully smoketest https://gerrit.wikimedia.org/r/#/c/288639 [19:39:38] (CR) Ejegg: [C: 2] Document $wgDonationInterfaceDebugLog global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286711 (owner: Awight) [19:41:35] Is there a config change that would accompany that change? In some puppet file or some other repo? [19:42:40] (PS2) Ejegg: Move chunk of Worldpay logic into a staging class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287159 (owner: Awight) [19:45:17] (CR) Ejegg: [C: 2] "Let's go with this for now, and we can revisit the auth interface later. I was thinking it would be useful (even if an identical signatur" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287159 (owner: Awight) [19:47:40] (Merged) jenkins-bot: Document $wgDonationInterfaceDebugLog global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286711 (owner: Awight) [19:48:04] Also, does anyone have any tips as to what's urgent here? https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/DonationInterface,n,z [19:51:28] (PS14) Ejegg: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [19:52:57] (CR) AndyRussG: [C: 1] "Cool!! Locally I needed a config change to make this work... Would any config changes be needed for production, and if so, how would they " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288639 (owner: Ejegg) [19:54:01] (CR) Ejegg: "Yep! On production we'll need to fix the account info globals for this gateway. I'll add a deployment note to the commit message" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288639 (owner: Ejegg) [19:55:08] (PS2) Ejegg: Fix AstroPay case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288639 [19:55:19] ejegg: regarding 131811, i had been looking at it but worried about how the heck we know if those are all the instances [19:56:00] (Merged) jenkins-bot: Move chunk of Worldpay logic into a staging class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287159 (owner: Awight) [19:56:09] grep -r? Or IDE search? [19:56:32] i grepped around but there area lot of things that say token that are unrelated [19:56:35] I think that does need one more update around the API validation patch [19:56:50] lemme see... I had myself pretty convinced at one point [19:59:02] ejegg: anything else I should do to smoketest https://gerrit.wikimedia.org/r/#/c/288639/ other than just trying out AstroPay? [19:59:30] AndyRussG: I think that should do it [19:59:30] Looks pretty straightforward [19:59:33] K! [19:59:46] Oh, it should also work with the old urls for now [20:00:06] Special:AstropayGateway & the return page [20:01:08] (CR) AndyRussG: [C: 2] "Wheeeee! ;)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288639 (owner: Ejegg) [20:03:15] (Merged) jenkins-bot: Fix AstroPay case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288639 (owner: Ejegg) [20:03:41] nice! [20:03:55] good to finally scratch that itch [20:09:12] (CR) Ejegg: "Needs one more update because https://gerrit.wikimedia.org/r/#/c/287139/7/gateway_common/donation.api.php,unified merged first." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [20:37:37] Back online(ish) later! [21:19:03] d'oh, gdocs outage [21:19:18] Glad I wasn't doing the review right in the form... [21:24:12] (CR) XenoRyet: [C: 2] "Good times." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288647 (https://phabricator.wikimedia.org/T135255) (owner: Ejegg) [21:27:06] (Merged) jenkins-bot: Language query params shouldn't be case sensitive [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288647 (https://phabricator.wikimedia.org/T135255) (owner: Ejegg) [21:28:10] cwd: I just reviewed all the 'token' occurrences, and the ones that aren't in comments or message keys are only the backwards-compatibility shim and the api parameter. If I add the wmf_token api param, would you be availble to CR ? [21:29:01] totally! [21:29:12] thanks! [21:30:34] thanks for the CR XenoRyet ! [21:30:44] No worries [21:31:05] thanks for thumbing through that grep output! i took one look and got discouraged [21:34:10] (PS15) Ejegg: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [21:34:27] (PS16) Ejegg: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [21:35:40] cool, that gets rid of the warnings from api response [21:36:52] cwd PHPStorm presents search results pretty usefully, grouped by type (comment vs literal vs identifier), then lets you collapse a whole folder like i18n [21:39:31] hehe that sounds nice [21:39:36] * cwd inks quill pen [22:20:30] (CR) Cdentinger: [C: 2] "Looks great, one question but not a blocker" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [22:22:10] (Merged) jenkins-bot: Give token param a WMF namespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286716 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [22:24:28] thanks cwd! [22:25:08] I think I'm going to head out. Might put in a couple hrs over the weekend, since this feels a bit early [22:25:15] Have a good one, all! [22:27:39] seeya ejegg|away [22:28:23] later! [22:29:07] 6:30pm est on a friday...pretty early alright :) [22:29:43] lol yeah [23:16:06] I'm going to run as well. Have a good weekend everyone