[00:30:59] <grrrit-wm>	 (PS1) Ejegg: WIP: Super hacky language fallback override [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254)
[00:33:41] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen, and 2 others: Allow custom fallback message language - https://phabricator.wikimedia.org/T135254#2299649 (Ejegg) a:Ejegg
[00:57:43] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, I18n, Patch-For-Review, and 2 others: Adyen Hebrew UI bugs - https://phabricator.wikimedia.org/T135416#2299664 (Ejegg) The CSS for Adyen's iframe has been updated to fix a chunk of these problems.  The CSS for the stuff outside the ifram...
[00:59:00] <grrrit-wm>	 (PS3) Ejegg: Adyen iframe CSS for RTL languages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289002 (https://phabricator.wikimedia.org/T135416)
[07:17:08] <wikibugs>	 Fundraising-Backlog, Operations: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2300084 (Joe) p:Triage>Normal
[14:15:41] <grrrit-wm>	 (CR) Pcoombe: [C: 2] Update Spanish TY letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/289101 (https://phabricator.wikimedia.org/T134489) (owner: Ejegg)
[15:33:33] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Give CIVICRM ADMIN and FR Tech permission to Delete activities - https://phabricator.wikimedia.org/T135076#2301392 (DStrine)
[15:43:11] <grrrit-wm>	 (PS2) Cdentinger: [WIP] Use PROTO_CURRENT for paypal urls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811)
[16:33:04] <wikibugs>	 Fundraising-Backlog: unexplained Adyen transactions - https://phabricator.wikimedia.org/T135520#2301544 (DStrine)
[16:34:49] <grrrit-wm>	 (PS2) Ejegg: Override built-in Mediawiki message settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254)
[16:35:15] <ejegg>	 cwd so there's a hook to help with that, but it's a little awkward to use ^^
[17:13:13] <cwd>	 ejegg: oops!  sorry i gotta run out for a bit but i will check that out later
[17:13:29] <grrrit-wm>	 (PS1) Ejegg: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/289243
[17:14:29] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/289243 (owner: Ejegg)
[17:20:28] <grrrit-wm>	 (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/289243 (owner: Ejegg)
[17:22:33] <ejegg>	 !log updated CiviCRM from 6e3581692bb81c2c507612e7cd66dcdf78ef3cc0 to 7952ba43a012cb6a2e8d16af19bb13ed520bd56f
[17:22:39] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[17:22:59] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Patch-For-Review: Deploy changes to Spanish Thank you letter - https://phabricator.wikimedia.org/T134489#2267119 (Ejegg) Open>Resolved a:Ejegg
[17:26:16] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 4 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2301848 (Ejegg) Some pros and cons listed on a...
[17:31:21] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2301860 (Ejegg) Email column has the same type and collation as first and last names in silverpop_export ``...
[17:33:04] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Mailing list export script chokes on 8-bit email addresses - https://phabricator.wikimedia.org/T135204#2301864 (Ejegg) a:Ejegg Aha, but it's varbinary in silverpop_excluded!  Will fix...
[17:47:54] <grrrit-wm>	 (CR) Ejegg: [V: 2] Aggregate contact ID in select (MySQL 5.7 fix) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/288030 (owner: Ejegg)
[17:49:01] <grrrit-wm>	 (PS1) Ejegg: Fix encoding and paging on unsubscribe table [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/289247 (https://phabricator.wikimedia.org/T135204)
[17:50:24] <ejegg>	 clouding up, gonna move indoors
[17:55:35] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2301952 (CCogdill_WMF) Open>Resolved p:High>...
[17:55:52] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2301958 (CCogdill_WMF) Resolved>Open
[18:06:54] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2301992 (Ejegg) Aha, I think the problem is that the lan...
[18:07:06] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2301993 (Ejegg) a:CCogdill_WMF>Ejegg
[18:17:42] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2302039 (CCogdill_WMF) Ah, cool. Weird that WMF worked a...
[18:19:52] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2302056 (Ejegg) @CCogdill_WMF, yep, it's just a list of...
[18:21:05] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2302071 (CCogdill_WMF) Cool, thank you!
[18:23:49] <grrrit-wm>	 (PS1) Ejegg: Add /wiki/WP* to landing page patterns [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/289255 (https://phabricator.wikimedia.org/T132500)
[18:27:12] <grrrit-wm>	 (PS4) Florianschmidtwelzow: Replace usage of wfSetupSession() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/282479 (https://phabricator.wikimedia.org/T132251)
[18:28:56] <grrrit-wm>	 (PS2) Ejegg: Add /wiki/WP* to landing page patterns [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/289255 (https://phabricator.wikimedia.org/T132500)
[19:09:41] <grrrit-wm>	 (PS1) Ejegg: INSERT IGNORE into donatewiki_unique [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/289262
[19:16:20] <ejegg|afk>	 hi cwd
[19:16:26] <ejegg|afk>	 oops
[19:16:43] <cwd>	 yo!
[19:16:51] <ejegg>	 got a couple of trivial updates to the landing page counter ^^
[19:17:13] <ejegg>	 if you're not busy with something else already
[19:17:49] <cwd>	 i have never contributed to this repo, can you give me the super fast version of what it's for?
[19:17:59] <cwd>	 django i know as the python web framework
[19:18:17] <ejegg>	 I just wrote a little about it here: https://www.mediawiki.org/wiki/Fundraising_tech/tools
[19:18:31] <ejegg>	 yeah, there's no real reason for this to use django
[19:18:54] <cwd>	 oh awesome
[19:19:02] <ejegg>	 there's no web frontend and we barely use the models
[19:19:23] <cwd>	 hehe
[19:19:30] <ejegg>	 but hey, it's nice to get a break from php once in a while!
[19:19:58] <cwd>	 no kidding
[19:27:25] <cwd>	 ejegg: no CI on this repo?
[19:28:17] <ejegg>	 cwd nah, guess not even pyflakes
[19:29:01] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Add /wiki/WP* to landing page patterns [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/289255 (https://phabricator.wikimedia.org/T132500) (owner: Ejegg)
[19:29:31] <cwd>	 oh well!
[19:30:32] <ejegg>	 ... which also means manual V+2 / submit is needed for merge
[19:30:50] <cwd>	 hehe of course
[19:31:29] <cwd>	 i have been warned about force submit pausing zuul for 10 minutes
[19:31:43] <cwd>	 but since this has no zuul bindings maybe it doesn't matter?
[19:32:08] <ejegg>	 yeah, I think zuul is blissfully unaware of this heap of code
[19:32:23] <grrrit-wm>	 (CR) Cdentinger: [V: 2] Add /wiki/WP* to landing page patterns [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/289255 (https://phabricator.wikimedia.org/T132500) (owner: Ejegg)
[19:36:55] <ejegg>	 cwd so there's this recursive exception handling in the write fn, which must have been pretty busy with that 'IGNORE' missing
[19:37:39] <ejegg>	 it tries to insert into donatewiki_uniques in batches of up to 1500
[19:38:05] <ejegg>	 but if any of those violated the unique (utm_source, contact_id) constraint
[19:38:29] <ejegg>	 (i.e. a donor clicked on an email a second time)
[19:38:46] <ejegg>	 the batch would fail and it would fall back to individual inserts
[19:42:22] <cwd>	 aah yeah that makes sense
[19:45:07] <AndyRussG>	 Hey... anyone want to test a Google Hangout with me? My work machine is still down but I'd like to join the meet
[19:45:15] <grrrit-wm>	 (CR) Cdentinger: [C: 2 V: 2] INSERT IGNORE into donatewiki_unique [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/289262 (owner: Ejegg)
[19:47:15] <AndyRussG>	 cwd: dstrine: ejegg: ^
[19:47:16] <AndyRussG>	 ?
[19:47:40] <ejegg>	 AndyRussG: sure, one sec!
[19:47:49] <AndyRussG>	 Thx!
[19:51:12] <AndyRussG>	 ejegg: huh, I heard the call and tried to answer, then got an error...
[19:51:25] <AndyRussG>	 I guess I should see if I can get dialed into the call
[19:51:28] <ejegg>	 AndyRussG: phooey, lemme try in another browser
[19:51:45] <AndyRussG>	 I should try to update my browser, the prob is surely on my end...
[19:52:50] <ejegg>	 I just joined the fr-tech-backlog mtg early if you want to try that one
[19:53:58] <AndyRussG>	 ejegg: K thx!
[19:55:30] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Patch-For-Review: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2200676 (Ejegg) OK, the pattern up...
[20:00:09] <ejegg>	 !log disabled banner impression loader
[20:00:17] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[20:00:33] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Patch-For-Review: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2302761 (CCogdill_WMF) Sure, that'...
[20:02:07] <ejegg>	 !log updated DjangoBannerStats from 30396a6df5bb9eadd5d4485a08fc4f6cb4096bd9 to 8172c4176ea2b78df0dccbfa052064f2739c64bd
[20:02:14] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[20:03:48] <ejegg>	 !log enabled banner impression loader
[20:03:55] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[20:05:38] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Errors from api calls should not be displayed with multiple alert popups - https://phabricator.wikimedia.org/T134530#2302779 (Ejegg) Open>...
[20:11:00] <wikibugs>	 Fundraising-Backlog: Change paymentswiki session cookie name - https://phabricator.wikimedia.org/T135439#2302792 (DStrine) p:Triage>Normal
[20:15:06] <wikibugs>	 Fundraising-Backlog: Ingenico iframe styling has changed - https://phabricator.wikimedia.org/T135388#2302805 (DStrine) p:Triage>Normal
[20:18:22] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Configuring a banner sequence test - https://phabricator.wikimedia.org/T135398#2302822 (DStrine)
[20:19:06] <wikibugs>	 Fundraising-Backlog: Process to archive and save an out of date mailing address - https://phabricator.wikimedia.org/T135552#2302825 (CaitVirtue)
[20:20:55] <wikibugs>	 Fundraising-Backlog: Process to archive and save an out of date mailing address - https://phabricator.wikimedia.org/T135552#2302850 (CaitVirtue)
[20:26:58] <wikibugs>	 Fundraising-Backlog: Process to archive and save an out of date mailing address - https://phabricator.wikimedia.org/T135552#2302874 (DStrine) p:Triage>Normal
[20:27:00] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: is it possible to correct obvious email address typos before deduping exact matches? - https://phabricator.wikimedia.org/T135042#2286640 (Ejegg) We could also use this MIT-licensed JS lib to help reduce these errors on the way in: https://github.c...
[21:00:20] <ejegg>	 phooey, there might be something wrong with that last landing page counter update
[21:00:52] <cwd>	 dag
[21:00:59] <cwd>	 we should get some tests happening on that repo
[21:01:13] <cwd>	 says the laziest test writer ever
[21:02:45] <ejegg>	 huh, so INSERT IGNORE still generates a warning
[21:03:06] <cwd>	 aah that does sound familiar
[21:03:27] <ejegg>	 andpython's mysql lib is treating that as an exception
[21:03:49] <ejegg>	 wonder how I can suppress that with the fewest side effects
[21:06:11] <ejegg>	 could do a dummy 'on duplicate key update' thing I guess
[21:07:05] <cwd>	 i think there's a replace keyword like update
[21:07:10] <cwd>	 err...ignore i mean
[21:07:19] <cwd>	 insert replace
[21:07:56] <ejegg>	 yeah, I don't even wanna replace - I'd rather keep the initial timestamp and link id
[21:08:12] <ejegg>	 so maybe just ...on duplicate key update link_id=link_id
[21:09:00] <cwd>	 what is link id?
[21:09:00] <ejegg>	 link_id=values(link_id) would actually change it, but I want the no-op
[21:09:21] <ejegg>	 cwd if they have multiple links in one email, that distinguishes them
[21:09:33] <cwd>	 gotcha
[21:11:46] <cwd>	 ejegg: i have everything merged up until the big EC adapter patch, and this is the only thing i had to put on top to make it work for me, but i have a feeling it's the wrong approach: https://gerrit.wikimedia.org/r/#/c/289102/
[21:12:08] <cwd>	 i think there's probably some other reason i was getting those links starting with //
[21:12:38] <ejegg>	 oh huh, lemme see
[21:13:31] <ejegg>	 do you have $wgServer set in LocalSettings?
[21:13:59] <ejegg>	 I think that's what getFullURL uses by default
[21:14:00] <cwd>	 yep: $wgServer = "http://payments.wiki.local.wmftest.net:8080";
[21:14:11] <ejegg>	 weird
[21:14:18] <cwd>	 but those links were appearing in the payload to paypal as //
[21:14:28] <cwd>	 and they responded with errors about the params
[21:14:38] <cwd>	 once i got the http on there it worked
[21:14:41] <ejegg>	 that stuff's been working in prod so far
[21:14:54] <cwd>	 interesting
[21:16:04] <ejegg>	 but... looking at the source for Title.php, it doesn't seem like it should be...
[21:16:12] <ejegg>	 totally defaults to //
[21:16:35] <cwd>	 that function is crazy
[21:18:57] <cwd>	 ejegg: but changing it in resultpages.php...wouldn't that imply that this is working with all the other gateways?
[21:19:55] <ejegg>	 Ahh, it's probably only working in prod 'cause we're setting the globals to fully-qualified URLs
[21:20:21] <ejegg>	 and we don't hit the Title logic
[21:20:53] <ejegg>	 so your patch looks totally legit
[21:22:40] <ejegg>	 ehh?  Nope, i'm getting an https:// back from this other place it's called without params
[21:22:44] <ejegg>	 debugger time
[21:22:57] <cwd>	 hehe
[21:23:06] <cwd>	 thanks for doing that!
[21:23:45] <cwd>	 urgh engagement survey
[21:24:08] <cwd>	 the reason i keep putting it off is i want to give it some time
[21:35:08] <ejegg>	 cwd how about $wgScriptPath?
[21:35:40] <cwd>	  /w
[21:35:56] <ejegg>	 ehh, i have no idea...
[21:36:06] <ejegg>	 lots of twisty little passages... and hooks
[21:36:08] <cwd>	 you get the protocol on your machine?
[21:36:17] <ejegg>	 yep
[21:36:18] <cwd>	 oh god yeah
[21:36:36] <cwd>	 tugging on strings in DI is an experience
[21:36:49] <ejegg>	 so, for me, getLocalURL returns something starting with /index.php/....
[21:37:14] <ejegg>	 then expandUrl prefixes $wgServer
[21:37:30] <ejegg>	 but if getLocalURL were to return something starting with //
[21:38:06] <ejegg>	 it would use the protocol param from getFullUrl
[21:40:28] <ejegg>	 uhh, weird, I've got $wgScriptPath = "";
[21:41:05] <cwd>	 i think i'm using basically the default vagrant settings
[21:43:02] <ejegg>	 ehh, even if I set it to /w it still gets a url w/o double slashes out of getLocalUrl
[21:44:05] <ejegg>	 well, anyway, we should make DI do something consistent regardless of settings
[21:44:21] <ejegg>	 so your patch still seems sane
[21:45:36] <wikibugs>	 fundraising-tech-ops: test jessie for payments servers, upgrade servers to jessie - https://phabricator.wikimedia.org/T135562#2303206 (Jgreen)
[21:46:09] <wikibugs>	 fundraising-tech-ops: test jessie for payments servers, upgrade servers to jessie - https://phabricator.wikimedia.org/T135562#2303220 (Jgreen)
[21:46:11] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#2303219 (Jgreen)
[21:46:25] <ejegg>	 oddly enough, in core I see tons of wfExpandUrl( $mainPage->getFullURL(), PROTO_CURRENT );
[21:46:38] <ejegg>	 but almost no calls to getFullURL with the third param
[21:47:36] <ejegg>	 ehh, anyway, looks like PROTO_CURRENT is relied on everywhere, so I'm sure it takes proxying into account
[21:50:25] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#2303224 (Jgreen) After a whole lot of testing and tweaking, I'm pretty much at the conclusion that owasp-crs rules for tracking sessions and detecti...
[22:08:21] <wikibugs>	 Fundraising-Backlog: Process to archive and save an out of date mailing address - https://phabricator.wikimedia.org/T135552#2303290 (CaitVirtue)
[22:21:14] <wikibugs>	 Fundraising-Backlog: Catch email typos early - https://phabricator.wikimedia.org/T135567#2303344 (DStrine)
[22:26:01] <cwd>	 ejegg: sorry i've been engaging with this survey -- isn't it interesting that Title&getFullUrl sets PROTO_RELATIVE?  i can't understand why everyone doesn't see the behavior i'm seeing
[22:27:00] <ejegg>	 yeah, I can trace why it works in my case, cause getLocalUrl returns something starting with a single /
[22:27:15] <ejegg>	 and expandUrl prepends wgServer in that case
[22:27:27] <ejegg>	 just can't figure the alternate path that you're getting
[22:28:39] <cwd>	 oh gotcha, ok i bet i can figure that out
[22:28:40] <cwd>	 thanks!
[22:36:56] <ejegg>	 going to head over to the local CiviCRM meetup for a bit - hope it's better attended than last month's
[22:37:39] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: Make the CiviCRM Search bar work for non-exact searches - https://phabricator.wikimedia.org/T114053#2303425 (DStrine)
[22:47:20] <wikibugs>	 Fundraising-Backlog: Catch email address typos early  - https://phabricator.wikimedia.org/T135567#2303448 (DStrine)
[23:30:02] <AndyRussG>	 Woohhooo! Activated my raid/encrypted/lvm'd volumes from resuce shell!
[23:31:26] <AndyRussG>	 Foodz time...