[12:18:47] <wikibugs>	 Fundraising Tech Backlog, Tracking: Fundraising Tech Staging (tracking) - https://phabricator.wikimedia.org/T88657#2318122 (Danny_B)
[15:35:10] <ejegg>	 hi cwd !  I'm going to deploy DI to get some of that Adyen stuff up
[15:35:33] <ejegg>	 wanna watch and see if the paypal file move is ok?
[15:35:44] <cwd>	 sure thing, lemme find my keys
[15:36:53] <cwd>	 need to composer install to get autoload stuff yeah?
[15:38:27] <grrrit-wm>	 (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/290260
[15:38:44] <cwd>	 first time i have noticed there is no paypal log file
[15:39:04] <ejegg>	 oh huh, is it called payflow still?
[15:39:17] <cwd>	 i do see that one, didn't know they were the same
[15:39:47] <ejegg>	 i think that was the name of one of their integrations long ago
[15:39:57] <cwd>	 TIL
[15:40:16] <ejegg>	 what do we need to update in composer autoload?
[15:40:50] <ejegg>	 ohh, paypal is in classmap
[15:40:51] <cwd>	 the paypal stuff being ina new directory
[15:40:53] <cwd>	 yeah
[15:41:03] <ejegg>	 huh, it's also in mediawiki autoloader though
[15:41:19] <cwd>	 hrm, yeah i don't understand why both
[15:42:39] <ejegg>	 huh, we only list like 6 classes in the classmap bit of composer.json, but there are a ton in the autoload file
[15:45:23] <cwd>	 most of that stuff is in DonationInterface.php too
[15:45:33] <ejegg>	 yeah
[15:45:36] <ejegg>	 i think all of it
[15:46:06] <cwd>	 ls
[15:46:11] <cwd>	 :|
[15:46:49] <ejegg>	 autoexec.bat        system32         Documents and Settings
[15:48:01] <grrrit-wm>	 (PS1) Ejegg: Update autoloader files [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/290261
[15:48:36] <cwd>	 hehehe
[15:50:16] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] Update autoloader files [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/290261 (owner: Ejegg)
[15:50:31] <grrrit-wm>	 (PS2) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/290260
[15:50:53] <cwd>	 am i weird to think it's weird to use the composer autoloader for non composer stuff?
[15:51:29] <grrrit-wm>	 (PS3) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/290260
[15:51:49] <ejegg>	 cwd: yeah, does seem that way
[15:52:09] <ejegg>	 I mean, it makes sense to list the things you have so ppl using your package can autoload them
[15:52:29] <ejegg>	 but using composer to autoload your own stuff does seem odd
[15:53:03] <ejegg>	 though i guess if it's gonna autoload some things, you might as well not duplicate functionality
[15:54:39] <cwd>	 i thought it was more accepted to put local classes in RL modules?
[15:54:55] <cwd>	 (which these also are)
[15:55:15] <ejegg>	 mediawiki ResourceLoader?
[15:55:49] <cwd>	 yeah
[15:55:57] <AndyRussG>	 ?
[15:55:57] <cwd>	 isn't that what scrapes donationinterface.php?
[15:56:27] * AndyRussG hugs RL
[15:56:40] <cwd>	 $wgAutoloadClasses
[15:56:45] <AndyRussG>	 Hmmm
[15:56:46] <ejegg>	 cwd pretty sure RL is for client-side stuff, and there's a separate autoloader for php classes
[15:56:56] <AndyRussG>	 Ah yes RL is just client-side
[15:57:02] <grrrit-wm>	 (PS4) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/290260
[15:57:09] <cwd>	 ah ha, nm
[15:57:39] <ejegg>	 but yeah, mediawiki's got a preferred loader
[15:57:47] <cwd>	 anyway wouldn't it be cleaner to keep all the paypal stuff in that file?
[15:58:04] <ejegg>	 i was just thinking for other random php libs that don't have a homegrown solution
[15:58:14] <ejegg>	 it makes sense to use composer autoload for both
[15:59:46] <cwd>	 what wigs me out about it is installing the vendor submodule under another project
[16:00:14] <cwd>	 it seems like it should not have strings tied to the main repo
[16:10:01] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/290260 (owner: Ejegg)
[16:30:28] <cwd>	 ejegg: deploy get hung up on something?
[16:30:55] <ejegg>	 cwd DI merge is taking forever
[16:31:13] <ejegg>	 and I bet the core submodule bump will hang on the same stuff as friday, too
[16:31:48] <cwd>	 oh crap
[16:31:51] <cwd>	 i forgot about that
[16:32:31] <cwd>	 zuul looks clogged up
[16:33:57] <ejegg>	 yeah, some of those extension tests are at the 35 minute mark
[16:35:50] <cwd>	 cripes
[16:35:58] <ejegg>	 man, i have no idea why that stuff has to block us
[16:36:20] <ejegg>	 looks like everything's waiting on https://integration.wikimedia.org/ci/job/mwext-testextension-php55/11652/
[16:36:26] <cwd>	 yeah it doesn't really make sense for fundraising stuff
[16:36:28] <ejegg>	 i'll ask in releng
[16:36:57] <cwd>	 i poked tyler but i think monday mornings are rough over there
[16:39:24] <cwd>	 ejegg: ah ha https://phabricator.wikimedia.org/T135906#2319030
[16:41:27] <cwd>	 with any luck we'll just inherit a fix for those CI problems
[16:42:49] <ejegg>	 cwd: i think we were getting a lot more than just those 2 build errors
[16:46:18] <grrrit-wm>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/290260 (owner: Ejegg)
[16:48:49] <grrrit-wm>	 (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290267
[16:51:16] <grrrit-wm>	 (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290267 (owner: Ejegg)
[16:54:06] <dstirne>	 Hi all.. looks like we had a few exciting days
[16:54:21] <dstirne>	 Thanks all who were handling that thrusday/friday
[16:54:59] <cwd>	 dstirne: i think we should this high priority: https://phabricator.wikimedia.org/T135803
[16:55:01] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290267 (owner: Ejegg)
[16:55:16] <cwd>	 this job explodes every night for some reason and needs to be turned off
[16:55:31] <cwd>	 but can be turned on again the next day
[16:55:47] <cwd>	 MBeat: did you see any new txns since i turned it on again?
[16:56:20] <MBeat>	 nah, cwd, nothing yet
[16:56:34] <cwd>	 damn
[16:56:59] <dstirne>	 cwd: ok sure ... adyen is priority
[16:57:21] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Unplanned-Sprint-Work: Adyen smashpig job runner failing - https://phabricator.wikimedia.org/T135803#2319150 (DStrine) p:Triage>High
[16:57:30] <cwd>	 the log looks like it ran a bunch
[16:57:51] <dstirne>	 cwd:  could we still be testing adyen (like a 1 hour test) during the day?
[16:58:34] <dstirne>	 ejegg:  I see a bunch of adyen tasks in pending deployment. how is the hebrew from looking?
[16:58:36] <dstirne>	 *form
[16:59:07] <ejegg>	 hi dstirne it's looking good!
[16:59:35] <ejegg>	 but... we need some help from releng to be able to deploy again
[16:59:59] <ejegg>	 after the security update, tons of tests are breaking on our core branch
[17:01:29] <dstirne>	 ejegg: ok totally understandable... thanks for dealing with all that
[17:02:18] <cwd>	 dstirne: i think so, think it's just the audit download that fails
[17:02:24] <cwd>	 maybe that should be a separate job
[17:05:58] <wikibugs>	 Fundraising-Backlog, Documentation: Document templates on donate-wiki and payments-wiki - https://phabricator.wikimedia.org/T131219#2319200 (Danny_B)
[17:06:14] <cwd>	 dstirne: i think so, think it's just the audit download that fails
[17:08:53] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Documentation: Document paymentswiki config VCS on collabwiki - https://phabricator.wikimedia.org/T134221#2319216 (Danny_B)
[17:15:36] <awight>	 n e one know if K4 is still in San Francisco?
[17:16:26] <ejegg>	 no clue
[17:16:31] <ejegg>	 are you back from the tropics?
[17:16:31] <awight>	 bah
[17:16:37] <awight>	 physically, yes
[17:16:40] <ejegg>	 heh
[17:17:07] <awight>	 I became aware of a difference in time zones at some unearthly time this morning, however
[17:17:19] <cwd>	 how many hours is it?
[17:17:23] <awight>	 Just 3
[17:17:55] <awight>	 I highly recommend the "big island" as not being infested with annoying tourists yet, fwiw...
[17:18:30] <awight>	 Although I had a sad realization that the tourists were less annoying than usual because the island prices are uncomfortably high
[17:18:53] <awight>	 So they weren't going totally bonkers like all "how much for the wife?"
[17:22:26] <cwd>	 heh, yeah i imagine getting goods to the moon colony is pretty expensive
[17:22:32] <cwd>	 and makes everything expensive
[17:22:42] <awight>	 A million dollars per brick
[17:23:15] <awight>	 Such a sketchy historical anomaly that people are speaking English and USDing there
[17:23:34] <awight>	 The Mauna will have their revenge...
[17:23:36] <cwd>	 http://static1.fjcdn.com/comments/Heh+lots+of+dolan+today+i+m+not+complaining+mind+you+_92ae98a9a95ab441e609a0435acac525.jpg
[17:23:43] <awight>	 (volcano god)
[17:24:11] <cwd>	 unrelated just a good cartoon
[17:24:22] <awight>	 excellent as usual!
[17:25:58] <awight>	 dstirne: Feel free to help me climb back onto the rails when you're done with the meeting...  I have no clue what's going on
[17:27:24] <awight>	 I guess the sprint board is plenty informative.  I'll deploy the SP config change for now
[17:34:02] <Jeff_Green>	 awight: just saw your comment on T133601, i can work on it whenever you're ready, i'm just tilting at modsecurity windmills otherwise
[17:34:02] <stashbot>	 T133601: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601
[17:34:26] <Jeff_Green>	 ha ^^^ awesome
[17:36:10] <awight>	 Jeff_Green: ah great, buckling in then
[17:36:33] <Jeff_Green>	 awight: is this just a flat file config? and does it contain sensitive info?
[17:36:44] <awight>	 hrm, I think it's insensitive
[17:36:49] <awight>	 yah, just a YAML file
[17:37:20] <awight>	 oh--actually it contains slight fraud tweaks, so is sort of sensitive
[17:37:47] <Jeff_Green>	 ok
[17:38:01] <Jeff_Green>	 it should probably go in the puppet private repo then
[17:38:20] <cwd>	 is it part of config tree?
[17:38:32] <awight>	 cwd: it lives in /etc/fundraising
[17:38:50] <awight>	 & is a new file, so I think the answer is yes, it should be part of the config tree
[17:39:08] <cwd>	 seems like a good job for the deploy script?
[17:46:59] <grrrit-wm>	 (PS1) Ejegg: Merge REL1_25 test fixes into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290276
[17:47:20] <awight>	 cwd: I think it'll be part of fundraising_code_update
[17:47:51] <awight>	 I won't miss all the PHP punctuation.
[17:47:53] <awight>	 !@#*!
[17:51:17] <grrrit-wm>	 (PS4) Ejegg: Disable testIPTCParseForcedUTFButInvalid on PHP > 5.6.0 but < 5.6.10 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/275035 (https://phabricator.wikimedia.org/T124574) (owner: Paladox)
[17:51:29] <grrrit-wm>	 (CR) Ejegg: [C: 2] Disable testIPTCParseForcedUTFButInvalid on PHP > 5.6.0 but < 5.6.10 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/275035 (https://phabricator.wikimedia.org/T124574) (owner: Paladox)
[17:52:36] <grrrit-wm>	 (CR) Paladox: "Thanks." [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/275035 (https://phabricator.wikimedia.org/T124574) (owner: Paladox)
[17:53:58] <awight>	 That's creepy: "verified: /queue/donations-gc-garbage"
[17:54:10] <awight>	 ejegg: Great, I've copied over the extra queue pointers
[17:54:18] <ejegg>	 right on
[17:54:28] <ejegg>	 and yeah, that does look weird
[17:56:01] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Disable testIPTCParseForcedUTFButInvalid on PHP > 5.6.0 but < 5.6.10 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/275035 (https://phabricator.wikimedia.org/T124574) (owner: Paladox)
[17:56:18] <wikibugs>	 Fundraising-Backlog, FR-ActiveMQ, FR-Ingenico, FR-Smashpig: Spike: investigate donations-gc-garbage - https://phabricator.wikimedia.org/T136022#2319412 (awight)
[17:58:23] <grrrit-wm>	 (CR) Ejegg: [V: 2] "Forcing just a couple test fix patches" [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/275035 (https://phabricator.wikimedia.org/T124574) (owner: Paladox)
[17:59:48] <grrrit-wm>	 (PS1) Paladox: Suppress session_destroy() warnings for unit tests [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290280 (https://phabricator.wikimedia.org/T135906)
[18:00:15] <grrrit-wm>	 (PS2) Ejegg: Suppress session_destroy() warnings for unit tests [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290280 (https://phabricator.wikimedia.org/T135906) (owner: Paladox)
[18:00:25] <awight>	 dstirne: Why is your name misspelled?
[18:00:37] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] Suppress session_destroy() warnings for unit tests [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290280 (https://phabricator.wikimedia.org/T135906) (owner: Paladox)
[18:00:41] <awight>	 hahaha
[18:00:55] <awight>	 You're just making us feel better about our own troubles
[18:01:11] <grrrit-wm>	 (CR) Paladox: "check experimental" [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290276 (owner: Ejegg)
[18:01:13] * awight looks stern mnemonically
[18:01:39] <grrrit-wm>	 (PS1) Ejegg: Follow-up ceffd37e68 Fix parser test that broke [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290281 (https://phabricator.wikimedia.org/T135906)
[18:02:17] <grrrit-wm>	 (CR) Paladox: "Thanks." [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290280 (https://phabricator.wikimedia.org/T135906) (owner: Paladox)
[18:02:23] <grrrit-wm>	 (CR) Ejegg: [C: 2] "OK, let's see if this gets our branch back to passing too!" [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290281 (https://phabricator.wikimedia.org/T135906) (owner: Ejegg)
[18:05:35] <grrrit-wm>	 (Abandoned) Ejegg: Merge REL1_25 test fixes into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290276 (owner: Ejegg)
[18:08:03] <ejegg>	 damn, still failing
[18:25:13] <ejegg>	 ok, maybe this limited layout fix is all we need: https://gerrit.wikimedia.org/r/#/c/289975/
[18:26:21] <awight>	 ejegg: That's a little scary tho, cos we're still using 5.3 in production
[18:26:48] <ejegg>	 Right, I figure it makes more sense to test on that one
[18:26:51] <awight>	 D'oh.  This one has been coming down the pipe for a while now
[18:27:07] <awight>	 ejegg: But it looks like that patch causes us to test using 5.5 only
[18:27:33] <ejegg>	 we've been testing DI on 5.3 for a while, but core fundraising/REL1_25 has been running php55 tests
[18:28:13] * awight blinks
[18:28:25] <ejegg>	 those branch regexes are negative lookaheads, right?
[18:28:32] <awight>	 a ha :) thank you
[18:28:36] <awight>	 double negative
[18:28:49] <ejegg>	 skip if not untrue:
[18:31:28] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Follow-up ceffd37e68 Fix parser test that broke [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290281 (https://phabricator.wikimedia.org/T135906) (owner: Ejegg)
[18:33:12] <awight>	 Ouch!  We have no deployment branch for SmashPig
[18:33:54] <awight>	 Heads up: this is going to emit smoke.
[18:34:03] <awight>	 !log update SmashPig from 5cadcf3abcfcda4552b068c783337d82b743e2e5 to aa1614afa845358669208c2f6c4cd62e83a98f4c
[18:34:09] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[18:34:37] <awight>	 Let the failmail fun begin
[18:35:40] <ejegg>	 awight: not stopping any jobs?
[18:36:55] <awight>	 hehe
[18:38:22] <awight>	 fail
[18:38:36] <awight>	 !log Paused Adyen SmashPig job runner
[18:38:43] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[18:39:13] <awight>	 !log Reenable Adyen SmashPig job runner
[18:39:21] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[18:39:55] <awight>	 !log Disable Adyen SmashPig runner and just stop spamming the server admin log.
[18:40:03] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[18:40:35] <awight>	 Well... 20 minutes to figure this out before the recurring GC job runs
[18:42:00] <awight>	 missing the yaml library
[18:44:54] <grrrit-wm>	 (PS1) Awight: Update libraries; add YAML [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/290289
[18:45:06] <grrrit-wm>	 (CR) Awight: [C: 2] "Self-merging libraries" [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/290289 (owner: Awight)
[18:45:38] <grrrit-wm>	 (CR) Awight: [V: 2] Update libraries; add YAML [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/290289 (owner: Awight)
[18:46:14] <grrrit-wm>	 (PS1) Awight: Update libraries; add YAML lib [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290291
[18:46:28] <grrrit-wm>	 (CR) Awight: [C: 2] "Self-merging libraries." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290291 (owner: Awight)
[18:47:58] <awight>	 crap.  Listeners are down
[18:48:00] <awight>	 of course
[18:48:21] <awight>	 Looks like deploying the fix will take the same amount of time as rolling back.
[18:49:19] * awight taps foot
[18:50:24] <awight>	 !log Rollback SmashPig from aa1614afa845358669208c2f6c4cd62e83a98f4c to 5cadcf3abcfcda4552b068c783337d82b743e2e5
[18:50:31] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[18:50:54] <awight>	 Or... I'll have to wait 30 minutes for zuul
[18:56:25] <awight>	 wtF.  The CI tests are running for the 3rd time
[18:57:23] <grrrit-wm>	 (CR) Hashar: "recheck" [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290281 (https://phabricator.wikimedia.org/T135906) (owner: Ejegg)
[19:01:07] <awight>	 !log update SmashPig from 5cadcf3abcfcda4552b068c783337d82b743e2e5 to f0bf4385afac65a27f99c5f657c3d0931c991fa8
[19:01:15] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[19:01:53] <awight>	 !log rollback SmashPig from f0bf4385afac65a27f99c5f657c3d0931c991fa8 to 5cadcf3abcfcda4552b068c783337d82b743e2e5
[19:02:01] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[19:02:08] <awight>	 This calls for a person who has eaten lunch.
[19:05:48] <grrrit-wm>	 (CR) Ejegg: [C: 2] Follow-up ceffd37e68 Fix parser test that broke [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290281 (https://phabricator.wikimedia.org/T135906) (owner: Ejegg)
[19:52:49] <grrrit-wm>	 (PS2) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290267
[20:00:33] <grrrit-wm>	 (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290267 (owner: Ejegg)
[20:06:40] <grrrit-wm>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/290267 (owner: Ejegg)
[20:23:58] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Unplanned-Sprint-Work: Revisit Adyen missing donor info behavior - https://phabricator.wikimedia.org/T136038#2321030 (Ejegg)
[20:28:41] <wikibugs>	 Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-74-P: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2321052 (dr0ptp4kt)
[20:42:48] <wikibugs>	 Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-74-P: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2321059 (dr0ptp4kt) @DStrine, would you please confirm whether this is the...
[20:52:31] <awight>	 Nice deploy code: roqr
[20:52:51] <awight>	 !log Update SmashPig from 5cadcf3abcfcda4552b068c783337d82b743e2e5 to f0bf4385afac65a27f99c5f657c3d0931c991fa8
[20:52:58] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[20:53:13] <awight>	 ohKAY, looks like that one might stick.
[20:55:22] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2236963 (awight) The last steps before we mark as resolved a...
[20:56:40] <awight>	 AndyRussG: Are you reviewing anything at the moment?  I'm about to grab the top CR task or two
[21:05:02] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2321102 (a...
[21:07:00] <ejegg>	 awight: about to deploy donationInterface, including moving paypal to a subdir
[21:07:11] <ejegg>	 in case you want to watch
[21:07:13] <awight>	 Thanks!
[21:07:14] <awight>	 sure
[21:07:48] <awight>	 ack, no bucket for paypal
[21:09:23] <ejegg>	 !log updated payments from 76b5c559e08b340fb3d66254b27f624a9c0a4b95 to e6807395d7687d521070b83d159b77b242e5c04f
[21:09:30] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[21:11:01] <ejegg>	 !log rolled back payments to 76b5c559e08b340fb3d66254b27f624a9c0a4b95
[21:11:08] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[21:12:56] <awight>	 Hrm > Your request failed due to technical difficulties.Please try again after some time.
[21:13:26] <awight>	 I'm getting failure in the PayPal console
[21:14:00] <cwd>	 awight: why have the paypal deps in the composer autoloader instead of the mw one?
[21:14:10] <awight>	 uhh
[21:14:30] <awight>	 just to have things self-contained I guess
[21:14:49] <cwd>	 idgi
[21:14:56] <ejegg>	 !log updated payments from 76b5c559e08b340fb3d66254b27f624a9c0a4b95 to e6807395d7687d521070b83d159b77b242e5c04f
[21:15:00] <cwd>	 the paypal code is outside vendor...
[21:15:04] <awight>	 MBeat: heads up, there might be a flurry of failures from PayPal donors
[21:15:15] <awight>	 cwd: I guess I'm not sure what you mean
[21:15:19] <MBeat>	 ty for heads up
[21:15:37] <awight>	 cwd: I think the dependencies should be in the composer.json nearest to the code
[21:16:02] <awight>	 r u saying that we should rely on composer-merge-plugin or something?
[21:16:07] <cwd>	 i must be misunderstanding
[21:16:18] <ejegg>	 awight: I just made a successful $1 donation via the legacy gateway
[21:16:23] <awight>	 harrumph
[21:16:30] <awight>	 maybe I have no pay pals
[21:17:03] <cwd>	 yeah nm i was just confused
[21:17:18] <ejegg>	 logs are looking pretty normal
[21:18:34] <awight>	 unfortunately, PP is one of the methods where we call it success when someone gets redirected away
[21:36:27] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2321219 (awight)
[21:36:36] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2321237 (awight) p:Triage>High
[21:37:09] <grrrit-wm>	 (PS1) Ejegg: Add 'rcc' as a payment method in formsettings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290354
[21:37:19] <ejegg>	 awight: ^^^
[21:38:10] <awight>	 uh
[21:38:36] <awight>	 it shouldn't be a payment method, just a method code in the utm_source
[21:38:53] <awight>	 i.e. nothing about that changed recently
[21:39:02] * awight squints at the banner code
[21:40:05] <awight>	 ejegg: https://meta.wikimedia.org/wiki/MediaWiki:FR2013/Resources/BannerFormCore.js is where you were looking?
[21:40:20] <awight>	 full_dotted_payment_method should only be used to build utm_source
[21:40:47] <ejegg>	 ah, nvm
[21:41:04] <awight>	 I think that one got me a few weeks ago, too
[21:41:21] <grrrit-wm>	 (Abandoned) Ejegg: Add 'rcc' as a payment method in formsettings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290354 (owner: Ejegg)
[21:41:26] <awight>	 https://meta.wikimedia.org/w/index.php?title=MediaWiki:FR2013/Resources/BannerFormCore.js&diff=15484967&oldid=15070860
[21:41:57] <ejegg>	 ah right
[21:42:32] <ejegg>	 well, if that deploy is looking good i'mma go offline for a bit
[21:42:42] <awight>	 see you tomorrow!
[21:42:49] <ejegg>	 see ya later!
[21:57:01] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen, and 2 others: Allow custom fallback message language - https://phabricator.wikimedia.org/T135254#2293336 (awight) What's the business case for this?  It seems incredibly hacky to have our...
[22:02:24] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Unplanned-Sprint-Work: Revisit Adyen missing donor info behavior - https://phabricator.wikimedia.org/T136038#2321311 (awight) p:Triage>High
[22:04:08] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Unplanned-Sprint-Work: Revisit Adyen missing donor info behavior - https://phabricator.wikimedia.org/T136038#2321030 (awight)
[22:04:10] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2321313 (a...
[22:04:20] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel... - https://phabricator.wikimedia.org/T128812#2086811
[22:09:55] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen, and 2 others: Allow custom fallback message language - https://phabricator.wikimedia.org/T135254#2321328 (awight) OK @DStrine explained to me a bit.  I'd like to make this change in media...
[22:13:04] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2321335 (awight)
[22:16:52] <grrrit-wm>	 (PS1) AndyRussG: ext.centralNotice.display: API for registering tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286)
[22:17:35] <AndyRussG>	 awight: cwd: ejegg|afk: ^ untested but very simple
[22:19:59] <awight>	 AndyRussG: Thanks!  Just drop that into the review column whenever you're ready to hand it off...
[22:20:35] <cwd>	 any reason we shouldn't direct support people from the processors to phab?
[22:20:57] <cwd>	 could be a lot nicer than the email chains
[22:21:13] <awight>	 cwd: We could try, but people generally want to work in their own tracking systems
[22:21:29] <cwd>	 the customer is always right!
[22:21:50] <awight>	 even if that tracking system is email chains bulky enough to crash your phone
[22:25:11] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Unplanned-Sprint-Work: Adyen smashpig job runner failing - https://phabricator.wikimedia.org/T135803#2321365 (cwdent) It's looking a lot like a legit 404.  Turning the job on again the next day results in the audit file being downloaded and...
[22:27:03] <AndyRussG>	 awight: drop't!
[22:27:09] <AndyRussG>	 Just recall, totally untested...
[22:28:31] <awight>	 that's what I deserve for my own exclusively haphazard spewing of patches :p
[22:33:50] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Spike: investigate negative scroll offset for cancelling "banner bump" - https://phabricator.wikimedia.org/T107967#2321424 (AndyRussG) >>! In T107967#2315231, @Nemo_bis wrote: >>>! In T107967#2310344, @AndyRussG wrote: >> Hi @TheDJ... Can...
[22:35:55] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2321439 (awight) The fix is to deploy a new SmashPig.yaml from my home dir on the deployment master.
[22:36:39] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2321219 (awight) @Jgreen  This one is pretty high priority--please comment here once you have a chance to dep...
[22:42:27] <cwd>	 awight: is it weird that i can't find the mentioned SPCID log ID from the jenkins log anywhere on the log server?
[22:42:33] <cwd>	 when this thing fails the download
[22:43:39] <awight>	 hrm
[22:43:50] <awight>	 can you find it in /var/log/syslog on the job running machine?
[22:44:00] <cwd>	 lessee
[22:44:07] <awight>	 should be bucketed into fundraising-misc I believe
[22:44:49] <cwd>	 don't see it...
[22:44:52] <cwd>	 that is one big file though
[22:46:10] <awight>	 cwd: It probably got rotated
[22:58:05] <awight>	 cwd: You want to sync up on the PayPal stuff at any point?  I'd be happy to take back the cookie unless you're looking forward to it for some strange reason.
[22:58:44] <cwd>	 sure yeah either way we should talk about it
[22:58:53] <cwd>	 it seems pretty close to me...
[23:03:20] <awight>	 +1.  I don't particularly remember where we're at with that.
[23:03:46] <awight>	 https://phabricator.wikimedia.org/project/board/1996/query/nBN.DhNNyhNG/
[23:04:06] <awight>	 I guess I'm waiting on CR, then
[23:04:25] <awight>	 Want to try live CR on a video call or anything?
[23:05:20] <wikibugs>	 Fundraising-Backlog: Generate of list of CN admins active in the last 12 months - https://phabricator.wikimedia.org/T136050#2321476 (DStrine)
[23:07:23] <cwd>	 aaah yeah elliott made a few comments on there
[23:08:30] <cwd>	 https://gerrit.wikimedia.org/r/#/c/286117/
[23:12:32] <awight>	 oh good, thanks!
[23:13:43] <cwd>	 awight: would love to get on a call, but would tomorrow be ok?  i have to start packing up the house now
[23:14:26] <awight>	 wfm!  good luck
[23:14:40] <cwd>	 ty...
[23:14:42] <cwd>	 have a good one!
[23:24:21] <grrrit-wm>	 (PS26) Awight: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811)
[23:26:30] <grrrit-wm>	 (CR) Awight: "We use the isodate in @I8761b077cdccfc693176f15d3efeca83904cb5ff" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287171 (owner: Awight)
[23:28:25] <grrrit-wm>	 (Abandoned) Awight: Prevent HTTP continuations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288256 (owner: Awight)
[23:32:56] <grrrit-wm>	 (PS4) Awight: Use PROTO_CURRENT for paypal urls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811) (owner: Cdentinger)
[23:33:52] <grrrit-wm>	 (CR) Awight: [C: 2] "Good find! Please bless my change to globalcollect.adapter.php when you have a moment." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811) (owner: Cdentinger)
[23:36:34] <grrrit-wm>	 (PS1) Awight: We don't care to get failmail when banner history import fails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290372
[23:37:24] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2321554 (Eileenmcnaughton) Note to self re command : drush cvapi Job.proces...
[23:54:12] <grrrit-wm>	 (CR) Awight: "Looks good so far, but I still need to test." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG)
[23:54:32] <awight>	 commuting...