[00:43:28] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2321649 (Jgreen) Done! [01:03:25] (PS2) AndyRussG: ext.centralNotice.display: API for registering tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) [01:11:43] (CR) AndyRussG: "Thx!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG) [01:11:56] (CR) AndyRussG: ext.centralNotice.display: API for registering tests (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG) [02:22:02] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Patch-For-Review: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2321818 (Ejegg) Definitely somethi... [03:13:37] (CR) Ejegg: [C: 2] We don't care to get failmail when banner history import fails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290372 (owner: Awight) [03:29:39] (Merged) jenkins-bot: We don't care to get failmail when banner history import fails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290372 (owner: Awight) [03:39:46] (PS27) Ejegg: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [03:42:01] (CR) Ejegg: [C: 2] "Awesome! And so much in config, not code. One TODO in that vein." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [03:43:23] (Merged) jenkins-bot: Rough PayPal Express Checkout integration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286117 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [03:45:45] (PS3) Ejegg: Implement IsoDate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287171 (owner: Awight) [03:48:10] (CR) Ejegg: [C: 2] Implement IsoDate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287171 (owner: Awight) [03:48:34] (PS5) Ejegg: Use PROTO_CURRENT for paypal urls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811) (owner: Cdentinger) [03:49:42] (Merged) jenkins-bot: Implement IsoDate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287171 (owner: Awight) [03:51:40] (CR) Ejegg: [C: 2] "Consistent behavior independent of wgServer config!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811) (owner: Cdentinger) [03:51:51] (PS6) Ejegg: Use PROTO_CURRENT for paypal urls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811) (owner: Cdentinger) [03:54:07] (CR) Ejegg: [C: 2] Use PROTO_CURRENT for paypal urls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811) (owner: Cdentinger) [03:56:38] (Merged) jenkins-bot: Use PROTO_CURRENT for paypal urls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289102 (https://phabricator.wikimedia.org/T131811) (owner: Cdentinger) [04:03:32] (CR) Ejegg: "Nothing paypal-specific in the code - I'd say go with that todo now and move it out of the paypal dir." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287157 (https://phabricator.wikimedia.org/T131811) (owner: Awight) [04:07:12] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Catch email address typos early - https://phabricator.wikimedia.org/T135567#2321877 (Ejegg) Open>Resolved [04:07:47] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, I18n, Patch-For-Review, and 2 others: Adyen Hebrew UI bugs - https://phabricator.wikimedia.org/T135416#2321879 (Ejegg) [04:07:48] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Amounts displayed in DonationInterface forms should be localized - https://phabricator.wikimedia.org/T93196#2321878 (Ejegg) Open>Resolved [04:08:25] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel... - https://phabricator.wikimedia.org/T128812#2321882 [04:08:27] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Setup Japanese form for Adyen - https://phabricator.wikimedia.org/T135418#2321880 (Ejegg) Open>Resolved [04:08:53] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Astropay, and 2 others: Re-create pending queue messages for AstroPay donations - https://phabricator.wikimedia.org/T135856#2321883 (Ejegg) Open>Resolved [04:11:47] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, I18n, Patch-For-Review, and 2 others: Adyen Hebrew UI bugs - https://phabricator.wikimedia.org/T135416#2321889 (Ejegg) @Amire80, if you have some time to take another look at this, it would be great to hear your feedback. We've deployed... [04:49:49] Crazy kids. [05:39:26] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2293336 (Nemo_bis) I see curious a... [05:40:57] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2321929 (Nemo_bis) [05:40:59] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2321928 (Nemo_bis) [05:41:13] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2293336 (Nemo_bis) [05:41:58] (CR) Nemo bis: "Declined, please abandon. I suggest you fix https://phabricator.wikimedia.org/T96552 instead." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) (owner: Ejegg) [06:33:33] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel... - https://phabricator.wikimedia.org/T128812#2321956 [06:39:26] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Unplanned-Sprint-Work: Setup Japanese form for Adyen - https://phabricator.wikimedia.org/T135418#2321963 (TerraCodes) [08:10:36] (PS1) Awight: Freak out when merging config nodes of different types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290400 (https://phabricator.wikimedia.org/T136043) [08:10:38] (PS1) Awight: Maintenance script to dump the config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290401 [08:36:01] (PS2) Awight: Freak out when merging config nodes of different types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290400 (https://phabricator.wikimedia.org/T136043) [08:36:03] (PS2) Awight: Maintenance script to dump the config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290401 [08:36:05] (PS1) Awight: Fix Amazon credentials config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290408 (https://phabricator.wikimedia.org/T136043) [08:37:33] (CR) jenkins-bot: [V: -1] Freak out when merging config nodes of different types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290400 (https://phabricator.wikimedia.org/T136043) (owner: Awight) [08:37:42] (CR) jenkins-bot: [V: -1] Maintenance script to dump the config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290401 (owner: Awight) [08:38:20] (CR) jenkins-bot: [V: -1] Fix Amazon credentials config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290408 (https://phabricator.wikimedia.org/T136043) (owner: Awight) [08:57:27] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel... - https://phabricator.wikimedia.org/T128812#2322120 [09:23:45] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, and 2 others: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2322146 (awight) I missed the real problem with my last fix--the &CREDENTIALS block is reused in yaml, so our amazon.crede... [09:25:42] (PS2) Awight: Refactor Amazon credentials config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290408 (https://phabricator.wikimedia.org/T136043) [09:25:44] (PS3) Awight: Freak out when merging config nodes of different types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290400 (https://phabricator.wikimedia.org/T136043) [09:25:46] (PS3) Awight: Maintenance script to dump the config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290401 [09:25:48] (PS1) Awight: Correct bad commandline defaults [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290416 [10:19:48] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-74-P: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2322263 (Jhernandez) [12:31:47] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2322613 (Ejegg) duplicate>O... [12:32:55] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2322618 (Ejegg) [12:32:57] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2322617 (Ejegg) [12:36:30] Fundraising-Backlog, FR-Adyen: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#2322620 (Ejegg) @jrobell, any opinion on how we handle this, given that @Amire80 says Israeli users will often type their name in Hebrew in the contact form, then in Latin characters in... [15:13:38] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2323098 (Nemo_bis) > DonationInter... [16:01:47] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2323326 (Ejegg) The intent is not... [16:21:49] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Unplanned-Sprint-Work: Adyen smashpig job runner failing - https://phabricator.wikimedia.org/T135803#2323421 (cwdent) Open>Resolved a:cwdent Confirmed from Adyen they are sending the message before the report is ready. Closing t... [16:24:25] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2323432 (Nemo_bis) Ok, then I reph... [16:25:40] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel... - https://phabricator.wikimedia.org/T128812#2323443 [16:29:14] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel... - https://phabricator.wikimedia.org/T128812#2323468 [16:33:00] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2323482 (Ejegg) We're not trying t... [16:39:21] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2323492 (Ejegg) It seems that core... [17:06:28] Fundraising-Backlog, fundraising-tech-ops: Try fail2ban on payments - https://phabricator.wikimedia.org/T136110#2323572 (cwdent) [17:13:18] (CR) Cdentinger: "Call me old fashioned but I think an actual firewall is better than doing this at the application layer. Stops attacks before they ever h" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289893 (owner: Ejegg) [17:14:25] Fundraising-Backlog, fundraising-tech-ops: Allow fr-tech to block IPs - https://phabricator.wikimedia.org/T136111#2323611 (cwdent) [17:22:09] cwd: and ejegg I'm discussing adyen with awight.. I noticed this is resolved: https://phabricator.wikimedia.org/T135803 but do we need adyen to complete something on their end to fix this? [17:22:53] yep [17:23:03] sorry if resolved was the wrong course [17:23:11] i was just happy that it's their fault [17:23:51] lol um we don't really have a good way to track open tasks on a erd party... we also don't have pats to escalate to right now [17:24:00] *3rd party [17:24:04] yeah [17:24:10] what do we need to aske them to do? [17:24:34] they're on it already, they opened an issue with their engineering team [17:25:16] oh ok I see that email [17:25:46] just to be clear, this would prevent us from testing france, correct? [17:26:25] i don't think _this_ would, but didn't some other thing come up that was blocky? [17:26:47] this prevents us from importing audit files (mainly refunds) in a timely manner [17:26:55] but doesn't seem to affect incoming donations [17:26:58] as far as i know [17:27:57] ok [17:28:17] this one got mentioned https://phabricator.wikimedia.org/T136038 [17:28:25] i don't know how srs it is [17:28:40] yeah I was just about to ask that [17:28:49] ejegg: and awight? [17:29:28] dstrine: we need to figure that out [17:29:29] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-WMF-Audit, Unplanned-Sprint-Work: Adyen smashpig job runner failing - https://phabricator.wikimedia.org/T135803#2323698 (DStrine) [17:29:44] ejegg: ok [17:29:54] not sure it those were just from the queue fails, or if the frontend isn't sending the data correctly [17:31:04] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, FR-Smashpig, Unplanned-Sprint-Work: Revisit Adyen missing donor info behavior - https://phabricator.wikimedia.org/T136038#2321030 (awight) * Check whether we're still seeing attempted double-charges. * If so, expand the sco... [17:40:50] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Repair Amazon donations skipped by the auth job; document workflow - https://phabricator.wikimedia.org/T136116#2323754 (awight) [17:41:25] (PS3) Ejegg: Bypass built-in Mediawiki language fallbacks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) [17:42:47] (CR) jenkins-bot: [V: -1] Bypass built-in Mediawiki language fallbacks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) (owner: Ejegg) [17:43:40] Strange. Why is the old message archiver trying to access the "test" queue?? /job/AMQ Old Message Consume/846/QUEUE_DATA=pending.20/console [17:43:48] Hopefully that's related to the bad config. [17:45:08] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2323807 (Ejegg) OK, I think I foun... [17:51:58] Fundraising-Backlog, FR-Adyen: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#1956762 (DStrine) @Ejegg I just discussed this with @jrobell and hebrew seems to be a special case. We don't have any other info for non-latin scripts and we wouldn't want to seem cul... [18:07:28] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Repair Amazon donations skipped by the auth job; document workflow - https://phabricator.wikimedia.org/T136116#2323886 (awight) [18:09:28] Jeff_Green: fyi, the last SmashPig config deployment seems to have charmed our demons back into their bottle. [18:09:45] yayyyy demons! [18:10:38] http://2.bp.blogspot.com/-FnIMt2QvlYQ/TqF7fQnZ1QI/AAAAAAAALbk/sk7VPEIOrvg/s1600/a2.jpg [18:11:32] awight: should we let it settle for a day or two now, or delete the old *.php version now? [18:11:41] I think settlement is in order [18:11:46] I'm batting about .100 [18:11:56] hahahah yeah ok [18:14:04] Jeff_Green: Do you have a snap judgement about whether it's worth anything to get more of our config into a developer deployment regimen, or do you think it's worth a conversation? [18:14:17] * awight blinks at own lack of grammar [18:14:59] awight: my kneejerk reaction is that generally things go better if production is handled with beaker tongs rather than super hands-on intervention. [18:15:16] k, that sounds more than fair [18:15:25] which is to say...prototype and test more before deploying, and deployments should be really well mapped out [18:15:27] I think I made that case pretty well over the last 24hr [18:15:59] and... deployments should be made during business hours... [18:15:59] i think my perspective might fly directly in the face of the whole devops trend [18:16:37] yeah that too, I didn't think about it at the time but we should have done that as a more formal maintenance window [18:16:59] I've been that guy, at smaller shops, and definitely prefer this. It's very nice to have someone with rubber gloves on throw the switch, leaving me to just watch logs [18:17:13] yah. I was guaranteed to blow something up. [18:17:58] that said I'm not opposed to designing things devs can tweak, they just need to be designed such that there's very low likelihood of explosions and shards [18:19:14] We're approaching an interesting situation, though. More of our apps are moving into configuration, and the default config is shipped along with source code. Eventually, /etc will only contain our production overrides [18:19:36] Which sort of puts us back in the scary place of having a backdoor to deploy most config changes ourselves. [18:20:01] == maximum shrapnel [18:24:01] i'm not sure what you mean by apps moving into configuration? [18:24:09] you mean configuration moving into the app? [18:24:28] (PS4) Ejegg: Bypass built-in Mediawiki language fallbacks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) [18:24:56] Jeff_Green: lots of name->value arrays that were mixed in with php code [18:25:10] Jeff_Green: err, for example in DonationInterface we've been moving all of the simple business logic into flat files: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/tree/master/globalcollect_gateway/config [18:25:16] oic [18:25:17] are now in yaml file [18:25:19] s [18:25:22] And the process is pretty far along with SmashPig [18:25:24] i think that's actually not bad [18:25:39] because you have peer review and audit trails on code deployments [18:26:34] if we can layer that with a minimal overlay of sensitive/production values that are blatted out of puppet, that seems pretty sane to me [18:26:38] It's great, but it blurs the line between business logic changes which developers should handle, and static configuration and sensitive things which should have some access control [18:26:45] +1 [18:28:35] can we get it down to pretty much everything in phabricator except things like passwords and hostnames? [18:29:14] found a better hook for language fallback override: https://gerrit.wikimedia.org/r/289117/ [18:30:17] Jeff_Green: Sorry I'm not clear on "everything in Phabricator" [18:31:45] awight: code and generic config == everything [18:32:00] vs hostnames/usernames/passwords/keys in puppet [18:32:19] Ah--and Phabricator=source code repository :p. [18:32:22] totally [18:32:28] and I'd love to split up all our config so that secrets can come from a separate file. [18:32:37] yeah [18:32:57] It's possible already with SmashPig. [18:33:41] we do a recursive merge of /etc/fundraising/SmashPig.yaml, ~/.fundraising/SmashPig.yaml (for development and testing), and SmashPig/SmashPig.yaml [18:34:10] All I have to do to get there is to remove everything from /etc which is redundant with the defaults [18:34:23] nice [18:35:10] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Smashpig, Technical-Debt: Remove redundant SmashPig from /etc - https://phabricator.wikimedia.org/T136121#2323965 (awight) [18:35:12] ^ that one [18:37:08] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Repair Amazon donations skipped by the auth job; document workflow - https://phabricator.wikimedia.org/T136116#2323987 (awight) @MBeat33 The next time you find yourself in the Amazon con... [18:39:12] ejegg: The language workarounds are elegant, but wouldn't it be better to be consistent with mediawiki-core? [18:39:19] Fundraising-Backlog, FR-Adyen: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#2323989 (Ejegg) OK, so show (empty) for Hebrew and autofill+hide for the rest? [18:39:45] awight: yep, that'd be nice, but there seems to be significant resistance to changing the fallback there [18:40:41] see https://phabricator.wikimedia.org/T39314 , the -1s on https://gerrit.wikimedia.org/r/290362 [18:41:11] I noticed! But I still I feel like we should have the broader conversation, and if it's declined again we should seriously reconsider doing a rogue job of it ourselves. [18:41:31] Thanks for all the help pushing on the core issue, btw! [18:43:57] awight: I'm a little confused how https://gerrit.wikimedia.org/r/#/c/290408/2 changes anything [18:44:35] ejegg: It's just so that I don't go crazy again [18:44:37] it looks like the old thing was a reference to an array that contained a map [18:44:48] It will result in the same data going to the Amzn library [18:44:57] and the new thing is an array that contains a reference to a map [18:45:16] But I think "credentials" is a good place to be normal, and inst-args is where we actually need the argv[0] syntax [18:45:33] ah, ok, that makes sense [18:45:40] * awight chuckles at "amzn". [18:45:51] Why didn't they just take *all* the vowels out... [18:45:56] The payment processor that shall not be named [18:46:43] (CR) Ejegg: [C: 2] "Makes sense. TODO: move/delete invalid comment" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290408 (https://phabricator.wikimedia.org/T136043) (owner: Awight) [18:47:08] ejegg: what invalid comment? [18:47:17] oh heh I see [18:48:09] (PS1) Awight: Remove bad comment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290515 [18:49:05] (Merged) jenkins-bot: Refactor Amazon credentials config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290408 (https://phabricator.wikimedia.org/T136043) (owner: Awight) [18:49:15] Fundraising-Backlog, FR-Adyen: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#2324011 (DStrine) yes Thanks! [18:49:37] ejegg: Hey, can I pick your brain about the Amazon workflow... [18:49:49] awight: sure [18:50:11] It looks like auditing will catch most of the stuff [18:50:35] you figure we should make the pending data stuff more like adyen's? Or vice-versa? [18:50:37] sorry, I'm IRL for a sec [18:51:49] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Repair Amazon donations skipped by the auth job; document workflow - https://phabricator.wikimedia.org/T136116#2324014 (MBeat33) @awight: P01-3809672-0020363 payment status Open P01-8924... [18:53:57] awight, looks like there are 29 open Amazon transactions at portal: normally we settle these manually; should we sit on these recent ones or process them? [18:55:31] MBeat: I think you can settle those manually [18:55:39] cool, thx [18:56:02] is that a consistent issue, or do they mostly come up when there are queue / listener troubles? [19:02:06] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: Wikimedia Foundation wikis: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2324037 (... [19:02:59] (CR) Ejegg: [C: 2] "Good to have. PHP is weird for letting you pass the ref and the value in and treating them the same. The list vs map test is a little co" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290400 (https://phabricator.wikimedia.org/T136043) (owner: Awight) [19:03:13] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: Wikimedia Foundation wikis: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2293336 (... [19:03:45] MBeat: hooray! Great news that you can settle manually, thank you. [19:04:00] happy to :) [19:04:44] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Repair Amazon donations skipped by the auth job; document workflow - https://phabricator.wikimedia.org/T136116#2324054 (awight) MBeat33 is going to settle the 29 affected transactions ma... [19:05:40] MBeat: I hope you don't have to do that too often! Do a lot fall through the cracks normally, or is it just when we have technical difficulties? [19:06:35] actually awight ejegg the portal’s giving me errors when I go to Collect on these. Normally some do fall through so during high volume times we check every day [19:07:06] noooo [19:07:10] okay thanks [19:07:46] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Document Amazon transaction workflow; make settlement more robust - https://phabricator.wikimedia.org/T136116#2324056 (awight) [19:08:33] MBeat: Want me to email our account rep about the failure? [19:09:05] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Document Amazon transaction workflow; make settlement more robust - https://phabricator.wikimedia.org/T136116#2323754 (awight) [19:09:26] MBeat: oops, ejegg already on it in the private channel [19:09:37] (Merged) jenkins-bot: Freak out when merging config nodes of different types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290400 (https://phabricator.wikimedia.org/T136043) (owner: Awight) [19:11:53] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Document Amazon transaction workflow; make settlement more robust - https://phabricator.wikimedia.org/T136116#2324070 (awight) [19:12:27] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Amazon, FR-Smashpig, Unplanned-Sprint-Work: Document Amazon transaction workflow; make settlement more robust - https://phabricator.wikimedia.org/T136116#2324078 (MBeat33) Argh, Amazon is showing an error when we try to collect th... [19:22:57] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Smashpig, Technical-Debt: Remove redundant SmashPig config from /etc - https://phabricator.wikimedia.org/T136121#2324109 (awight) [19:55:11] (CR) Ejegg: [C: 2] "nice to have!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290401 (owner: Awight) [19:56:37] (Merged) jenkins-bot: Maintenance script to dump the config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290401 (owner: Awight) [20:04:51] Fundraising-Backlog, fundraising-tech-ops: Allow fr-tech to block IPs - https://phabricator.wikimedia.org/T136111#2324227 (DStrine) p:Triage>Normal a:Jgreen [20:05:07] Fundraising-Backlog, fundraising-tech-ops: Try fail2ban on payments - https://phabricator.wikimedia.org/T136110#2324230 (DStrine) p:Triage>Normal a:Jgreen [20:08:34] Fundraising-Backlog: Generate of list of CN admins active in the last 12 months - https://phabricator.wikimedia.org/T136050#2321476 (awight) Basic idea: log into labs and get access to the metawiki database replica. query something like, "select distinct user from cn_logs where date > date_sub(now(), 1 year... [20:10:22] Fundraising Tech Backlog, Fundraising-Backlog, FR-ActiveMQ, Patch-For-Review: another round of activemq queue decrufting needed - https://phabricator.wikimedia.org/T134916#2324251 (DStrine) [20:10:34] Fundraising Tech Backlog, Fundraising-Backlog, FR-ActiveMQ, Patch-For-Review: another round of activemq queue decrufting needed - https://phabricator.wikimedia.org/T134916#2282095 (DStrine) Open>Resolved [20:11:06] Fundraising-Backlog, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Payments vagrant role has duplicated settings, needs more documentation - https://phabricator.wikimedia.org/T135653#2324258 (DStrine) p:Triage>Low [20:11:45] Fundraising-Backlog, FR-Adyen, FR-WMF-Audit: Adyen refunds: look at reconciliation / auditing to make sure they get to Civi - https://phabricator.wikimedia.org/T135641#2324263 (awight) [20:45:18] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Documentation, FR-Amazon, and 2 others: Document Amazon transaction workflow; make settlement more robust - https://phabricator.wikimedia.org/T136116#2324438 (Danny_B) [21:05:44] (PS5) Ejegg: Bypass built-in Mediawiki language fallbacks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) [21:12:04] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Smashpig, Technical-Debt: Remove redundant SmashPig config from /etc - https://phabricator.wikimedia.org/T136121#2324545 (awight) @Jgreen No rush, but I've trimmed the remaining fat and uploaded a new SmashPig.yaml to my deployment h... [21:14:40] awight: Do you know the status of Sitesupport-url overrides on local wiki? [21:14:51] It seems this is something fundraising used to do in 2013 but not anymore [21:15:01] Krinkle: I don't recognize that message [21:15:07] however many smaller wikis still have those overrides in place (originally put in place by staff accounts) [21:15:10] E.g. https://mr.wikipedia.org/wiki/%E0%A4%AE%E0%A4%BF%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A5%80:Sitesupport-url [21:15:27] Producing urls to C12 or C13 - //donate.wikimedia.org/wiki/Special:FundraiserRedirector?utm_source=donate&utm_medium=sidebar&utm_campaign=C13_mr.wikipedia.org&uselang=mr [21:15:31] Used by the sidebar [21:15:33] Ah interesting! That accounts for some of our random referrers [21:15:48] I'm cleaning up CSS and JS on old wikis and almost all of them have tehis [21:15:56] AFAIK we can get rid of those, but we could check with the-wub [21:17:11] (PS1) Awight: Add minor comments to the config file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290584 [21:17:23] awight: Also a lot of them have really really old banners created by Common.js - however contrary to sitesupport-url, these are not put on those wikis by fundraising staff, rather, they were accidentally copied by community admins from en.wiki when copying their common.js [21:17:35] For example, browsing https://mr.wikipedia.org/wiki/ when logged-out shows a random banner absolutely positioned [21:17:36] in English [21:17:51] See halfway https://mr.wikipedia.org/wiki/MediaWiki:Common.js for the Math.random() based injection [21:18:28] yipes! Please do kill that [21:18:32] (CR) Ejegg: [C: 2] "i agree!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290416 (owner: Awight) [21:19:00] awight: It's too much though, I'd rather someone like Peter does this with his account. [21:19:09] awight: Should I file two tasks? [21:19:48] Good call. I can create the task if that's helpful. [21:20:02] (Merged) jenkins-bot: Correct bad commandline defaults [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290416 (owner: Awight) [21:20:09] Sounds like one overarching task at least: clean up insanely old fundraising cruft [21:20:15] (PS2) Ejegg: Remove bad comment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290515 (owner: Awight) [21:20:26] awight: Sure! I'll see if I can produce a dump once that task exists with a list of affected wikis [21:20:34] (CR) Ejegg: [C: 2] Remove bad comment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290515 (owner: Awight) [21:20:35] awight: It's a never ending task :P [21:22:13] Seddon: hehe lemme use that Phabricator tag [21:23:58] Fundraising-Backlog, Technical-Debt: Clean up onwiki fundraising cruft - https://phabricator.wikimedia.org/T136134#2324593 (awight) [21:24:25] += never ending story [21:35:15] (PS1) Ejegg: Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) [21:35:35] Fundraising-Backlog, Technical-Debt: Clean up onwiki fundraising cruft - https://phabricator.wikimedia.org/T136134#2324616 (Krinkle) [21:36:01] ^^ hebrew is a hard-coded exception there - any burning desire for another config file instead? [21:37:05] (CR) jenkins-bot: [V: -1] Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) (owner: Ejegg) [21:38:18] grr, l10n-bot done me wrong! [21:40:49] hehe [21:40:55] (PS1) Ejegg: Undo l10n adding blank value, breaking tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290591 [21:41:10] is pulling the translation stuff out of DI on the road map? or not worth the trouble [21:41:48] cwd I've got a ticket in there to move all the i18n to the form layer [21:42:19] any messages coming from the bowels of the code should just be a key + params till they get to the UI [21:42:32] (CR) jenkins-bot: [V: -1] Undo l10n adding blank value, breaking tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290591 (owner: Ejegg) [21:42:42] double grr [21:43:22] ??? is that cached [21:43:47] ejegg: hardcoded hack works for me, though it might deserve a FIXME [21:44:14] cool [21:44:29] Fundraising-Backlog, Technical-Debt: Clean up onwiki fundraising cruft - https://phabricator.wikimedia.org/T136134#2324650 (Krinkle) [21:44:37] Wow, the node test sure is annoying [21:44:50] oh, I need to kill one more line in that patch [21:44:55] Maybe it would be less annoying if I had any idea what it was telling us [21:45:36] Translator 'MetalHead64' added two blank values [21:45:43] and that makes tests fail [21:45:58] * awight headbangs waning mane [21:46:13] (PS2) Ejegg: Undo l10n adding blank values, breaking tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290591 [21:46:45] that is some pretty metal translating alright [21:46:49] blank values [21:46:51] Fundraising-Backlog, Technical-Debt: Clean up onwiki fundraising cruft - https://phabricator.wikimedia.org/T136134#2324653 (Krinkle) MediaWiki:Sitesupport-url is overridden with text containing "utm_campaign" on 666 wikis: {P3172} [21:46:59] (PS2) Ejegg: Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) [21:47:52] (PS3) Ejegg: Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) [21:57:54] (PS4) Ejegg: Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) [21:58:08] awight: OK. Posted all the search results. [21:58:49] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen, and 2 others: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#2324681 (Ejegg) a:Ejegg [22:02:01] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Hovercards, Patch-For-Review: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2260911 (awight) The only gotcha I've noticed so far is that the mediaWiki.centralNotice.registerTest call can't happen until the... [22:02:44] Krinkle: Thanks for letting us know, and doing all the footwork! [22:03:09] yw [22:13:49] (PS3) Awight: ext.centralNotice.display: API for registering tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG) [22:14:11] (CR) Awight: ext.centralNotice.display: API for registering tests (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG) [22:14:30] (PS4) Awight: ext.centralNotice.display: API for registering tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG) [22:15:22] (CR) Awight: [C: 2 V: 1] "Works locally. See the bug for the magic spot I found whence to call this function." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG) [22:16:00] Fundraising-Backlog, Documentation, FR-Amazon, FR-Smashpig: Document Amazon transaction workflow; make settlement more robust - https://phabricator.wikimedia.org/T136116#2324749 (awight) [22:18:13] hey awight ejegg just re PPena s email on the Financial type. I don't quite know why things are set up the way they are re financial types etc - but I guess the answer to "Eileen- is there a way to create a 'gateway' for Endowment and still have that granularity?" is no... [22:18:36] (the email titled 'tracking endowment gifts in civi' [22:19:23] eileen: hmm, 'gateway' seems a bit big for that... let's see what else we have to sort by [22:19:42] I see mention of a field 'Gift source' [22:19:49] yah gateway is not right [22:20:19] I think the question is what she wants to achieve with the grouping. Sounds like she would want it to somehow appear in a reconciliation report... [22:20:59] OK cool I'll reply back [22:21:29] it seems like it would fit with how we're using financial type [22:22:05] eileen: You think this might be a good place to start using financial accounts? [22:23:14] awight: I guess financial accounts can provide a grouping of sorts for financial types [22:24:26] fwiw, here are the PayPal EC patches: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/DonationInterface+status:open,n,z [22:25:29] eileen: It would be great to have a little documentation on the different categories we're using, cos this question comes up often... [22:25:50] Maybe this is more something for Major Gifts to write, on the other hand. [22:27:34] (CR) Awight: [C: 2] Undo l10n adding blank values, breaking tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290591 (owner: Ejegg) [22:44:31] (CR) Awight: [C: -1] "Good idea! If we want to add the ability to assign CTID elsewhere, we'll need a CSRF token anyway, so it's fine to remove for now." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T135745) (owner: Ejegg) [22:47:17] (PS6) Awight: remove query string from referrer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289563 (https://phabricator.wikimedia.org/T110564) (owner: Cdentinger) [22:47:22] (CR) Awight: [C: 2] "Good step forward" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289563 (https://phabricator.wikimedia.org/T110564) (owner: Cdentinger) [22:49:06] (CR) jenkins-bot: [V: -1] remove query string from referrer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289563 (https://phabricator.wikimedia.org/T110564) (owner: Cdentinger) [22:51:35] >:| [22:52:10] * awight flogs jenkins [22:52:32] I think it's that empty i18n message--the revert still hasn't merged. [22:53:01] .. 24 minutes later [22:53:34] There's this ridiculous thing where everything in the zuul queue merges in linear order, because theoretically there may be cross-repo dependencies [22:53:54] and it seems that the test re-run each time something at the top of the queue merges. [22:56:09] ejegg|afk: I need a walkthrough of the ip velocity changes, maybe a video call later? [22:56:55] awight: sure, when's good? [22:57:24] now works! Sorry, didn't mean to pull you out of your afkness [22:59:03] awight: also why everything explodes if the top build fails [22:59:11] they all "rebase" [22:59:21] It's barbaric [22:59:44] I can appreciate how hard it must be to keep that card skyscraper from falling in every direction, of course [22:59:51] totally [22:59:55] it's a very hard problem [23:00:02] awight: in a half hour ok? [23:00:19] ejegg: sure! I might have to run at 4:45 or so, but that should be plenty of time [23:00:27] we could probably define sets of things that can be run in parallel [23:00:42] but there would problems [23:01:10] _but_ if there was one exception it should probably be fundraising [23:01:26] I think the main problem they're dealing with is that zuul and gearman are incredibly janky, so any adjustment brings all kinds of extra pain raining down [23:10:27] (CR) Awight: [C: 2] "Nice improvements!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288542 (owner: Ejegg) [23:11:29] (CR) Awight: [C: 2] "Yes!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [23:12:06] (PS2) Awight: Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [23:12:40] (CR) Awight: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [23:13:44] (CR) jenkins-bot: [V: -1] Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [23:13:48] awight: ok, ready to chat if you are [23:14:09] * awight reluctantly sets down KALX ;) [23:14:13] https://plus.google.com/hangouts/_/wikimedia.org/awight-eegglest?authuser=0 [23:21:22] (Merged) jenkins-bot: ext.centralNotice.display: API for registering tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG) [23:21:26] (Merged) jenkins-bot: Undo l10n adding blank values, breaking tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290591 (owner: Ejegg) [23:28:10] (Merged) jenkins-bot: remove query string from referrer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289563 (https://phabricator.wikimedia.org/T110564) (owner: Cdentinger) [23:31:22] (CR) Awight: Fire IP velocity filter early (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289809 (owner: Ejegg) [23:44:53] (PS4) Ejegg: Fire IP velocity filter early [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289809 [23:55:21] (PS7) Ejegg: Add GatewayInitialFilter hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289801 [23:57:09] (PS4) Ejegg: Persist risk score array in session [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289804 [23:57:43] (PS5) Ejegg: Fire IP velocity filter early [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289809 [23:59:31] (Merged) jenkins-bot: Harmonize required field calculation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288542 (owner: Ejegg) [23:59:33] (CR) jenkins-bot: [V: -1] Add order ID to pending queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg)