[00:01:23] (PS3) Ejegg: Add order ID to pending queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 (https://phabricator.wikimedia.org/T133195) [00:15:17] (PS3) Ejegg: Disallow setting contribution tracking ID from request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T135745) [00:16:35] (PS4) Ejegg: Disallow setting contribution tracking ID from request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T135745) [00:17:28] (PS2) Ejegg: Add minor comments to the config file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290584 (owner: Awight) [00:17:35] (CR) Ejegg: [C: 2] Add minor comments to the config file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290584 (owner: Awight) [00:50:21] (PS1) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [00:54:11] (PS2) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [00:57:52] (CR) Ejegg: "Thanks for the CR awight - not sure why I had to rebase, but would you mind re-applying that score? Also see (trivial) I0e33dc78ce71 upda" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [00:59:35] (CR) Ejegg: "Good point - not sure why I thought I needed that special-case session code! I've also removed it from the generic and wp API params." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T135745) (owner: Ejegg) [01:01:21] (CR) Ejegg: "ooh, that'll generate disallowed param warnings unless I clear it out of all that html... rats" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T135745) (owner: Ejegg) [01:01:34] (CR) Ejegg: [C: -1] Disallow setting contribution tracking ID from request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T135745) (owner: Ejegg) [01:04:31] (Merged) jenkins-bot: Add minor comments to the config file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/290584 (owner: Awight) [01:09:48] (CR) jenkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg) [01:17:03] (PS3) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [01:18:34] (CR) jenkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg) [01:48:41] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2325224 (Eileenmcnaughton) OK - that table IS still being filled up for searches. I'm back on core on staging though & alth... [01:49:21] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2325225 (Eileenmcnaughton) drush civicrm_merge -u 1 --batch=100 [01:49:45] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2325226 (Eileenmcnaughton) Found this bug - https://issues.civicrm.org/jira... [01:51:11] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Slow queries on staging related to groups - https://phabricator.wikimedia.org/T136158#2325227 (Eileenmcnaughton) [01:52:51] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2325241 (Eileenmcnaughton) Found this & need to fix it before I can go much... [01:54:11] (PS4) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [01:55:35] (CR) jenkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg) [02:30:14] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2325262 (Eileenmcnaughton) OK - that bug turned out to be our invalid date... [02:46:24] (PS5) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [02:47:47] (CR) jenkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg) [05:38:07] (CR) AndyRussG: "Live from New York, it's Tuesday Night One Minor Inline Comment!!!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) (owner: Ejegg) [05:41:45] (CR) Ejegg: "Hope you had a pleasant drive AndyRussG! Hook fn name convention sounds like a good idea." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) (owner: Ejegg) [05:43:46] (PS6) Ejegg: Bypass built-in Mediawiki language fallbacks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) [05:44:29] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2325381 (Eileenmcnaughton) Actually the bug was valid ... https://github.co... [05:46:56] (PS7) Ejegg: Bypass built-in Mediawiki language fallbacks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) [06:02:03] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2325386 (Eileenmcnaughton) [06:03:50] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2258250 (Eileenmcnaughton) Bringing this in so I can commit the trigger sql to gerrit as described. At first w... [06:07:57] (PS1) Eileen: Save sql to generate triggers against current CiviCRM (4.6.9) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290634 [06:07:59] (PS1) Eileen: Save sql to generate triggers against latest CiviCRM (4.7.8) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290635 [06:09:23] (PS1) Eileen: Remove trigger sql from submodule [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/290636 [06:10:12] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2325399 (Eileenmcnaughton) a:Jgreen>Eileenmcnaughton [06:52:45] (CR) Raimond Spekking: "Underlying issue fixed with https://gerrit.wikimedia.org/r/290641" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290591 (owner: Ejegg) [07:14:27] Fundraising-Backlog, Epic, FR-Ingenico: [Epic] Must open a new GlobalCollect account in order to escape Order ID apocalypse - https://phabricator.wikimedia.org/T121000#2325568 (awight) [07:29:34] Fundraising-Backlog, fundraising-tech-ops, Monitoring: Improve Fundraising monitoring, alert, and high-level error handling (Tracking) - https://phabricator.wikimedia.org/T136169#2325589 (awight) [07:47:17] Fundraising-Backlog: Generate of list of CN admins active in the last 12 months - https://phabricator.wikimedia.org/T136050#2325611 (awight) The metawiki replica is at: https://wikitech.wikimedia.org/wiki/Help:Tool_Labs/Database Sorry if this takes some of the fun away this time, but to start with, try: ```... [09:04:36] Fundraising-Backlog, fundraising-tech-ops, Monitoring, Tracking: Improve Fundraising monitoring, alert, and high-level error handling (tracking) - https://phabricator.wikimedia.org/T136169#2325672 (Danny_B) [11:20:04] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: Wikimedia Foundation wikis: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2293336 (... [14:44:06] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#1949608 (Ata) Should/is attached resource file translated? Just wondering what stage is this task on O:) [14:52:46] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2326525 (Cmjohnson) [14:52:57] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2326538 (Cmjohnson) [15:08:44] (CR) Paladox: "recheck" [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/280665 (owner: Paladox) [15:15:56] (CR) Paladox: "recheck" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 (owner: Paladox) [15:16:22] (CR) Paladox: "check experimental" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 (owner: Paladox) [15:30:27] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2326642 (DStrine) We may have lost track of this task. Most of us were having a conversation on T135254 On that task @awight wrote: For the upcoming campaign, we can avoid messing with fallback orde... [16:53:50] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Patch-For-Review: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2327205 (CCogdill_WMF) Thanks for... [17:16:17] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Page_jumping [17:23:27] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: Wikimedia Foundation wikis: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2327287 (... [17:28:26] cwd: any news for scrum of scrums? Were you planning to take a look at that page jump? [17:29:14] hehe well i think it's a "feature" isn't it? [17:29:33] hmm, i thought we tried to minimise the annoyance [17:29:51] i feel like i remember a conversation where andy said he could fix it but FR considered it desirable [17:30:22] you might mention the trouble we had with CI too... [17:34:19] ejegg: cwd yeah page bump is "complicated" :P [17:36:52] ejegg: and cwd I'm trying get the right links for the ukranian form in ukrainian and forced into russian (for QA pruposes). I'm sorry if I'm still having trouble with these links. Can you help check this? I tried the ukranian ulr and It's still showing USD. Is this link correct? [17:36:53] https://payments.wikimedia.org/index.php?title=Special:adyenGateway&appeal=JimmyQuote&ffname=cc&recurring=false&utm_source=.default~default~default~default~control.cc&utm_medium=&utm_campaign=&utm_key=&referrer=&language=uk&country=UK&payment_method=cc&payment_submethod=&gateway=&amountGiven=1¤cy_code=UK&frequency=onetime&amount=Other [17:37:05] ah why am I guest again :( [17:37:19] currency should be UAH [17:37:22] country UA [17:37:25] and language uk [17:42:38] ah thanks [17:43:15] do we have a list of all this somewhere? [17:45:27] iso country codes is https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2 [17:45:43] languages https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes [17:46:44] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: Wikimedia Foundation wikis: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2327334 (... [17:47:00] (PS5) Cdentinger: Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) (owner: Ejegg) [17:56:08] ok so I'm guessing this is currency then? https://en.wikipedia.org/wiki/ISO_4217 [17:58:30] dstrine: yep, uah=Ukrainian hryvnia [17:59:40] Thanks ejegg and MBeat I've seen actually had to refernce so many countries and currencies. [18:00:28] the whole UA/UK/GB thing is confusing too [18:00:53] *I've never had to reference so many... [19:11:23] awight: shall we try to push some things over the line? [19:11:53] adyen hebrew hackery is here: https://gerrit.wikimedia.org/r/#/c/290589/ [19:12:10] oh, I can deploy the iframe bit of it to the adyen console [19:21:18] oops, stray comma busts input hiding [19:25:08] (PS6) Ejegg: Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) [19:26:21] ok, that version works^^^ [19:38:47] ejegg: yes--hooray! [19:38:57] k lemme test locally [19:39:33] thanks! [19:41:35] Scary--I have live adyen creds [19:41:41] I wonder why I did that... [19:43:16] Nice sheckels symbol [19:44:21] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: donatewiki: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2327765 (Nemo_bis) [19:45:16] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: donatewiki and paymentswiki: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2327768 (... [19:46:34] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ukrainian GC iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#2327790 (Nemo_bis) [19:46:36] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2327791 (Nemo_bis) [19:46:39] blast. can't get VPN to work [19:46:54] Nemo_bis: Thanks for your help with the uk->ru discussion! [19:47:01] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ukrainian GC iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#1807858 (Nemo_bis) >>! In T135254#2326001, @Pcoombe wrote: > I think this is getting slightly confused with the main issue we had bef... [19:47:59] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: donatewiki and paymentswiki: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2293336 (... [19:48:01] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#1949608 (Nemo_bis) [19:48:28] awight: test creds shouldn't need VPN to get the iframe [19:48:43] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2327817 (awight) @Nemo_bis Adyen and Ingenico (or formerly "GC") are two independent payment processors, so I'm unlinking the two tasks... [19:48:53] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2327820 (awight) [19:48:55] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ukrainian GC iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#2327819 (awight) [19:49:20] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Community-Liaisons, MediaWiki-extensions-DonationInterface, and 4 others: donatewiki and paymentswiki: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2327822 (... [19:49:32] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ukrainian credit card iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#2327826 (Nemo_bis) [19:50:15] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ingenico Ukrainian credit card iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#2327832 (awight) [19:51:06] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ingenico Ukrainian credit card iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#1807858 (awight) @Nemo_bis I'm changing the title back again--this really is a problem specific to Ingenico, becau... [19:51:15] * awight tries to focus on work [20:02:31] anybody want to CR this trivial bit: https://gerrit.wikimedia.org/r/287653 ? [20:02:57] moves some test code out of a one of our CRM modules and gets rid of a PHP7 breaker [20:23:42] (CR) Awight: [C: 2] "Works nicely!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) (owner: Ejegg) [20:23:51] CR'ing the CRM code now [20:26:51] (Merged) jenkins-bot: Adyen: fill & hide cc name field for all but Hebrew [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290589 (https://phabricator.wikimedia.org/T124467) (owner: Ejegg) [20:27:21] (CR) Awight: [C: -1] "Dependency is a problem. It would work in development, and should never be used in production, but still not a good idea to expose an uns" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/287653 (https://phabricator.wikimedia.org/T133712) (owner: Ejegg) [20:28:06] ejegg|vps: I'll mess with the initial velocity fun for a few... [20:31:49] (CR) Ejegg: Move test code to test support (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/287653 (https://phabricator.wikimedia.org/T133712) (owner: Ejegg) [20:31:51] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2258250 (Eileenmcnaughton) https://gerrit.wikimedia.org/r/#/c/290634/ https://gerrit.wikimedia.org/r/#/c/29063... [20:33:38] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2327972 (Cmjohnson) @Jgreen We are out of available SRX switch ports to add this new db....do you want to decom anything? [20:34:46] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2327978 (Eileenmcnaughton) @Jgreen you might be the best person to approve those 3 gerrits. There is somethin... [20:36:26] (PS2) Ejegg: Move test code to test support [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/287653 (https://phabricator.wikimedia.org/T133712) [20:37:32] (CR) Awight: [C: 2] "Less code! Love it." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/287653 (https://phabricator.wikimedia.org/T133712) (owner: Ejegg) [20:39:52] (Merged) jenkins-bot: Move test code to test support [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/287653 (https://phabricator.wikimedia.org/T133712) (owner: Ejegg) [20:45:14] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen, and 3 others: donatewiki and paymentswiki: We should stop falling back to Russian when looking up unavailable Ukranian messages - https://phabricator.wikimedia.org/T135254#2327986 (Qgil) [20:45:15] (CR) Awight: [C: 2] Add order ID to pending queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [20:46:23] (CR) Awight: [C: 2] "(not this revision, but) What's this funky file about? It's not .json..." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288448 (owner: Ejegg) [20:51:41] (CR) Ejegg: "yeah, that's the 'raw' format from EmptyQueueToDump (and used by PopulateQueueFromDump (FIXME)" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288448 (owner: Ejegg) [20:56:00] awight: a few little noise reductions commits for the email export, if you're still feeling CR-y: [20:56:08] https://gerrit.wikimedia.org/r/289592 [20:56:14] https://gerrit.wikimedia.org/r/289593 [20:56:22] https://gerrit.wikimedia.org/r/289714 [20:56:33] well, that last is more of a signal boost than noise cancelling [20:59:34] holler! got the staging server in browser [20:59:59] nice! [21:01:08] oh cool--will do after the meeting [21:10:36] (Merged) jenkins-bot: Add order ID to pending queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288439 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [21:10:39] (Merged) jenkins-bot: Add order ID to fake pending messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288448 (owner: Ejegg) [21:15:23] (CR) Ejegg: [C: 2] Remove trigger sql from submodule [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/290636 (owner: Eileen) [21:15:29] (PS2) Ejegg: Save sql to generate triggers against current CiviCRM (4.6.9) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290634 (owner: Eileen) [21:15:47] (CR) Ejegg: [C: 2] Save sql to generate triggers against current CiviCRM (4.6.9) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290634 (owner: Eileen) [21:16:01] (PS2) Ejegg: Save sql to generate triggers against latest CiviCRM (4.7.8) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290635 (owner: Eileen) [21:17:05] Fundraising-Backlog: SPRINT L (6/8- 6/22) Paypal Japan campaign ready? - https://phabricator.wikimedia.org/T136250#2328166 (DStrine) [21:18:05] Fundraising-Backlog: SPRINT M (6/22 - 7/6) if possible, only bugs fixes for paypal - https://phabricator.wikimedia.org/T136251#2328180 (DStrine) [21:26:04] (Merged) jenkins-bot: Remove trigger sql from submodule [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/290636 (owner: Eileen) [21:26:26] (Merged) jenkins-bot: Save sql to generate triggers against current CiviCRM (4.6.9) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290634 (owner: Eileen) [21:28:59] (CR) Ejegg: [C: 2] "Looks good, diffs with 4.6 script are mostly whitespace." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290635 (owner: Eileen) [21:33:38] Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Ingenico Ukrainian credit card iframe should fall back to English instead of Russian - https://phabricator.wikimedia.org/T118734#2328280 (Pcoombe) @Nemo_bis Let me try and clarify: * This is about the forms provided by our credit card processo... [21:34:13] (Merged) jenkins-bot: Save sql to generate triggers against latest CiviCRM (4.7.8) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290635 (owner: Eileen) [21:41:16] Fundraising-Backlog: Generate of list of CN admins active in the last 12 months - https://phabricator.wikimedia.org/T136050#2328317 (CCogdill_WMF) Dumping into a TSV file is super easy! Just do the below -- anything in brackets should be replaced. ssh into whatever server you're using and: **mysql [database... [22:02:47] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 2 others: Fix logging hook name - https://phabricator.wikimedia.org/T133257#2328408 (Eileenmcnaughton) Open>Resolved [22:03:11] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Patch upstreaming : Participate in CiviCRM review week in order to get some of my work merged - https://phabricator.wikimedia.org/T135058#2328411 (Eileenmcnaughton) Open>Resolved [22:03:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2328412 (Eileenmcnaughton) [22:03:48] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work, WMF-deploy-2016-05-24_(1.28.0-wmf.3): Setup Ukrainian forms for Adyen - https://phabricator.wikimedia.org/T135417#2298213 (DStrine) Open>Resolved [22:03:50] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, and 3 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel... - https://phabricator.wikimedia.org/T128812#2328419 [22:09:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare 4.7 CiviCRM branch & clean our patches into it - https://phabricator.wikimedia.org/T136252#2328451 (Eileenmcnaughton) [22:10:34] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: setup civi 4.7 on staging - https://phabricator.wikimedia.org/T133806#2328458 (Eileenmcnaughton) Open>Resolved I'm setting this to resolv... [22:12:18] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, FR-Adyen, and 2 others: Adyen job runner log prepending too many IDs - https://phabricator.wikimedia.org/T129946#2328462 (Ejegg) Open>Resolved [22:14:58] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog: SPRINT J (5/11 to 5/25) GOAL: Continue Paypal, dedupe exact matches? - https://phabricator.wikimedia.org/T132083#2328466 (DStrine) Open>Resolved [22:18:32] Fundraising Sprint K 2016, Fundraising-Backlog, Documentation, FR-Amazon, FR-Smashpig: Document Amazon transaction workflow; make settlement more robust - https://phabricator.wikimedia.org/T136116#2328476 (DStrine) [22:18:34] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, FR-Smashpig, Technical-Debt: Remove redundant SmashPig config from /etc - https://phabricator.wikimedia.org/T136121#2328475 (DStrine) [22:18:36] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, FR-Amazon, and 3 others: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2328479 (DStrine) [22:18:38] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, FR-Adyen, and 2 others: Revisit Adyen missing donor info behavior - https://phabricator.wikimedia.org/T136038#2328480 (DStrine) [22:18:40] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, I18n, and 4 others: Adyen Hebrew UI bugs - https://phabricator.wikimedia.org/T135416#2328481 (DStrine) [22:18:42] Fundraising Sprint K 2016, Fundraising-Backlog: Ingenico iframe styling has changed - https://phabricator.wikimedia.org/T135388#2328482 (DStrine) [22:18:44] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog: CentralNotice: finalize list of wild useless cookies for slurp, and push config change - https://phabricator.wikimedia.org/T135090#2328485 (DStrine) [22:18:46] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2328484 (DStrine) [22:18:48] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: donatewiki and paymentswiki: We should stop falling back to Russian when looking up unavailable Ukranian mes... - https://phabricator.wikimedia.org/T135254#2328483 [22:18:50] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, and 4 others: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2328487 (DStrine) [22:18:53] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, and 3 others: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect - https://phabricator.wikimedia.org/T134310#2328488 (DStr... [22:18:55] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, Hovercards, Patch-For-Review: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2328489 (DStrine) [22:18:58] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, and 6 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2328490 (DStrine) [22:19:00] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, and 3 others: Move queue2civicrm_generate_message to test support - https://phabricator.wikimedia.org/T133712#2328493 (DStrine) [22:19:02] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, Security-Data-Mapping: Rough draft of data flow map - https://phabricator.wikimedia.org/T133810#2328491 (DStrine) [22:19:04] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2328492 (DStrine) [22:19:06] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 5 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2328495 (DStrine) [22:19:08] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 3 others: Write a hook to skip the calculated tables from conflict consideration - https://phabricator.wikimedia.org/T133625#2328494 (DStrine) [22:19:10] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 4 others: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2328496 (DStrine) [22:19:13] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 5 others: Write pending queue consumer and schema - https://phabricator.wikimedia.org/T133197#2328498 (DStrine) [22:19:15] Fundraising Sprint K 2016, Fundraising-Backlog: SPRINT K (5/25- 6/8) GOAL: Continue Paypal, dedupe exact matches? - https://phabricator.wikimedia.org/T133570#2328497 (DStrine) [22:19:18] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 3 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or delete th... - https://phabricator.wikimedia.org/T132640#2328500 [22:19:21] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 7 others: All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2328499 (DStrine) [22:19:24] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, and 5 others: Write adapter for Express Checkout - https://phabricator.wikimedia.org/T131811#2328504 (DStrine) [22:19:26] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 2 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2328502 (DStrine) [22:19:28] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 3 others: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2328503 (DStri... [22:19:31] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 3 others: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets, impre... - https://phabricator.wikimedia.org/T132639#2328501 [22:19:34] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, Fundraising-Backlog, and 3 others: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2328505 (DStrine) [22:19:44] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint K 2016, and 5 others: Don't make donors guess minimum donation amount - https://phabricator.wikimedia.org/T105618#2328514 (DStrine) [22:19:45] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 4 others: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#2328515 (DStrine) [22:37:30] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Update trigger mysql in git to reflect latest change from upstream (connection_id) - https://phabricator.wikimedia.org/T133745#2328564 (Eileenm... [22:37:32] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 2 others: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2328565 (Eileenmcnaughton) [22:37:34] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2328561 (Eileenmcnaughton) Open>... [22:45:51] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2328574 (Jgreen) Yeah I thought that might happen, which is why I was hoping for a resolution to the SRX linecard issue ASAP. The only host that can be removed at this time is alum... [22:55:50] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor form chooser - https://phabricator.wikimedia.org/T136254#2328603 (Ejegg) [22:57:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor form chooser - https://phabricator.wikimedia.org/T136254#2328618 (Ejegg) [22:58:36] awight: so, when the donor info is missing, maybe we just don't capture and leave the payment open? [22:59:00] We don't want to be reading Civi to see if there's already a capture for the OID [22:59:35] And it seems like donor services notices when a bunch of stalled transactions pile up [23:00:21] we can write a maintenance script to take a list of OIds, query for em, and make sure each has exactly one payment captured, closing the rest [23:00:50] also cwd ^^^ [23:01:18] it cancels right now? [23:01:37] this is re: https://phabricator.wikimedia.org/T136038 [23:02:10] yeah, we had some donors submitting clicking multiple times in the iframe [23:02:34] and that gave us multiple auth IPN messages for the same (our-side) order ID [23:02:52] ah ha, so that sounds like canceling it would be legit [23:02:57] debounce [23:03:10] but is there another reason it could happen? [23:03:24] yeah, queue outage [23:04:39] ah yes [23:04:40] hmm, actually, lemme see if there's an api call we can make to check for any captured payments with the same merchant ref [23:04:49] that would be ideal [23:05:28] have we asked if they can debounce the button in the iframe? [23:06:32] that would also be good... [23:06:45] stop it at the source [23:07:40] i think the donor in https://phabricator.wikimedia.org/T129935 might have done something wacky like reload the iframe [23:08:02] we erroneously send them to the fail page a couple times [23:09:22] with our traffic profile one thing you can count on is if something is possible, it will happen [23:09:35] oh right, their API is pretty lean [23:10:20] ejegg: I think there's plenty of precedent for checking Civi for the order id [23:10:43] I like the of an orphan rectifier, also [23:11:36] awight: oh yeah? right, i guess the job runner hangs out in the same neighborhood [23:11:44] It's already like this IIRC, but the listener should be really lightweight, just goes-inna-goes-outta. The actual capture/close job is free to do whatev though [23:11:49] We have audit parsers which check Civi also [23:12:18] In general, we should probably do less of that and just let the queue consumer handle duplicates, but if we're taking processor action then it makes sense to actually check [23:12:45] gotta roll, back later [23:12:51] yeah... ok, so let's do that. Get a capture request with contact info for that order id? Cool, first time, capture, and move the contact info to verified [23:13:03] no contact info? Check civi for the order id [23:13:23] I'm not sure how the contact info is involved... [23:13:28] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2328626 (Jdlrobson) [23:13:46] awight: it's a marker for 'already captured' right now [23:13:57] on that note... documenting our workflow for these things will be nice to have... napkin sketch is fine [23:14:05] hrm! how does that work? [23:14:22] the capture job moves the contact id from pending to verified [23:15:02] (PS1) Krinkle: Minor clean up in CNChoiceDataResourceLoaderModule [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290824 [23:15:04] hmm, we can't count on the first donation getting to civi before we see the duplicate, though [23:15:11] good point [23:15:23] this would be a perfect use for the pending database [23:15:30] (CR) Jdlrobson: [C: -1] "This patch needs a rebase" [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/177011 (owner: Ssmith) [23:15:32] hah, exactly what i was thinking! [23:15:39] hehe [23:15:46] (PS1) Krinkle: Add in-process caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290825 [23:15:51] synchronicity, then [23:16:20] * awight eyebrows go up at interesting flurry of awesome external help [23:17:05] ooh, that last one looks good [23:17:16] (CR) Awight: [C: 2] Add GatewayInitialFilter hook (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289801 (owner: Ejegg) [23:18:58] (CR) jenkins-bot: [V: -1] Add in-process caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290825 (owner: Krinkle) [23:19:53] (Merged) jenkins-bot: Add GatewayInitialFilter hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289801 (owner: Ejegg) [23:19:58] (CR) Krinkle: "I didn't think of adding a cache-bypass flag (e.g. READ_LATEST) because the read always happens from a slave, so a few ms more lag from in" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290825 (owner: Krinkle) [23:20:37] (CR) Awight: [C: 2] "I'm wary about how this might accumulate across attempts... but we can always tweak later as we learn how the scores add up in practice." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289804 (owner: Ejegg) [23:20:47] (CR) Ejegg: "Thanks! followups for a couple of your comments are on the way." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289801 (owner: Ejegg) [23:22:52] (Merged) jenkins-bot: Persist risk score array in session [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289804 (owner: Ejegg) [23:25:13] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, Security-Data-Mapping: Rough draft of data flow map - https://phabricator.wikimedia.org/T133810#2244911 (awight) a:awight [23:27:48] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: donatewiki and paymentswiki: We should stop falling back to Russian when looking up unavailable Ukrani... - https://phabricator.wikimedia.org/T135254#2328653 [23:28:05] (PS2) Eileen: Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) [23:28:07] (PS1) Eileen: basic merge command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 [23:28:55] (PS1) Ejegg: Rename hook functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290829 [23:29:36] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: donatewiki and paymentswiki: We should stop falling back to Russian when looking up unavailable Ukrani... - https://phabricator.wikimedia.org/T135254#2293336 [23:30:17] (CR) jenkins-bot: [V: -1] Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [23:30:28] (PS6) Awight: Fire IP velocity filter early [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289809 (owner: Ejegg) [23:30:44] (CR) Eileen: [C: -1] "This is WIP - put up for discussion not review just yet" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [23:33:04] (PS1) Ejegg: Comment and DRY for functions filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 [23:33:33] (CR) Eileen: [C: -1] "WIP - up for discussion, needs to be tidied up - esp commit message needs to refer to Phab task" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 (owner: Eileen) [23:33:41] awight: ejegg this is early stages - but might be a good time for input on what the merge job scripts should look like https://gerrit.wikimedia.org/r/#/c/290828/1 [23:34:15] thanks! [23:37:37] (PS1) GergÅ‘ Tisza: Update mediawiki_api gem to 1.7.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290834 (https://phabricator.wikimedia.org/T135884) [23:38:00] (eileen: fwiw, our norm is to prepend [WIP] to the commit message) [23:40:15] awight: ah yeah - I only pushed those up to answer your Q on the tests - but yes, good practice. If I did that & removed it when it's not WIP I wouldn't need to think about it [23:41:55] (CR) Awight: "Lightweight!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 (owner: Eileen) [23:53:58] (CR) Awight: [C: 2] Fire IP velocity filter early (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289809 (owner: Ejegg) [23:54:31] thanks for all the CR awight! [23:54:48] gotta head out, see you later [23:55:47] (CR) Awight: [C: 2] Log number of rows exported [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/289714 (owner: Ejegg) [23:57:11] (CR) Eileen: "I don't think it will attempt to dedupe a contact you are editing on save. It does try to discourage you from creating a matching contact " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 (owner: Eileen) [23:59:42] (Merged) jenkins-bot: Fire IP velocity filter early [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289809 (owner: Ejegg) [23:59:56] (Merged) jenkins-bot: Log number of rows exported [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/289714 (owner: Ejegg)