[00:53:09] <grrrit-wm>	 (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/291147
[00:53:27] <grrrit-wm>	 (CR) Ejegg: [V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/291147 (owner: Ejegg)
[00:53:55] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/291147 (owner: Ejegg)
[01:01:31] <grrrit-wm>	 (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/291148
[01:01:48] <grrrit-wm>	 (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/291148 (owner: Ejegg)
[01:07:59] <grrrit-wm>	 (PS1) Ejegg: Fix CSS selector in Adyen iframe [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291149 (https://phabricator.wikimedia.org/T135416)
[01:08:17] <grrrit-wm>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/291148 (owner: Ejegg)
[01:18:54] <ejegg>	 !log updated payments from e6807395d7687d521070b83d159b77b242e5c04f to de0398a244094f2bad6bc70eefce8388a616e575
[01:19:00] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[01:25:06] <wikibugs>	 Fundraising-Backlog: Update vagrant main page test links - https://phabricator.wikimedia.org/T136379#2332721 (Ejegg)
[01:35:40] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, Patch-For-Review: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2260911 (Ejegg) @Pcoombe this is ready to play with on production!  Also, reading web informs me that there's...
[01:43:23] <grrrit-wm>	 (PS1) Ejegg: Make Capture IPN logging like Auth IPN logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/291150
[02:14:28] <grrrit-wm>	 (PS1) Ejegg: Quit flooding antifraud queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291151 (https://phabricator.wikimedia.org/T136381)
[02:25:36] <grrrit-wm>	 (PS2) Ejegg: Quit flooding antifraud queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291151 (https://phabricator.wikimedia.org/T136381)
[02:31:13] <ejegg>	 phooey, nobody to CR... guess I'll roll back to stop the failmail
[02:33:20] <ejegg>	 !log rolled back payments from de0398a244094f2bad6bc70eefce8388a616e575 to e6807395d7687d521070b83d159b77b242e5c04f
[02:33:26] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[02:46:34] <grrrit-wm>	 (PS3) Ejegg: Rename hook functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290829 (https://phabricator.wikimedia.org/T136381)
[02:46:47] <grrrit-wm>	 (PS3) Ejegg: Comment and DRY for functions filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 (https://phabricator.wikimedia.org/T136381)
[02:46:59] <grrrit-wm>	 (PS4) Ejegg: Const and better name for initial ip velocity flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290990 (https://phabricator.wikimedia.org/T136381)
[03:19:27] <grrrit-wm>	 (PS1) Ejegg: Trim fields before sending to server [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291154
[03:31:40] <wikibugs>	 Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 3 others: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2332862 (Ejegg...
[03:48:07] <grrrit-wm>	 (PS1) Ejegg: NumberFormatter fallback when ext-intl not installed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291156
[03:49:34] <ejegg|away>	 man, i shouldn't drink coffee after noon...
[03:52:45] <grrrit-wm>	 (PS6) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615
[03:53:03] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg)
[04:58:00] <grrrit-wm>	 (CR) Ejegg: "Order is tricky here - command-line options include specifying an alternate config file and section, so you need to parse those before you" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288314 (owner: Ejegg)
[07:44:27] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2333006
[10:00:44] <grrrit-wm>	 (CR) Bartosz Dziewoński: "Caused T136387." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290361 (https://phabricator.wikimedia.org/T134286) (owner: AndyRussG)
[11:23:02] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: mw.centralNotice CRASH on client side - https://phabricator.wikimedia.org/T133765#2333354 (PerfektesChaos) @AndyRussG – see T136387 – Fun...
[14:01:34] <wikibugs>	 Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2333878 (Ata) @DStrine, everything is translated on the links you mentioned so I guess the problem is not there. I was talking about the file attached to the description of this task. Someone (even me...
[15:04:28] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, Patch-For-Review: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2260911 (matmarex) This caused T136387 and the production deployment was just reverted.
[15:05:11] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript: EcmaScript 6 features are not supported in older browsers - https://phabricator.wikimedia.org/T136387#2332918 (matmarex) a:matmarex>None Deployment of the faulty patch (T134286) was rev...
[15:29:33] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript: EcmaScript 6 features are not supported in older browsers - https://phabricator.wikimedia.org/T136387#2334153 (Strainu) I can confirm JavaScript now works in IE 11. Waiting for confirmation on...
[15:49:20] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript: EcmaScript 6 features are not supported in older browsers - https://phabricator.wikimedia.org/T136387#2334209 (Antilope) I can confirm JavaScript now works again in Opera 12.18 (released Feb 20...
[15:53:46] <wikibugs>	 Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, Patch-For-Review: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2334228 (DStrine) p:Triage>High
[16:06:26] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript: EcmaScript 6 features are not supported in older browsers - https://phabricator.wikimedia.org/T136387#2332918 (Krinkle) >>! In T136387#2334101, @matmarex wrote: > Deployment of the faulty patch...
[16:06:47] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2334287 (Krinkle)
[16:07:41] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2334289 (matmarex) >>! In T136387#2334284, @Krinkle wrote: > It should be coin...
[16:07:43] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, JavaScript: Introduce automatic ECMA version check on JS patch review - https://phabricator.wikimedia.org/T136408#2333737 (matmarex)
[16:08:58] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, JavaScript: Update CentralNotice JSHint config to restrict syntax to ES3 (disallow ES5 or ES6) - https://phabricator.wikimedia.org/T136408#2334303 (Krinkle)
[16:40:15] <wikibugs>	 Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 3 others: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2334409 (CCogd...
[16:41:44] <wikibugs>	 Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 3 others: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2334412 (MBeat...
[16:43:21] <grrrit-wm>	 (PS1) Ejegg: WIP jshint and gruntfile fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (https://phabricator.wikimedia.org/T136408)
[16:45:41] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP jshint and gruntfile fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (https://phabricator.wikimedia.org/T136408) (owner: Ejegg)
[16:46:33] <dstrine>	 oh hey ejegg are you trying to help with the CN rollback thing? I was just reading up on those tasks
[16:46:38] <ejegg>	 yeah
[16:46:50] <ejegg>	 it breaks old browsers
[16:47:10] <ejegg>	 and we haven't actually been checking most of the js files in continuous integration
[16:47:23] <dstrine>	 thanks! you're like the green beret these last 2 weeks
[16:47:28] <ejegg>	 so ^^ was turning on the tests, including enforcing old syntax
[16:47:33] <ejegg>	 and... lots of breakage
[16:47:59] <ejegg>	 hopefully mostly trivial fixes and nothing that will change logic
[16:48:07] <ejegg>	 heh, thanks
[16:48:18] <dstrine>	 This could wait for Andy and Adam to get back ... it's up to you
[16:48:30] <ejegg>	 ehh, I'll pounce on it
[16:48:43] <dstrine>	 unless we need to respond to part of it today
[16:48:45] <dstrine>	 ok
[16:48:46] <ejegg>	 haven't peeked at CN for a while, I'll take this opportunity
[16:49:22] <dstrine>	 ok
[17:12:12] <grrrit-wm>	 (PS2) Ejegg: jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264
[17:27:37] <grrrit-wm>	 (PS3) Ejegg: jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264
[17:31:40] <grrrit-wm>	 (PS4) Ejegg: jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264
[17:40:36] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: CentralNotice: reducing initial JS load? (tracking) - https://phabricator.wikimedia.org/T133741#2334627 (Danny_B)
[18:01:25] <grrrit-wm>	 (PS1) Ejegg: WIP enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288
[18:50:35] <grrrit-wm>	 (PS2) Ejegg: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288
[18:55:26] <grrrit-wm>	 (CR) Bartosz Dziewoński: [C: 2] jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[18:56:57] <grrrit-wm>	 (CR) Bartosz Dziewoński: "Hmm. I think you need to move the .jscsrc to the next patch." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[18:57:16] <grrrit-wm>	 (CR) Ejegg: "oops, will do" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[18:58:00] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[18:58:21] <grrrit-wm>	 (CR) Bartosz Dziewoński: "(And the related Gruntfile and package.json changes)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[18:59:27] <grrrit-wm>	 (CR) Ejegg: "yeah, must have --amended by mistake at some point" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[19:01:45] <grrrit-wm>	 (PS5) Ejegg: jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264
[19:05:57] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript, and 2 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2334954 (Trizek-WMF)
[19:15:15] <awight>	 dstrine: You WFH?
[19:15:33] <grrrit-wm>	 (PS3) Ejegg: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288
[19:22:28] <grrrit-wm>	 (PS4) Ejegg: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288
[19:24:06] <grrrit-wm>	 (CR) Ejegg: "thanks Krinkle, guess I leaned a little too heavily on autotune. I'll review the rest and revert any other overzealousness" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 (owner: Ejegg)
[19:26:25] <grrrit-wm>	 (CR) Bartosz Dziewoński: [C: 2] jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[19:28:13] <grrrit-wm>	 (Merged) jenkins-bot: jshint, gruntfile, and compatibility fixes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291264 (owner: Ejegg)
[19:31:26] <dstrine>	 awight:  yeah
[19:31:33] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, JavaScript: Update CentralNotice JSHint config to restrict syntax to ES3 (disallow ES5 or ES6) - https://phabricator.wikimedia.org/T136408#2335053 (matmarex) Open>Resolved a:Ejegg
[19:31:56] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, JavaScript, User-notice: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2335056 (matmarex) Open>Resolved a:Ejegg
[19:32:37] <awight>	 dstrine: Do you know if eileen is in the office today?
[19:32:59] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 3 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2335060 (Ejegg)
[19:33:03] <dstrine>	 awight: it doesn't look like it. She isn't usually
[19:33:08] <awight>	 uhh
[19:33:10] <awight>	 wat
[19:33:15] <dstrine>	 on fridays?
[19:33:20] <dstrine>	 it's her saturday
[19:33:25] <awight>	 But she's here, I thought
[19:33:29] <awight>	 do I have the week wrong?
[19:33:42] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, JavaScript, Unplanned-Sprint-Work: Update CentralNotice JSHint config to restrict syntax to ES3 (disallow ES5 or ES6) - https://phabricator.wikimedia.org/T136408#2335062 (Ejegg)
[19:34:04] * awight facepalms all over the place
[19:34:14] <awight>	 I don't wanna talk about it.
[19:34:15] <dstrine>	 awight:  the schedule says 6/9 and 6/10
[19:34:20] <awight>	 Well, at least I didn't miss her yesterday
[19:34:24] <dstrine>	 LOL
[19:38:38] <wikibugs>	 Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2261096 (awight) Please note the comments on T134286 -- there are some special "legacy" campaign settings you'll need to enable in order to use my workaround, and sample code that comes pretty close to w...
[19:39:05] * awight becomes increasingly agitated
[19:39:58] <awight>	 Anybody have things I can help with?
[19:40:18] <grrrit-wm>	 (CR) Awight: [C: 2] "Debt writeoff!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/289716 (https://phabricator.wikimedia.org/T122411) (owner: Ejegg)
[19:40:19] <ejegg|afk>	 awight: there's something to limit the antifraud spam
[19:40:21] <grrrit-wm>	 (PS2) Awight: Remove old email edit hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/289716 (https://phabricator.wikimedia.org/T122411) (owner: Ejegg)
[19:40:51] <grrrit-wm>	 (CR) Awight: [C: 2] Keep Civi users off suppression list [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/291136 (https://phabricator.wikimedia.org/T122411) (owner: Ejegg)
[19:40:53] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Remove old email edit hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/289716 (https://phabricator.wikimedia.org/T122411) (owner: Ejegg)
[19:41:17] <ejegg>	 hrm?
[19:41:34] <awight>	 cloning bug
[19:41:34] <ejegg>	 ah, db issue
[19:41:51] <grrrit-wm>	 (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/289716 (https://phabricator.wikimedia.org/T122411) (owner: Ejegg)
[19:42:00] <awight>	 ah the cloning issue was a warning
[19:43:13] <grrrit-wm>	 (Merged) jenkins-bot: Keep Civi users off suppression list [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/291136 (https://phabricator.wikimedia.org/T122411) (owner: Ejegg)
[19:44:39] <awight>	 hah!  Phabricator double-encodes and breaks its own link
[19:44:48] <awight>	 Must be part of the "workflow"
[19:51:00] <grrrit-wm>	 (CR) Awight: [C: 2] "It's an improvement, but these classes have quite an existing funky smell. Time for a bigger cleanup!" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291151 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:51:46] <grrrit-wm>	 (PS4) Awight: Rename hook functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290829 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:51:54] <grrrit-wm>	 (CR) Awight: [C: 2] Rename hook functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290829 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:52:27] <grrrit-wm>	 (CR) Awight: [C: 2] Comment and DRY for functions filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:52:33] <grrrit-wm>	 (PS4) Awight: Comment and DRY for functions filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:53:18] <grrrit-wm>	 (Merged) jenkins-bot: Quit flooding antifraud queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291151 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:53:36] <grrrit-wm>	 (Merged) jenkins-bot: Rename hook functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290829 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:55:08] <grrrit-wm>	 (CR) Awight: [C: 2] "Beneficial protectionism!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[19:55:12] <grrrit-wm>	 (PS3) Awight: Rationalize accesibility of fns and methods for Extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[19:55:48] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Rationalize accesibility of fns and methods for Extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[19:56:13] <grrrit-wm>	 (CR) Awight: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290990 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:56:27] <grrrit-wm>	 (PS5) Awight: Comment and DRY for functions filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[19:56:46] <grrrit-wm>	 (CR) Awight: "@ejegg aww, manual rebase needed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[19:58:10] <grrrit-wm>	 (CR) Ejegg: "dang, really hoped to avoid that for this guy!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[20:02:29] <grrrit-wm>	 (PS9) Awight: PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446)
[20:02:43] <grrrit-wm>	 (CR) Awight: "PS9: Manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight)
[20:02:57] <grrrit-wm>	 (PS3) Awight: Stop sending item category [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288253 (https://phabricator.wikimedia.org/T134446)
[20:03:16] <awight>	 ejegg: recurring is ready for CR if you get the chance...
[20:04:18] <ejegg>	 cool!
[20:04:42] <grrrit-wm>	 (CR) Awight: [C: 2] "Confirmed unused." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288314 (owner: Ejegg)
[20:04:54] <grrrit-wm>	 (PS2) Awight: replace busted addOptionWithConfigDefault [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288314 (owner: Ejegg)
[20:04:58] <dstrine>	 ejegg:  and awight ... ejegg and I are the only official people left here today. I don't think we NEED a standup unless you want to chat about anything
[20:05:00] <grrrit-wm>	 (PS4) Awight: Fix defaults for QueueJobRunner [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287871 (owner: Ejegg)
[20:06:06] <dstrine>	 ejegg:  we don't have to meet
[20:06:16] <dstrine>	 It's technically just us
[20:06:31] <awight>	 I'm happy to chat, but probably leaving soon.
[20:06:36] <awight>	 My official objectives have been foiled
[20:06:56] <grrrit-wm>	 (CR) Awight: [C: 2] Fix defaults for QueueJobRunner (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287871 (owner: Ejegg)
[20:07:01] <grrrit-wm>	 (PS6) Awight: Fix time and message limits [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[20:07:13] <ejegg>	 ok, a/v issues here anyway
[20:07:27] <ejegg>	 my report: messed with a bunch of little fixes last night
[20:07:39] <dstrine>	 ok
[20:07:47] <ejegg>	 including something for the reason i had to roll back
[20:07:54] <ejegg>	 then today mostly central notice
[20:08:21] <dstrine>	 ah ... are you in on monday? I canceled the standup becuase I will not be and I assumed no one else was
[20:08:33] <ejegg>	 dstrine: not planning to be
[20:08:38] <dstrine>	 ok great :)
[20:08:50] <awight>	 Wow, thanks for the cleanup btw, I was really hoping to not leave you with a third-hand disaster :(
[20:08:51] <ejegg>	 oh...  i might have forgotten it was a holiday in some email
[20:08:57] <dstrine>	 I canceled that meeting without asking anyone
[20:09:12] <grrrit-wm>	 (CR) Awight: [C: 2] Fix time and message limits (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[20:09:27] <awight>	 I have no need to meet on Monday either, if that's the question :p
[20:09:29] <ejegg>	 awight: third-hand?  I think that was all my code ringing the alarm bells
[20:09:31] <grrrit-wm>	 (PS7) Awight: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[20:09:42] <grrrit-wm>	 (Merged) jenkins-bot: replace busted addOptionWithConfigDefault [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288314 (owner: Ejegg)
[20:09:44] <grrrit-wm>	 (Merged) jenkins-bot: Fix defaults for QueueJobRunner [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287871 (owner: Ejegg)
[20:10:02] <ejegg>	 whew, looks like I'll have a few code comments to folow up on
[20:10:03] <awight>	 ejegg: I thought that was AndyRussG's patch, which I butchered and self-merged
[20:10:12] <ejegg>	 thanks for the blitz!
[20:10:12] <awight>	 the registerTest fail
[20:10:19] <ejegg>	 awight: ohh, thataone
[20:10:25] <awight>	 yah sorry about the binge and purge CR
[20:10:28] <ejegg>	 i mean, the real fail was in the gruntfile
[20:10:35] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Fix time and message limits [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[20:10:52] <ejegg>	 it was doing jshint on... the gruntfile
[20:10:58] <ejegg>	 and nothing else
[20:11:21] <awight>	 omgwow
[20:11:22] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[20:11:48] <awight>	 btw .......PHP Fatal error:  Class 'SmashPig\Tests\Context' not found in /mnt/jenkins-workspace/workspace/composer-php53@2/Tests/QueueConsumerTest.php on line 146
[20:11:57] <awight>	 Missing namespace I guess
[20:12:43] <ejegg>	 oops, lemme fix that
[20:12:45] <dstrine>	 hey awight and ejegg I'm palying with sql in civi and I'm super new. I just want to try looking different things up. Is there a way to get a list of tables, their column headers and the types of data in the columns? I want to try looking for things but it's kinda hard when you don't know what to search for. This question might just be me being a total noob so applogies in
[20:12:45] <dstrine>	 advance.
[20:13:03] <ejegg>	 dstrine: show tables;
[20:13:13] <awight>	 show create table FOO
[20:13:26] <ejegg>	 or for a subset: show tables like '%contact%';
[20:13:37] <awight>	 show table status;
[20:13:40] <awight>	 describe table FOO;
[20:14:11] <ejegg>	 less verbose alternate to show create table foo; is "describe foo;"
[20:14:15] <awight>	 dstrine: https://collab.wikimedia.org/wiki/Fundraising/Engineering/SQL_Database_Overview
[20:14:18] <ejegg>	 what he said^
[20:14:50] <awight>	 We should really start using SQL comments...  so column descriptions show up in the above commands.
[20:14:59] <awight>	 s/in/using/
[20:15:14] <ejegg>	 yah
[20:15:41] <dstrine>	 awight:  That link is awesome. I've asked like 5 people about that and they just laughed me :(
[20:15:58] <dstrine>	 ok ... like 3 people really
[20:16:01] <grrrit-wm>	 (PS5) Ejegg: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288
[20:17:05] <awight>	 hrm
[20:17:15] <awight>	 We should move it to the public wiki actually.  nothing to hide there.
[20:17:29] <awight>	 And I can never find the little bastard due to search
[20:17:53] <dstrine>	 awight:  pgehres is not related to civi, right?
[20:18:23] <awight>	 sigh
[20:18:35] <awight>	 pgehres is the Django database for storing banner impressions from S:RI
[20:21:18] <awight>	 Totally on my hit list at the end of this queue refactoring
[20:27:30] <grrrit-wm>	 (CR) Awight: [C: -1] "This is *really* great. I made a few suggestions inline..." (9 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[20:28:54] <grrrit-wm>	 (PS6) Ejegg: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288
[20:32:38] <awight>	 gtg!
[20:32:41] <awight>	 have a fun weekend
[20:32:46] <ejegg>	 see ya, you too
[20:37:05] <grrrit-wm>	 (CR) Ejegg: "Krinkle: now with 75% less robotic mangling! I think it's ready for another pass if you want to take a look." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 (owner: Ejegg)
[20:37:21] <ejegg>	 ok, lets see what awight had to say
[20:37:34] <ejegg>	 *let's
[20:42:41] <grrrit-wm>	 (CR) Ejegg: "thanks for the comments. Re-reading, I realize this was panic-tinged code. Maybe we always send antifraud messages on the old filter hoo" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291151 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[20:43:31] <grrrit-wm>	 (CR) Ejegg: Fix defaults for QueueJobRunner (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287871 (owner: Ejegg)
[20:46:09] <grrrit-wm>	 (PS6) Ejegg: Comment and DRY for functions filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 (https://phabricator.wikimedia.org/T136381)
[20:51:50] <grrrit-wm>	 (CR) Ejegg: "d'oh - bad autorebase" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965) (owner: Ejegg)
[21:01:00] <grrrit-wm>	 (PS7) Ejegg: Fix time and message limits [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/288449 (https://phabricator.wikimedia.org/T133965)
[21:03:19] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Removing and re-applying awight's +2 to convince Zuul to merge" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[21:04:44] <grrrit-wm>	 (Merged) jenkins-bot: Comment and DRY for functions filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290830 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[21:23:55] <grrrit-wm>	 (PS4) Ejegg: Rationalize accesibility of fns and methods for Extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982
[21:24:24] <grrrit-wm>	 (CR) Ejegg: "PS4: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[21:25:53] <grrrit-wm>	 (PS5) Ejegg: Const and better name for initial ip velocity flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290990 (https://phabricator.wikimedia.org/T136381)
[21:28:26] <grrrit-wm>	 (PS5) Ejegg: Rationalize accesibility of fns and methods for Extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982
[21:29:12] <grrrit-wm>	 (CR) Ejegg: "PS5: pulled the TestingAccessWrapper up from following patch" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[21:29:23] <grrrit-wm>	 (PS6) Ejegg: Const and better name for initial ip velocity flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290990 (https://phabricator.wikimedia.org/T136381)
[21:36:16] <grrrit-wm>	 (PS8) Ejegg: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197)
[22:08:09] <grrrit-wm>	 (PS9) Ejegg: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197)
[22:11:06] <grrrit-wm>	 (CR) Ejegg: Consume pending queue to database (9 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg)
[22:42:55] <grrrit-wm>	 (PS1) Ejegg: Simplify antifraud message logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291367 (https://phabricator.wikimedia.org/T136381)
[22:43:32] <grrrit-wm>	 (PS2) Ejegg: Simplify antifraud message logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291367 (https://phabricator.wikimedia.org/T136381)
[22:44:24] <grrrit-wm>	 (CR) Ejegg: "I6ce06002eee1f oughtta dissipate some of that funky odor" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291151 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[22:53:17] <ejegg>	 gonna skedaddle. so long!
[23:02:51] <grrrit-wm>	 (CR) Ejegg: "couple questions, i'll look at it more tuesday" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight)
[23:08:12] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2335721
[23:16:56] <dstrine>	 I'm out too...