[08:55:27] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2340468
[12:51:43] <wikibugs>	 fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2340902 (Aklapper) >>! In T135178#2292645, @Cmjohnson wrote: > @jgreen,  We will need to scheduled down time to replace the disk.  @Cmjohnson / @jgreen: Has...
[13:17:28] <grrrit-wm>	 (PS7) Ejegg: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288
[13:20:01] <grrrit-wm>	 (CR) Ejegg: "Thanks Krinkle! Fixed most of 'em in PS7, will do the text() changes in another commit." (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 (owner: Ejegg)
[13:32:28] <grrrit-wm>	 (PS1) Ejegg: jQuery usage tweaks [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291917
[14:28:24] <grrrit-wm>	 (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/291926
[14:28:42] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/291926 (owner: Ejegg)
[14:29:50] <grrrit-wm>	 (CR) Ejegg: [V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/291926 (owner: Ejegg)
[15:21:15] <grrrit-wm>	 (Abandoned) Awight: Bump version minor during cookie migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/288135 (owner: Awight)
[15:33:24] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2341278 (awight) @Eileenmcnaughton...
[15:40:06] <wikibugs>	 Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Tracking: General DonationInterface code cleanup (tracking) - https://phabricator.wikimedia.org/T87043#2341325 (Danny_B)
[15:57:52] <awight>	 hehe, gmail corrected a search for L_PAYMENTREQUEST* to "did you mean L'PAYMENT REQUEST?"
[15:57:55] <awight>	 mai oui
[16:15:36] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 4 others: configure database backups for new log_civicrm database - https://phabricator.wikimedia.org/T133613#2341491 (Jgreen) AFAIK a dump only p...
[16:29:28] <grrrit-wm>	 (CR) Awight: PayPal Express Checkout: recurring (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight)
[16:38:06] <grrrit-wm>	 (PS10) Awight: PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446)
[16:41:10] <grrrit-wm>	 (CR) Awight: PayPal Express Checkout: recurring (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight)
[16:41:19] <awight|distract>	 ejegg|away: ^ ready for more CR
[17:03:11] <awight|distract>	 late for a meeting I called... again
[17:05:27] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2341635
[17:06:27] <dstrine>	 hey XenoRyet welcome back
[17:06:39] <XenoRyet>	 Thanks.  It's good to be home.
[17:07:06] <dstrine>	 XenoRyet: cwd and awight would this be the correct link for adyen in japanese?
[17:07:07] <dstrine>	 https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=cc-vjma&recurring=false&utm_source=.default~default~default~default~control.cc&utm_medium=&utm_campaign=&utm_key=&referrer=&language=ja&country=JP&payment_method=cc&payment_submethod=&gateway=&amountGiven=&currency_code=JPY&frequency=onetime&amount=1000
[17:08:07] <awight>	 ejegg: hey, didn't hear you!
[17:08:29] <dstrine>	 oh hey ejegg
[17:08:43] <XenoRyet>	 dstrine:  Yea, that link looks like it should work.
[17:09:39] <dstrine>	 Do you think it would be ok for us to try France and Japanese adyen for 1 hour? I know we are still waiting for feedback deploys on ukraine and Hebrew. I'm wondering what we can test before that
[17:20:19] <ejegg>	 dstrine: I can deploy that last Hebrew fix in a sec.  Got something in that should prevent failmails like Thursday's
[17:24:11] <dstrine>	 ejegg: ok coo.. Jessica just reported some failures from ukraine: https://phabricator.wikimedia.org/T128812
[17:24:35] <dstrine>	 would it still be ok to try other countries?
[17:27:37] <ejegg>	 I should take a look at the logs to see why it's failing...
[17:27:47] <dstrine>	 ok thanks
[17:29:01] <grrrit-wm>	 (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/291955
[17:34:30] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2341746
[17:36:36] <grrrit-wm>	 (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/291955 (owner: Ejegg)
[17:42:40] <grrrit-wm>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/291955 (owner: Ejegg)
[17:54:04] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: Make an estimate of the proportion of people affected by order id collision - https://phabricator.wikimedia.org/T136328#2341859 (DStrine) @awight  What is the user experience as we approach .8%?  When...
[17:57:50] <grrrit-wm>	 (CR) Krinkle: [C: 1] "LGTM!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 (owner: Ejegg)
[18:00:29] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: Make an estimate of the proportion of people affected by order id collision - https://phabricator.wikimedia.org/T136328#2341895 (jrobell) Thanks @Dstrine. I have sent the Japan form to a few local tes...
[18:00:34] <grrrit-wm>	 (CR) Krinkle: jQuery usage tweaks (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291917 (owner: Ejegg)
[18:00:58] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: Make an estimate of the proportion of people affected by order id collision - https://phabricator.wikimedia.org/T136328#2341896 (awight)
[18:06:50] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: Make an estimate of the proportion of people affected by order id collision - https://phabricator.wikimedia.org/T136328#2341909 (awight) @DStrine  I hate to say it, but it looks like we'll survive eve...
[18:07:14] <ejegg>	 !log updated payments-wiki from e6807395d7687d521070b83d159b77b242e5c04f to 5bb160e9898224e1d7d0a5c57fe408edb998a262
[18:07:20] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[18:14:34] <ejegg>	 deploy looks good
[18:15:04] <ejegg>	 I had hoped that Locale thing would fix the Adyen iframe being in the wrong language if you leave off uselang
[18:15:48] <ejegg>	 trying to figure out why we still need that
[18:16:01] <eileen>	 hello - I'm in Denver .. but cwd isn't :-(
[18:16:45] <ejegg>	 aww
[18:16:54] <ejegg>	 how's the altitude treating you?
[18:17:32] <cwd>	 :(
[18:17:39] <cwd>	 400 miles due south
[18:17:59] <cwd>	 or should i say...643.738km
[18:20:13] <eileen>	 thanks for the metric conversion
[18:20:33] <eileen>	 altitude seems OK - maybe I can use it as an excuse for my poor fitness
[18:20:48] <eileen>	 (I'm just out of breath because of the altitude, honest)
[18:21:13] <eileen>	 I don't think I'll join the meeting in 30 mins though
[18:22:29] <eileen>	 I sat next to a woman on the plane who is doing this race … http://transambikerace.com/
[18:22:42] <eileen>	 "self supported road racers on a 4400 mile journey across the United States at break neck speed. "
[18:23:13] <dstrine>	 wow
[18:26:33] <awight>	 ejegg: If you leave off uselang?? that's creepy, I'd like to take a look at it if still unsolved
[18:28:00] <grrrit-wm>	 (PS1) Ejegg: Don't rely on uselang for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291961 (https://phabricator.wikimedia.org/T128812)
[18:28:17] <ejegg>	 awight: dumb javascript, easy fix ^^
[18:28:58] <awight>	 aha
[18:29:35] <grrrit-wm>	 (CR) Awight: [C: 2] "Good find!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291961 (https://phabricator.wikimedia.org/T128812) (owner: Ejegg)
[18:31:11] <grrrit-wm>	 (Merged) jenkins-bot: Don't rely on uselang for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291961 (https://phabricator.wikimedia.org/T128812) (owner: Ejegg)
[18:31:28] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2341989
[18:32:46] <ejegg>	 awight: i ripped out most of the stinky stuff from that antifraud message rate limiting: https://gerrit.wikimedia.org/r/291367
[18:34:15] <ejegg>	 real simple logic now.  Always send on the old 'validate' hook, only send on the initial hook if fraud-failing
[18:37:57] <grrrit-wm>	 (CR) Awight: [C: 2] "Oh, cool! I have a longer-term question about sendAntifraudMessage, though" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291367 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[18:43:26] <awight>	 eileen: heads-up on the time zone conversion, the backlog meeting is in 80 minutes now.  Still fine to miss, of course!
[18:43:51] <grrrit-wm>	 (CR) Ejegg: Simplify antifraud message logic (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291367 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[18:47:12] <ejegg>	 crud, a bunch of ffname '' is invalid. Assigning ffname ''....
[18:47:44] <ejegg>	 maybe that selection_weight silliness.
[18:49:29] * awight facepalms
[18:55:23] <eileen>	 awight: ah cool - I'll miss it a bit later then :-)
[18:55:31] <ejegg>	 aargh,  ffname 'adyen' is invalid. Assigning ffname ''.... that's totally not correct
[18:55:52] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2342071
[18:56:07] <ejegg>	 but it's not breaking from the donor side...
[18:59:24] <dstrine>	 ejegg: is this anything that would affect adyen tests? jessica and peter would like to try to set up some 1 hours tests on thursday. Do you think we can make those plans?
[18:59:47] <dstrine>	 their prioirty would be heberw and ukrainian forms
[19:01:36] <ejegg>	 dstrine: it would get good data for fr-not-tech
[19:01:52] <ejegg>	 but the extra log noise would make errors harder for -tech to spot
[19:02:10] <ejegg>	 would be easy to filter if we couldn't figure it out though
[19:02:15] <ejegg>	 I wouldn't make it a blocker
[19:02:37] <dstrine>	 this would be a blocker to campaign ready?
[19:03:49] <ejegg>	 dstrine: yeah, I wouldn't want all that noise long term
[19:03:50] <dstrine>	 I gotta grab food let's chat in the next meeting
[19:03:53] <ejegg>	 sure
[19:03:54] <dstrine>	 ok
[19:27:36] <grrrit-wm>	 (PS4) Awight: Stop sending item category [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288253 (https://phabricator.wikimedia.org/T134446)
[19:50:43] <grrrit-wm>	 (PS1) Ejegg: Skip ffname logic for Mustache-rendered forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291975 (https://phabricator.wikimedia.org/T128812)
[19:54:36] <grrrit-wm>	 (CR) Awight: "Tiny cleanup suggestions and cheerleading inline. More tests would be nice!" (10 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg)
[19:57:04] <grrrit-wm>	 (CR) Awight: [C: 2] "/me rubs hands at the prospect of deleting the rest of that function" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291975 (https://phabricator.wikimedia.org/T128812) (owner: Ejegg)
[19:57:52] <wikibugs>	 Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Don't make donors guess minimum donation amount - https://phabricator.wikimedia.org/T105618#2342449 (awight) @Ejegg  Great idea!
[19:58:24] <grrrit-wm>	 (Merged) jenkins-bot: Skip ffname logic for Mustache-rendered forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291975 (https://phabricator.wikimedia.org/T128812) (owner: Ejegg)
[20:03:19] <dstrine>	 AndyRussG: meeting?
[20:03:50] <AndyRussG>	 dstrine: yep!
[21:07:09] <wikibugs>	 Fundraising-Backlog, FR-Smashpig: Add 1 day banner history queue to expiry job - https://phabricator.wikimedia.org/T136646#2342702 (Ejegg)
[21:15:41] <awight>	 dstrine: https://raw.githubusercontent.com/wikimedia/mediawiki-vagrant/master/puppet/modules/payments/files/Main_Page.wiki
[21:17:30] <ejegg>	 dstrine: https://www.mediawiki.org/wiki/Fundraising_tech/Test_links
[21:18:36] <ejegg>	 couple of those vagrant links could use another update
[21:27:16] <ejegg>	 https://gerrit.wikimedia.org/r/292034
[21:34:39] <awight>	 !log Enable PayPal Express Checkout in paymentswiki config.
[21:34:44] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[21:36:34] <wikibugs>	 Fundraising-Backlog, FR-Smashpig: Add 1 day banner history queue to expiry job - https://phabricator.wikimedia.org/T136646#2342825 (Jgreen) Deploying now...
[21:50:36] <awight>	 okay, away'ing to do an errand
[21:57:00] <wikibugs>	 Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Operations, Traffic: Provide location, logged-in status and device information in ResourceLoaderContext - https://phabricator.wikimedia.org/T103695#2342913 (BBlack) This ticket is getting stale, is it still relevant and up-to-date with cu...
[22:19:39] <grrrit-wm>	 (PS6) Cdentinger: Rationalize accesibility of fns and methods for Extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[22:21:24] <grrrit-wm>	 (CR) Ejegg: [C: -1] "That case statement with checkAck everywhere except ProcessReturn, illustrates how bad an idea it was for me to re-use processResponse in " (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight)
[22:23:31] <grrrit-wm>	 (CR) Ejegg: "I think I remember you disapproving of that pattern when I shoehorned it into AstroPay..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight)
[22:25:55] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Rationalize accesibility of fns and methods for Extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[22:27:21] <grrrit-wm>	 (Merged) jenkins-bot: Rationalize accesibility of fns and methods for Extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290982 (owner: Ejegg)
[22:28:13] <ejegg>	 thanks for the CR!
[22:28:29] <ejegg>	 lappy's nearly dead... relocating
[23:07:21] <grrrit-wm>	 (PS7) Cdentinger: Const and better name for initial ip velocity flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290990 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[23:12:39] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Const and better name for initial ip velocity flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290990 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[23:19:40] <grrrit-wm>	 (Merged) jenkins-bot: Const and better name for initial ip velocity flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290990 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg)
[23:20:02] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: Make an estimate of the proportion of people affected by order id collision - https://phabricator.wikimedia.org/T136328#2343219 (MBeat33) Opening the iframe is not as bad a delay as one after sending...