[01:48:18] (PS11) Awight: PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) [01:49:15] (CR) Awight: "PS11: Use generic error code in response processing exceptions." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [01:58:17] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Move controller code out of GatewayType#processResponse - https://phabricator.wikimedia.org/T136665#2343529 (awight) [02:00:34] (CR) Awight: "@ejegg" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [02:03:13] (CR) Awight: "More rationale for getting this out without coupling to refactoring work, is that I want to cross this hacky milestone ASAP: T131800. The" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [04:37:11] (PS12) Ejegg: PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [04:44:05] (CR) Ejegg: [C: 2] "Makes sense, I was only blocking on the error codes. Let's see this baby in the wild!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [04:44:47] (PS5) Ejegg: Stop sending item category [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288253 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [04:44:59] (CR) Ejegg: [C: 2] Stop sending item category [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288253 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [04:46:08] (Merged) jenkins-bot: PayPal Express Checkout: recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287036 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [04:47:10] (Merged) jenkins-bot: Stop sending item category [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288253 (https://phabricator.wikimedia.org/T134446) (owner: Awight) [09:56:38] § Fundraising Sprint Abba: test - https://phabricator.wikimedia.org/T136689#2344308 (Fabfag) [09:56:56] § Fundraising Sprint Abba: - https://phabricator.wikimedia.org/T136689#2344321 (Fabfag) [15:45:11] (PS3) Cdentinger: Simplify antifraud message logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291367 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg) [15:52:06] (CR) Cdentinger: [C: 2] Simplify antifraud message logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291367 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg) [15:53:36] (Merged) jenkins-bot: Simplify antifraud message logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291367 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg) [16:21:53] (Abandoned) Cdentinger: WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger) [16:22:47] (Abandoned) Cdentinger: handle no 'donation age' results [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257927 (owner: Cdentinger) [16:23:27] (Abandoned) Cdentinger: Record donor name after card authorize [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/239925 (owner: Cdentinger) [16:24:03] (Abandoned) Cdentinger: adds a workingish a/b button using wmf_ab [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/216343 (owner: Cdentinger) [16:24:30] (Abandoned) Cdentinger: make a/b widget return some fake data [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/215758 (owner: Cdentinger) [16:41:13] cwd: thanks for the CR! Think I'll do a deploy to get the rest of the paypal stuff out [16:41:51] sure! mostly just merging things that already had +2 but got buried :P [16:42:11] trying to clean up the gerrit [16:42:20] i abandoned all my pending stuff [16:42:22] it was all old [16:42:28] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292171 [16:42:45] ah, I've got some hopeless cases I should probably ditch too [16:43:05] it's hard to press the button on some of them [16:43:16] but life's too short to incubate dead ends [16:43:37] oh man, even a couple attempted core bugfixes from when I was interviewing for WMF [16:45:40] (CR) Ejegg: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292171 (owner: Ejegg) [16:47:25] hehe, memory lane [16:49:15] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292174 [16:49:37] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292174 (owner: Ejegg) [17:04:14] cwd / XenoRyet|afk : any news for scrum of scrums? [17:04:30] Na, nothing here. [17:06:32] !log updated payments-wiki from 5bb160e9898224e1d7d0a5c57fe408edb998a262 to a335a3a6f8909d1e7e1a79877512a12a0561aa2a [17:06:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:15:26] !log rolled back payments-wiki from a335a3a6f8909d1e7e1a79877512a12a0561aa2a to 5bb160e9898224e1d7d0a5c57fe408edb998a262 [17:15:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:18:28] ejegg: good here, thanks [17:32:07] (PS1) Ejegg: Make custom filters singleton method public [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292183 (https://phabricator.wikimedia.org/T136381) [17:55:19] fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2345597 (Cmjohnson) Ended up replacing both disks and Jeff will re-install. [17:56:06] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2345600 (Cmjohnson) Silicon has a send ethernet port wired up and does not appear to be in use. [17:56:07] cwd / XenoRyet : got a sec for a super-simple CR? https://gerrit.wikimedia.org/r/292183 fixes the thing that made me roll back just now [17:57:01] ejegg: Sure, let me take a look [17:57:10] ejegg: why the rollback? [17:57:15] oh haha [17:57:22] i read the first half of the sentence and stopped [17:57:58] (CR) Cdentinger: [C: 2] Make custom filters singleton method public [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292183 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg) [18:00:53] thanks! [18:02:47] (Merged) jenkins-bot: Make custom filters singleton method public [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292183 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg) [18:03:04] cool, I'mma redeploy [18:05:23] (PS1) Ejegg: Make custom filters singleton method public [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292191 (https://phabricator.wikimedia.org/T136381) [18:05:41] (CR) Ejegg: [C: 2 V: 2] Make custom filters singleton method public [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292191 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg) [18:06:37] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292192 [18:09:20] (CR) Krinkle: [C: -1] jQuery usage tweaks [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291917 (owner: Ejegg) [18:09:47] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292192 (owner: Ejegg) [18:13:21] Fundraising-Backlog, FR-Adyen: Spike: investigate what went wrong with recent Carte Bleu donations - https://phabricator.wikimedia.org/T136719#2345648 (awight) [18:13:35] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Spike: investigate what went wrong with recent Carte Bleu donations - https://phabricator.wikimedia.org/T136719#2345663 (awight) [18:16:21] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292192 (owner: Ejegg) [18:19:15] !log updated payments-wiki from 5bb160e9898224e1d7d0a5c57fe408edb998a262 to 7d222320b35ad8a44d8c77a4c3019364a49e53f2 [18:19:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:31:11] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Spike: investigate what went wrong with recent Carte Bleu donations - https://phabricator.wikimedia.org/T136719#2345801 (awight) Confirmed. The one CB transaction was for $2.00, at 2016-05-24T09:41:54. It pro... [18:53:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface: 'order_id' is ambiguous. Call it 'merchant reference' whenever we generate it. - https://phabricator.wikimedia.org/T136730#2345903 (Ejegg) [18:59:20] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Merchant reference generation should have options for attempt number or API sequence - https://phabricator.wikimedia.org/T136733#2345971 (Ejegg) [19:07:06] (PS1) Ejegg: Fill missing antifraud message order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292203 [19:09:16] (CR) jenkins-bot: [V: -1] Fill missing antifraud message order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292203 (owner: Ejegg) [19:11:28] (PS2) Ejegg: Fill missing antifraud message order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292203 [19:21:32] (CR) Ejegg: "Holy crap, my earlier code was using a totally wrong variable name for the message. WTF PHP, any sane language would have screamed about t" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292203 (owner: Ejegg) [19:24:58] gotta relocate, be back before standup... [19:32:02] (CR) XenoRyet: [C: 2] "Does what it says, looks good to me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292203 (owner: Ejegg) [19:33:33] (Merged) jenkins-bot: Fill missing antifraud message order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292203 (owner: Ejegg) [19:44:36] fundraising-tech-ops, Operations, ops-eqiad: investigate RAID failure on beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T135178#2346110 (Jgreen) Open>Resolved rebuilt, kerberos data restored [19:45:44] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2346116 (Jgreen) Perfect! [19:59:58] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, MediaWiki-extensions-DonationInterface, Epic: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2346138 (awight) [20:01:10] (PS1) Ejegg: Fill missing antifraud message order_id [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292211 [20:01:31] (CR) Ejegg: [C: 2 V: 2] Fill missing antifraud message order_id [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292211 (owner: Ejegg) [20:02:26] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292213 [20:02:38] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292213 (owner: Ejegg) [20:07:08] AndyRussG: standup? [20:12:21] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292213 (owner: Ejegg) [20:36:57] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, and 3 others: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2179067 (awight) [20:36:59] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Internal Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2346298 (awight) [20:37:10] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, MediaWiki-extensions-DonationInterface, Epic: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2346305 (awight) [20:42:46] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Renew PayPal API certificate. Due date: Aug 1st - https://phabricator.wikimedia.org/T136742#2346343 (awight) [20:44:18] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Support API certificate method - https://phabricator.wikimedia.org/T136743#2346358 (awight) [20:45:55] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 2 others: Support API certificate method - https://phabricator.wikimedia.org/T136743#2346358 (awight) a:awight [20:46:36] AndyRussG: Here's the task for the hide cookie snafu, https://phabricator.wikimedia.org/T130442 [20:49:34] !log updated paymentswiki from 7d222320b35ad8a44d8c77a4c3019364a49e53f2 to 44bd699d6700ac4faf3c2d772ba713b093ae8cb8 [20:49:41] Fundraising Sprint Killing Time, Fundraising-Backlog: Ingenico iframe styling has changed - https://phabricator.wikimedia.org/T135388#2346402 (cwdent) a:cwdent [20:49:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:50:07] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: PayPal Express Checkout is missing a payment_method. Decide on one and implement. - https://phabricator.wikimedia.org/T136745#2346404 (awight) [21:07:10] (PS1) Cdentinger: restore GC iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 [21:15:51] awight: Thx! Rrrrg ping notifications not working yet on this IRC client... [21:16:28] oops! [21:16:52] Heh neither does clicking on links [21:16:58] * AndyRussG contemplates going back to Quassel [21:18:11] irssi FTW [21:19:05] Quassel doesn't seem to support OTR? :( [21:19:34] https://github.com/glowing-bear/glowing-bear [21:19:42] Yeah it doesn't [21:19:50] Or rather, not it doesn't [21:19:52] no it doesn't [21:20:00] No, you're right [21:20:01] hehe [21:22:06] Ohyeah cwd I remember you mentioning that once before... [21:24:10] i really recommend it [21:24:19] it's better than irc cloud, and open source [21:25:06] you are welcome to use my secure relay https://caseydentinger.com:9000/# [21:25:19] you just point that at your weechat relay [21:25:36] (it's good to set up ssl for that connection too) [21:27:13] (CR) Ejegg: "needs https://github.com/wikimedia/mediawiki-extensions-DonationInterface/commit/88aa10495d3df881ad9f6783d4da2a6424f75155#diff-e519297cfd0" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 (owner: Cdentinger) [21:27:58] (CR) Ejegg: "Also, it would be nice to remove those misleading "this is for local testing" comments!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 (owner: Cdentinger) [21:32:53] (PS2) Cdentinger: restore GC iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 [21:33:55] (CR) jenkins-bot: [V: -1] restore GC iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 (owner: Cdentinger) [21:36:47] (PS3) Cdentinger: restore GC iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 [21:40:41] (PS1) Awight: Wrap gateway URL in an accessor function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292272 (https://phabricator.wikimedia.org/T136743) [21:41:52] (CR) Ejegg: [C: 2] "That oughtta do it! Thanks for cleaning up my mess." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 (owner: Cdentinger) [21:42:07] (CR) jenkins-bot: [V: -1] Wrap gateway URL in an accessor function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292272 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:43:34] (Merged) jenkins-bot: restore GC iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292232 (owner: Cdentinger) [21:46:04] thanks ejegg! [21:46:35] sorry for that overzealous cleanup everyone! [21:47:23] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 4 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2346834 (matmarex) Resolved>Open I... [21:53:21] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 5 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2346883 (matmarex) CentralNotice seems to h... [21:54:23] ejegg: were your last couple commits on deployment cherry picked? merge appears to merge them twice [21:56:16] ah yeah [21:56:23] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 5 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2346901 (matmarex) [21:56:28] i guess they'll be no-ops [21:56:28] I guess I didn't think about that, sorry [21:56:34] oughtta be [21:56:50] np! [21:56:59] continuous deployment! [21:58:16] (PS1) Cdentinger: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292280 [21:58:51] i don't actually understand why they appear twice [21:59:07] some git voodoo [21:59:32] d'oh! they re-deployed the faulty CN patch by mistake [21:59:34] awight: ejegg: ^ bad patch causing IE11 outage somehow got back onto production, in 1.28.0-wmf4 [21:59:45] ejegg: jinx! [21:59:46] heh [21:59:54] It's not on wp thankfully [22:00:13] Maybe some automatic process associated with wmf_deploy [22:00:15] so... can i just merge the fix to wmf deploy branch? [22:00:15] branch [22:00:42] ejegg: yeah that'd be great! [22:01:03] k, I'll do that [22:02:33] ejegg can you add bug T136387? [22:02:34] T136387: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387 [22:03:33] AndyRussG: sorry, add the bug to what? [22:04:04] Also, log wmf_deploy..master seems long. Been a bunch of cherry-pick deploys? [22:04:13] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 5 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2347308 (AndyRussG) Aaaaarg!! Fortunately,... [22:05:10] Probably there have [22:05:11] (CR) Cdentinger: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292280 (owner: Cdentinger) [22:05:46] ejegg: the Bug: T136387 tag to the merge to wmf_deploy commit message? [22:05:46] T136387: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387 [22:05:49] Or does that make sense [22:05:58] Who is stashbot? [22:06:24] oh, right, I can add that to the merge message too [22:06:24] At least this IRC client has smooth scrolling! [22:07:03] And nice colours [22:09:36] AndyRussG: Sorry for the bad news, but the ECMA6 thing just regressed [22:09:45] I think wmf_deploy wasn't reverted and it went out with today's train. [22:09:50] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292280 (owner: Cdentinger) [22:09:51] awight: correct [22:10:03] I can prepare a patch for today's swat--are you going with the revert or with ejegg's fix? [22:10:39] I think ejegg's doing a patch on wmf_deploy... Yeah I was going to say, we should request a SWAT. It's not on WP yet, only.... everything else. [22:10:46] (PS1) Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/292282 (https://phabricator.wikimedia.org/T136387) [22:11:20] ejegg: noooo.... [22:11:24] ^^^ was kinda a hefty merge, with a couple minor conflicts [22:11:45] (CR) AndyRussG: [C: -2] "Let's the ECMA6 thing first... K? Thx!!!" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/292282 (https://phabricator.wikimedia.org/T136387) (owner: Ejegg) [22:12:15] AndyRussG: so just a revert for now? [22:12:29] Rather a cherry-pick of just the fix? Would that make sense? [22:12:50] The fix touched a lot of files to make jshint happy... [22:13:31] I'll see if it cherry-picks cleanly though [22:13:45] (PS1) Cdentinger: Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292283 [22:13:51] ejegg: Ah I see [22:13:55] If it doesn't then let's just revert [22:14:21] (CR) jenkins-bot: [V: -1] Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292283 (owner: Cdentinger) [22:14:56] conflicts in impressionDiet and kvStore :( [22:15:31] K let's just revert then? [22:15:40] will do [22:16:05] The merge brings in all the new cookie stuff, I feel it's too much when we're in semi-broken state [22:16:40] k [22:17:00] (PS1) Ejegg: Revert "ext.centralNotice.display: API for registering tests" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/292285 (https://phabricator.wikimedia.org/T136387) [22:18:46] AndyRussG ok, ^^^ is occam-friendly [22:19:44] (Abandoned) Cdentinger: Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292283 (owner: Cdentinger) [22:20:02] oh hey, it's ockham's razor... [22:20:39] self-merge is OK on wmf_deploy, right? [22:20:48] yep! [22:21:03] unfortunately, the simplest possible spelling is not always correct [22:21:12] (CR) Ejegg: [C: 2 V: 2] Revert "ext.centralNotice.display: API for registering tests" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/292285 (https://phabricator.wikimedia.org/T136387) (owner: Ejegg) [22:21:43] (PS1) Cdentinger: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292286 [22:24:11] (CR) Cdentinger: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292286 (owner: Cdentinger) [22:24:38] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 5 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2347395 (Ejegg) Sorry! https://gerrit.wiki... [22:25:08] (Abandoned) Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/292282 (https://phabricator.wikimedia.org/T136387) (owner: Ejegg) [22:28:54] ejegg: awight: shall I add the revert patch to the SWAT deploy? [22:29:29] I think MatmaRex already merged a fix to the wmf.4 tree [22:29:29] AndyRussG: looks like someone reverted the submodule bump in -wmf.4 [22:29:34] jinx! [22:29:38] 1..10 [22:29:46] heh [22:30:38] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292286 (owner: Cdentinger) [22:36:14] !log updated paymentswiki from 44bd699d6700ac4faf3c2d772ba713b093ae8cb8 to d26426c4225080c95f0bd5a6a31c54e4826287b1 [22:36:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:37:32] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 5 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2332918 (mmodell) deployed [22:38:39] Fundraising Sprint Killing Time, Fundraising-Backlog: Ingenico iframe styling has changed - https://phabricator.wikimedia.org/T135388#2347453 (cwdent) Open>Resolved Stylesheet was accidentally deleted, has been restored. [22:40:45] (PS1) Ejegg: Add comments explaining gc.iframe module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292289 (https://phabricator.wikimedia.org/T135388) [22:42:33] the-wub: I just noticed the hits from _adyen_test running into problems at the form chooser [22:43:20] hi AndyRussG :] [22:44:05] form chooser logic was sending random users to Adyen as soon as it listed more CC types than any single ingenico form [22:44:19] AndyRussG, so should I resend the email? or do you prefer me to explain here? [22:44:49] the-wub: so we had to tell it to only select adyen if you add ffname=adyen [22:44:59] the-wub: sorry, I should have communicated that to you [22:45:01] mforns: heads-up, Andrew just installed a new IRC client, I don't think his highlighting is set up yet. i.e. it may take a minute. [22:45:11] thanks awight :] [22:46:01] of course! [22:46:23] mforns: Feel free to explain the issue here, too, if it's Fundraisingy and not personal [22:47:32] awight, it's partially fundraisingy and partially analytics, but I'm with andrew in gtalk anyway, thanks! [22:48:14] ok great, thank you [22:49:04] awight: dang, looks like my blunt form chooser fix is messing up the-wub's normal banner logic [22:49:09] Not able to find a valid form for country 'UA', currency 'UAH', method 'cc', submethod '', recurring: 'false', gateway 'adyen' for utm source 'peter_0602_adyen_test.no-LP.cc' [22:49:28] eh [22:49:50] ejegg: have you played with testGetAll? [22:49:52] because selection_weight=0, it's knocking them all out [22:49:56] ok [22:50:21] Let's... get rid of the magic numbers perhaps? [22:50:26] yah [22:50:59] and I guess it might be time to corral the requirements for the chooser [22:51:00] but we have to also change the 'always go with more submethods' unless we want to send all the donors to adyen instead of ingenico [22:51:06] We're also on the ropes with the Mustache choosing [22:51:12] T136254 [22:51:13] T136254: Refactor form chooser - https://phabricator.wikimedia.org/T136254 [22:51:18] * awight perks up [22:51:22] (CR) XenoRyet: [C: 2] Add comments explaining gc.iframe module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292289 (https://phabricator.wikimedia.org/T135388) (owner: Ejegg) [22:52:12] that starts towards the 'query capabilities' road you mapped [22:53:09] but leaves us a simple way to keep unready forms from being chosen over established ones [22:55:11] mforms Hi! heh sorry my IRC client doesn't notify pings properly, just getting everything re-set up [22:55:24] cwd: I know you were interested in the form chooser, wanna look at the bug above? [22:55:42] sure thing [22:55:59] i had some ideas about that selection weight thing [22:56:59] (Merged) jenkins-bot: Add comments explaining gc.iframe module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292289 (https://phabricator.wikimedia.org/T135388) (owner: Ejegg) [22:57:18] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor form chooser - https://phabricator.wikimedia.org/T136254#2328603 (awight) "weight" is problematic because it's usually the reverse sense--higher weight sinks to the bottom. I don't like the specificity comparisons, those will give us... [22:59:00] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 5 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2347540 (AndyRussG) @mmodell @Ejegg @matmar... [23:00:18] ejegg: awight: I guess u saw mmodell just deployed the reversion fix! [23:00:42] yah he deployed that before I could blink! [23:00:52] Heh yeah! [23:00:53] oops--here goes the cookie "fix" [23:01:00] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor form chooser - https://phabricator.wikimedia.org/T136254#2347551 (Ejegg) [23:01:19] awight: did that get tested on the beta cluster, too? [23:01:29] no, sorry :( [23:01:38] We should probably abort? [23:01:47] that's easy + respectable [23:03:16] Nah [23:03:21] It looks fine [23:03:23] hehe okay /me buckles up [23:03:33] Or are u doing the deploying? [23:03:38] nope [23:03:42] K [23:03:58] Yeah I guess let's let 'em let it out [23:04:15] what could go wrong ;) [23:06:27] Hmmm apparently the config didn't make it to the batter cloister [23:06:48] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor form chooser - https://phabricator.wikimedia.org/T136254#2347576 (Ejegg) I added an initial step explaining what the rest of the steps mean by 'valid' forms. Which sounds better to you for suppressing unready forms? - rename/renumber... [23:07:09] Why is that? I guess the patch should have changed something batter cloister-y, too? [23:07:33] What you mean by that? [23:07:45] I think he's probably getting to it in a few minutes [23:07:51] just did another config change... [23:08:18] oh hehe I just decoded [23:08:28] that stuff will rot13 your brains out :p [23:08:42] awight: sorry, does mediawiki-config not have depoyment branches or such? [23:08:50] no [23:08:59] So, just when they merge it it goes out to prod? [23:09:09] ah--there's a betalabs variant where you can test though [23:09:21] Ah right [23:09:22] e.g. InitialiseSettings-labs.php [23:09:24] * AndyRussG remembers [23:11:02] K I see, so that file just contains the settings to override [23:12:37] Anyway, hide cookies do seem to work fine on the beta cluster, using the old seting [23:17:04] (PS1) Awight: [WIP] Support certificate authentication [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292296 (https://phabricator.wikimedia.org/T136743) [23:18:40] (CR) jenkins-bot: [V: -1] [WIP] Support certificate authentication [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292296 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [23:22:04] awight: hahaha the hide cookies on beta cluster actually set the cookies on production! [23:22:23] I was looking for where those production URLs were substituted, guess they're not [23:24:58] I'm having a hard time testing on production... [23:25:41] ok wmf/TY page does the right thing. But I think that's coded onwiki [23:25:56] oh, I've ta'en too little care of this [23:27:25] eek--I guess banner diet counts are not shared between wikis [23:29:11] AndyRussG: looks like setHideCookies is only in the customHideBanner code path, and that has to be called from banner code? [23:30:35] awight there's a method on mw.centralNotice [23:30:53] I just tested on prod with https://en.wikipedia.org/wiki/Main_Page?country=IN [23:30:57] Works fine! :) [23:31:26] I see, hideBannerWithCloseButton works too [23:31:34] ahem s/works/uses the same function/ [23:32:07] All good! [23:32:13] Race u to [23:32:18] #wikimedia-operations [23:34:13] weird. I still couldn't confirm. My breakpoint never tripped, etc. [23:34:38] Just open in a new window and watch the Network tab [23:35:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor form chooser - https://phabricator.wikimedia.org/T136254#2347660 (awight) I like priority, but I think for suppressing automatic choice we should have a self-explanatory flag like 'isTestingOnly' [23:37:44] awight huh maybe mmodel just commented "Deployed" but didn't actually deploy or anything? [23:39:23] That could be [23:39:30] http://wikitech.wikimedia.org/view/Server_admin_log [23:39:57] 22:30 logmsgbot: twentyafterfour@tin Synchronized php-1.28.0-wmf.4/extensions/CentralNotice/: deploy https://gerrit.wikimedia.org/r/#/c/292279/ (duration: 00m 26s) [23:40:03] That might not be what we needed [23:52:11] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Internet-Explorer, and 6 others: CentralNotice failing in older browsers due use of ECMAScript 6 syntax - https://phabricator.wikimedia.org/T136387#2347698 (matmarex) @mmodell The revert does... [23:54:18] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Spike: investigate what went wrong with recent Carte Bleu donations - https://phabricator.wikimedia.org/T136719#2347701 (awight) Open>Resolved [23:54:25] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Internal Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2347703 (awight) [23:54:27] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, and 3 others: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2347702 (awight) Open>Resolved [23:54:30] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, MediaWiki-extensions-DonationInterface, Epic: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2347704 (awight) [23:54:36] Fundraising-Backlog, Security-Data-Mapping, Documentation: FR Tech Data Map - https://phabricator.wikimedia.org/T133236#2347707 (awight) [23:54:38] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, Security-Data-Mapping: Rough draft of data flow map - https://phabricator.wikimedia.org/T133810#2347706 (awight) Open>Resolved [23:54:41] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2347709 (awight) [23:54:43] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Amazon, and 3 others: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2347708 (awight) Open>Resolved [23:54:49] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Ingenico, Unplanned-Sprint-Work: Spike: Make an estimate of the proportion of people affected by order id collision - https://phabricator.wikimedia.org/T136328#2347710 (awight) Open>Resolved [23:54:51] Fundraising-Backlog, FR-Ingenico, Epic: [Epic] Must open a new GlobalCollect account in order to escape Order ID apocalypse - https://phabricator.wikimedia.org/T121000#2347711 (awight) [23:54:55] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: SmashPig should read config from /etc - https://phabricator.wikimedia.org/T133601#2236963 (awight) Open>Resolved [23:55:27] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Spike: investigate what went wrong with recent Carte Bleu donations - https://phabricator.wikimedia.org/T136719#2345648 (awight) a:awight [23:55:31] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, and 3 others: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2179067 (awight) a:awight [23:55:42] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, and 3 others: Revisit Adyen missing donor info behavior - https://phabricator.wikimedia.org/T136038#2347717 (awight) a:Ejegg [23:56:41] AndyRussG: Want me to poke around the deployment server to understand what's wrong with the revert deploy? [23:59:57] AndyRussG: production 1.28-wmf.4 is at 88137bbe7e098385e0711e0ba72fd326e4e395d9 which is the bad patch