[00:05:29] * awight wipes away digital sweat
[00:05:32] <awight>	 AndyRussG: hi!
[00:05:42] <awight>	 Want to talk about the CN deployment snafu?
[00:06:16] <AndyRussG>	 awight: sure how about in 15 min?
[00:06:40] <awight>	 that WFM, or it can wait for a more human Eastern hour
[00:06:46] <awight>	 *humane
[00:06:52] <AndyRussG>	 Or is that past your commute start time?
[00:07:07] <awight>	 hehe.  I'm stuck at work until this scap finishes
[00:07:11] <AndyRussG>	 Could be a bit sooner
[00:07:16] <awight>	 maybe for an hour :(
[00:14:23] <AndyRussG>	 awight: heh putting the kids to bed was faster than usual ;p so anytime is fine! Just lemme bringing this lopsided computer downstairs...
[00:14:59] <awight>	 wow!  That sure was fast
[00:16:49] <AndyRussG>	 Heh I think Sofia ate too much chocolate cake, and just wanted to go lie down... and her sister followed suit
[00:22:10] <AndyRussG>	 awight: neway, anytime you want to talk is cool
[00:22:27] <awight>	 what medium u prefer?
[00:22:38] <AndyRussG>	 ur choice!
[00:22:49] <awight>	 IRC is fine...
[00:22:52] <AndyRussG>	 K!
[00:23:12] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turning on geocoding for proximity searches - https://phabricator.wikimedia.org/T136901#2351757 (LeanneS)
[00:23:27] * awight winces at task
[00:23:28] <AndyRussG>	 Mmmm so is there a link to this purported autodeploy mechanism code?
[00:23:37] <awight>	 good question... let's spelunk
[00:24:33] <awight>	 huh.  I don't see any of the bot's commits in gerrit, e.g. 614b676ae16ac24f101aa4263230419a56b8ed7d
[00:25:24] <awight>	 committer Gerrit Code Review <gerrit@wikimedia.org> 1464907774 +0000
[00:25:27] <awight>	 rats
[00:27:30] <AndyRussG>	 Hmmm
[00:27:40] <AndyRussG>	 I think I have not yet met this so-named "bot"
[00:27:43] <awight>	 (asking in ops)
[00:31:55] <awight>	 well... that's not working
[00:49:20] <grrrit-wm>	 (PS1) Ejegg: Render error forms with Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292512 (https://phabricator.wikimedia.org/T131995)
[01:00:12] <AndyRussG>	 awight: hahah kids weren't really asleep it seems, /me hears kid noises upstairs...
[01:00:43] <awight>	 hehe.  We "gave" mari her own room two days ago, so I'm just learning about these thigns.
[01:01:36] <awight>	 It's amazing how quickly she grew up, apparently in response!  like, a dry morning diaper...  it seems to be a big deal
[01:01:49] <AndyRussG>	 awight: amazing! way to go :)
[01:02:22] <AndyRussG>	 Ahaha I see, Sofi claims to have lost a tooth, but couldn't find it, and was concerned "because money", so got up to look for it, and that woke up her sister...
[01:02:36] <awight>	 hehehe
[01:03:01] <awight>	 Future director of Fundraising
[01:04:44] <AndyRussG>	 Come to think of it, she owes me for the plasma ball from the museum store
[01:09:32] <grrrit-wm>	 (PS1) Ejegg: Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001)
[01:10:13] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904#2351830 (awight)
[01:11:17] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001) (owner: Ejegg)
[01:11:18] <awight>	 I think that's it for me.  See you soon!
[01:11:32] <ejegg>	 see ya
[01:11:33] <awight>	 lol plasma ball.  The stakes sure get higher as they grow.
[01:11:41] <awight>	 wat.  you all work too much
[01:21:39] <AndyRussG>	 awight: bye!
[01:22:15] <AndyRussG>	 It was, "I have $13 saved up at home from my allowance"... and it cost $20...
[01:22:37] <AndyRussG>	 We did actually buy them plenty of other trinkets without asking for payback, heh...
[01:22:45] <AndyRussG>	 And also books at Strand!
[01:23:07] <AndyRussG>	 Sadly the NY Public Library was closed...
[01:23:50] <AndyRussG>	 https://en.wikipedia.org/wiki/Plasma_globe
[01:24:38] <AndyRussG>	 Mari might be old enuf for one, infact!
[01:28:13] <grrrit-wm>	 (PS2) Ejegg: Render error forms with Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292512 (https://phabricator.wikimedia.org/T131995)
[01:31:35] <awight>	 oh yah Strand is great
[01:32:03] <awight>	 I have a friend who visited me years ago, when living in NYC, and he went there maybe 5 times during his short stay.
[01:32:17] <awight>	 He had hilarious, multiple boxes of books by the end
[01:32:26] <awight>	 we taped them up for enhanced luggageness
[01:38:56] <wikibugs>	 Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2351861 (awight) @AndyRussG was saying that you should be able to run the registerTest function from a plain <script> tag in the banner, without dealing with any of the legacy hook nonsense.  Please let...
[01:39:33] <grrrit-wm>	 (PS2) Ejegg: Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001)
[01:40:10] <grrrit-wm>	 (PS3) Ejegg: Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001)
[01:42:12] <grrrit-wm>	 (PS4) Ejegg: Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001)
[01:43:52] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001) (owner: Ejegg)
[01:47:27] <grrrit-wm>	 (PS5) Ejegg: Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001)
[02:55:11] <grrrit-wm>	 (PS1) Ejegg: WIP Mustache for legacy WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292519 (https://phabricator.wikimedia.org/T86248)
[02:56:38] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Mustache for legacy WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292519 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg)
[03:48:06] <cwd>	 ejegg: hope you're not actually still working (or awake for that matter) but i love the idea of starting by killing rapidhtml and getting everything on mustache!
[03:48:56] <ejegg>	 oops, forgot my away message
[03:49:12] <cwd>	 also, my bad on shoe horning ffname into world pay :P
[03:49:22] <ejegg>	 but yeah, it'll make a lot of other progress easier
[03:49:28] <cwd>	 totally
[03:49:47] <XenoRyet|afk>	 Heh, I'm not really here either, but +1 to the idea of killing rapidhtml
[03:49:48] <ejegg>	 anyway, actually offline! see ya tomorrow
[03:50:04] <cwd>	 see ya!
[12:59:57] <wikibugs>	 fundraising-tech-ops: build payments1005 with Debian Jessie, HHVM - https://phabricator.wikimedia.org/T136938#2352865 (Jgreen)
[13:14:53] <wikibugs>	 fundraising-tech-ops: build payments1005 with Debian Jessie, HHVM - https://phabricator.wikimedia.org/T136938#2352894 (Jgreen)
[13:14:55] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + PHP 5.5 - https://phabricator.wikimedia.org/T130130#2352893 (Jgreen)
[13:15:55] <wikibugs>	 fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2352865 (Jgreen)
[13:44:56] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2352952 (Jgreen) In terms of PCI, some of this hinges on whether we decide to stay SAQ A or change to SAQ A-EP, but in terms o...
[13:46:41] <wikibugs>	 fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2352968 (Jgreen) p:Triage>High
[14:24:28] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2142257 (cwdent) What if we cut our own branch every Monday, based on the branch that stabilized the previous week?  This woul...
[14:53:42] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2353104 (demon) >>! In T130658#2353040, @cwdent wrote: > What if we cut our own branch every Monday, based on the branch that...
[15:01:45] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2353128 (Jgreen) As part of this we should also think about how we stage/test, as we got partway there but never really worked...
[15:46:13] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Running the Donor Summary report it blocks us with an incorrect validation error - https://phabricator.wikimedia.org/T136893#2353313 (Eileenmcnaughton) @LeanneS oK to close?
[15:47:06] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Running the Donor Summary report it blocks us with an incorrect validation error - https://phabricator.wikimedia.org/T136893#2353315 (Eileenmcnaughton) I turns out the unintuitive answer it to make sure the country f...
[15:49:30] <grrrit-wm>	 (CR) Cdentinger: [C: 2] "Great!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292512 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg)
[15:51:58] <grrrit-wm>	 (Merged) jenkins-bot: Render error forms with Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292512 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg)
[16:02:56] <grrrit-wm>	 (PS1) Ejegg: WIP Mustache for Direct Debit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292579 (https://phabricator.wikimedia.org/T123002)
[16:03:03] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Use Mustache for legacy PayPal adapter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001) (owner: Ejegg)
[16:05:09] <ejegg>	 woohoo!
[16:05:13] <ejegg>	 momentum!
[16:05:26] <grrrit-wm>	 (Merged) jenkins-bot: Use Mustache for legacy PayPal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001) (owner: Ejegg)
[16:06:53] <grrrit-wm>	 (CR) Ejegg: Use Mustache for legacy PayPal adapter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292515 (https://phabricator.wikimedia.org/T123001) (owner: Ejegg)
[16:06:54] <cwd>	 yes!
[16:27:20] <grrrit-wm>	 (PS1) Ejegg: JS module fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292584
[16:27:47] <ejegg>	 was looking at BT form to try to mustachify, but it seems to have a busted dependency ^^^
[16:49:56] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + PHP 5.5 - https://phabricator.wikimedia.org/T130130#2353484 (Jgreen)
[16:49:58] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#2353485 (Jgreen)
[16:50:12] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#1098364 (Jgreen)
[16:50:14] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + PHP 5.5 - https://phabricator.wikimedia.org/T130130#2126677 (Jgreen)
[16:50:26] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + PHP 5.5 - https://phabricator.wikimedia.org/T130130#2126677 (Jgreen)
[16:50:28] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#1098364 (Jgreen)
[16:52:28] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Render rapidfail error forms with mustache - https://phabricator.wikimedia.org/T131995#2353524 (Ejegg) a:Ejegg
[16:52:39] <wikibugs>	 fundraising-tech-ops: review and build HHVM packages for fundraising use - https://phabricator.wikimedia.org/T136958#2353530 (Jgreen)
[16:52:55] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 2 others: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#2353543 (Ejegg) a:Ejegg
[16:55:03] <wikibugs>	 fundraising-tech-ops: review and build HHVM packages for fundraising use - https://phabricator.wikimedia.org/T136958#2353554 (Jgreen) Relevant for consideration:  https://wikitech.wikimedia.org/wiki/HHVM T133674 HHVM is leaking memory on the API appservers T101354 Create a whitelist of commands which HHVM ma...
[16:55:54] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2353562 (Jgreen)
[16:57:56] <wikibugs>	 fundraising-tech-ops: build fundraising civicrm (barium) replacement server on Debian Jessie, with HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136959#2353563 (Jgreen)
[17:00:22] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2353581 (Jgreen)
[17:00:24] <wikibugs>	 fundraising-tech-ops: build fundraising civicrm (barium) replacement server on Debian Jessie, with HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136959#2353580 (Jgreen)
[17:00:26] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#2353579 (Jgreen)
[17:01:15] <wikibugs>	 fundraising-tech-ops: review and build HHVM packages for fundraising use - https://phabricator.wikimedia.org/T136958#2353585 (Jgreen)
[17:01:30] <wikibugs>	 fundraising-tech-ops: review and build HHVM package(s) for fundraising use - https://phabricator.wikimedia.org/T136958#2353530 (Jgreen)
[17:02:22] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2126677 (Jgreen)
[17:02:26] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, HHVM: Run Payments wiki on HHVM - https://phabricator.wikimedia.org/T91899#2353589 (Jgreen)
[17:02:44] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2353593 (Jgreen)
[17:02:46] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2353592 (Jgreen)
[17:05:47] <wikibugs>	 Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adjustable load balancer to direct small samples of donors to staging payments - https://phabricator.wikimedia.org/T97745#2353601 (Jgreen) a:Jgreen
[17:11:18] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#2353619 (Jgreen)
[17:13:34] <grrrit-wm>	 (CR) Cdentinger: [C: 2] JS module fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292584 (owner: Ejegg)
[17:14:27] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#2353648 (Jgreen)
[17:14:57] <wikibugs>	 Fundraising-Backlog, FR-Smashpig: Add SmashPig config to settings repo - https://phabricator.wikimedia.org/T129706#2353654 (Jgreen)
[17:14:59] <grrrit-wm>	 (Merged) jenkins-bot: JS module fixes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292584 (owner: Ejegg)
[17:15:17] <wikibugs>	 Fundraising-Backlog, FR-Smashpig: Add SmashPig config to settings repo - https://phabricator.wikimedia.org/T129706#2113434 (Jgreen) Open>stalled
[17:15:25] <wikibugs>	 Fundraising-Backlog, FR-Smashpig: Add SmashPig config to settings repo - https://phabricator.wikimedia.org/T129706#2113434 (Jgreen) p:Normal>Low
[17:15:53] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1572549 (Jgreen) Open>stalled
[17:16:01] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#1572549 (Jgreen) p:Normal>Low
[17:19:59] <wikibugs>	 Fundraising Tech Backlog: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2353665 (Jgreen) Open>Resolved a:Jgreen I think this is now under control after some monitoring tweaks, so closing. Please reopen & comment if I missed...
[17:30:12] <grrrit-wm>	 (PS1) Ejegg: Handle error-default form in Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292591 (https://phabricator.wikimedia.org/T131995)
[17:32:38] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353692 (Jgreen)
[17:32:51] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353704 (Jgreen) p:Triage>Normal a:Jgreen
[17:33:00] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2353706 (awight)
[17:34:20] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: Move all fundraising component config into Puppet - https://phabricator.wikimedia.org/T110224#2353727 (awight) stalled>Resolved a:awight The part I still care about was covered by localsettings.git wo...
[17:34:29] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353692 (Jgreen)
[17:35:03] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: All fundraising configuration should be deployed from either puppet or git. - https://phabricator.wikimedia.org/T110224#2353732 (awight)
[17:35:23] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, Technical-Debt: All fundraising configuration should be deployed from either puppet templates or a private git repo - https://phabricator.wikimedia.org/T110224#1572549 (awight)
[17:36:20] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353735 (Jgreen)
[17:36:22] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2353736 (Jgreen)
[17:37:22] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353692 (Jgreen)
[17:37:24] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2142257 (Jgreen)
[17:38:15] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops, Release-Engineering-Team: Spike: decide how payments-wiki deployment process should relate to the core MW deployment process - https://phabricator.wikimedia.org/T130658#2142257 (Jgreen)
[17:38:19] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Internal Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2353745 (awight)
[17:38:21] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, MediaWiki-extensions-DonationInterface, Epic: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2353746 (awight)
[17:38:24] <wikibugs>	 Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, and 3 others: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2353743 (awight) Resolved>Open I haven't gotten to the...
[17:41:20] <grrrit-wm>	 (PS1) Ejegg: Remove FormDir and filename for Mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292593 (https://phabricator.wikimedia.org/T86248)
[17:42:39] <wikibugs>	 Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adjustable load balancer to direct small samples of donors to staging payments - https://phabricator.wikimedia.org/T97745#2353754 (Jgreen) Open>stalled p:Triage>Low
[17:43:27] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Remove FormDir and filename for Mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292593 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg)
[17:44:29] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353758 (Jgreen)
[17:44:31] <wikibugs>	 Fundraising Tech Backlog, Tracking: Fundraising Tech Staging (tracking) - https://phabricator.wikimedia.org/T88657#2353757 (Jgreen)
[17:47:16] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Spike: How to configure a staging server for payments? - https://phabricator.wikimedia.org/T112857#2353761 (Jgreen)
[17:47:17] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353759 (Jgreen)
[17:47:20] <wikibugs>	 Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adjustable load balancer to direct small samples of donors to staging payments - https://phabricator.wikimedia.org/T97745#2353763 (Jgreen)
[17:47:52] <grrrit-wm>	 (PS2) Ejegg: Remove FormDir and filename for Mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292593 (https://phabricator.wikimedia.org/T86248)
[17:47:54] <grrrit-wm>	 (PS1) Ejegg: FIXMEs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292595
[17:48:26] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353692 (Jgreen)
[17:48:28] <wikibugs>	 Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adjustable load balancer to direct small samples of donors to staging payments - https://phabricator.wikimedia.org/T97745#1251276 (Jgreen)
[17:48:30] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Spike: How to configure a staging server for payments? - https://phabricator.wikimedia.org/T112857#1648333 (Jgreen) Open>stalled
[17:48:34] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Spike: How to configure a staging server for payments? - https://phabricator.wikimedia.org/T112857#1648333 (Jgreen) p:High>Low
[17:49:14] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353769 (Jgreen)
[17:49:37] <wikibugs>	 fundraising-tech-ops: build fundraising civicrm (barium) replacement server on Debian Jessie, with HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136959#2353770 (Jgreen) p:Triage>High
[17:49:52] <wikibugs>	 fundraising-tech-ops: review and build HHVM package(s) for fundraising use - https://phabricator.wikimedia.org/T136958#2353771 (Jgreen) p:Triage>High
[17:59:41] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2353795 (Jgreen) There is a fairly long chain of dependencies to switch to HHVM, and recent issues in produ...
[18:00:06] <wikibugs>	 fundraising-tech-ops: review and build HHVM package(s) for fundraising use - https://phabricator.wikimedia.org/T136958#2353797 (Jgreen) p:High>Low
[18:00:37] <wikibugs>	 fundraising-tech-ops: build fundraising civicrm (barium) replacement server on Debian Jessie, with HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136959#2353798 (Jgreen)
[18:00:40] <wikibugs>	 fundraising-tech-ops: review and build HHVM package(s) for fundraising use - https://phabricator.wikimedia.org/T136958#2353530 (Jgreen)
[18:01:27] <wikibugs>	 fundraising-tech-ops: review and build HHVM package(s) for fundraising use - https://phabricator.wikimedia.org/T136958#2353530 (Jgreen)
[18:01:29] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#2353802 (Jgreen)
[18:07:48] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#2353824 (Jgreen)
[18:07:50] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2353825 (Jgreen)
[18:13:35] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912#2353842 (Jgreen)
[18:14:10] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353844 (Jgreen) p:Normal>High
[18:19:46] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: evaluate scap3 as a possible replacement for FrDeploy tools - https://phabricator.wikimedia.org/T136966#2353854 (Jgreen)
[18:21:17] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#2353877 (Jgreen)
[18:21:19] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: evaluate scap3 as a possible replacement for FrDeploy tools - https://phabricator.wikimedia.org/T136966#2353878 (Jgreen)
[18:21:33] <grrrit-wm>	 (PS1) Ejegg: Test setValidationAction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292599
[18:21:46] <wikibugs>	 Fundraising Tech Backlog, fundraising-tech-ops: evaluate scap3 as a possible replacement for FrDeploy tools - https://phabricator.wikimedia.org/T136966#2353854 (Jgreen) https://www.mediawiki.org/wiki/Fundraising_tech/Chat/Scap3
[18:36:07] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2353909 (awight) That would be great!  The only additional benefit we might get from HHVM would be to cut P...
[18:38:53] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Performance: Run CRM on HHVM - https://phabricator.wikimedia.org/T91896#2353912 (awight) Open>stalled Pausing this task until we find out more about CRM on HHVM vs PHP 5.6 or 5.3, and c...
[18:47:46] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, Unplanned-Sprint-Work: Isreal and Franc 1hour tests processed in USD - https://phabricator.wikimedia.org/T136967#2353926 (DStrine)
[18:54:10] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, Unplanned-Sprint-Work: Israel and France 1hour tests processed in USD - https://phabricator.wikimedia.org/T136967#2353948 (Neil_P._Quinn_WMF)
[18:57:30] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Render rapidfail error forms with mustache - https://phabricator.wikimedia.org/T131995#2353961 (DStrine)
[19:09:40] <grrrit-wm>	 (PS1) Ejegg: Extra assertion for pre-process test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292607
[19:16:50] <wikibugs>	 Fundraising-Backlog: Spike: investigate new integration for ingenico to prevent order ID issues - https://phabricator.wikimedia.org/T136976#2354140 (DStrine)
[19:17:14] <wikibugs>	 Fundraising-Backlog, FR-Ingenico: Spike: investigate new integration for ingenico to prevent order ID issues - https://phabricator.wikimedia.org/T136976#2354140 (DStrine)
[19:34:22] <grrrit-wm>	 (CR) Awight: [C: 2] "Good thing to check!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292599 (owner: Ejegg)
[19:36:02] <grrrit-wm>	 (Merged) jenkins-bot: Test setValidationAction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292599 (owner: Ejegg)
[19:45:58] <grrrit-wm>	 (CR) XenoRyet: [C: 2] "Looks good and works as advertised." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/283112 (https://phabricator.wikimedia.org/T88460) (owner: Awight)
[19:46:33] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Import errors are logged and recoverable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/283112 (https://phabricator.wikimedia.org/T88460) (owner: Awight)
[20:23:25] <dstrine>	 ejegg:  I think all the adyen countries were charging in USD. Jessica also noted that a Japanese tester was charged $150 instead of 150 yen. MBeat was going to refund that.
[20:24:04] <dstrine>	 XenoRyet:  made a good point... it's probably good that the test only worked for 8 minutes
[20:24:11] <ejegg>	 yeah
[20:25:09] <ejegg>	 !log updated GatewayReady hook on paymentswiki
[20:25:14] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[20:28:44] <grrrit-wm>	 (PS1) Ejegg: Clear out expensive js landmine [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292628
[20:28:57] <ejegg>	 awight / cwd / XenoRyet ^^^^ d'oh!
[20:29:28] <ejegg>	 I shoulda given that js more scrutiny when I found the dumb 'uselang' thing in there
[20:31:38] <grrrit-wm>	 (CR) Awight: [C: 2] "https://pixabay.com/static/uploads/photo/2015/09/01/18/14/child-917367_960_720.jpg" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292628 (owner: Ejegg)
[20:32:24] <ejegg>	 so, i'mma cherry-pick that one to deploy...
[20:32:41] <awight>	 Good find
[20:32:51] <ejegg>	 leaving it up like this seems more dangerous than a friday deploy of a js file
[20:33:06] <awight>	 yah
[20:33:23] <grrrit-wm>	 (Merged) jenkins-bot: Clear out expensive js landmine [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292628 (owner: Ejegg)
[20:33:38] <ejegg>	 that's the hole in our code review... nobody was changing that, so nobody looked at it
[20:34:20] <grrrit-wm>	 (PS1) Ejegg: Clear out expensive js landmine [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292629
[20:34:49] <grrrit-wm>	 (CR) Ejegg: [C: 2] Clear out expensive js landmine [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292629 (owner: Ejegg)
[20:34:54] <awight>	 We should be able to annotate it all, and spray hazmat orange at the stinky parts
[20:35:03] <grrrit-wm>	 (CR) Ejegg: [V: 2] Clear out expensive js landmine [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292629 (owner: Ejegg)
[20:35:58] <cwd>	 oh geez
[20:36:40] <cwd>	 i'm sure that was a safe assumption until recently
[20:38:45] <grrrit-wm>	 (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292631
[20:39:02] <grrrit-wm>	 (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292631 (owner: Ejegg)
[20:44:59] <grrrit-wm>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292631 (owner: Ejegg)
[20:47:12] <ejegg>	 !log updated payments-wiki de86eadcd98922ee4207a0c46112585f3ba5c48d to 28b98ec254b2a15c8df61c568b62f221b328222f
[20:47:17] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[20:56:26] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, Unplanned-Sprint-Work: Israel and France 1hour tests processed in USD - https://phabricator.wikimedia.org/T136967#2354404 (Pcoombe) Is checking transactions are in the right currency something we could/should have unit tests for?
[21:04:42] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, Unplanned-Sprint-Work: Israel and France 1hour tests processed in USD - https://phabricator.wikimedia.org/T136967#2353926 (Ejegg) For this one, we would have needed browser tests.  We do have unit tests that simulate a currency code coming in on t...
[21:05:05] <grrrit-wm>	 (PS1) Awight: Add some logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292635
[21:05:09] <wikibugs>	 Fundraising Sprint Killing Time, Fundraising-Backlog, Unplanned-Sprint-Work: Israel and France 1hour tests processed in USD - https://phabricator.wikimedia.org/T136967#2354413 (Ejegg) p:Triage>Unbreak! a:Ejegg
[21:10:13] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Can't hurt, might help!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292635 (owner: Awight)
[21:12:32] <grrrit-wm>	 (Merged) jenkins-bot: Add some logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292635 (owner: Awight)
[21:12:50] <awight>	 ejegg: I'll go ahead and deploy that, eh?
[21:13:41] <ejegg>	 thanks!
[21:15:06] <grrrit-wm>	 (PS1) Awight: Add some logging [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292659
[21:15:18] <grrrit-wm>	 (CR) Awight: [C: 2] Add some logging [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292659 (owner: Awight)
[21:15:43] <grrrit-wm>	 (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292664
[21:15:55] <grrrit-wm>	 (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292664 (owner: Awight)
[21:18:14] * awight twitches finger above the "Submit" button
[21:18:29] <awight>	 Go ahead, Zuul.  Make my day.
[21:18:56] <grrrit-wm>	 (Merged) jenkins-bot: Add some logging [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/292659 (owner: Awight)
[21:19:56] <awight>	 ejegg: Maybe I should have added a random number or something so we could distinguish between repeated log lines and repeated log calls
[21:20:14] <ejegg>	 I think it's freaking SpecialPageFactory...
[21:20:39] <ejegg>	 we need to move all the heavy lifting out of the GatewayPage constructor
[21:21:05] <awight>	 ^ that regardless...
[21:22:00] <ejegg>	 yeah, that would have been useful
[21:22:51] <awight>	 On another topic, I've been thinking about how to encode PP EC transactions, and I'm leaning towards gateway=paypal account=default payment_method=paypal payment_submethod=express_checkout
[21:23:29] <awight>	 hrm.  nvm I need to think about that more
[21:24:25] <awight>	 I'm not sure we can easily get submethod from the CRM side, which would make recurring payments and cancellation annoying.
[21:25:25] <grrrit-wm>	 (Merged) jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/292664 (owner: Awight)
[21:26:30] <ejegg>	 aha, it's first constructed from this call: https://github.com/wikimedia/mediawiki/blob/REL1_25/includes/MediaWiki.php#L232
[21:27:40] <ejegg>	 then this call to SpecialPageFactory::executePath calls getPage again : https://github.com/wikimedia/mediawiki/blob/REL1_25/includes/MediaWiki.php#L263
[21:27:54] <awight>	 !log update paymentswiki from 28b98ec254b2a15c8df61c568b62f221b328222f to 3df3329f75fdbc679baf37bfd3955880091b3ae1
[21:27:58] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[21:28:33] <awight>	 why oh why
[21:30:59] <awight>	 ejegg: Confirmed that logging shows two adapters constructed per request
[21:31:06] <awight>	 Nice guess!
[21:31:21] <ejegg>	 So that bandaid should hold for the weekend
[21:37:32] <grrrit-wm>	 (PS1) Awight: [WIP] Move GatewayPage fun into the execute() method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292743
[21:39:22] <awight>	 ejegg: It does seem like we're fine, but if you want to beat on ^ it seems to work locally
[21:39:29] <awight>	 ...seemingly...
[21:40:30] <grrrit-wm>	 (PS2) Awight: Move GatewayPage fun into the execute() method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292743
[21:41:05] <ejegg>	 awight: yep, seems like there's no reason to keep that crap in the constructor.
[21:41:54] <awight>	 constructors: unsafe at any speed
[21:43:16] <ejegg>	 Gotta relocate, back in a bit... Thanks for participating in another Fire drill Friday!
[21:44:51] * awight stays tuned
[21:51:07] <awight>	 cwd: Have any opinion on https://gerrit.wikimedia.org/r/292743 ?
[21:51:27] <awight>	 No rush on that one
[21:52:27] <cwd>	 lessee...
[21:54:34] <cwd>	 awight: that would prevent making an adaptor on the page constructor?
[21:54:59] <grrrit-wm>	 (PS3) Awight: Move GatewayPage fun into the execute() method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292743
[21:55:03] <awight>	 yep
[22:17:17] <grrrit-wm>	 (PS1) Ejegg: Use 'noform' error when appropriate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292757
[22:29:51] <grrrit-wm>	 (CR) Ejegg: [C: 1] "All seems right and proper! We can even get rid of that silly $this->isFailed variable now." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292743 (owner: Awight)
[22:31:28] <ejegg>	 XenoRyet: if you wanna look at a couple more mustache-related things, there's https://gerrit.wikimedia.org/r/292591 , https://gerrit.wikimedia.org/r/292593 , https://gerrit.wikimedia.org/r/292595 , and https://gerrit.wikimedia.org/r/292757
[22:31:44] <XenoRyet>	 Yea, I'll dig in.
[22:31:54] <ejegg>	 Thanks!  All pretty minor
[22:37:11] <cwd>	 ejegg: re: that one above...looks good to me as well, but trying to think of cases where execute() might not be called in time for something that checks for any of the values it now sets
[22:37:21] <cwd>	 is that a legit concern from your perspective?
[22:37:49] <ejegg>	 cwd I'm looking through all the subclasses, and I'm not seeing them override any other special page methods
[22:38:04] <ejegg>	 I think everything we've written ends up being called from execute
[22:38:39] <ejegg>	 updated vagrant test links: https://gerrit.wikimedia.org/r/292034
[23:18:58] <ejegg>	 pretty sure awight's patch is the right way to go
[23:19:12] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Examined all subclasses and confirmed that none are overriding any special page methods. All code in them is ultimately called by execute(" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292743 (owner: Awight)
[23:20:42] <grrrit-wm>	 (Merged) jenkins-bot: Move GatewayPage fun into the execute() method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292743 (owner: Awight)
[23:32:28] <grrrit-wm>	 (CR) XenoRyet: [C: 2] Handle error-default form in Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292591 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg)
[23:33:47] <grrrit-wm>	 (Merged) jenkins-bot: Handle error-default form in Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292591 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg)
[23:34:28] <grrrit-wm>	 (PS1) Ejegg: More cleanup around GatewayPage constructor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292766
[23:34:51] <grrrit-wm>	 (Abandoned) Ejegg: Don't register client-side var hook when failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286490 (owner: Ejegg)
[23:46:18] <grrrit-wm>	 (PS2) Ejegg: More cleanup around GatewayPage constructor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292766