[00:02:52] (PS10) Ejegg: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) [00:03:46] (CR) Ejegg: Consume pending queue to database (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [00:09:30] (PS6) Ejegg: Disallow setting contribution tracking ID from request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T135745) [00:35:05] !log updated settings on payments-wiki [00:35:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:41:30] that ct_id fix oughtta be ready for some testing / CR awight : https://gerrit.wikimedia.org/r/289731 [00:43:36] ejegg: Great! I'm trying to get the pending queue consumer vagrantized ATM, so ping me again tomorrow if I forget... [00:43:55] oh cool! [00:44:32] lack of other popAtomic backends holding you back? [00:44:35] Just installing the schema and stuff... not a cron job [00:44:38] hehe nah [01:11:22] ejegg: oh yeah, now I get it. the queue consumer is blocked by https://gerrit.wikimedia.org/r/#/c/288037 [01:12:38] hanging my hat for the evening. See you! [01:12:44] see ya! [01:12:54] ehh, me too... [01:13:36] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Write pending queue consumer and schema - https://phabricator.wikimedia.org/T133197#2359902 (awight) Should this be linked (and ta... [14:55:07] Fundraising Sprint Killing Time, Fundraising-Backlog: Cut fundraising/REL1_26 branch - https://phabricator.wikimedia.org/T137213#2361053 (cwdent) [16:19:32] cwd: ejegg AndyRussG|owt did anyone see Katie's email on CN failures? [16:19:58] dstrine: looking now [16:20:12] i can't remember what this was about... [16:20:59] phew, just selenium tests, not live site! [16:21:19] Yeah, I don't think I ever knew what was causing those... [16:24:28] cwd I was thinking of deploying the GatewayPage constructor fix and the Mustache paypal / error forms [16:25:13] cool, i am around to keep an eye [16:26:30] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293120 [16:26:45] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293120 (owner: Ejegg) [16:29:06] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293122 [16:29:29] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293122 (owner: Ejegg) [16:35:09] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293122 (owner: Ejegg) [16:36:33] ejegg: well that's good news... could you reply to Katie on that thread? [16:37:31] when dstrine is Guest12364, i picture him wearing one of those glasses/mustache combos [16:37:34] well, K4 knows it's not prod, but releng does get annoyed when ppl leave broken tests flapping around [16:38:49] cwd: lol I think I have a few of those lying around [16:39:32] nothing to see here, just an invited guest [16:39:52] ejegg: would Andy or Adam know more? [16:42:37] dstirne: oh looking [16:42:38] I know Andy's fixed them before [16:43:06] thanks AndyRussG [16:43:41] dstirne: yw, thank u too! [16:43:48] ejegg: in other news, PPena asked a question on the email "1-hour test for adyen countries this thusrday" [16:44:35] heh, thanks for pointing that out - I'll reply in a sec! [16:47:04] thanks ejegg! [16:57:25] ok, i'm going to deploy DI and keep an eye on it for a bit, so I can roll back before test if necessary [16:58:02] onward and upward [17:04:05] !log updated payments-wiki from 3df3329f75fdbc679baf37bfd3955880091b3ae1 to 413bd3ea92ac570c081532c71891c31391194984 [17:04:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:05:57] !log rolled back payments-wiki to 3df3329f75fdbc679baf37bfd3955880091b3ae1 [17:06:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:06:29] yikes, sending cents to paypal instead of dollars. Let's see if anybody else hit that... [17:07:31] whoops! [17:07:42] because of mustache you think? [17:07:48] whew, looks like I was the only one to get it [17:07:57] cwd must have something to do with it... [17:09:01] wtf, it's totally got 'AmountInCents' in the transformers config [17:09:07] that's very much not right [17:09:42] also StreetAddress? Odd [17:13:38] (PS1) Ejegg: Stop doing bad staging for Paypal Legacy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293126 [17:13:58] cwd really curious how that wasn't biting us in the ass before [17:16:13] must be some template inconsistency? [17:16:59] (CR) Cdentinger: [C: 2] Stop doing bad staging for Paypal Legacy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293126 (owner: Ejegg) [17:18:24] (Merged) jenkins-bot: Stop doing bad staging for Paypal Legacy [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293126 (owner: Ejegg) [17:19:00] well, the rest looked good. I'll see if I can get this patch up in the next 10 min [17:19:43] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293127 [17:21:54] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293127 (owner: Ejegg) [17:22:34] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293128 [17:22:51] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293128 (owner: Ejegg) [17:28:23] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293128 (owner: Ejegg) [17:30:36] !log updated payments-wiki from 3df3329f75fdbc679baf37bfd3955880091b3ae1 to 28e10141454ef53085aed4c6619a34d3a4b43c58 [17:30:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:31:10] ok, that looks better! [17:31:26] Total: $5.00USD [17:31:38] error log is quiet [17:31:40] yah, much more reasonable [17:39:39] Fundraising-Backlog: Investigate forms in emails prefilling payments wiki fields - https://phabricator.wikimedia.org/T137233#2361661 (CCogdill_WMF) [17:41:57] (CR) Ejegg: "Ah, let's not put much logic in this. Let's either make the sql scripts idempotent and run 'em all each time, or keep a schema version ta" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293055 (owner: Awight) [17:52:27] awight: I'm going to be watching Adyen test logs in 10 min, so I'll be late to the deploy meeting [17:52:40] jessicarobell the-wub MBeat ejegg all ready to go for the 11am? :) [17:52:50] for sure! [17:53:18] PPena: yep! [17:54:10] PPena: I'm ready. will enable the campaigns [17:55:07] Great! Thanks all! [17:55:35] I will be in a meeting, but feel free to ping me here [17:56:04] okay, we're all set to go at 11 [17:56:21] (unrelated to test) hmm, getting GeoIP=:::::v6 in my donatewiki cookie when I go directly there [17:56:52] I thought we forced a request to a v4 only host [17:57:28] but I don't see that [18:00:45] okay PPena MBeat ejegg, banners are up [18:01:06] Thanks the-wub [18:05:13] Jeff_Green: ping... [18:05:20] We're in the config hangout [18:05:22] ya, logging in [18:05:25] hey good timing! [18:05:59] it takes me literally 5 minutes to log in once I get started [18:06:11] find phone, find gmail password, flail, etc. [18:10:31] well that's weird. the Israel banner isn't showing for me: https://he.wikipedia.org/?banner=B1516_0607_heIL_dsk_p2_sm_pym_adyen&force=1&country=IL [18:11:03] huh, me neither [18:11:10] taking a look at the requests.. [18:11:34] it IS hitting BannerLoader [18:11:53] err, not much for html in that though [18:12:08] "bannerHtml":"\u003CCentralnotice-template-B1516_0607_heIL_dsk_p2_sm_pym_adyen [18:12:11] \u003E" [18:12:18] ejegg: I see an empty element in the page [18:12:46] are any other banners working for you at the moment? [18:13:16] ejegg: made a dummy edit to the banner, and it seems to be working now. the code was definitely there before - it was just a clone from yesterday's [18:13:28] the french ones seem to have been working fine [18:13:52] very odd [18:14:08] ooh, i'm seeing a misaligned thing coving text [18:14:12] *covering [18:14:19] one sec, i'll do a screenshot [18:15:58] the-wub: https://phabricator.wikimedia.org/M175 [18:16:21] oh, that's in FF 46.0.1 [18:16:28] thx [18:16:52] Fundraising-Backlog, FR-Adyen, FR-WMF-Audit: Adyen refunds: look at reconciliation / auditing to make sure they get to Civi - https://phabricator.wikimedia.org/T135641#2361774 (DStrine) p:Triage>High [18:16:53] ejegg the-wub i dont see much going on at Adyen's console... [18:17:37] seeing a few hits in the logs, not a ton [18:17:57] PPena ejegg : I see donations from France https://docs.google.com/spreadsheets/d/17arGLTPupnrCmo7O0He38js-gmOoF3OY53sOwiAbAp0/edit#gid=1108147582 [18:18:18] nothing from Israel yet though. not even clicks [18:19:09] i only see 7 trnxs fot today [18:19:22] maybe the updater is slow? [18:20:04] yeah I think there is a bit of a delay [18:20:17] PPena: oh right, their console has a bunch of lag [18:20:18] k will wait :) [18:26:01] okay ejegg that triangle positioning bug should be fixed now. thanks for the heads up [18:26:08] ty [18:29:17] (PS1) Ejegg: Quit looking for duplicate queue messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293138 [18:29:37] the-wub ejegg still seeing WAAAY to little... is it due to time? Maybe we are not at a 100%? [18:29:45] ejegg do the logs look ok? [18:30:07] error logs are quiet [18:30:13] strange.... [18:30:15] but they do look a bit slow [18:30:52] Maybe that BannerLoader bug the-wub saw earlier is affecting more people? [18:31:37] PPena: allocation looks to be at 100%. ingenico and paypal traffic seem low too though. ejegg could be right that it's a banner loading bug [18:33:02] config talk going a bit over [18:34:20] Fundraising Sprint Killing Time, Fundraising-Backlog: Cut fundraising/REL1_26 branch - https://phabricator.wikimedia.org/T137213#2361819 (Paladox) @DStrine shoulden we go with REL1_27 instead. Since REL1_27 is a lts release and due for release this month I think. [18:35:57] Jeff_Green: are you free for a chat? [18:36:10] yep. just flailing at google [18:38:41] some good news: paypal conversion looks much healthier today [18:39:10] Fundraising-Backlog: introduction to fr-tech for new analyst (Brent) - https://phabricator.wikimedia.org/T135392#2361828 (DStrine) a:Jgreen [18:39:43] Fundraising-Backlog, fundraising-tech-ops: introduction to fr-tech for new analyst (Brent) - https://phabricator.wikimedia.org/T135392#2297258 (DStrine) [18:40:33] the-wub: awesome! We did just deploy a tweak to the interstitial form so it uses the new renderer, but in most cases donors don't see that [18:40:56] Fundraising-Backlog, fundraising-tech-ops: introduction to fr-tech for new analyst (Brent) - https://phabricator.wikimedia.org/T135392#2361849 (awight) [18:40:58] Fundraising-Backlog, fundraising-tech-ops: access request for new fundraising analyst (Brent) - https://phabricator.wikimedia.org/T135392#2361850 (Jgreen) p:Triage>High [18:41:31] Fundraising-Backlog, fundraising-tech-ops, Epic: [Epic] Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2361854 (awight) [18:43:03] Fundraising Sprint Killing Time, Fundraising-Backlog: Cut fundraising/REL1_26 branch - https://phabricator.wikimedia.org/T137213#2361860 (cwdent) @paladox unfortunately there are a few things blocking us from moving to 27 such as PHP version incompat and some code changes. It's on the radar but still a... [18:46:35] Fundraising-Backlog: Produce failure signals from the application which indicate bad behavior - https://phabricator.wikimedia.org/T137239#2361876 (awight) [18:46:53] hrmph, not sure how to push this to a branch on gerrit: https://gerrit.wikimedia.org/r/#/c/293141/ [18:47:03] gotta run for a bit [18:47:59] Fundraising Sprint Killing Time, Fundraising-Backlog: Cut fundraising/REL1_26 branch - https://phabricator.wikimedia.org/T137213#2361897 (Paladox) Oh yes sorry forgot about the php change. [18:49:52] Fundraising-Backlog: Produce failure signals from the application which indicate bad behavior - https://phabricator.wikimedia.org/T137239#2361902 (awight) [18:49:54] Fundraising-Backlog, fundraising-tech-ops: Allow fr-tech to block IPs - https://phabricator.wikimedia.org/T136111#2361901 (awight) [18:50:35] Fundraising-Backlog, fundraising-tech-ops: Allow fr-tech to block IPs - https://phabricator.wikimedia.org/T136111#2323611 (DStrine) Per @Jgreen this should be mostly handled by mob security and other systems to detect fraud. [18:50:52] Fundraising-Backlog, fundraising-tech-ops: Allow fr-tech to block IPs - https://phabricator.wikimedia.org/T136111#2361912 (DStrine) Open>declined [18:51:11] Fundraising-Backlog: Produce failure signals from the application which indicate bad behavior - https://phabricator.wikimedia.org/T137239#2361876 (awight) [18:53:23] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2361917 (DStrine) Open>Resolved [18:53:32] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2258250 (DStrine) Resolved>Open [18:54:28] Fundraising Sprint Jabberwock Slaying, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Find a way to backup triggers - https://phabricator.wikimedia.org/T134212#2361923 (awight) Open>Resolved Looks like we have a good plan. We use the triggers from source code, [18:56:52] Fundraising-Backlog, fundraising-tech-ops: Share Fundraising disaster protocol with all of ops - https://phabricator.wikimedia.org/T121941#2361930 (DStrine) a:Jgreen [18:57:07] hehe I heard just enuf: that's all folks [19:01:05] PPena MBeat ejegg : France and Israel tests are over. will update the results and send them round in a bit [19:01:19] thanks, the-wub [19:01:41] (PS1) Ejegg: Log an error when banner translation retrieval fails [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293147 [19:01:46] thanks the-wub . [19:02:09] ^^^ should at least log when the BannerLoader can't get the html from the translation system [19:05:01] ejegg: do we think that's what the problem was today? [19:05:48] that's the only thing I can think of that would have given us back the banner key wrapped in angle brackets [19:07:01] cwd|afk: re branch, the easiest fix is to edit the .gitreview file's defaultbranch. [19:07:10] okay back in two hours... [19:08:51] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup payments1005-8 - https://phabricator.wikimedia.org/T136881#2361942 (Cmjohnson) payments1005-8 are racked, racktables updated, DNS completed and idrac setup. Payments1005 is currently connected to pfw1- ge-2/0/11. I do not have access to t... [19:09:30] (PS2) Ejegg: Log an error when banner translation retrieval fails [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293147 [19:10:03] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2361957 (Cmjohnson) frdb1001 is racked, dns updated, racktables completed, ilo setup. All that is needed is an available port. [19:10:05] AndyRussG: ^^ [19:10:53] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup new fundraising queue servers - https://phabricator.wikimedia.org/T136882#2361958 (Cmjohnson) frqueue1001/2 are racked, racktables updated, DNS completed and idrac setup. frqueue1001 is currently connected to pfw2- ge-2/0/11. I do not hav... [19:38:54] ejegg: the translation patch? [19:39:04] AndyRussG: yeah [19:39:13] K cool, I'll check it out [19:39:14] have you ever seen that happen before? [19:51:12] (PS1) Ejegg: Show Adyen iframe regardless of risk score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293152 [19:57:03] (PS2) Ejegg: Show Adyen iframe regardless of risk score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293152 (https://phabricator.wikimedia.org/T137243) [20:04:22] Guest11659: cwd: ejegg: XenoRyet|afk: I have to miss the beginning of grooming meeting for an unforseen family situation.... [20:05:23] sorry, room snafu, just got set up outdoors! [20:08:15] Fundraising Sprint Killing Time, Fundraising-Backlog: Cut fundraising/REL1_26 branch - https://phabricator.wikimedia.org/T137213#2362117 (cwdent) I tried to push this branch up but got: ! [remote rejected] HEAD -> refs/publish/fundraising/REL1_26 (branch fundraising/REL1_26 not found) @demon could... [20:08:46] AndyRussG: you free for a meeting? [20:10:35] AndyRussG: sorry that was me [20:10:40] are you free? [20:23:44] Fundraising-Backlog, fundraising-tech-ops: access request for new fundraising analyst (Brent) - https://phabricator.wikimedia.org/T135392#2362158 (Jgreen) Please add Brent's the full name and put his contact info on officewiki staff contacts or collabwiki fundraising contacts, and I can follow up with hi... [20:23:48] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Special:LoadBanners should scream if translation fails - https://phabricator.wikimedia.org/T137247#2362159 (Ejegg) [20:24:00] Fundraising-Backlog, fundraising-tech-ops: access request for new fundraising analyst (Brent) - https://phabricator.wikimedia.org/T135392#2362171 (Jgreen) p:High>Normal [20:29:17] Fundraising Sprint Killing Time, Fundraising-Backlog: Cut fundraising/REL1_26 branch - https://phabricator.wikimedia.org/T137213#2362187 (demon) [[ https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core,branches | You should be able to create a branch here ]]. [20:30:03] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Remove "language" parameter handling from DonationInterface - https://phabricator.wikimedia.org/T137129#2362192 (DStrine) p:Triage>Low [20:32:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Undo WmfException::isNoEmail hack - https://phabricator.wikimedia.org/T136784#2347810 (DStrine) p:Triage>Normal [20:33:56] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor: Sort out transaction_option vs getData* vs getTransactionSpecificValue vs accountInfo vs account_config - https://phabricator.wikimedia.org/T137164#2359522 (Ejegg) Also see T130154 [20:35:38] (PS1) Cdentinger: Create fundraising/REL1_26 branch [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 [20:40:13] Fundraising-Backlog: Investigate forms in emails prefilling payments wiki fields - https://phabricator.wikimedia.org/T137233#2361661 (Ejegg) It's possible right now to send in fname=Blah&lname=Blah&email=foo@bar.com parameters on the query string and have them pre-filled in our payments form. Not sure about... [20:43:53] Fundraising-Backlog: Investigate forms in emails prefilling payments wiki fields - https://phabricator.wikimedia.org/T137233#2362259 (CCogdill_WMF) Oh that's awesome, I didn't know! Thanks, Elliott :) @Dstrine, is this something tech should look at more from a security perspective, or should I just go to le... [20:48:15] Fundraising-Backlog: Investigate forms in emails prefilling payments wiki fields - https://phabricator.wikimedia.org/T137233#2361661 (cwdent) One thought I have is that the email address parameter will probably make modsecurity shout. [20:49:43] Fundraising Sprint Killing Time, Fundraising-Backlog: Cut fundraising/REL1_26 branch - https://phabricator.wikimedia.org/T137213#2362284 (cwdent) @demon thanks! TIL [20:52:23] Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Special:LoadBanners should scream if translation fails - https://phabricator.wikimedia.org/T137247#2362159 (Ejegg) a:Ejegg [20:53:54] ejegg: the comment with the command 2 run on production is here: https://phabricator.wikimedia.org/T132374#2229057 [20:53:56] thx!! [20:57:05] AndyRussG: cool, let's see if I remember how to get on those machine [20:59:02] hmm, long-running cmd, maybe I'll head home to do that on wired net and wall current [20:59:22] tmux to the rescue [20:59:32] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2362302 (Ejegg) [20:59:34] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2362303 (Ejegg) [20:59:36] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#2362304 (Ejegg) [20:59:38] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 2 others: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#2362301 (Ejegg) Open>Resolved [21:01:25] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#964453 (Ejegg) [21:01:27] Fundraising Sprint Killing Time, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Render rapidfail error forms with mustache - https://phabricator.wikimedia.org/T131995#2362309 (Ejegg) Open>Resolved [21:01:29] Fundraising Sprint Killing Time, Fundraising-Backlog, Unplanned-Sprint-Work: Israel and France 1hour tests processed in USD - https://phabricator.wikimedia.org/T136967#2362311 (Ejegg) Open>Resolved [21:01:31] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2362313 [21:01:34] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, and 4 others: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#2362312 (Ejegg) Open>Resolved [21:01:36] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2362314 (Ejegg) [21:01:38] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, and 3 others: Revisit Adyen missing donor info behavior - https://phabricator.wikimedia.org/T136038#2362315 (Ejegg) Open>Resolved [21:01:40] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2086811 [21:04:49] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#964453 (Ejegg) So close I can taste it! [21:07:07] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: [Epic] Make the forms come from one template - https://phabricator.wikimedia.org/T86248#2362322 (awight) [21:11:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Refactor: Sort out transaction_option vs getData* vs getTransactionSpecificValue vs account* constellation - https://phabricator.wikimedia.org/T137164#2362330 (awight) [21:16:53] (PS5) Awight: Wrap gateway URL in an accessor function and clean up redirect logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292272 (https://phabricator.wikimedia.org/T136743) [21:17:05] (CR) Awight: "That sounds better, thank you!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292272 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:19:30] Having a good adventure with Barbaloot... I'll have to relocate for 110VAC in a minute, but wanted to share my happiness at: https://en.wikipedia.org/wiki/File:Posta_Romana_-_1959_-_Laika_120_B.jpg#/media/File:Posta_Romana_-_1959_-_Laika_120_B.jpg [21:19:53] top dog! [21:19:55] ejegg: Thanks for the review, holler if I can get you started with the certificate? [21:20:00] hehe [21:20:18] oh hey, i was just thinking i could prolly merge em both [21:20:24] Apparently the USSR lied about her cause and time of death until 2002 [21:20:29] formalities forthcoming... [21:20:32] that would be great. [21:20:50] I'll deploy in an hour, and we should have jp_JP_pp-ec! [21:23:31] Ooh looks like I should WIP most of my other DonationInterface patches, they look junky [21:24:07] (PS6) Ejegg: Wrap gateway URL in an accessor function and clean up redirect logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292272 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:24:12] urp, I'm at 5% battery [21:24:14] goodbye [21:25:14] (CR) Ejegg: [C: 2] "restores an iota of sanity!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292272 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:26:30] (Merged) jenkins-bot: Wrap gateway URL in an accessor function and clean up redirect logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292272 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:28:45] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, and 3 others: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2362356 (awight) Also, documentation about how to get and use c... [21:31:30] AndyRussG: getting a p/w prompt at the varnish server, asking ops whether I need 2FA set up [21:34:02] AndyRussG: only ops can access the varnish servers. Perhaps one of them can re-run the command? [21:41:30] (PS5) Ejegg: Support certificate authentication [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292296 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:42:23] (CR) Ejegg: [C: 2] "Client SSL certs? How modern of you, PayPal!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292296 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:42:29] ejegg: cool beans! [21:44:20] (PS2) Cdentinger: Create fundraising/REL1_26 branch [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 [21:45:51] i am not seeing any obvious breakage there ^ [21:45:57] (Merged) jenkins-bot: Support certificate authentication [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292296 (https://phabricator.wikimedia.org/T136743) (owner: Awight) [21:47:24] cwd awesome, taking a look [21:48:25] thanks! just looking at CI now [21:48:45] some dead simple CR, in case anyone wants to knock off a few patches: [21:49:13] https://gerrit.wikimedia.org/r/289888 Remove referrer from queue messages [21:49:27] https://gerrit.wikimedia.org/r/289966 Remove referrer from DI messages (smashpig) [21:49:51] https://gerrit.wikimedia.org/r/292034 Update payments role test links (vagrant) [21:50:11] https://gerrit.wikimedia.org/r/292607 Extra assertion for pre-process test [21:50:52] https://gerrit.wikimedia.org/r/291149 Fix CSS selector in Adyen iframe (already deployed at the Adyen side, but our repo should have the latest) [22:25:27] (CR) Ejegg: "Do we want to un-ignore and check in composer.lock? Also, url for extensions/DonationEmailUnsubscribe submodule used to point to Fundraisi" [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (owner: Cdentinger) [22:30:35] (CR) Cdentinger: "Good question! We historically have, but I created this vendor by just checking out REL1_26. I went over the lockfiles by hand and didn'" [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (owner: Cdentinger) [22:32:11] ejegg: Are any of those patches for review urgent? [22:33:50] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293233 [22:34:03] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293233 (owner: Awight) [22:35:39] awight: nah, just trying to clear out some easy stuff [22:35:59] cool, I'll play it safe and limit changes to just the PP patches [22:36:07] k [22:38:17] ejegg: want to trade vagrant review? [22:38:35] oh sure! [22:39:42] awight: looks like CI is complaining about some trivial thing [22:39:54] https://integration.wikimedia.org/ci/job/rake-jessie/43861/console [22:40:37] lintballs! [22:42:02] got it [22:44:23] (PS1) Awight: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293237 [22:44:37] (CR) Awight: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293237 (owner: Awight) [22:45:19] (PS5) Awight: Remove referrer from queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289888 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [22:45:35] (CR) Awight: [C: 2] "Great idea!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289888 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [22:46:56] cwd: ^ that was your kind of patch :D [22:48:27] ejegg: gee there sure was a lot of bad-style cruft in the admin interface js.... [22:48:46] heh, none with your fingerprints on it! [22:48:57] ah yeah good stuff! [22:49:00] Mmmm I wish it were so [22:49:29] (PS3) Awight: Remove referrer from DI messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/289966 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [22:49:47] * AndyRussG stashes fake-fingerprint finger covers [22:49:59] (CR) Awight: [C: 2] "PS3: manual rebase, add order_id and remove referrer." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/289966 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [22:50:53] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293233 (owner: Awight) [22:51:41] (CR) Ejegg: "sure looks like the url is DonationEmail..." [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (owner: Cdentinger) [22:53:32] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293237 (owner: Awight) [22:53:35] (Merged) jenkins-bot: Remove referrer from queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289888 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [22:53:37] (Merged) jenkins-bot: Remove referrer from DI messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/289966 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg) [22:55:52] ejegg: urgh, that url was Fundraising in .git/modules bit Donation in .gitmodules [22:55:57] * cwd brain reset [22:56:57] fundraising-tech-ops: paypal gateway log messages should be bucketed - https://phabricator.wikimedia.org/T113308#2362656 (awight) p:Normal>High Increasing priority for the silly reason that we're launching a new PayPal integration soon, so the cleaner log would be helpful. [22:57:26] cwd arggh [22:57:58] i don't know which takes precedence [22:58:07] (CR) Awight: [C: 2] Extra assertion for pre-process test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292607 (owner: Ejegg) [22:58:11] well, the repo is actually at Fundraising [22:58:13] (PS2) Awight: Extra assertion for pre-process test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292607 (owner: Ejegg) [22:58:26] * cwd doesn't ask [22:59:11] :P [22:59:33] (CR) Awight: [C: 2] "Glad to have our generics back!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291149 (https://phabricator.wikimedia.org/T135416) (owner: Ejegg) [22:59:37] (PS2) Awight: Fix CSS selector in Adyen iframe [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291149 (https://phabricator.wikimedia.org/T135416) (owner: Ejegg) [23:00:37] thanks awight [23:00:45] any time [23:00:56] just looking for things we might actually need to put in vagrant's SmashPig.yaml [23:01:28] jenkins_jobs.errors.JenkinsJobsException: Duplicate entry point found for component type: 'parameter', 'parameter',name: 'string' [23:01:29] great [23:01:31] * cwd hangs head [23:01:37] ub [23:01:38] hehe wat [23:02:19] gonna take off in a little bit, but I won't forget about those vagrant patches [23:02:20] !log update paymentswiki from 28e10141454ef53085aed4c6619a34d3a4b43c58 to de11bfe2273d0bcaa0e713389b2d91e8b3567a1d; add PP cert [23:02:24] no rush [23:02:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:07:34] awight: bah, crm queue path defaults don't match smashpig [23:11:18] I prefer the smashpig defaults tho [23:14:03] k, gotta scram for now [23:20:11] (PS3) Cdentinger: Make fundraising/REL1_26 branch [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 [23:20:49] (CR) jenkins-bot: [V: -1] Make fundraising/REL1_26 branch [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (owner: Cdentinger) [23:22:45] * cwd facedesk [23:27:12] (PS4) Cdentinger: Make fundraising/REL1_26 branch [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158