[00:00:40] (PS2) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293447 [00:05:01] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293447 (owner: Ejegg) [00:08:26] (PS8) Ejegg: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 [00:09:05] (CR) Ejegg: "thanks AndyRussG, got rid of that extraneous '$' param" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 (owner: Ejegg) [00:10:41] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293447 (owner: Ejegg) [00:10:44] (PS3) Cdentinger: Add a country selector, links to OWTG [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260228 (https://phabricator.wikimedia.org/T96047) (owner: Awight) [00:15:20] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291149 (https://phabricator.wikimedia.org/T135416) (owner: Ejegg) [00:16:25] !log updated payments from de11bfe2273d0bcaa0e713389b2d91e8b3567a1d to c6ea2ca699aa78a90f64c77d860f69421e9a7782 [00:23:52] (CR) Cdentinger: "I worry this might be confusing. I wouldn't know what that link was for intuitively. However I don't know where else to put it. Maybe s" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260228 (https://phabricator.wikimedia.org/T96047) (owner: Awight) [00:26:00] (CR) Ejegg: [C: 2] "re-re-applying awight's +2 now that CI is back" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291149 (https://phabricator.wikimedia.org/T135416) (owner: Ejegg) [00:26:33] (PS4) Ejegg: Log an error when banner translation retrieval fails [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293147 (https://phabricator.wikimedia.org/T137247) [00:27:37] (Merged) jenkins-bot: Fix CSS selector in Adyen iframe [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291149 (https://phabricator.wikimedia.org/T135416) (owner: Ejegg) [00:32:20] (PS1) Ejegg: Shut up a warning, remove test code from prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293453 [00:36:42] (PS1) Ejegg: Add missing result page aliases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293454 [00:54:49] (PS1) Ejegg: Cap risk score sent to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293455 [00:55:19] XenoRyet: ^^^ does the TODO from that last patch's commit message [00:55:37] Cool, looking. [00:55:59] thanks! [00:58:04] (PS1) Ejegg: Remove completed TODO comment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293456 [01:05:47] (CR) XenoRyet: [C: 2] Cap risk score sent to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293455 (owner: Ejegg) [01:07:12] (Merged) jenkins-bot: Cap risk score sent to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293455 (owner: Ejegg) [01:09:14] (CR) XenoRyet: [C: 2] Remove completed TODO comment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293456 (owner: Ejegg) [01:09:51] And now it's time to call it quits for the day. Catch you folks tomorrow. [01:10:03] see ya! [01:11:19] (Merged) jenkins-bot: Remove completed TODO comment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293456 (owner: Ejegg) [01:21:19] (PS1) Ejegg: Adyen signature StagingHelper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293458 (https://phabricator.wikimedia.org/T137157) [02:08:17] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt, Unplanned-Sprint-Work: Kill staged_vars - https://phabricator.wikimedia.org/T137387#2366819 (Ejegg) [02:10:55] (CR) Aaron Schulz: Add WAN caching to ChoiceDataProvider (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [02:11:37] (CR) Aaron Schulz: Add WAN caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [02:37:07] (PS1) Ejegg: Kill staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293463 (https://phabricator.wikimedia.org/T137387) [02:38:22] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Adyen staging functions should be rewritten as helpers - https://phabricator.wikimedia.org/T137157#2366846 (Ejegg) [02:38:24] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Kill staged_vars - https://phabricator.wikimedia.org/T137387#2366819 (Ejegg) [02:39:06] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, and 4 others: Adyen staging functions should be rewritten as helpers - https://phabricator.wikimedia.org/T137157#2359358 (Ejegg) a:Ejegg [02:40:34] (CR) Ejegg: [C: -1] "Needs that $self = $this nonsense to match the other closures" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/293248 (https://phabricator.wikimedia.org/T133964) (owner: Awight) [03:10:57] (PS2) Ejegg: Kill staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293463 (https://phabricator.wikimedia.org/T137387) [03:48:41] (PS1) Ejegg: AstroPay signature as staging helper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 [03:50:36] (CR) jenkins-bot: [V: -1] AstroPay signature as staging helper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 (owner: Ejegg) [03:57:58] (PS2) Ejegg: AstroPay signature as staging helper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 [04:11:32] (PS3) Ejegg: AstroPay signature as staging helper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 (https://phabricator.wikimedia.org/T137164) [04:13:57] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Refactor: Sort out transaction_option vs getData* vs getTransactionSpecificValue vs account* constellation - https://phabricator.wikimedia.org/T137164#2366951 (Ejegg) Also, how about the staged data keys are the processor... [04:30:59] (PS1) Ejegg: EncodingMangler implements StagingHelper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293466 (https://phabricator.wikimedia.org/T137164) [04:38:06] totally forgot that pomegranite white tea i put on ice had caffeine in it... [04:58:53] Is anyone awake and know the current alarm code for the office? [05:38:55] (CR) Ori.livneh: Add WAN caching to ChoiceDataProvider (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [05:40:45] (PS2) Ori.livneh: Add WAN caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 [05:45:42] (PS3) Ejegg: Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 [05:47:29] (CR) jenkins-bot: [V: -1] Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [05:52:04] (PS4) Ejegg: Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 [05:59:48] (PS3) Ejegg: Actually block if flagged on GatewayReady [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292970 (https://phabricator.wikimedia.org/T136381) [06:05:53] (CR) Ejegg: "Thanks for the CR awight! PS4 should deals with the permanent blacklist after a fraud block, and simplifies the check in amazon.api.php. H" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292970 (https://phabricator.wikimedia.org/T136381) (owner: Ejegg) [06:11:38] (Abandoned) Ejegg: WIP popAtomic for Stomp [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/288037 (owner: Ejegg) [06:12:24] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: Write pending queue consumer and schema - https://phabricator.wikimedia.org/T133197#2367122 (Ejegg) Abandoning the stomp popAtomic... [06:14:42] (PS2) Ejegg: Fix some PHPDoc comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 [06:26:40] (PS2) Ejegg: More efficient old custom value lookup [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283513 [06:28:50] (CR) jenkins-bot: [V: -1] More efficient old custom value lookup [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283513 (owner: Ejegg) [06:33:58] (PS1) Ejegg: Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293468 [06:34:17] (CR) Ejegg: [C: 2 V: 2] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293468 (owner: Ejegg) [06:34:56] (PS3) Ejegg: More efficient old custom value lookup [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/283513 [06:54:21] (CR) Aaron Schulz: Add WAN caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [14:16:53] Fundraising-Backlog, fundraising-tech-ops: access request for new fundraising analyst (Brent Cohn) - https://phabricator.wikimedia.org/T135392#2367863 (Jgreen) [14:23:26] Fundraising-Backlog, fundraising-tech-ops: access request for new fundraising analyst (Brent Cohn) - https://phabricator.wikimedia.org/T135392#2367890 (Jgreen) I put in request to OIT for Brent's yubikey: http://wmf.zendesk.com/requests/11074 [16:01:20] ejegg: pats is asking if they can run a 2 hour test starting at 10. Would you have to monitor the second hour? We could always do this tomorrow too [16:03:21] I think it's ok [16:03:49] If things are going horribly wrong an hour in, we can ask them to shut it down [16:05:24] dstrine / Guest97342 : it should be fine, they can shut it down if things are busted after 45 min [16:27:29] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues - https://phabricator.wikimedia.org/T137434#2368297 (Jgreen) [16:28:01] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2368312 (Jgreen) [16:28:30] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2368297 (Jgreen) [16:28:50] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2368297 (Jgreen) [16:28:52] fundraising-tech-ops: replace payments1002-1004 with new hardware running debian/jessie - https://phabricator.wikimedia.org/T137299#2368319 (Jgreen) [16:29:26] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2368297 (Jgreen) [16:29:28] fundraising-tech-ops: reimage payments2001-2003 with debian/jessie - https://phabricator.wikimedia.org/T137152#2368321 (Jgreen) [16:37:45] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 4 others: Can the CIVI import function show what rows in a file aren't imported? - https://phabricator.wikimedia.org/T88460#2368341 (RLewis... [16:44:12] heads up, we're running another France/Israel test from 17-19 UTC ie starting in 15 minutes. MBeat, just checking if that's okay for you? [16:44:26] sure thing, the-wub [16:44:33] cool thanks [16:45:07] Fundraising-Backlog: Two small edits to the template of the Main Contact Record Page - https://phabricator.wikimedia.org/T137438#2368395 (CaitVirtue) [16:46:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Two small edits to the template of the Main Contact Record Page - https://phabricator.wikimedia.org/T137438#2368427 (CaitVirtue) p:Triage>High [16:51:12] I can see all the banners when forcing them this time, which is a good sign :) [16:52:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Two small edits to the template of the Main Contact Record Page - https://phabricator.wikimedia.org/T137438#2368448 (RLewis) @CaitVirtue this is some we can do ourselves, I've made the changes and added in the extra field. Take a look and let me know if... [16:58:34] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293528 [16:58:51] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/293528 (owner: Ejegg) [16:59:42] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293529 [17:01:03] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293529 (owner: Ejegg) [17:01:27] PPena MBeat ejegg : banners are up [17:01:42] awesome, thank you [17:02:34] the-wub: deploying one tiny tweak to keep Adyen from auto-declining on their side when we have a high fraud score, shouldn't disrupt anything [17:02:56] thanks ejegg [17:03:04] sorry, i though i had that finished in last night's deploy [17:07:07] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/293529 (owner: Ejegg) [17:09:59] !log updated payments-wiki from 3dcf58e3b4e1d02ad4f1874a3e87e55b7e169bfe to 053aaa259382c94aa59e4d0da7317fcafab635cd [17:10:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:12:47] the-wub thanks [17:14:16] the-wub ejegg I dont see much happening in the console agian, hopefully just a delay [17:14:24] ejegg logs look good? [17:15:13] I see 1 donation through adyen. but the delay was about this long in the last test too [17:22:27] PPena: yep, logs look fine [17:22:35] cool [17:23:36] Adyen donations are always going to take a little while to show up, because we have to wait for the IPN to decide whether to capture. [17:24:12] then i split up the capture / send to civi queue into two steps so manually captured things get caught the same way [17:25:11] so there are 3 jobs on our side that have to run, interleaved with 2 on Adyen's, before Civi knows it's for real [17:29:38] (PS9) Ejegg: Encapsulated amount validation for better messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) [17:31:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Two small edits to the template of the Main Contact Record Page - https://phabricator.wikimedia.org/T137438#2368622 (CaitVirtue) Looks great. THANK YOU!!! [17:31:58] (CR) Ejegg: "@awight, thanks for nudging me to add tests - I discovered I wasn't using the bigamount message key to point people to benefactors@wm.o!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg) [17:49:32] (PS1) Ejegg: Fix 'Other ways to give' link in error pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293537 (https://phabricator.wikimedia.org/T131995) [17:53:24] Fundraising Sprint Killing Time, Fundraising-Backlog, Unplanned-Sprint-Work: Adding info to the prospect tab Funny characters that I didn’t type - https://phabricator.wikimedia.org/T137451#2368727 (DStrine) [17:57:07] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: JCB transactions failing - https://phabricator.wikimedia.org/T137452#2368747 (DStrine) [17:58:33] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Unplanned-Sprint-Work: Adding info to the prospect tab Funny characters that I didn’t type - https://phabricator.wikimedia.org/T137451#2368776 (DStrine) [18:08:56] (PS3) Krinkle: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [18:09:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: shut crm error up - https://phabricator.wikimedia.org/T137455#2368813 (cwdent) [18:10:01] ejegg the-wub MBeat just checking... all looking smooth? [18:10:23] looking good so far [18:10:26] PPena: all seems fine to me [18:10:45] yup [18:11:12] handful of Auths to look into, but success rates at portal look good [18:11:56] (CR) Krinkle: "Nice. To summarise (and verify):" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [18:12:51] (Abandoned) Krinkle: Add in-process caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/290825 (owner: Krinkle) [18:15:52] MBeat the-wub ejegg cool we all see the same thing :) [18:23:56] Hey the-wub! How's everything? Pls lmk if you'd like me to peek at any of the hovercards banner tests or anything... ;) [18:32:52] hey ejegg, if an Adyen trx gets stopped (and stays) at Auth, is that only because of us? [18:33:17] MBeat: I think so [18:33:52] cool, ty [18:34:09] Fundraising-Backlog, fundraising-tech-ops: access request for new fundraising analyst (Brent Cohn) - https://phabricator.wikimedia.org/T135392#2368914 (MeganHernandez_WMF) There are two other people working on Brent's team who will also need access (Jasmeet Samra and Maximilian Pany ). @spatton & @jrob... [18:45:26] (PS1) Ejegg: Don't try to serialize Capture job logger [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293543 [18:48:20] MBeat I think those will be your manual review, like 600 in Ingenico [18:49:20] ty PPena - it looks like it may take a little while for some of them to settle out of there [18:51:53] PPena / MBeat looks like the delay updating status in their console is even longer than the delay getting donations into Civi. If you see it in Civi, it's definitely been captured already [18:53:58] cwd https://gerrit.wikimedia.org/r/293543 oughtta fix the exception in that smashpig failmail just now [18:59:29] (CR) Ori.livneh: "Krinkle: yep, that's accurate. It's a nice summary so I'll use it in the commit message and credit you as co-author." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [19:01:30] (PS4) Ori.livneh: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 [19:02:11] PPena MBeat ejegg : test is over. results look pretty similar to the last one, will let them settle and then follow up on email [19:02:25] ejegg: checking it out [19:02:32] thanks, the-wub [19:02:33] thanks the-wub [19:03:13] and ty cwd [19:03:15] thanks the-wub, ejegg and MBeat ! [19:04:00] glad we're finally getting some smooth sailing with the adyen integration code [19:04:26] yea, definitely hope they work out [19:09:29] deploying settings change, confirm code is 'bggy' [19:09:47] not superstitious, but i might type 'no' and re-run [19:11:35] !log updated cancel page settings on payments-wiki [19:11:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:12:43] ok, that looks good [19:13:53] haha [19:14:00] i love those codes [19:14:39] just the right length to randomly throw us 'four letter words' [19:15:17] (PS1) Ejegg: FIXMEs re: fail forms & their titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293548 (https://phabricator.wikimedia.org/T131995) [19:19:28] (CR) Cdentinger: [C: 2] "That is quite the inheritance chain!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293543 (owner: Ejegg) [19:19:42] heh, gotta dig deep [19:20:11] ejegg: does your IDE make that more obvious? [19:20:37] does it have visibility into the inheritance or something? [19:20:44] yeah, there's a heirarchy view [19:21:02] i can see how that would be handy [19:21:04] and you can just ctrl-click on the parent class name to navigate that way [19:21:18] i'm guessing you can do something like that with ctags in vim [19:22:00] probably - I had that working once but I completely forget the interface now [19:22:29] (Merged) jenkins-bot: Don't try to serialize Capture job logger [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293543 (owner: Ejegg) [19:22:49] (PS4) Awight: Import errors are logged and recoverable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/283112 (https://phabricator.wikimedia.org/T88460) [19:23:42] yeah i am lazy about that stuff :P [19:24:26] me too, hence IDE [19:25:07] yeah [19:25:30] i usually try to avoid inheritance because i find it unnecessarily confusing [19:25:42] but i still have to deal with it a lot [19:25:56] yeah, best to wait till you find yourself repeating code [19:26:04] (PS2) Awight: Add the predis library [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293249 [19:26:17] one level of inheritance can be really elegant in the right situations [19:26:28] but beyond that i just get lost [19:26:55] i think traits are a better way to handle the same problem [19:27:42] (CR) jenkins-bot: [V: -1] Add the predis library [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293249 (owner: Awight) [19:27:43] still not convinced... i did a bunch with 'extension methods' in c# and ended up regretting most of it [19:29:02] it's probably about the same, can be handy or a burden, depending on the execution [19:30:16] extension methods were good for trivial stuff, but once they got more than a few lines long they're the wrong tool for the job [19:30:37] (CR) AndyRussG: [C: 2] "Woohoo!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 (owner: Ejegg) [19:30:53] Thanks AndyRussG ! [19:31:24] ejegg: thanks to u for that great patchissimo! [19:32:39] heh, most of the work was undoing the extreme linewrapping my IDE added when I had it reformat [19:33:00] (Merged) jenkins-bot: Enforce jscs, make it pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/291288 (owner: Ejegg) [19:37:52] (CR) Ejegg: "The worst bit about migrating to extension.json is the fact you can't add comments for all those globals :(" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [19:43:59] relocating for mtgs [20:00:51] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2369336 (Jgreen) > switch to systemd's sntp instead of standard ntpd? decided against. ntp::client adds this: timedatectl set-ntp false [20:15:03] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2369376 (Jgreen) > freshclam won't start "AllowSupplementaryGroups false" isn't supported, and doesn't appear to be needed for precise/trusty since the def... [20:16:25] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2369377 (Jgreen) > timezone is wrong after install UTC isn't an option during manual install (?), but it's fixed fixed via preseed for automatic installs [20:25:28] fundraising-tech-ops: reimage payments2001-2003 with debian/jessie - https://phabricator.wikimedia.org/T137152#2369415 (Jgreen) [20:25:30] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2369411 (Jgreen) Open>Resolved > figure out local systemd vs syslog log centralization this is already working. [20:25:32] fundraising-tech-ops: replace payments1001 with new server running debian/jessie - https://phabricator.wikimedia.org/T137301#2369413 (Jgreen) [20:25:34] fundraising-tech-ops: replace payments1002-1004 with new hardware running debian/jessie - https://phabricator.wikimedia.org/T137299#2369414 (Jgreen) [20:55:03] fundraising-tech-ops: fundraising jessie build/puppet integration outstanding issues for payments servers - https://phabricator.wikimedia.org/T137434#2369723 (Jgreen) [21:15:29] (CR) Ori.livneh: Add object caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [21:15:43] (PS5) Ori.livneh: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 [21:20:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Receipt/Thank you letters from Civi - Fix template? - https://phabricator.wikimedia.org/T137496#2369861 (CaitVirtue) [21:24:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: A tool to evaluate and fix donor-entered data - https://phabricator.wikimedia.org/T137498#2369899 (CaitVirtue) [21:24:38] (CR) Aaron Schulz: Add object caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [21:30:00] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, Fundraising-Backlog, and 2 others: Figure out & fix the certificate issue that's not allowing civi users to have dashlets - https://phabricator.wikimedia.org/T118356#2369925 (CaitVirtue) @awight... [21:35:30] sorry fr-tech crm meeting went long, be in the gerrit meeting in one sec [21:37:27] also, AndyRussG cwd XenoRyet anybody set up hilighting on fr-tech yet? :) ^^ [21:37:49] Notyet [21:37:56] yep! [21:38:07] Heh, not quite yet. Wasn't immediatly obvious how to do it in pidgin. [21:51:43] (PS2) Awight: Make Capture IPN logging like Auth IPN logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/291150 (owner: Ejegg) [21:51:47] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 5 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2369974 (CCogdill_WMF)... [21:51:48] (CR) Awight: [C: 2] Make Capture IPN logging like Auth IPN logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/291150 (owner: Ejegg) [21:52:38] (PS2) Awight: Shut up a warning, remove test code from prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293453 (owner: Ejegg) [21:52:49] (CR) Awight: [C: 2] Shut up a warning, remove test code from prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293453 (owner: Ejegg) [21:53:12] (Merged) jenkins-bot: Make Capture IPN logging like Auth IPN logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/291150 (owner: Ejegg) [21:53:22] (PS2) Awight: Add missing result page aliases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293454 (owner: Ejegg) [21:53:27] (CR) Awight: [C: 2] Add missing result page aliases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293454 (owner: Ejegg) [21:54:10] (Merged) jenkins-bot: Shut up a warning, remove test code from prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293453 (owner: Ejegg) [21:55:21] (Merged) jenkins-bot: Add missing result page aliases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293454 (owner: Ejegg) [22:00:09] (CR) Krinkle: Add object caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [22:04:42] (CR) Aaron Schulz: Add object caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [22:18:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: A tool to evaluate and fix donor-entered data - https://phabricator.wikimedia.org/T137498#2369899 (Platonides) Maybe it would be positive if you listed the most common cleanups that such robot should do? [22:55:18] fr-tech: woot! [22:56:30] holler [22:56:34] should i invite all of fr-tech? [22:59:13] Yea, seems like a good idea [23:05:02] sure thing! [23:05:25] (PS1) Eileen: Core 4.7.9 (ish) version [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293641 [23:05:27] (PS1) Eileen: WMF customisations & as yet unmerged improvements (on top of 4.7.8) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293642 [23:08:07] (CR) jenkins-bot: [V: -1] Core 4.7.9 (ish) version [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293641 (owner: Eileen) [23:08:25] (CR) jenkins-bot: [V: -1] WMF customisations & as yet unmerged improvements (on top of 4.7.8) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293642 (owner: Eileen) [23:11:42] (PS3) Awight: Don't assume configured directories end in a slash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241109 [23:13:44] somebody say fr-tech, see if I've got hmy highlighting working. [23:14:04] fr-tech!!! [23:14:04] fr-tech! [23:14:11] Yep, thanks [23:14:11] hehe [23:14:12] damn. mine isn't working [23:14:41] (PS1) Eileen: bower_components [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293644 [23:14:47] spelling. [23:14:57] "/hilight" [23:15:00] fr-tech me [23:15:06] fr-tech [23:15:09] oh good [23:15:19] hilight party! [23:15:29] that also explains why "awight|muck" never worked [23:15:37] cos highlight, hilight and hilite [23:15:50] dang hybrid spelling [23:16:06] good talk, i'm excited about having a better venue to talk about tech stuff. standup tends to be more about tickets [23:16:23] yah. And I'm protective of our social time ;) [23:17:23] (CR) jenkins-bot: [V: -1] bower_components [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293644 (owner: Eileen) [23:18:14] ^ [23:19:05] (PS3) Awight: Add the predis library [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293249 [23:20:31] Can someone send me the secret email address for the Fundraising Tech calendar? [23:21:05] oh huh, I don't have that one [23:21:29] cwd: maybe also add us all as individuals [23:22:24] will do [23:22:35] my only regret is we can't get eileen in on it [23:23:09] Maybe daylight savings will fall back... [23:24:37] AndyRussG: You might if I hack on the extension registration patch for CentralNotice a bit? Just asking in case you ran off and licked it [23:25:27] (CR) Ejegg: [C: 2 V: 2] "Looks good! Merging so we can use it for DonationInterface CI, we can shake out any bugs." [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (https://phabricator.wikimedia.org/T137213) (owner: Cdentinger) [23:25:52] k, i gotta head out [23:25:53] awight: heh please go ahead, no licks of mine have been perched thereupon, at least not intentionally so, or AFIK [23:25:57] thx for asking! [23:25:58] good evening all! [23:26:04] see ya! [23:26:08] I was gonna ask u more about how that's working, but I could also read the doc [23:26:12] AndyRussG: Oh hey and a Canada question :) The cheap flights involved a day-long layover in Toronto, I was wondering if you would recommend the science museum or the kid's playground on the island... [23:26:16] ejegg|away: cya! [23:26:27] Hmmm [23:26:33] AndyRussG: Great, I'll just put a fresh layer of paint and we can talk next week [23:26:37] Isn't the science museum closed for rennovations? [23:26:40] ooh [23:26:43] That would factor in [23:26:44] (PS1) Eileen: CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293649 [23:26:53] It was last November when we wanted to go [23:27:01] Dunno about the island playground [23:27:30] (CR) jenkins-bot: [V: -1] Make fundraising/REL1_26 branch [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (https://phabricator.wikimedia.org/T137213) (owner: Cdentinger) [23:27:34] Our two successful kid activities in TO last Novemember were: the acquarium next to the CN tower, and the beach [23:27:50] oh excellent. aquarium always hits the spot [23:27:54] gotta run to the store, back later! [23:28:03] cwd|afk: cya! [23:28:20] We're also on a short layover in Montreal, but only 4 hours so probably not much of an adventure [23:28:34] awight: yea we rushed through it in a little over an hour, but there was much more [23:28:48] awight: ohh hey! wow that's a lot of layovers [23:29:01] (PS12) Awight: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [23:29:02] Is it Toronto and then Mtl? [23:29:06] When is it? [23:29:33] I think we're in TO on the 19th, and Mtl on the 4th [23:29:40] 4th of July? [23:29:41] (CR) jenkins-bot: [V: -1] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293649 (owner: Eileen) [23:29:51] Ah post-Europe [23:30:24] If ur not deathly tired we might be able to scoop you up or somehow meet... [23:30:49] Heh the news on our situation is... July we're still here. And after that, we still don't know 8p [23:31:09] That would be tres fun, but I was assuming you would be busy with the "don't know" you referenced [23:33:56] (CR) Awight: Consume pending queue to database (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [23:34:30] awight: heh it might have been the case, prior to this decision... But now we're quite likely to be around [23:35:07] OK I will spam you with itinerary this weekend... [23:35:29] cool beanz!!:) We can also be flexible depending on if the flight is late and what your tiredness state is, BTW [23:36:01] that's for real. We'll have a better sense for crazy after surviving the outbound flights [23:38:33] (CR) Awight: "Hehe. Accidentally discovered during testing that we drop the data if the table is missing. Seems not very atomic." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [23:39:02] (CR) Awight: "^ but probably not the fault of this patch... I'm sure my Predis::popAtomic implementation is to blame" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [23:39:39] (CR) Awight: [C: 2] "ka-ching!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [23:39:53] (PS4) Awight: Add the predis library [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293249 [23:45:00] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Can we allow fallback to alternative campaign if mixin would hide this on... - https://phabricator.wikimedia.org/T124969#2370246 [23:45:11] laterz! [23:47:57] (Merged) jenkins-bot: Consume pending queue to database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287147 (https://phabricator.wikimedia.org/T133197) (owner: Ejegg) [23:54:39] (PS2) Eileen: CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293649 [23:57:17] (CR) jenkins-bot: [V: -1] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293649 (owner: Eileen)