[00:12:40] (CR) Ori.livneh: Add object caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [00:13:41] (PS1) Eileen: WMF adjustments over 4.7.8 branch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293659 [00:16:21] (CR) jenkins-bot: [V: -1] WMF adjustments over 4.7.8 branch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293659 (owner: Eileen) [00:20:36] (Abandoned) Eileen: Core 4.7.9 (ish) version [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293641 (owner: Eileen) [00:20:50] (Abandoned) Eileen: bower_components [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293644 (owner: Eileen) [00:21:11] (Abandoned) Eileen: WMF customisations & as yet unmerged improvements (on top of 4.7.8) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293642 (owner: Eileen) [00:23:43] (PS1) Eileen: wmf-sunset-patch alter exception behaviour [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293660 [00:25:52] (CR) jenkins-bot: [V: -1] wmf-sunset-patch alter exception behaviour [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293660 (owner: Eileen) [00:46:04] (PS6) Ori.livneh: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 [01:48:34] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Can we allow fallback to alternative campaign if mixin would hide this on... - https://phabricator.wikimedia.org/T124969#2370463 [02:56:41] (CR) Aaron Schulz: [C: 1] Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [03:47:40] (PS17) Awight: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [03:48:00] (CR) jenkins-bot: [V: -1] [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [03:59:16] (PS18) Awight: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [03:59:34] (CR) jenkins-bot: [V: -1] [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [04:03:03] (PS19) Awight: [WIP] Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [04:03:22] (CR) jenkins-bot: [V: -1] [WIP] Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [04:09:35] (PS20) Awight: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [04:09:53] (CR) jenkins-bot: [V: -1] Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [04:11:35] (CR) Awight: "@AndyRussG:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [05:48:13] (PS1) Ejegg: Add autocomplete hints to personal info form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293681 [05:51:55] (PS10) Ejegg: Encapsulated amount validation for better messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) [05:52:21] (CR) Ejegg: "PS10: whitespace" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg) [06:00:57] (PS5) Ejegg: Actually block if flagged on GatewayReady [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292970 (https://phabricator.wikimedia.org/T136381) [08:19:28] (PS21) Awight: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [08:19:30] (PS1) Awight: [WIP] Clean up from extension registration migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293687 [08:19:58] (CR) jenkins-bot: [V: -1] Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [08:20:10] (CR) jenkins-bot: [V: -1] [WIP] Clean up from extension registration migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293687 (owner: Awight) [08:34:40] (PS2) Awight: Clean up from extension registration migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293687 [08:34:42] (PS22) Awight: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [08:34:44] (PS1) Awight: Clean up annoying punctuation and unnecessary strict equality [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293688 [08:35:22] (CR) jenkins-bot: [V: -1] Clean up from extension registration migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293687 (owner: Awight) [08:35:31] (CR) jenkins-bot: [V: -1] Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [08:35:46] (CR) jenkins-bot: [V: -1] Clean up annoying punctuation and unnecessary strict equality [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293688 (owner: Awight) [08:38:34] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, and 2 others: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#2370887 (awight) a:awight [10:00:37] Fundraising-Backlog, fundraising-tech-ops: access request for new fundraising analyst (Brent Cohn) - https://phabricator.wikimedia.org/T135392#2371034 (jrobell) Thank you @Jgreen for your help on this. Yubikeys for Brent Cohn, Jasmeet Samra and Maximilian Pany can be sent to the following address: CPS... [12:00:35] (CR) Krinkle: "Other use of CNDatabase master: CleanCNTranslateMetadata.php, Banner:: populateBasicData()," [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [12:58:31] fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2371491 (faidon) [12:58:33] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup payments1005-8 - https://phabricator.wikimedia.org/T136881#2371492 (faidon) [14:14:55] (PS1) Eileen: WIP try to get test info [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293727 [14:17:11] (CR) jenkins-bot: [V: -1] WIP try to get test info [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293727 (owner: Eileen) [14:27:44] (PS1) Eileen: WMF patch to log source of queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293729 [14:29:49] (CR) jenkins-bot: [V: -1] WMF patch to log source of queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293729 (owner: Eileen) [15:42:55] Jeff_Green: would 7pm monday work for you for a civi upgrade? [15:43:12] 7pm your time [15:44:33] dstrine: yeah that would be ok [15:44:51] actually that's preferable than tuesday, i forgot about a going away party that night [15:45:24] ok cool thanks. this isn't set in stone yet. I'm trying to line up everyone today [15:45:42] woohoo, upgrade monday! [15:46:00] hey ejegg do you think you could help with the civi upgrade at 7pm your time? [15:47:23] yeah, I can help for at least the start of it. Going to a show at 8:30 eastern [15:51:33] ejegg: eileen is cool with that (I'm talking to her in office) [15:51:40] cool [15:52:36] the-wub: we're discussing the civi upgrade. It sounds like we can do it later on monday. That will be in your evening. [15:52:56] like midnight, right? [15:53:26] yeah so no one in europe should be bothered :) [16:02:06] thanks dstrine, sounds good [16:16:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make summary fields in contact records more useful - https://phabricator.wikimedia.org/T137568#2372099 (LeanneS) [16:17:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding Gift Source option for Engage users - https://phabricator.wikimedia.org/T137569#2372119 (LeanneS) [16:20:03] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Amazon, and 2 others: Glitch in Amazon SmashPig config - https://phabricator.wikimedia.org/T136043#2372144 (DStrine) [16:22:17] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, and 3 others: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#2372148 (DStrine) [16:30:28] (PS1) Eileen: Create civicrm_strip_non_numeric during test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293750 [16:33:05] Can I get someone to do a quick review on this test-only fix/ hack so I can rerun the civicrm-patch with this fix in ? https://gerrit.wikimedia.org/r/#/c/293750/ [16:33:57] (PS2) Eileen: Create civicrm_strip_non_numeric during test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293750 [16:40:00] ejegg: can you take a look at that patch above? It's a blocker to checking if the 4.7 code is all good (& it should be an easy review) [16:41:11] sure thing eileen [16:41:16] thanks heaps! [16:41:25] ejegg: do you think campaigns need to come down for the civi upgrade? I was assuming so but I wanted to confirm. [16:41:36] I'm in this juggling between master & submodule stage [16:44:40] (CR) Ejegg: [C: 2] "nicely workarounded" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293750 (owner: Eileen) [16:45:25] (CR) Eileen: "a brand new verb enters the lexicon" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293750 (owner: Eileen) [16:45:45] dstrine: depends how long the outage is and what kind of traffic we're getting [16:46:02] eileen: thinks it will take 4 hours [16:46:11] if it's low traffic for a few hours, we can just let stuff hang out in the queue [16:46:18] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293750 (owner: Eileen) [16:46:25] we won't be running any campaign at the time [16:46:43] actually I hope it won't take 4 hours :-) [16:46:45] (Merged) jenkins-bot: Create civicrm_strip_non_numeric during test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293750 (owner: Eileen) [16:46:48] cool, let's leave banners up and just turn the consumers off [16:47:01] so that's just turning off through jenkins isn't it [16:47:07] yep! [16:47:28] what I should do is review last time's plan for this time [16:47:37] eileen: I'll still set expectations for 4 hours. It's better to announce more time than we need [16:47:37] ooh, good call [16:47:57] OK - I'll look to do that [16:48:04] i'd be interested to take a look too if you wanna point me at it [16:48:09] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293729 (owner: Eileen) [16:48:52] (Abandoned) Eileen: Backport markConflicts code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/285325 (https://phabricator.wikimedia.org/T132396) (owner: Eileen) [16:49:40] so we have this link [16:49:41] https://collab.wikimedia.org/wiki/Checklists_for_maintenance_%26_Recovery [16:49:57] and this is the list [16:49:58] https://collab.wikimedia.org/wiki/2016-05-03-CIvi-enable-logging-checklist [16:50:12] that we can put in an etherpad to edit for next week [16:50:28] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, MediaWiki-extensions-DonationInterface: Upgrade code to use certificate-based authentication - https://phabricator.wikimedia.org/T134451#2372247 (awight) Why sprint +2? Looks like an accident... This t... [16:50:43] I think last time there were a few proposed edits to step 22 [16:52:30] Fundraising-Backlog, FR-PayPal-ExpressCheckout: instructions for blocking accounts payments from Non-U.S. accounts - https://phabricator.wikimedia.org/T137577#2372264 (DStrine) [16:54:22] Jeff_Green: ejegg here is the etherpad for the upgrade - it's just a copy so far https://etherpad.wikimedia.org/p/2016-jun-14-civi47upgrade [16:54:39] thanks! [16:55:49] eileen: ok great [16:58:05] can you check through it & check if anything has changed. I'm made a few edits & I'm not sure about no 16 [16:58:17] looking [16:59:31] no changes from my side that I can think of [17:00:05] re. 16, i'm not sure about drop trigger syntax, checking [17:02:30] it doesn't look like you can drop multiple triggers in one sql statement, so I guess it would be handy to have a prepared list [17:02:52] ejegg: so the code for the 4.7 upgrade is the 5 patches working backwards from here https://gerrit.wikimedia.org/r/#/c/293729/ the tests are passing on them now except lint so I'll have to look at that shortly - just going over some stuff with David - but I'll check that soon - I want to get those merged today in prep for the deploy [17:06:25] k, i can take a look [17:06:36] cwd: are you doing that tech talk? [17:07:14] yea! [17:07:37] on in a sec [17:19:00] (PS1) Eileen: (WIP)Add Contact custom fields to report [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293757 [17:21:20] (CR) jenkins-bot: [V: -1] (WIP)Add Contact custom fields to report [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293757 (owner: Eileen) [17:42:10] fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2352865 (Ejegg) Oh boy, we just noticed 1.26 is EOL in November (https://www.mediawiki.org/wiki/Version_lifecycle#Versions_and_their_end-of-life), so we'll need to be off 5.3 before Big... [17:43:51] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281485 (owner: Ejegg) [17:56:52] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Push all translation up to the form layer - https://phabricator.wikimedia.org/T130669#2372531 (Ejegg) [18:08:03] AndyRussG: https://www.jwz.org/doc/worse-is-better.html [18:09:25] cwd: cool thx! [18:14:40] ejegg: so when you have a chance - the patches look OK - but I don't get the php53lint fail https://gerrit.wikimedia.org/r/#/c/293729/ [18:15:37] it's failing on this line '3919eeb97e98d4648304477f8ef734ba' => __DIR__ . '/..' . '/phpseclib/phpseclib/phpseclib/Crypt/Random.php', [18:15:37] which looks valid to me [18:18:39] eileen: sure, i'll take a look soon [18:18:49] gotta relocate first tho [18:23:21] (PS7) Ori.livneh: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 [18:35:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Rudimentary scoping of mediawikiless-donationinterface - https://phabricator.wikimedia.org/T137586#2372608 (cwdent) [18:39:46] (PS1) Eileen: Add mysql to drop triggers to git [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293785 [18:52:29] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Unplanned-Sprint-Work: Adding info to the prospect tab Funny characters that I didn’t type - https://phabricator.wikimedia.org/T137451#2368727 (Eileenmcnaughton) This seems to have been 'incidentally fixed' - ie. when I packaged up the code fo... [19:20:10] eileen: so, I'm inclined to just take the '4.7.8 core code' commit on faith... [19:20:22] don't think i could review all that by monday evening [19:21:04] I'll force-merge it since our tests need some of the following patches [19:22:34] (CR) Ejegg: [C: 2 V: 2] "Force-merging since our tests depend on subsequent patches" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293649 (owner: Eileen) [19:22:52] (PS1) Eileen: Add prospecting custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293793 (https://phabricator.wikimedia.org/T128818) [19:23:25] (CR) jenkins-bot: [V: -1] Add prospecting custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293793 (https://phabricator.wikimedia.org/T128818) (owner: Eileen) [19:23:34] ah crud, no submit button [19:23:55] ejegg: yeah the 4.7.8 is simply the tarball untarred [19:24:31] lemme see if I can temporarily give us force permissions on that repo [19:24:50] hmm, guess I should keep those to a minimum so as not to disrupt zuul [19:24:59] the next patch is a combo of our patches & some 4.7.9 patches - which is a shame because it would have been easy reading otherwise [19:25:10] (CR) jenkins-bot: [V: -1] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293649 (owner: Eileen) [19:25:15] eileen: mind doing a PS3 removing the Trait files from vendor? [19:25:28] as long as we're php53 linting [19:25:57] is that what is causing the fail? [19:26:15] that's what I see in the 4.7.8 patch [19:26:41] not sure about that WMF query one [19:26:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make summary fields in contact records more useful - https://phabricator.wikimedia.org/T137568#2372099 (RLewis) @LeanneS this is something we can discuss in our check in next week as it might be something we can update ourselves by adding custom fields.... [19:27:00] hmm - so on the fail I'm ONLY looking at the last in the patch queue [19:27:22] because I originally dropped the exception patch & had to bring it back for the tests [19:27:28] this is the patch copied sheet [19:27:29] https://docs.google.com/spreadsheets/d/17a8jQ5XWVUVM5QS2W3h5UIBvzV3RLTqcaBJxL0ivvZg/edit#gid=0 [19:28:02] nb all the code is on staging now [19:28:19] love that shinking 'carry' list [19:28:28] *shrinking [19:28:29] :-) [19:29:19] here's the Trait fail in 4.7.8: https://integration.wikimedia.org/ci/job/php53lint/4482/console [19:30:30] syntax error, unexpected T_STRING in vendor/psr/log/Psr/Log/LoggerAwareTrait.php on line 8 [19:30:40] so we have to hack the composer installed vendor file? [19:31:15] ...or disable php53 lint [19:32:26] eileen: oh, that first patch will need forcing in any case [19:32:41] maybe roll the deletion in with the next patch? [19:32:48] (PS2) Eileen: Add prospecting custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293793 (https://phabricator.wikimedia.org/T128818) [19:34:12] hmm - the thing is I'm still getting phplint on this one https://gerrit.wikimedia.org/r/#/c/293729/ [19:34:26] which is the one with the fixes for the exceptions [19:34:42] (CR) jenkins-bot: [V: -1] Add prospecting custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293793 (https://phabricator.wikimedia.org/T128818) (owner: Eileen) [19:35:17] oh, is phplint only checking the changed files? that would be sensible [19:35:36] ok, forced 4.7.8 through [19:36:26] cool - I just don't quite have my head around what we need to worry about here [19:36:30] re phplint [19:36:37] ejegg: Jeff_Green eileen Katie and I just talked and she would like to hold on the civi upgrade until we are all back from wikimania [19:36:44] phpoffice/phpword :S [19:36:53] dstrine: o really? [19:37:07] (CR) Aaron Schulz: Add object caching to ChoiceDataProvider (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [19:37:20] yeah, i guess a bunch of stuff shook out in the week or two after the last upgrade [19:37:24] ejegg: yeah eileen will still be here during wikimania but no one will be around to +2 her stuff [19:37:28] dstrine: ok, that makes sense [19:37:35] (PS8) Ori.livneh: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 [19:37:44] shoot, wish i'd heard 3 minutes earlier [19:37:44] I'll send a follow up email [19:37:57] ejegg: it would still be good to get that stuff merged & 'stable' on staging [19:38:06] true [19:38:13] because up til now staging has had 'my' version of the code not an official version [19:38:31] & I've screwed it up several times in rebasing attempts :-) [19:38:32] right, right [19:38:46] so 4.7.9 pulls in some Word2007 parsing php code? [19:39:26] ejegg: hmm - I seem to recall seeing something like that [19:39:32] hopefully we don't have to touch it [19:39:45] PHP Catchable fatal error: Argument 1 passed to Gateway_Form_Mustache::__construct() must be an instance of GatewayAdapter, instance of AdyenGateway given [19:39:48] am i stupid? [19:39:56] blecch... would be nice to not even have that mess on our servers, but meh [19:40:01] cwd what? [19:40:06] is that in prod? [19:40:12] nono [19:40:19] i'm just trying some silly stuff [19:40:24] that is confusing [19:40:32] but adyengateway extens gateway common [19:40:34] so i don't get that error [19:40:45] does not compute [19:47:11] the machines are just spitting out all kinds of nonsense errors today [19:50:29] it's a friday thing [19:58:48] (CR) XenoRyet: [C: 2] Disallow setting contribution tracking ID from request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T137155) (owner: Ejegg) [19:59:08] MBeat: you okay with me running a quick Hungary test? probably only for about 30 mins, and traffic should be low because of the time [19:59:16] just need to sanity check something... [19:59:23] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2372779 (Jgreen) [20:00:42] eileen: do you know what I need to tweak to avoid this error? [20:00:52] Database check failed - the database looks to have been partially upgraded. You may want to reload the database with the backup and try the upgrade process [error] [20:00:55] again [20:02:58] Fundraising-Backlog, FR-Smashpig: IPN listener should be able to update payments_final_status - https://phabricator.wikimedia.org/T137590#2372781 (Ejegg) [20:04:07] sure thing, the-wub [20:04:40] (Merged) jenkins-bot: Disallow setting contribution tracking ID from request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289731 (https://phabricator.wikimedia.org/T137155) (owner: Ejegg) [20:08:56] okay, it's up [20:17:46] thank you for the heads-up [20:24:23] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2372821 (Jgreen) >>! In T135392#2371034, @jrobell wrote: > Thank you @Jgreen for your help on this. Yubikeys for Brent Cohn, Jasmeet Samr... [20:28:21] https://civicrm.org/blog/stoob/introducing-civigoat-the-worlds-first-open-source-grm [20:31:24] eileen: do you know where the upgrade script checks to see if it't been partially updated? I'm getting this error: [20:31:31] Database check failed - the database looks to have been partially upgraded. You may want to reload the database with the backup and try the upgrade process [error] [20:34:27] eileen: did you see my question about the upgrade error? [20:36:48] nvm, found it [20:40:01] eileen: even with the 4.7.9 patches, the upgrade thinks it's going to 4.7.8. any db changes between the point releases we should care about? [20:42:51] okay MBeat, Hungary test is done. sanity seems to be confirmed [20:43:03] good to hear ! [20:43:16] no tickets or weird trxns [20:44:13] yeah it was very quiet, I only see about 21 donations total. then again it is late, and many people are probably watching the football [20:45:47] I'm heading out now. AndyRussG: if you could look at my email and give me a hint where to look by monday that would be much appreciated [20:45:54] have a nice weekend everyone! [20:46:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: Turning on geocoding for proximity searches - https://phabricator.wikimedia.org/T136901#2372857 (DStrine) [20:49:57] the-wub: hi! yeah i did see it :) [20:50:06] thx! [20:50:09] Have a fun weekend :) [21:00:06] (PS3) Eileen: Add prospecting custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293793 (https://phabricator.wikimedia.org/T128818) [21:01:34] ejegg: I kind of tried to hold it back from thinking it was 4.7.9 but excluding that version patch but I'm not sure it worked [21:01:42] but, not much in the upgrade script I don't think [21:01:53] ah, ok [21:02:14] (CR) jenkins-bot: [V: -1] Add prospecting custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293793 (https://phabricator.wikimedia.org/T128818) (owner: Eileen) [21:02:17] i see prod thinks it's 4.6.9 despite us patching it up further [21:02:24] but none of those were db-related, i think [21:02:26] prod? staging? [21:02:35] prod [21:02:40] yeah - there is still something funky in the version of the upgrade script [21:02:46] sorry deployment script [21:02:57] k [21:03:14] we can always manually update civicrm_domain if we want to, i guess [21:03:42] ejegg: the codebase in gerrit is also on staging & when I go to the url civicrm/upgrade it is not trying to run 4.7.9 [21:03:57] should it? [21:04:15] no, the reason I hacked back the 4.7.9 patch was so it wouldn't [21:04:24] so when we put the full 4.7.9 on it will [21:04:31] ok [21:04:35] & we won't risk not running something that is in the 4.7.9 upgrade [21:05:02] the thinking is the civicrm-core repo will always be latest released version of civicrm-core + our patches over the top [21:05:23] cool, i'll retry the script locally as soon as my backup finishes. I guessed at the version it was supposed to be after an aborted attempt, and got another half-finished one [21:05:30] but at the moment I went past 4.7.8 even though not released because we had patches in it [21:05:38] hopefully it'll go smooth with the 'from' version being 4.6.9 [21:06:43] yeah I didn't hit anything around that on staging [21:07:24] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Can we allow fallback to alternative campaign if mixin would hide this on... - https://phabricator.wikimedia.org/T124969#2372894 [21:12:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2372920 (Eileenmcnaughton) @CaitVirtue @RLewis I have added the fields as I understood them on staging in the prospect custom data group. Do you want to take a look? Curr... [21:19:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Set do not trade field to 0 on all contacts - https://phabricator.wikimedia.org/T137588#2372926 (Krenair) [21:21:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make summary fields in contact records more useful - https://phabricator.wikimedia.org/T137568#2372944 (Eileenmcnaughton) Hey Rosie, There are couple of reasons why it is good for tech to add custom fields via script 1) because it means we will have t... [21:36:01] (Abandoned) Eileen: Add script for compiling deployment repo [wikimedia/fundraising/civicrm-core] - https://gerrit.wikimedia.org/r/252376 (https://phabricator.wikimedia.org/T1152925) (owner: Eileen) [21:37:24] am i crazy or do we autoload all the classes twice in donation interface? donationinterface.php and composer autoloader [21:44:39] cwd is it an either/or question? [21:45:34] it looks like they duplicate pretty much all the classes [21:51:59] cwd huh, it used to be just the ones we explicitly mentioned in composer.json [21:54:07] well it lists the gateway directories, so i think it spiders through [22:13:44] (PS15) Ejegg: WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:14:30] (CR) Ejegg: "PS15: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:15:01] (CR) jenkins-bot: [V: -1] WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:15:44] (PS16) Ejegg: WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:16:53] (CR) jenkins-bot: [V: -1] WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:17:11] eileen: argh, still bombing out on Error: Migrate 'on behalf of' information to module_data [22:19:22] (CR) Ejegg: "PS16 updates authors, autoload classes, special pages, hooks, and globals, adds README. TODO: update ResourceLoader modules" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:19:37] man, is that ever tedious ^^^ [22:20:25] eileen: sorry, i can't get 4.7.8 working locally right now, but I'll pick it back up Monday morning [22:20:34] damn [22:22:10] i gotta head out soon. have a good weekend all! [22:23:48] (PS17) Paladox: WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:24:08] (CR) Paladox: "Add "DonationInterface": "DonationInterface.php"," [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:24:36] (PS18) Paladox: WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:25:01] (CR) Paladox: "Actually add "DonationInterface": "DonationInterface.class.php"," [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:25:57] (CR) jenkins-bot: [V: -1] WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:34:54] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Duplicate class loading in DonationInterface - https://phabricator.wikimedia.org/T137602#2373100 (cwdent) [22:35:45] (CR) Paladox: "Not sure why it is failing with https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-non-voting/895/console" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [22:43:57] (PS1) Eileen: WMF adjustments over 4.7.8 branch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293885 [22:45:54] (CR) jenkins-bot: [V: -1] WMF adjustments over 4.7.8 branch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293885 (owner: Eileen) [23:11:37] Fundraising-Backlog, FR-Adyen: bug: Adyen JPY transactions have different amounts in CIVI vs Adyen - https://phabricator.wikimedia.org/T137607#2373181 (MBeat33) [23:29:32] 'aloo my droogs [23:30:05] I'm raring to deploy the new PayPal configuration, should be a safe Friday thing ;) [23:30:22] <_< [23:30:23] >_> [23:31:18] You're trying to see if you can make me jump, aren't you? [23:31:35] brain is squirming like a toad :p [23:32:23] I had a completely different idea of how I was going to spend this afternoon. [23:32:35] Now I'm so far behind I can't even see the front. [23:33:03] Can I do four hours of work in 30 minutes? Maybe! But I probably shouldn't. [23:33:06] What's the crisis du jour? The one I helped with? [23:33:13] (helped create) [23:33:19] It was a factor, yes. :p [23:33:30] Not the only factor. [23:34:27] I also got a great thing over lunch that allowed me to put the final touches on my new desk. [23:34:34] I feel like I'm driving the space station. [23:34:39] I'm so jealous. [23:34:48] I just squat in various positions on outdoor furniture. [23:34:57] I'm dead serious about this config change, though... [23:35:18] Well... if you can't avoid doing it, you're on the hook for all the fallout. [23:35:23] it's a one-line change to an experimental gateway, so I think it's legitimately 50% safe. [23:35:45] heh [23:35:47] The bad part would be if the deployment infrastructure melted everything down and Jeff had to breathe fire [23:36:11] Usually good to avoid. [23:36:19] Yup, I sign up for cleaning the fan and the walls [23:36:34] It'll be fun, what could go wrong... [23:37:14] hehe. [23:37:18] * K4-713 puts on helmet [23:37:28] !log Update PayPal Express Checkout configuration: add API certificate path [23:37:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:37:37] omfg: error: Auto packing the repository for optimum performance. You may also [23:37:48] foul ball [23:38:54] er... [23:39:09] It was just testing my resolve... [23:43:36] fundraising-tech-ops: paypal gateway log messages should be bucketed - https://phabricator.wikimedia.org/T113308#2373234 (awight) Resolved>Open I was wrong about the regex--it should have been "paypal_ec_gateway", not "paypal_express_gateway". [23:49:54] Bunk. malformed URL apparently. [23:50:01] I'll watch the logs and then leave it for Monday [23:56:05] (PS1) Eileen: Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293890 [23:56:07] (PS1) Eileen: WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293891 [23:56:36] (Abandoned) Eileen: WIP try to get test info [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293727 (owner: Eileen) [23:58:09] (CR) jenkins-bot: [V: -1] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293890 (owner: Eileen) [23:58:39] (CR) jenkins-bot: [V: -1] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293891 (owner: Eileen)