[00:01:18] (Abandoned) Eileen: WMF adjustments over 4.7.8 branch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293885 (owner: Eileen) [00:01:43] (Abandoned) Eileen: WMF patch to log source of queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293729 (owner: Eileen) [00:02:00] (Abandoned) Eileen: wmf-sunset-patch alter exception behaviour [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293660 (owner: Eileen) [00:02:38] (Abandoned) Eileen: WMF adjustments over 4.7.8 branch [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293659 (owner: Eileen) [00:23:22] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Running the Donor Summary report it blocks us with an incorrect validation error - https://phabricator.wikimedia.org/T136893#2351334 (Eileenmcnaughton) Open>Resolved [00:44:42] awight: You still around? [00:45:42] K4-713: waat [00:45:46] sorta [00:46:32] Do you know of any way to look and see what an individual contributor has CR'd? [00:46:47] erp [00:46:56] I haven't, but lemme try [00:47:18] yep [00:47:23] https://gerrit.wikimedia.org/r/#/q/reviewer:%22Awight+%253Cawight%2540wikimedia.org%253E%22,n,z [00:47:25] I tried typing some nonsense into gerrit search, and it said we had to enable secondary indexes. [00:47:26] reviewer: [00:47:31] aha! [00:47:41] oh that wasn't quite right [00:47:42] You must have had some better nonsense than mine. [00:47:53] those are patches with reviewer assigned [00:48:10] Aw, raspberries. [00:48:41] https://review.openstack.org/Documentation/user-search.html [00:49:06] doesn't look like it [00:50:08] There should be a way to do this. [00:50:21] * K4-713 is apparently talking to the universe [00:51:46] Oh man. I am now kicking myself for deleting all those gerrit emails. [00:51:52] I could have looked that way. [00:51:56] :[ [00:52:09] aaargh [00:52:16] I might still have them [00:52:20] is there somethign speficif? [00:52:39] cos I can spelll [00:52:47] I just want to find out who gets the gold star for CR this year. [00:52:59] I mean, I think we all have ideas, but I want to be right. [00:53:13] oh. I can't help with that :p [00:53:15] Also want to find out if some people are, you know... never doing it. [00:53:33] They will get the platinum whacking stick. [00:54:03] It's kind of weird, though, isn't it? [00:54:18] I mean, we keep saying that we really want people to be good citizens, and we can't... measure it. [00:55:20] Isn't there an index of gerrit reports already? [00:55:27] Is there? [00:55:37] And by that I mean: Is this on it? [00:56:49] fwiw https://github.com/wikimedia/analytics-gerrit-stats [00:58:10] There it is: https://www.mediawiki.org/wiki/Gerrit/Reports/Code_review_activity [00:59:18] http://koti.kapsi.fi/~federico/crstats/ [00:59:28] lots of code to play with, at the least. [00:59:42] !-3 might be the thing u were looking for [00:59:47] although it's for all time [01:01:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: Turning on geocoding for proximity searches - https://phabricator.wikimedia.org/T136901#2351757 (awight) Some thoughts * Get a zipcode database with appropriate licensing. Might have to buy a subscription. * Hopefully we can hook into large_dona... [01:02:34] awight: Yeah, there might be some stuff I can play with here. [01:04:05] awight: How good has the team been about moving cards around in phab when they complete CR for a card? [01:04:25] On a scale of "Unfailingly Excellent" to "Potato". [01:04:52] Usually, we don't. [01:05:13] it's something we should work out as a team [01:05:13] Boooo potato. [01:05:29] Yeah... it kind of says that we have moved away from the work board. [01:05:35] I don't think so [01:05:44] There are lots of reasons to not move someone else's task. [01:05:58] hmm [01:05:59] I somehow got it in my head that the done thing was to let people move their own cards. [01:06:06] If they move it to "needs review"... [01:06:16] Another issue is that we might have 5 patches for review, come up with a new thing to do and write a patch for, but want to leave the card in review to draw attention to... needing review. [01:06:31] exactly. [01:06:35] we move our own cards [01:06:43] That's... odd. [01:06:47] but it seems rare to move other people's cards, e.g. when you complete the CR [01:07:01] cos we don't always know for certain that we caught all of the patches [01:07:16] gerrit-bot only links patches like 80% of the time D: [01:07:25] So, how do you communicate that someone is currently reviewing a thing? [01:08:05] And... can that be queried? :p [01:08:30] Heh, sometimes I just pick stuff up and do it, others I talk to the person who wrote it. So not really querriable. [01:08:51] +1 [01:08:58] we have no flaggery for that [01:09:12] one moment, I need to pluck some tan bark splinters from the wee knees [01:09:47] I am surprised this data is this hard to get at. [01:09:49] We used to be very good at that. Mostly because Pgehres used to always beat me to the end of a review after I had spent a while looking at it, and I went crazy at all the parallel work. [01:10:04] Like, really crazy. [01:10:30] We don't seem to actually double up much lately, despite not really having a mechanism to prevent it. [01:11:03] Yeah, I mean, if you had this problem, I'd assume there would be a solution in place. [01:11:10] Though our CR meeting on Thursday kind of works towards that and is something we could do more of. [01:11:10] Hmmmm. [01:11:45] Dang, why did I eat those emails. [01:11:50] ...eat? I meant "delete". [01:11:56] * K4-713 frowns [01:11:58] hehe [01:12:12] Most emails have very little nutritional value. [01:12:16] what are these stats for, again? I don't think the metric of how many reviews we each did means anything [01:12:38] Oh... I was looking for things to say for ANNUAL REVIEWS [01:12:46] There it is. [01:12:49] oh fack [01:13:01] But... you know, could be useful things to say all the time. [01:13:20] I was about to say someone was a CR powerhouse, and then I thought: "Can I prove that?" [01:15:26] Anyway, I gotta go tag in on toddler patrol. I'll catch you folks later. [01:15:34] see ya Monday! [01:15:50] See ya then [01:16:10] XenoRyet|afk: Later! [01:31:53] eileen: go "home"! [01:32:10] It was great to see you yesterday, thanks again for swinging through town [03:26:08] K4-713: yeah sucky you were here same week not same day! [04:51:10] (PS1) Cdentinger: [DO NOT MERGE] mediawikiless-donationinterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293895 [05:02:40] (PS2) Cdentinger: [DO NOT MERGE] mediawikiless-donationinterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293895 [18:13:09] (PS1) Ori.livneh: Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 [18:13:28] (CR) jenkins-bot: [V: -1] Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (owner: Ori.livneh) [18:14:31] (PS2) Ori.livneh: Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 [18:15:48] (PS3) Ori.livneh: Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911