[08:21:13] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2375378 (jrobell) Thank you @Jgreen I added email addresses for Brent's two co-workers to the bottom of the collab page https://collab.... [15:09:06] Fundraising Tech Backlog: Spike on Apple Pay - https://phabricator.wikimedia.org/T137714#2376306 (Ppena) [15:25:26] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Add autocomplete hints to donation form - https://phabricator.wikimedia.org/T137716#2376378 (Ejegg) [15:25:40] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Add autocomplete hints to donation form - https://phabricator.wikimedia.org/T137716#2376391 (Ejegg) p:Triage>Low [15:26:06] (PS2) Ejegg: Add autocomplete hints to personal info form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293681 (https://phabricator.wikimedia.org/T137716) [15:27:24] good morning ejegg after the tests last week, fr-online is wondering if we are good to turn on israel with adyen. [15:27:30] ah guest :( [15:27:38] hi dstrine! [15:27:56] hi [15:28:03] Yes, we should be fine to turn it on! [15:28:14] sweet! [15:28:30] at least we got one of these done. [15:28:34] :) [15:38:21] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 5 others: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2376475 (Ejegg) Ope... [15:39:54] (PS6) Ejegg: Actually block if flagged on GatewayReady [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292970 (https://phabricator.wikimedia.org/T137374) [16:14:42] Right. I was in the middle of Friday deploying config changes to paymentswiki. [16:14:52] I'm seeing mysterious errors from PP EC [16:19:59] cool, I can reproduce it locally [16:23:56] (PS1) Awight: Fix name of the URL accessor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294082 [16:23:59] easy CR... ^ [16:25:31] ejegg: Bit myself with that refactor! [16:25:47] ooh, lemme look [16:25:53] thanks! [16:31:00] cwd: fwiw I have a conflicting meeting for the first half of fr tech talk, but will switch back at 10:30 [16:31:42] heh, i have a 1 on 1 with K4 at 10:30 [16:31:53] also fr standup is at 10pst [16:32:16] but i guess that's what optional attendance is for [16:32:22] d'oh [16:32:34] yah it's the standup that got me [16:34:09] awight: https://gerrit.wikimedia.org/r/#/c/293895/ [16:34:14] Jeff_Green: Thanks for tying up all my loose ends! It's looking good so far, I think I'll have everything I need to pursue the new PayPal integration for a while [16:34:24] cwd: whoa [16:34:29] awight: great [16:35:15] cwd: Seems like you'd want to create a new WmfFramework.standalone ? [16:35:22] awight: it's silly, but i think this project may not be that absurdly big [16:35:32] hmm, i don't know about that [16:35:34] it is... [16:35:38] awight: i thought of a potential issue for moving other config to the localsettings repo [16:35:58] we use mw for request stuff but that is pretty easy [16:36:00] (CR) Ejegg: [C: 2] "consistent!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294082 (owner: Awight) [16:36:05] cwd: Feel free, of course, to make or elaborate tasks that might push us in the right direction! [16:36:21] cwd: yah, Symfony\HttpThing [16:36:27] yeah [16:36:29] Jeff_Green: uh, oh [16:36:41] ejegg: thanks! [16:36:50] translate...i think we could wedge something in that can read the translations [16:36:50] right now, we send some of the code out to servers without payments config [16:37:11] cwd: my suggestion is to plan the work without like... doing it, though. [16:37:21] for example we wanted smashpig libraries on the civi and qa server, but we don't necessarily want all the same configuration there [16:37:32] yeah, this is just a scoping exercise [16:37:47] moving code into the tree means every host gets all config, and all the same config [16:37:49] Jeff_Green: It's gross, but I think we're able to deploy the same configuration everywhere, actually [16:38:22] Jeff_Green: SmashPig has its own baroque system for doing config overrides depending on what we're doing with it. [16:38:41] cwd: I think it's awesome. [16:38:49] awight: ok. we just need to be aware of any situation where we might i.e. expose payment provider credentials to contractors [16:38:56] gurp [16:39:17] (Merged) jenkins-bot: Fix name of the URL accessor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294082 (owner: Awight) [16:40:36] i was able to get a form out of DI in one afternoon which is better than i thought it'd be. the devil's in the details of course but whatever happens looking at it from the bottom up is enlightening [16:40:41] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/294084 [16:41:16] Jeff_Green: Good point. The Civi host will need payments creds [16:41:38] civi host yes, lutetium...probably not [16:41:48] and or lutetieum/testing credentials instead [16:41:49] +1 [16:42:11] it's all workable even with the localsettings, worst case we need yet another checkout aka project [16:42:40] yeah, the plucking is all done with puppet IIRC, so that seems plenty flexible [16:43:12] now yes, but we're talking about undoing that right? [16:43:37] cwd: Totally valuable exercise! I'm thrilled by how few things needed a tweak [16:43:47] Jeff_Green: mmm? I thought that was still the plan [16:44:01] * awight squints at https://etherpad.wikimedia.org/p/Fundraising_configuration [16:44:34] i thought we haven't fully decided either way, or in any case where is the proper place for the line between puppet vs localsettings [16:44:35] I see puppet commit->puppet run->code deploy [16:45:40] it does seem squirrely, but I'm comfortable with what I thought was the consensus, that we have secrets stored in a private repo, and puppet squeezes those through a config file template. Then, the semiprivate localsettings repo gets checked out and puppet tweezes entire files from there [16:46:20] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/294084 (owner: Awight) [16:48:17] (PS1) Awight: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/294086 [16:48:38] (CR) Awight: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/294086 (owner: Awight) [16:48:52] awight: the distinction I guess would be that the secrets/config gets populated to the node itself, and the config templates would to parse it at runtime [16:49:57] I hadn't thought of that one. Is there an advantage? Less of a tangle in fundraising_code_update? [16:50:56] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/294084 (owner: Awight) [16:51:11] it's the only way puppet creates node-specific config [16:52:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2376690 (RLewis) @Eileenmcnaughton, @CaitVirtue the fields added look ok and are what we requested. We don't however have a sense of what the output of the report would... [16:52:56] hrm. I see what you mean, we'd have to render multiple files to do it the first way. [16:53:21] right, puppet would render a file on boron that's appropriate for node=boron [16:53:49] I can't think of a case where we want to install node-specific config or any cases of conflicting roles, though. [16:54:06] Which feels sort of surprising. [16:54:36] You're saying that the SmashPig config is still node-specific? [16:55:01] awight: it might not be an issue, but when I started looking at ripping apart that manifest in puppet (tools.pp) and moving things into localsettings, I realized puppet is already deploying different versions of some files. [16:55:23] yeah, not sure about SmashPig specifically, but I have notes from friday when I noticed this, somewhere.... [16:55:55] I'd be happy to look at yr notes when they surface... and thanks for noticing this glitch, of course! [16:56:38] awight, examples: [16:56:50] privchan? [16:56:53] (civicrm)dedupe.yaml vs (fundraising_qa) dedupe.yaml [16:57:00] (ok n.p.) [16:57:06] nah, it's nothing sensitive afaict [16:57:18] Jeff_Green: that one is a deprecated script, we should stop the cron job... [16:57:22] same for legacy_paypal_config.yaml [16:57:34] and drupal.settings.php [16:57:38] and... uh [16:58:11] I see... I hadn't considered deployments to staging... [16:58:26] me either, had totally forgotten we do that [16:58:33] i'm not sure we even use them anymore [16:58:36] I have meetings for an hour, one moment please [16:58:45] * awight sticks head in warm, quiet sand [16:59:01] sure, there's no rush to sort this out, just a thing I noticed and thought we should get on our radr [16:59:41] * cwd can't decide which meeting to go to [16:59:51] maybe we should not have the new one on mondays [17:00:17] although it is probably valuable after the weekend [17:00:19] cwd if there is a conflict, they cancel eachother out and you have no meetings [17:00:48] I have an antimeeting with the antipope [17:02:02] Jeff_Green: that's sorta what i was thinking... [17:02:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make summary fields in contact records more useful - https://phabricator.wikimedia.org/T137568#2376703 (RLewis) @Eileenmcnaughton this makes total sense and thanks for the explanation. Going forward @LeanneS and I will come up with a list of what fiel... [17:02:27] ejegg: over antipasta? [17:02:33] hehe [17:03:48] Jeff_Green: The unattainable ideal I guess, would be that the private config gets installed as its own file, and this is a thing puppet is optimized to do. Then, there's shared configuration that we install via the localsettings mechanism. Staging might have some more overrides, not sure how those go out. [17:03:51] i'm up for mtg if anyone has stuff to discuss, but i don't have anything for the agenda myself [17:05:37] i'll hop in [17:05:45] cwd: just paste the minutes link here when you get the chance... [17:07:35] I guess it's still https://etherpad.wikimedia.org/p/fr-tech-talk ? [17:07:48] yeah let's just use the one [17:17:11] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: bug: Adyen JPY transactions have different amounts in CIVI vs Adyen - https://phabricator.wikimedia.org/T137607#2376751 (DStrine) p:Triage>Normal [17:24:51] dstrine: I'm not good at keeping my cards hidden ;) [17:25:24] this is why I'm here to translate :) [17:25:26] Hey, tech talk is empty but I see an agenda [17:25:30] hehe [17:26:42] k then... I'm gonna deploy the payments fix [17:28:43] awight: meeting overload [17:33:20] Jeff_Green: are you going to this tech meeting or do you have some time to chat about external civi users? [17:33:38] yeah, i was just going through the process of logging in... [17:33:50] cwd: Good idea to quit it before the point of diminishing returns, though [17:34:06] dstrine? do we even need a meeting? can i just get a list? [17:34:59] the list hasn't changed and is current on collab. This was a meeting that I set up a while before you had your system in place. If you feel that works for external users too then we can cancel [17:35:50] sure. iirc the main point of the meeting was to make sure we actually disable accounts for users who no longer need them [17:35:55] !log update paymentswiki from 63fbe39fbc4d671fd2705ce9e42762b7c49564c2 to 44102c59ac897c9acab470bf83369d233f9b736f [17:35:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:36:25] ok well let's cancel then. No one has left engage since our last conversation [17:36:37] ok [17:40:42] Fundraising Tech Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#2376891 (awight) [17:44:57] Fundraising-Backlog, FR-Adyen: Make Adyen default gateway for Israel - https://phabricator.wikimedia.org/T137731#2376911 (Pcoombe) [17:45:23] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Make Adyen default gateway for Israel - https://phabricator.wikimedia.org/T137731#2376925 (Pcoombe) p:Triage>High [17:47:44] !log Whitelist Special:PaypalExpressGatewayResult [17:47:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:49:29] Fundraising Tech Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#2376934 (Ellis) [17:49:43] fr-tech: Heads up, this Express Checkout message might require pipeline plunging in just a minute... [17:56:24] There's the failmail. [17:57:55] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Unplanned-Sprint-Work: Spike: Ask integration support about "Completed" status in donor console - https://phabricator.wikimedia.org/T137732#2376963 (awight) [17:58:11] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#2376976 (awight) [18:02:02] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Unplanned-Sprint-Work: Spike: Investigate premature transaction completion - https://phabricator.wikimedia.org/T137732#2376984 (awight) p:Triage>High [18:09:50] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#1679603 (DStrine) @RLewis @LeanneS and I created a prototype on staging: https://civicrm.frdev.wikimedia.org/civicrm/report/instance/94?reset=1&output=criteria Let's continue to talk about this... [18:10:22] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Unplanned-Sprint-Work: Spike: Investigate premature transaction completion - https://phabricator.wikimedia.org/T137732#2377017 (awight) Open>Invalid Whew! This was invalid, I'm off by one in my testing.... [18:12:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-PayPal-ExpressCheckout: Damaged queue messages missing from Drupal interface - https://phabricator.wikimedia.org/T137735#2377032 (awight) [18:23:30] i don't understand this error: https://integration.wikimedia.org/ci/job/mediawiki-phpunit-php53/555/console [18:23:36] why is it trying to install net_smtp? [18:24:10] local composer install does not do that [18:24:10] must be part of the mediawiki composer deps [18:24:22] oh it doesn't? [18:24:24] it doesn't seem to be... [18:24:26] hmm [18:24:38] noplace in the chain? [18:24:50] grep smtp comes up with nothing [18:24:57] after composer install even [18:25:09] then i'm stumped... [18:25:09] i would think it'd at least be in installed.json? [18:37:04] cwd: wow, the PHP 5.5 noose is really tightening around us quickly [18:37:57] i don't understand this one. i am trying to get composer to tell me what that's a dependency of [18:38:32] This part looks correct, 00:00:07.915 DEBUG:zuul.Cloner:Fetched ref refs/zuul/fundraising/REL1_26/Z1204d23766e047a1b386bb47d4081d45 from mediawiki/core [18:43:16] cwd: Can you get that info by logging into the integration node? [18:43:34] yeah i'm poking around there now [18:44:48] cwd: FWIW, https://github.com/wikimedia/integration-jenkins/blob/master/bin/mw-fetch-composer-dev.sh [18:45:23] gothic [18:46:08] hmm interesting, it's in .lock on the CI host [18:46:17] ooh [18:46:25] could be cross-test contamination? [18:47:40] it's the same test we run against currently [18:49:59] cwd: here are the dependencies, https://packagist.org/packages/pear/net_smtp [18:50:15] cwd: oh psych, I misread that. [18:50:43] * awight continues to be disappointe by anything PHP [18:51:13] WTH. https://packagist.org/packages/pear/net_smtp/dependents [18:51:25] https://packagist.org/packages/pear/net_smtp/suggesters [18:51:49] * awight scratches hindquarters [18:51:54] ya... There is no installed package depending on "pear/net_smtp" [18:52:01] from the CI host [18:52:06] maybe it's a virus ;) [18:53:30] net_smtp...maybe it's like seti@home, but for spam [18:55:34] * awight invests via bitcoin [18:55:47] oh, i wonder if that xargs thing slurps up suggests as well as requires [18:55:52] sounds like an hustle whose time as come [18:56:09] hehe [18:56:17] contributing to the adnetwork superintelligence [18:56:44] https://github.com/wikimedia/integration-jenkins/blob/master/tools/composer-dev-args.js [18:57:15] Dare I ask why we're reinventing composer install... [18:57:51] suddently, nodejs [18:57:54] This is the tragic phase that every standard library integration goes through [18:58:07] ... where every little thing becomes a gigantic shim to keep us using the standard [18:58:19] * awight fears a summons [18:58:33] hehe lemme try that again. "that goddamn composer install" [18:58:45] it's shims all the way down [18:58:59] I actually did see the bamboo scaffolding, by the way. [18:59:03] It's not apocryphal. [18:59:36] In HK and in CN, there were pretty hefty buildings, 8 stories and such, being renovated via bamboo platforms [19:00:00] yikes [19:01:07] i was reading about the wooden boxes upon which the brooklyn bridge sits the other day [19:01:11] that is one hell of a thing [19:01:43] http://scaffoldage.tumblr.com/ [19:01:48] ohwhoa [19:02:04] but it's... stone. [19:02:20] Those must be serious old-growth boxes. fwd? [19:02:43] http://history1800s.about.com/od/bridgebuilding/ig/Images-of-the-Brooklyn-Bridge/Brooklyn-Bridge-s-Caisson.htm [19:02:49] it's totally insane [19:03:03] i wonder if they are still accessible... [19:04:14] they don't mention in there, but they never hit bedrock on the new york side [19:04:22] it's sitting on sand still [19:04:38] it sounds like they filled them with concrete though? [19:04:51] so once side is a giant concrete foot on sand? fancy [19:05:06] oh, i missed that part [19:05:10] darn [19:05:21] it's insane either way [19:05:42] the idea that people were able to pull that off...insane [19:05:58] yeah, with no power tools or flashlights [19:07:05] this scaffolding site evokes similar feelings [19:07:25] totally [19:08:01] http://67.media.tumblr.com/e62b941337dde2b67099635b638d7b9b/tumblr_mjwrwtdmTp1qhie3ho1_500.jpg [19:08:04] careful with that torch! [19:08:15] "A month after his plans were accepted, while examining locations for the Brooklyn tower site, Roebling’s foot was crushed on a pier by a ferry. Roebling died 17 days later from tetanus." [19:08:40] oops! Looks like you got this one, Jr. [19:08:54] jr gets the bends [19:08:59] has there not been a drama made about this? [19:09:33] starring leonardo decaprio as the son, with an intolerably bad brooklyn acces [19:09:39] accent [19:10:34] "By taking soil samples he discovered that the soil hadn’t shifted in millions of years" [until they placed a really heavy thing right on top of it] [19:12:25] this makes me think of the whole thread about what happens if NYC (or SF for that matter) loses power for a year, about how much of these cities is based on continual bailing of groundwater [19:15:11] when sparkfun built their new $12m building it was on an underground river and would flood of the pumps go out. "that will never happen, there's a backup generator." happened immediately. [19:15:44] ha oops [19:17:54] awight: this task is not high priority for this week: https://phabricator.wikimedia.org/T88460 [19:18:08] I was merely following up with them and got more info on the task [19:18:21] They are cool with it happening later [19:19:22] AndyRussG: how's it going? [19:19:29] dstrine: ok sure, shall we punt until after Wikimania? [19:19:57] yeah for sure. they are not blocked [19:20:23] dstrine: aaaarrgh!!! [19:20:27] ;p [19:20:29] yourself? [19:20:29] done, thanks for the note! [19:22:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2377255 (LeanneS) [19:22:10] awight: you might see a lot of activity between Rosie and me on old phab tasks. It's the current pile of stuff I am churning through/updating. It seems like there are quite a few things they can solve on their own and it will help me learn civi more. Also I'm going to make sure they are writing better, more actionable bugs . [19:23:06] dstrine: great to hear, have fun and feel free to ping us! [19:23:52] PPena: What do you think about PayPal legacy and express checkout being reconciled separately? Is that helpful, or a pain? [19:24:55] dstrine: was there anything more specific? [19:25:10] AndyRussG: sorry just got distracted will ping you in a second [19:25:18] dstrine: k! [19:26:49] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Spike: Decide whether PayPal Express Checkout is a new gateway, payment method, or account name. - https://phabricator.wikimedia.org/T134452#2377273 (awight) @PPena... [19:28:12] awight: hashar pointed out, it's not finding the vendor branch and falling back to master [19:28:28] dstrine: when you have a moment, want to sync up with me about PayPal EC? I'm through the "feasibility" goalposts and wondering how to prioritize [19:28:37] cwd: excellent, glad there's a way forward [19:29:06] I suppose we should create a vendor branch, then? [19:31:12] yeah i think so [19:32:48] ok we had a fundraising/REL1_25 branch and it looks like that's what we deploy from [19:33:01] (CR) Cdentinger: "recheck" [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (https://phabricator.wikimedia.org/T137213) (owner: Cdentinger) [19:33:45] awight: yep, i just made fundraising/REL1_26 from regular REL1_26 [19:34:34] cool. then += a few weird things maybe [19:34:59] probably [19:35:06] the 1.25 branch adds monolog, not sure why we needed to do it that way [19:35:37] oh. cos of my payments.error fatal exception stuff [19:35:38] might add yaml too... [19:35:48] what uses that? [19:36:04] oh nm i'm thinking DI [19:36:47] The tricky part I suppose is that core require:monolog needs to be the same version as DI's. Which is entirely silly. [19:37:08] (CR) Cdentinger: [C: 2] "re+2 cause this runs diff tests on gate+submit" [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (https://phabricator.wikimedia.org/T137213) (owner: Cdentinger) [19:37:10] again: let's use a standard and then configure it in a non-standard way [19:37:43] yeah that is hrmmmmm [19:38:16] it would be happier if composer pulled in the DI dependencies and resolved version compatibility in there [19:38:22] mw-core composer, that is. [19:38:48] I vaguely understand that's what composer-merge-plugin does, but I haven't homeworked on it yet [19:38:53] yeah since extensions depend on mw it does seem like there could be a compile step [19:38:59] ah yeah that thing [19:44:18] (Merged) jenkins-bot: Make fundraising/REL1_26 branch [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/293158 (https://phabricator.wikimedia.org/T137213) (owner: Cdentinger) [19:48:45] awight: I was on a random phone call. Let's chat after standup? [19:48:57] AndyRussG: I'll ask my questions and standup too [19:49:02] dstrine: sure! [19:49:22] dstrine: K [19:49:25] :) [19:51:00] oh damn looks like that did it [19:54:13] cwd: nice one! [19:57:09] (PS19) Ejegg: Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [19:57:23] ^^^ now passing tests locally! [19:59:20] (CR) jenkins-bot: [V: -1] Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [20:00:04] futuristic! [20:00:55] d'oh [20:01:53] (PS20) Ejegg: Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [20:02:02] oops, left a trailing comma [20:03:31] (PS21) Ejegg: Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [20:08:41] (CR) Awight: Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [20:14:01] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: bug: Adyen JPY transactions have different amounts in CIVI vs Adyen - https://phabricator.wikimedia.org/T137607#2377401 (XenoRyet) a:XenoRyet [20:36:38] https://i.ytimg.com/vi/G7dTDr803Bo/maxresdefault.jpg [20:38:01] ejegg: I see http://www.w3schools.com/tags/att_input_autocomplete.asp [20:38:08] It says the attribute can be "on" or "off"... [20:38:58] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, MediaWiki-extensions-DonationInterface, Epic: [Epic] Support PayPal Express Checkout NVP API - https://phabricator.wikimedia.org/T130843#2377447 (awight) [20:39:00] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 4 others: Get Express Checkout production credentials - https://phabricator.wikimedia.org/T131806#2179067 (awight) Open>Resolved [20:44:17] then again, https://developers.google.com/web/updates/2015/06/checkout-faster-with-autofill?hl=en [20:49:13] (PS1) Awight: Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) [20:51:22] (CR) jenkins-bot: [V: -1] Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [20:52:14] awight: it's in the whatwg 'living standard', but it's got pretty wide browser support: https://html.spec.whatwg.org/multipage/forms.html#autofill [20:52:52] hmm, wait, lemme see [20:53:46] "When wearing the autofill expectation mantle" *chuckle* [20:54:15] hehe [20:55:05] wait, lemme make sure I'm using the right hints for address lines [20:55:21] Fundraising-Backlog: Argentina donation form: update 'Santander' button to say 'bank transfer' - https://phabricator.wikimedia.org/T137746#2377490 (MBeat33) [20:55:35] Can't wait to move to "name". [20:55:47] I don't even like f/l name in English [20:55:50] Fundraising-Backlog: Argentina donation form: update 'Santander' button to say 'bank transfer' - https://phabricator.wikimedia.org/T137746#2377502 (MBeat33) p:Triage>Normal [20:56:43] (CR) Awight: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [21:00:12] ah, also supposed to work for select elements [21:01:04] (PS2) Awight: Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) [21:01:34] (CR) Hashar: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293895 (owner: Cdentinger) [21:02:37] (PS3) Awight: Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) [21:04:38] (CR) jenkins-bot: [V: -1] Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [21:05:12] (PS3) Ejegg: Add autocomplete hints to personal info form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293681 (https://phabricator.wikimedia.org/T137716) [21:06:29] (CR) jenkins-bot: [V: -1] Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [21:06:38] (PS4) Awight: Add autocomplete hints to personal info form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293681 (https://phabricator.wikimedia.org/T137716) (owner: Ejegg) [21:07:06] (CR) Awight: [C: 2] "Works as advertised. Great find!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293681 (https://phabricator.wikimedia.org/T137716) (owner: Ejegg) [21:09:14] (CR) Awight: "I'll review and probably merge to master--we don't expect to deploy anything but cherry-pickable patches to the deployment branch for the " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [21:10:56] (Merged) jenkins-bot: Add autocomplete hints to personal info form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293681 (https://phabricator.wikimedia.org/T137716) (owner: Ejegg) [21:12:34] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-WMF-Audit: Update audit parser for PayPal Express Checkout - https://phabricator.wikimedia.org/T134605#2377554 (awight) Note that the gateway should be set to "paypal_ec". [21:13:14] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2377555 (awight) Note that the gateway should be set to "paypal_ec" for Express Checkout transactions. [21:14:30] (CR) Awight: Convert DonationInterface to extension registration (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [21:16:37] (CR) Awight: Convert DonationInterface to extension registration (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [21:20:38] (CR) Awight: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [21:21:04] sudo rm -rf /mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm [21:21:34] * awight clenches teeth harder on bowie knife [21:22:41] no love [21:28:53] This problem started June 9, it seems [21:29:19] awight: argh, my fault [21:29:42] I forced 4.7.8 through, then left it busted [21:29:57] why did i decide we needed a fundraising/REL1_26 vendor branch? [21:30:11] I guess I should just revert that huge 4.7.8 patch [21:30:49] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CRM CI is broken - https://phabricator.wikimedia.org/T137750#2377629 (awight) [21:32:26] ejegg: aha! [21:33:02] cwd: Wasn't it because it's the only way zuul-cloner will build composer update without coming into conflict with the future? [21:34:34] ejegg: ooh, so CI uses civicrm#master [21:34:55] oh dang.... [21:35:00] Was that to deploy to staging? [21:35:16] cos we can do that by using sandbox branches or git pulling exact refs... [21:35:18] that was when we thought we were upgrading prod tonight [21:35:32] oops, sorry about the balk! [21:35:44] That whole incident was unfortunate [21:35:53] then i kept hitting a snag upgrading locally, and K4-713 made a very sensible decision to delay till after mania [21:35:59] It would have been a fun deploy... it wouldn't have been... [21:36:36] * K4-713 whispers "nooooooo" [21:36:36] i was reluctant to immediately revert such a huge patch, too, coz git bloat [21:36:50] hehe [21:37:06] lessee. All I want to do is deploy a one-liner to crm [21:37:20] I could review that on a feature branch, then cherry-pick to deployment... [21:37:58] ahh, and b/c it's not merging to master, cloner won't name-match civicrm master? [21:38:31] hmm. good point, CI is just broken [21:39:06] urf... lemme see how much more needs to be shoved thru to make 4.7.8 pass tests again [21:39:18] oh right, there's an email [21:40:04] We won't lose anything by just postponing that work on a branch, would we? [21:41:12] nah, would that be the way to go? [21:41:26] We're planning to leave production on the current version of Civi for a few weeks, so a revert seems prudent [21:41:41] true. ok, will do [21:42:10] I'll grab and push to a feature branch... [21:43:16] ejegg: also, wanna CR my gateway patch at your leisure? https://gerrit.wikimedia.org/r/#/c/294123/ [21:43:50] (PS1) Ejegg: Revert "CiviCRM 4.7.8 core code" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294176 [21:43:55] awight: sure [21:45:55] ejegg: I'm also creating a crm# feature branch for messing with the upgrade [21:46:02] we can bump the submodule pointer there [21:46:08] awight: your patch seems safe & easy. Do you want to look at the revert, or should I just self-merge? [21:46:53] (CR) Awight: [C: 2] "/me throws a scoop of dirt on the shallow grave." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294176 (owner: Ejegg) [21:47:56] ejegg: hmm. okay so I've created a branch #4.7.8-wmf_dev on crm and civicrm, sort of a silly move. but we can continue hacking the tests there, at least. [21:48:26] (PS1) Awight: Set gerrit feature branch pointer [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294178 [21:49:00] thanks! [21:49:08] (CR) Awight: [C: 2] "self-merging git metadata" [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294178 (owner: Awight) [21:49:21] (CR) Ejegg: [C: 2] Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [21:49:23] (Merged) jenkins-bot: Revert "CiviCRM 4.7.8 core code" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294176 (owner: Ejegg) [21:49:33] I'll change the task to reflect the non-urgency :) [21:50:32] (PS2) Cdentinger: Adyen signature StagingHelper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293458 (https://phabricator.wikimedia.org/T137157) (owner: Ejegg) [21:51:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix CI failures on CiviCRM 4.7 feature branch - https://phabricator.wikimedia.org/T137750#2377721 (awight) p:Unbreak!>Normal [21:51:13] (CR) jenkins-bot: [V: -1] Set gerrit feature branch pointer [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294178 (owner: Awight) [21:51:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix CI failures on CiviCRM 4.7 feature branch - https://phabricator.wikimedia.org/T137750#2377629 (awight) [21:51:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare 4.7 CiviCRM branch & clean our patches into it - https://phabricator.wikimedia.org/T136252#2377729 (awight) [21:57:29] (CR) Ori.livneh: "AndyRussG, ping" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [21:58:37] (Merged) jenkins-bot: Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294123 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [21:59:57] Jeff_Green: Thank you! [22:00:13] Jeff_Green: erm, oops. Thank you for everything. but ejegg: Thanks again! [22:00:33] je != ej [22:03:43] heh [22:05:30] (PS1) Awight: Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/294181 (https://phabricator.wikimedia.org/T134452) [22:06:08] FYI we are going to have a broken non-voting test for a little while: https://integration.wikimedia.org/ci/job/mwext-donationinterfacecore-REL1_26-testextension-zend53/5/console [22:06:28] Going for the cherry-pick, although the rest of the crm patches look sort of benign [22:06:51] falling back to the wrong branch, there's some jjb config waiting to go out, but it's late in france [22:07:12] cwd: wow, you already have a fix? Cool! [22:07:25] Thanks for playing global shield for now [22:07:33] https://gerrit.wikimedia.org/r/#/c/294173/ [22:07:48] yeah of course [22:07:49] (CR) Awight: [C: 2] Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/294181 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [22:08:01] i am thinking we don't need to cut fundraising branches for every last submodule [22:08:06] (Merged) jenkins-bot: Express Checkout is recorded as PayPal [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/294181 (https://phabricator.wikimedia.org/T134452) (owner: Awight) [22:08:13] in fact it's probably better for everyone if we don't [22:08:22] hehe CI CI itself has a non-voting failure, too [22:08:33] yeah [22:08:54] antoine was helping me but he had to crash [22:09:19] i feel like i have deployed CI changes from my laptop but it was a long time ago... [22:09:37] and i'm not super psyched on breaking CI [22:09:52] Those jjbs get uploaded directly to Jenkins, IIRC [22:10:07] yeah I think I did it once successfully, then decided I never needed to go to that place again [22:10:23] hehe [22:11:30] it seems simple until to get close up and realize it's inherently super complicated [22:11:39] !log Updating fundraising CRM from b7b46740d701942507dca0a98a75f3f87b6b31b1 to e684b7823e751558772a4de4ac23819bc601eb74 [22:11:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:20:20] That's very bad. Duplicate contributions are coming in, cos the listener doesn't know about EC yet. [22:24:08] i'm confused. because of the gateway name? [22:25:08] I think so, yeah. There's a transaction PAYPAL_EC X.. from DonationInterface, then a PAYPAL X.. from the listener [22:31:12] cwd: ejegg|afk: Reverting my CRM patch, fyi. I'd rather get a failmail than record duplicate contributions... [22:31:22] (PS1) Awight: Revert "Express Checkout is recorded as PayPal" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/294183 [22:31:35] (CR) Awight: [C: 2] "Self-merging revert" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/294183 (owner: Awight) [22:32:32] ooh, that's no good [22:33:11] It's a whole world of pain I overlooked when trying to reason about the gateway vs account thing [22:35:29] do you have to tell them to include the new gateway name with the message? [22:35:29] The legacy PayPal listener doesn't even log... [22:35:43] (Merged) jenkins-bot: Revert "Express Checkout is recorded as PayPal" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/294183 (owner: Awight) [22:35:50] that's the thing--I'm not sure that's possible yet. Without some horrific custom data side-channel [22:36:19] !log update fundraising CRM revert from e684b7823e751558772a4de4ac23819bc601eb74 to bb9bf136dc0fa82d5d07ebeb33d696e54672b2d6 [22:36:26] because it's the same account... [22:36:57] Yeah, I don't think PP send us any information we could use to distinguish... and of course, no logging :) [22:37:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:37:38] this listener is sufficiently zealous as to create another contribution even though it has no data from the front end? [22:38:47] (PS1) Ejegg: Default to Adyen in Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294185 (https://phabricator.wikimedia.org/T137731) [22:44:57] ejegg: ^ That ready to go? I'll take a look if it is. [22:44:58] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, Patch-For-Review: Make Adyen default gateway for Israel - https://phabricator.wikimedia.org/T137731#2376911 (Ejegg) Hi @Pcoombe, I've got a patch to update the form settings to make Adyen the default for Israel. I split the f... [22:46:22] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, and 2 others: Make Adyen default gateway for Israel - https://phabricator.wikimedia.org/T137731#2377857 (Ejegg) a:Ejegg [22:47:21] thanks XenoRyet , that would be great! [22:47:29] Yea, no worries. [22:47:54] cwd i think the paypal IPNs arrive with all the donor info, since we don't collect anything locally [22:48:37] awight: pending db! [22:49:47] ejegg: that sounds right to me [22:50:20] we should do *something* to see if it's correlated with any donor activity at all [22:50:21] or.... wait, how do we associate pp contributions with utm_source etc? [22:50:37] hrm yeah, seems like it would be in ct? [22:50:52] oh right, we just write that and send it off [22:51:29] (CR) Cdentinger: [C: 2] Adyen signature StagingHelper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293458 (https://phabricator.wikimedia.org/T137157) (owner: Ejegg) [22:51:59] do we send that off with them somehow? return url param? [22:52:41] so a hack is definitely possible to check ct in the queue consumer and ignore source=listener + ct gateway=ec as duplicates [22:52:51] but that is a disgusting idea [22:53:13] cwd we send some kind of merchant reference, i think ct id [22:53:17] heuristics are solutions too! [22:53:22] (Merged) jenkins-bot: Adyen signature StagingHelper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293458 (https://phabricator.wikimedia.org/T137157) (owner: Ejegg) [22:54:05] cwd thanks! exciting to see that 1.26 test running, even if it's red right now [22:54:17] hehe [22:54:39] yeah...will get that all sorted out tomorrow [22:54:52] There might be a field that tells us if it's a one-time express checkout transaction, but doesn't seem to work for recurring charges... [22:55:26] wouldn't it be prudent for the listener to not insert another contribution if there is already one associated with the ct_id? [22:55:40] The pending queue would help us with the recurring case... [22:56:27] cwd: I think that would work. But it's distasteful ;) [22:56:47] it's cheesy, but a last line of defense [22:57:10] (CR) XenoRyet: [C: 2] Default to Adyen in Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294185 (https://phabricator.wikimedia.org/T137731) (owner: Ejegg) [22:57:48] There you go ejegg, looks good. [22:57:52] thanks XenoRyet ! [22:58:03] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout, and 2 others: Spike: Decide whether PayPal Express Checkout is a new gateway, payment method, or account name. - https://phabricator.wikimedia.org/T134452#2266003 (awight) Back on... [22:58:06] No worries, I know you were trying to get that out today. [22:58:09] ejegg: we could actually fix that test right now by making fundraising/REL1_26 branches for all the extensions [22:58:15] cwd the listener shouldn't do any db queries [22:58:32] cwd: It's not many extensions, that's not so bad [22:58:42] ok, i'll put those in [22:58:45] err, i guess except for the pending db :S [22:58:50] (Merged) jenkins-bot: Default to Adyen in Israel [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294185 (https://phabricator.wikimedia.org/T137731) (owner: Ejegg) [22:59:35] ejegg: I think we're in the horrific practice of doing a db query from the audit and listener code, to test for duplicates. [22:59:59] you mean that's the best solution for now? [23:00:11] or the freakazoid pp listener is already doing that? [23:00:29] pp listener is not doing that actually [23:00:42] and I don't think it should be a best practice [23:00:43] why not do it at the queue consumer? [23:00:57] it's already doing some things [23:00:58] and also, I don't think it would solve the problem here [23:01:13] Agreed, I want to move towards all the information flowing into the queue consumers. [23:01:27] awight: contribution tracking record has the correct gateway, right? [23:01:37] and listener message has ct id in some form? [23:01:44] ... where we can decide if it makes sense to throw out as a duplicate, or fill in details / audit existing stuff [23:02:05] ejegg: ooh good call, that better contains the horror [23:02:31] oh actually, we even update ct with the donation id [23:02:45] err, that is the civicrm_contribution ID [23:02:45] (PS3) Cdentinger: Kill staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293463 (https://phabricator.wikimedia.org/T137387) (owner: Ejegg) [23:03:12] except we don't want to rely on the correct one coming first, i guess [23:03:28] so just a check for ct gateway != listener message gateway [23:03:30] d'oh! CT doesn't include gateway [23:03:37] ah dang [23:03:57] not much precedent for probing payments_init either [23:06:04] and that's another queue, so we can't assume it'll be there before the donation message :( [23:06:34] 26 test is passing now [23:06:38] woohoo! [23:07:35] (PS1) Ejegg: Default to Adyen in Israel [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/294193 (https://phabricator.wikimedia.org/T137731) [23:08:11] (CR) Ejegg: [C: 2 V: 2] "merging cherry pick" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/294193 (https://phabricator.wikimedia.org/T137731) (owner: Ejegg) [23:10:01] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/294194 [23:10:34] ehh, i'll cherry pick the autocompletes too [23:11:17] (PS1) Ejegg: Add autocomplete hints to personal info form [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/294195 (https://phabricator.wikimedia.org/T137716) [23:11:35] (CR) Ejegg: [C: 2 V: 2] Add autocomplete hints to personal info form [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/294195 (https://phabricator.wikimedia.org/T137716) (owner: Ejegg) [23:12:05] (PS2) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/294194 [23:12:24] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/294194 (owner: Ejegg) [23:18:09] (CR) Krinkle: [C: 1] Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (owner: Ori.livneh) [23:18:25] well i don't know of any blockers to deploying 1.26. tests pass, pages load. might be a bad week for it, but might also be bad to let changes to 1.25 accumulate [23:19:04] nah, let's wait [23:19:29] near as i can tell from the UI gerrit would actually let me delete any branch i felt like from the remote [23:20:01] i'm scared to do it but we could just delete and recut that branch after wikimania [23:20:16] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/294194 (owner: Ejegg) [23:23:42] IRL ambushed by a crowd of kids to see the ducklings... [23:26:21] (CR) Awight: "If we really must do this, please test on the beta cluster first. Thanks for" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (owner: Ori.livneh) [23:26:24] awight: cool [23:26:39] (CR) Awight: "Thanks for spotting this legacy code and cleaning it up..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (owner: Ori.livneh) [23:27:02] awight so the duck that was sitting on the eggs for 4 weeks eventually hatched some? [23:27:28] gotta run, will crack open that last staged patch later [23:27:28] cwd: I don't expect that much will happen on REL1_26 or fundraising/REL1_25 in the next few weeks. [23:27:37] dstrine: yes! 6 fuzzy wuzzies [23:27:48] cool! [23:27:51] sounds good [23:27:59] It's the first time I've had ducklings and their mama, major cutefest [23:28:11] take pictures!!! [23:28:39] I gotta run too. seeya tomorrow [23:28:42] cwd|afk: one more place we could use payments staging... [23:28:45] dstrine: k bye! [23:33:32] !log updated payments from 44102c59ac897c9acab470bf83369d233f9b736f to 2fc573cbb94e833c4144aa9dad79de8ec374bb09 [23:33:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:35:25] hellooo [23:36:45] hi! Sticking to the bottom of the world again? [23:37:12] yep haven't fallen off yet.... [23:38:42] awight: re tests passing - I get a 'pass' on the top of the food chain here https://gerrit.wikimedia.org/r/#/c/293891/ [23:38:48] but php53 lint fails [23:39:01] & can't see why it fails [23:39:18] That's an odd one, 23:58:31 PHP Parse error: syntax error, unexpected '.', expecting ')' in vendor/composer/autoload_static.php on line 10 [23:39:21] https://integration.wikimedia.org/ci/job/php53lint/4485/console [23:39:47] yeah because the row is not actually invalid [23:40:28] '3919eeb97e98d4648304477f8ef734ba' => __DIR__ . '/..' . '/phpseclib/phpseclib/phpseclib/Crypt/Random.php', [23:40:58] I think it doesn't like the way the string is concatenated with __DIR__ but it shouldn't be a problem [23:41:10] fwiw something similar just happened with the payments CI jobs, and we realized that we had to create a vendor branch to match the core release branch. But I guess CRM was set up to check out submodules or something? [23:41:33] yeah - that line was generated by running composer [23:44:14] It's a bit unnerving that the CI job is just called "php53lint", too. I'm not sure if the potential name collision is a problem [23:45:14] Just got weirder--I'm in integration-slave-precise-1011.eqiad.wmflabs:/mnt/jenkins-workspace/workspace/php53lint and there is no vendor/composer/autoload_static.php file [23:45:25] I'm wondering if phplint just doesn't cope with something about that line but it doesn't normally hit the radar as it isn't updated very often so not linted often [23:45:27] (CR) Awight: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293891 (owner: Eileen) [23:45:40] running again just in case this was colliding with another job... [23:47:52] urgh, discovering that I can't run composer update on our crm/civicrm repo... [23:48:38] But, vendor is checked in along with the master branch? [23:48:47] awight: is that the missing file message? [23:48:59] I commented that out & re-ran & there was no change [23:49:03] I don't see a missing file message [23:49:47] ok - well now we have 'merge failed' which is odd. I'll try rebasing though [23:51:04] eileen: oh hey. We reverted the 4.7 changes on crm/civicrm#master, so that CI passed again... [23:51:12] That might be related to the merge failure, at least. [23:51:35] LMK if this is a problem, but I've moved the 4.7 development over to civicrm#4.7.8-wmf_dev [23:51:41] ah OK - hmm with the full patches merged it was passing - but not passing lint [23:52:26] Do we have CI on that new branch? Because I need to run CI for https://gerrit.wikimedia.org/r/#/c/285322/ over the top of the Civi changes [23:52:36] eileen: It was actually this which caused me to revert: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/ [23:53:15] Side-effect of forcing failing code to master was that other repos which depend on civicrm were also failing, because zuul-cloner matches submodules by branch name rather than by submodule pointer... [23:53:26] yeah - if was failing on the 'stock civi' because of the missing exception hack which is in https://gerrit.wikimedia.org/r/#/c/293891/ [23:53:48] eileen: I'm not sure we have CI there yet--I could push a test commit [23:54:31] OK - so, tests but not lint pass with the 3 upgrade patches combined [23:54:48] eileen: please do whatever is most convenient for your development--aside from needing to deploy crm, the other motivation behind pushing into a feature branch was that we don't expect to deploy 4.7 for a few weeks now... [23:55:24] yeah - I'm OK with using a feature branch if I can get CI on it - although I recall last time merging back in from the feature branch was a bit messy [23:56:26] (PS1) Awight: DO NOT MERGE: trip PHPUnit tests [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294201 [23:56:38] grr, wrong branch [23:57:39] (CR) Awight: [V: 2] Set gerrit feature branch pointer [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294178 (owner: Awight) [23:57:56] eileen: looks like we do have CI. [23:58:27] (PS1) Awight: DO NOT MERGE: trip PHPUnit tests [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294202 [23:58:42] (Abandoned) Awight: DO NOT MERGE: trip PHPUnit tests [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294201 (owner: Awight) [23:58:47] OK - so in theory if I create a crm branch with the same name I can test over the top of those on the merge fn [23:59:03] ues [23:59:04] yes [23:59:10] (and I already created the branch)