[00:00:59] eileen: Confirmed that zuul-cloner is doing branch matching, please ignore whatever I said earlier about submodules... > 23:59:04 DEBUG:zuul.Cloner:Project wikimedia/fundraising/crm in Zuul does not have ref refs/zuul/4.7.8-wmf_dev/Zd4ba96561d22429d87525bae0cfbbb56 [00:01:28] (CR) jenkins-bot: [V: -1] DO NOT MERGE: trip PHPUnit tests [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294202 (owner: Awight) [00:01:29] well, that was an uneventful deploy. Gonna sign off for the night. See you all tomorrow! [00:01:42] (PS1) Eileen: CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294203 [00:01:43] uneventful is good for deploys [00:02:30] bye! [00:02:58] (PS1) Eileen: Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294204 [00:03:00] (PS1) Eileen: WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294205 [00:03:39] dstrine: You are IRCcloudy? We need to let the stakeholders know about risks of https://gerrit.wikimedia.org/r/#/c/293911/ [00:04:30] (CR) jenkins-bot: [V: -1] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294203 (owner: Eileen) [00:04:55] OK - so I re-gitreviewed them & this one is now the top of the feeding chain https://gerrit.wikimedia.org/r/#/c/294205/ I expect to see it pass tests & fail on lint again & I have no idea what to do about the latter since it's a false negative from what I can see [00:05:25] (CR) jenkins-bot: [V: -1] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294204 (owner: Eileen) [00:05:37] (CR) jenkins-bot: [V: -1] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294205 (owner: Eileen) [00:06:38] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294205 (owner: Eileen) [00:08:05] hmm here is the composer chat https://github.com/composer/composer/issues/5273 [00:10:18] any idea how we exclude that file from our linting - seems it's not used for php 5.3 [00:11:09] (Abandoned) Eileen: WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293891 (owner: Eileen) [00:11:47] (CR) Eileen: "abandoning in favour of feature branch commits" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293890 (owner: Eileen) [00:21:00] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2378014 (awight) [00:21:56] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2378026 (awight) [00:22:11] (PS4) Awight: Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (https://phabricator.wikimedia.org/T137761) (owner: Ori.livneh) [00:22:45] (CR) Awight: "This is going to take some monitoring, and in case we want to have a conversation, I've created a task here:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (https://phabricator.wikimedia.org/T137761) (owner: Ori.livneh) [00:27:06] awight: do you know how to exclude that file from phplint? [00:29:57] oops, sorry to piss your message [00:30:02] erm *miss [00:30:13] :-) [00:32:08] I'm not sure whether the output of https://github.com/wikimedia/integration-jenkins/blob/master/bin/git-changed-in-head is used in that xargs... [00:34:36] if it is then we could probably ignore it this round & it might not come back... [00:34:43] eileen: We shouldn't be linting in vendor/ in the first place... [00:35:32] ok - how do we change that [00:35:33] dang, the crm CI job does the same thing [00:37:43] I don't know yet :( [00:38:08] can we merge those commits & then see if pushing a new one passes or fails? [00:38:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix CI failures on CiviCRM 4.7 feature branch - https://phabricator.wikimedia.org/T137750#2378079 (awight) @Eileenmcnaughton pointed out that we could stop running phplint on the entire vendor/ dir. [00:38:52] eileen: Force submit? sure if you want, it's just a feature branch [00:40:38] well yeah - but we'll have to do the same when we merge too… it if turns out that we can 'live with it' provided we rarely touch that file [00:43:31] eileen: On the topic of that file... I'm confused because I have no vendor/. You're saying it's produced by composer on the CI server, but I can't find it there either. Plus, I can't run composer locally [00:44:30] I don't see composer run from the CI job... [00:44:58] awight: no - it's produced by composer locally & is part of the vendor directory that is checked into civicrm [00:45:16] we aren't doing composer as part of deploy on civi at this stage [00:45:17] okay just catching up with that last part. https://gerrit.wikimedia.org/r/#/c/294204/1/vendor/composer/autoload_static.php [00:45:34] So you can run composer locally only in the civicrm development checkout, right? [00:46:07] well sort of [00:46:25] some bright spark added some lines to it that ensure some bad files are not present [00:46:38] & that part won't run on a deployment build [00:46:52] because it relies on non-present bash scripts [00:46:55] * awight scowls [00:46:58] yeah [00:47:40] * awight squeezes eyes further shut at seeing "vendor/phpoffice" scroll by ;) [00:48:28] :-) [00:48:43] of course, php -l locally works fine. [00:48:54] what do you make of that file being missing on the CI server? [00:49:13] * awight logs in again to marvel [00:49:51] wmf1411:civicrm emcnaughton$ php -l vendor/composer/autoload_static.php [00:49:51] Parse error: syntax error, unexpected '.', expecting ')' in vendor/composer/autoload_static.php on line 10 [00:50:00] nope, it's there now [00:50:00] yeah [00:50:03] huh [00:50:13] * awight squints at "." [00:50:22] yeah so for me locally phplint doesn't work on that file [00:51:30] I get php -l passing locally. You too, huh [00:51:40] my php: PHP 5.6.20-0+deb8u1 (cli) (built: Apr 27 2016 11:26:05) [00:53:12] __DIR__ was added in PHP 5.3.0 [00:53:34] integration server is running: PHP 5.3.10-1ubuntu3.23+wmf1 with Suhosin-Patch (cli) (built: May 25 2016 08:25:05) [00:53:54] right - it will pass on later php versions [00:54:00] & it wont be called on earlier ones [00:54:16] Is this some kind of optical illusion?? [00:54:32] It fails locally for me on PHP 5.5.26 [00:54:52] the calling code for that file is php version specific [00:54:53] oh. You can't run functions from the class scope [00:55:05] so that's the rule that's being broken, at least. [00:55:33] ok - so the file is not used if the php version is 5.3 or whatever [00:55:37] I'm not what what you mean about the calling code--the composer autoloader? [00:56:00] https://github.com/composer/composer/issues/5273 [00:56:14] https://github.com/composer/composer/commit/fd2f51cea8e5f1ef978cd8f90b87b69dc1778976#diff-33037407f7f293f37df2258567b56598R583 [00:56:27] see the version handling in the second link [00:56:40] Thanks for being patient with me ;) [00:57:40] ok that's php >=5.6.0 [00:58:05] Bizarre, but I'm back on the same page as you, I think--the only solution for it is to stop php linting vendor. [00:58:37] yeah all of vendor or at the very least that file - but how do we change that config? [00:59:11] a possible workaround however--can you give arguments to composer to not produce that "optimized" file? [01:00:36] well I can probably just remove it from the commit - assuming our prod version of php is old [01:01:07] eileen: Here's the job definition, fwiw, https://github.com/wikimedia/integration-config/blob/master/jjb/macro.yaml#L527 [01:01:22] eileen: yes, our prod version is 5.3.10 [01:02:00] well maybe I'll just drop it from our vendor dir [01:02:09] fwiw, https://github.com/composer/composer/issues/3603 [01:02:40] meh that's nothing. [01:03:22] I see that composer has an --optimize-autoloader option, maybe you can tell it --no-opt... ? [01:04:47] (PS1) Eileen: Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294210 [01:05:50] nope [01:07:43] (CR) jenkins-bot: [V: -1] Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294210 (owner: Eileen) [01:08:42] (PS1) Eileen: Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294211 [01:09:55] eileen: We should try to get hashar's help with ignoring vendor... [01:11:02] ok - log a Phab to him? [01:11:44] (CR) jenkins-bot: [V: -1] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294211 (owner: Eileen) [01:13:36] (PS2) Eileen: Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294211 [01:14:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix CI failures on CiviCRM 4.7 feature branch - https://phabricator.wikimedia.org/T137750#2378127 (awight) >>! In T137750#2378079, @awight wrote: > @Eileenmcnaughton pointed out that we could stop running phplint on the entire vendor/ dir. @hashar Is t... [01:16:10] eileen: done. The vendor as a submodule and .gitignored in master workaround might be enough, though, and it would make this repo more like the others. [01:18:46] ohh cool [01:18:59] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294205 (owner: Eileen) [01:19:07] it's... halfway a good thing [01:20:07] it increases rather than decreases scope for error. Running composer update on that dir in deploy would be better [01:22:10] not sure what you mean by "in deploy", you can run it locally all day but for deployment we are syncing with files checked into civicrm/vendor#deployment branch [01:22:41] I was meaning the rblaster script or whatever runs on boron [01:22:53] boron def doesn't composer anything... [01:23:00] Why would that be better? [01:23:17] oh - I thought that was the point composer ran on smash pig etc [01:24:00] only in CI and by developers, there's no composer run on production stuff [01:24:20] it would fail with firewall fireworks, to start with [01:25:04] I think composer update should be part of a local compile step, along with DAOs etc. challenges to that idea welcome, of course! [01:25:09] ok - btw I just did recheck & it still failed https://gerrit.wikimedia.org/r/#/c/294205/ - although a couple of steps further down the dev tree it's passing because I removed some files... [01:25:21] sorry to hear it [01:25:25] dev tree = patch tree [01:25:33] dependency tree [01:25:37] hehe [01:26:07] We could do the vendor rearrangement soon, but there's a little bit of a latency on the turnaround for creating a new repo [01:26:55] ok - well - if you think the patch set in that tree looks Ok can you CR it & then we'll have an 'official' 4.7 branch… [01:27:17] https://gerrit.wikimedia.org/r/#/admin/projects/?filter=vendor [01:28:03] oh, perfect! [01:28:10] (CR) Awight: [C: 2] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294211 (owner: Eileen) [01:28:28] eileen: I think you can also push directly to that branch [01:28:46] & we have another round of CR before merging to master [01:29:01] ok - but the CR then will be on one big merge commit won't it? [01:29:24] (maybe it's unrealistic to do any more detailed CR anyway for this) [01:30:18] * awight force merges and hopes to not be eaten by Zuul [01:31:34] It doesn't need a force merge if the last commit passes does it? [01:32:20] I think that didn't work, anyway. The other commits have to be reviewed, too... [01:32:30] Trying to force push the branch, cos [01:36:00] (CR) Awight: [C: 2 V: 2] Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294210 (owner: Eileen) [01:36:18] (CR) Awight: [C: 2 V: 2] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294205 (owner: Eileen) [01:36:31] (CR) Awight: [C: 2 V: 2] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294204 (owner: Eileen) [01:36:41] * awight glares at gerrit [01:36:52] :-) [01:36:58] (CR) Awight: [C: 2 V: 2] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294203 (owner: Eileen) [01:37:05] I always think of gerrit as a hamster like creature [01:37:12] (PS2) Awight: CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294203 (owner: Eileen) [01:37:19] (CR) Awight: [V: 2] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294203 (owner: Eileen) [01:37:30] (CR) jenkins-bot: [V: -1] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294204 (owner: Eileen) [01:37:32] (CR) jenkins-bot: [V: -1] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294205 (owner: Eileen) [01:37:34] (CR) jenkins-bot: [V: -1] Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294210 (owner: Eileen) [01:37:36] (CR) jenkins-bot: [V: -1] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294211 (owner: Eileen) [01:37:38] (PS2) Awight: Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294204 (owner: Eileen) [01:37:42] (CR) Awight: [V: 2] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294204 (owner: Eileen) [01:39:27] whew! [01:39:31] (PS3) Awight: Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294211 (owner: Eileen) [01:39:33] (CR) Awight: [V: 2] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294211 (owner: Eileen) [01:40:20] (Abandoned) Eileen: Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/293890 (owner: Eileen) [01:40:42] So for next time, I think I figured it out. If the whole thing had been rebased onto the new head of the feature branch, the .gitreview file or whatever silly, small commit, then we could have just done "git push" and skip all the CR UI. [01:41:50] ok... [01:42:29] On the other hand, were there patches in there I was supposed to actually CR? ;) [01:42:46] I'll take a look at "WMF patches..." [01:44:43] (PS1) Eileen: CiviCRM 4.7.9(ish) [wikimedia/fundraising/crm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294214 [01:44:45] (PS1) Eileen: Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294215 (https://phabricator.wikimedia.org/T133625) [01:46:03] :-) [01:46:45] the wmf patches should map fairly well to the ones in the google s/s although a couple are hopefully in this month's core review cycle [01:46:58] (CR) Awight: "The changes look right!" [wikimedia/fundraising/crm/civicrm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294205 (owner: Eileen) [01:47:03] (CR) jenkins-bot: [V: -1] Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294215 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [01:47:44] https://gerrit.wikimedia.org/r/#/c/294214/1 <-- right on. [01:48:01] Glad to see the tests didn't give you trouble there [01:48:15] no - that's good [01:48:31] I need to figure out the fail on the next one [01:50:07] Legit. I'm going to fade into RL now :) [01:50:29] :-) [01:50:34] catch you tomorrow [01:50:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare 4.7 CiviCRM branch & clean our patches into it - https://phabricator.wikimedia.org/T136252#2378185 (awight) [01:50:50] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix CI failures on CiviCRM 4.7 feature branch - https://phabricator.wikimedia.org/T137750#2378183 (awight) Open>Resolved [01:51:19] eileen: now that CI passes, I fully support merging 4.7 to master if you care to... [01:55:46] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Spike: Internal Test Express Checkout in Japan to prove feasability of method - https://phabricator.wikimedia.org/T131800#2378188 (awight) Update on the TY bug I mentioned in email: These contributions actually *will*... [01:57:02] :-) [01:57:15] awight: yeah I kind of would - I'd like to make it 'official' [01:57:33] because up to that point it can kind of be changed outside the CI process [01:57:48] & I think we are at the point of saying let's not do that anymore [01:58:30] CR process I mean [01:58:34] (CR) AndyRussG: [C: -1] "Nice stuff!! Just one detail so far... I think CentralNotice->handleNoticePostFromList() (SpecialCentralNotice.php) also needs to invalida" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [01:58:40] sure! Cherry picking 4.6 deployment fixes won't be too hard, either way. [02:01:07] dang - I get screeds of merge conflicts :-( [02:02:06] thank you for the correction :), porting Civi patches is *always* hard [02:03:03] hmm - it's the revert causing all the probs [02:03:17] maybe I should just push up a new review chain with the same patches direct [02:03:38] the final one should pass just as with 4.7.8-dev [02:03:42] sorry about that revert... I was overly hasty in getting my patch deployed. [02:03:49] no worries [02:03:53] At the end of the day, I ended up reverting my own patch anyway! [02:03:57] :-) [02:03:58] lol [02:04:10] Pretty much what I deserved [02:04:59] I'll linger etherally in case you want a +2 on any of this patch shuffling [02:05:06] ok - I'm gonna try the same review chain on master I think [02:05:10] rahter than the merge [02:05:13] that makes sense [02:05:21] I think the revert is on master, too, though [02:05:33] yeah but it's different in the 4.7.8 version [02:05:45] HMM okay [02:05:49] that's so evil [02:06:28] bugger not working on master either now [02:14:18] (PS1) Eileen: CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294216 [02:14:20] (PS1) Eileen: Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294217 [02:14:22] (PS1) Eileen: WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294218 [02:14:24] (PS1) Eileen: Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294219 [02:14:26] (PS1) Eileen: Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294220 [02:17:14] (CR) jenkins-bot: [V: -1] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294216 (owner: Eileen) [02:17:50] (CR) jenkins-bot: [V: -1] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294217 (owner: Eileen) [02:18:18] (CR) jenkins-bot: [V: -1] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294218 (owner: Eileen) [02:18:21] (CR) jenkins-bot: [V: -1] Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294219 (owner: Eileen) [02:19:53] ok awight now we have a green tick at the bottom of all of those [02:21:47] * awight blinks at green tick [02:22:01] :-) [02:22:51] * awight imagines how to commit a merge [02:23:03] I was hoping to not force submit on master... [02:23:42] It makes things very fishy if we need to deploy a revert later [02:24:07] lemme think for a second [02:24:12] I though that if you +2 them then as long as the last one in the chain has a green tick they all merge? [02:24:19] no... [02:24:34] are you sure? I feel I've seen that happen before... [02:24:42] well. lemme see. Maybe if we remove jenkins as a reviewer [02:24:52] (CR) Awight: [C: 2] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294220 (owner: Eileen) [02:25:03] hmm I really feel like it will accept the merge if the 'chain' passes [02:25:06] (CR) Awight: [C: 2] Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294219 (owner: Eileen) [02:25:12] even if not all individual commits will [02:25:20] (CR) Awight: [C: 2] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294218 (owner: Eileen) [02:25:43] (CR) Awight: [C: 2] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294217 (owner: Eileen) [02:26:05] (CR) Awight: [C: 2] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294216 (owner: Eileen) [02:26:25] It might work if I quickly V+2 all thoe... [02:26:35] (CR) Awight: [V: 2] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294216 (owner: Eileen) [02:26:47] (CR) Awight: [V: 2] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294217 (owner: Eileen) [02:27:08] It's still bothering me that we can't safely roll back to any of these patches, though [02:27:15] (CR) Awight: [V: 2] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294218 (owner: Eileen) [02:27:25] (CR) Awight: [V: 2] Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294219 (owner: Eileen) [02:27:38] (CR) Awight: [V: 2] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294220 (owner: Eileen) [02:27:53] I'm optimistic about this... [02:28:30] (CR) jenkins-bot: [V: -1] CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294216 (owner: Eileen) [02:28:32] crap--gate-and-submit jobs. Not sure how we get around that without a force submit [02:28:36] (CR) jenkins-bot: [V: -1] Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294217 (owner: Eileen) [02:28:36] (CR) jenkins-bot: [V: -1] WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294218 (owner: Eileen) [02:28:39] (CR) jenkins-bot: [V: -1] Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294219 (owner: Eileen) [02:28:40] (CR) jenkins-bot: [V: -1] Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294220 (owner: Eileen) [02:28:58] dang [02:29:37] rats, I can't force push the 4.7.8-wmf_dev branch [02:30:39] its stalled again [02:30:51] you should go stop work [02:30:58] & we should deal with it tomorrow [02:31:29] (PS1) Awight: Merge sandbox/adamw/4.7.8-wmf_dev into master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294224 [02:31:33] I can squash them to a single commit [02:31:45] That one seems to work, and preserves the commits [02:32:09] We'll see if it can fool the CI troll... [02:32:28] ok waiting… [02:33:13] I may have slain Zuul with the UI fuzzing [02:33:27] no, there it is. https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/2541/console [02:34:24] git merge --no-ff, btw [02:34:31] ohh maybe our last sprint of the year can be zuul slaying [02:34:32] and cos I will forget next time it's needed [02:34:38] COOL [02:34:44] with a ghostbusters theme [02:34:48] again ;) [02:35:03] Positron beam crossing for P [02:35:55] huh. The merge didn't trigger a phplint job, fwiw, because there were no explicit .php diffs in the merge commit [02:36:08] (CR) Eileen: [C: 2] "This is the code we have been running in our staging tests" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294224 (owner: Awight) [02:36:20] ah… [02:36:26] ok I got it to merge [02:36:41] so given this stage I can merge a submodule commit to crm? [02:37:07] Yes! Half marathon nearly complete... [02:37:20] :-) [02:38:52] (PS1) Eileen: 4.7.8 & a half codebase ready for upgrade [wikimedia/fundraising/crm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294226 [02:39:29] (PS1) Eileen: 4.7.8 & a half codebase ready for upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294227 [02:39:35] (Abandoned) Eileen: 4.7.8 & a half codebase ready for upgrade [wikimedia/fundraising/crm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294226 (owner: Eileen) [02:39:43] gotcha [02:39:53] (Abandoned) Eileen: Knock out a couple of trait files coz php5.3 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294220 (owner: Eileen) [02:40:01] (Abandoned) Eileen: Remove autoload_static as it won't phplint on 5.3 for us. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294219 (owner: Eileen) [02:40:04] Congrats :) [02:40:28] Such triplicate bureaucracy... it's a steep price to pay for the CI [02:40:34] (Abandoned) Eileen: WMF patches over latest master. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294218 (owner: Eileen) [02:40:37] :-) [02:40:51] (Abandoned) Eileen: Update CiviCRM to latest patches from master [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294217 (owner: Eileen) [02:41:10] (Abandoned) Eileen: CiviCRM 4.7.8 core code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294216 (owner: Eileen) [02:41:44] If I fix the crm tests to work with normal civicrm exceptions we won't hit those same issues on stock codebase [02:42:05] (Abandoned) Eileen: CiviCRM 4.7.9(ish) [wikimedia/fundraising/crm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294214 (owner: Eileen) [02:42:32] (CR) Awight: Convert DonationInterface to extension registration (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [02:46:55] (PS22) Awight: Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) [02:47:21] (CR) Awight: "PS 22: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [02:53:58] (CR) Awight: "I've verified that Adyen, Ingenico, and both PayPals work normally..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [02:55:14] (CR) Awight: [C: 2] "Recklessly merging to master so that we can all dogfood until the next big deployment in a few weeks." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [02:57:05] (Merged) jenkins-bot: Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [11:02:50] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Unplanned-Sprint-Work: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2379152 (Pcoombe) The previous bug was T76743 [14:41:12] fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2379698 (faidon) [15:10:12] Fundraising-Backlog: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2379794 (MBeat33) [15:10:22] Fundraising-Backlog: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2379809 (MBeat33) p:Triage>Unbreak! [15:34:04] Fundraising-Backlog: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2379886 (MBeat33) @ejegg asked Adyen to change maxlength=3 attribute to maxlength=4 [15:36:05] Fundraising-Backlog: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2379892 (Ejegg) Also looking into putting some script into the footer of the HPP skin to fix it. [16:54:09] hi cwd [16:54:46] yo [16:54:56] you on a plane or what? [16:57:42] * cwd ponders wifi on int'l flights [16:57:47] guess that's gotta be a thing by now [16:59:16] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, and 3 others: Make Adyen default gateway for Israel - https://phabricator.wikimedia.org/T137731#2380256 (Pcoombe) Open>Resolved Thanks! [17:05:22] i was not gonna bother with the meeting unless anyone else wants to [17:05:39] I don't have a real pressing need for it today. [17:12:30] cwd: empty agenda? [17:12:58] Maybe we should make part of each meeting to set up the topics for the next day? [17:12:58] awight: yeah i didn't have much, but happy to hop on if you do [17:13:11] I do, but not sure anyone wants to talk about ti. [17:13:16] it [17:13:16] PPEC? [17:13:23] I'm still stumped by the method vs gateway thing [17:13:25] yeah [17:13:33] lemme grab headphones [17:14:30] sure, i'm in [17:14:39] Yea, I'll pop in too.\ [17:14:49] cwd plane's not till 7:45 pm local [17:15:01] Like I was complaining about last night, the cool! [17:15:04] i might miss standup and just work from airport the last couple hrs [17:15:06] hehe that was a mistake [18:12:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Store and show merchant reference ID in Civi - https://phabricator.wikimedia.org/T137834#2380538 (Ejegg) [18:23:36] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Come up with ID scheme for "merchant reference" numbers - https://phabricator.wikimedia.org/T137837#2380606 (cwdent) [18:47:18] (PS4) Cdentinger: Kill staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293463 (https://phabricator.wikimedia.org/T137387) (owner: Ejegg) [18:52:11] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904#2380718 (greg) p:Triage>High [18:54:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904#2351830 (greg) p:High>Triage (bad drag) [18:55:48] (CR) Cdentinger: [C: 2] Kill staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293463 (https://phabricator.wikimedia.org/T137387) (owner: Ejegg) [18:57:33] (Merged) jenkins-bot: Kill staged_vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293463 (https://phabricator.wikimedia.org/T137387) (owner: Ejegg) [19:05:58] Fundraising-Backlog: Amazon: duplicate transaction - only 1 reached Civi - https://phabricator.wikimedia.org/T121920#2380756 (DStrine) Resolved>declined [19:50:36] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2380849 (AndyRussG) [20:01:32] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2380879 (AndyRussG) Here's what I have so far: - Thi... [20:05:04] awight|fud: do you have a vagrant link for ppec that is good for testing? i've tried a few with varying results... [20:07:27] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Come up with ID scheme for "merchant reference" numbers - https://phabricator.wikimedia.org/T137837#2380882 (DStrine) p:Triage>High [20:09:11] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2380890 (DStrine) [20:13:47] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Unplanned-Sprint-Work: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2380895 (awight) Andrew brought up another candidate for... [20:14:04] Fundraising-Backlog, FR-Astropay: Argentina donation form: update 'Santander' button to say 'bank transfer' - https://phabricator.wikimedia.org/T137746#2377490 (DStrine) [20:14:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-PayPal-ExpressCheckout: Damaged queue messages missing from Drupal interface - https://phabricator.wikimedia.org/T137735#2380898 (awight) Might be related to the underscore in our gateway name? I think I saw "paypalec" somewhere. [20:14:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2380899 (DStrine) p:Triage>Normal [20:15:11] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#2380908 (awight) [20:15:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-PayPal-ExpressCheckout: Damaged queue messages missing from Drupal interface - https://phabricator.wikimedia.org/T137735#2380909 (DStrine) p:Triage>Normal [20:16:02] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#2380918 (DStrine) p:Triage>Normal [20:16:18] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#2380922 (awight) [20:16:20] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#2380921 (awight) [20:18:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Duplicate class loading in DonationInterface - https://phabricator.wikimedia.org/T137602#2380934 (DStrine) Open>Invalid [20:18:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Set do not trade field to 0 on all contacts - https://phabricator.wikimedia.org/T137588#2380935 (DStrine) p:Triage>Normal [20:20:08] Fundraising-Backlog, FR-Smashpig: IPN listener should be able to update payments_final_status - https://phabricator.wikimedia.org/T137590#2380937 (DStrine) p:Triage>Normal [20:20:30] Fundraising-Backlog, FR-Adyen, FR-Smashpig: IPN listener should be able to update payments_final_status - https://phabricator.wikimedia.org/T137590#2372781 (DStrine) [20:22:04] Fundraising-Backlog, FR-Adyen, FR-Smashpig: IPN listener should be able to update payments_final_status - https://phabricator.wikimedia.org/T137590#2380940 (awight) @MBeat33 FYI. @RLewis @PPena It's possible that reports will have incorrect totals, cos "Pending" contributions won't show up alongside... [20:22:32] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Rudimentary scoping of mediawikiless-donationinterface - https://phabricator.wikimedia.org/T137586#2380943 (DStrine) p:Triage>Normal [20:24:07] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Unplanned-Sprint-Work: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2380948 (ori) >! In T137761, @awight wrote: > As best as... [20:27:19] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Get performance metrics for payments wiki - https://phabricator.wikimedia.org/T137583#2380954 (DStrine) p:Triage>Normal [20:29:03] Fundraising-Backlog, FR-PayPal-ExpressCheckout: instructions for blocking accounts payments from Non-U.S. accounts - https://phabricator.wikimedia.org/T137577#2372264 (awight) @PPena Thanks for the instructions! What exactly are you asking us to do, though? It's just to have in case we need it? Or is... [20:34:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Date parsing error from unknown gateway - https://phabricator.wikimedia.org/T137455#2380982 (awight) p:Triage>High [20:35:19] (PS9) Ori.livneh: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 [20:36:10] (CR) Ori.livneh: "@AndyRussG, I added a ChoiceDataProvider::invalidateCache() to Campaign::logCampaignChange(); that should cover the case you mentioned." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [20:50:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Date parsing error from unknown gateway - https://phabricator.wikimedia.org/T137455#2381056 (awight) [20:50:40] Fundraising-Backlog, fundraising-tech-ops, Monitoring, Tracking: Improve Fundraising monitoring, alert, and high-level error handling (tracking) - https://phabricator.wikimedia.org/T136169#2381055 (awight) [20:58:03] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, and 4 others: Support API certificate authentication - https://phabricator.wikimedia.org/T136743#2381076 (awight) [21:24:10] Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2381117 (Pcoombe) [21:24:12] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2381118 (Pcoombe) [21:24:14] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, Patch-For-Review: CentralNotice: test registration - https://phabricator.wikimedia.org/T134286#2381115 (Pcoombe) Open>Resolved Confirmed this appears to be... [21:28:31] Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2381119 (Pcoombe) Open>Resolved Banners for the test are done: Large * https://hu.wikipedia.org/wiki/Guy_Fawkes?force=1&country=HU&banner=B1516_0615_huHU_dsk_p1_lg_twin_1 * https://hu.wikipedia.... [21:36:20] awight|fud: uback? i'm trying to get the ppec forward working in vagrant. i swear it used to but now i get a DI form with a continue button [21:45:13] cwd: squatting out of reach of IRC [21:45:13] hey [21:45:24] Maybe your amount is wrong? [21:45:28] What's your URL? [21:45:33] & you on master? [21:45:44] yeah [21:45:49] i've tried a few, one sec... [21:47:07] http://payments.wiki.local.wmftest.net:8080/wiki/Special:PaypalExpressGateway?appeal=JimmyQuote&ffname=paypal&recurring=&language=en&utm_source=Waystogive&utm_medium=sitenotice&utm_campaign=C11_Waystogive&gateway=paypal&returnto=Thank_You%2Fen¤cy_code=USD&uselang=en&amount=10000&payment_method=paypal [21:47:34] U has no amount [21:47:38] and USD is not supported [21:47:45] grab URL params from that letter I sent out... [21:47:57] whoops! [21:48:03] ?title=Special:PaypalExpressGateway&appeal=JimmyQuote&ffname=paypal&language=en&utm_source=Waystogive&utm_medium=sitenotice&utm_campaign=C11_Waystogive&gateway=paypal&returnto=Thank_You%2Fen¤cy_code=JPY&country=JP&uselang=en&amount=140&recurring=false [21:50:58] cwd: I should add those to the vagrant Main_Page.wiki [21:51:08] some are in there already [21:52:52] or here: https://www.mediawiki.org/wiki/Fundraising_tech/Test_links [21:52:58] a huge compendium of query strings would be great [21:53:28] I like the vagrant ones cos they have the right host, but the wikitext can be pasted into any wiki [21:55:48] awight: which vagrant page? [21:58:01] should be the home page [21:58:07] wiki/index.php [21:59:13] even just some javascript-driven dropdowns would be handy [21:59:33] yess [21:59:35] ooh, that page [21:59:47] yeah that would be nice [22:00:31] I think the concrete list is good for grabbing known working URLs, but a form to generate URLs would be better for finding new frontiers [22:02:25] Do we have a site we use to test on a bunch of browsers? I thought we did but I can't remember what it was. [22:02:38] oh wow, somebody merged extension.json. Awesome! [22:03:15] XenoRyet: yeah, was it something like browsertest.org ? [22:03:33] nope, not that one [22:04:18] Something like that though. [22:04:37] aha, crossbrowsertesting.com [22:05:36] account deets up on officewiki: https://office.wikimedia.org/wiki/Browser_testing_and_design_tools [22:05:44] That's the one. Thanks [22:06:01] Gonna put that skin fix through more browsers than I have locally. [22:06:12] That service is great [22:06:14] brb [22:09:25] XenoRyet: i'm a little stumped as to how to do that since we don't have an externally accessable staging site [22:10:12] I think the adyen console will let you get at just the skin, which is probably enough for this test. [22:10:18] ahh, cool! [22:19:46] ejegg: We're currently not sending them a 'brand code' right? [22:31:01] (PS1) Ejegg: Check in Adyen iframe skin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294392 (https://phabricator.wikimedia.org/T137811) [22:31:44] XenoRyet: oops, didn't see my hilight! nope, we're not sending that now [22:32:48] Shouldn't be hard to add that, as long as it's a consistent mapping. There's stuff in the docs about doing a directory lookup each time, but I hope that's not necessary when we know which options we want to allow [22:33:14] That's what I thought. The Adyen console won't display without it though, and if I include it it puts a logo at the bottom of the form. The currently live version doesn't do that even when I do include the code [22:33:49] Not sure how to get an accurate test out of this. But for what it's worth it's working as intended in FF and Chrome locally. [22:35:24] (PS1) Ejegg: Adyen iframe hacks to fix CVV input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294394 (https://phabricator.wikimedia.org/T137811) [22:39:14] cwd: You getting PP EC action now? [22:39:38] XenoRyet: it's pretty vanilla JS, right? [22:39:52] Yea [22:39:53] awight: lemme get the error... [22:39:57] hehe [22:40:03] And I tried to guard against things being renamed [22:40:34] Yea, I'm pretty confident it's fine. Was just going to be extra cautious. [22:41:02] awight: this ring any bells? :"OrderTotal (Amt) : Required parameter missing" [22:41:06] amount is in the params [22:41:37] (PS2) Ejegg: Adyen iframe hacks to fix CVV input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294394 (https://phabricator.wikimedia.org/T137811) [22:41:55] cwd: Where is that error coming from? [22:42:05] i think it's in the pp response [22:42:10] axing for the iframe url [22:42:13] XenoRyet: PS2 just adds a note about the brandCode thing, same exact js [22:42:25] Yea, saw that. [22:43:32] cwd: what IRC setup do you suggest? running weechat on a virtual server somewhere with tmux and connecting with glowingbear? [22:43:43] cwd: What's the gateway URL you're using now? [22:43:50] I guess weechat has a way to archive chats? [22:44:08] who should i speak to about the fundraising ads ? [22:44:23] matanya: Me :) what is up? [22:44:31] Hi Seddon [22:44:47] haven't been logged out in about a year [22:44:53] AndyRussG: yep! leave it running in tmux or screen on a virtual server, and set up a "relay" which is like a socket [22:45:08] and now i have for some networking issue. I get 3 versions of the same ad [22:45:15] is that by design ? [22:45:55] awight: payments.wiki.local.wmftest.net:8080/wiki/Special:PaypalExpressGateway?appeal=JimmyQuote&ffname=paypal&language= [22:45:57] en&utm_source=Waystogive&utm_medium=sitenotice&utm_campaign=C11_Waystogive&gateway=paypal&returnto=Thank_You%2Fen¤cy_code=JPY&country=JP&uselang=en&amount=140&recurring=false [22:46:09] That one looks good. [22:46:13] ejegg: I'm pretty convinced this is ok to go to live. So I guess I'll +2 those patches and you can push the button in the console? [22:46:14] matanya, you should see at least two version. There is a Big banner and a Small banner [22:46:26] even if i click close Seddon ? [22:46:27] cwd: What about the syslog like where it prepares the SetExpressCheckout call? [22:47:42] awight: looks...fine. i don't see much of the request in syslog [22:47:52] Preparing to send SetExpressCheckout transaction to Paypal Express Checkout [22:48:00] Successful transaction to Paypal Express Checkout [22:49:07] matanya: I don't think so. In theory if you close you shouldn't see the banner for a fixed period of time [22:49:09] XenoRyet: i can do the honors [22:49:29] but I'm about to hop on a flight, so I'll rely on you to roll back in case of problems [22:49:33] matanya: do you allow the setting of cookies? [22:49:37] Seddon: easily reproducible [22:49:41] I do [22:49:49] ejegg: Cool, yea, I can do that. [22:53:07] ah ha. i get a different error on master vs. deployment. good thing we're not deploying... [22:53:34] Seddon: https://imgur.com/0fUnoLx and https://imgur.com/Z5jgD6O right after clicking close [22:53:43] error on deployment is also weird: "Security header is not valid" [22:53:56] matanya: they are definitely the banners I was expecting [22:54:11] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2381382 (awight) Losing my bea... [22:54:59] cwd: That sounds like signature vs certificatepath stuff. but it should be the same across branches. [22:55:19] ejegg: Sanity check, please. This comment illustrates the problem we're diagnosing, right? https://phabricator.wikimedia.org/T132500#2381382 [22:55:24] yeah, i think something on master might be funky [22:55:50] Seddon: i can share a screencast [22:55:58] awight: yeah, that seems really off [22:56:47] ejegg: ok great. That's a pretty small sample, I can try to correlate lines and find a pattern [22:57:04] good luck, man, that one's been really puzzling [22:57:09] I've gotten the donatewiki webrequest logs into a SQL database on the staging box, which should help [22:57:12] thx! [22:57:20] awight: that sounds fun [22:57:50] cwd: Can you pm me your PP EC LocalSettings config? [22:58:00] XenoRyet: I think I need to rely on you to promote v 24 too. Boarding is imminent! [22:58:11] sure [22:58:19] ok everybody, have a good week, and I'll see you all in Esino Lario! [22:58:30] ejegg: No worries. Catch that plane. [22:58:37] See you there [22:58:50] Seddon: https://commons.wikimedia.org/wiki/File:%D7%A6%D7%99%D7%9C%D7%95%D7%9D_%D7%9E%D7%A1%D7%9A_%D7%9E%D6%BE15-06-16_01-55-00.webm [23:01:03] matanya: I'll take a look into this and maybe get back to you tomorrow [23:01:34] Thanks Seddon i will delete this file, please download it, if you need a copy [23:02:02] matanya: downloaded :) thanks for that [23:02:07] sure [23:03:24] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Patch-For-Review, Unplanned-Sprint-Work: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2379794 (XenoRyet) Live site is accepting 4 digit CVV now. [23:04:53] Fundraising Sprint Killing Time, Fundraising-Backlog, FR-Adyen, Patch-For-Review, Unplanned-Sprint-Work: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2381408 (MBeat33) Awesome, thank you all! [23:22:38] (PS3) Eileen: Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) [23:26:58] AndyRussG: btw https://www.glowing-bear.org/ has easy instructions in the Usage part [23:27:10] XenoRyet: did the CVV fixed go out? [23:27:18] Yep [23:27:19] *CVV Fix [23:27:22] cool [23:27:23] thanks! [23:27:45] cwd: cool thx! Yeah I have it working locally! Just trying to close a buffer that I opened by accident [23:28:12] Also on Quasell I used to get a little indicator of when people were away--their nick was dimmed and there was a little icon--now everyone looks the same [23:28:19] I must run. See you all tomorrow [23:28:29] dstrine-away: bye! [23:28:37] I think this is gonna be a better setup, tho [23:28:41] AndyRussG: hrm yeah i don't know of any UI stuff for away... [23:29:31] (Abandoned) Eileen: Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] (4.7.8-wmf_dev) - https://gerrit.wikimedia.org/r/294215 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [23:39:00] (PS1) Awight: Fix test mode typo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294404 [23:46:00] (PS2) Eileen: Drush merge command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 (https://phabricator.wikimedia.org/T133808)