[00:06:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: enhance existing retrieve & batch merge methodology in core by accepting more fluid criteria (currently only takes the group) & - https://phabricator.wikimedia.org/T135052#2381522 (Eileenmcnaughton) a:Eileenmcnaughton [00:06:37] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: enhance existing retrieve & batch merge methodology in core by accepting more fluid criteria (currently only takes the group) & - https://phabricator.wikimedia.org/T135052#2286888 (Eileenmcnaughton) [00:12:18] (PS3) Eileen: Drush merge command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 [00:31:09] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2381557 (awight) a:Ejegg>... [01:45:40] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/293793 (https://phabricator.wikimedia.org/T128818) (owner: Eileen) [01:48:04] (CR) Krinkle: [C: 1] Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [02:58:18] (PS1) Eileen: CRM-18958 add limit to dedupe screen [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294420 (https://phabricator.wikimedia.org/T135051) [03:00:26] (PS2) Eileen: CRM-18958 add limit to dedupe screen [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294420 (https://phabricator.wikimedia.org/T135051) [03:42:02] (PS3) Eileen: CRM-18958 add limit to dedupe screen [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294420 (https://phabricator.wikimedia.org/T135051) [03:44:16] (PS4) Eileen: CRM-18958 add limit to dedupe screen [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294420 (https://phabricator.wikimedia.org/T135051) [04:51:18] (PS4) Eileen: Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) [05:07:28] (PS5) Eileen: Fix merge hook to remove calculated fields from merge_conflicts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/285322 (https://phabricator.wikimedia.org/T133625) [05:07:30] (PS4) Eileen: Drush merge command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/290828 [05:07:32] (PS1) Eileen: Per merge connection id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294428 (https://phabricator.wikimedia.org/T135063) [05:29:06] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Decide whether we want batch merges to be reversible by contact or by group. - https://phabricator.wikimedia.org/T135063#2381748 (Eileenmcnaughton) a:Eileenmcnaughton [05:30:26] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Decide whether we want batch merges to be reversible by contact or by group. - https://phabricator.wikimedia.org/T135063#2287112 (Eileenmcnaughton) Per discussions I have set this to update the transaction id per... [06:01:25] (PS1) Eileen: WIP Trial patch to deal with group performance vs functionality issue [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294433 [06:06:28] (PS1) Eileen: CRM-18692 issue warning about empty smart group cache rather than crash the server [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/294434 [06:45:09] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2381836 (awight) Breadcrumbs..... [07:27:48] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2381926 (awight) ``` zgrep -F... [07:35:15] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2381942 (awight) ``` zcat dona... [08:00:22] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2381998 (awight) Filtering the... [08:15:24] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2382012 (awight) Also noting t... [08:35:26] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2382039 (awight) Trying a more... [10:23:14] Wikimedia-Fundraising: Create banners for HoverCards A/B test - https://phabricator.wikimedia.org/T134291#2382212 (Pcoombe) [10:23:16] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2382211 (Pcoombe) [10:23:53] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog, Reading-Web-Sprint-74-Page-views-page-views-PAGE-VIEWS: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2165081 (Pcoombe) This test is underway now... [13:57:25] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 3 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2382574 (Jgreen) You have a ty... [14:15:13] Fundraising-Backlog, FR-PayPal-ExpressCheckout: instructions for blocking accounts payments from Non-U.S. accounts - https://phabricator.wikimedia.org/T137577#2382607 (Ppena) @awight Just to triple check that everything that we need to be blocked is blocked. We were still receiving donations from some... [16:46:52] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2383076 (Jgreen) p:Normal>High [17:14:36] (PS1) Cdentinger: Removes some aberrant single quotes. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294525 [17:38:36] nuts. I think I added an agenda item and then didn't show up. [17:39:06] "too horrible to bear" is my opinion about deployment. [17:39:26] The odds of some random person cleaning up from the mess several days later is high. [17:39:44] Got any agenda for tomorrow? [17:39:49] (fr-tech) [17:40:59] ppec? [17:41:10] wat about it? [17:41:25] oh sorry, I meant agenda for the fr-t-t meeting [17:41:32] I missed the meeting as well, but I think I'm also sitting ever so slightly on the 'too horrible to bear' side of the fence. [17:41:40] i found the prob from yesterday btw: https://gerrit.wikimedia.org/r/294525 [17:41:57] cwd: Thanks!! [17:42:12] (CR) Awight: [C: 2] "Eagle eyes!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294525 (owner: Cdentinger) [17:42:24] uhm, well i was planning to try and get that new merchant reference thing working today, and though we could talk about that tomorrow [17:42:34] wfm [17:42:39] i think i pretty much know what to do [17:42:47] I'm probably staring at clicktracking numbers today [17:42:54] I found some abberations [17:43:02] yeah i saw that [17:43:25] looks like a pretty intense staring session [17:43:33] Sort of oversharing on the task, but I figured that might be helpful for ejegg and anyone else who gets curious [17:43:50] (Merged) jenkins-bot: Removes some aberrant single quotes. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294525 (owner: Cdentinger) [17:44:11] is this ID thing the last known blocker for testing express checkout? [17:44:18] hmm lemme see [17:44:37] I made this terrible work board btw [17:44:38] https://phabricator.wikimedia.org/project/view/1893/ [17:44:50] dstrine says it's just a matter of time until the Phabricator secret police find out [17:45:04] currency conversion is a blocker, too [17:45:14] and... we should circle 'round about recurring. [17:45:38] The workflow is all jacked up, and there's one potential (very complex) solution available, that we use reference transactions. [17:46:16] they don't want to test without recurring? [17:46:20] donno [17:46:41] PPena: ppena_: Do you have an opinion about that? ^ [17:46:46] hmm jrobell should be queried as well [17:50:19] awight sorry, this is confusing. What do I need to chime in for? [17:51:17] PPena: for paypal express checkout, would you be OK to test it without recurring? there are still some questions about if that will work or not. [17:51:36] PPena: hi! The part I was hoping to get your opinion on was, ^ yeah. We have recurring, but it's not the right flow. Wondering if anyone cares. [17:52:11] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 4 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2383273 (awight) [17:52:41] awight 1. I'm ok testing without recurring 2.If we can test recurring (even though its not the correct flow) but that would help us find problems in the back end, I support going ahead with recurring tests [17:52:54] PPena: +1. Okay, thanks for the input! [17:54:09] speaking of paypal exploding [17:54:39] * awight checks email all 'noidly [17:54:42] wat [17:56:04] (CR) XenoRyet: [C: 2] Fix test mode typo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294404 (owner: Awight) [17:57:35] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Ingenico orphan slayer acting up - https://phabricator.wikimedia.org/T137905#2383283 (awight) [17:57:47] (Merged) jenkins-bot: Fix test mode typo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294404 (owner: Awight) [17:58:53] XenoRyet: thank you! [17:59:01] No worries [17:59:11] Was an easy one. [18:05:55] (CR) AndyRussG: [C: 2] "Great!! :) Nice post-cache handling of campaigns that may start during cache TTL, BTW..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [18:07:10] awight: in the context of ppec is order id the same as merchant ref? [18:07:16] or are we not sending merchant ref now? [18:07:53] (Merged) jenkins-bot: Add object caching to ChoiceDataProvider [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293443 (owner: Ori.livneh) [18:15:10] cwd: We're sending order id now, and into a different fields IIRC... [18:15:15] s/s// [18:16:00] order id looks like ctid.attempt# [18:16:03] is that right? [18:16:05] yep [18:16:12] groovy [18:16:31] should i send the new value in there or make an additional one? merchant ref [18:18:26] Good question [18:18:39] What's the field we're using? Something kind of wrong, right? [18:18:59] it's order_id in the string we send them [18:19:38] doesn't seem that wrong to me [18:19:46] I think it's "custom" for legacy [18:20:24] And for express, we send contribution_tracking_id in L_BILLINGAGREEMENTCUSTOM0, PAYMENTREQUEST_0_CUSTOM and PROFILEREFERENCE [18:20:45] and order_id in L_BILLINGAGREEMENTCUSTOM0 (oops, not ctid), and PAYMENTREQUEST_0_INVNUM [18:22:13] oh heh i'm looking at the returnurl param which includes an order id param [18:22:16] * awight cries a little seeing the filters I've created to avoid reading failmail [18:22:22] ah, that one's for us [18:22:24] brb [18:22:45] yo dawg i heard you like name value pairs [18:25:05] My favorite is not escaping them [18:26:58] so order_id is the thing we want to change? or should i say L_BILLINGAGREEMENTCUSTOM0 [18:27:12] also why send the same value in 3 fields? [18:27:44] I was covering our bases, cos unsure which fields come back to us in IPN and the audit files. Pretty silly way to do it. [18:28:52] One important subtask is to locate a few of the PPEC transactions in incoming IPN and audit data... [18:29:26] to see what they're sending back? [18:29:30] yep [18:29:35] cool [18:29:48] do the IPN messages work in test mode? [18:29:53] no [18:30:34] that's pretty fuck it ship it [18:30:42] If you want to get dastardly though (and probably no need for this), you could use the production creds locally, and add the magic ipn url field which specifies that the IPN for that transaction should go to your honeypot [18:31:07] But for now, I'm happy taking whatever squirts out of the other end of the IPN, on the queue [18:31:17] ... assuming it has all the same infos [18:32:46] ok cool [18:34:24] it seemed to work right? the payment succeeded on the front end, but then the listener got the message and thought it was old paypal. so dupes in civi. need to change the listener to pick the string apart and...do what now? [18:35:53] um. One thing is to verify that the IPN message has all the stuff. The other thing is probably to decode the merchant reference in the IPN listener and set the gateway to paypal_ec if it matches our magic [18:36:08] that way the transaction is correct over the wire (and gets the right stupid correlation id) [18:37:12] once it sets the gateway, the backend will avoid inserting the dupe? [18:38:08] it occurs to me that just turning off the listener might make it work? [18:43:39] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Ingenico orphan slayer acting up - https://phabricator.wikimedia.org/T137905#2383533 (awight) Okay--it's not every transaction. For example, at Jun 15 18:10:03 we successfully rectified 36894761:2190633880 We are incorrectly... [18:43:52] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Ingenico orphan slayer incorrectly cancelling pending transactions - https://phabricator.wikimedia.org/T137905#2383534 (awight) [18:45:06] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Ingenico orphan slayer incorrectly cancelling pending transactions - https://phabricator.wikimedia.org/T137905#2383283 (awight) @MBeat33 Have you gotten any reports of Ingenico donors seeing their charges mysteriously cancelle... [18:45:26] cwd: The listener is pretty key for redirect methods [18:46:03] I've seen periods where up to 25% of transactions have to be recontructed from the audit logs, even, cos they fell through both the final step of redirecting back to us, and the listener failed. [18:47:38] damn [18:51:40] and um... don't you think turning off the listener is a bit drastic? :p [18:52:03] Good to post oneself decisively outside the box though [18:53:17] Might peek into CC's email discussion [18:54:58] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Ingenico orphan slayer incorrectly cancelling pending transactions - https://phabricator.wikimedia.org/T137905#2383575 (MBeat33) Thanks, @awight We have two Ingenico card errors from today, but it's not clear what's going on wi... [18:59:38] (PS1) Cdentinger: Add express checkout identifier to order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294533 [19:54:33] fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2383725 (Jgreen) payments1005 is built on jessie and should behave like payments1004, so you should be able to do live testing there now by using an ssh tunnel I also rebuilt payments2... [20:10:46] Fundraising-Backlog, fundraising-tech-ops, Epic: [Epic] Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2383759 (Jgreen) [20:10:48] fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2383758 (Jgreen) Open>Resolved [20:14:12] Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Come up with ID scheme for "merchant reference" numbers - https://phabricator.wikimedia.org/T137837#2383796 (cwdent) a:cwdent [20:40:58] awight: where even is the paypal listener? i don't see anything in smash-pig. [20:44:53] cwd: It's the worst. [20:45:00] u wanna to a call btw? [20:45:17] i am just eating but could in a few minutes [20:45:51] cwd: https://github.com/wikimedia/wikimedia-fundraising-PaymentsListeners/tree/master/legacy-paypal [20:45:54] no worries [20:46:37] ah ok gotcha [20:46:45] so this is a generic layer [20:46:59] not sure whatchu mean by generic [20:47:13] nmnm [20:47:18] how have i never seen this repo before [20:47:29] we don't show the 1st-years :p [20:47:44] what is this one? https://github.com/wikimedia/wikimedia-fundraising-PaymentsListeners/tree/master/paypal/IPN [20:47:45] The plan was to rewrite this under SmashPig and burn the evidence [20:47:54] That's... nothing [20:47:57] hehe [20:48:01] move along [20:49:22] awight: does this need to change at all, or is it in the civi module? [20:49:33] to make it recognize the new name and reset gateway [20:50:29] I think it need to be changed in this IPN code. [20:50:36] Open to debate, of course [20:50:58] but my itch is that I'd rather not send the message over the wire saying gateway=paypal if that's incorrect [20:51:11] cool [20:51:15] is this running on the civi box? [20:51:44] And here's the fun part: no logging ATM. [20:51:54] I was considering hacking syslog support... [20:52:01] that' *is* fun [20:52:16] But most productive would be to rewrite it as a SmashPig module. [20:54:23] https://github.com/wikimedia/wikimedia-fundraising-PaymentsListeners/blob/master/legacy-paypal/PaypalIPNListener.php#L84 [20:54:35] exactly [20:54:49] cos the last thing we want to do is actually touch this code with anything but a flamethrower [20:55:25] sheesh [20:56:01] but all that should have to happen is "if order_id looks like EC, gateway=EC" right? [20:56:34] yes [20:57:11] But if we're going to include this listener in the queue overhaul... it'll need to be rewritten anyway. [20:57:49] yeah [20:58:12] worth blocking this on that? or should i ham it up? [20:58:47] I guess I can drop this bone--it's a two-line change... [20:58:57] We can just say the rewrite blocks the queue work. [20:59:41] word [20:59:58] https://github.com/wikimedia/wikimedia-fundraising-PaymentsListeners/blob/master/legacy-paypal/PaypalIPNListener.php#L56 [21:00:23] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2383939 (awight) [21:00:25] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#2383938 (awight) [21:00:39] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2148612 (awight) [21:00:41] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2383940 (awight) [21:01:33] Fundraising-Backlog, FR-ActiveMQ, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Rewrite PayPal listener under SmashPig - https://phabricator.wikimedia.org/T130851#2148612 (awight) [21:02:49] wow. I got some cheap headphones at yard sale this weekend and it's amazing to enjoy music without the constant crackle of a blown driver [21:03:13] cwd: That class is beyond atrocious. And believe it or not, this is after several mini rewrites [21:03:22] (PS1) Awight: Remove unused commit of legacy PayPal IPN code [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294636 [21:04:51] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypay Express checkout internal test - https://phabricator.wikimedia.org/T131815#2383947 (awight) [21:04:53] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#2383948 (awight) [21:04:55] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Debug gateway account name handling - https://phabricator.wikimedia.org/T130852#2383945 (awight) Open>Invalid We're gonna use gateway name instead. [21:05:19] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout, and 2 others: Spike: Decide whether PayPal Express Checkout is a new gateway, payment method, or account name. - https://phabricator.wikimedia.org/T134452#2383949 (awight) Okay, we... [21:05:24] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, FR-Smashpig: Debug gateway account name handling - https://phabricator.wikimedia.org/T130852#2383951 (awight) [21:05:26] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, FR-PayPal-ExpressCheckout, and 2 others: Spike: Decide whether PayPal Express Checkout is a new gateway, payment method, or account name. - https://phabricator.wikimedia.org/T134452#2383950 (awight) Open... [21:07:15] nice, listening to KZSC and they just switched to generators [21:07:17] hippis. [21:07:25] * awight buys an "e" [21:09:27] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2383956 (awight) @AndyRussG That sounds good--I'm cu... [21:09:44] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Can we allow fallback to alternative campaign if mixin would hide this on... - https://phabricator.wikimedia.org/T124969#2383958 [21:09:53] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2383959 (awight) a:AndyRussG [21:15:17] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Can we allow fallback to alternative campaign if mixin would hide this on... - https://phabricator.wikimedia.org/T124969#1971256 [21:17:36] dstrine: goddamit. https://phabricator.wikimedia.org/T257 [21:19:03] yup and upstream conversations are positively hostile [21:19:21] Where do we find these guys... [21:20:55] Hey for some reason though, the manifest search is a much more useful output: https://phabricator.wikimedia.org/maniphest/query/AviEEkfX2uTV/#R [21:21:12] go go gadget mediawiki sprint extension [21:21:55] hehe [21:22:37] awight: i have this situation where i need the staging functions to run in a certain order [21:22:44] because one needs the mutated value from the other [21:22:44] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2383980 (awight) [21:22:48] cwd: cool. [21:22:58] You should be able to order them in transformers.yaml, no? [21:23:03] oh duh [21:23:05] thanks! [21:25:06] (PS2) Cdentinger: Add express checkout identifier to order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294533 [21:25:27] I'm... really happy that we have that ability now [21:25:38] it used to be evil magic in how you declared staged_vars [21:26:24] yeah it really works great [21:26:56] ooh--just realized it might be a problem that we run unstaging in the same order rather than in reverse [21:27:05] meh we can cross that bridge after it's burned down [21:27:26] heh [21:27:36] https://github.com/egalpin/apt-vim [21:27:52] That's so wrong [21:28:06] why not just use emacs mode in vi :p [21:28:32] hehe [21:28:55] i've always resisted using vim plugins and having a long vimrc [21:29:00] but i'm getting old and tired of resisting [21:29:34] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2383986 (awight) @Jgreen Thanx... [21:37:14] (PS1) Cdentinger: Differentiate express checkout for the back end. [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294639 [21:40:55] guess there's no CI on that repo [21:40:55] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2383992 (Jgreen) Another thing... [22:14:01] awight|meathook: whenever you have time maybe you could take a look at https://gerrit.wikimedia.org/r/#/c/294533/ and https://gerrit.wikimedia.org/r/#/c/294639/ ...that's everything i know about right now. i gotta bounce but will check in later. [22:18:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Provide ability to enter foreign currency into Source and have the USD amount populated by Civi - https://phabricator.wikimedia.org/T137931#2384084 (awight) [22:20:18] (CR) Awight: Differentiate express checkout for the back end. (2 comments) [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294639 (owner: Cdentinger) [22:22:26] (CR) Awight: "Looks nice. Just waiting to discuss the prefix a bit more." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294533 (owner: Cdentinger) [22:23:41] awight: i'm not gone yet...what about just PPEC- ? [22:23:58] i don't know if we benefit from making it complicated [22:24:36] unless we plan to have 26^4 processors [22:25:27] What I want from the ID is that is tells us exactly what it contains [22:25:58] So we should like... list all the types of IDs we handle [22:26:32] we are using a field called order_id [22:26:48] That one is already regrettably amorphous [22:26:59] https://docs.google.com/spreadsheets/d/1ek-YAnERnZGjCBN1xyKf2a_PeR3vCpDytzsviNzHPcY/edit#gid=0 [22:27:04] esp since we don't process orders [22:27:12] XenoRyet: hi! [22:27:23] Hi [22:27:29] Conversation caught my attention a little bit. [22:27:37] hehehe [22:28:52] is this one a gateway transaction id? or is that something that comes from them? [22:29:20] This one is from us [22:29:25] yeah [22:29:33] it's contribution_tracking_id.sequence_number [22:29:44] but it's got some crap on the front [22:30:01] merchant_reference does make sense [22:32:31] awight: ok based on what you wrote in there, what about PPEC-OID [22:32:50] or even just EC-OID [22:33:36] maybe OID first? [22:33:40] I can dig oid. [22:33:46] it sounds cool. [22:34:05] hehe [22:34:15] I'm a little wary of clashing with order_id though--can we imagine situations where that might be a different number or string?... [22:34:31] I guess this is what it was made for. [22:34:36] When I looked at PPEC-OID the words "PayPal Express Checkout Order ID" instinctively came to mind, so it's got that going for it. [22:34:44] hehe [22:34:45] if Ingenico order_id gives us a problem, we change its name. [22:35:00] XenoRyet: that's a good call--for some reason I wanted the broader class to come first though [22:35:09] Yea, I can see that reasoning too. [22:35:17] abstract and less practical, maybe [22:35:31] lemme see, OID-PPEC-1234567.2 [22:35:34] meh [22:35:37] Not necessarily, just more technical, less narrative. [22:35:45] which isn't a bad thing [22:35:55] I guess the idea is that other gateways would only require OID-123456, also [22:36:02] which is a mild argument in favor of OID first [22:36:14] unless you think we should make them all standardish? [22:36:19] Looking at OID first, it's not hard to read either. [22:36:35] awight: well if we add this stuff on the front, it's no longer an order ID, so we shouldn't use that url param. maybe we should use merchant_reference [22:36:38] for other gateways, we won't need the gateway name :( [22:36:42] ooh [22:36:47] interesting [22:36:55] and unpack it in the listener [22:37:08] or do we want to make order id processing everywhere able to handle these semantic strings? [22:37:25] hmm, that could be cool [22:37:40] cos we do need to retain the merchant_reference in the form that the gateway knows about it. [22:37:46] hrrrm [22:38:04] the name order ID is still weird, but doing this might give it a more solid definition anyway [22:38:36] My descriptive paragraphs suck, they just illustrate how jumbled all of this has become. [22:39:11] are order IDs numeric across the board, except for the dot? [22:39:31] yeah--but the processors seem to universally accept alphanumeric [22:39:45] well that's pretty great then [22:39:54] I'm now leaning towards rehabilitating Order ID [22:40:07] Like you said, this is what it was made for. [22:40:13] i'd be fine with the assumption that order id is a numeric thing that you can stick some alpha stuff on the beginning for flow control [22:40:44] so when a processor gives us the order id... what is it. [22:40:47] if we want to formalize that later we can but it's useful right now too [22:41:03] I sort of want to untether that [22:41:39] what's an example of one where they generate it? [22:42:49] Ingenico (new account), and I believe--PayPal legacy! [22:42:55] at least, according to the source code [22:43:06] order_id_meta = [ 'generate' => false ] [22:43:33] Also, is it just me or does PHP look even stupider and more punctuation-happy with the short array syntax... [22:43:48] hehe [22:44:02] * awight marvels at PayPal supplying order id. How can that be, [22:44:08] it's not the optimization we need, but it's the one we got [22:44:31] oh, for paypal legacy we simply don't use order_id [22:44:46] I would have gone for s/php/py/ [22:45:02] OK so nothing returns order_id to us yet. We can hang that hat [22:45:20] yeah if i have to use a language of their ilk i guess i choose python [22:45:39] I guess, for Ingenico (new account)... we can use their gateway txn id for what it is, and generate our own order_id and jam it into custom fields with the best of em [22:45:54] if we even need to [22:45:58] do we need to? [22:46:30] mebbe not! [22:49:26] cool. Our order id is sort of aligned with Amazon's nice hierarchy of IDs. [22:49:53] as far as namespacing? [22:50:04] They have a different order reference id for each charge [22:50:26] We can do that by incrementing the sequence number at the end :-/ [22:51:09] for each charge...why would there be multiple charges? [22:51:20] for recurring [22:51:35] Hmm, Amazon sets their own order reference id. [22:52:22] we could just rebrand that a gateway transaction id I suppose [22:52:28] k. I'm sort of happy. [22:52:42] oh yeah recurring [22:52:42] We throw contribution_tracking IDs around currently, too. [22:52:49] Maybe we can stop doing that and just use order_id. [22:52:52] yeah [22:53:18] subquestion: do we want to store this in CT anywhere? [22:53:31] no need to [22:53:34] I believe [22:53:42] dang, we send ctid all over the place. [22:53:58] you couldn't differentiate legacy and EC in CT without it [22:54:02] dunno if that matters [22:54:06] I think that's fine [22:54:20] groovy [22:54:22] We only need to care when making another API call, and we would need the gateway txn id also [22:54:41] but this does beg the question of, we need to store the order_id in Civi like you were saying. [22:55:25] Hrm I don't know that we can every prefix a gateway_txn_id. Not safe. [22:55:29] *ever [22:55:41] The gateway might have their own crazy alpha- prefix [22:56:03] yeah [22:56:17] (PS2) Cdentinger: Differentiate express checkout for the back end. [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294639 [22:56:22] (PS3) Cdentinger: Add express checkout identifier to order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294533 [22:56:41] well maybe that name is a little better anyway, i've gotta actually go now. later! [22:56:46] (CR) Awight: [C: 2] "safe." [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/294639 (owner: Cdentinger) [22:56:54] see ya! [23:13:27] (CR) Awight: [C: 2] "I'm not certain this is safe, but let's go ahead and try it!" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294533 (owner: Cdentinger) [23:15:19] (Merged) jenkins-bot: Add express checkout identifier to order_id [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294533 (owner: Cdentinger) [23:18:13] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2384212 (awight) @Jgreen I ge... [23:46:13] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2384284 (awight) I'm not sure...