[00:54:18] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix the group performance issue ... better - https://phabricator.wikimedia.org/T139006#2432243 (Eileenmcnaughton) So the 2 patches for this are https://gerrit.wikimedia.org/r/296689 https://... [00:54:37] (PS4) Awight: Request startUp and geoIP RL modules instead of bannerController [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296493 (https://phabricator.wikimedia.org/T138875) (owner: AndyRussG) [00:54:50] (CR) Awight: [C: 2] "Great cleanup!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296493 (https://phabricator.wikimedia.org/T138875) (owner: AndyRussG) [00:57:07] (Merged) jenkins-bot: Request startUp and geoIP RL modules instead of bannerController [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296493 (https://phabricator.wikimedia.org/T138875) (owner: AndyRussG) [01:02:21] cwd|afk: let's try jumping to the 1.28.wmf branch on Thursday--we could even be incremental and only do so on the jessie servers [01:02:37] I don't think it involves changes to fundraising_code_update [01:02:54] I'm all for your idea! [01:18:31] (PS5) Awight: Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (https://phabricator.wikimedia.org/T137761) (owner: Ori.livneh) [01:22:04] (CR) Awight: [C: 2] "This is a great idea, plus it's a good fundraising season for experimentation. Thank you for catching these leftovers from our panicked s" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (https://phabricator.wikimedia.org/T137761) (owner: Ori.livneh) [01:25:23] (Merged) jenkins-bot: Revert "Prevent Google indexing of the CentralNotice div" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293911 (https://phabricator.wikimedia.org/T137761) (owner: Ori.livneh) [01:35:28] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, and 2 others: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2378014 (awight) a:awight [01:59:05] AndyRussG|sortof: ah hah, finally tracked down my failure to CentralNotice... [01:59:17] err maybe. [02:00:16] or maybe FireFox can't set breakpoints in the geoip promise [02:42:34] AndyRussG|sortof: Ok, debugging with Chrom* I found that a legacy bucket cookie was jamming display, cos it had been set to "1" while my campaign had 2 buckets. When I reduced the number of buckets to 1, the modulo thing didn't happen. [02:42:55] Can this condition never happen, or should we fix this as a regression bug? [02:43:44] * awight blinks [02:43:57] --not a cookie, but a "legacy" localstorage entry [02:44:24] sorry to drag you through my process of rediscovering this code... [02:48:26] is "val" one-based?? [02:52:16] (PS3) Awight: Prevent banners on Special pages server-side [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296623 (owner: AndyRussG) [02:52:34] (CR) Awight: [C: 2 V: 1] "Optimized! Great approach..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296623 (owner: AndyRussG) [02:52:42] (PS3) Awight: Don't show the banner on action=edit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296275 (https://phabricator.wikimedia.org/T138177) (owner: Ori.livneh) [02:54:51] (Merged) jenkins-bot: Prevent banners on Special pages server-side [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296623 (owner: AndyRussG) [03:03:55] (CR) Awight: [C: 2 V: 1] "Hooray, nicely done!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296275 (https://phabricator.wikimedia.org/T138177) (owner: Ori.livneh) [03:08:43] (Merged) jenkins-bot: Don't show the banner on action=edit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296275 (https://phabricator.wikimedia.org/T138177) (owner: Ori.livneh) [03:09:18] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and action=edit pages - https://phabricator.wikimedia.org/T139439#2432367 (awight) [03:09:47] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and action=edit pages - https://phabricator.wikimedia.org/T139439#2432367 (awight) [03:12:00] that's all... [08:00:20] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2432535 (MoritzMuehlenhoff) p:Triage>Normal [16:25:53] !log update orphan rectifier config to add payments 4 to the Redis pool [16:25:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:26:28] !log update orphan rectifier from 2fc573cbb94e833c4144aa9dad79de8ec374bb09 to 70a7baa9f77c2510739bab0ff9d1b51578a59a6e [16:26:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:44:03] (PS4) Awight: Implement popAtomic for Redis [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/293248 (https://phabricator.wikimedia.org/T133964) [16:47:20] (CR) Awight: Implement popAtomic for Redis (2 comments) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/293248 (https://phabricator.wikimedia.org/T133964) (owner: Awight) [16:47:39] ejegg: ^ interesting find wrt the "noop" exceptions... [16:47:43] not sure what to make of that [16:48:50] Here's the announcement of the CAS transactions, https://gist.github.com/nrk/761863 [16:49:09] noop? Lemme see [16:49:25] just the link you pasted, https://github.com/nrk/predis/blob/0e17edbefb50c6cbd1acc4a6f6ef06399deb1af2/src/Transaction/MultiExec.php#L425 [16:49:38] ah right, the retry thing [16:50:03] oh, now it looks like it doesn't retry if there's an exception. huh [16:50:07] wat [16:50:41] the lexical scope of $exception creeps me out, too... so ANSI C [16:52:51] yeah... I can't see how it actually retries [16:53:05] not that it's got anything to do with your patch... [16:53:43] seems to retry only if $execResponse === null [16:54:32] Intuitively, I think that only happens if the CAS watched variable changes? [16:55:32] makes sense--the watching is on the server side [16:55:35] aha [16:55:53] yep, there it is: http://redis.io/commands/exec [16:56:04] returns null when using watch, if execution was aborted [16:56:09] k, see ya in standup... [16:56:14] see ya [17:12:20] fr-tech: any news for Scrum of Scrums? [17:12:32] None here [17:13:16] ejegg: might mention the new servers i guess [17:13:32] will do [17:36:13] PPena: Ukraine test today, I think we should just do Adyen (no ingenico) as traffic was so low last time. agree? [17:55:35] the-wub sure! [17:55:48] the-wub sorry just saw that now [17:55:57] PPena: no problem :) [17:56:35] dstrine: do we have a volunteer from tech to monitor Israel and Ukraine? [17:58:19] the-wub: I can do it [17:58:31] cool, thanks ejegg! [17:59:50] ppena_ MBeat ejegg : everyone okay with me putting banners up now? [18:00:07] definitely, thanks the-wub [18:00:18] sure the-wub [18:02:14] okay, we're up for an hour. If there aren't any problems, I think we should aim to leave Israel up [18:04:17] the-wub: and PPena we'll have to take all campaigns down in a few hours due to civi and they will need to stay down until friday. It's up to you if you want to keep IL up for jsut a few hours [18:06:15] dstrine: oh yeah good point. let's try and leave it up until then anyway - there is an interesting test that I would like to have more data on, even if it's just a few hours [18:06:31] the-wub: ok cool [18:10:30] the-wub: logs are looking food so far [18:10:33] *good [18:10:55] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Changing the name of custom field Anonymous to Benefactor Page Listing - https://phabricator.wikimedia.org/T139494#2434008 (RLewis) [18:11:10] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Changing the name of custom field Anonymous to Benefactor Page Listing - https://phabricator.wikimedia.org/T139494#2434023 (RLewis) Open>Resolved [18:20:04] looking fairly good so far. I see 19 adyen donations from Ukraine, and about 6 from Israel [18:22:12] looks good at Adyen portal [18:27:24] (CR) Ejegg: "The test looks good, but I'm leary of depending on mysql aggregation quirks. Maybe split into two queries, one for aggregates and one for" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [18:27:47] the-wub, do you have a landing page URL for Israel that will point to Adyen for CC donors to retry? [18:29:52] MBeat: hang on, let me just re-enable cc on donatewiki... [18:32:19] MBeat: done. English: https://donate.wikimedia.org/?country=IL&uselang=en Hebrew: https://donate.wikimedia.org/?country=IL&uselang=he [18:32:27] thank you!! [18:32:36] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/293248 (https://phabricator.wikimedia.org/T133964) (owner: Awight) [18:32:42] ejegg: ty! [18:34:04] (PS3) Ejegg: Check in Adyen iframe skin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294392 (https://phabricator.wikimedia.org/T137811) [18:47:44] hmm... still looking good but I would like to leave Ukraine up for another hour. that okay with you ejegg MBeat ? [18:48:06] for sure, the-wub [18:53:40] the-wub MBeat dstrine how is it looking? [18:54:10] good - one error from an AmEx donor in Israel that I’m looking into [18:54:49] looks good to me. results are in the usual doc [18:55:04] https://docs.google.com/spreadsheets/d/17arGLTPupnrCmo7O0He38js-gmOoF3OY53sOwiAbAp0/edit#gid=292722186 [18:55:05] it looks like the form gave an error message: Invalid card number, before they submitted details to Adyen [18:55:22] (CR) Ejegg: [C: 2] "thanks for the fix!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297374 (https://phabricator.wikimedia.org/T136252) (owner: Eileen) [18:57:55] (Merged) jenkins-bot: Fix for regression in tests. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297374 (https://phabricator.wikimedia.org/T136252) (owner: Eileen) [19:03:09] ejegg: have you seen any of these form chooser errors this time around? https://phabricator.wikimedia.org/T137978 [19:07:53] the-wub: checking [19:09:28] the-wub: yep, about 15, all for paypal. let me check the form settings [19:10:01] :( [19:10:21] weird, paypal form settings have no country/currency restrictions at all [19:10:39] so what's the issue here? [19:10:41] Huh [19:11:11] ohhh, it's got gateway=adyen and method=paypal [19:11:16] the-wub: ^^ [19:12:06] ejegg: okay, looking. these are all from Ukraine? [19:14:56] the-wub: yep, all UA/UAH [19:15:12] B1516_0706_enruukUA_dsk_p2_sm_pym_adyen [19:24:39] got payments running on 1.28 and seeing some weird behavior, my first thought is async js loading [19:26:55] ejegg: okay, think that should be fixed now [19:27:12] nice! [19:29:07] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2434498 (Ottomata) OH man, I k... [19:35:53] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Form chooser error from Ukranian Adyen-PayPal form - https://phabricator.wikimedia.org/T137978#2434536 (Pcoombe) Okay, think this should be fixed now. The credit card button in these banners sets the gateway field to Adyen. Howeve... [19:38:20] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2434548 (Jgreen) We also uncov... [19:40:27] (CR) Ejegg: "may be stepping on a local bartik theme css hack" (1 comment) [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/296490 (https://phabricator.wikimedia.org/T138890) (owner: Eileen) [19:41:20] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2434555 (CCogdill_WMF) Wow, th... [19:43:47] (CR) XenoRyet: [C: 2] Check in Adyen iframe skin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294392 (https://phabricator.wikimedia.org/T137811) (owner: Ejegg) [19:44:38] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2434574 (Ottomata) @CCogdill_W... [19:45:24] (CR) Ejegg: "Also some local modifications in user.module" (1 comment) [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/296490 (https://phabricator.wikimedia.org/T138890) (owner: Eileen) [19:46:11] (Merged) jenkins-bot: Check in Adyen iframe skin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294392 (https://phabricator.wikimedia.org/T137811) (owner: Ejegg) [19:46:28] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2434578 (Ottomata) Well, let m... [19:52:58] (CR) Ejegg: "The user.module changes seem to no longer be necessary. I guess we fixed that stuff in the phpunit bootstrap. I'll make a lil patch for " [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/296490 (https://phabricator.wikimedia.org/T138890) (owner: Eileen) [19:56:19] (PS3) XenoRyet: Adyen iframe hacks to fix CVV input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294394 (https://phabricator.wikimedia.org/T137811) (owner: Ejegg) [19:57:50] (CR) XenoRyet: [C: 2] "This version of the skin is live and working now." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294394 (https://phabricator.wikimedia.org/T137811) (owner: Ejegg) [20:01:07] (PS1) Ejegg: Patch for bartik font change [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/297638 [20:01:09] (PS1) Ejegg: Custom font for Bartik [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/297639 [20:01:26] (Merged) jenkins-bot: Adyen iframe hacks to fix CVV input [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/294394 (https://phabricator.wikimedia.org/T137811) (owner: Ejegg) [20:03:08] right, Ukraine test is over ejegg PPena MBeat. will update final results and send round in a bit. I think we're okay to leave Israel up too [20:03:33] thank you, the-wub [20:03:49] ejegg: did you see any more form chooser errors since I tweaked the banners earlier? [20:03:59] (backscrolling) are we going to leave IL up even through the Civi outage? [20:06:03] the-wub: taking a look [20:06:57] MBeat: no, it will come down with the other campaigns for Civi maintenance [20:07:05] the-wub: nope, last one was a few minutes before you said here you'd fixed something! [20:07:15] great! thanks [20:07:25] ty [20:07:26] great, ty for the confirm the-wub [20:07:28] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Form chooser error from Ukranian Adyen-PayPal form - https://phabricator.wikimedia.org/T137978#2434674 (Pcoombe) Open>Resolved [20:10:33] Fundraising-Backlog: Adyen Israel form & AmEx validation - https://phabricator.wikimedia.org/T139523#2434689 (MBeat33) [20:15:08] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2434715 (awight) @Ottomata Fan... [20:15:16] Fundraising-Backlog: Adyen Israel Hebrew form & autofill cardholder name - https://phabricator.wikimedia.org/T139524#2434716 (MBeat33) [20:19:36] oh wow, the clicktracking mystery is solved! [20:21:48] huge! [20:22:10] It just added a year to the end of my life, I'm pretty sure [20:23:11] eileen: Anything I can CR or otherwise help with? [20:23:30] With every answer come 10 new questions! [20:23:52] so true! [20:24:00] awight: cwd: ejegg: XenoRyet: hey... trying to think of when a good time to schedule a big CN deploy is... [20:24:26] I'm thinking of maybe tomorrow's evening SWAT deploy [20:24:33] Fundraising-Backlog: Adyen Israel Hebrew form & autofill cardholder name - https://phabricator.wikimedia.org/T139524#2434753 (Ejegg) So, @Amire80 told us in T135416 that Israeli donors often will enter their name in Hebrew in the 'contact' form, then enter their name in latin characters for the cardholder na... [20:24:46] AndyRussG: I was imagining we lightning deploy at something like 9AM Pacific, tomorrow [20:24:53] To take advantage of our campaigns being down [20:25:02] AndyRussG: what do you think about the extension registration patch? [20:25:26] crud. merge conflicts already. [20:25:36] * awight puts on caving boots [20:25:48] oops [20:25:56] It gets stale real fast... [20:26:46] awight: aaarg sorry about that, I'll check it out before doing any other CR or codding... [20:26:58] * AndyRussG cod-slaps self [20:27:09] sorry likewise to throw such a cruftball in your general direction [20:27:34] Heh I'm sure it's not so crufty... [20:27:53] What time is the campaign outage again? [20:28:10] Wouldn't that distract from fixing potential problems w/ the civi stuff? [20:28:27] awight: this really needs to be in our deploy https://gerrit.wikimedia.org/r/#/c/297520/ [20:28:43] because otherwise there are some server killing queries on the manage groups tab [20:29:04] Also if we SWAT deploy we can farm it out to opsen, also freeing up fr-tech resources... [20:29:07] Fundraising-Backlog: Adyen Israel Hebrew form & autofill cardholder name - https://phabricator.wikimedia.org/T139524#2434771 (Ppena) That's a good point. Could we autofill but show anyways and give donors the chance to change if they want to? [20:29:08] AndyRussG: We'll probably just focus on Civi until it's finished, yeah. But the expectation is that it'll be resolved tonight. [20:29:12] that has been the case since 4.6 but in 4.6 I reverted the commit that caused the problem in the Fuzion repo & just used it for wmf [20:29:25] but I think I have properly solved it now [20:29:37] AndyRussG: our maintenance window is 9AM-5PM pacific [20:29:42] Hmmm [20:29:45] eileen: will do [20:30:00] unfortunately your ability to really interpret that & QA it has to be quite low - because it's not code you can really just make sense of [20:30:03] eileen: want to do a vidchat and talk us through the things that need reviewing? [20:30:07] AndyRussG: if you want to try the morning swat, I'm sure we could nudge the leading edge of our maintenance window [20:30:30] ok sure [20:30:42] SWAT is at 8-9 am and 4-5 pm PDT [20:31:01] awight: live review session? [20:31:57] ejegg: cool [20:31:59] What about wanting one thing to settle before doing the other? Maybe we need to be able to watch stats to make sure CN deploy causes no big bumps, so we should wait 'till civi settles before possibly thrashing CN? [20:32:19] awight: ^ [20:32:27] SHould we use the spring planning link? [20:32:27] Fundraising-Backlog: Adyen Israel Hebrew form & autofill cardholder name - https://phabricator.wikimedia.org/T139524#2434716 (DStrine) >>! In T139524#2434771, @Ppena wrote: > That's a good point. Could we autofill but show anyways and give donors the chance to change if they want to? That's what we do by de... [20:32:27] AndyRussG: that would be ideal, but we have a lot of churn to push out. [20:32:33] Ah K [20:32:41] Also I was thinking of asking Krinkle when he's available, in case there are RL issues [20:32:49] AndyRussG: don't do anything you're uncomfortable with, of course! [20:33:11] I'm just supplying low-level, continuous support for throwing anything we can into the pyre tomorrow though [20:33:27] AFIK the main stats to keep an eye on will be banner impressions and donation levels [20:33:30] ... to contain the breakage [20:34:04] eileen / awight: sure, sprint planning link for CR sounds good [20:35:11] It sounds like the civi stuff is more risky and has required more planning. So let's do the CN deploy after rather than before [20:35:39] AndyRussG: Civi will be deployed tonight from 5-7:30 Pacific [20:35:59] & we're certainly doing a big Payments push tomorrow, too [20:36:10] cwd: btw, is the 1.26 branch ready to go? [20:36:20] sorry for the startle ;) [20:36:29] awight: i'm afraid there are gonna be bugs in the 1.28 transition [20:36:32] Apologies for not knowing... rrrg so the window tomorow isn't for civi? [20:36:36] But for payments? [20:36:37] cwd: sure, but 1.26 [20:36:45] awight: oh, yeah that one should be fine [20:36:50] AndyRussG: it's for us to catch up on everything that's been stewing over the last 2 weeks [20:36:52] it's up on gerrit, one sec [20:36:59] cwd: but it probably needs more backports? [20:37:18] from mainline REL1_26 and from DI 1.25? [20:37:23] awight: just whatever we deploy tomorrow [20:37:38] hmm, not that i know of [20:38:07] K well if it needs a campaign outage window, it's big enuf to worry about not putting out other risky stuff right before [20:38:31] we can talk in a minute... [20:38:33] awight|mtg: https://gerrit.wikimedia.org/r/#/c/293158/ [20:38:59] cwd: that looks great, but we need to bump the DI submodule at the least, right? [20:39:39] awight|mtg: well it's up to date right now but whatever we deploy tomorrow will have to get backported [20:53:26] Fundraising-Backlog: Adyen Israel Hebrew form & autofill cardholder name - https://phabricator.wikimedia.org/T139524#2434856 (MBeat33) Ah, it's good to know the localization. I will ask two community members listed in Jessica's contacts doc what they would expect from a Hebrew form. [21:01:30] (CR) Awight: [C: 2] CRM-19015 Merge data loss on zero fields (batch mode) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297342 (owner: Eileen) [21:01:39] (CR) Awight: [C: 2] CRM-18692 issue warning about empty smart group cache rather than crash the server [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/296689 (https://phabricator.wikimedia.org/T139006) (owner: Eileen) [21:01:39] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and action=edit pages - https://phabricator.wikimedia.org/T139439#2434869 (AndyRussG) Proposed deploy slot: Thursday 2016... [21:01:49] (CR) Awight: [C: 2] CRM-17123 remove damaging OR from smart group query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297520 (owner: Eileen) [21:03:20] Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, and 2 others: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2434873 (AndyRussG) Is this deploy slot doable: Thursday 2016-07-07 4... [21:05:14] (CR) jenkins-bot: [V: -1] CRM-18692 issue warning about empty smart group cache rather than crash the server [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/296689 (https://phabricator.wikimedia.org/T139006) (owner: Eileen) [21:05:16] (CR) jenkins-bot: [V: -1] CRM-17123 remove damaging OR from smart group query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297520 (owner: Eileen) [21:09:34] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/296689 (https://phabricator.wikimedia.org/T139006) (owner: Eileen) [21:14:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2434906 (Eileenmcnaughton) [21:14:11] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 2 others: setup dedupe exact matches prototype on staging - https://phabricator.wikimedia.org/T133808#2244827 (Eileenmcnaughton) Open>Resol... [21:15:10] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297520 (owner: Eileen) [21:17:00] Fundraising Sprint Licking Cookies, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2397177 (Eileenmcnaughton) Some questions how this will work on live with proxy - let's see after the deploy [21:19:13] Fundraising Sprint Licking Cookies, Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Tunnel and test Jessie paymentswiki - https://phabricator.wikimedia.org/T137975#2385725 (cwdent) Open>Resolved 1005 has been tested, pooled, de... [21:21:33] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297700 [21:24:42] (CR) Eileen: [C: 2] "Self merging as submodule commit" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297700 (owner: Eileen) [21:30:20] (PS3) Eileen: Drupal core udpate. [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/296490 (https://phabricator.wikimedia.org/T138890) [21:30:56] (CR) Eileen: "ejegg - I have removed that line from bartik/css" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/296490 (https://phabricator.wikimedia.org/T138890) (owner: Eileen) [21:40:07] (CR) Ejegg: [C: 2] Drupal core udpate. [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/296490 (https://phabricator.wikimedia.org/T138890) (owner: Eileen) [21:42:06] Fundraising Sprint M 2016, Fundraising-Backlog: Adyen Israel form & AmEx validation - https://phabricator.wikimedia.org/T139523#2435001 (DStrine) [21:42:10] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and action=edit pages - https://phabricator.wikimedia.org/T139439#2435002 (DStrine) [21:42:12] (Merged) jenkins-bot: Drupal core udpate. [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/296490 (https://phabricator.wikimedia.org/T138890) (owner: Eileen) [21:42:13] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix the group performance issue ... better - https://phabricator.wikimedia.org/T139006#2435003 (DStrine) [21:42:17] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add WMF donor fields to Civi production - https://phabricator.wikimedia.org/T138968#2435004 (DStrine) [21:42:19] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Patch-For-Review, and 2 others: Ingenico donation form: email address autosuggestion is confusing donors - https://phabricator.wikimedia.org/T138957#2435005 (DStrine) [21:42:23] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create new prospecting fields - https://phabricator.wikimedia.org/T138908#2435006 (DStrine) [21:42:28] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Upgrade to CiviCRM 4.7.9 - https://phabricator.wikimedia.org/T138802#2435007 (DStrine) [21:42:30] Fundraising Sprint Licking Cookies, Fundraising-Backlog: SPRINT L (6/8- 6/22) Paypal and dedupe all day - https://phabricator.wikimedia.org/T136250#2435008 (DStrine) Open>Resolved [21:42:32] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, FR-Adyen, Unplanned-Sprint-Work: Handle refund mismatch more correctly - https://phabricator.wikimedia.org/T138542#2435009 (DStrine) [21:42:41] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2435012 (DStrine) [21:43:00] Fundraising Sprint Killing Time, Fundraising Sprint M 2016, Fundraising-Backlog, FR-Adyen, and 3 others: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2435032 (DStrine) [21:43:04] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2435033 (DStrine) [21:43:09] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Add autocomplete hints to donation form - https://phabricator.wikimedia.org/T137716#2435034 (DStrine) [21:43:12] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, FR-Adyen, and 3 others: bug: Adyen JPY transactions have different amounts in CIVI vs Adyen - https://phabricator.wikimedia.org/T137607#2435035 (DStrine) [21:43:25] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: Kill staged_vars - https://phabricator.wikimedia.org/T137387#2435040 (DStrine) [21:43:33] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, and 2 others: Special:LoadBanners should scream if translation fails - https://phabricator.wikimedia.org/T137247#2435044 (DStrine) [21:43:37] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create new prospecting fields - https://phabricator.wikimedia.org/T138908#2413664 (Eileenmcnaughton) a:Eileenmcnaughton [21:43:44] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, FR-Adyen, and 4 others: Adyen staging functions should be rewritten as helpers - https://phabricator.wikimedia.org/T137157#2435047 (DStrine) [21:43:55] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Prepare 4.7 CiviCRM branch & clean our patches into it - https://phabricator.wikimedia.org/T136252#2435051 (DStrine) [21:44:18] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog: SPRINT L (6/8- 6/22) Paypal and dedupe all day - https://phabricator.wikimedia.org/T136250#2435058 (DStrine) [21:44:21] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, and 2 others: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2435059 (DStrine) [21:44:25] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog: CentralNotice: finalize list of wild useless cookies for slurp, and push config change - https://phabricator.wikimedia.org/T135090#2435060 (... [21:44:28] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Agree acceptance criteria for deciding the script is 'ready' - https://phabricator.wikimedia.org/T135062#2435075 (DStrine) [21:44:30] Fundraising Sprint M 2016, Fundraising-Backlog: Move payments to mediawiki 1.26 - https://phabricator.wikimedia.org/T139531#2435061 (cwdent) [21:44:37] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe: review the rest of the code in our merge hook - https://phabricator.wikimedia.org/T135057#2435077 (DStrine) [21:44:39] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, and 2 others: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2435078 (DStrine) [21:44:46] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 6 others: Implement Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2435080 (DStrine) [21:44:49] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 5 others: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData a... - https://phabricator.wikimedia.org/T134310#2435081 [21:44:54] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 8 others: Write high-level SmashPig DonationQueue - https://phabricator.wikimedia.org/T133965#2435082 (DStrine) [21:44:57] Fundraising Sprint Internet Exploring, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, and 5 others: Implement AtomicReadBuffer for choice of PHP-Queue backend - https://phabricator.wikimedia.org/T133964#2435083 (DStrine) [21:45:00] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 5 others: Move queue2civicrm_generate_message to test support - https://phabricator.wikimedia.org/T133712#2435084 (DStrine) [21:45:03] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Write a hook to skip the calculated tables from conflict consideration - https://phabricator.wikimedia.org/T133625#2435085 (DStrine) [21:45:06] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 7 others: Write pending queue consumer and schema - https://phabricator.wikimedia.org/T133197#2435086 (DStrine) [21:45:17] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 9 others: All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2435087 (DStrine) [21:45:19] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or del... - https://phabricator.wikimedia.org/T132640#2435088 [21:45:25] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets,... - https://phabricator.wikimedia.org/T132639#2435092 [21:45:31] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2435093 (DStrine) [21:45:35] Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 5 others: Only subscribe primary emails, secondary addresses should be suppressed - https://phabricator.wikimedia.org/T131979#2435094 (DStri... [21:45:39] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 10 others: [Epic] Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2435095 (DStrine) [21:45:42] Fundraising Sprint Freshmaking, Fundraising Sprint Ghostbusting , Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, and 7 others: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2435096 (DStrine) [21:45:47] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 8 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2435097 (DStrine) [21:45:54] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2435102 [21:45:58] Fundraising Sprint Licking Cookies, Fundraising Sprint M 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#2435103 (DStrine) [21:46:04] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 7 others: Don't make donors guess minimum donation amount - https://phabricator.wikimedia.org/T105618#2435104 (DStrine) [22:12:49] (PS2) Ejegg: Check in custom hack to register namespaced classes [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/297521 (owner: Awight) [22:21:10] (CR) Ejegg: [C: 2] Check in custom hack to register namespaced classes [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/297521 (owner: Awight) [22:23:23] (Merged) jenkins-bot: Check in custom hack to register namespaced classes [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/297521 (owner: Awight) [22:29:47] hey ejegg, do you have a minute for a question? [22:30:30] sure cwd [22:31:50] thanks! ok so on .26 and later i get "mw is not defined" on GC forms. it should get passed in to gc.interface.js. do you know off hand where to look for that? the only reference i see is in extensions.json [22:33:58] Fundraising Sprint Muggle Baiting, Fundraising-Backlog: Adyen Israel form & AmEx validation - https://phabricator.wikimedia.org/T139523#2435372 (XenoRyet) a:XenoRyet [22:33:59] (the symptom of this is i see the old green form) [22:43:30] (PS1) Eileen: Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297708 [22:45:56] (CR) Eileen: [C: 2] "submodule commit - self merging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297708 (owner: Eileen) [22:51:53] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Monitoring, Spike: Identify most offensive issues in the DonationInterface logs - https://phabricator.wikimedia.org/T139423#2435483 (Danny_B) [22:59:56] ejegg: hope i didn't send you down the rabbit hole. i am thinking maybe there was a change to resource loader? [23:00:24] so sorry, I got distracted and forgot to afk [23:00:34] switching over to 1.26 [23:00:46] no worries! thanks for looking [23:01:04] i have a feeling this is going to get ugly but maybe you have some inside info [23:01:27] js race conditions are a bad time [23:02:31] cwd does it go away under debug=true? [23:05:49] ejegg: nope i still get it [23:06:43] ok, guess nothing can depend on mw being defined till document ready? Seems reasonable [23:06:57] I'm getting it under both conditions too [23:07:53] do we need to rearrange all these rapidhtml forms? [23:08:14] or can we make them dependencies of something that waits for document ready? [23:08:25] in extension.json maybe? [23:09:00] hmph, i don't want to waste too much time screwing with those old forms [23:09:55] yeah, it would be nice to just kill them but GC seems like a bigger job than the others [23:10:05] i don't really know the scope of it [23:10:18] sure is, just trying to think of ways to avoid it [23:10:46] only idea so far is horrible, and it's a fake mw object to defer all the mw.loader.load calls [23:11:17] (while causing all sorts of fun side effects, I'm sure) [23:12:04] hmmm, yeah i just don't know how resource loader works well enough to say [23:12:36] js itself can be very hard to reason about when there are this many moving pieces [23:12:45] i assume resource loader when used properly handles that stuff [23:13:02] cwd I guess move the dependency listing from html to FormSettings.php [23:13:06] but probably rapidhtml doesn't conform [23:13:22] where is it in html? [23:13:44] Top of like 50 .html files in the forms/ directories [23:14:22] oh yeah [23:14:34] eh, seems like a slight cleanup too. just reviewing the mapping will be tedious [23:15:14] I'll take a crack at it [23:21:45] ejegg: no jquery available in rapidhtml? [23:22:16] err, i'm not sure [23:22:39] doesn't seem like it, though it could be the same race condition [23:22:51] guess it'd be an easy search & replace, but lemme just try dumping the dependencies with a maintenance script [23:24:59] I'm going to merge the code for deploy into the deployment branch now - I'm still trying to replicate the problem with the merge hook patch in a test so will leave that out - can work on that while the script is running.... [23:26:13] ejegg: setting a timeout worked so it's definitely a new race condition [23:26:46] k [23:30:53] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/297712 [23:31:45] awight: happy about this being in the deploy set ?https://gerrit.wikimedia.org/r/#/c/294123/ [23:31:59] (set is here https://gerrit.wikimedia.org/r/#/c/297712/) [23:32:25] also this is yours (awight) https://gerrit.wikimedia.org/r/#/c/283112/ [23:32:46] & this https://gerrit.wikimedia.org/r/#/c/294123/ [23:33:26] ejegg: this one ok to go out? https://gerrit.wikimedia.org/r/#/c/289716/ [23:34:08] & this is the last one that is not 'mine' [23:34:10] https://gerrit.wikimedia.org/r/#/c/290372/ [23:34:59] Will be able to read that in about 10 minutes [23:35:35] ok - just eyeball it to check nothing being deployed unexpectedly [23:42:26] Jeff_Green: step one on our list … Confirm recent backup was succesful …. hoping it was [23:42:43] oh sorry - you are still at your other thing - ignore!!! [23:47:20] eileen: yeah, that one should be safe [23:52:57] eileen: yep, I'm happy deploying those changes you flagged [23:53:29] cool - I'll merge it then [23:53:41] ty! [23:53:50] Anything I can do to help prep? [23:53:58] (CR) Eileen: [C: 2] "Self-merging as this is putting master changes into deployment branch" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/297712 (owner: Eileen) [23:54:25] awight: I think the repos are OK - we are onto the check list [23:54:26] https://etherpad.wikimedia.org/p/2016-jun-14-civi47upgrade [23:54:57] ccogdill: just confirming that no emails have gone out over the past day? [23:55:30] nope awight, no emails this week at all [23:55:39] thanks! [23:56:50] awight: so 4 & 5 are Jeff? [23:57:16] ccogdill: I've been meaning to ask how your "seed" list works, actually--are there docs? It seems to be more than just a CC of everything going out to real lists... [23:57:22] eileen: yes [23:57:24] (NB I like this re-usable etherpad list) [23:57:47] I love it too! [23:58:58] umm that’s basically all it is… occasionally it gets turned off if we’re testing something and forget to turn it back on [23:59:10] what info are you looking for?