[00:00:06] ccogdill: ah okay, that's all I was wondering, I guess [00:00:25] but sometimes I see a few variations go out in a volley--is that the A and B of a test? [00:00:34] OK - I think I'll do 6 & 13 now - email & put into mtce from drupal point of view [00:00:59] great! [00:01:04] * awight rattles pom-poms [00:01:28] I'll #12 shut down the campaigns [00:01:34] woot [00:03:07] oh yeah, we’re always A/B/C etc testing [00:03:14] so you’ll usually see a bunch at once awight [00:04:02] yesterday's backup looks normal [00:04:11] cool [00:04:53] ccogdill: that's rad. The history of tests should be automatically archived online, too... [00:05:10] automatically? that would be wonderful [00:05:38] for now I make google docs of every send… see column AF https://docs.google.com/spreadsheets/d/1dXYudLg9EYC00efKDjFRNv4mqUK8to1fxjB4I2cAhNc/edit#gid=0 [00:07:40] awight: who is shutting down campaigns? is that done? [00:08:28] eileen: oops, I'm doing so slowly [00:08:49] no that's cool - I think Jeff_Green is still working through some things too [00:11:57] are we still doing step 14 or did we decide it's ok to leave payments up? [00:12:49] awight: ? I think they are coming down but? [00:13:06] Jeff_Green: it should be done [00:13:20] eileen: I've got 70% of them disabled, so far [00:13:26] cool [00:13:34] ok. another question: i see we have the dedupe cron disabled for barium, did we move that to jenkins? was it supposed to be up this whole time? [00:14:42] I don't even know what that is :-) [00:15:04] Fundraising Sprint Muggle Baiting, Fundraising-Backlog: Make RapidHTML work with mediawiki 1.26 - https://phabricator.wikimedia.org/T139551#2435747 (cwdent) [00:15:48] it's the thingie that goes through civi records and (afaik) looks for similarities and attempts to merge them under the same donor [00:16:19] #12 campaigns are down. [00:16:30] I didn't think we were doing that yet… [00:18:09] Jeff_Green: what roles does fdb2001 have? [00:18:38] eileen: I don't understand--was that supposed to be timed somehow? [00:18:45] I thought 5-7:30 was our window [00:18:57] fdb2001 is just an offsite fundraising database slave, in theory we could cut to it if eqiad is levelled or whatever [00:19:42] cool, I'll try to give that a symbolic name in the doc [00:20:04] which doc? [00:20:20] awight: I meant yet as in "it's the thingie that goes through civi records and (afaik) looks for similarities and attempts to merge them under the same donor" - not the steps in the list [00:20:22] also fwiw i'm going to rename them all fdb* as we replace them [00:20:52] eileen: got it! [00:22:11] eileen: that's the legacy dedupe job which I had started writing, which simply tags contacts that match a dedupe rule. It burns a few cycles, we should stop running it for sure [00:22:25] ok - looks like it's time for me to push GO on deploying the code [00:22:29] whee! [00:22:46] awight: looks like we'd already done that, but i didn't rip out the puppet bits [00:22:50] * awight looks to the horizon for a puff of cmoke [00:22:57] awight: are we confident we'll never run it again? [00:23:12] Jeff_Green: if we do, it will pick up exactly where it left off, anyway [00:23:19] !log Updated CiviCRM from bb9bf136dc0fa82d5d07ebeb33d696e54672b2d6 to 54e168db2fddc6a9a07036323e01a27dd64333cf [00:23:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:24:40] ok Jeff_Green so you need to run the trigger drop... [00:24:48] ok [00:24:53] & 17 [00:24:59] then I kick off 18 [00:25:03] then we wait 90 mins [00:25:25] (well actually I will probably obsessively check what's happening every few seconds for 90 mins) [00:28:35] trigger dropped, now checking [00:29:03] ready for #18 [00:29:52] DANG [00:29:54] WD php: Exception: CiviCRM 4.7.9 requires MySQL trigger privileges [00:30:00] I didn't hit that on staging [00:31:13] which user are we talking about? [00:31:24] I ran it using drush - so www-data [00:31:44] I think I can just hack out that check [00:31:46] it would be civicrm, civiadmin, or drupal i guess? [00:32:03] yeah - but I guess www-data [00:32:07] so, 2 choices [00:32:17] 1) give www-data temp higher mysql perms [00:32:18] or [00:32:32] 2) I hack out that check - I think it will otherwise go ok [00:32:37] +1 (2) [00:32:56] if the check is the only place we're going to run up against it i'd vote 2 also [00:33:18] if we run into it in other places, it's a good thing that we get alerted to the fact tho [00:33:23] ugh [00:34:35] I think it is… [00:38:17] (PS1) Eileen: Show triggers as permitted if the setting says to manage them offline [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297724 [00:38:24] k, cr'ing [00:38:37] I think this change will do it [00:38:37] https://gerrit.wikimedia.org/r/#/c/297724/ [00:40:10] (CR) Awight: [C: 2] "Smarter Record!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297724 (owner: Eileen) [00:42:54] (Merged) jenkins-bot: Show triggers as permitted if the setting says to manage them offline [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297724 (owner: Eileen) [00:43:18] (PS1) Ejegg: WIP fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [00:43:30] Jeff_Green: did you figure out how to restart Jenkins with all the jobs disabled? [00:43:57] awight: i just did a sed -i to mangle the xml files [00:44:52] (PS1) Eileen: Submodule update Show triggers as permitted if the setting says to manage them offline [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297726 [00:45:15] Jeff_Green: nice. I'll add that to the steps [00:45:21] (CR) Eileen: [C: 2] "submodule update, self-merge" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297726 (owner: Eileen) [00:45:37] awight: lemme see if I can remember what I did [00:46:50] Seems like there should be a Jenkins plugin to do that :( [00:47:40] or even a core feature [00:47:48] 8D [00:47:59] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/297728 [00:48:58] (CR) Eileen: [C: 2] "Self-merging as merge to deployment" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/297728 (owner: Eileen) [00:50:35] !log updating CiviCRM from 54e168db2fddc6a9a07036323e01a27dd64333cf to 5f8f7c3236e6bf12c52deea07093fbca165ef4a7 [00:50:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:51:12] OK - no immediate fail that time [00:53:11] right now for steps 20-22 while we wait... [00:53:27] how long was it last time? [00:53:33] /eileen puts a shoulder to the jalopy and it rattles out of the muddy ditch [00:53:36] 90 mins on staging a few days ago [00:53:57] blarney that's a long time [00:53:58] ok [00:54:09] yeah there are about 5 queries that are to blame [00:55:02] just minor alter queries but because of table size it is slow [00:55:43] ya [00:57:35] * Jeff_Green is tempted to reimage payments1003 in the meantime since it's double-not-doing-anything [00:57:43] yay! [00:57:54] That's what I'd really like to do with all this maintenance elbowroom. [00:58:15] turns out we can't replace hardware until next week b/c chris is on vacation [00:58:28] it's like we have the schoolbus up on a few jacks [00:58:45] Interesting change this time around … https://issues.civicrm.org/jira/browse/CRM-17005 [00:58:51] Jeff_Green: that's too bad, but glad to hear it's for a good reason [00:58:53] totally. let's paint it with purple spots while it's up [01:00:17] eilieen: that is interesting indeed [01:00:20] eileen: /me jumps [01:00:46] yeah - I'm not sure I agree with the change.... [01:01:50] but meh - could argue that one in many directions I suppose [01:01:57] I can't wrap my head around why it said occupied in the first place? [01:02:29] yeah - well I guess you could distinguish between the ones that are (west bank) & the ones that aren't (gaza) [01:02:37] but - how useful is that in a CRM? [01:02:40] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make banner impression counts available somewhere public - https://phabricator.wikimedia.org/T115042#2435827 (awight) One possible visualization: pacman-sized pie charts in the campaign's summary table line, with a pie... [01:02:58] eileen: could be very important in the context of a Palestinian NGO ;-) [01:03:12] why wouldn't you say something more palatable like palestine - gaza [01:03:24] well yeah - except that calling it 'Palestine' is hardly negative [01:04:17] we should just use lat/long for everything [01:04:31] I get that the war on words matters 'neighbourhoods' vs 'settlements' [01:05:15] vs colonies .... [01:05:19] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make banner impression counts available somewhere public - https://phabricator.wikimedia.org/T115042#2435830 (awight) @Jseddon Feel free to triage this task some day! [01:05:48] totally [01:06:16] i just don't understand the context well enough to understand how the choice of the word "occupied" to made sense [01:07:05] no - it is probably more important when reporting the news than listing someone's address [01:08:01] what would happen if they ever did do a deal - 'semi-occupied', 'a little less occupied', 'truly & utterly repressed' [01:08:24] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 6 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2435833 (awight) [01:08:40] perhaps an additional field is necessary in that case :-) [01:08:42] 'de-occupying territories' [01:11:00] & then maybe other countries could get values like 'mildly pre-occupied' [01:13:04] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 6 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2435837 (awight) @DStrine Let's ice thi... [01:16:31] (PS1) Cdentinger: Use RL to make RapidHTML wait for document ready [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297729 (https://phabricator.wikimedia.org/T139551) [01:16:34] Fundraising Sprint Internet Exploring, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, and 5 others: Implement AtomicReadBuffer for choice of PHP-Queue backend - https://phabricator.wikimedia.org/T133964#2435849 (awight) [01:16:36] Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Epic: [Epic] Provision high-availability Kafka cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2435850 (awight) [01:16:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Deploy Redis 3 to frack - https://phabricator.wikimedia.org/T120464#2435851 (awight) [01:16:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, FR-ActiveMQ, and 3 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#2435852 (awight) [01:16:43] Fundraising Sprint Freshmaking, Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, and 7 others: Spike: Choose a new backend for queueing - https://phabricator.wikimedia.org/T130304#2435847 (awight) Open>Resolved [01:17:26] ejegg: you are gonna puke when you see this https://gerrit.wikimedia.org/r/#/c/297729/ [01:18:06] (CR) jenkins-bot: [V: -1] Use RL to make RapidHTML wait for document ready [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297729 (https://phabricator.wikimedia.org/T139551) (owner: Cdentinger) [01:19:08] Fundraising-Backlog, FR-Adyen: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#2435859 (awight) [01:19:11] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: [Epic] Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & He... - https://phabricator.wikimedia.org/T128812#2435857 [01:20:03] cwd oh man, that's dirty! [01:20:15] i am kind of at a loss for a real solution [01:20:19] cwd: that is pure debt :p [01:20:41] suggestions are super welcome [01:20:46] there's also this 'investment' in RHTML: https://gerrit.wikimedia.org/r/297725 [01:21:07] But I don't think that should ever make it into Mustache [01:21:35] Jeff_Green: #10 should probably be a thing... [01:21:52] oh that [01:21:55] yeah [01:22:03] fwiw nobody else but us pays attention to catchpoint [01:23:15] ejegg: ah sorry i missed that one go by [01:23:18] probably a better solution [01:24:16] word, I should check a few more of 'em. I know the main cc one is fine [09:28:27] (PS2) Eileen: Alter logic for calculating wmf_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) [09:30:40] (CR) jenkins-bot: [V: -1] Alter logic for calculating wmf_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [10:07:57] (PS3) Eileen: Alter logic for calculating wmf_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) [10:09:43] (CR) jenkins-bot: [V: -1] Alter logic for calculating wmf_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [10:12:12] (PS1) Eileen: Fix custom fields update to work regardless of permissions [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297762 [10:12:59] (CR) Eileen: "I think the latest patch is working better - but it requires" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [14:30:00] (PS3) Ejegg: WIP fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [14:30:23] cwd sprinkled some position:top around and it's a slightly different unstyled flash ^^^ [14:31:03] ejegg: heh interesting, i tried that but it didn't seem to load at all [14:31:19] i was thinking about trying to pull those js blocks out in to RL modules [14:31:27] no idea if it would make a difference [14:31:57] cwd problem is those js blocks have crap that's rendered by rapidHTML [14:32:25] huh, there's also 'addModuleStyles' [14:32:30] lemme try that one [14:32:43] ugh [14:32:55] i don't know why i expected the upgrade to be simple [14:54:42] so addModuleStyles does the trick, it'll just be another bit of tedium pulling apart the modules and tracing dependencies [15:32:26] AndyRussG|_: you around? [15:55:45] AndyRussG|_: lmk if I can help make the extension registration patch more palatable... The merge conflicts should be resolved now [15:56:02] cwd: Want to walk me through the RL issue with payments on 1.26? [15:56:15] Why does it only affect RapidHtml? [15:56:24] awight: sure [15:56:45] it's because the js at the top of the partials is rendered before document ready [15:56:59] well, it's a race condition, but nearly always [15:57:13] Could we turn those into RL modules and be done with it? [15:57:21] well there are a couple issues [15:57:48] #1 they contain stuff that RHTML renders, but i think ejegg found a solution for that ResourceLoader&addModuleStyles [15:58:02] wat. yuck [15:58:11] templatized css? [15:58:33] #2 i don't understand exactly what the mechanism that applies the mustache styles to the rhtml things is, but when it happens on docready there is a visual bump and repaint of the thing from old green to new grey [15:59:15] gack [15:59:26] i'm not sure if there's a way around that one [15:59:52] ok, cool. I'll get set up locally with the evil version mismatch... [16:00:20] awight: it's easy since the branch is on remote already: checkout -t origin/fundraising/REL1_26 [16:01:17] awight: this is the problem gnar: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/globalcollect_gateway/forms/html/cc/cc-vmad.html#L2 [16:02:21] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Convert DonationInterface to use extension registration - https://phabricator.wikimedia.org/T108763#2437812 (awight) [16:02:38] yikes, just noticed a really big patch in the pending deployment pipeline ^ [16:02:39] awight: happily, this is also the only thing i know is broken on 28 [16:03:26] man i thought that already merged [16:03:42] I was surprised it was merged :) [16:03:55] oh, haha it did [16:03:58] but not deployed [16:04:02] hmmm [16:04:10] OK cool, thx for the pointer to the loader stuff [16:04:11] hrm [16:04:13] harrrumph [16:04:49] basically we do something hacky or we rebuild GC in mustache [16:05:10] and i think the hacky thing is going to have an inevitably bad UX because of the repaint [16:05:26] unless we track down that mechanism and it's fixable [16:05:42] but i think by that point we might be bumping up against the same workload as the mustache rebuild [16:05:43] haha I get green 50% of the time [16:06:10] that's interesting. in vagrant? [16:06:22] bare nginx [16:06:48] i guess that makes sense that it's an actual race condition if you don't have vagrant molasses [16:07:14] now I get only green... [16:07:21] fun [16:07:32] and there's already a repaint screwup going from unstyled to green [16:07:40] ls [16:07:42] hehe [16:07:51] yes, I type "ls" all day long [16:07:54] yeap [16:08:02] at least I don't have alias sl=ls tho [16:08:23] i think we are dealing with some sedimentary layers of bandaids [16:11:10] I guess I'll take down campaigns and prepare to deploy at least the DI#master changes for now [16:11:52] the-wub: ^ mind if I take campaigns down? [16:14:36] cwd: So it looks like there's a bit of inline JS in the forms, but nothing timing-sensitive [16:14:46] other than those mw.loader statements... [16:20:50] (PS1) Awight: [WIP] Move RapidHtml inline loader statements to the server side [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297808 [16:20:55] cwd: Early feedback? ^ [16:21:02] sure [16:21:36] !log Taking Fundraising campaigns down for maintenance [16:21:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:22:18] (CR) jenkins-bot: [V: -1] [WIP] Move RapidHtml inline loader statements to the server side [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297808 (owner: Awight) [16:22:34] awight: this might work, i was trying to shove stuff into that validate load an having no luck [16:22:55] ah. hrm that's a bad sign. I'll start with just one form to test, then [16:24:01] I think we need addModuleStyles to ensure no unstlyed flash [16:24:10] adding it to my WIP now [16:25:30] (PS2) Awight: [WIP] Move RapidHtml inline loader statements to the server side [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297808 [16:25:38] This fixes the js error, at least. ^ [16:25:47] cwd: can you try that on your molasses install? [16:25:55] FWIW, http://payments.dev/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&payment_method=cc&recurring=&uselang=en&language=en¤cy_code=USD&amount=10&country=US&debug=true [16:26:12] yeah for sure [16:26:22] ejegg: tell me more :) [16:27:13] outputPage->addModuleStyles is for styling server-rendered content, and adds a tag in the head [16:27:29] ejegg: I like your dependencies hack better than my adapter class one [16:27:29] while all the other resourceloader things run after some of the page is already displayed [16:28:00] awight: still see the repaint [16:28:02] (CR) jenkins-bot: [V: -1] [WIP] Move RapidHtml inline loader statements to the server side [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297808 (owner: Awight) [16:28:22] cwd: yah the repaint is still there [16:28:59] ejegg: do you know where the mustache css is getting applied? like in code? [16:29:36] (PS3) Awight: [WIP] Move RapidHtml inline loader statements to the server side [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297808 [16:29:37] So, not at all an OK way to do things, but ^ this seems to eliminate the race condition and the repaint. [16:29:40] cwd GatewayPage line 158 [16:30:05] but it's got a repaint too [16:30:54] awight: yeah, that double-loads all the CSS [16:31:09] aww man. I can't jump back to 1.25 now [16:31:22] (CR) jenkins-bot: [V: -1] [WIP] Move RapidHtml inline loader statements to the server side [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297808 (owner: Awight) [16:31:28] i guess what i'm wondering is why do we load the wrong css first, and can't we just load the right one instead [16:31:32] one would wonder, why the CSS isn't handled correctly by addModules [16:32:24] position=top just doesn't mean what it used to... [16:32:49] really silly, i guess they're expecting the client-side code to render everything too now? [16:33:08] that seems to be the direction of the internet in general [16:33:26] * awight dives deeper into pool of sadness [16:34:23] (CR) Awight: WIP fix dependencies for legacy forms in 1.26 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [16:35:40] u bros don't wanna just bash out the mustache forms and delete all this cruft? [16:36:07] the scope and risk of this silly little problem seems disproportionate [16:36:21] I think mustaching would introduce about 2 dozen bugs [16:37:03] why the furry does addModules not call addModuleStyles internally???? [16:37:06] that's fair, but whatever we do here might also. js load race is so untestable [16:37:48] got the mustache train started here: https://gerrit.wikimedia.org/r/295546 [16:37:52] Lessee. This really is our last chance to mustachize GC [16:37:54] but there's already a bug [16:38:18] meanwhile, I'm gonna get the payments deployment ready [16:40:01] ejegg: this? wikimedia/composer-merge-plugin: 1.0.0 installed, 1.3.1 required. [16:40:33] (PS4) Ejegg: WIP fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [16:43:34] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/297815 [16:44:39] (CR) jenkins-bot: [V: -1] WIP fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [16:45:05] (PS1) Awight: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297816 [16:46:00] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/297815 (owner: Awight) [16:46:04] (PS5) Ejegg: WIP fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [16:46:21] (CR) Awight: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297816 (owner: Awight) [16:49:01] Jeff_Green: you know anything about the IPNListener catchpoint errors? [16:49:21] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/297815 (owner: Awight) [16:49:25] awight: hmm. maybe [16:49:27] (CR) jenkins-bot: [V: -1] WIP fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [16:49:37] hehe k [16:49:42] I just weaked our HSTS header to be more restrictive [16:49:53] Jeff_Green: it's not urgent cos I've taken campaigns down [16:49:58] maybe they happened to poll while nginx was restarting [16:53:00] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297816 (owner: Awight) [16:53:48] ejegg: > Exception setting up GatewayPage with adapter class AstroPayAdapter: No supported currencies for CN [16:53:58] attack? [16:54:14] awight: huh [16:54:26] getting a lot of those? [16:54:33] !log update paymentwiki from 2fc573cbb94e833c4144aa9dad79de8ec374bb09 to c33ddfccf945bd075f0abff9e9de8c09f0174f89 [16:54:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [16:54:50] shouldn't be any AstroPay / CN links out there [16:55:11] ejegg: nah, it's just funny when we turn campaigns off and all that's left is background radiation [16:56:31] huh, i get Unfortunately we were unable to process this request from the adyen iframe [16:56:57] cwd: on production? [16:57:01] yep [16:57:08] hmm, did the sig as staging get merged? Lemme see if I messed with how it gets settings... [16:57:12] https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=FR&language=FR¤cy_code=EUR&amount=10&country=FR [16:57:30] awight: https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=adyen&payment_method=cc&recurring=&uselang=en&language=en¤cy_code=USD&amount=1&country=US&utm_source=internal_test [16:57:35] i've used it before... [16:57:49] the error is at adyen though [16:58:18] cwd: I get the iframe [16:58:22] weird, I just got the iframe to show up fine [16:58:29] cwd: try pron mode? [16:59:04] i mean after i submit the payment [16:59:07] ah [16:59:17] * awight begrudgingly donates $1 [16:59:21] could be a My Browser thing though [16:59:58] TY page [17:00:39] cwd: I don't see your requests in the log [17:00:48] a nvm there it is [17:01:17] 37029418 [17:01:31] must be a privacy thing [17:01:46] low fraud score, all successful logging [17:02:23] dstrine: You missed it. I was here < 9am [17:03:22] ah sorry I was at home [17:03:27] good job though! [17:03:45] :p [17:03:52] i allowed js from adyen and it worked [17:04:08] AndyRussG|_: you pointed me to a page that had the table schema for campaigns, banners etc. could you resend? [17:04:31] I will make sure I add it to the sequence spec [17:06:07] dstrine: https://www.mediawiki.org/wiki/Extension:CentralNotice/Database_schema [17:06:32] (PS2) Ejegg: Generalize per-country validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295530 (https://phabricator.wikimedia.org/T123002) [17:06:56] (PS3) Ejegg: Generalize per-country validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295530 (https://phabricator.wikimedia.org/T123002) [17:06:59] ejegg: Can I help with anything? [17:07:10] are you hakking on 1.26 or mustache? [17:08:48] awight: got as far as this for 1.26: https://gerrit.wikimedia.org/r/297725 [17:09:02] but I'm turning back to mustache to see if it's really much more work [17:09:14] ejegg: cool. I'll pick up the 1.26 thing for fun [17:09:20] thanks! [17:09:56] (PS3) Ejegg: Set address width class dynamically, fix no-state bug [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295535 (https://phabricator.wikimedia.org/T123002) [17:12:51] (PS6) Awight: [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:13:17] (PS2) Ejegg: Required fields don't need to be in a group [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295546 (https://phabricator.wikimedia.org/T123002) [17:14:35] (CR) jenkins-bot: [V: -1] [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:18:54] (PS7) Awight: [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:18:56] (PS1) Awight: Whitespace cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297823 [17:20:08] (PS8) Awight: [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:22:35] (CR) jenkins-bot: [V: -1] [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:23:19] (PS9) Awight: [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:23:53] print_r($form_obj); # 137752 lines [17:23:59] hahaha [17:24:19] i hit F5 and my fan started whining [17:24:27] anyone wanna kick the easy one? https://gerrit.wikimedia.org/r/#/c/297823/ [17:24:59] (CR) jenkins-bot: [V: -1] [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:25:29] (CR) Ejegg: [C: 2] "Washing the corpse before the funeral" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297823 (owner: Awight) [17:25:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gift Source and Financial Type for Endowment Gifts - https://phabricator.wikimedia.org/T139629#2438173 (LeanneS) [17:26:03] awight: thanks! AndyRussG|_ had shown me something else but this works too :) [17:26:59] dstrine: I hadn't seen that page before you asked, it's really nice! [17:27:06] might want to verify the last updated date though [17:27:46] (Merged) jenkins-bot: Whitespace cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297823 (owner: Awight) [17:27:48] hmmm 2013 :( [17:28:27] AndyRussG|_: had shown me the code that creates the campaign record [17:29:14] dang. [17:29:20] is this donationInterface.skinOverride somehow responsible for the gray theme? [17:29:30] wish I knew [17:29:54] the contents don't seem to relate to the name [17:30:07] dstrine: maybe https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/includes/Campaign.php#L831 [17:31:01] (PS10) Awight: [WIP] fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:31:23] awight: that looks more like it :) [17:32:13] (PS11) Awight: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:32:26] ejegg: cwd: ^ I think that's the one [17:32:42] nice, taking a look! [17:32:57] aight lessee [17:33:30] ejegg: don't we want to put this into the document.ready? https://gerrit.wikimedia.org/r/#/c/297725/11/globalcollect_gateway/forms/js/gc.cc.js,unified [17:34:11] (PS12) Awight: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [17:35:00] I'm gonna look at 1.28 CI [17:36:01] is position: top supposed to load in the head? [17:36:14] that was how it used to work [17:36:17] meh. it used to, but I don't think it does anything now [17:36:19] but it doesn't seem to any more [17:36:33] yeah, I think we don't need to add those actually [17:36:54] in fact, I get an error with them when the stuff is already cached [17:37:13] * awight removing now [17:37:20] some of those loaded things expect the js vars rendered inline to be defined already [17:37:32] it will be [17:37:57] there's probably some more style wrangling needed too, I only set the styles for the cc forms [17:38:05] (PS1) Awight: Remove deprecated "position" directives [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297827 [17:38:10] ok, will do [17:38:29] php does the var subbing in that js before it's rendered right? [17:38:37] yeah [17:38:45] RapidHtml does that [17:39:36] well this does get rid of the repaint [17:40:16] ejegg: This is really annoying. So we have to declare styles coming from dependencies as well, at the form level? [17:40:30] * awight wonders again why addModules isn't just using the 'styles' information directly [17:40:40] it's too bad we have to add machinery for rapidhtml's sake. are there going to be other cases where we want to force load things in the head with RL? [17:40:57] awight: either that, or get one copy of the CSS in the RL LocalSettinggs cache and another loaded via tags [17:41:46] cwd well, we are also using it to a tiny degree with mustache [17:42:15] but it's always the same style, so no formsettings cruft needed [17:42:37] though... it's one way to switch up appearance by ffname [17:42:59] asking Krinkle... [17:45:56] off the hook. [17:46:33] ejegg: okay, worst case scenario with missing styles is that we get a repaint, eh? [17:47:06] or that they just don't load [17:47:27] lessee where I removed 'em [17:47:39] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2438288 (Jgreen) [17:48:03] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2359459 (Jgreen) [17:48:08] ah, there's that ie6 crap half-removed too [17:48:58] ejegg: gotcha, I can find these [17:52:09] ok, i think bt and dd forms need the styles added to form settings [17:57:36] (PS1) Awight: Finish futzing with styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297833 [18:01:13] (PS13) Awight: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [18:01:20] (Abandoned) Awight: Remove deprecated "position" directives [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297827 (owner: Awight) [18:01:25] (Abandoned) Awight: Finish futzing with styles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297833 (owner: Awight) [18:03:25] (PS4) Awight: Generalize per-country validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295530 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:04:09] (CR) Awight: [C: 2] Generalize per-country validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295530 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:04:16] (PS4) Awight: Set address width class dynamically, fix no-state bug [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295535 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:05:11] (CR) Awight: [C: 2] Set address width class dynamically, fix no-state bug (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295535 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:05:19] (PS3) Awight: Required fields don't need to be in a group [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295546 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:05:59] (CR) Awight: [C: 2] Required fields don't need to be in a group [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295546 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:07:17] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2438394 (Jgreen) [18:08:58] the-wub: Hey, if I want to get a small amount of traffic to payments w/o messing up your statistics, is there any particular campaign that I can reenable? [18:10:03] cwd: Where is "donationinterface-fundraising-branches" used in the CI config? [18:10:28] Does that just create a matrix of jobs? [18:11:04] hmm [18:12:02] awight: i believe that is the top level thing that jjb looks at [18:12:04] "project" [18:12:15] and it will create the jobs dynamically [18:12:25] so uh yeah what you said [18:12:45] (Merged) jenkins-bot: Generalize per-country validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295530 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:12:47] (Merged) jenkins-bot: Set address width class dynamically, fix no-state bug [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295535 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:12:51] (Merged) jenkins-bot: Required fields don't need to be in a group [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/295546 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:13:58] omg [18:14:30] what should we call the master thing... fundraising/REL1_28 seems sketchy cos there's no core REL branch for that [18:15:46] Well. If the style workaround looks good, we can deploy that and bump up to 1.26 [18:16:46] awight: i have this locally: fundraising/wmf/1.28.0-wmf.9 [18:16:50] :P [18:17:05] d'oh [18:17:23] I guess branch naming is another detail we should figure out before the switch [18:17:29] huh, we need some kind of constant that we can deploy from [18:17:39] hmmm [18:17:46] constant? like a release branch? [18:17:58] or we could make the deploy tool do it [18:18:03] we could use a tag... [18:18:08] yuck [18:18:17] like, give fundraising-code-update a branch name? [18:18:44] yeah, or probably put it in config [18:18:49] but somethign that we can change [18:19:23] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#2438520 (awight) [18:21:17] are we looking harder at the mustache path now? [18:21:35] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/297835 [18:22:10] cwd: I think we have a working 1.26 fix. Once that's reviewed, I'll push it out. fine if people want to continue hacking on Mustache though, I don't care [18:22:25] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/297835 (owner: Awight) [18:22:51] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/297835 (owner: Awight) [18:23:18] !log Update SmashPig from 917138e159f0341e3dfbb35818c3ce479927875b to e6aa6fe6fdcaab8e961a8b0668cc742d4c443c46 [18:23:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:24:32] oh hey, we have zero forms using street_supplemental [18:24:38] oh good [18:27:00] ejegg: Are there any deployment steps for T133197? like create the schema in production? [18:27:00] T133197: Write pending queue consumer and schema - https://phabricator.wikimedia.org/T133197 [18:29:13] heh, might even need to deploy a sql server [18:29:21] d'oh [18:29:55] right. ok well i noticed a bunch of the "pending db" stuff is written but with no enablement. so we can just make a new task for that. [18:30:25] yeah, deploying it shouldn't interfere with existing code [18:30:32] dstrine: I wanted to ask you about T134446. How about we kick it to sprint +2? [18:30:32] T134446: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446 [18:31:36] awight: what are the next steps for paypal? [18:31:37] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2438550 (Jgreen) [18:31:41] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Unplanned-Sprint-Work: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1918994 (awight) a:Ejegg [18:32:38] dstrine: T131816 [18:32:39] T131816: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816 [18:33:06] dstrine: * figure out how to get donations bucketed into paypal_ec, even if they come through the audit or IPN and not frontend. [18:33:36] * Make fixes to recurring in response to bug reports. Possibly do a whole new type of tokenized, self-recurring charge [18:33:44] awight: we moved the Japanese campaign to september. we could pause paypal for a few more days but if it isn't at a 1 hour test by early august it would be a mad dash to get it up and running [18:34:10] dstrine: I don't see how we can focus on paypal and also the queue work [18:34:25] We've already eaten a week out of the queue month [18:35:13] (PS1) Ejegg: Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) [18:36:02] awight: you were unsure that everyone could pile onto queue stuff simultaneously. Has that changed? [18:36:39] I don't think that's going to happen either way--there's plenty of smoldering fires that nobody will not be busy [18:36:52] (CR) jenkins-bot: [V: -1] Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:37:20] paypal was already a missed goal. It should count as a thing someone should be busy with [18:37:32] dstrine: check out the current sprint btw. I did a bunch of simple cleanup [18:37:36] non-controversial [18:38:28] dstrine: Doesn't sound like Sept is good timing for PP [18:39:02] The queues have to happen first cos of systemic instability [18:39:19] So that would leave us resuming PP something like... mid-August [18:39:40] like you said, that's too tight [18:41:15] dstrine: It's a terrible position to triage our way out of--please don't feel pressure to figure it out right now. [18:41:30] We're going to have to talk about this more over the next few days. [18:41:33] exactly [18:42:29] Judging from my experience over the past 2 months or so, I don't think it's feasible to do the queue overhaul as a background task around regular business features [18:43:38] There's always something else taking top priority, and that's where the effort goes [18:45:07] I think you've prepped the rest of the stakeholders sufficiently, luckily--hopefully they'll understand that "no progress" on other goals really means, no progress... [18:45:42] k I'm gonna wolf a lunch. [18:46:34] ejegg: cwd: lmk what you think about https://gerrit.wikimedia.org/r/#/c/297725/, I'd be excited to get 1.26 out today [18:47:47] awight|fud: will do! [18:48:18] yessir [19:07:45] (PS1) Ejegg: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) [19:09:36] (CR) jenkins-bot: [V: -1] Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:10:50] (CR) Cdentinger: [C: 1] "I think this approach is sane. I would merge but I am not the authority on whether the changes cover every case or not." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [19:35:13] dstrine: Here's the thing I think you were thinking of: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/7198cf0340c4a003a5e26a1f01b0a36babe7c563/CentralNotice.sql [19:35:20] I'll send by e-mail too in a bit then [19:55:38] I think ejegg|food is running off the rails [19:55:58] with the mustache thing? i was getting hopeful... [19:56:17] it looks good so far, but i'm getting a failure i don't understand [19:56:38] It's a pretty freaking ambitious project to write, review, and deploy today [19:57:09] indeed [19:57:52] awight: would you prefer to try the other fix and 1.26 in concert? [19:58:15] maybe we should outline the benefits [19:58:49] > we don't have a ticking time bomb in the app [19:58:57] but nothing is actually _broken_ about 1.25 right now [19:59:15] but it could go to hell at any time in a way we couldn't really recover from [20:01:56] rails or no, the crazy train is tantalizingly close to the destination [20:02:03] hehehe [20:02:21] * awight drops another 2 quarters into the machine [20:02:29] (PS1) Awight: Clean up style complaints (to squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297857 [20:02:42] ejegg: ^ to stick onto your WIP [20:03:01] ah, thanks! [20:04:05] ejegg: how can I help? just CR? [20:04:09] (PS2) Ejegg: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) [20:04:51] cr is great, or if you want to look at the non-cc ingenico stuff that's cool too [20:05:05] sure [20:05:19] I'll build followon patches [20:05:20] i'll take a break from that and review the plan B stuff [20:05:52] thx. cos we should keep your new work rebased on top of that [20:05:56] i'm trying to figure out why i get Class undefined: TestingGlobalCollectAdapter [20:06:02] AndyRussG: awight ejegg meeting? [20:06:04] trying to open in gc iframe in mustache [20:06:12] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Epic: Move payments to mediawiki 1.26 - https://phabricator.wikimedia.org/T139531#2438956 (Danny_B) [20:12:06] (CR) jenkins-bot: [V: -1] Clean up style complaints (to squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297857 (owner: Awight) [20:14:58] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 7 others: Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2438985 (Danny_B) [20:15:31] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 10 others: All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2438988 (Danny_B) [20:16:37] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Epic: Move payments to mediawiki 1.26 - https://phabricator.wikimedia.org/T139531#2438990 (awight) @Danny_B I really do want the tag to appear in the title... [20:16:46] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Epic: [Epic] Move payments to mediawiki 1.26 - https://phabricator.wikimedia.org/T139531#2438992 (awight) [20:16:55] (CR) jenkins-bot: [V: -1] Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [20:17:35] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 7 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2438995 (awight) [20:17:59] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 10 others: [Epic\ All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2438996 (awight) [20:18:09] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 10 others: [Epic] All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2224734 (awight) [20:18:11] Danny_B: hi! [20:18:24] Thank you for the attention to our tasks, it's nice having people in there :D [20:18:47] Please do discuss with us whether to take tags out of the title, though... is that a best practice? [20:26:05] awight: sort of. tags in titles are unscaleable, hence why we have tags themselves [20:26:57] awight: and for the record: it's not attention only to your tasks ;-) i'm continuously cleaning up all phabricator [20:28:29] Danny_B: yes, fantastic work! The tags in titles are useful for our team, however [20:38:06] ejegg, awight - are we going to prioritize one approach over the other, or try both? want to do the most useful thing available [20:38:06] (PS2) Ejegg: Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) [20:41:33] cwd: I think we can serialize the patches pretty nicely as 1) RL workaround, 2) mustache conversion [20:41:47] that way, we can move to 1.26 no matter what happens [20:44:17] (PS1) Ejegg: Make images dir match fundraising/REL1_25 [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297899 [20:44:18] & still keep momentum towards the mustache conversion, which may or may not be finished today. [20:44:41] yeah that sounds good to me [20:45:54] AndyRussG: Do you want me to continue rebasing T108721? Were you planning to get that into today's deployment, or wait until later? [20:45:54] T108721: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721 [20:46:14] awight: one sec, meeting [20:49:29] k [20:50:17] (CR) Awight: [C: 2] Make images dir match fundraising/REL1_25 [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297899 (owner: Ejegg) [20:55:48] (Merged) jenkins-bot: Make images dir match fundraising/REL1_25 [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297899 (owner: Ejegg) [20:55:55] (PS14) Ejegg: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [20:56:27] awight: sorry... I don't plan to +2 anything else before that's merged. However i was thinking of not deploying it today... Gotta run to pick up kids, cya in a bit! [20:57:09] shofar? [21:04:46] Made of concrete: https://www.theguardian.com/world/2016/jul/06/noahs-ark-encounter-kentucky-replica-unveiled [21:05:27] (PS1) Ejegg: Use REL1_26 extension branches [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297904 [21:07:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gift Source and Financial Type for Endowment Gifts - https://phabricator.wikimedia.org/T139629#2439288 (Eileenmcnaughton) awight ejegg I think this is something they can add themselves - you can't think of anywhere it would impact can you? [21:07:20] anybody else keep getting logged out of gerrit ui? [21:08:29] +1 [21:09:12] I'm in! [21:09:27] oh this again [21:09:33] (PS28) Awight: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [21:09:41] (PS5) Awight: Clean up from extension registration migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293687 [21:09:44] ejegg: did you see I fixed up that merge patch? no - cos you are locked out of gerrit! [21:09:46] (PS4) Awight: Clean up annoying punctuation and unnecessary strict equality [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293688 [21:11:06] eileen: oh, i'll take a look in a sec! [21:11:49] it has a civicrm patch dependency [21:12:00] but it would be good to get it rolled out [21:20:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Wiknic banner needs to provide a close box - https://phabricator.wikimedia.org/T139672#2439485 (awight) [21:39:10] is $wgDonationInterfaceTestMode supposed to represent that tests are being run, or "development" mode? [21:48:57] cwd: something like dev mode [21:58:00] (PS15) Ejegg: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [21:58:03] awight: doesn't this seem like the opposite of that? https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/gateway_common/donation.api.php#L206 [22:02:48] eh? that's crazy shit that should not exist [22:03:19] that too [22:03:32] i'm just trying to find out if that class not being loaded is a new behavior or now [22:03:34] *not [22:03:50] turn test mode off... [22:04:22] yeah then it works [22:04:28] but shouldn't i have test mode on in dev? [22:05:53] nah... [22:06:31] boy u crazy [22:11:14] cwd: I think it's used inconsistently in various places, and not particularly helpful. [22:11:26] also, should certainly not be enabled when you're testing the production code [22:11:34] that might be why you hit an unused code path [22:11:52] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297911 [22:12:41] (PS16) Ejegg: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [22:12:59] awight ejegg cwd XenoRyet How's stuff? Just preparing the wmf_deploy branch for CentralNotice... ^ [22:13:21] How do you feel about a big CN deploy at 4 pm PDT¡ [22:13:23] ? [22:13:30] sounds exciting! [22:13:41] * awight blasts the fog horn [22:13:57] * AndyRussG trembles [22:14:10] awight: i'll see if i can narrow down the uses of that setting [22:14:49] grep -r TestMode . [22:14:52] not much [22:14:57] There's another one, though... [22:15:20] $wgDonationInterfaceTest [22:15:38] grep -rw "'Test'" . [22:24:05] https://codeclimate.com/github/wikimedia/mediawiki-extensions-DonationInterface [22:24:49] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up Codeclimate for Fundraising repositories - https://phabricator.wikimedia.org/T139686#2439865 (awight) [22:28:02] adyen_gateway/adyen.adapter.php has improved. [22:28:07] D->B [22:28:13] For the merge patch, a diff with master finds nothing, except a couple stray newlines (?). However the Gerrit patch diff looks a bit weird. I think it's OK tho. https://gerrit.wikimedia.org/r/#/c/297911 [22:28:16] The helper classes obviously score big [22:28:20] cos: 20 lines. [22:28:25] single responsibility. [22:28:25] https://sadbastard.org/images/approve.gif [22:28:31] Unless anyone has any better ideas, I'm gonna self +2 [22:29:12] (PS17) Ejegg: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 [22:29:34] AndyRussG: looks good! [22:30:20] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up Codeclimate for Fundraising repositories - https://phabricator.wikimedia.org/T139686#2439910 (awight) [22:30:43] awight: PS17 ^^^ looks like prod for all the freaky methods I tested, and I'm not seeing any js errors or unstyled flashes [22:31:13] I restored the position=top for the iframe liberator, as i think it still does /something/ [22:31:19] ejegg: woohoo! [22:31:24] k, gotta relocate to a power source [22:34:14] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297911 (owner: AndyRussG) [22:34:35] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up Codeclimate for Fundraising repositories, make it part of our process - https://phabricator.wikimedia.org/T139686#2439916 (awight) [22:36:21] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297911 (owner: AndyRussG) [22:43:25] awight: what if i changed all the TestMode to Test ? [22:45:17] donno... it sounds like a good idea [22:48:31] the localsettings paradigm makes it hard to take back a config var [22:49:08] luckily, nobody else uses this [22:50:23] not yet! [22:56:40] awight: now that i think about it... it does seem like (based on that wacky case) we need a way to differentiate between "on dev server" and "currently running tests" [22:57:00] because i think the latter is what that is referring to with the TestingGlobalCollectAdapter thing [22:57:27] maybee. sorry you're in uncharted waters [22:58:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Documentation: List all of the places we've extended CiviCRM - https://phabricator.wikimedia.org/T133356#2440038 (awight) Open>Resolved a:Eileenmcnaughton [22:59:19] no idea if it somehow detects that it's in CI and does the right thing [22:59:21] * cwd shudders [23:00:12] I don't think so. There's a horrifying TestSettings file under tests/ somewhere... [23:02:05] that sure makes it sound like it'd be choosing the wrong GC adapter in CI [23:03:47] cwd so it's looking for that thing when running unit tests, right? [23:04:23] ejegg: yeah [23:04:30] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/gateway_common/donation.api.php#L206 [23:04:37] that's added to the autoloader in onDonationInterfaceUnitTests [23:04:43] let's see if that's ever called now [23:05:17] UnitTestsList hook... [23:06:19] oh right, it must be being called if any of our tests run [23:06:20] FWIW, last-minute extra x-browser testing of new CN code shows no issues :D [23:06:28] woohoo! [23:07:13] yeah! [23:08:49] cwd oho! right, it won't have that class unless running unit tests [23:09:12] so, test mode is broken as well as dumb [23:09:13] i'm not sure why i had that set in localsettings [23:09:34] seems like what we want is just dependency injection of the adapter classes [23:09:49] probably my normal approach to problem solving which is thrash until something happens [23:10:37] would the TestingAdapter be any use if it did resolve? [23:10:54] let's just nuke that bit... [23:11:19] would we be more effective if we had some centralized localsettings for development? [23:11:36] possibly maybe [23:12:01] stash em in the secret git repo so we can play with realistic fraud filter settings [23:13:06] yeah, would be nice to not make coding decisions based on divergent config [23:13:37] (PS4) Ejegg: Merge payments init messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/296186 (https://phabricator.wikimedia.org/T137590) [23:13:57] i gotta run for a bit, will check in later. good luck with the deploy AndyRussG ! [23:15:45] cwd|afk: thx! [23:19:28] (CR) Ejegg: [C: 2] "If the user can do a merge, they oughtta be privy to all the info." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297762 (owner: Eileen) [23:22:18] (Merged) jenkins-bot: Fix custom fields update to work regardless of permissions [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/297762 (owner: Eileen) [23:22:44] Sorry to be pushing, but our window is closing... [23:22:58] cwd|afk: ejegg: what do you want to do about the rest of the DI patches? [23:23:04] *pushy [23:23:41] awight / cwd: I'd like to get them out if possible [23:23:45] (CR) Awight: [C: 2] Merge payments init messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/296186 (https://phabricator.wikimedia.org/T137590) (owner: Ejegg) [23:24:05] I've checked locally on the methods that have links in the test link page [23:24:19] anything else active that we need to prod? [23:24:32] r u thinking that https://gerrit.wikimedia.org/r/#/c/297725/ is unnecessary because you've replaced RapidHtml? [23:24:42] works for me, if so... [23:24:46] awight: no! [23:24:51] erp [23:25:06] I've accepted that's the way to 1.26 if we want to deploy today [23:25:26] and that was the patch I've been looking at locally [23:25:30] k [23:25:30] I'll be back on asap [23:25:36] (Merged) jenkins-bot: Merge payments init messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/296186 (https://phabricator.wikimedia.org/T137590) (owner: Ejegg) [23:25:40] It also seems harmless [23:26:04] I mean... plenty risky, but not damaging to code we need for painting Mustaches on everything later [23:26:27] (PS18) Awight: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [23:26:51] (CR) Awight: [C: 2] "Semi-self merging after IRC discussion" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [23:28:54] (Merged) jenkins-bot: fix dependencies for legacy forms in 1.26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297725 (owner: Ejegg) [23:29:52] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/297922 [23:30:03] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/297922 (owner: Awight) [23:31:42] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297923 [23:31:54] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/297922 (owner: Awight) [23:32:04] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297923 (owner: Awight) [23:32:18] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make banner impression counts available somewhere public - https://phabricator.wikimedia.org/T115042#2440127 (Jseddon) p:Triage>Low [23:33:28] awight: what do you think of this patch: https://gerrit.wikimedia.org/r/297904 ? [23:33:51] some of those extensions are very old [23:34:19] ty! [23:34:20] (CR) Awight: [C: 2] Use REL1_26 extension branches [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297904 (owner: Ejegg) [23:35:09] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297925 [23:35:51] (CR) Eileen: [C: 2] "submodule update - self-merging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/297925 (owner: Eileen) [23:36:32] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Log IP addresses when outgoing requests fail - https://phabricator.wikimedia.org/T139698#2440146 (Ejegg) [23:38:08] (Merged) jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297923 (owner: Awight) [23:38:12] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [23:38:36] (PS2) Awight: Use REL1_26 extension branches [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297904 (owner: Ejegg) [23:40:03] Fundraising-Backlog: Spike: Do we need ParserFunctions on paymentswiki? - https://phabricator.wikimedia.org/T139699#2440161 (awight) [23:41:20] ejegg: thanks for reviewing the civicrm patch - with that merged this is now passing https://gerrit.wikimedia.org/r/#/c/294661/ [23:41:27] nice! [23:42:13] eileen: but again I'm not sure how :) Shouldn't that join from x.entity_id be to c.id, not c.contact_id? [23:42:54] should it? dang - I looked at that & thought I had it wrong before! [23:43:13] ejegg: what was the pressing reason to use symfony http foundation? [23:43:17] I confused myself [23:43:38] * awight pulls straightjacket tighter [23:43:57] ejegg: you said something convincing i just forgot [23:44:33] cwd needing to use DI under CRM to make recurring charges [23:44:42] thaaat's right [23:44:55] not necessarily symfony, but we've gotta stop using the MW logic [23:45:02] yeah [23:45:04] cwd: well. it's what you said, then--we can only deploy the 1.26 shimmed code on 1.25 [23:45:24] huh, is that even worth it? [23:45:28] i don't *think* anything will esplode [23:45:38] still passing 1.25 tests [23:45:39] I'm pretty sad about that. 8 hours of deployment window later... [23:46:06] :( [23:46:14] bah. just bits. [23:47:11] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297927 [23:47:20] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297927 (owner: Awight) [23:47:45] wondering if it's int he puppet private repo [23:47:53] branch config i mean [23:48:11] (PS1) Ejegg: Use 'addModuleStyles' in a couple more places [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297928 [23:48:15] yeah... yep. modules/frdeploy/manifests/init.pp [23:49:57] (CR) Awight: [C: 2] "Good finds!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297928 (owner: Ejegg) [23:50:02] if only jeff wasn't so thorough and knowledgeable [23:50:10] hehe [23:50:27] I know--K4 used to have this enormous sudo backdoor for just this scenario [23:50:54] that was my overwhelming feeling last week when testing the jessie servers. just confirming that jeff did everything right first try. [23:51:43] (PS4) Eileen: Alter logic for calculating wmf_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) [23:52:07] ejegg: I fixed that - the test data must be too samey! [23:53:24] (Merged) jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297927 (owner: Awight) [23:53:27] (Merged) jenkins-bot: Use 'addModuleStyles' in a couple more places [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297928 (owner: Ejegg) [23:55:33] !log Update paymentswiki from c33ddfccf945bd075f0abff9e9de8c09f0174f89 to f54ffb4fad0dc18079a813fbe25813dba36c64aa [23:55:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:55:57] (CR) Ejegg: [C: 2] "Rockin!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) (owner: Eileen) [23:56:36] Deployed! [23:56:47] watchin logs [23:56:48] Awesome work, cwd ejegg -- no repaint at all (with 1.25) [23:57:05] dang, even with a hard refresh [23:57:25] I'm gonna hit it with some campaigns [23:57:40] heh, shouldn't have been a repaint! [23:57:50] anyway, amazon still works [23:58:41] (Merged) jenkins-bot: Alter logic for calculating wmf_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/294661 (https://phabricator.wikimedia.org/T133625) (owner: Eileen)