[00:01:00] !log CentralNotice campaigns reenabled [00:01:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:01:23] morebots: I meant to say, "fundraising CentralNotice" [00:01:23] I am a logbot running on tools-exec-1211. [00:01:23] Messages are logged to wikitech.wikimedia.org/wiki/Server_Admin_Log. [00:01:23] To log a message, type !log . [00:01:25] hehe [00:01:47] haha [00:05:12] Fundraising-Backlog, Spike: Spike: Do we need ParserFunctions on paymentswiki? - https://phabricator.wikimedia.org/T139699#2440248 (Danny_B) [00:05:49] O_o [00:08:16] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up Codeclimate for Fundraising repositories, make it part of our process - https://phabricator.wikimedia.org/T139686#2440251 (awight) [00:14:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Wiknic banner needs to provide a close box - https://phabricator.wikimedia.org/T139672#2440286 (Whatamidoing-WMF) Now, there is a close button in the center bottom of the box, but it doesn't work (Safari 9/Mac OS 10.10.5). [00:24:05] k, i'm going to head out for the eve. see you all tomorrow! [00:25:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Wiknic banner needs to provide a close box - https://phabricator.wikimedia.org/T139672#2440307 (awight) @Whatamidoing-WMF Thanks for catching that--it's still a horrible hack, but try now? I damaged the banner pretty badly and made very little of... [00:34:35] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Unplanned-Sprint-Work: Bad paymentswiki referrer appearing in contribution_tracking - https://phabricator.wikimedia.org/T139706#2440326 (awight) [00:39:30] !log roll back paymentswiki from f54ffb4fad0dc18079a813fbe25813dba36c64aa to c33ddfccf945bd075f0abff9e9de8c09f0174f89 [00:39:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:42:07] !log roll back paymentswiki further, to 2fc573cbb94e833c4144aa9dad79de8ec374bb09 [00:42:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:48:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Wiknic banner needs to provide a close box - https://phabricator.wikimedia.org/T139672#2440377 (Whatamidoing-WMF) Worked for me at enwiki just now. Thanks. [00:53:26] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297938 [00:55:24] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297938 (owner: AndyRussG) [00:57:23] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297938 (owner: AndyRussG) [00:58:34] AndyRussG: looks like you're having fun too :) [00:58:50] can I help with anything? I'm stuck watching logs for the next 45 min or so [01:30:39] awight: thx! I'm waiting to see if we'll deploy CN or not... [01:31:35] I made a silly mistake and did a git merge of a non-updated local copy of master when preparing the deploy [01:31:42] So had to re-do that [01:33:49] sorry! [01:38:18] awight: heh it happens ;p [01:38:49] The all-day deployment window was basically a spectacular disaster... [01:39:00] donno if you saw what happened with paymentswiki! [01:39:18] I had to revert everything, 9 hours deep [01:39:27] awight: ah no sorry I was off disastering in my own corner.... Really sorry to hear that!!! [01:40:25] It was one of those things that's so horrible that I have to write it off as a learning experience [01:41:06] Awwwww sorry... well, was it fun, too? [01:42:24] What happened? [01:44:38] meh, unknown. All credit card transactions were stopped for fraudulence [01:45:38] ouch [01:46:05] Maybe payments achieved consciousness and tried to end capitalism [01:46:39] So maybe the mistake was reverting? [01:50:25] :D [01:50:50] Right, what's the harm--CC transactions are just throwing fraud at fraud, anyway [01:53:03] time's up! [01:53:20] good luck with the CN deployment [01:53:28] I don't think there's any pressure to do it day, fwiw [01:53:30] *today [01:53:41] awight: thx! [01:53:48] I'd love to just get it done ;p [01:54:08] We have Krinkle waiting up to help fix any RL issues... [01:54:40] Don't fret about today! [01:55:17] wait. Isn't it 3am in London? [01:55:28] hopefully he's not there? [01:55:42] If you caught the problem and reverted, then all went well! [01:56:12] Not sure where he is... [01:56:23] see ya! [03:10:36] (CR) Dereckson: "Reverted by db5eb37" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297911 (owner: AndyRussG) [03:12:29] (CR) Dereckson: "(discard last comment, what was reverted was the wmf/1.28.0-wmf.9 core change to pickup this change)" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/297911 (owner: AndyRussG) [03:35:55] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/297944 [15:04:42] Fundraising Sprint Muggle Baiting, Fundraising-Backlog: New payments code erroneously failing for referrer - https://phabricator.wikimedia.org/T139753#2441609 (cwdent) [15:33:20] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2441720 (spatton) Hi @Jgreen, @DStrine: I know that Brent, Jasmeet and Max have received their yubikeys. Can you please confirm that they... [15:40:20] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2441753 (DStrine) Resolved>Open [15:41:15] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2297258 (DStrine) I'm reopening this and adding @awight so more people see this. I know of these things but do not have the ability to g... [15:49:48] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2297258 (Jgreen) They have lutetium access. I'm not sure which git repo we're referring to? If gerrit, that is public already. Hadoop/... [15:57:07] ejegg: good morning. Just to confirm, we didn't see anything bad on the tech side for IL or Ukraine in the Wednesday test, right? would you say we are ok turning on Ukraine on Tuesday? [15:57:57] we had kept IL up on Wednesday after the test. [15:58:06] dstrine: right, I didn't see anything bad tech-wise [15:58:46] Just to confirm from the rollback yesterday, are we stable today/ through the weekend? [15:58:47] though we might think about removing Amex in IL given donors' problems with the Adyen form [15:59:47] i second removing amex ejegg, if we can’t fix it [15:59:52] is it easy to only remove Amex? is that something the-wub can do or is it fr-tech? [15:59:55] dstrine: yeah, post-rollback we're back to normal. I kinda want to cherry-pick and deploy that one mailcheck thing, but I probably shouldn't right now [16:00:13] dstrine: it's an fr-tech thing [16:00:27] RE rollbacks: ok. I'm always in favor of a more sane friday [16:00:38] re amex: thanks for the info [16:01:02] the card config is a settings-type file, but in a dir that we have to manage via a super-minor deploy rather than just an on-cluster edit [16:01:21] ejegg: you think this could have been it? https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/extension.json#L423 [16:01:41] cwd yep, exactly! [16:01:41] dstrine: I have home internet! So if you'd like to chat now that's fine. The Monday slot you just changed it to is also cool, of course :) [16:02:34] AndyRussG: thanks but I didn't have time to get my work together. also I thought it might be good to include Adam [16:02:45] dstrine: K sounds good :) [16:05:01] (PS1) Cdentinger: don't run referrer filter on initial [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298008 [16:06:20] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2441889 (Jgreen) [16:07:57] (PS2) Cdentinger: don't run referrer filter on initial [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298008 (https://phabricator.wikimedia.org/T139753) [16:08:43] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2441893 (ellery) Katie is the owner of the private fr github repo. [16:52:45] (PS1) Ejegg: Put referrer back in session again [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298022 (https://phabricator.wikimedia.org/T139753) [16:55:27] (CR) Ejegg: [C: -1] "Let's keep running this on initial - it's the place that makes sense, as we don't get any new info during processing. It was turned off by" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298008 (https://phabricator.wikimedia.org/T139753) (owner: Cdentinger) [17:18:28] (PS3) Ejegg: Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) [17:18:30] (PS3) Ejegg: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) [17:19:09] (CR) Ejegg: "PS3:rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [17:20:27] (CR) jenkins-bot: [V: -1] Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [17:20:56] (CR) jenkins-bot: [V: -1] Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [17:26:37] (PS12) Ejegg: Encapsulated amount validation for better messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) [17:27:24] (CR) Ejegg: "PS12: rebase. FIXME: stepped on the exponent3 work" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg) [17:27:42] (CR) jenkins-bot: [V: -1] Encapsulated amount validation for better messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg) [18:10:37] (Abandoned) Cdentinger: don't run referrer filter on initial [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298008 (https://phabricator.wikimedia.org/T139753) (owner: Cdentinger) [18:24:50] (PS13) Ejegg: Encapsulated amount validation for better messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) [18:30:13] (PS4) Ejegg: Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) [18:30:15] (PS4) Ejegg: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) [18:31:40] (CR) Ejegg: "PS4: rebased onto encapsulated amount validation to make it more convenient to fix those tests" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:33:29] (CR) jenkins-bot: [V: -1] Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:35:01] cwd that httpfoundation work might be a little tricky around our integration-y unit tests where we set the ambient mediawiki request to a FauxRequest [18:35:25] do you think we should explore other libs? [18:35:41] (CR) jenkins-bot: [V: -1] Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:36:09] no, it'll just be work to use anything except the MW classes and get the right fake data to some tests [18:36:55] does the session fix get referrer working for you locally? [18:39:46] (PS5) Ejegg: Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) [18:41:21] (PS5) Ejegg: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) [18:42:26] (CR) Ejegg: "PS5: squashed in fixes from I4d3fdac96fa3ef. Thanks awight!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:50:01] (PS1) Ejegg: donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 [19:00:40] (CR) Ejegg: "awight, regarding your PS11 comment, that's an existing issue with the RapidHTML forms. Without this patch it says 'Please enter a valid " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg) [19:08:44] ejegg: sorry got distracted, i'll check it out [19:10:34] thanks! [19:14:15] (CR) jenkins-bot: [V: -1] Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:22:26] (PS6) Ejegg: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) [19:22:36] (CR) jenkins-bot: [V: -1] donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [19:30:05] XenoRyet: can you take a look at [19:30:22] https://gerrit.wikimedia.org/r/286261 [19:30:37] and make sure I didn't mess up the Adyen currency stuff you just did? [19:31:01] Sure. I have to go make lunch for the kid real fast, but I'll take a peek right when I get back. [19:31:02] damn, just saw this video of the protest in oakland [19:31:10] go oakland [19:32:15] * ejegg takes head out of sand [19:33:48] freakin cops [19:34:41] it's mind boggling what's happening [19:35:30] it's about damn time the country started noticing [19:40:54] (CR) jenkins-bot: [V: -1] Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:49:37] (PS7) Ejegg: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) [19:50:00] fundraising-tech-ops: frack jessie integration cleanup - https://phabricator.wikimedia.org/T138222#2442711 (Jgreen) Some of our older Dell boxes have broadcom bnx2 nics that require proprietary firmware which is not included with the debian install kernel as it was with ubuntu. So you're supposed to side-loa... [20:01:29] ejegg: Haven't looked at all of that patch yet, but I can confirm it's playing nicely with the Adyen amounts. [20:01:32] woohoo, mustache forms for ingenico CC is now passing tests! https://gerrit.wikimedia.org/r/297845 [20:02:02] thanks XenoRyet ! If you do have a chance to CR it, that would be great too [20:02:30] Yea, was planning on it. Just wanted to mention that bit before we get meeting'd [20:02:35] cool [20:30:05] (CR) Cdentinger: [C: 2] "Looks good, and better names." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298022 (https://phabricator.wikimedia.org/T139753) (owner: Ejegg) [20:31:50] (Merged) jenkins-bot: Put referrer back in session again [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298022 (https://phabricator.wikimedia.org/T139753) (owner: Ejegg) [20:37:29] dstrine: I think I actually am going to make a ticket for the AmEx thing, just for history and bookeeping. [20:37:46] ok cool and thanks [20:40:12] Fundraising Sprint Muggle Baiting: Turn off AmEx for non-US Adyen forms - https://phabricator.wikimedia.org/T139796#2442914 (XenoRyet) [20:40:42] Fundraising Sprint Muggle Baiting: Turn off AmEx for non-US Adyen forms - https://phabricator.wikimedia.org/T139796#2442929 (XenoRyet) p:Triage>Normal [20:41:41] My branch naming and patch notes workflow is all tied to ticket names anyway, so keeps it easy for me. [20:53:03] (PS1) XenoRyet: Disable AmEx payment submethod outside USA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298053 (https://phabricator.wikimedia.org/T139796) [20:58:15] ejegg or cwd: That Adyen patch is ready for review and should be really quick if either of you has a minute. https://gerrit.wikimedia.org/r/#/c/298053/ [21:00:19] sure thing [21:00:33] Cool, thanks [21:00:42] (CR) Ejegg: [C: 2] Disable AmEx payment submethod outside USA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298053 (https://phabricator.wikimedia.org/T139796) (owner: XenoRyet) [21:00:58] Yea, super easy. [21:02:42] (Merged) jenkins-bot: Disable AmEx payment submethod outside USA [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298053 (https://phabricator.wikimedia.org/T139796) (owner: XenoRyet) [21:28:00] ejegg: see any spaces in deploy calendar that we should request? I think we need to allow at least a few days forewarning for such requests (so maybe from Tuesday onward)... [21:28:04] https://wikitech.wikimedia.org/wiki/Deployments#Week_of_July_11th [21:30:20] AndyRussG: Maybe Wednesday between noon and 3 EST? [21:30:34] Err, EDT [21:30:37] UTC-4 [21:51:35] ejegg: cool, works for me! K, requesting it... :) [21:51:48] thanks! [21:52:44] oh, it's scrum of scrums from 1:30-2. if the deploy is looking hairy I'll just ask if someone else can attend [22:01:00] hey ejegg is this good to merge https://gerrit.wikimedia.org/r/#/c/297944/ - [22:01:18] oh it is merged [22:01:31] no it's not [22:01:59] I /think/ so! Err, let me actually test that 'payments init messages' thing locally [22:04:55] (CR) Ejegg: "A few observations - I'll keep scrutinizing" (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [22:07:11] ejegg: i am getting this trying to open the iframe under mustache: *** UNKNOWN MERCHANT test ACTION INSERT_ORDERWITHPAYMENT (130) IS NOT ALLOWED [22:07:23] wonder if maybe i have some config messed up? [22:07:26] sounds like credentials [22:08:19] what i have should be pretty much default vagrant [22:09:00] cwd yeah, you'll need something realer to actually make API calls [22:09:56] ejegg: how real are we talking? live creds real? [22:20:36] eileen: Sure, I think it's good to merge! [22:22:16] ejegg: cool I'll deploy & let them know [22:22:56] I'll keep an eye on the queue consumer [22:22:59] I actually realised last night it didn't need to stop them merging [22:23:26] heh, overloaded verb [22:23:26] because it did work without that patch - it just left a confusing change log & took more sql transactions [22:23:38] anyway - going now [22:24:06] (CR) Eileen: [C: 2] "merge to deploy - self approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/297944 (owner: Eileen) [22:26:09] !log from bdf2afd417b70332c9542fd3ee4f14cb4e6f93cc to f477a42014dd1e6759849b347d5f73d710954d0b [22:26:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:29:03] Fundraising-Backlog, FR-Ingenico: 3502596148 mysteriously in 600 - https://phabricator.wikimedia.org/T139000#2443141 (MBeat33) Ingenico 6857880165 and 7014594213 from today are similar, stopped at status 600 but showing empty sets in fredge. Maybe related to {T139753} ? [22:33:49] eileen: ok, import job's looking good [22:34:11] going to head out for now, folks. have a great weekend! [22:35:11] ejegg: cool - thanks - glad to get that out [22:45:19] (CR) XenoRyet: [C: 2] "Looks pretty nice." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg) [22:47:06] (Merged) jenkins-bot: Encapsulated amount validation for better messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286261 (https://phabricator.wikimedia.org/T105618) (owner: Ejegg)