[00:27:45] Fundraising Tech Backlog: Convert FundraisingEmailUnsubscribe to use extension registration - https://phabricator.wikimedia.org/T108764#1529881 (Paladox) @awright hi, is this extension even used any more. I thought we use the donation extension now (I could think of the name of extension of by heart so calle... [00:30:26] Fundraising Tech Backlog, Fundraising-Backlog, Epic, Technical-Debt: [epic] Migrate fundraising extensions to the new format - https://phabricator.wikimedia.org/T95832#2446194 (Paladox) [00:30:34] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Convert DonationInterface to use extension registration - https://phabricator.wikimedia.org/T108763#2446191 (Paladox) Open>Resolved a:awight Hi I'm g... [01:49:14] Fundraising-Backlog, FR-Ingenico: 3502596148 mysteriously in 600 - https://phabricator.wikimedia.org/T139000#2416476 (DStrine) I'm adding this back to the top of our triage pile. [12:40:21] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2447080 (Jgreen) [14:07:54] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Operations, and 4 others: Redo /beacon/impression system (formerly Special:RecordImpression) to remove extra round trips on all FR impressions (title was: S:RI should pyr... - https://phabricator.wikimedia.org/T45250#2447263 [14:12:18] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Operations, and 4 others: Redo /beacon/impression system (formerly Special:RecordImpression) to remove extra round trips on all FR impressions (title was: S:RI should pyr... - https://phabricator.wikimedia.org/T45250#2447284 [15:51:44] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2447784 (BBlack) [15:54:50] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2447794 (BBlack) @Jgreen thanks for working on this! I've re-audited all the Fundraising wikimedia.org hostnames, updated https://wikitech.wikimed... [16:38:41] dstrine: You are remote? [16:46:09] cwd: well, you called it. There are streams of ocean water squirting into every corridor, and broken riven heads strewn about the floors [16:46:12] *rivet [16:46:26] I'm still happy about progress on code quality, though :p [16:47:24] yeah, i have been feeling bad about saying that, i was in a frustrated mood. we are making huge strides towards code quality and maintainability [16:47:39] but your instincts were totally on point... [16:47:50] the paint is sloughing off the walls [16:48:45] btw. https://phabricator.wikimedia.org/T139686 [16:48:53] https://codeclimate.com/github/wikimedia/mediawiki-extensions-DonationInterface/code [16:50:25] yeah, that's gonna be great [16:50:55] it's like the meyers briggs test for code. creepily accurate [16:51:29] * awight shudders [16:51:37] 1.54 GPA sounds about right... [16:52:28] awight: annoyingly, it takes points off for TODOs [16:52:29] ooh, the trends tab is slick. Makes me wish we had more data... [16:52:48] yeah, I think we turned it on more than 3 months ago [16:52:59] ejegg: we can tweak all those settings... https://github.com/adamwight/cat-ache/blob/gh-pages/.codeclimate.yml [16:53:00] ejegg: i wonder if that's configurable. seems lame [16:53:09] heh [16:53:13] +1 to turn that off, although having the list of issues on a web page is nice [16:53:32] I also don't like the "unused formal parameter" rule, when we're just implementing an interface [16:53:57] e.g. https://codeclimate.com/github/wikimedia/mediawiki-extensions-DonationInterface/adyen_gateway/AdyenHostedSignature.php [16:54:00] on a philosophical level, if you don't have todos in your code you are living in a fantasy [16:54:09] that code is some day finished [16:54:16] Fundraising-Backlog, Recurring-Donations: Make different monthly receipt for recurring donors - https://phabricator.wikimedia.org/T112966#1651193 (DStrine) spec: https://docs.google.com/presentation/d/1cNBdsgmyC4zzJs1LxL9ZtMXNhVSXBPWhvVQ4fvN1tVs/edit#slide=id.p [16:54:35] cwd: +1 [16:58:39] the-wub: Okay, should be clear to put campaigns up again. [16:59:44] i have to go shuffle a couple batteries around for a minute but will hop on the call after that [16:59:49] awight / cwd shall we try to deploy the DI changes again before bumping to 1.26 [17:00:25] ejegg: yeek. Sure. I think your guess was right, that the extension registration blew away some config [17:01:23] awight: i think it was two bugs, both my fault. first, I disabled the referrer check when I broke up the antifraud triggers [17:01:40] then, i broke storing the referrer in session when i took it out of logs and queue messages [17:02:03] the second bug didn't cause any issues because the referrer check wasn't happening [17:02:04] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2448233 (awight) [17:02:15] the-wub: It's safe to put the campaigns up again... [17:02:31] ejegg: ooh ty for figuring it out! [17:02:38] awight: yep thanks. am in meetings, so will do it when I get a chance [17:03:04] fundraising-tech-ops, Operations, Traffic: Fix nits in Fundraising HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2448253 (Jgreen) >>! In T137161#2447794, @BBlack wrote: > @Jgreen thanks for working on this! I've re-audited all the Fundraising wikimedia.org ho... [17:03:06] the-wub: I can do it, if you're okay with that [17:03:06] sorry for introducing the bugs in the first place :S [17:03:19] ejegg: :p it was teamwork [17:03:40] awight: yeah that would be great [17:03:42] heh, anyway, we merged something friday to get the referrer back in session for the filters to work on [17:04:08] the-wub: k! [17:04:34] so, i'll prep a deploy on 1.25 with the friday fix [17:04:59] ejegg: i think that bug actually shook loose some stuff that was good to find [17:05:57] AndyRussG|rrrg: can you remind me--the Special:CentralNotice campaign overview grid has smart conflict detection now, right? [17:06:30] like, I mostly won't overwrite other admins' changes? [17:06:51] awight: not conflict detection, no. But it only changes stuff that you've clicked on [17:07:13] So, two admins can be saving changes at the same time, and so long as they're changing stuff on different campaigns, it should be OK [17:07:38] Also, hi! [17:07:40] that's awesome, thanks for adding! [17:07:48] AndyRussG: hehe sorry about the pleasantries :D [17:08:19] hi! Wish I'd had a longer layover in Montreal... we sat in the US zone of the airport :x [17:08:28] Heh it's being here w/ all of you pleasantry :) [17:08:40] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/298304 [17:08:46] awight: awww oh well... there'll be another time!! [17:09:17] !log reenable fundraising campaigns [17:09:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:09:32] AndyRussG: We had a amusingly great time in toronto on our 10-hr layover, though [17:09:33] ^ I meant, "being her w/ all of you is always a pleasantry :)" [17:09:39] It's all the kid talks about :) [17:09:40] cwd shook stuff loose? like what else? [17:09:52] (Dunno what happened to the extra words disappearing) [17:09:56] lol [17:10:00] awight: cool! What did you do there? [17:10:56] AndyRussG: we went to the island, to the roller coaster park and then a few nice fountain+wading pool spots [17:11:03] it was all the kid ever wanted from life... [17:11:18] ejegg: isn't that how you noticed stuff missing from session? and wasn't there something else about referrer being screwed up for awhile? [17:12:03] ah right, i thought you'd seen more stuff too [17:12:21] dstrine: oops, tech fire on the deck took priority over talking about smoldering. lmk if I should jump into the call for anything [17:12:51] thanks for putting campaigns back up :) [17:12:52] (CR) Ejegg: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/298304 (owner: Ejegg) [17:12:55] awight: ^ [17:12:57] AndyRussG: this might be interesting to you... https://codeclimate.com/github/wikimedia/mediawiki-extensions-CentralNotice/code [17:13:00] the-wub: np! [17:13:01] ejegg: now that i'm thinking about it, what was broken with referrer? is there still something? [17:13:16] cwd: https://phabricator.wikimedia.org/T139706 [17:13:18] that should never happen [17:14:15] cwd we quit storing it in session when https://gerrit.wikimedia.org/r/#/c/289888/ merged [17:14:44] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/298304 (owner: Ejegg) [17:14:51] and without it being in session, we would take the GC form address as the referrer when the users got redirected back [17:14:55] K i needa screw with the fredge consumer now... [17:15:12] aaah right [17:15:20] cwd anyway, it should be alright now as far as I can reason [17:15:26] so this bad referrer is totally unrelated [17:15:55] cwd actually, it's probably the same reason [17:16:10] oh really? how come? [17:17:17] any request without referrer on the qs / post would use the referrer header, which in a lot of cases IS going to be from our own site [17:17:50] Fundraising-Backlog: Investigate Failmail: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2448458 (MBeat33) [17:17:51] i know a lot of our forms have it reposting each time, but i'm betting there are a bunch of cases where it doesn't [17:18:43] oh totally [17:18:48] man good detective work [17:18:53] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Investigate Failmail: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2448471 (awight) p:Triage>High [17:19:26] heh, easier to find bugs when you vaguely remember writing them [17:19:29] awight: is this the job that puts contributions in civi? [17:19:39] the broken one [17:19:53] cwd: fredge is the database with payments_initial records and fraud details [17:20:34] oh yeah [17:25:38] (PS1) Awight: Use the decoded array to access message content [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298306 [17:28:10] ejegg: ^ [17:32:17] (PS1) Ejegg: Don't treat stomp frame like array [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298308 [17:33:37] awight: oops, missed yrs [17:34:07] (CR) Ejegg: [C: 2] "Thanks for fixing my copypasta." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298306 (owner: Awight) [17:34:43] (Abandoned) Ejegg: Don't treat stomp frame like array [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298308 (owner: Ejegg) [17:36:23] (Merged) jenkins-bot: Use the decoded array to access message content [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298306 (owner: Awight) [17:40:54] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298309 [17:41:49] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298309 (owner: Ejegg) [17:42:18] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298309 (owner: Ejegg) [17:44:08] !log updated CiviCRM from f477a42014dd1e6759849b347d5f73d710954d0b to bf029eecb9bfb49d267e60d76344b0170bfa0a83 [17:44:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:45:07] ejegg: shall I turn the job on? [17:45:41] awight: sure, let's turn batch size down to 1 and try a couple runs [17:45:57] i'm in the admin ui, i'll change batch size [17:46:16] thx [17:46:21] on your mark [17:47:13] awight: go ahead [17:47:31] no batch size for fredge qc, so i gave it a 1 second limit [17:48:01] d'oh. that's fine, it failed fast and only sent one mail [17:48:20] ejegg: okay, it works again, let it rip [17:49:01] k, back to 60 sec [17:49:52] nice, message merge patch doesn't seem to have slowed it down [17:49:58] looking at the data to double check [17:50:26] awight: yeah I'm remote. I accidentally closed IRC for a bit there. Thanks for looking into the civi problem. [17:51:04] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM db lock damaging queue consumption - https://phabricator.wikimedia.org/T139973#2448636 (awight) [17:51:16] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM db lock damaging queue consumption - https://phabricator.wikimedia.org/T139973#2448648 (awight) [17:52:05] dstrine: nbd, we can have our conversations over video if you'd like, maybe grab some calendar space? [17:53:50] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Unplanned-Sprint-Work: Bad paymentswiki referrer appearing in contribution_tracking - https://phabricator.wikimedia.org/T139706#2440326 (Ejegg) Pretty sure this is the same issue as T139756, I broke the referrer filter and stopped storing referr... [18:00:56] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/298313 [18:08:24] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/298313 (owner: Ejegg) [18:11:06] fr-tech: did anybody notice all the 'missing predecessor' damaged astropay messages? Looks like they came in Tuesday June 28th [18:12:08] noo [18:12:16] k, making a ticket [18:14:34] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/298313 (owner: Ejegg) [18:16:33] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Unplanned-Sprint-Work: Investigate and clean up Astropay 'MISSING PREDECESSOR' messages - https://phabricator.wikimedia.org/T139982#2448861 (Ejegg) [18:17:35] OK awight / cwd / XenoRyet , i'd like to deploy that DI code again, including taking AmEx down for non-US Adyen donors [18:17:49] righteous [18:17:51] Sounds good to me. [18:17:59] great! I'll drop crumbs into my keyboard as the logs scroll by [18:20:21] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2448903 (awight) Scary--@MBeat33 reports that nobody Donor Services knowingly ran a dedupe today. This mig... [18:22:43] k, rsyncing [18:23:01] !log updated payments from 2fc573cbb94e833c4144aa9dad79de8ec374bb09 to d9f7027340e5311f38c4224c2fddde087467df87 [18:23:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:24:14] merging 25 into 26 explodes in a big way. we might want to just delete that branch and remake it when we are ready to roll [18:24:37] how does everyone else feel about that? [18:24:39] cwd: +1 [18:25:38] ejegg: globalcollect_gateway_payment_in 37056083:7407025232 FINAL STATUS: 'complete:process' [18:25:41] :D [18:26:37] i can't actually delete branches but i could force push to it i guess [18:26:51] wait [18:26:52] erm [18:26:58] or maybe i can't [18:27:23] awight: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core,branches [18:27:28] what exactly is the problem? Can't we just roll forwards with the fundraising/REL1_26 branch? [18:28:36] awight: i don't know how to retrofit it with the recent changes to 25 [18:28:51] i might be missing something simple... [18:28:53] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: General DonationInterface code cleanup - https://phabricator.wikimedia.org/T87043#2448962 (Danny_B) [18:29:21] cwd: lessee. I would just try to apply the REL1_25..fundraising/REL1_25 diff [18:29:26] trying... [18:29:32] (there is no try, only do) [18:30:14] cwd: git diff origin/REL1_25 origin/fundraising/REL1_25 is only 280 lines... [18:30:25] oh. [18:30:40] first thing to do is to backport from core rel1_25, one moment... [18:31:41] (PS1) Awight: Merge REL1_25 into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/298320 [18:32:25] strange, but decent. [18:32:38] were we missing much? [18:32:52] ejegg: some fixes we probably want [18:33:13] ejegg: oops, I misread--no, we don't care. Just test fixes [18:33:29] So for 1.26, it's mostly just images and submodules that turn it into 'fundraising/', right? [18:33:44] ejegg: try git diff origin/REL1_25 origin/fundraising/REL1_25 [18:34:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2449056 (LeanneS) [18:34:16] It's a few little things... [18:34:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2449068 (LeanneS) p:Triage>Unbreak! [18:34:36] d'oh [18:34:43] I'm gonna eat a fud. [18:39:59] cwd what recent changes to 1.25 are you concerned about? [18:40:20] hmm, i just tried merging it and the conflicts were crazy [18:41:38] isn't all of that stuff backported to both 1.25 and 1.26? I think we just need to make sure fr/REL1_26 has the same customizations as fr/REL1_25, and most of them are all set [18:42:03] got extensions, skin and vendor submodules, got images dir [18:43:50] ah, needs favicon [18:44:14] and can zap a couple more readmes [18:45:19] ejegg: sorry yeah i just meant the changes that we have made to fr/1.25 since creating fr/1.26 [18:45:41] i'll look closer at the merge [18:46:35] cwd pretty sure it's just the DI submodule updattes since that security release [18:47:56] well when i created that branch it was from core/1.26 [18:48:10] i did not pull 1.26 into fr/1.25. i thought better to start fresh, but maybe not? [18:48:13] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2449177 (MBeat33) It looks like these may have been the actions: Contact ID 268850 has been merged into Co... [18:48:19] (CR) Ejegg: [C: 2] "re-applying awight's +2" [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297904 (owner: Ejegg) [18:48:33] cwd definitely better to start fresh! [18:49:02] a bunch of those security patches needed different code to backport to 1.25 [18:51:02] cool, maybe i should just try to merge the last bunch of patches specifically instead of the whole branch [18:51:39] cwd huh, paladox did just delete composer.lock from the repo. is that kosher? [18:51:47] seems to still pass tests [18:52:34] we don't do any composer stuff on prod so i think it's fine [18:52:45] i think CI does composer update [18:52:53] so i think it's ok... [18:53:02] (Merged) jenkins-bot: Use REL1_26 extension branches [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/297904 (owner: Ejegg) [18:56:10] k. we should make sure our versions match in DI for monolog and lightncandy [18:57:44] checking for diffs between mediawiki/vendor branches rel1_25 and fr/rel1_25... [18:58:49] ejegg: if possible want to not use FR specific branches for the extensions? [19:00:55] (PS1) Ejegg: More fundraising/ customizations for 1_26 [core] (fundraising/REL1_26) - https://gerrit.wikimedia.org/r/298326 [19:01:38] cwd yeah, those are all generic REL1_26 branches, except vendor [19:01:57] oh hey, vendor /is/ generic now [19:02:52] cwd: I agree with basckscroll, it's definitely better (only possible) to start fresh there. [19:03:06] The composer.lock thing was something paladox explained to me last week [19:03:22] it made sense at the time... [19:03:43] seems kosher. apparently it's not only best practice (at WMF), but is necessary for some janky CI thing that looks for a *second* lock file under in vendor/ [19:03:48] ejegg: yep vendor is vanilla, be awesome if we could keep it that way but i dunno [19:04:50] git seems really unwilling to cherry pick a bunch of submodule updates. [19:05:13] don't [19:05:14] ! [19:05:16] Eh, no need to cherry pick [19:05:25] just bump it to the latest? [19:05:28] git diff origin/REL1_25 fundraising/REL1_25 [19:05:31] that's all [19:05:44] cwd: yah bump it to DI#deployment [19:06:11] (PS1) Ejegg: Update composer libs to match REL1_26 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298329 [19:06:22] guess I should read lightncandy changelog [19:06:57] ty! [19:12:36] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2449404 (MBeat33) It looks like DS agents cid=12105651 and cid=6353743 missed my fwd of Eileen's warning on... [19:12:49] (CR) Florianschmidtwelzow: [C: -1] Convert FundraiserLandingPage to use extension registration (1 comment) [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [19:14:25] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2449433 (awight) It looks like this was a result of: > https://civicrm.wikimedia.org/civicrm/contact/merge?... [19:16:46] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Unplanned-Sprint-Work: Bad paymentswiki referrer appearing in contribution_tracking - https://phabricator.wikimedia.org/T139706#2440326 (Ejegg) Open>Resolved a:Ejegg [19:21:00] Fundraising Sprint Muggle Baiting, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Turn off AmEx for non-US Adyen forms - https://phabricator.wikimedia.org/T139796#2449457 (XenoRyet) Open>Resolved [19:21:42] (CR) Ejegg: "Took a look at the monolog (1.12->1.14) and lightncandy (0.18->0.21) changelogs, nothing we need to worry about." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298329 (owner: Ejegg) [19:23:51] (CR) Awight: Migrate to extension registration (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [19:25:50] ejegg: is having monlog as a non-dev dep the only difference between our vendor and core? [19:25:56] deploy is looking solid, i'mm grab food [19:26:20] cwd it's a diff in composer.json, but it looks like the core vendor does have monolog in it [19:27:09] back in a few [19:28:48] well that's strange...it's a dev dependency but in the main branch [19:57:32] (PS8) Reedy: Convert FundraiserLandingPage to use extension registration [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [20:00:51] (CR) Florianschmidtwelzow: [C: 2] Convert FundraiserLandingPage to use extension registration [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [20:01:59] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2449706 (DStrine) [20:02:00] (Merged) jenkins-bot: Convert FundraiserLandingPage to use extension registration [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [20:02:09] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2449056 (DStrine) [20:10:48] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2449056 (awight) @Eileenmcnaughton Note that the Engage role has some special hooks you should be aware of... [20:20:43] !log disabled fundraising donation queue consumer... [20:20:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:30:17] Awkwardtown: "show full processlust; [20:32:27] so 'merge and go to listing' has no limit in the url [20:33:07] but locally, i see the same number of results with and without the limit [20:33:58] ohh, limit only applies when a group is selected? [20:37:34] eileen: so limit only works in conjunction with a group? [20:38:46] no - even without [20:38:50] ejegg: what url are you hitting? i need to get up to speed with what's going on in civi-land [20:38:55] I just tried to replicate on staging & failed [20:39:14] cwd https://civi.dev:4443/civicrm/contact/dedupefind?reset=1&action=update&rgid=4&limit=1 [20:39:46] thanks! [20:40:30] I might need to find out how they triggered that url [20:42:30] haha [20:42:41] i got "crazy deduping of the entire database is not available" [20:42:50] cwd that would be local [20:42:53] heh, not till now! [20:43:11] the thing is - I can't figure how they got to that url [20:43:18] cwd: Step away from the airlock, Dave. What are you doing. [20:43:27] Dammit HAL, open the door! [20:43:32] ejegg: Hey, did you still want to meet today? [20:44:00] K4-713: oh shoot, i got caught up in the db thing! [20:44:10] Sure, lemme get back in the conf room [20:44:15] ejegg: No worries if you're busy... [20:44:22] We can reschedule for a less interesting time. [20:44:56] K4-713: if your schedule allows, that might be nice [20:45:04] So I think first line of defence is to block them submitting the find & merge page without a limit [20:45:13] & perhaps specific roles [20:45:18] rules [20:51:21] (PS29) Awight: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [20:52:01] (PS6) Awight: Clean up from extension registration migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293687 [20:52:07] (PS5) Awight: Clean up annoying punctuation and unnecessary strict equality [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293688 [20:53:02] AndyRussG: I'm hoping that this glitch explains the MobileFrontend failures you were seeing... https://gerrit.wikimedia.org/r/#/c/186899/28..29/CentralNotice.hooks.php,unified [20:54:02] awight: cool thx! [21:02:21] AndyRussG: meeting? [21:03:14] dstrine: coming! [21:09:43] eileen: figured out my local issue with limit seemingly ignored. I ran a find with limit 100 and it filled the prevnext_cache for the merge key. Then I tried for a smaller limit and it showed all the same results from the prevnext cache. [21:10:00] (not that it has anything to do with the initial query limit) [21:16:45] eileen: I'm responding to MBeat, should I mention that dedupe is "game on" or "game off"? [21:19:47] (PS1) Eileen: Block access to merge screen without a limit. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298378 (https://phabricator.wikimedia.org/T139964) [21:20:39] awight: I''ve just pushed a 'first line of defence patch' https://gerrit.wikimedia.org/r/#/c/298378/ [21:20:50] taking a look [21:21:58] I couldn;t figure out a way to wind up on that screen from the ticket [21:24:33] the links at the bottom of the screen and the 'merge and go to result' button [21:27:10] (PS2) Ejegg: Block access to merge screen without a limit. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298378 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [21:27:29] (CR) Ejegg: [C: 2] "Works locally!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298378 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [21:28:32] ejegg: when I click on merge & go to result I get to the merged contact [21:28:48] oops, i mean 'go to listing' [21:29:20] hmm - that was adding the limit before for me [21:29:27] now I'm hitting the hook [21:29:55] (Merged) jenkins-bot: Block access to merge screen without a limit. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298378 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [21:30:33] I thought it would be thouse sourceParams lines in DedupeFind l135 [21:31:03] but I added $limit there and no change [21:31:33] hmm - I can merge & go to listing on staging [21:31:33] https://civicrm.frdev.wikimedia.org/civicrm/contact/merge?reset=1&cid=1&oid=252718&action=update&rgid=13 [21:33:56] I'll deploy that patch & keep diggin - I think with it we can bring up the queue [21:35:24] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298384 [21:36:27] (CR) Eileen: [C: 2] "Merge to deployment - self-approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298384 (owner: Eileen) [21:37:22] awight: I'm trying to deploy that one patch & on boron seeing .LocalSettingsNoBackup.php [21:37:33] wanting refresh - is that fine? [21:38:21] eileen: found a template to update, patch up soon [21:38:23] eileen: hrm. yeah go ahead, thanks [21:38:35] it's in git now, so we can forensic that up, at least [21:39:17] ok - so that first line of defence fix is out - I think we can start the queue again [21:39:24] & tell them they can use Civi normally [21:40:12] eileen: ok, no atomic queries are running at the moment. resuming the consumer... [21:40:42] !log resuming fundraising donations queue consumer [21:40:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:46:12] On the engage one - what I see (as me) is that once I choose 'Arizona drop box' the 'gift information custom data set gets added onto the form [21:46:38] hmmm [21:47:07] Is that encoded in the custom group "extends" field? [21:50:28] ejegg: Mind if I write a logging patch for T101129 ? [21:51:00] awight: be my guest! [21:51:05] k [21:51:14] ouch that admin setting meeting has snuck up [21:51:33] awight: yep [21:51:44] is it only supposed to be for Arizona ? [21:52:37] eileen: Arizona Lockbox is the old vendor's name, it was replaced by Engage [21:52:50] I think it's correct that it's only supposed to be for Engage donations [21:53:01] So maybe what happened is that the hook which defaults the contribution type to Engage is borken? [21:55:21] gotta relocate, back soon! [21:55:45] awight: I forgot you were invited to the next meeting. You don't have to go. [21:56:11] dstrine: I accept. Feel free to pull me in if there's anything I can help with, though [21:58:38] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2450338 (Eileenmcnaughton) Hi, It looks like the field is there when the right financial type is chosen b... [22:05:16] K4-713: We doing the meeting thing? [22:23:20] Fundraising-Backlog: Ingenico: iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2450447 (MBeat33) [22:48:31] (PS1) Awight: Support verbose logging for cURL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 [22:48:42] ejegg: Not a happy place. But it might work ^ [22:49:06] cwd: Anything I can do to help with 1.26? [22:49:53] hmm, i saw a couple patches from ejegg i should review [22:50:00] when do you want to try it out? [22:50:21] ut-oh, that last deploy might have broken iDEAL [22:50:33] hehe. once we're stable for a moment, I guess [22:51:05] I think we should have a retro about last Thursday. The "waterfall day" was pretty interesting in the various exotic failure modes we all suffered [22:51:22] Definitely made me appreciate our usual incremental deployment approach [22:51:54] remember when release cycles were months long? [22:52:16] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Investigate Failmail: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2450587 (awight) [22:52:29] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Regression, Unplanned-Sprint-Work: Unknown campaigns are causing queue consumer to splutter - https://phabricator.wikimedia.org/T139868#2450589 (awight) [22:52:31] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Investigate Failmail: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2448458 (awight) [22:52:50] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Unknown campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2448458 (awight) [22:53:09] cwd: no, cos everyone would be fired before they could see 2 of them [22:53:21] guh, ideal seems to work for me... [22:53:40] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up Codeclimate for Fundraising repositories, make it part of our process - https://phabricator.wikimedia.org/T139686#2439865 (awight) a:awight [22:54:04] ejegg: didn't it kind of sound like an outage where we are eating the error? [22:54:43] ejegg: slick hack suggestion! [22:55:41] cwd ah, a normal outage, just no feedback [22:56:16] awight: heh, also check your log var names [22:58:25] yah [23:01:18] (PS1) Ejegg: Add limit to sourceUrl on dedupefind results [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/298396 [23:02:48] (PS2) Awight: Support verbose logging for cURL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 [23:02:52] ejegg: works! [23:03:08] woohoo! [23:03:25] (PS3) Awight: Support verbose logging for cURL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 [23:03:35] (CR) Cdentinger: "Is this to match vendor in MW? Is there a reason they need to be the same? I've heard of a "composer merge plugin" but don't know what i" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298329 (owner: Ejegg) [23:03:50] it's a shame that the getinfo server ip thing doesn't work at all, though [23:06:58] dstrine-away: aww, I'm not able to edit the dashboard panel. needs updating to the current sprint: https://phabricator.wikimedia.org/dashboard/manage/129/ [23:07:44] (CR) Ejegg: "yep, just want to make sure we don't have two different versions of the same libs registered. Composer merge does indeed sound like a thin" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298329 (owner: Ejegg) [23:08:01] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2450687 (awight) a:Eileenmcnaughton [23:10:36] (PS1) Ejegg: Add limit to some dedupefind urls [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/298398 [23:14:38] ejegg: so I'll go ahead and book the deploy slot for Wednesday 9 am PST as per gre g-g's e-mail, all good? [23:14:51] AndyRussG: sure thing! [23:14:58] ejegg: k thx!! [23:15:21] ejegg: shouldn't it not matter if there are two versions of a lib around? not that you shouldn't upgrade it, but i want to make sure i understand composer [23:15:46] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2450739 (LeanneS) @Eileenmcnaughton I can ask, but I believe they would only be using the Engage financial... [23:16:15] cwd: I don't think it'll work. The autoloader order is the same for all components, so everything either gets the old or new lib classes. [23:17:21] my understanding was it will autoload classes in vendor, and where ever else you specify in composer.json [23:17:52] cwd just want to know which one we're actually going to get [23:17:54] so if core autoloads extensions i can see how they would conflict [23:18:54] composer adds autoloads from both mediawiki-core/vendor/autoload.php and DI/vendor/autoload.php, before any application code runs... [23:18:58] instead of depending on where you require the autoloader in localsettings [23:20:55] ah yeah i'm all confused [23:21:03] i can see why you want a composer merge plugin now [23:21:44] crap, getting notices just loading the astropay form [23:25:13] ejegg: on what? new vendor? [23:26:14] Deploy slot book'd! [23:28:15] (CR) Ejegg: "This does the trick! Want to associate it with T139698 ?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 (owner: Awight) [23:29:14] cwd nope, i think it's trying to stage stuff and missing some fields (cause it's the first load) [23:30:02] ejegg: what branch are you on? [23:31:06] same on either one, i've got a lil fix coming [23:32:47] (PS1) Ejegg: Stop trying to access undefined field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298401 [23:33:25] ah gotcha [23:33:29] sorry lost in email land [23:33:38] omg ppl are catching pokemons around me [23:33:41] (PS4) Awight: Support verbose logging for cURL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 (https://phabricator.wikimedia.org/T139698) [23:34:47] scary! Bad day to look cute and round [23:35:23] i have the vague idea that there is some layered reality pokemon thing going on that i know nothing about [23:43:40] pokemon go [23:43:59] the ingress guys released it last week [23:44:39] I'm stuck. So we have the automated quality checks, and Atom feeds if that's helpful, but I'm failing to see how to integrate this into our workflow. [23:45:21] that provider doesn't seem to have great integration tools [23:45:29] are you looking for pre-merge testing? [23:45:42] bd808: yes, that was the main thing that's jumping out at me! [23:46:24] you might be able to hack something up with github. cscott long ago had a thing that would make jenkins push a patch to a branch on github so that traavis-ci could see it [23:46:55] I think that it may actually still be in use for ocg [23:47:01] dang. [23:47:57] I'm finding a lot of crazy here, https://wikitech.wikimedia.org/wiki/OCG [23:49:38] well, pre-merge is just one frontier. [23:50:10] I'd be happy with it being an after-action thing, but I haven't thought of a way to use it that makes sense. [23:50:23] We could go through the weekly summary as a team, I guess... [23:50:34] I use this one for composer-merge-plugin -- https://scrutinizer-ci.com/g/wikimedia/composer-merge-plugin/?branch=master [23:50:55] that's nice, thx [23:51:35] 50€/mo, eh? [23:51:53] aha > We do not charge for open-source repositories, you can add as many as you like. [23:51:59] I'm on some free tier [23:52:36] * AndyRussG re-opens recently closed tab [23:54:22] (PS1) Eileen: Fix for engage custom data not loading. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298403 (https://phabricator.wikimedia.org/T139990) [23:55:35] bd808: too bad! scrutinizer requires admin access to the repo, which I don't have [23:55:54] awight: which repo(s)? [23:56:02] and do you want admin access on github? [23:56:07] I have a fix for the engage unbreak now,,, https://gerrit.wikimedia.org/r/#/c/298403/ [23:56:11] * bd808 has powers [23:56:19] bd808: https://gerrit.wikimedia.org/r/#/c/298399/2/wmf-config/InitialiseSettings.php,unified [23:56:42] scary. I have 2FA on github though, so sure, I'd accept some sort of powerup [23:56:59] * awight waits for pac-man music to get louder [23:57:24] bd808: ooh ooh, can i be part of the org? [23:58:32] sure. what's your github nick? [23:58:38] I did notice that codeclimate can emit Slack or an Atom feed... so it shouldn't be too hard to plug that into something that burst into flames [23:59:01] "adamwight" [23:59:26] * awight glances at XenoRyet eileen ejegg -- the party is here ;-) [23:59:35] bd808: https://github.com/caseydentinger