[00:00:33] i find it super annoying that github now wants you to pick which repos appear on your page [00:00:40] this kills the metric [00:01:41] It still does the top stars thing I think [00:01:51] if you haven't pinned any repos [00:02:50] ok, invites are in the mail. [00:02:54] thanks! [00:03:24] I made a fundraising team too. awight can make repos and give the whole team control of them [00:03:30] wicked, thanks! [00:08:05] oh awesome [00:11:11] woot, thanks bd808 and awight! [00:12:25] AndyRussG: Do you have a github account? [00:12:45] aha, found you! [00:18:57] ack, unsub all the repos! [00:21:58] ok folks, i'm done for the day. see y'all tomorrow [00:22:07] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up Codeclimate for Fundraising repositories, make it part of our process - https://phabricator.wikimedia.org/T139686#2450971 (awight) Here's another quality tool for us to experimen... [00:25:19] out. see you! [01:02:21] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2448233 (Eileenmcnaughton) a:Eileenmcnaughton [01:03:11] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add WMF donor fields to Civi production - https://phabricator.wikimedia.org/T138968#2451050 (Eileenmcnaughton) @LeanneS OK to close? [01:03:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2451054 (Eileenmcnaughton) [01:04:00] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create new prospecting fields - https://phabricator.wikimedia.org/T138908#2451052 (Eileenmcnaughton) Open>Resolved Closing this as it seems to duplicate one I asked i... [01:04:17] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Upgrade to CiviCRM 4.7.9 - https://phabricator.wikimedia.org/T138802#2451055 (Eileenmcnaughton) Open>Resolved [01:04:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2451056 (Eileenmcnaughton) [01:05:11] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Investigation: dedupe exact matches - https://phabricator.wikimedia.org/T132396#2451060 (Eileenmcnaughton) [01:05:12] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: Write a hook to skip the calculated tables from conflict consideration - https://phabricator.wikimedia.org/T133625#2451058 (Eileenm... [01:06:06] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Prepare 4.7 CiviCRM branch & clean our patches into it - https://phabricator.wikimedia.org/T136252#2451063 (Eileenmcnaughton) [01:06:08] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix the group performance issue ... better - https://phabricator.wikimedia.org/T139006#2451061 (Eileenmcnaughton) Open>Resolved Closing this as... [04:37:56] (CR) MZMcBride: "Nice." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296275 (https://phabricator.wikimedia.org/T138177) (owner: Ori.livneh) [08:11:08] (PS1) Awight: Switch to caret semantic versioning [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/298418 [08:18:25] (PS1) Awight: [WIP] Loosen version requirements to allow for updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298420 [11:15:16] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Astropay, Unplanned-Sprint-Work: Investigate and clean up Astropay 'MISSING PREDECESSOR' messages - https://phabricator.wikimedia.org/T139982#2452118 (Danny_B) [11:21:20] Fundraising-Backlog, FR-Ingenico: iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2452151 (Danny_B) [13:18:00] Fundraising-Backlog, fundraising-tech-ops, Operations: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2452594 (faidon) The only requirement from my side would be to use a granularity limiter ("g=donate" or "g=donate*" perhaps?), which I'm guess... [13:19:21] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Make Adyen default gateway for Ukraine - https://phabricator.wikimedia.org/T140086#2452599 (Pcoombe) [13:27:17] Fundraising-Backlog, Project-Admins: Create project for Fundraising - https://phabricator.wikimedia.org/T682#2452650 (Danny_B) [13:42:00] Fundraising-Backlog, fundraising-tech-ops, Operations: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2452782 (Jgreen) Thanks @dpatrick & @faidon. @CCogdill_WMF so the next step--could you get a statement from Silverpop to the effect of what dp... [14:51:06] Fundraising-Backlog: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2453194 (MBeat33) [14:56:21] (Abandoned) Cdentinger: Use RL to make RapidHTML wait for document ready [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297729 (https://phabricator.wikimedia.org/T139551) (owner: Cdentinger) [15:03:59] Fundraising-Backlog: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2453274 (MBeat33) [15:11:20] (CR) Cdentinger: [C: 1] "This works, will merge when we're about to deploy 26 so we don't have to cherry pick around it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298329 (owner: Ejegg) [15:16:08] cwd are we aiming to get 1.26 deployed today? [15:21:36] (CR) Cdentinger: [C: 2] "Can't hurt, might help." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298135 (owner: Ejegg) [15:26:18] (Merged) jenkins-bot: Add autoloader config to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298135 (owner: Ejegg) [15:48:48] Fundraising-Backlog, FR-Adyen: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2453506 (Danny_B) [15:52:15] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up Codeclimate for Fundraising repositories, make it part of our process - https://phabricator.wikimedia.org/T139686#2453575 (awight) The pre-merge nut is proving difficult to crack... [15:56:20] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2449056 (Ejegg) With patch https://gerrit.wikimedia.org/r/298403/ , I see the 'Engage' type pre-selected fo... [15:57:23] AndyRussG: thanks for meeting [15:59:44] AndyRussG: what do you think your next step is? Do you want time to think things through? [16:02:50] dstrine: hmmmm ;) [16:02:55] * AndyRussG ruminates [16:03:14] :) [16:03:18] For me the biggest question marks at this point are indeed technical [16:03:40] And the biggest unknown is what are the incremental steps [16:04:23] On the UI side I think the mock-ups could now be honed a bit (for example to remove all the banner diet options under each sequence element, and to add the randomize option Max mentioned) [16:04:48] But really I think we already know more or less how stuff will or should look [16:05:06] So yeah a good next step could be for me to come up with a more concrete implementation plan [16:05:13] or us [16:05:16] I should say [16:07:13] AndyRussG: I'm not going to be much help with the deeper technical stuff. Do you want to start with a conversation with the rest of fr-tech? [16:08:26] from my non-technical perspective: making banners their own independent unit outside of buckets seems like a big step [16:10:40] Fundraising-Backlog, FR-Ingenico: Ingenico iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2453724 (DStrine) [16:12:40] dstrine: that step may not be so big, fortunately :) [16:12:51] ok great [16:23:15] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2453878 (awight) @CCogdill_WMF... [16:27:48] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2453905 (Jgreen) >>! In T13250... [16:42:28] > Worst rated PHP Operations https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-DonationInterface/code-structure/master/hot-spots [16:58:22] Fundraising Sprint Muggle Baiting, Fundraising-Backlog: Adyen Israel form & AmEx validation - https://phabricator.wikimedia.org/T139523#2454141 (XenoRyet) The AmEx validation issue is fixed. Turned out to be that our account didn't have AmEx enabled for non-USD currencies, so the AmEx numbers were being... [17:01:12] awight not suprised to see form crap on there! [17:02:27] fr-tech: anybody got code ideas to chat about? [17:02:27] Fundraising Sprint Muggle Baiting, Fundraising-Backlog: Adyen Israel form & AmEx validation - https://phabricator.wikimedia.org/T139523#2454154 (MBeat33) That sounds awesome, thank you @XenoRyet [17:02:59] Nothing especially this morning, but I'm available to listen. [17:03:08] ejegg: hi! [17:03:18] hi awight [17:03:27] I was wondering if you wanted to spin off anything for me from T123002 [17:03:28] T123002: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002 [17:03:41] get that outta the way before moving on to the queue overhaul... [17:03:58] oh hey, yah, if you've got further fixes or want to take on another payment method that would be awesome! [17:04:41] Fundraising Sprint Muggle Baiting, Fundraising-Backlog: Adyen Israel form & AmEx validation - https://phabricator.wikimedia.org/T139523#2454178 (XenoRyet) Open>Resolved [17:04:49] I started on direct debit stuff before that, then realized we weren't using it at all: https://gerrit.wikimedia.org/r/292579 [17:06:38] fr-tech, want to do a tech chat about queue next steps and rapidhtml elimination? [17:06:50] sure [17:07:02] oh, why am I still afk [17:07:53] Let me finish up one quick thing, then I'll jump in the hangout. [17:11:03] ejegg: I wonder... maybe we don't have to reimplement everything all at once? [17:11:26] Fundraising-Backlog: Make Adyen iframe validation error validation messages more verbose - https://phabricator.wikimedia.org/T140133#2454213 (XenoRyet) [17:18:34] omw home, 15mins [17:19:31] sad; I'm lagged [17:21:45] lagged? [17:21:57] Fundraising-Backlog: Make Adyen iframe validation error messages more verbose - https://phabricator.wikimedia.org/T140133#2454242 (XenoRyet) [17:43:47] Things we can kill off with no witnesses: dd, boleto, yandex, webmoney, eps, sofort, moneybookers [17:46:03] Fundraising-Backlog, FR-Ingenico: Ingenico iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2454324 (MBeat33) @Pcoombe as this button is still inoperative, what would you think of putting up an interim message for donors? [17:51:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, Epic: [Epic] Rewrite all queue clients to use a single shim library, improve library - https://phabricator.wikimedia.org/T133108#2454335 (awight) [17:51:41] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 10 others: [Epic] Consolidate queue abstractions - https://phabricator.wikimedia.org/T131271#2454334 (awight) Open>Resolved [17:57:04] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Convert BPay to mustache - https://phabricator.wikimedia.org/T140138#2454374 (cwdent) [17:57:23] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2454391 (CCogdill_WMF) Yes, th... [18:04:12] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 6 others: Clicktracking data not matching up with donation totals - https://phabricator.wikimedia.org/T132500#2454429 (CCogdill_WMF) Open... [18:06:06] (PS2) Awight: Clean up style complaints (to squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297857 [18:06:12] (Abandoned) Awight: Clean up style complaints (to squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297857 (owner: Awight) [18:15:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Store payment method in Civi - https://phabricator.wikimedia.org/T140139#2454499 (awight) [18:35:00] (PS1) Ejegg: Doc & default for CurlVerboseLog [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298546 (https://phabricator.wikimedia.org/T139698) [18:41:36] (PS1) Awight: Remove unused forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298547 (https://phabricator.wikimedia.org/T123002) [18:41:43] It feels good!! [18:42:06] Fundraising-Backlog, FR-Ingenico: Ingenico iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2454610 (Pcoombe) @MBeat33 I've taken the Netherlands out of the low-level banner campaign, and added a note to the [[ https://donate.wikimedia.org/?countr... [18:47:17] (PS5) Ejegg: Support verbose logging for cURL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 (https://phabricator.wikimedia.org/T139698) (owner: Awight) [18:47:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.7 attempts to self-update an extension - https://phabricator.wikimedia.org/T140142#2454622 (awight) [18:48:00] (CR) Ejegg: [C: 2] "Looks good! I'll do those suggestions in follow-on patches." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 (https://phabricator.wikimedia.org/T139698) (owner: Awight) [18:48:43] ejegg: oops, thanks! I missed your review, somehow [18:49:29] yeah, guess I should always put a +1/-1 on things to make them stick out [18:50:03] i need to do that too [18:50:09] (PS2) Ejegg: Doc & default for CurlVerboseLog [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298546 (https://phabricator.wikimedia.org/T139698) [18:50:10] i just have a hard time -1 [18:50:16] i feel like a dick [18:50:50] (Merged) jenkins-bot: Support verbose logging for cURL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298395 (https://phabricator.wikimedia.org/T139698) (owner: Awight) [18:51:31] (PS1) Ejegg: Verbose cURL output for all retried requests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298549 (https://phabricator.wikimedia.org/T139698) [18:52:36] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Ingenico iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2450447 (awight) [18:53:24] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Ingenico iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2450447 (awight) I'll be able to fix this inc... [18:53:31] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Ingenico iDEAL donation form Continue button unresponsive for all banks - https://phabricator.wikimedia.org/T140028#2454681 (awight) a:awight [18:55:37] +1 to the "-1" thread [18:55:49] I have the same problem, but with the same negative side-effect. [18:55:56] We should team norm being a dick :p [18:57:13] If your intent is "I've done all the looking I'm gonna do to this patchset, and it still looks fucked up", then it's a courtesy to leave a CR-1 [18:57:49] We should start CR-2'ing each other so that -1s feel benign [18:57:54] ... i'm only half joking [18:58:44] fr-tech: ohey, something I forgot to put on our tech talk agenda: I think I have a solution to the code quality tools investigation. [18:59:04] Oh yea? [18:59:16] It seemed difficult and pointless to try to analyze our merges after the fact, so I started thinking about the CQ results as a planning tool instead. [18:59:45] So you would have the hit list of bad functions on your wall, and when a task comes up to fix something related, you tear the limbs off of bad function. [19:00:06] Alternatively, we use the CQ scores to multiply the difficulty of any estimates [19:00:24] (looking at backscroll) awight: if you do kill off some unused methods for good, could you let me know so I can remove their cruft from donatewiki too? [19:00:55] awight: i dig that [19:01:01] I like both of those ideas. [19:01:43] yeah, I guess it they aren't exclusive [19:02:27] the-wub: hi! Yes, awesome. Consider these forms deal until further notice... https://gerrit.wikimedia.org/r/298547 [19:02:42] The hit list is something I think could be really useful to us in the 'make things a little better every day' kind of way. [19:03:26] Especially if we do adjust estimates in particularly gnarly bits to account for the fact that we're going to do some cleanup while we're in there. [19:03:37] https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-DonationInterface/code-structure/master?elementType=operation [19:04:54] I can't argue with that list... every one of those names causes me to shudder and twitch on sight [19:05:51] only 7684 unique code paths through that top function ;-) [19:06:18] heh [19:07:50] Fundraising-Backlog, FR-Adyen: Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2454742 (MBeat33) [19:09:44] dstrine: T140146 will take just a few minutes, should I go ahead and pull it into the sprint? [19:09:44] T140146: Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146 [19:10:20] (PS6) Awight: Move js to call donate API into generic forms module [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297839 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:10:27] (PS8) Awight: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:10:29] XenoRyet: yeah sure if it's not too much trouble [19:10:39] (PS2) Awight: Remove unused forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298547 (https://phabricator.wikimedia.org/T123002) [19:11:08] Na, some of that tech debt that we've paid off recently makes this a super easy thing to do. [19:11:43] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen: Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2454760 (XenoRyet) a:XenoRyet [19:12:22] 4 of the 8 'F' functions are in the crosshairs with the rapidHTML / form consolidation [19:14:21] Fundraising-Backlog, FR-Adyen: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2454786 (MBeat33) [19:20:25] (PS1) XenoRyet: Adyen: Add American Express option for Israel and Ukraine [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298556 (https://phabricator.wikimedia.org/T140146) [19:20:58] ejegg: I've you've got 2 seconds ^ [19:21:07] *if you've got [19:21:24] sure! [19:21:57] (PS2) Ejegg: Adyen: Add American Express option for Israel and Ukraine [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298556 (https://phabricator.wikimedia.org/T140146) (owner: XenoRyet) [19:22:14] (CR) Ejegg: [C: 2] Adyen: Add American Express option for Israel and Ukraine [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298556 (https://phabricator.wikimedia.org/T140146) (owner: XenoRyet) [19:22:21] Cool, thanks [19:25:33] (Merged) jenkins-bot: Adyen: Add American Express option for Israel and Ukraine [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298556 (https://phabricator.wikimedia.org/T140146) (owner: XenoRyet) [19:26:56] So, the Mustache form doesn't show a logo when there's only one submethod? [19:27:01] Fundraising-Backlog, FR-Smashpig: Create pending database - https://phabricator.wikimedia.org/T140149#2454868 (Ejegg) [19:27:25] Seems like we would always want to show the logo? [19:29:10] awight: I forget why we decided on just a 'continue' button. Maybe just to keep the layout compact? Maybe because a single radio button looked weird? [19:29:38] I was thinking just the submethod logo... at least, that was how the iDeal page historically rendered [19:30:19] ah cool, that would probably look fine. I think the AliPay layout was decent too [19:30:23] with a single logo [19:33:33] too bad! The img alt attribute is hardcoded to English [19:33:51] ejegg: thanks for the pointer [19:34:08] awight: https://gerrit.wikimedia.org/r/287041 for alt localization [19:34:16] just a WIP [19:36:47] got a segfault! how exotic [19:38:06] (CR) Awight: "Neat, looks like a good strategy! Any reason not to move this out of WIP? Incomplete is fine, since you left an incremental migration pa" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287041 (owner: Ejegg) [19:42:29] (CR) Ejegg: "I think I wanted to send it through the same l10n path as the rest of the keys instead of directly calling WmfFramework." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287041 (owner: Ejegg) [19:50:28] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2454985 (CCogdill_WMF) Thanks @faidon and @dpatrick for making this possible, and in the nick of time! I really appreciat... [19:53:11] awight: I'll just do that in template 'logic' with a TODO to remove the complexity after adding keys for all submethods [19:53:40] that works! [19:56:34] (PS2) Ejegg: WIP localize card label alt/title attributes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287041 [19:56:52] (CR) Ejegg: "PS2: rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287041 (owner: Ejegg) [19:57:41] I really don't like Mustache scoping... [20:03:31] (PS3) Ejegg: Localize card label alt/title attributes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287041 (https://phabricator.wikimedia.org/T86248) [20:04:54] awight: meeting? [20:05:08] ack--getting headphones [20:05:21] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Unknown campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2455051 (CCogdill_WMF) Hey @awight, this is kind o... [20:14:26] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2455072 (Eileenmcnaughton) @Ejegg is that local - I found the field was view only locally - probably an err... [20:22:06] (PS1) Cdentinger: WIP: form displays, does not function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298572 [20:37:57] Fundraising-Backlog, fundraising-tech-ops, Epic: [Epic] Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2455215 (Jgreen) [20:37:59] fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2455213 (Jgreen) Resolved>Open reopening because the partman recipe didn't set up the RAID1 as desired. [20:46:53] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add WMF donor fields to Civi production - https://phabricator.wikimedia.org/T138968#2455246 (LeanneS) @Eileenmcnaughton Yes - thanks! [20:52:47] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add WMF donor fields to Civi production - https://phabricator.wikimedia.org/T138968#2455261 (Eileenmcnaughton) Open>Resolved [21:02:55] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, and 2 others: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2455284 (Eileenmcnaughton) [21:09:08] WorkPuddle test case: [21:09:09] Poor Tom, that eats the swimming frog, the toad, the tadpole, the wall newt, and the water; that in the fury of his heart, when the foul fiend rages, eats cow dung for salads, swallows the old rat and the ditch-dog, drinks the green mantle of the standing pool; who is whipped from tithing to tithing and stocked, punished and imprisoned; who hath had three suits to his back, six shirts to his [21:09:15] body, Horse to ride and weapon to wear. But mice and rats and such small deer Have been Tom’s food for seven long year. Beware my follower. Peace, Smulkin. Peace, thou fiend! [21:10:21] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, and 2 others: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2455308 (Eileenmcnaughton) @awight @Ejegg I'm going t... [21:12:11] (PS1) Ejegg: Clean up has_x flags in Mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298632 (https://phabricator.wikimedia.org/T86248) [21:12:31] (PS1) Awight: [WIP] rtbt methods support getAvailableSubmethods; display logo for only submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [21:13:15] ejegg: Something terribly I relearned about Mustache template syntax... see line 6 of https://gerrit.wikimedia.org/r/#/c/298633/1/gateway_forms/mustache/payment_method.html.mustache,unified [21:13:19] I think that's invalid. [21:13:54] Once you do a "{{#", you lose access to variables outside the scope of the expression you tested :( [21:14:06] (PS1) Eileen: Gift Information field is not view_only on live, don't make it so on dev [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298635 (https://phabricator.wikimedia.org/T139990) [21:14:47] ejegg: this won't fix your existing install but will make it better next time you rebuild https://gerrit.wikimedia.org/r/#/c/298635/ [21:15:06] awight: that can't be right [21:15:34] I wish it weren't. [21:15:51] 'submethods' isn't a property of 'show_submethods' [21:16:00] 'show_submethods' is just boolean [21:16:06] But notice how the variables inside the submodules block are unqualified [21:16:19] what u say is true, though... [21:16:37] yeah, i'm pretty sure it goes up a level if it doesn't find it in innermost scope [21:17:28] or maybe booleans don't create a scope? wonder what happens when you use '.' with a boolean flag [21:18:00] It wasn't working for me to use outer vars [21:18:12] It's possible that {{# has access to the top scope, still? [21:18:14] so janky [21:18:42] huh, what was breaking for you? [21:19:14] I wrapped label and logo in a hash cos I couldn't find any other way to test and use two variables [21:19:21] sadness ensues [21:19:40] button_class btw doesn't display correctly, even if I set it explicitly in PHP [21:20:06] There's a handlebars extension to allow "{{../logo}}" to navigate scope [21:20:25] nbd, I'm just commiserating [21:21:10] (PS2) Awight: [WIP] rtbt methods support getAvailableSubmethods; display logo for only submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [21:21:40] (CR) jenkins-bot: [V: -1] [WIP] rtbt methods support getAvailableSubmethods; display logo for only submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [21:21:44] awight: and yet somehow we do get our buttons wrapping nicely either 3 or 4 per line [21:22:12] im seeing the class there fine [21:22:58] What I'm saying doesn't jive with any of the other templates, does it... [21:23:05] I must have had some other issue [21:24:42] (CR) Ejegg: [C: 2] "Thanks! Had me quite puzzled." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298635 (https://phabricator.wikimedia.org/T139990) (owner: Eileen) [21:25:07] (PS3) Awight: [WIP] rtbt methods support getAvailableSubmethods; display logo for only submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [21:25:37] ejegg: Okay, sorry for the FUD: the behavior seems to be different if you {{# test a boolean or a string variable. fun! [21:29:08] eileen: I might have more custom data config issues locally - having a hard time making any fields appear conditionally [21:29:12] (PS1) Eileen: Set do_no_trade field to 0 for all contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298638 (https://phabricator.wikimedia.org/T135057) [21:30:02] ejegg: hmm - that one did work for me…. [21:30:09] do you have js errors? [21:31:16] (I can put that patch on staging if it helps) [21:31:44] eileen: no js errors, the fields do disappear and reappear but no change [21:32:21] hmm & the gift information set is not included in the ones that appear? [21:32:25] can't get the refund-specific fields to appear when I change an existing contribution's status either :( [21:32:38] oh... [21:32:48] the gift information set is there for every type [21:33:00] lemme play with custom data config some more [21:33:32] ah, think i found the gift info problem! [21:33:41] totally just config [21:34:30] cool, appearing and disappearing as expected now [21:34:36] great [21:35:02] just one more test with my engage username [21:36:02] awight: I just put up a patch to set do_not_trade to 0 for all contacts (about 5000 have a 1 in that field from memory). I feel like I've discussed with you, major gifts & ejegg & dstrine about that field & no-one can think of a reason we might have had data in there - does that make it confirmed? Or do I need to check with Katie too ? https://gerrit.wikimedia.org/r/#/c/298638/ [21:36:15] (CR) jenkins-bot: [V: -1] [WIP] rtbt methods support getAvailableSubmethods; display logo for only submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [21:38:39] (CR) Ejegg: [C: 2] "Worked like a charm once I got my settings right!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298403 (https://phabricator.wikimedia.org/T139990) (owner: Eileen) [21:39:30] eileen: Confirmed, that shouldn't be used anywhere, I'd say go ahead. Thanks! [21:40:02] awight: ok - do you want to approve that gerrit [21:40:28] sure! thanks for the nudge [21:40:46] (CR) Awight: [C: 2] Set do_no_trade field to 0 for all contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298638 (https://phabricator.wikimedia.org/T135057) (owner: Eileen) [21:40:56] (Merged) jenkins-bot: Fix for engage custom data not loading. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298403 (https://phabricator.wikimedia.org/T139990) (owner: Eileen) [21:40:58] (Merged) jenkins-bot: Gift Information field is not view_only on live, don't make it so on dev [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298635 (https://phabricator.wikimedia.org/T139990) (owner: Eileen) [21:42:55] (Merged) jenkins-bot: Set do_no_trade field to 0 for all contacts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298638 (https://phabricator.wikimedia.org/T135057) (owner: Eileen) [21:47:35] (PS1) Awight: [WIP] Display issuers dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298641 [21:49:38] (CR) jenkins-bot: [V: -1] [WIP] Display issuers dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298641 (owner: Awight) [21:50:07] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298642 [21:50:38] (CR) Eileen: [C: 2] "merge from master to deployment - self-approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298642 (owner: Eileen) [21:52:19] !log Updating CiviCRM from 415d7e62bc3bcbd7c5e3682da64ee4847ad63f5b to f7434730ebd87f6d542c34c080c61eb3f21ccc6b [21:52:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:58:38] (PS1) Eileen: Fix typo install number [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298644 (https://phabricator.wikimedia.org/T135057) [21:59:34] awight: Argh I miscommitted (is that a word) that patch you just reviewed … https://gerrit.wikimedia.org/r/#/c/298644/ [22:00:02] I has miscommitment issues [22:00:14] (CR) Awight: [C: 2] Fix typo install number [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298644 (https://phabricator.wikimedia.org/T135057) (owner: Eileen) [22:00:30] away with the trade winds! [22:01:53] :-) [22:03:11] (Merged) jenkins-bot: Fix typo install number [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298644 (https://phabricator.wikimedia.org/T135057) (owner: Eileen) [22:03:53] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298645 [22:04:21] (CR) Eileen: [C: 2] "Deploy to master commit - self approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298645 (owner: Eileen) [22:06:48] !log upgrade Civicrm from f7434730ebd87f6d542c34c080c61eb3f21ccc6b to 0898bb9360fe4a5ddea1a41d4e3f3e9823afee27 [22:06:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:09:11] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: BPay is broken - https://phabricator.wikimedia.org/T140169#2455627 (cwdent) [22:10:16] fr-tech: ^ dunno if this increases or decreases the urgency of the mustache replacement [22:11:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2455646 (Eileenmcnaughton) [22:11:13] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Dedupe: review the rest of the code in our merge hook - https://phabricator.wikimedia.org/T135057#2287003 (Eileenmcnaughton) Open>Resolved I've... [22:12:49] cwd ah crud, looks like my fault again... wonder when $this->context disappeared [22:13:28] Fundraising-Backlog, FR-Adyen: Make Adyen iframe validation error messages more verbose - https://phabricator.wikimedia.org/T140133#2455657 (Danny_B) [22:14:19] ejegg: if a processor falls over in the woods and nobody hears it... [22:14:34] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2455658 (Eileenmcnaughton) The deploy definitely did not improve this so I will dig into why [22:15:35] aw hell, did that ever work? [22:16:56] (PS1) Ejegg: Fix OBT breakage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298649 (https://phabricator.wikimedia.org/T140169) [22:17:52] d'oh: MBeat reported it long ago: T127863 [22:17:54] T127863: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863 [22:18:09] ¯\_(ツ)_/¯ [22:19:08] feb, damn [22:19:59] oof, that's a bunch of AUD missed [22:20:48] if you wanna CR that I'll deploy so we can compare forms [22:20:50] i hope turning it back on doesn't reveal additional breakage [22:20:58] yeah, sounds good [22:21:09] i think the backend stuff has been pretty stable [22:21:37] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2455705 (Eileenmcnaughton) I've set this to done because I fixed the bug I understood... [22:21:51] ejegg: i assume the workflow is you get forwarded to the bank. have we done that with mustache yet? i can only think of iframes [22:22:38] astropay is full redirects after a form submit to our server [22:22:52] ah right on [22:22:59] i will steal the javascripts [22:23:01] and paypal's interstitial form when there's an amount bug, i think [22:23:26] the paypal form you don't actually see? [22:23:37] not bug, i meant amount error [22:24:00] when you do have to stop and correct something, we render that with mustache [22:24:38] (Abandoned) Awight: [WIP] Hack to highlight invalid fields in Mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/281181 (owner: Awight) [22:26:03] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, Unplanned-Sprint-Work: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2455725 (Ejegg) a:Ejegg [22:30:12] ejegg: CI is dragging a little [22:31:19] huh, wonder if that core test ahead of us is stuck [22:32:19] ah, there it goes [22:32:20] (CR) Cdentinger: [C: 2] Fix OBT breakage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298649 (https://phabricator.wikimedia.org/T140169) (owner: Ejegg) [22:34:05] (Merged) jenkins-bot: Fix OBT breakage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298649 (https://phabricator.wikimedia.org/T140169) (owner: Ejegg) [22:35:14] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2455773 (LeanneS) @Eileenmcnaughton Postmark date is another field that they use unde... [22:35:35] (PS1) Eileen: Update triggers to reflect prospect fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298654 (https://phabricator.wikimedia.org/T138908) [22:36:50] I'm never quite sure what to do in Phab when I close something out & then realise there is a follow up minor thing that needs committing (like this) https://gerrit.wikimedia.org/r/#/c/298654/ - should I pull the ticket back to review? [22:38:39] eileen: sure, it'll get people's attention that way [22:42:32] (PS1) Ejegg: Check in composer's 'optimized' autoloaders [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/298656 [22:42:42] ejegg: ok thx [22:43:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2455818 (Eileenmcnaughton) [22:43:41] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create new prospecting fields - https://phabricator.wikimedia.org/T138908#2455816 (Eileenmcnaughton) Resolved>Open Actually just bring this back... [22:44:50] ejegg: want me to deploy DI? [22:46:17] cwd I can do it - just messing around with the optimized autoloader locally [22:46:26] make sure all the libs are happy [22:46:45] oh cool, what are the optimizations like? [22:47:00] just flattens all the PSR stuff into a classmap [22:47:11] afaict [22:47:17] word [22:47:32] yeah, nothing missing so far, I'mma go ahead [22:48:00] (CR) Ejegg: [C: 2 V: 2] Check in composer's 'optimized' autoloaders [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/298656 (owner: Ejegg) [22:48:11] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/298658 [22:48:47] (CR) Ejegg: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/298658 (owner: Ejegg) [22:49:47] hmm, odd that we're trying to run (non-voting) tests on deployment branch [22:50:10] cwd: Quick question: what do you do eventually with long-running weechat-in-tmux-es? Eventually restart them? Do buffers get saved somehow? [22:50:38] It seems Glow Bear gets unperformant after a while, I think closing and opening in a new tab fixes that [22:51:56] AndyRussG: interesting, i don't have any issues like that [22:52:14] you just mean you close the browser tab and not the weechat instance right? [22:52:59] the interface is angularjs which probably eats a lot of computer [22:55:39] (CR) Ejegg: [C: 2] "Whew, twitchy!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298654 (https://phabricator.wikimedia.org/T138908) (owner: Eileen) [22:55:51] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/298658 (owner: Ejegg) [22:56:05] cwd: yeah I mean, I've left the weechat instance in tmux for at least a week now [22:56:14] GlowBear is easy enuf to restart, yeah [22:56:50] My main uncertainty is if I should go in and restart weechat every now and again, and how to keep buffers and make 'em searchable... [22:57:13] AndyRussG: i've left it running for a year without a problem [22:57:27] all your history is in .weechat [22:57:32] since the beginning of time [22:57:47] if i need to search far back i use CLI tools [23:04:09] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): BPay is broken - https://phabricator.wikimedia.org/T140169#2455920 (Ejegg) [23:04:11] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, Unplanned-Sprint-Work: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2455922 (Ejegg) [23:06:46] cwd: ah k cool! thx :) [23:07:25] k, submodule update merged [23:08:31] ejegg: How does Mustache inject RL modules? Mustache::getResources() isn't implemented... [23:11:31] aha. > if( $this->adapter->getPaymentMethod() === 'cc' ) { [23:11:34] $this->getOutput()->addModules( 'ext.donationinterface.ingenico.scripts' ); [23:12:55] !log updated payments from d9f7027340e5311f38c4224c2fddde087467df87 to 8bf6e911eb43a2d369bf656f07d1b51be0a54f6c [23:12:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:13:02] oops, sorry awight . [23:13:31] yeah, wasn't sure if it was good or bad to put that in form settings for mustache [23:14:10] along those lines, i need to either expand that js to support forwarding for bpay or make another file. anyone care? [23:16:07] cwd: I had that same issue. can you add rtbt to the switch case? [23:16:31] cwd ok, obt fix is deployed if you want comparison fodder [23:16:54] ejegg: yep works now [23:16:58] interesting work flow [23:17:05] awight: sure thing! [23:17:57] cwd: you'll want https://gerrit.wikimedia.org/r/#/c/298670/ too [23:18:08] we should merge each other's minor patches... [23:21:06] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2455998 (XenoRyet) @MBeat33 This just went live, AmEx is available agai... [23:21:25] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, Unplanned-Sprint-Work: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2056762 (Ejegg) Open>Resolved [23:22:32] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2454742 (Ejegg) just tried some test Amex numbers in ILS and it worked... [23:26:01] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2456022 (XenoRyet) Worked equally well for me in UAH. [23:28:18] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2456046 (MBeat33) Awesome, many thanks for the fast fix @XenoRyet [23:29:21] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2456047 (XenoRyet) No worries, glad I could help. [23:29:26] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Adyen, Patch-For-Review, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Adyen: add American Express option for Israel, Ukraine - https://phabricator.wikimedia.org/T140146#2456048 (XenoRyet) Open>Resolved [23:41:50] grrrit-wm: where you at bro [23:44:24] So, in a dad first for me: I have to go pick up my kid from school. I'll see you guys later. [23:46:13] XenoRyet|afk: coool! [23:46:51] For the record, I'm cutting enets. We've only taken $6k since Jan 2014 [23:47:01] Got some cute pictures I can inflict on you folks tomorrow. [23:48:29] please do [23:52:43] cwd: Are you editing globalcollect_gateway/forms/js/ingenico.js ? [23:53:12] I can if you're not there already... [23:53:22] awight: not at the moment but it's on the list [23:53:33] i was just reviewing the parent patches [23:53:38] go for it if it suits you [23:54:10] that successCallback should make it nice and easy to case iframe vs. forward [23:54:23] yeah, it looks promising