[00:00:42] cwd: You wanna merge https://gerrit.wikimedia.org/r/#/c/297839/ so I can rebase? [00:01:24] oh nvm, it's already a predecessor [00:01:27] yep i was just testing it...kind of a big change but seems to work and would explode if not [00:01:35] awight: ejegg: hey! I'm trying to find doc on the details of how extension registration migration goes specifically in our prod setup. Did you see any? [00:01:51] AndyRussG: sort of... 1 moment please [00:02:01] ooh, good call [00:02:47] AndyRussG: hmm, I'm just using this old thing: https://www.mediawiki.org/wiki/Manual:Extension_registration [00:03:11] the "callback" param is documented under #Customizing_registration there, fwiw [00:03:34] Are you trying to boost confidence on the namespace number thing? [00:03:51] AndyRussG: you mean the mediawiki-config changes we'd need to deploy it? [00:04:26] There shouldn't be any mediawiki-config changes required cos we have a shim [00:04:53] so it'll just go ahead and switch over to wfLoadExtension? [00:05:30] oh i see, we're doing that when we're require()d [00:05:32] Ah good point, WMF prod stuff probably works around the shim even... [00:06:15] Maybe not. [00:06:46] CommonSettings makes it look like each extension is either required() or wfLoadExtension()'d explicitly [00:06:59] but yeah, the shim covers us in that case. [00:07:15] donationinterface_langonly.php is another story... [00:07:36] awight: ejegg: yeah, I was wondering if there were config changes or other WMF-specific prod details to consider [00:07:49] I guess we can talk to releng when time comes to deploy [00:08:14] Not that I know of, the DonationInterface cutover to extension registration seems to have been mostly harmless [00:08:17] heh, or see if it blows up on beta when we merge [00:08:31] hmm--although we're on a completely different deployment system so never mind me [00:11:39] well, I can't think of anything to worry about besides the wfLoadExtension [00:12:04] getting late here, think I'm going to sign off [00:31:52] awight: hey again, another extension reg question... Is there a specific distinction between what's in the main extension registration patch, and what's in the follow-on "clean up" one? [00:32:10] Should I look at them together? Test together or one at a time? [00:41:55] AndyRussG: Probably test at the head end of the chain [00:42:02] I could squash them if it makes more sense... [00:42:48] ah--but I tried to end each patchset at a "working" state [00:42:56] so feel free to do them one at a time, also [01:06:17] (PS7) Awight: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [01:06:42] cwd: ^ Has some fixes you might want to rebase onto... [01:07:35] awight: awesome, thanks [01:08:22] (CR) jenkins-bot: [V: -1] Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [02:49:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe speed fixes - https://phabricator.wikimedia.org/T135056#2456530 (Eileenmcnaughton) I've opened this to track the upstreaming https://issues.civicrm.org/jira/browse/CRM-19069 [02:55:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807#2456537 (Eileenmcnaughton) [02:55:51] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, and 2 others: Resolve issues around prevnext_cache table - https://phabricator.wikimedia.org/T135050#2456536 (Eileenmcnaughton) Open>Resolved [02:56:54] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298654 (https://phabricator.wikimedia.org/T138908) (owner: Eileen) [11:10:15] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico, Unplanned-Sprint-Work: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2457201 (Pcoombe) Thanks! I've added BPay back to donatewiki for Aust... [14:26:37] Fundraising Tech Backlog: CIVI Gateway Report not showing time field - https://phabricator.wikimedia.org/T140241#2457879 (Ppena) [15:19:16] ejegg|away: hey! all ready for the deploy at 12:00 EST (9:00 PDT) :) [15:19:17] ? [15:31:40] Hi AndyRussG , I think so, let me see if I can get on tin [15:32:58] yep, I'm in [15:33:07] reviewing the checklist [15:34:50] ejegg: cool beans! thx! :) [15:35:17] ejegg: it looks like we have to make a new prod patch because stuff was reverted to wmf.8 [15:35:32] https://www.mediawiki.org/wiki/Special:Version [15:35:42] https://www.mediawiki.org/wiki/MediaWiki_1.28/Roadmap [15:36:08] I have my prod access supposedly but haven't set up that special ssh config stuff [15:36:37] Fundraising-Backlog, FR-Smashpig: Create pending database - https://phabricator.wikimedia.org/T140149#2458129 (Jgreen) Can you provide a ballpark of how large the dataset will be, and some sense of what additional query volume to expect? I think it should be fine sharing a mysql instance with civi etc,... [15:37:04] Looks like today the train will deploy wmf.8 -> wmf.10, so we need patches for both, I think [15:40:48] Just confirmed the above, so as of now everything is on wmf.8 [15:41:11] (checked w/ greg-g on #wikimedia-operations) [15:42:56] ejegg: also, let's deploy first to mw1017. I'm all set up to test there before pushing to the whole cluster... [15:42:57] https://wikitech.wikimedia.org/wiki/Debugging_in_production#Pushing_code_to_mw1017 [15:43:19] btw, I don't update the /Roadmap page, volunteers do, so it's not canonical. My emails and what's on [[wikitech:Deployments]] are canonical :) [15:46:52] greg-g: but then wikitech:Deployments is wrong? [15:47:11] it's right now [15:49:09] greg-g: ? [15:49:11] group0 1.28.0-wmf.9->1.28.0-wmf.10 [15:49:13] group1 1.28.0-wmf.9->1.28.0-wmf.10 [15:49:15] group2 1.28.0-wmf.9 [15:49:25] (for today's train) [15:49:41] I thought it was wmf.8 [15:49:53] whatever [15:49:57] .... ;p [15:50:00] :P [15:50:01] np [15:50:15] Just need to be sure we're pushing the right branch [15:51:39] yup [15:51:41] ejegg: here's the core change, still needs +2 [15:51:42] https://gerrit.wikimedia.org/r/#/c/298783/ [15:51:54] ok, looking [15:52:29] greg-g: wmf.10 will still be cut from wmf.9, I imagine? So for our CN submodule update to not revert, we also have to do a wmf.9 change, correct? [15:52:43] https://wikitech.wikimedia.org/w/index.php?title=Deployments&action=historysubmit&type=revision&diff=745279&oldid=745276 [15:52:54] wmf.10 will be cut from master today [15:53:05] so as long as everything you need is in master [15:53:17] correction, be branched right now [15:53:26] 15:51 <+ostriches> James_F, greg-g: Branch in progress. [15:53:30] UTC ^ [15:54:07] greg-g: K gotcha, thx! [15:55:36] AndyRussG: +2ed but there's a ton of stuff in zuul right now [15:55:44] Hmmm [15:55:46] K [16:06:22] dstrine: btw we're just about to deploy the CentralNotice stuff [16:06:35] AndyRussG: woot!! [16:29:22] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team (Long-Lived-Branches), Spike: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904#2458413 (mmodell) [16:49:57] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: Do not show donation form error message: "No processors available". Fix UI and plug holes. - https://phabricator.wikimedia.org/T117872#2458563 (... [16:53:15] cwd: would you like to attend Scrum of Scrums today? no worries if not [16:56:31] at 11:30? sure i can do that [16:56:35] (MST) [16:57:16] yep, thanks cwd! [16:57:47] np! [17:01:46] MBeat: can you discuss https://phabricator.wikimedia.org/T117872 with cwd and ejegg ? I am able to load the last link in your comment. I'm about to head into a meeting. Is this a true unbreak now? I'll check back in a few minutes. [17:02:44] yikes [17:09:14] dstrine: CN update is all deploy'd, many thx to ejegg's proddeploying handiwork [17:09:34] AndyRussG: and ejegg WOOT!!! THANKS!!!! [17:09:56] yeah fun times! [17:10:43] new process is a bit more streamlined and faster, ops has done some cool stuff [17:11:23] yeahfersures [17:11:48] ooh, more AstroPay API request timeouts... [17:12:11] ejegg: logjam that silliness! [17:12:12] awight: what do you think of this: https://gerrit.wikimedia.org/r/298549 [17:12:19] ejegg: dstrine: should I send a heads-up to fr-online about the deploy? [17:12:22] ejegg: are they timeouts? i am seeing nothing relevant in the logs [17:12:32] ejegg: I think it's safeish, if that's whatchu mean [17:12:42] oh wait [17:12:50] sorry, I thought that was my patch, one moment please [17:13:14] just some gold-leaf on your calla lily [17:13:42] AndyRussG: if the deploy is already out and stable then it's not that necessary. It might have been nice to give a heads up earlier if it was going to interrupt anyone. [17:14:09] (CR) Awight: [C: 2] "Thanks!" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298546 (https://phabricator.wikimedia.org/T139698) (owner: Ejegg) [17:14:26] (PS3) Awight: Doc & default for CurlVerboseLog [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298546 (https://phabricator.wikimedia.org/T139698) (owner: Ejegg) [17:14:31] dstrine: well, it appears to be working, but it isn't "stable" until we see there was no unusual jump in impression or donation numbers at the same time as the deploy [17:14:40] (PS2) Awight: Verbose cURL output for all retried requests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298549 (https://phabricator.wikimedia.org/T139698) (owner: Ejegg) [17:15:22] That's because this whole system (from servers to networks to devices) is so complex and heterogeneous that the only way to know that there weren't some subtle unexpected side effects is to watch the real numbers [17:15:31] ejegg: Missing the 1st request seems pretty bad [17:15:36] What do we accomplish with this? [17:16:01] dstrine: so I would be happy for them to check in a day or so that there weren't any unexplicable disturbances in the force starting at the time of this deploy [17:16:57] AFIK it's all working but I'm not on an ipad in Spain or on a desktop in... (etc.) [17:16:59] awight: you think we should always capture the curl verbose output, and log if failed or your global is true? [17:17:20] I didn't know how much overhead the verbose output and the memory stream would be [17:17:41] But I thought it would be nice to catch the retry even without the global on [17:18:02] ejegg: did you see this? https://phabricator.wikimedia.org/T117872 i have no idea what's going on but can reproduce the error. the logs show nothing [17:18:21] also in this particular case (cookies gone to localstorage, ResourceLoader module changes, different way of turning off on special pages) any ill effects are most likely to be subtle rather than catastrophic [17:18:38] ejegg: what do we get with the retry, though? It might make sense to log that we're retrying, but the contents of the curl log won't be very exciting [17:18:51] unless of course it fails the 2nd time as well--is that where you were going? [17:19:00] awight: exactly [17:19:08] also-- I do like your suggestion to always record and then log if trouble. [17:19:27] I don't think we need to worry about overhead any time soon--those machines are at like .01 load [17:19:51] word, I'll rework that patch [17:20:35] cwd just trying to reproduce the AstroPay error? [17:21:05] ejegg: i can reproduce it. sure looks like astropay is straight up broken [17:21:12] ah crap, astropay-ar form isn't asking for name and email? [17:21:27] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 5 others: CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData a... - https://phabricator.wikimedia.org/T134310#2261489 [17:21:37] could that be it? nothing in the logs whatsoever [17:21:45] well nothing useful at all [17:21:50] no errors [17:21:52] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2458722 (AndyRussG) [17:21:55] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 5 others: CentralNotice: Use LocalStorage instead of cookies whenever possible, for buckets,... - https://phabricator.wikimedia.org/T132639#2205213 [17:22:10] is this probably from a mustache thing? [17:22:17] oh wait, first link in that last comment has no payment_method [17:22:26] we should deal with that condition better... [17:23:16] i get one that asks for Datos de facturación [17:23:28] thought it was like that "financial number" or whatever [17:23:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269#2458727 (Ejegg) [17:24:05] but when i put CC in there it looks normal [17:25:15] hmm, i'mma test on MX where I don't need a real DNI [17:25:21] cwd: you can set uselang=en even in MX... [17:25:59] oh fun [17:26:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269#2458760 (Ejegg) [17:27:02] ejegg: what's the up to date SoS link again? [17:27:07] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, MediaWiki-extensions-CentralNotice, Patch-For-Review, Unplanned-Sprint-Work: CentralNotice: Stop adding old, empty bannerController modules to HTML - https://phabricator.wikimedia.org/T138875#2458761 (AndyRussG) Open>... [17:27:19] etherpad: http://etherpad.wikimedia.org/p/Scrum-of-Scrums [17:27:38] awight: are people allowed to use manual dedupe at this point? [17:28:05] meeting: https://plus.google.com/hangouts/_/wikimedia.org/scrum-of-scrums?authuser=0&hceid=d2lraW1lZGlhLm9yZ18xZ2hra2Y1YmpsNHJlazlrdXNpcGZzdm4yMEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t.2hspaf4bhcmpvtb0aq71c8ppvs [17:28:10] dstrine: Let's continue to say no [17:28:20] I didn't see any all-clear email from eileen, at least. [17:28:20] thanks! i'll save those this time [17:28:30] awight: ok thanks [17:28:58] thanks again cwd [17:29:14] no prob [17:30:56] ejegg: hey btw I think I succeeded in rewriting rtbt [17:31:04] patch is in gerrit... [17:31:11] nice! will take a look [17:31:17] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup payments1005-8 - https://phabricator.wikimedia.org/T136881#2458807 (Cmjohnson) Spoke with Jeff G and he prefers using the same names for payments. We shutdown the old payments1003 and connected to the new payments1003. Changed the idrac to... [17:31:33] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup payments1005-8 - https://phabricator.wikimedia.org/T136881#2458808 (Cmjohnson) racktables updated with new payments1003 information. [17:35:21] !log turned on cURL verbose logging for AstroPay requests on payments [17:35:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:52:03] ejegg: woot! [17:55:15] (PS4) Ejegg: Doc & default for CurlVerboseLog [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298546 (https://phabricator.wikimedia.org/T139698) [17:57:10] (CR) Awight: [C: 2] Doc & default for CurlVerboseLog [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298546 (https://phabricator.wikimedia.org/T139698) (owner: Ejegg) [17:59:17] (Merged) jenkins-bot: Doc & default for CurlVerboseLog [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298546 (https://phabricator.wikimedia.org/T139698) (owner: Ejegg) [17:59:26] I really like it. https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-DonationInterface/inspections/38592276-1705-4130-a0e9-bda3036216a0 [18:02:44] ejegg: Anything more I can do to help with Mustachization? [18:03:41] can't think of anything right now besides review [18:04:21] (PS10) Awight: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [18:05:02] XenoRyet: ^ Did you have a chance to smoke test much of that? [18:05:21] I'll do some now, just wanted to avoid a ton of duplicate work [18:05:57] awight: I was mostly going over the code, was just getting set up to do smoke testing. [18:06:06] ah cool [18:07:58] Another pair of eyes never hurts though, if you still want to do a bit yourself. [18:18:49] awight: wow, that scrutinizer thing is really cool! [18:19:07] now, to make it part of our process... [18:21:42] Fundraising-Backlog, FR-ActiveMQ: Write Debian packaging for arnaud-lb/php-rdkafka - https://phabricator.wikimedia.org/T132957#2459101 (awight) Open>Invalid [18:30:31] Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Epic: Provision Redis cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2459156 (awight) [18:31:19] Jeff_Green: pls let me know if ^ that card is missing anything important that u need... [18:32:19] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Epic: Provision Redis cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2131633 (awight) [18:34:14] awight: looking [18:34:23] hehe. https://gerrit-new.wikimedia.org/ [18:35:56] awight: i'm a little confused what we're building [18:36:07] gerrit 503 [18:36:17] how do redis and kafka relate in that ticket? [18:36:18] Jeff_Green: This is a replacement for ActiveMQ [18:36:32] We decided to use Redis rather than Kafka [18:37:31] oh. part of my confusion was the way email mangled the ticket. reading via web instead [18:38:12] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, fundraising-tech-ops, FR-ActiveMQ, Epic: Provision Redis cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2459190 (awight) To clarify the changes to the task title and description, we've decided to use Redis rather tha... [18:38:29] cool; I just added a comment for further disambiguation [18:38:56] ejegg|meet: XenoRyet: fwiw, smoke testing the Mustache CC forms works perfectly on my local [18:40:22] awight: I'm getting the 'no processors available' thing, but I'm sure that's just something with my setup. [18:40:39] XenoRyet: with the full VPN tunnel [18:40:40] ? [18:40:43] awight ok. i think there's enough info for now. I'm sort of stuck for working on it by the fact that that we don't have enough ports to connect the new queue servers (hopefully that block will be resolved in the near future) plus the volume of other stuff [18:40:50] also. my god, https://gerrit-new.wikimedia.org/r/#/c/297845 [18:41:05] Yea. At least I think I'm full tunnel. Let me check that. [18:41:35] utterly macabre [18:41:43] Jeff_Green: no problem--you think it might be unblocked this month, though? [18:42:05] awight: we can hope, but I don't know [18:42:16] we're short handed for network ops [18:42:20] yipes [18:42:27] can we get the payments servers working besides the new queues? [18:42:32] although we have at least reached a decision on the path forward, so that's an improvement [18:42:46] cwd: what do you mean? [18:43:03] Jeff_Green: here's a crazy-ass thought. Our first step will be to mirror outgoing queue messages. What do you think about mirroring those to a Redis server on the staging box? [18:43:04] payments servers are a 1:1 swap, so they're do able [18:43:13] that would be a pretty cozy way to test the data, at least. [18:43:23] Jeff_Green: cool yeah, that's all i was wondering [18:44:00] awight that's payments servers potentially talking to staging server? [18:44:24] mm yeah. okay let me retract that thought [18:44:30] awight: actually, yeah no that won't fly also because staging is still precise and that's a snakepit of backporting too [18:44:41] hehe, k [18:46:24] GC is asking for more XML. i don't see this DO_PAYMENT anywhere in the logs. [18:46:28] Too bad we work with intangible things. There's this trick for getting rid of illegally dumped refrigerators and stuff. It might only work on the East Coast, though. You just put a 6-pack inside of the fridge on garbage day, and it magically disappears. [18:46:42] cwd: that sounds like a recurring globalcollect thing. [18:46:51] Check the fundraising-drupal logs? [18:47:03] hmm, not sure we even get that logging. [18:47:15] yeah checked all the logs in remote [18:48:27] awight: ha. this reminds me of the microwave that mysteriously showed up on my lawn, at the edge of the road, with a sign that read "free microwave, one man's garbage is another man's treasure". i wrote on the sign "please don't put your garbage on my lawn" and several hours later it was gone. so strange [18:48:57] that's the epistolary version [18:50:01] :-) [18:50:26] cwd: I can't find anything, either. [18:50:30] socks. [18:51:02] WmfFramework.drupal#debugLog seems to be the culprit, fwiw [18:51:27] hehe someone just requested my CTCP version [18:52:37] the mind boggles at the idea of sending them previously sent XML over email as the only option [18:52:49] Jeff_Green: Here's another terrible thing to ask. What about withholding a payments box in favor of the queue server... [18:53:36] awight we'll figure it out. it's just one of those puzzles where you shuffle the squares around, and the entire puzzle needs to turn over this FY [18:54:18] it took several months to arrive at a decision about how to move forward, that imo was the harder part [18:55:06] There's one of those puzzles at my local park... it's insanely extra frustrating cos of gravity. [18:55:39] that would drive me insane. at the end of the day I have no mental energy left for puzzles of any kind [18:55:55] hehe [18:56:05] Yeah, parenting is puzzle enuf [18:56:58] word [19:06:01] (CR) Awight: [C: 1] "Code is great, and the feature still works for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:07:54] Awight: I'm still not getting this thing to work locally, but the code looks good to me too, and if you say it's not emitting smoke, I believe you. I'm happy to have it merge. [19:08:16] XenoRyet: I was just gonna ask. want to try to debug the local? [19:08:25] Sure [19:08:27] Happy to move on if you want to skip that, though [19:08:28] k [19:08:40] u haz interesting logs? [19:08:55] We can go ahead and merge without fixing me up, but I would like to have this working locally anyway. [19:09:05] sounds good [19:09:29] (CR) Awight: [C: 2] "Move on up!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:09:40] (PS3) Awight: DRY workaround [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298670 [19:09:47] (PS8) Awight: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [19:10:14] So which logs you think might have interesting stuff here? I've just been debugging and stepping through the code trying to figure out where it goes off the rails. [19:10:47] XenoRyet: ? $wgDonationInterfaceUseSyslog = true; [19:11:49] Looks like not. I'll add that in. Also, I'm on vagrant, for context. [19:11:52] If you have IP issues, the logged response will say something like "ACTION 130 IS NOT ALLOWED" [19:11:55] aha k [19:12:03] dang, we need to have that in vagrant. adding now [19:12:35] (PS2) Cdentinger: WIP: form displays, does not function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298572 [19:12:51] XenoRyet: looks like that's enabled by default in vagrant [19:12:53] (Merged) jenkins-bot: Mustache forms for Ingenico credit cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/297845 (https://phabricator.wikimedia.org/T123002) (owner: Ejegg) [19:13:10] Oh, probably looking in the wrong spot. [19:13:19] Was over in vagrant's localsettings? [19:13:29] I think the output will be in /var/log/syslog [19:13:57] XenoRyet: it's messy. the config lands in settings.d/wikis/paymentswiki/settings.d/puppet-managed/10-DonationInterface.php [19:14:04] wheeee! [19:14:16] Ah, that one. Ran into that setting up Adyen. [19:14:45] BTW when you write your merchant creds however, they should go into a different file so the code generation doesn't blow your changes away. [19:14:52] see the Main_Page on the installed wiki... [19:15:05] I use something like, settings.d/01-DI-real.php [19:15:23] Yea, got that all set up last time around. [19:16:43] This is inside the vagrant VM, right? I'm not seeing syslog in /var/log [19:16:49] wait, blind. There it is [19:17:25] hmm... empty though. [19:18:02] you should see lines like Jun 16 18:52:25 mediawiki-vagrant globalcollect_gateway: 3:2189973377 session_addDonorData: Refreshing all donor data [19:18:21] empty?? [19:18:37] Yep, not a thing in there. [19:18:58] garble. [19:19:14] sudo'd? [19:19:34] permissions are -rw-r----- 1 syslog adm 1730996 Jul 13 19:17 /var/log/syslog [19:19:43] That's got it. [19:19:51] nice [19:20:13] the globalcollect_gateway lines should lead to forgotten treasure... [19:20:35] woohoo, thanks for the CR and testing guys! [19:20:39] Reading them now. [19:20:56] Will reciprocate on the rtbt after I grab some grub [19:21:40] cwd: any luck on the obt front? [19:22:03] awight: just rebasing on your rtbt stuff [19:22:32] sweet. I'll prepare the funeral pyre [19:23:29] awight: if i push this rebase to gerrit will it know what to do? [19:25:37] (PS3) Cdentinger: WIP: form displays, does not function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298572 [19:25:48] yeah doesn't seem to break anything [19:25:50] wicked [19:26:11] rad [19:26:19] just when i'm starting to get along with gerrit it's going to change [19:26:27] hopefully the guts stay the same [19:28:07] Awight: Ok, first try was bad merchantID, but fixed that and now I am getting ACTION 130 IS NOT ALLOWED... [19:28:37] XenoRyet: That sounds like IP now [19:29:00] Yea, I am on the VPN, but must be something going wonky there. [19:29:37] sorry to keep saying this, but split or full? [19:29:55] u should be able to go to a browser "what is my ip" and see the office ip [19:30:19] The log has my local public IP in it, so I'm sure that's the problem. [19:31:25] https://office.wikimedia.org/wiki/VPN_Setup#Full_Tunnel [19:31:41] The only difference is the '-RA' group suffix [19:32:17] super annoying though, I just filed https://phabricator.wikimedia.org/T140281 to get us off the full tunnel one day [19:33:30] Yea, now it's working fine. [19:33:42] Could've sworn I was on full tunnel before, but guess not. [19:33:47] Woot woot! [19:33:48] Thanks! [19:33:51] np [19:34:15] I should probably mention this stuff in the Main_PAge readme [19:34:24] Couldn't hurt [19:34:59] Alright, time to grab some food, then find something else to CR. [19:37:37] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2459363 (LeanneS) Engage confirmed that both the batch number and postmark date field... [19:56:35] (Merged) jenkins-bot: Localize card label alt/title attributes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/287041 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [19:57:01] (PS2) Awight: Stop trying to access undefined field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298401 (owner: Ejegg) [19:57:40] (CR) Awight: [C: 2] "Sorry about this... I donno if there's a nicer way to declare dependencies. Explicit has its advantages, at least." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298401 (owner: Ejegg) [19:58:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Issue Searching Contacts - https://phabricator.wikimedia.org/T140293#2459444 (LeanneS) [19:58:44] (Merged) jenkins-bot: Clean up has_x flags in Mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298632 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [20:00:12] (CR) Awight: [C: 2] "Rad! Success, here we come" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298136 (owner: Ejegg) [20:00:17] (PS2) Awight: Add installer info to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298136 (owner: Ejegg) [20:01:03] (PS2) Awight: donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [20:01:22] https://sadbastard.org/bpay.png too subtle? [20:01:58] (PS4) Awight: Remove ext-iconv and add ruflin/elastica [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297458 (owner: Paladox) [20:02:07] (CR) Awight: [C: 2] Remove ext-iconv and add ruflin/elastica [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297458 (owner: Paladox) [20:02:21] (CR) Awight: [C: 2] donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [20:03:01] cwd: pay or bpayd [20:03:39] (CR) jenkins-bot: [V: -1] Add installer info to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298136 (owner: Ejegg) [20:04:01] (PS2) Awight: Fix 'Other ways to give' link in error pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293537 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg) [20:04:35] (CR) jenkins-bot: [V: -1] donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [20:05:40] awight: meeting? [20:05:40] (CR) Awight: [C: 2] Fix 'Other ways to give' link in error pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293537 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg) [20:05:58] (PS2) Awight: FIXMEs re: fail forms & their titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293548 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg) [20:06:04] (CR) Awight: [C: 2] FIXMEs re: fail forms & their titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293548 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg) [20:06:10] dstrine: gah! coming [20:06:21] (Merged) jenkins-bot: Stop trying to access undefined field [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298401 (owner: Ejegg) [20:10:33] (Merged) jenkins-bot: Remove ext-iconv and add ruflin/elastica [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/297458 (owner: Paladox) [20:10:36] (CR) jenkins-bot: [V: -1] donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [20:10:38] (Merged) jenkins-bot: Fix 'Other ways to give' link in error pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293537 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg) [20:10:40] (Merged) jenkins-bot: FIXMEs re: fail forms & their titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293548 (https://phabricator.wikimedia.org/T131995) (owner: Ejegg) [20:24:45] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Batch Number Disappeared for Engage - https://phabricator.wikimedia.org/T139990#2459560 (Eileenmcnaughton) Open>Resolved Great [20:34:37] Fundraising-Backlog, FR-Smashpig: Create pending database - https://phabricator.wikimedia.org/T140149#2459622 (Ejegg) This will replace the 'pending' queue currently on silicon, so about the same number of rows as that has messages. Rows will be couple of indexed fields and the rest in a json blobs. [20:36:36] (CR) Ejegg: Mustache for rtbt_ideal (10 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [20:49:52] fundraising-tech-ops: replace payments1002-1004 with new hardware running debian/jessie - https://phabricator.wikimedia.org/T137299#2459714 (Jgreen) payments1002 & payments1003 are done [21:12:59] awight: what if, if there is only one card/bank logo, it goes under the continue button? [21:13:32] a la https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&recurring=&payment_method=obt&utm_medium=Waystogive&utm_campaign=C11_Waystogive&utm_key=&language=en&country=AU&returnto=Thank_You%2Fen&amountGiven=¤cy_code=AUD&frequency=onetime&amount=3&uselang=en [21:20:12] (CR) Ejegg: "am I missing something?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298549 (https://phabricator.wikimedia.org/T139698) (owner: Ejegg) [21:21:35] cwd: ooh. I put it above the continue button [21:21:58] cwd: actually, with the rtbt patch it happens automatically [21:24:07] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: Do not show donation form error message: "No processors available". Fix UI and plug holes. - https://phabricator.wikimedia.org/T117872#2459821 (... [21:25:24] awight: yep it works, it's just above the button and looks a little funny [21:25:30] but i am no UI expert [21:25:38] i think i also need to scale this image down a bunch [21:25:49] unless we want to add a size to the template [21:29:12] good call. [21:29:14] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Can we make the Custom Field - Benefactor Page Listing default to Not Replied - https://phabricator.wikimedia.org/T140308#2459825 (RLewis) [21:32:50] (PS5) Awight: Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [21:34:34] (CR) Awight: [C: 2] Fix some PHPDoc and dynamically declared fields (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [21:34:48] (PS2) Awight: EncodingMangler implements StagingHelper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293466 (https://phabricator.wikimedia.org/T137164) (owner: Ejegg) [21:36:06] (CR) Awight: [C: 2] EncodingMangler implements StagingHelper (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293466 (https://phabricator.wikimedia.org/T137164) (owner: Ejegg) [21:36:41] (CR) Awight: "@ejegg should this be abandoned?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 (https://phabricator.wikimedia.org/T137164) (owner: Ejegg) [21:37:15] (PS2) Awight: Quit looking for duplicate queue messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293138 (owner: Ejegg) [21:37:36] (CR) Awight: [C: 2] "good idea!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293138 (owner: Ejegg) [21:38:35] (CR) Ejegg: "Thanks for rummaging through my hoard! I still like this better than the hokey getTransactionSpecificValue override it's using now. Not t" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 (https://phabricator.wikimedia.org/T137164) (owner: Ejegg) [21:39:03] (CR) Ejegg: "I'll rebase this for extension registration" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 (https://phabricator.wikimedia.org/T137164) (owner: Ejegg) [21:39:32] (Merged) jenkins-bot: Fix some PHPDoc and dynamically declared fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/286993 (owner: Ejegg) [21:39:35] (Merged) jenkins-bot: EncodingMangler implements StagingHelper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293466 (https://phabricator.wikimedia.org/T137164) (owner: Ejegg) [21:39:39] (Merged) jenkins-bot: Quit looking for duplicate queue messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/293138 (owner: Ejegg) [21:39:58] (PS2) Awight: Make isValidForm self-contained [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292398 (https://phabricator.wikimedia.org/T136254) (owner: Ejegg) [21:42:15] (CR) Awight: [C: 2] "Great! Confirmed working." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292398 (https://phabricator.wikimedia.org/T136254) (owner: Ejegg) [21:44:03] (Merged) jenkins-bot: Make isValidForm self-contained [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292398 (https://phabricator.wikimedia.org/T136254) (owner: Ejegg) [21:45:13] Fundraising-Backlog, FR-Smashpig: Create pending database - https://phabricator.wikimedia.org/T140149#2459887 (Jgreen) a:Jgreen>Ejegg this is done. please close the ticket when you've confirmed that it's all set up as desired. [21:46:33] fundraising-tech-ops: frack jessie integration cleanup - https://phabricator.wikimedia.org/T138222#2459890 (Jgreen) p:Triage>Normal [21:47:20] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2459891 (Jgreen) p:High>Normal [21:48:38] fundraising-tech-ops: build payments1005 with Debian Jessie, and HHVM or PHP5.5 - https://phabricator.wikimedia.org/T136938#2459894 (Jgreen) [21:48:40] fundraising-tech-ops: replace payments1002-1004 with new hardware running debian/jessie - https://phabricator.wikimedia.org/T137299#2459896 (Jgreen) [21:49:48] (CR) Awight: [C: -2] "I'm CR-2'ing until we figure out whether the bug is valid or not." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289117 (https://phabricator.wikimedia.org/T135254) (owner: Ejegg) [21:56:48] thanks dstrine [21:56:56] for the GC email [21:57:52] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops, HHVM, Performance: Run Payments wiki on HHVM - https://phabricator.wikimedia.org/T91899#2459913 (awight) Open>declined I'm deleting this task and making a high-level epic to fix payments performance in general. [21:59:19] (PS9) Cdentinger: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [21:59:21] (PS4) Cdentinger: DRY workaround [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298670 (owner: Awight) [21:59:23] (PS4) Cdentinger: WIP: form displays, does not function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298572 [21:59:25] (PS1) Cdentinger: Add bpay logo and css class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298889 [21:59:50] awight: there was a hairy rebase there, hopefully i caught everything [22:00:24] sorry 'bout that [22:00:28] setting you up and all [22:02:27] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Performance: [Epic] Payments performance tuning - https://phabricator.wikimedia.org/T140311#2459918 (awight) [22:03:20] (CR) jenkins-bot: [V: -1] Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [22:03:51] (CR) jenkins-bot: [V: -1] WIP: form displays, does not function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298572 (owner: Cdentinger) [22:04:03] hmm, I should check that test failure on my patch [22:04:09] (CR) jenkins-bot: [V: -1] Add bpay logo and css class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298889 (owner: Cdentinger) [22:06:24] awight: i just paved over a bunch of ejegg comments too, sorry about that [22:06:27] see PS8 [22:07:17] (PS4) Ejegg: AstroPay signature as staging helper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 (https://phabricator.wikimedia.org/T137164) [22:07:34] ok thx for the note [22:08:03] * awight adjusts all my whitespace to "Stupid" [22:08:28] (CR) Ejegg: "PS4: Rebased around extension registration" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/293465 (https://phabricator.wikimedia.org/T137164) (owner: Ejegg) [22:08:36] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: Do not show donation form error message: "No processors available". Fix UI and plug holes. - https://phabricator.wikimedia.org/T117872#2459965 (... [22:09:04] (PS10) Awight: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [22:11:02] (CR) jenkins-bot: [V: -1] Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [22:12:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Redirect loop when processor is disabled. - https://phabricator.wikimedia.org/T140314#2459971 (Ejegg) [22:12:28] (CR) Awight: "Needs a manual rebase." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291154 (owner: Ejegg) [22:12:39] (CR) Awight: [C: 2] Trim fields before sending to server [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291154 (owner: Ejegg) [22:12:59] (CR) jenkins-bot: [V: -1] Trim fields before sending to server [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291154 (owner: Ejegg) [22:14:11] (PS2) Awight: Rearrange processing wrapper for dequeue loop [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287872 (owner: Ejegg) [22:16:57] Fundraising Tech Backlog, Operations: Add granularity limiter (g=) to wikimedia.org DKIM record(s) - https://phabricator.wikimedia.org/T140316#2460001 (CCogdill_WMF) [22:17:28] Fundraising Tech Backlog, Operations: Add granularity limiter (g=) to wikimedia.org DKIM record(s) - https://phabricator.wikimedia.org/T140316#2460017 (CCogdill_WMF) [22:18:42] (PS2) Ejegg: Trim fields before sending to server [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291154 [22:19:00] (CR) Ejegg: "PS2: rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291154 (owner: Ejegg) [22:19:20] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2460021 (CCogdill_WMF) To follow up on my last comment, I created T140316 which addresses the granularity limiter for wik... [22:19:59] (PS3) Ejegg: Trim fields before sending to server [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/291154 [22:24:29] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Can we make the Custom Field - Benefactor Page Listing default to Not Replied - https://phabricator.wikimedia.org/T140308#2460031 (Eileenmcnaughton) So this is something you can configure yourself - under civicrm/admin/custom/group/field?reset=1&ac... [22:33:32] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Security-General: Spike: Is the Verisign seal even PCI compliant? - https://phabricator.wikimedia.org/T140318#2460052 (awight) [22:34:20] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Security-General: Spike: Is the Verisign seal even PCI compliant? - https://phabricator.wikimedia.org/T140318#2460067 (awight) [22:42:19] (PS11) Awight: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [22:43:03] ejegg: cwd: n.b. the last few patches were just easy stuff that I overlooked, lint and tests. Just starting to read the PS8 comments now... [22:43:37] ah, cool! [22:43:56] a couple were obsoleted by the rebase [22:45:52] (PS12) Awight: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [22:45:54] (PS1) Awight: Remove WorldPay ResourceLoader modules [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298893 [22:47:54] awight: v+2, sweet [22:49:14] (Abandoned) Awight: Remove WorldPay ResourceLoader modules [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298893 (owner: Awight) [22:49:19] (PS1) Eileen: Change gateway report filters to date time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298894 (https://phabricator.wikimedia.org/T140241) [22:49:19] I... removed tests ;) [22:51:06] hehe nice [22:51:17] Fundraising Tech Backlog, Patch-For-Review: CIVI Gateway Report not showing time field - https://phabricator.wikimedia.org/T140241#2457879 (Eileenmcnaughton) I've added a patch for this report - as a custom report it stands alone. However there may also be some other reports you are missing time on? Let... [22:52:28] Are people OK with me pulling this one it? I did a really trivial patch for it - https://phabricator.wikimedia.org/T140241 - but I'm also aware people don't necessarily want to have more QA tasks piled onto them..... [22:52:53] works for me, thanks! [22:53:22] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: Do not show donation form error message: "No processors available". Fix UI and plug holes. - https://phabricator.wikimedia.org/T117872#1785597 (... [22:53:58] awight: was that a reply to me or Casey? [22:54:43] eileen: that seems like a worthy task, especially useful for Adyen right now [22:55:00] their payment console rolls up days in CET, not UTC [22:55:48] eileen: am i imagining things, or did we used to get an input for the refund reason when we set a contribution status to refunded? [22:55:58] ejegg: ok - it's a small patch too - [22:56:18] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Patch-For-Review: CIVI Gateway Report not showing time field - https://phabricator.wikimedia.org/T140241#2460151 (Eileenmcnaughton) a:Eileenmcnaughton [22:57:25] ejegg: locally I'm still getting a chance to enter Cancellation / Refund Reason [22:57:50] weird, i'm not on prod [22:58:39] or locally [23:00:09] ejegg: cool, nice to get acquainted with this client side validation thing. [23:00:42] ejegg: What would you say if I DRY by appending the server validation vars to that stuff, in the base implementation? [23:01:01] awight: yes, exactly what I was thinking! [23:01:07] cool, will do. [23:02:26] ejegg: I just got it to show ib orod [23:02:39] erm touch typing - misplaced hands.... [23:02:52] ib = on [23:04:03] awight: i have to run some errands but will be back on later and hopefully finish up the GC stuff -- seems like we are pretty close [23:05:12] see ya! [23:05:16] I've got to run too. I'll check email later tonight. [23:05:43] we need to see if verizon is a possibility at this property. if we are going to try to pull the plug we have to do it asap [23:09:08] damn. [23:09:18] eileen: odd, wonder what I'm doing wrong. I just refunded those 4 JPY Adyen donations by clicking 'edit' from the contribution search results and making changes in the modal [23:09:28] cwd|afk: or ask for $100k off the sale price [23:09:56] (PS13) Awight: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [23:09:58] (PS1) Awight: Reuse server-side validations in getClientSideValidations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298898 [23:11:04] ejegg: hmm - we can hangout if you want & compare screen shares…. [23:11:43] eileen: i'll take another look tomorrow and see if it's something obvious [23:11:46] thanks! [23:13:00] ok cool [23:15:11] (CR) Awight: Mustache for rtbt_ideal (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) (owner: Awight) [23:17:54] Fundraising-Backlog, FR-Smashpig: Create pending database - https://phabricator.wikimedia.org/T140149#2460196 (Ejegg) Thanks, db looks good! I updated a copy of /etc/fundraising/SmashPig.yaml in my homedir on the deploy host with the credentials. Would you mind puppetizing that when you have time? [23:18:26] ejegg: I think SP config is already puppetized in localsettings.git [23:19:40] (CR) Ejegg: [C: 2] Change gateway report filters to date time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298894 (https://phabricator.wikimedia.org/T140241) (owner: Eileen) [23:21:10] awight: all I see there is the old .php file [23:21:40] hrm [23:21:59] (Merged) jenkins-bot: Change gateway report filters to date time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298894 (https://phabricator.wikimedia.org/T140241) (owner: Eileen) [23:22:20] ejegg: wow, thanks for catching that! [23:22:53] catching what now? [23:23:04] noticing the lack of puppet [23:23:26] hehe yeah there's been plenty of stuff hitting the fan to choose from [23:23:53] ah, I mean I think it's already in puppet-private, just we can't touch that one still [23:24:15] k, I gotta run, but I'll poke at that client-side val and rtbt some more later [23:24:22] k bye! [23:26:42] (CR) Eileen: "thanks ejegg" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/298894 (https://phabricator.wikimedia.org/T140241) (owner: Eileen) [23:28:05] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298900 [23:28:58] (CR) Eileen: [C: 2] "Merge to deploy -self approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/298900 (owner: Eileen) [23:31:11] !log update CiviCRM from 0898bb9360fe4a5ddea1a41d4e3f3e9823afee27 to cea316cc57c511c645a92a003028c95e19cac877 [23:31:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:31:58] (PS14) Awight: Mustache for rtbt_ideal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298633 (https://phabricator.wikimedia.org/T123002) [23:32:15] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Patch-For-Review: CIVI Gateway Report not showing time field - https://phabricator.wikimedia.org/T140241#2457879 (Eileenmcnaughton) @Ppena thanks to some super-speedy review by @Ejegg I have just deployed this. Let me know if you see the f... [23:32:34] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Patch-For-Review, Unplanned-Sprint-Work: CIVI Gateway Report not showing time field - https://phabricator.wikimedia.org/T140241#2460235 (Eileenmcnaughton) [23:33:42] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Patch-For-Review, Unplanned-Sprint-Work: CIVI Gateway Report not showing time field - https://phabricator.wikimedia.org/T140241#2460241 (Ppena) @Eileenmcnaughton and @Ejegg Awwww- super duper speedy! I see it. Thanks SO MUCH! [23:39:15] (PS1) Awight: Remove WorldPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298903 [23:43:30] LOL: -12,000 lines ^ [23:54:21] Fundraising Sprint Muggle Baiting, Fundraising Tech Backlog, Patch-For-Review, Unplanned-Sprint-Work: CIVI Gateway Report not showing time field - https://phabricator.wikimedia.org/T140241#2460290 (Eileenmcnaughton) Open>Resolved