[15:00:17] (CR) Ejegg: "nice safeguard! seems odd not to log amount though" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [16:43:01] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Log IP addresses when outgoing requests fail - https://phabricator.wikimedia.org/T139698#2471441 (Ejegg) [16:46:52] Fundraising Dash, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dash login failing - https://phabricator.wikimedia.org/T140656#2471478 (Ejegg) [16:56:42] (CR) Awight: Force bad encodings to approximate UTF-8 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [16:59:02] awight: hiya! you know how when you set up vagrant all the remotes are https? is there a systemic solution to this or do you just change them? [16:59:15] ooh [16:59:19] I think that's generally OK [16:59:37] "git review" implies "git review -s", which is what creates the gerrit remote [17:00:10] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah - https://phabricator.wikimedia.org/T138100#2471582 (Jgreen) >>! In T138100#2463756, @spatton wrote: > Hey @CCogdill_WMF and @Jgreen, I spoke to Hannah last night and she confirmed that the Yubikey has arrived! Jeff, c... [17:00:35] hmm, git review -s is not doing that for me [17:00:44] funky [17:00:47] What does it do? [17:02:03] (PS4) Awight: Force bad encodings to approximate UTF-8 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) [17:02:22] hi awight cwd was there going to be a video call about the queuing this morning? I don't actually have much more in the way of questions or ideas about it yet, but if there is a call pls do count me in :) [17:02:45] sure, seems like a good idea! [17:03:46] sure i'll hop on in a couple minutes [17:04:58] K cool going there too! [17:09:45] ejegg: boo! [17:09:46] ejegg: we're doing a tech chat fryi [17:09:48] hehe [17:09:51] fyi [17:10:02] fyfry [17:13:15] hi AndyRussG ! [17:13:20] oh, one sec [17:19:57] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Smashpig, Unplanned-Sprint-Work: Create pending database - https://phabricator.wikimedia.org/T140149#2471690 (Ejegg) Open>Resolved [17:21:42] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299576 [17:22:43] (CR) Ejegg: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299576 (owner: Ejegg) [17:23:56] (CR) jenkins-bot: [V: -1] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299576 (owner: Ejegg) [17:35:56] (Abandoned) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299576 (owner: Ejegg) [17:40:09] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299580 [17:42:50] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299580 (owner: Ejegg) [17:43:08] (CR) Awight: [C: 2] Create fundraising/REL1_27 branch [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299035 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [17:44:37] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299580 (owner: Ejegg) [17:46:46] (Merged) jenkins-bot: Create fundraising/REL1_27 branch [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299035 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [17:50:19] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/299584 [17:51:06] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/299584 (owner: Ejegg) [17:51:16] AndyRussG: careful with those lightning bolts! [17:56:52] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/299584 (owner: Ejegg) [18:00:15] the-wub / MBeat : about to deploy a fairly substantial DonationInterface update, switching Ingenico forms over to the new rendering engine [18:00:28] doesn't look like a crazy pace of donations at the moment [18:00:42] yee hah- ty or heads-up [18:00:46] *for [18:01:24] fr-tech: no updates needed in the settings repo as far as you recall, correct? [18:01:55] hmmm... [18:02:11] just reviewing commit msgs [18:02:52] relevant config all seems to be in the local files [18:02:58] cool [18:04:38] * cwd holds breath [18:05:35] !log updated payments from 0c14940f4930e94a9287acae978cc6e661e54ee1 to 8d3873f8d6b0600331775e9ccfc0cf4c6ed1e181 [18:05:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:07:22] something screwy with rtbt :( [18:08:39] !log rolled back payments to 0c14940f4930e94a9287acae978cc6e661e54ee1 [18:08:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:11:13] d'oh: PHP Fatal error: Class 'Memcache' not found [18:11:14] ??? [18:11:28] wat [18:12:00] something with the PHPQueue backend... odder still [18:16:31] oh crap, rtbt is broken with the same error even rolled back [18:17:00] hehe [18:33:03] wow so sorry to not status out. [18:33:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make "Primary" address default address to export - https://phabricator.wikimedia.org/T88446#2471982 (RLewis) @dstrine I tested this by doing the following search: Find Contributions 07/01/2016 to 07/18/2016 $1000 dollars Exported the search results a... [18:33:40] PL O [18:33:42] err [18:33:46] ok i'm looking at logs [18:51:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2472029 (awight) [18:52:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2472041 (awight) p:Triage>High Marking as high priority because of data corruption. [18:57:46] (PS1) Awight: Redisable Knab [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299599 [18:58:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make "Primary" address default address to export - https://phabricator.wikimedia.org/T88446#2472094 (DStrine) thanks @RLewis I will close this task [18:58:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make "Primary" address default address to export - https://phabricator.wikimedia.org/T88446#2472102 (DStrine) Open>Resolved [18:59:45] (PS1) Awight: Disable Friesland and Bunq bank [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299601 [19:01:23] (PS2) Awight: Disable Friesland bank [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299601 [19:02:32] ^ those should go into the next deployment [19:05:20] (CR) Ejegg: [C: 2] Redisable Knab [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299599 (owner: Awight) [19:05:51] (CR) Ejegg: [C: 2] Disable Friesland bank [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299601 (owner: Awight) [19:06:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make contribution_source into a proper thing or retire - https://phabricator.wikimedia.org/T119813#2472144 (DStrine) [19:10:03] awight: I'mma roll your issuer changes into deploy once they merge and try again [19:10:22] fantastic [19:10:29] (Merged) jenkins-bot: Redisable Knab [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299599 (owner: Awight) [19:10:35] (Merged) jenkins-bot: Disable Friesland bank [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299601 (owner: Awight) [19:11:51] (PS5) Awight: Force bad encodings to approximate UTF-8 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) [19:12:15] That one's ready for CR again ^. Pretty high prio to get it out [19:13:01] It's just a workaround, but should make us much more robust. [19:19:27] Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, Technical-Debt: Clean up confusing and repeated code in the PayPal express adapter - https://phabricator.wikimedia.org/T134445#2472251 (DStrine) [19:23:18] (CR) Ejegg: [C: -1] "seems to have made logCompletedPayment non-functional. Do you want to just remove it?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [19:23:26] fundraising-tech-ops: paypal gateway log messages should be bucketed - https://phabricator.wikimedia.org/T113308#2472294 (Jgreen) Open>Resolved done [19:24:43] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah - https://phabricator.wikimedia.org/T138100#2472324 (CCogdill_WMF) Hey @spatton, can you check with Hannah on this when you meet with her next, and ask her to follow up with Jeff? [19:24:44] (CR) Awight: Force bad encodings to approximate UTF-8 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [19:24:58] (CR) Ejegg: "derp, never mind" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [19:25:17] ejegg: you'll need the global enabled to smoke test, too... [19:30:50] (PS7) Awight: Actually block if flagged on GatewayReady [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292970 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [19:31:27] (CR) Awight: [C: 2] Actually block if flagged on GatewayReady [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292970 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [19:31:54] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Consider some initial steps for infrastructure for banner history data crunching - https://phabricator.wikimedia.org/T120057#2472377 (DStrine) [19:33:43] (Merged) jenkins-bot: Actually block if flagged on GatewayReady [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292970 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [19:35:07] (PS6) Ejegg: Force bad encodings to approximate UTF-8 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [19:35:17] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Zapp, Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Donors still don't know payments succeeded when breakage, e.g. queue is dead. - https://phabricator.wikimedia.org/T122627#2472420 (DStrine) [19:36:32] (CR) Ejegg: [C: 2] Force bad encodings to approximate UTF-8 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [19:38:27] (Merged) jenkins-bot: Force bad encodings to approximate UTF-8 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299352 (https://phabricator.wikimedia.org/T140515) (owner: Awight) [19:39:13] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Kill staged_vars - https://phabricator.wikimedia.org/T137387#2472438 (Ejegg) Open>Resolved [19:40:34] fundraising-tech-ops, Operations, ops-eqiad: decommission aluminium, replace it with frqueue1002 - https://phabricator.wikimedia.org/T140676#2472440 (Jgreen) [19:41:01] awight: how's about I cherry-pick around that 'stop processing' thing [19:41:08] +1 [19:41:20] That might bring its own party [19:41:32] (PS1) Ejegg: Kill 'limbo' queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299608 [19:42:16] Fundraising-Backlog: SPRINT N (7/20 - 8/3) - https://phabricator.wikimedia.org/T136251#2472466 (DStrine) [19:42:30] (CR) Awight: "Just to be doctrinaire: this sort of cleanup especially needs a Bug link, cos we're about to toss so many things up in the air..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299608 (owner: Ejegg) [19:43:37] (PS2) Awight: Kill 'limbo' queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299608 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [19:43:43] (PS1) Ejegg: Update libs [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/299609 [19:43:51] (CR) Awight: [C: 2] "Nice low-hanging fruit!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299608 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [19:44:10] (CR) Ejegg: [C: 2 V: 2] Update libs [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/299609 (owner: Ejegg) [19:44:56] ejegg: ty for noticing that a vendor update was needed! I forgot to mention it in the commit message... [19:45:13] no worries, i keep an eye on those composer files [19:45:23] hehe [19:45:48] (PS1) Ejegg: Redisable Knab [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299610 [19:45:50] (PS1) Ejegg: Disable Friesland bank [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299611 [19:45:52] (PS1) Ejegg: Force bad encodings to approximate UTF-8 [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299612 (https://phabricator.wikimedia.org/T140515) [19:45:54] (PS1) Ejegg: Update vendor for UTF8 coersion lib [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299613 [19:46:13] (CR) Ejegg: [C: 2] Redisable Knab [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299610 (owner: Ejegg) [19:46:21] (CR) Ejegg: [C: 2] Disable Friesland bank [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299611 (owner: Ejegg) [19:46:44] (CR) Ejegg: [C: 2] Force bad encodings to approximate UTF-8 [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299612 (https://phabricator.wikimedia.org/T140515) (owner: Ejegg) [19:46:51] (CR) Ejegg: [C: 2] Update vendor for UTF8 coersion lib [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299613 (owner: Ejegg) [19:49:26] I'm just noticing... DI#deployment includes our tests although there are no tests [19:52:35] (Merged) jenkins-bot: Kill 'limbo' queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299608 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [19:52:37] (Merged) jenkins-bot: Redisable Knab [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299610 (owner: Ejegg) [19:52:39] (Merged) jenkins-bot: Disable Friesland bank [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299611 (owner: Ejegg) [19:52:42] (Merged) jenkins-bot: Force bad encodings to approximate UTF-8 [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299612 (https://phabricator.wikimedia.org/T140515) (owner: Ejegg) [19:52:45] (Merged) jenkins-bot: Update vendor for UTF8 coersion lib [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299613 (owner: Ejegg) [19:55:57] !log updated payments from 0c14940f4930e94a9287acae978cc6e661e54ee1 to 8d3873f8d6b0600331775e9ccfc0cf4c6ed1e181 [19:56:07] fr-tech ^^ [19:56:13] rad. [19:56:21] cool [19:56:36] watching the logs [19:57:11] d'oh, did I miss something? [19:57:19] still seeing friesland and knab [19:57:37] derp derp derp [19:57:45] yep, missed the submodule update [19:57:57] fr-tech one more moment please ^^ [19:58:14] good catch! [19:58:15] though, this is most of the patches [19:59:05] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/299617 [20:00:10] ok, I'll start testing Mustaches [20:00:35] meeting. [20:01:00] bpay thing looks OK [20:01:04] o yah [20:05:50] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/299617 (owner: Ejegg) [20:09:02] Fundraising Dash, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dash login failing - https://phabricator.wikimedia.org/T140656#2472563 (DStrine) p:Triage>Normal [20:23:34] Fundraising-Backlog, FR-Adyen, FR-Ingenico, MediaWiki-extensions-DonationInterface: Redirect loop when processor is disabled. - https://phabricator.wikimedia.org/T140314#2472643 (DStrine) [20:23:47] (PS1) Eileen: T137569 Allow Engage users to enter Benefactor Give into Gift Source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299622 [20:26:58] Fundraising-Backlog, FR-Amazon: Amazon interstitial page - https://phabricator.wikimedia.org/T121698#1885763 (DStrine) [20:30:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not all online donations getting tagged to Restrictions and Gift Source Fields - https://phabricator.wikimedia.org/T138361#2472663 (DStrine) p:Triage>Normal [20:31:28] Fundraising-Backlog: Leave blank values in Silverpop file blank, not NULL - https://phabricator.wikimedia.org/T91692#1093457 (Ejegg) This seems to be corrected for first and last names. Are null values in other fields still a problem, or can we close this, @CCogdill_WMF ? [20:35:59] Fundraising-Backlog: Leave blank values in Silverpop file blank, not NULL - https://phabricator.wikimedia.org/T91692#2472723 (CCogdill_WMF) Preferably any blank field in a field type we normally use would be left blank; it just adds a little more complication to Silverpop queries when we have to sort for is... [20:42:23] Fundraising-Backlog: More communication between Silverpop and Civi - https://phabricator.wikimedia.org/T114671#2472779 (Ejegg) [20:42:25] Fundraising-Backlog, Epic: [epic] Use Silverpop API to import email data to CiviCRM - https://phabricator.wikimedia.org/T108891#2472778 (Ejegg) [20:45:15] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, FR-Astropay, Unplanned-Sprint-Work: Investigate and clean up Astropay 'MISSING PREDECESSOR' messages - https://phabricator.wikimedia.org/T139982#2472784 (awight) p:Triage>High [20:45:46] Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, and 6 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2472787 (awight) [20:47:10] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM db lock damaging queue consumption - https://phabricator.wikimedia.org/T139973#2448636 (Eileenmcnaughton) I guess these have quietened down - close @awight ? [20:47:28] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM db lock damaging queue consumption - https://phabricator.wikimedia.org/T139973#2472812 (Eileenmcnaughton) a:Eileenmcnaughton [20:55:52] Fundraising-Backlog, FR-Amazon: Amazon interstitial page - https://phabricator.wikimedia.org/T121698#1885763 (Ejegg) ohhh... we want to change the text 'payments.wikimedia.org' to something like 'Wikimedia Donations'! Sorry, I wasn't sure what the task was. I think that's something we can do in the Ama... [21:01:08] !log updated payments from 8d3873f8d6b0600331775e9ccfc0cf4c6ed1e181 to e8b600c518b28e3f350ced85d7d1006a76b86596 [21:01:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:01:21] gotta swap mouse batteries... [21:06:26] Editable amount form is not working for me: https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=email-cc-vmaj&recurring=&debug=1 [21:06:46] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, and 2 others: Move IDEAL forms to Mustache templates - https://phabricator.wikimedia.org/T128693#2083009 (Ejegg) Open>Resolved redirect to bank is working... [21:06:55] ooh yuck, different error without debug= [21:08:55] Fundraising-Backlog, FR-Adyen: Adyen editable amount form failing - https://phabricator.wikimedia.org/T140690#2472900 (awight) [21:09:49] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 3 others: Convert GlobalCollect credit card forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#2472916 (Ejegg) [21:09:54] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, WMF-deploy-2016-07-12_(1.28.0-wmf.10): Convert BPay to mustache - https://phabricator.wikimedia.org/T140138#2472914 (Ejegg) Open>Resolved Looks good, shows a unique... [21:12:25] awight: ah crap, missing name fields, huh? [21:12:26] WOOHOO! [21:12:31] eh? [21:12:33] The adyen thing? [21:12:40] riiight, that too. missing name and email [21:12:42] yeah, the link with debug=1 [21:12:55] k, that needs fixin [21:13:07] Fundraising-Backlog, FR-Adyen: Adyen editable amount form failing - https://phabricator.wikimedia.org/T140690#2472941 (awight) The form is also missing name and email fields. [21:13:14] but... debug=1 generally breaks stuff on payments because whitelist [21:13:17] I'm not sure it's possible to reach that form though [21:13:23] w/o debug it's still broken [21:13:39] the whitelist doesn't look at URL params fwiw [21:13:41] awight: aha, it's 'cause there's no payment_method [21:13:45] ah [21:13:48] there's a ticket [21:13:49] should be immediate fail then [21:13:54] awesome [21:14:18] https://phabricator.wikimedia.org/T140269 [21:14:28] Wow, I can't believe we might get away with the Mustache deployment. [21:14:35] !!! [21:14:52] As crazy as it was, that feels good. [21:15:49] :) [21:16:28] so, i kind of want to deploy this 'actually block if failed on initial fraud filter' patch now [21:16:39] since it's merged, and I don't want to cherry-pick around it for long [21:16:49] doit [21:17:02] Wanna roll that into 1.27, or before/after? [21:17:16] ahhh... let's do that after 1.27, actually [21:17:20] that's the priority [21:17:26] makes sense [21:17:40] Want a break from deploying? [21:18:04] anybody got opinions on updating DI libs? https://gerrit.wikimedia.org/r/299083 [21:18:15] ooh, needs rebase [21:18:31] that's tricky [21:19:13] does DI require those new versions? [21:20:35] cwd no, I just don't want the version we're using to depend on autoloader order [21:20:35] no, but we can't have a different version than mw-core cos of the single autoloader [21:21:17] (PS3) Ejegg: Update libs to match REL1_27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299083 [21:21:39] ah right [21:21:42] Fundraising-Backlog, FR-Adyen: Adyen editable amount form failing - https://phabricator.wikimedia.org/T140690#2472900 (DStrine) Please note that this is only reproducible with the broken link in the description. As of the writing of this comment IL and UA campaigns are working normally. [21:21:50] So silly that we can't let Composer resolve our dependencies. We should be able to say "^1.12" and it will reconcile DI with mw-core [21:21:58] dstrine: ty! [21:21:59] thanks for getting that CI stuff pushed through on a friday awight ! [21:22:06] It was sad [21:22:09] Saturday too [21:22:11] awight: is that what the merge plugin does? [21:22:16] I thought... [21:23:24] yeah i think that's its purpose [21:23:31] sad that it's necessary, dep management is hard [21:24:26] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike: [BUG] Spike: Why is Donation form stuck with 0 as donation amount; donors can't modify it. Fix why. - https://phabricator.wikimedia.org/T113530#2472991 (Ejegg) Open>Resolved a:Ejegg... [21:27:34] (PS1) Ejegg: Update libs to match 1_27 [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/299665 [21:28:59] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: CiviCRM db lock damaging queue consumption - https://phabricator.wikimedia.org/T139973#2473033 (awight) Open>Resolved Thanks. We still have to make the consumer more robust to ti... [21:29:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Don't reject messages on unknown database error - https://phabricator.wikimedia.org/T140694#2473039 (awight) [21:30:47] Fundraising-Backlog, Project-Admins: Please create a #signal-to-noise tag - https://phabricator.wikimedia.org/T140531#2473055 (DStrine) I can create this tag. Here are the details: tag name: FR-signal-to-noise Description: [[ https://www.mediawiki.org/wiki/Fundraising_tech | Fundraising Tech (fr-tech... [21:31:15] (CR) Ejegg: [C: 2] "Self-merging library update" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299083 (owner: Ejegg) [21:32:40] (Merged) jenkins-bot: Update libs to match REL1_27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299083 (owner: Ejegg) [21:33:34] cwd: want to talk about https://phabricator.wikimedia.org/T133108 ? [21:33:37] (CR) Ejegg: [C: 2 V: 2] "Self-merging library update" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/299665 (owner: Ejegg) [21:33:44] was that the one you grabbed? [21:33:50] (PS1) Ejegg: Update libs to match REL1_27 [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299666 [21:34:11] cwd: or, I could stay offa your toes by doing the Python lib? [21:34:14] (CR) Ejegg: [C: 2] Update libs to match REL1_27 [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299666 (owner: Ejegg) [21:36:52] awight: i'd love to talk about it [21:37:21] (Merged) jenkins-bot: Update libs to match REL1_27 [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299666 (owner: Ejegg) [21:38:11] awight: sorry, what's the python thing about? [21:38:12] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299670 [21:39:49] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299670 (owner: Ejegg) [21:40:09] cwd: I'm on the tech talk link [21:40:27] brt [21:40:42] XenoRyet: ejegg awight and anyone else. This is not meant to derail anyone right now but a Japanese tester tried adyen in japan and got errors. Would this be something we can ask adyen about or would you have to look into it to eliminate something out our side first? https://phabricator.wikimedia.org/T140691 [21:42:15] dstrine: Let me take a quick look. If this is the first time we've tried JCB with them, then it kind of smells like the AmEx bug. [21:42:27] I should be able to sniff that out pretty quickly. [21:42:54] XenoRyet: ok thanks. [21:43:26] oh hah, i was just saying the same on the ticket! [21:45:28] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299670 (owner: Ejegg) [21:46:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 3 others: [Epic] Consolidate "pending" queue usages - https://phabricator.wikimedia.org/T130897#2473093 (Ejegg) [21:46:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Amazon, FR-Astropay: Quit looking in pending queue for completion message information - https://phabricator.wikimedia.org/T122641#2473092 (Ejegg) [21:48:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Read 'completion messages' from pending DB and ActiveMQ, scream if no match - https://phabricator.wikimedia.org/T140484#2473094 (Ejegg) [21:49:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Read 'completion messages' from pending DB and ActiveMQ, scream if no match - https://phabricator.wikimedia.org/T140484#2466525 (Ejegg) [21:49:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Amazon, FR-Astropay: Quit looking in pending queue for completion message information - https://phabricator.wikimedia.org/T122641#2473100 (Ejegg) [21:49:56] dstrine: confirmed it's the same issue as the AmEx thing. Adyen will need to enable JCB for JPY and any other currency we want to use with JCB. [21:50:06] I can put that in the ticket if you'd like. [21:51:41] awight: looks like everything's merged - you want to do the honors with payments-wiki=7c39ca8,payments-wiki-staging=7c39ca8 ? [21:52:48] wow, sure! [21:52:56] Shoot, I have to take off in a bit - if you all want to deploy 1_27 tomorrow I'd be happy to take the helm then... [21:53:17] oh I can totally do it, just chatting with cwd [21:56:57] XenoRyet: cool and thanks. can you email adyen or give me specific wording so I can? [21:57:20] Dstrine: No worries, I'll do it. [21:57:28] thanks! [22:00:43] dstrine: Oh, do you know if we want to use JCB anywhere besides Japan? [22:01:49] XenoRyet: hmm unsure ppena_ should JCB only be usable in Japan? [22:02:04] Settings say no, but if we're planning on it in the future might as well get it all configured now. [22:02:14] I might have to ping her on gchat [22:04:40] ejegg: Is there something funny going on with the other extensions? [22:04:45] Seem to be futuristic submodules [22:04:54] e.g. ContributionTracking = 8317dafcc2938a5ca6c596d422bf92caa6226e3c [22:05:33] awight: oh, I updated 'em to the latest matching 1.27wmfX versions [22:05:44] hrm, I can't seem to fetch those though [22:05:48] hrm? [22:05:50] lemme see [22:06:39] ah dang, looks like ParserFunctions is back on a wmf1.25 one too... oops [22:06:53] ok np. I can take it from here, just wanted to check what had happened [22:07:28] awight - huh, no, ContributionTracking should match origin/wmf/1.27.0-wmf.15 [22:07:54] do I have a bad origin in .gitmodules? [22:08:10] weird. I don't have that branch [22:08:22] dstrine: If she's not around right now we can just to JPY for the moment and ask again if we run into any others. [22:08:26] oh shoot, I wonder if it got cleaned up in gerrit! [22:08:32] I'm going for REL1_27 [22:08:51] ah yeah, I thought it didn't have one for some reason, but now I see it [22:08:57] XenoRyet: yeah let's just do JCB in japan. thanks [22:09:03] Cool, sending now. [22:09:37] (PS1) Awight: Update submodules to REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299676 [22:10:04] (CR) Awight: [C: 2] Update submodules to REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299676 (owner: Awight) [22:10:25] thanks awight! [22:10:28] oc! [22:11:57] so I don't THINK we need to change anything in LocalSettings... [22:12:12] hehe [22:12:17] I'll check UPGRADING [22:12:24] oh snap! [22:12:35] yep, we need Jeff_Green for this one [22:12:42] schema updates required [22:12:44] hmm, no special instructions since 1.16 [22:12:45] oooh [22:12:46] right [22:12:56] so... tomorrow, then! [22:13:18] +1 [22:13:24] we'll need the ability to roll back [22:13:31] yah [22:13:39] got bit by this today https://phabricator.wikimedia.org/T69976 [22:13:43] it's an adventure every time [22:13:50] (Merged) jenkins-bot: Update submodules to REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299676 (owner: Awight) [22:14:38] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Patch-For-Review: Move payments to MediaWiki 1.27 - https://phabricator.wikimedia.org/T138016#2473191 (awight) @Jgreen This just got funky. We realized that the MediaWiki 1.25 -> 1.27 upgrade involves a schema update. We were hoping to deploy... [22:15:28] awight: don't we also need to change the deploy script branch? [22:15:33] hehe > tl;dr instructions to fix if you run into this. ssh into the vagrant instance, run sudo mkdir -p /vagrant/cache/apt/partial, and then run vagrant reload. [22:15:38] that should come at the top of the bug. [22:16:04] cwd: Yeah, but I think the working theory is that we'll deploy the 1.27 code experimentally by simply rev locking to an explicit SHA [22:16:41] awight: oh good thinking [22:16:45] then you can roll back [22:17:10] I still haven't found a reason to be upset at our deployment scripts... [22:17:17] nope [22:17:18] even their Perlness is sort of quaint [22:18:57] i'm stupid but does it know about revs that are not on that branch? does the checkout there track every branch? [22:19:01] i guess i can just check [22:19:14] good question! [22:19:39] You could try to do the f_c_u to a 1.27 commit and then rollback w/o deploy [22:19:44] :-/ [22:22:00] i can git show the tip of 27 from the repo [22:22:05] so i'm pretty sure it would work fine [22:22:18] awesome [22:22:44] Donno if I should lunch anymore, it's getting late... [22:22:45] meh [22:23:41] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up code quality tools for Fundraising repositories - https://phabricator.wikimedia.org/T139686#2473277 (awight) [22:24:12] at some point you just have to skip it and wait for dinner [22:24:32] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up code quality tools for Fundraising repositories - https://phabricator.wikimedia.org/T139686#2439865 (awight) [22:25:03] exactly [22:25:07] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Set up code quality tools for Fundraising repositories - https://phabricator.wikimedia.org/T139686#2439865 (awight) Open>Resolved [22:26:40] Fundraising-Backlog, Technical-Debt: Make code quality scores feed into our planning process - https://phabricator.wikimedia.org/T140698#2473289 (awight) [22:28:12] (PS2) Eileen: T137569 Allow Engage users to enter Benefactor Give into Gift Source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299622 [22:36:02] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Apply CRM-18120 potential deadlock fix - https://phabricator.wikimedia.org/T130173#2473353 (DStrine) [22:38:05] Fundraising-Backlog, fundraising-tech-ops, Epic: [Epic] Upgrade paymentswiki to MediaWiki REL_* release branch or follow the WMF train. Upgrage PHP to HHVM or PHP 5.5 - https://phabricator.wikimedia.org/T130130#2473365 (awight) [22:38:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 2 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2473364 (awight) [22:39:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 2 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2161894 (awight) Note that there's some nastiness in running this on the CRM host, namely that we only have PHP 5.3 there. [22:39:43] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 3 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2473371 (awight) [22:47:41] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Unknown campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2473383 (awight) Agreed, everything about this is... [22:48:23] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: *Existing* campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2473386 (awight) [22:51:12] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, and 2 others: Donations message with empty body! - https://phabricator.wikimedia.org/T140515#2473404 (awight) a:awight [22:51:24] awight: so the current stuff the writes to redis is some code we intend to ditch? [22:51:39] dstrine: I thought I was replicating the search problem - but what I found was I was actually hitting a slightly different problem. Half way through trying to degrade it I was searching for a contact ID. When I continue searching it starts failing - because it has cached the fact I'm doing a contact id search [22:52:05] cwd: I think at the end of this migration, we'll keep that code, just give it a new queue name [22:52:24] oh so it is the new DonationQueue stuff [22:52:26] ? [22:52:28] yah [22:52:34] ok cool [22:52:43] DonationQueue is a chunk of T1000 that we're reverse engineering :) [22:52:43] T1000: Update Beta Cluster status documentation (re Q3 intradepartamental priority) - https://phabricator.wikimedia.org/T1000 [22:52:43] when you did your 20 + searches did you just get them to resolve in quicksearch or did you click 'go' [22:52:59] heh [22:53:23] awight: so it is writing for GC already? what needs to change about that? [22:53:24] dstrine: hey, really sorry about missing the extended standup today :( [22:53:42] cwd: Nothing anywhere is writing to the new queues yet [22:54:01] That's the only component where we write to queues using the new library, which is good [22:54:07] eileen: I don't think I actually completed all those searches, but probably most of them [22:54:12] 12+ [22:54:22] cwd: but we should continue writing to the legacy globalcollect-cc-limbo queue and also the pending-new queue [22:54:37] AndyRussG: it's cool. Whatever you can do to get up to speed on queue work would be awesome [22:54:48] those will be on the same redis in vagrant? [22:55:08] dstrine: is there any chance you did what I did & put a contact id search in the middle of them? [22:55:24] once you do that it caches the fact you are searching for contact id & then all searches fail [22:55:26] cwd: yah, that's not like production, but what can we do... [22:55:51] eileen: I don't think so [22:56:19] ok - I'll keep trying on staging [22:56:35] awight: so in the context of vagrant what that one is doing now is fine? or are we changing the message format? [22:56:39] eileen: I'll try again... [22:56:53] cwd: Pretty sure we'll use the same format [22:57:00] so that particular usage is just a copy paste... [22:57:07] sort of [22:57:20] eileen: can you repro on prod? [22:57:29] I can try on prod [22:58:19] awight: gotcha! now to demystify redis-cli for the nth time [22:58:33] hehehe [22:58:48] aww, nuts. DI doesn't depend on SmashPig yet [23:00:49] I'm not hitting it… - as long as I stick to name searches only… [23:01:37] (PS3) Awight: Add installer info to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298136 (owner: Ejegg) [23:02:45] dstrine: mmphfff is queue what was discussed? sorry I didn't remember the extended standup topic.... [23:03:19] AndyRussG: naw, it was just backlog cleanup and standup, no worries! [23:03:24] AndyRussG: were were triaging bugs. We made some good progress. Nothing CN came up [23:03:32] eileen: I can repro and screen share [23:03:43] can you call into the standup hangout? [23:03:46] (CR) jenkins-bot: [V: -1] Add installer info to composer.json [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298136 (owner: Ejegg) [23:03:49] ok - cool - I'll just move room to see [23:03:58] awight: dstrine cool beans, thx!! [23:21:19] (PS1) Awight: [WIP] Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) [23:22:59] (CR) jenkins-bot: [V: -1] [WIP] Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:24:17] (CR) Awight: "oops. needs the composer.lock change" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298136 (owner: Ejegg) [23:26:18] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 4 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2473521 (awight) So here's the fun question: should the new orphan rectifier be a SmashPig job with a... [23:26:33] cwd: you'll like this ^ [23:29:29] awight: what does it need from smash pig? [23:30:33] cwd: basically, https://gerrit.wikimedia.org/r/299686 [23:30:47] We could stop duplicating the configuration [23:31:07] ah, I guess I should change my question to, DI depends on SP, or DI doesn not have dependencies [23:31:13] There's no way we want SP to depend on DI [23:31:40] crud. how *am* I going to run this job outside of paymentswiki [23:31:49] oh hey look, my train is coming soon [23:34:43] hmm yeah now that i think about it [23:35:08] it seems like it will need its own paymentswiki [23:35:22] if only donation interface was a standalone application [23:35:27] har [23:35:33] :) [23:35:34] We use it that was for the CRM [23:35:37] *way [23:35:47] ah yeah [23:35:51] as a plugin [23:36:02] that's actually cool in a way [23:36:23] Ideally, we'd be decoupled from the forms and this would be trivial [23:36:42] The half-shimmed situation we're in is pretty hellish. My bad [23:37:08] could it run from CRM where DI is hanging out? [23:37:26] ooh nice [23:37:30] that's a great idea [23:37:32] as a civi job or something [23:38:15] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, and 4 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2473543 (awight) @cwdent has the answer here: We can run it from within the CRM, since that combinati... [23:38:16] ty! [23:38:24] and since it will be writing to civi stuff it makes logical sense [23:38:41] It doesn't write to Civi, but that's fine [23:38:57] hrm, to the queue the goes into civi i mean? [23:39:30] yah [23:41:25] awight: will that queue be made into redis too? [23:41:28] yep [23:41:39] that's the "completed queue [23:41:41] *" [23:41:45] but under a different "collection" ? [23:41:50] is that the terminology? [23:42:03] "key" ? [23:42:31] err [23:42:38] we could call them "topic" [23:42:43] but probaly just "queue" [23:42:48] * awight is eating letters [23:43:29] true that the redis native terminology is "key" [23:43:34] blech [23:44:10] Fetched in submodule path 'extensions/ContributionTracking', but it did not contain 8317dafcc2938a5ca6c596d422bf92caa6226e3c. Direct fetching of that commit failed. [23:44:12] wut [23:45:05] i'm still trying to piece together this vagrant box [23:45:24] (PS1) Awight: [WIP] Pending queue supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) [23:45:43] cwd: that sounds like a bad paymentswiki checkout, maybe that's the merged REL1_27 one? [23:46:08] i think so [23:46:09] try pulling again, I should have fixed that branch this morning [23:46:22] git submodule update -i for good measure... [23:46:30] (CR) jenkins-bot: [V: -1] [WIP] Pending queue supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:47:59] OK see you tomorrow! [23:48:09] later!