[00:06:19] Fundraising-Backlog, Project-Admins: Please create a #signal-to-noise tag - https://phabricator.wikimedia.org/T140531#2473617 (Aklapper) Ah. Thank you! Sounds good! +1. :) [00:38:28] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2473670 (Eileenmcnaughton) I think this is the reason why it didn't improve on upgrade https://g... [01:54:40] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2297258 (Dzahn) we use private github repos to store user data? [02:48:34] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2473877 (Eileenmcnaughton) OK - it seems that 1) it's intentional that if the cron is enabled &... [10:22:07] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: *Existing* campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid option - https://phabricator.wikimedia.org/T139969#2474700 (Pcoombe) > The rest of fr-online I ass... [13:50:06] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Patch-For-Review: Move payments to MediaWiki 1.27 - https://phabricator.wikimedia.org/T138016#2475121 (Jgreen) I can't remember the last time we changed the payments wiki schema, so we'll have to create the process. But that database is relativ... [13:56:27] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2475132 (Jgreen) >>! In T135392#2473804, @Dzahn wrote: > we use private github repos to store user data? Not user data, it's for code/co... [14:49:59] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2475502 (CaitVirtue) @RLewis @LeanneS Eileen has made some changes that may temporarily make Civi... [15:02:12] (PS2) Ejegg: Remove WorldPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298903 (owner: Awight) [15:03:23] (CR) Ejegg: "PS2: Manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298903 (owner: Awight) [15:42:05] aaaarg! [15:44:07] Fundraising-Backlog, FR-Adyen: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2475767 (MBeat33) We are continuing to see this error with Adyen, from donors who confirm that they have cookies enabled in their browsers. Adyen did not provide any insight or directions fo... [15:44:18] (PS1) Ejegg: Remove RapidHTML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299769 (https://phabricator.wikimedia.org/T86248) [15:46:06] (CR) jenkins-bot: [V: -1] Remove RapidHTML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299769 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [15:50:01] (PS2) Ejegg: Remove RapidHTML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299769 (https://phabricator.wikimedia.org/T86248) [15:58:11] AndyRussG: what's so aaaarg? [16:00:59] ejegg: heh it was a pre-emptive aaaarg. I thought I might start saving 'em up ahead of time [16:41:22] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup new fundraising queue servers - https://phabricator.wikimedia.org/T136882#2476007 (Cmjohnson) per Jeff's instruction...removed the cable from aluminum to frqueue1002. [16:42:10] (Abandoned) Ejegg: WIP Mustache for legacy WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/292519 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [16:53:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2476032 (JCuriel) Here's another example of the issue: I'm trying to mark as "completed" an assignment that was marked as "scheduled." But when I go to edit the task, Civi asks... [16:58:10] Jeff_Green: I think we're going to go for the 1.27 upgrade today [17:00:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Not able to save activity edits - https://phabricator.wikimedia.org/T137740#2476078 (CaitVirtue) p:Normal>High [17:14:50] (PS1) Ejegg: Get rid of a js global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299794 [17:16:50] (CR) jenkins-bot: [V: -1] Get rid of a js global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299794 (owner: Ejegg) [17:17:58] cwd: I rebased awight's worldpay-nuking patch. Big red button is here if you want to do the honors: https://gerrit.wikimedia.org/r/298903 [17:18:20] awesome :) [17:19:09] That one actually kills a few thousand more lines of code than removing RapidHTML ( https://gerrit.wikimedia.org/r/299769 ) ! [17:19:43] haha, incredible [17:19:54] measurable progress [17:22:40] (PS1) Cdentinger: WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) [17:23:53] cwd we got rid of 'limbo' in https://gerrit.wikimedia.org/r/299608 [17:24:20] ejegg: hrm class not found in that WP one... [17:24:20] who no limbo! [17:24:24] whoa I meant [17:24:28] (CR) jenkins-bot: [V: -1] WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [17:25:02] cwd the hhvm non-voting job? some kind of lagging vendor dir [17:25:13] Guess I should look into that [17:25:22] ejegg: oh nice, that will simplify things [17:25:26] (no limbo) [17:25:58] But everything's failing with missing 'Encoding' class since merging awight's fix for the cyrillic killing message bodies [17:30:14] (PS2) Cdentinger: WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) [17:30:41] interesting, maybe it's not built in to hhvm [17:30:50] but is with zend? [17:31:13] cwd ah no, it's in vendor, it's not built in anywhere [17:31:49] looks like that's the generic extension test, which doesn't account for extension submodules or extension composer needs [17:31:55] (CR) jenkins-bot: [V: -1] WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [17:35:02] so we're fine just merging with that failing? [17:35:27] ^ that thing is just failing cause i used short array syntax :S [17:36:16] oh yeah, we can kill that php53 test after today's deploy! [17:37:03] cwd yeah, that's a problem with the CI, not our code [17:37:34] fundraising-tech-ops, Operations, ops-eqiad: decommission aluminium, replace it with frqueue1002 - https://phabricator.wikimedia.org/T140676#2472440 (Cmjohnson) aluminium cables have been removed. [17:38:22] Jeff_Green: ooh, is ^ the redis server? [17:39:18] (CR) Cdentinger: [C: 2] "https://www.youtube.com/watch?v=U8TsAh-zYFI" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298903 (owner: Awight) [17:41:15] (Merged) jenkins-bot: Remove WorldPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298903 (owner: Awight) [17:41:54] hah, love it [17:45:09] (PS2) Ejegg: Get rid of a js global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299794 [17:46:42] who wants to take the RapidHTML pelt? https://gerrit.wikimedia.org/r/299769 [17:46:48] ejegg: ok re upgrade [17:46:54] cwd yeah it's one of two [17:46:56] So curious to see how those two change our scrutinizer scores [17:48:26] Jeff_Green: upgrade indeed! [17:50:22] ejegg: I'll take a look at that RapidHTML patch [17:51:32] ejegg: I realized, php5.3 is not a thing of the past yet. CRM [17:51:54] We need to keep compatibility until the Civi host is upgraded. [17:53:04] awight: oho, thanks for the reminder! [17:53:18] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2476367 (AndyRussG) This was deployed on Wednesday,... [17:53:42] fr-tech: I'd like some feedback on this... I was gonna introduce a dependency from DI to SmashPig, for pending db stuff. [17:54:06] But that would be the crack in the dyke through which we can slowly ooze generalized modules out of DI. [17:54:53] (CR) Ejegg: "maybe rename old hook function?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299622 (owner: Eileen) [17:55:32] awight: yeah, I've been expecting we'd do that at some point [17:55:42] awesome. [17:56:08] hmmm [17:57:32] dstrine: I've re-organized my kid pickup logistics and work locations, so... instead of being late for today's meeting, I'll leave a little early... hope that's also OK! [17:58:30] awight: but is it worth going to smash pig? are we going to pare that thing down, or make a new thing? [17:58:59] cwd: Since we don't have a new thing yet, it seems to make sense. [17:59:11] Feel free to pare it down or split into components, though! [17:59:26] queue stuff could stand on its own, I'm just not sure how config would work. [17:59:33] I dislike symfony config, but we could go there. [18:00:58] (PS3) Cdentinger: WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) [18:03:57] awight: i don't see a hugely compelling reason to ditch mw style config. php files that have logic in them. it's not pretty, but i don't know if it really matters. losing the ability to do that might make a bunch of work for us though. [18:04:31] we already bumped up against that with yaml config but i bet it'd be way worse with localsettings [18:05:52] cwd too late - smashpig config is already yaml [18:06:35] oh hehe [18:09:46] incoming opinion [18:11:26] i think donation interface is actually more portable than smash pig. i worry that putting stuff there will have more framework based "lock in" than DI where anything goes [18:12:02] what i'm trying to mean by portable is it would be easier to split into components than SP [18:13:56] hmm. [18:14:06] Good contrarian opinion... [18:14:29] I'm fine with creating a new component for the queue stuff-- [18:14:36] maybe we have a pluggable configuration thing? [18:15:56] can you elaborate? [18:15:59] SP is giving us dependency injection and configuration. What would we replace that with? [18:16:23] I'm half imagining we tell the new queue library, here is your Config provider, don't worry where it came from. [18:16:37] what does the dependency injection look like? [18:16:42] then we can continue to use SP for config just cos it's already written, or we can code a new config [18:16:51] the injection is pretty nice, lemme find an example. [18:17:28] cwd: https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/master/SmashPig.yaml#L25-L43 [18:17:56] We could also split the config out of SP and use that in isolation. that would be cool. [18:18:08] Logging I'm not so fond of. It's not PSR-4 compatible, IIRC [18:18:28] symfony config is even more overengineered: http://symfony.com/doc/current/components/config/definition.html [18:18:59] Jeff_Green: not sure anyone has pinged you yet, but we hit an obstacle with the MediaWiki upgrade: schema migration [18:19:05] Can you remind us how that works? [18:20:01] I promise to document this time... [18:21:29] awight: do you want to pull DonationQueue et al out of DI at the same time, and put it in the same component as the consumer? [18:21:40] yes! [18:22:13] cwd: Do you think we should make the new library donations-specific? [18:22:57] hmm, good question [18:23:11] is anything donation specific besides the name? [18:25:10] i have to water the trees, back in a bit [18:25:49] cwd|brb: Yah, like check out PendingDatabase. Not even sure that would fit into a queue library, maybe this is bigger / a separate thing? [18:26:14] cwd|brb: https://gerrit.wikimedia.org/r/#/c/299686/ [18:26:42] AndyRussG: thanks for the heads up. I think hours are mostly flexible but it's great to get everyone into our core meetings [18:32:51] cwd|brb: The way I think about this is, I'm not overly concerned about coupling as long as it's minimal. Like, PendingDatabase::storeMessage can come from anywhere, I just refactor the "use" statement. [18:33:24] dstrine-lunch: k! [18:33:36] (CR) XenoRyet: [C: 2] "Don't let the door hit you on the way out." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299769 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [18:34:00] awight: IIRC you're OK with my squashing the two CN extension registration patches together and tweaking away there, correct? [18:35:13] AndyRussG: for sure, ty! [18:35:26] (Merged) jenkins-bot: Remove RapidHTML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299769 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [18:36:06] bam! [18:36:16] ok, scrutinizer, how are we doing? [18:36:39] awight: cool, thanks likiwize :) [18:38:45] scrutinizer made the awkward observation that most of the WorldPay helpers were actually decent code. [18:38:54] (PS1) Ejegg: Compare pending DB row with queue message (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) [18:40:05] ejegg: note https://gerrit.wikimedia.org/r/#/c/299686/ btw [18:40:50] oh cool, seems to make sense [18:41:26] Ha, validate_input.js went from F to A [18:42:19] nice! [18:42:56] 78 issues fixed [18:44:15] Ok, gotta go be a dad for a while, hopefully back for the meeting [18:46:53] (PS1) Ejegg: No default values for final status message properties [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299819 (https://phabricator.wikimedia.org/T137590) [18:52:48] (PS30) AndyRussG: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [18:53:36] (PS2) Awight: [WIP] Pending database supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) [18:55:14] (PS2) Awight: [WIP] Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) [18:55:16] (PS3) Awight: [WIP] Pending database supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) [18:55:30] (CR) AndyRussG: [C: -2] "Squashed with I179e9ddab2." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [18:56:43] (Abandoned) AndyRussG: Clean up from extension registration migration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/293687 (owner: Awight) [19:01:29] (CR) Ejegg: "It would be really neat if DonationQueue could check to see if the queue's config was a numeric array, and treat that as multiple backends" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [19:03:10] ejegg: I've thought about that, and don't think we want it. [19:03:46] The queue usages might be different between old and new, so we don't want to unnecessarily force them to be used in the same place. [19:03:55] Although it is a killer feature... [19:04:56] ah, ok [19:05:57] That might be totally wrong. It would be awesome to do mirroring from config [19:07:58] we could put it in gateway config [19:08:06] th' yaml [19:08:30] that seems odd [19:08:31] that's application config tho [19:09:01] ok [19:10:02] if it is a thing that changes per gateway it does seem to be coupled with the application config [19:11:19] Why would it change per gateway? Like, to roll the change out per gateway? I hadn't thought of that... [19:26:10] (PS1) Ejegg: Remove Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299826 [19:32:38] awight, ejegg: let's say DonationQueue lived outside DI, wouldn't it be nice if its configuration described the message format, e.g. for PendingQueue ? [19:32:51] for redis it doesn't really matter [19:33:09] but if you wanted to plug that thing into a different mysql db [19:33:14] cwd The message formats are already sort-of defined in SmashPig [19:33:21] totally. I think messages should have a format, and when we deserialize from the queue or db they should be objects rather than arrays [19:33:25] not smartrecords, though [19:33:31] and it sure would be nice to reuse that stuff [19:33:35] ++ [19:33:46] damn, I'm getting burned by PDO. [19:33:54] PDOException: SQLSTATE[42000] [1064] You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'from pending [19:33:58] where gateway = 'test' [19:34:00] and gateway_txn_id = 'txn-1856835395'' at line 1 [19:34:03] "select from" is illegal now? [19:34:10] oh. yeah it is [19:34:13] hehe [19:34:14] column specifiers. [19:34:21] * awight puts away rubber duck [19:35:55] (PS1) Ejegg: (Squashme) rename unmagical validation hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299830 [19:36:21] eileen: does ^^ look good to add on to your latest engage patch? [19:37:29] ejegg: where do i look in smash pig to see those message formats? [19:37:47] CrmLink [19:42:02] extends KeyedOpaqueStorableObject <- that's the kind of stuff i'm wary of getting married to, because e.g. DonationQueue has its own back end [19:42:28] just seems like more layers of indirection [19:43:06] cwd: That one is ass. We don't need to use it, though [19:43:22] (PS3) Awight: Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) [19:43:24] (PS4) Awight: Pending database supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) [19:43:49] it looks like the message classes depend on it [19:44:39] (CR) jenkins-bot: [V: -1] Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [19:44:51] (CR) jenkins-bot: [V: -1] Pending database supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [19:44:57] cwd: really? That's bad. [19:45:21] that's terrible. [19:45:23] i think they extend it so they can have a "save" action or something [19:45:35] yeah a horrific custom json serialization. [19:45:43] yikes [19:45:43] smartrecord fail. [19:45:55] IMO that should be external to the object. [19:46:09] i think in most cases yeah [19:46:17] i think active record is bad [19:46:32] those message formats should maybe implement an interface to indicate they're messages. I don't even think that interface needs to have methods. [19:46:33] but by the time you realize it sucks you are too deep [19:47:03] yeah i can see the use of having them all be a thing [19:47:27] donation interface has models of some of these messages too [19:47:33] (CR) Ejegg: [C: -1] "Oh hey, SmashPig config in /etc should make it easier to reuse things like PendingDatabase (Iccfdbe207f1197)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) (owner: Ejegg) [19:47:34] they probably diverge and stuff [19:47:46] but i wonder if we could pull them out of both and into config [19:47:53] but i wonder if scope creep [19:47:59] +++ [19:48:13] let's keep 'em in code now [19:48:26] lots of other code assumes certain fields exist [19:48:44] I donno what the message formats should look like, but I'm unhealthily fond of putting it into its own library. [19:49:36] but we can complete a queue transition with less tools than this [19:50:01] i think we just need the consumer and then we have the whole chain right? [19:50:05] ejegg: that looks good - I did think about doing that. We are using different whitespace formatting - which is a problem that I can't answer, since CiviCRM has one standard & our code elsewhere has another we can't just agree defaults to use. Ignoring [19:50:18] I actually thought about making that change myself but didn't [19:50:32] oops, I can fix the ws in mine to match the surrounding code [19:50:54] cwd: Yeah, all we need is adapters for * new queue producer * new queue consumer * pending database access [19:51:00] (CR) Eileen: [C: 1] "I agree with this change - I'll test it shortly & change to +2" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299830 (owner: Ejegg) [19:51:14] we're 90% ready with that stuff, but I'm interested in packaging it better [19:52:29] awight: as in, packaging it up outside DI? [19:52:37] as adependency? [19:53:18] (PS2) Ejegg: Rename unmagical validation hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299830 [19:53:49] (CR) Ejegg: "PS2: whitespace" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299830 (owner: Ejegg) [19:54:07] cwd: yeah outside of SP even [19:54:20] The only thing we need is configuration, I believe. [19:55:28] ok, i dig it [19:55:43] shall we make a new repo? [19:57:11] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update CRM SmashPig usage for new config format - https://phabricator.wikimedia.org/T140814#2477041 (Ejegg) [19:57:44] well. we should maybe talk about whether this makes sense. [19:57:56] repo just for message format classes? [19:57:56] How will we get dependency injection and configuration? [19:58:15] nah I was thinking, for donations queue and database. I'm not convinced yet, just floating the idea [19:58:26] oh huh [19:59:06] Honestly, the frameworky stuff in SP is not really a win, it's just there already. [19:59:20] ahem, so it *is* a win, but we could do better if given more time. [19:59:44] i mostly like the fact of components finding their own config in /etc/fundraising [19:59:56] but then testing can get annoying [20:02:58] awight: i don't understand the dependency injection thing. what do we need that composer install doesn't provide? [20:08:03] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Update CRM SmashPig usage for new config format - https://phabricator.wikimedia.org/T140814#2477112 (DStrine) [20:11:40] Fundraising-Backlog, FR-Adyen: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2453194 (DStrine) @MBeat33 this looks like an issue with the user's browsers and any ad blocking software they use. Can you get an extra responsive donor to describe their browser setup? [20:14:19] Fundraising-Backlog, FR-Adyen: Adyen editable amount form failing - https://phabricator.wikimedia.org/T140690#2477164 (DStrine) Open>Invalid [20:14:25] Fundraising-Backlog, FR-Adyen: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2477165 (MBeat33) Thanks for the tip @DStrine we'll ask for more details along those lines [20:20:01] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2477204 (Eileenmcnaughton) After some discussion it seems that turning off the scheduled job is t... [20:20:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.7 attempts to self-update an extension - https://phabricator.wikimedia.org/T140142#2477206 (Eileenmcnaughton) Open>declined Duplicate of https://phabricator.wikimedia.org/T138334 [20:21:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Create an alert for suspicious dips in banner impressions - https://phabricator.wikimedia.org/T116047#2477213 (DStrine) [20:22:59] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269#2477219 (DStrine) p:Triage>Normal [20:23:52] (CR) Eileen: [C: 2] "Yep, tested fine" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299830 (owner: Ejegg) [20:26:06] (CR) Ejegg: [C: 2] T137569 Allow Engage users to enter Benefactor Give into Gift Source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299622 (owner: Eileen) [20:26:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 4.7 attempts to self-update an extension - https://phabricator.wikimedia.org/T140142#2477253 (DStrine) [20:26:53] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2477256 (DStrine) [20:29:53] Fundraising-Backlog, FR-Ingenico: 3502596148 mysteriously in 600 - https://phabricator.wikimedia.org/T139000#2477274 (DStrine) p:Triage>High [20:32:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gift Source and Financial Type for Endowment Gifts - https://phabricator.wikimedia.org/T139629#2438173 (awight) Sounds great--but maybe go staging-first and then we write a code migration? [20:33:09] (Merged) jenkins-bot: T137569 Allow Engage users to enter Benefactor Give into Gift Source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299622 (owner: Eileen) [20:34:39] Fundraising-Backlog, FR-Ingenico: 3502596148 mysteriously in 600 - https://phabricator.wikimedia.org/T139000#2477318 (cwdent) @MBeat33 sorry I didn't notice this earlier. Are you still seeing that problem? I just pulled some fraud breakdowns for recent GC donations and they looked normal. [20:39:45] Fundraising-Backlog: Investigate forms in emails prefilling payments wiki fields - https://phabricator.wikimedia.org/T137233#2477343 (awight) @dpatrick Would you mind taking a look at our crazy plan here? We're considering including the donor's name and email as URL params in links embedded in the email.... [20:40:55] Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2477345 (DStrine) [20:50:50] (PS1) Eileen: Add 'Endowment Gift' to gift source. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299858 [20:52:20] Fundraising-Backlog, FR-Ingenico: 3502596148 mysteriously in 600 - https://phabricator.wikimedia.org/T139000#2477388 (MBeat33) thanks @cwdent There have been no empty sets in fredge for either Ingenico or Adyen since July 10th, thankfully. [20:57:07] (PS1) Eileen: Add 'Endowment Gift' to Financial types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299861 [21:20:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi reports: add filter for "is deceased" - https://phabricator.wikimedia.org/T140831#2477500 (DStrine) [21:21:05] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gift Source and Financial Type for Endowment Gifts - https://phabricator.wikimedia.org/T139629#2477513 (Eileenmcnaughton) [21:21:09] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Adding Gift Source option for Engage users - https://phabricator.wikimedia.org/T137569#2477514 (Eileenmcnaughton) [21:22:39] (PS2) Eileen: Add 'Endowment Gift' to Financial types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299861 (https://phabricator.wikimedia.org/T139629) [21:35:27] ejegg|food: awightI just added a meeting request to discuss merging next week - you don't have to join if you don't want to [21:36:26] fr-tech, well shall we do code-first then? [21:37:34] eileen: I see a meeting at Tue Jul 26, 2016 2pm – 3pm (PDT) [21:37:43] but that is now, and the meeting seemd to be in an hour. [21:37:47] half an hour. [21:37:50] crzy [21:38:23] eileen: Leanne was able to repro the search bug today. Her radio button was set to "email" even though she had not be searching email recently [21:39:04] I'm going to add this to the task [21:39:13] nvm. I see that I'm missing it all, sorry [21:39:37] dstrine: OK - I think the issue is it just doesn't reset [21:39:44] but that seems like something that can be fixed [21:40:04] eileen: she swears she wasn't searching email before it happened [21:40:16] dstrine: ok… [21:40:33] awight: you have confused me - 26 July is not today …. even in NZ [21:41:18] * awight checks planetary alignment and... current planet [21:42:09] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gift Source and Financial Type for Endowment Gifts - https://phabricator.wikimedia.org/T139629#2477596 (Eileenmcnaughton) https://gerrit.wikimedia.org/r/#/c/299861/ [21:42:15] I have to relocate - catch you all in a bit [21:43:19] eileen: slightly new topic. Several civi users are reporting that it is being particularly slow this afternoon. Leanne's demo just now showed it too. It was pretty loan load to view a single record. [21:43:39] *long load to view a single record [21:47:25] (PS4) Awight: Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) [21:47:27] (PS5) Awight: Pending database supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) [21:49:25] (PS5) Awight: Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) [21:49:26] (PS6) Awight: Pending database supports delete and fetch [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) [21:49:38] (CR) jenkins-bot: [V: -1] Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [21:49:39] awight: just do a regular deploy to everything? [21:49:53] heckyeh [21:50:37] woot! sqlite test schema for SmashPig [21:50:42] sqlite::memory ftw [21:50:58] nice, i like sqlite [21:51:07] even the fulltext is pretty impressive [21:51:31] yeah considering it's a flat file [21:51:31] I once gave it a list of all enwp articles and it could do pretty much instantaneous search [21:51:42] awesome [21:51:57] oh KAY, the PendingDatabase patches are V+2 now [21:51:59] i bet sqlite is on the space station [21:52:02] hehe [21:52:10] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah - https://phabricator.wikimedia.org/T138100#2477624 (spatton) Hey @Jgreen and @CCogdill_WMF, just spoke to Hannah and she couldn't find your email, Jeff; I connected you both via email a few seconds ago. [21:52:18] cwd: I'll go ahead and deploy, unless you're already in there? [21:52:26] i haven't done anything [21:52:29] k [21:52:35] i'll fire up the logs [21:52:46] checking what's waiting to merge... [21:53:51] zuul is clear [21:54:02] aah, needs to be cherry-picked [21:54:31] DI fixes? [21:55:47] (PS1) Awight: Kill 'limbo' queue [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299873 (https://phabricator.wikimedia.org/T133195) [21:55:49] clearcutting [21:55:49] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299874 [21:55:51] (PS1) Awight: Remove WorldPay adapter [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299875 [21:55:53] (PS1) Awight: Remove RapidHTML [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299876 (https://phabricator.wikimedia.org/T86248) [21:56:01] Fetched in submodule path 'skins/Vector', but it did not contain e75808eff6056249905add166148a19332317889. Direct fetching of that commit failed. [21:56:02] but we're tiptoeing around the fraud change [21:56:09] bad. [21:56:13] thx for the heads-up [21:56:21] what's up with that? [21:56:27] (CR) Awight: [C: 2] Kill 'limbo' queue [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299873 (https://phabricator.wikimedia.org/T133195) (owner: Awight) [21:56:32] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299874 (owner: Awight) [21:56:37] (CR) Awight: [C: 2] Remove WorldPay adapter [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299875 (owner: Awight) [21:56:43] (CR) Awight: [C: 2] Remove RapidHTML [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299876 (https://phabricator.wikimedia.org/T86248) (owner: Awight) [21:57:13] cwd: There was a mistake in the first cut of the 1.27 branch, where we were using some 1.27.wmf.xxx stuff that was actually pruned from git [21:57:24] I caught it for extensions/ submodules, but missed the skin, is my guess [21:58:39] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299877 [21:58:50] oh, interesting [21:58:58] cwd: wanna zap that one? https://gerrit.wikimedia.org/r/#/c/299679/1 [21:59:30] (CR) Cdentinger: [C: 2] Version number indicates fundraising patches [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299679 (owner: Awight) [21:59:51] (PS2) Awight: update DonationInterface and Vector submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299877 [22:00:03] (Merged) jenkins-bot: Kill 'limbo' queue [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299873 (https://phabricator.wikimedia.org/T133195) (owner: Awight) [22:02:00] (CR) Awight: [C: 2] update DonationInterface and Vector submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299877 (owner: Awight) [22:02:03] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299874 (owner: Awight) [22:02:05] (Merged) jenkins-bot: Remove WorldPay adapter [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299875 (owner: Awight) [22:02:07] (Merged) jenkins-bot: Remove RapidHTML [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/299876 (https://phabricator.wikimedia.org/T86248) (owner: Awight) [22:04:45] (Merged) jenkins-bot: Version number indicates fundraising patches [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299679 (owner: Awight) [22:05:09] XenoRyet: fyi, I have some commits that would benefit from CR, but they aren't attached to a bug in the review column... https://gerrit.wikimedia.org/r/#/c/299686/5 and https://gerrit.wikimedia.org/r/#/c/299691/ [22:05:20] Would be nice to get merged, cos other work is bottlenecked on that [22:05:50] Cool, I'll take a look. [22:06:16] ty! [22:06:47] nice. the latest 1.27 payments still works... [22:06:51] (locally) [22:09:20] awight: the consumer will be a smash pig job that gets run by drush? [22:09:47] sorry off topic [22:10:35] (Merged) jenkins-bot: update DonationInterface and Vector submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/299877 (owner: Awight) [22:13:59] cwd: I'm thinking, a drush wrapper around a DonationInterface job [22:15:02] cwd: [22:15:04] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/recurring_globalcollect/recurring_globalcollect.drush.inc#L54 [22:15:07] ... [22:15:39] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/recurring_globalcollect/recurring_globalcollect.module#L303 [22:15:43] but much less awful. [22:15:58] ejegg: fyi, we're going for the code-first deploy unless you have final words [22:16:25] all for it! [22:16:45] snagging the latest fr/1.27 [22:17:13] the bad news is that I'm cornered in a meeting starting in 15 min, so I'm sending cwd air whiskey in exchange for taking on the 1-hr babysitting [22:17:20] hehe [22:17:40] !log update paymentswiki to fundraising/REL1_27 from e8b600c518b28e3f350ced85d7d1006a76b86596 to 7c6fb5a3b90fffdf2229cc903fb546e0e1e47998 [22:17:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:18:17] syncing... [22:18:43] there it is! [22:19:14] PHP Fatal error: Class 'Composer\Semver\VersionParser' not found [22:19:17] ? [22:19:50] dang. keyboard focus was stolen [22:20:01] I don't see that [22:20:04] locally? [22:20:15] payments-apache2_error [22:20:23] but only once... [22:20:42] right after a couple localizationCache things [22:20:52] weeeird [22:21:00] so it might have been a single-shot cache update missing a beat [22:22:01] that's strange, fatal errors are supposed to also go to the "error" file [22:22:25] adyen donation looks like it just went through fine [22:22:35] ingenico cc - ditto [22:23:00] ejegg: yeah the timestamp of that error was exactly when I started rsyncing. [22:23:23] paypal redirect looks good [22:23:31] awight probably halfway thru sync, then [22:23:54] * awight listens for the fail hail [22:24:17] rtbt redirect worked [22:24:29] yesss [22:24:38] form chooser still routing [22:24:58] i think php can do pretty unpredictable things when half the files are missing [22:25:36] if you manage to slip a request in mid rsync [22:27:59] looking good! [22:28:58] gtg. cwd you all good? [22:29:10] yep! [22:29:14] thanks again! [22:29:19] any time [22:29:40] oh hey, even astropay is working again! [22:31:54] was it broken? [22:51:52] ejegg, is that likely to stick, astropay working again (are forms live)? [22:53:38] forms are live on payments, just donatewiki still isn't showing the options [22:58:05] (CR) Ejegg: [C: 2] "I like it! Planning to reuse this thing." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [22:59:15] (Merged) jenkins-bot: Move PendingDatabase into its own class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:01:23] (CR) Ejegg: "Nice! The fetching we do currently (adyen, astrophysics, amazon) maps to gateway, order_id though, not gateway_txn_id" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299691 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:07:23] (PS2) Ejegg: Add 'Endowment Gift' to gift source. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299858 (owner: Eileen) [23:08:30] (CR) Ejegg: [C: 2] "Option group id makes me cringe, but it's consistent with what came before" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299858 (owner: Eileen) [23:11:12] (Merged) jenkins-bot: Add 'Endowment Gift' to gift source. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299858 (owner: Eileen) [23:23:03] (CR) XenoRyet: "Beat me to the +2 button, but for the record I like it too." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299686 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:38:25] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Patch-For-Review: Move payments to MediaWiki 1.27 - https://phabricator.wikimedia.org/T138016#2478020 (awight) Not totally done--we haven't migrated the schema yet. I made some notes here about the process: https://www.mediawiki.org/wiki/Fundra... [23:42:58] (CR) Eileen: "I cringe with you" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299858 (owner: Eileen) [23:49:18] awight: everything is still looking groovy [23:50:28] so cool [23:51:26] today was a good day [23:52:31] I did't even have to apply my sed/ak to any code [23:53:00] heh [23:53:18] tonight i'm getting on a plane at midnight and getting off at 6am, 4 hours later [23:53:23] tomorrow will be fun [23:53:30] that could be bad [23:53:44] We did the absolute worst timezone move ever, on the way to Wikimania. [23:53:53] We took two redeyes with a 12-hour layover in-between. [23:54:00] jesus [23:54:07] Which means, no sleep for over 36 hours or something [23:54:17] It was morning the whole time. [23:54:26] like Groundhog Day [23:54:36] That sounds horrific [23:55:01] Double lesson time [23:55:12] flying into JFK is basically like having a layover [23:56:00] it's 2 hours from everywhere [23:56:23] For real. Looks so close on a map. [23:56:49] i wonder how much a cab would cost... [23:57:00] $60 to the city, maybe [23:57:11] nah i enjoy the trains. because it's a novelty [23:57:20] worth it. The subway would be $30 for the two of you, and insanely slow [23:57:32] ... I always do it, though [23:57:34] well dani is already out there [23:57:39] ah [23:57:41] +1 for subway [23:57:46] it's fun [23:57:49] I like the summer weather out at the rockaways [23:57:56] it's jungly [23:58:36] i hope there is AC [23:58:43] at dani's sister's apartment [23:59:34] it's pretty nasty walking down the streets, with A/C dripping from every window [23:59:42] * awight is a climate control hater