[00:00:04] it pops open a Comment box instead :) -t has died as well [00:00:28] nasty [00:01:10] ooh, "/" is sweet tho [00:01:58] Fundraising-Backlog, FR-Amazon: Amazon interstitial page - https://phabricator.wikimedia.org/T121698#2485942 (Ejegg) text is changed to 'Wikimedia Foundation' - you change that from the console by selecting 'Login with Amazon' from the dropdown menu at the top, then clicking 'edit' under the Application... [00:02:07] (PS2) Awight: Remove Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299826 (owner: Ejegg) [00:02:20] (CR) Awight: [C: -2] Remove Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299826 (owner: Ejegg) [00:02:32] (CR) Awight: [C: 2] Remove Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299826 (owner: Ejegg) [00:02:34] haha [00:02:36] good UI [00:03:51] (Merged) jenkins-bot: Remove Worldpay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299826 (owner: Ejegg) [00:05:21] (CR) Awight: [C: 2] Get rid of a js global (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299794 (owner: Ejegg) [00:07:12] (Merged) jenkins-bot: Get rid of a js global [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299794 (owner: Ejegg) [00:09:06] thanks for the CR awight [00:09:30] I'll fix up that watchdog thing in a bit, gotta afk for now [00:10:32] (CR) Awight: "Sparse, very interesting!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299819 (https://phabricator.wikimedia.org/T137590) (owner: Ejegg) [00:10:36] oc [00:10:48] ok see you soon! [00:14:00] (CR) Awight: WIP: Write all limbo queues to new pending queue. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [00:16:47] (Abandoned) Awight: [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] (pending_db_orphan_rectifier) - https://gerrit.wikimedia.org/r/299915 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [00:24:14] (PS4) Awight: [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [00:24:16] (PS2) Awight: Depend on SmashPig; use looser caret versioning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299913 [00:25:24] ejegg|afk: nice, that vagrant role made my :4430 work like magic. I'm missing resources, I'm sure it's a simple fix though. [00:26:57] (CR) jenkins-bot: [V: -1] [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [00:30:37] eh? - wikimedia/composer-merge-plugin v1.0.0 requires composer-plugin-api 1.0.0 -> no matching package found. [00:31:06] nvm [00:33:01] cool. got the resources loading via 4430 now. [00:33:57] Oops, our fullurl templates on the main page are pointing to https:...:8080 [01:13:33] ejegg|afk: I think I figured out the "skip if already processed" logic... Since we're sorting and FIFOing by date anyway, just store the offset to last processed date and fetchOldestSince [01:15:54] ah, nope that doesn't work. timestamps only have 1s resolution [01:16:08] We could do the same thing by primary id, but that's not as nice [01:28:19] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Adding Gift Source option for Engage users - https://phabricator.wikimedia.org/T137569#2486044 (Eileenmcnaughton) Open>Resolved [01:31:48] (PS3) Awight: Method to override configuration with data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300171 [01:31:50] (PS1) Awight: New fetch by primary id plus offset, for incomplete consumption [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) [01:37:45] (PS2) Awight: New fetch by primary id plus offset, for incomplete consumption [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) [01:40:40] (PS5) Awight: [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [01:41:15] (CR) Awight: "ejegg: This is all I've come up with to solve the paging problem... lmk wyt" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [01:42:33] (CR) jenkins-bot: [V: -1] [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [03:57:29] (PS1) Cdentinger: use composer-merge-plugin [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/300471 [08:32:35] dstrine-away: what are T140944 and T141059 for, please? [08:32:35] T141059: Strine's second spacer task ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- - https://phabricator.wikimedia.org/T141059 [08:32:35] T140944: Strine's spacer task ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- - https://phabricator.wikimedia.org/T140944 [11:39:43] fundraising-tech-ops, Operations, netops, ops-eqiad: put pfw1- ge-2/0/11 in the 'fundraising' vlan for new host frqueue1001 - https://phabricator.wikimedia.org/T140991#2486639 (Gehel) p:Triage>High [15:44:40] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2487449 (CCogdill_WMF) IBM tried to validate wikipedia.org, but the validation failed because the the p= value was wrong.... [15:54:42] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2487522 (Jgreen) >>! In T135410#2487449, @CCogdill_WMF wrote: > IBM tried to validate wikipedia.org, but the validation f... [16:29:03] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2487683 (CCogdill_WMF) Thanks, Jeff! [16:35:54] (PS7) Ejegg: Compare pending DB row with queue message (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) [16:39:56] (PS3) Ejegg: DO NOT MERGE: import info from pending DB, not AMQ [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) [16:46:31] (CR) Ejegg: "It's a lot like what we did for the payments_fraud messages. The merge logic on the consumer side was introduced here: I3d7395a0a97426d0" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299819 (https://phabricator.wikimedia.org/T137590) (owner: Ejegg) [17:02:18] (PS1) Ejegg: WIP generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 [17:03:25] (CR) jenkins-bot: [V: -1] WIP generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [17:44:59] (PS1) Ejegg: Initialization shortcuts [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300582 [17:45:21] fr-tech: anybody around to review ^^^ ? [17:45:31] Sure, I can take a look. [17:46:27] XenoRyet: it was inspired by awight's comment on https://gerrit.wikimedia.org/r/#/c/299936/3/sites/all/modules/wmf_audit/tests/AmazonAuditTest.php,cm [17:46:52] Cool, thanks for the context [17:47:04] I just found myself about to copy-paste some more ugly code like that and figured I should nip it in the bud [17:47:53] Copy-paste usually is a pretty good indicator that some bud-nipping is in order. [17:52:23] (PS1) Ejegg: WIP tests for combining pending DB info [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300584 (https://phabricator.wikimedia.org/T122641) [17:56:36] (CR) XenoRyet: [C: 2] "Nice bit of tidying up. I like it." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300582 (owner: Ejegg) [17:57:43] (Merged) jenkins-bot: Initialization shortcuts [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300582 (owner: Ejegg) [17:57:59] thanks! [17:58:06] No worries [18:04:30] (CR) Ejegg: [C: -1] "The problem with this style is that we will keep retrying from the oldest message each time we run the job, no matter how many times it fa" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [18:22:11] Fundraising-Backlog, FR-Adyen: Adyen form error message: cookies/cache - https://phabricator.wikimedia.org/T140109#2488292 (MBeat33) p:Triage>Normal We've generated a new macro for these cases, and are gathering donor feedback, but as it appears to be related to browser settings rather than a bug... [18:59:54] !log rolled back payments from 79d2b67067fd7e579372b63e0d619eccfa3b9143 to 79cb53998c41f72d0fa49130ed1f66dc112b478c [18:59:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:45:35] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Store referrer outside of 'donor' key - https://phabricator.wikimedia.org/T141152#2488643 (Ejegg) [19:54:11] (PS2) Ejegg: Add order_id to sparse donation messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300417 (https://phabricator.wikimedia.org/T140484) [20:04:07] tumbleweeds in this google hangout... [20:04:23] Was just clikcing the link, [20:31:35] (PS1) Ejegg: Add JCB to Adyen reference data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300604 [20:31:55] Looks like somebody got a JCB transaction to go through XenoRyet [20:32:08] Wanna approve ^^ so we can parse that audit file? [20:32:23] Did Adyen fix that? [20:32:35] I dunno, I thought we had hidden it from the form [20:33:02] I thought so too. [20:33:35] (CR) XenoRyet: [C: 2] Add JCB to Adyen reference data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300604 (owner: Ejegg) [20:34:18] thanks! [20:34:48] No worries [20:35:07] (Merged) jenkins-bot: Add JCB to Adyen reference data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300604 (owner: Ejegg) [20:39:47] (PS1) Ejegg: Update SmashPig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300635 [20:40:38] (CR) Ejegg: [C: 2] Update SmashPig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300635 (owner: Ejegg) [20:43:40] (CR) jenkins-bot: [V: -1] Update SmashPig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300635 (owner: Ejegg) [20:44:18] d'oh [20:45:12] (PS1) Ejegg: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/300652 [20:49:29] (CR) jenkins-bot: [V: -1] Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/300652 (owner: Ejegg) [20:50:57] (PS2) Ejegg: Update SmashPig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300635 [20:55:08] XenoRyet: mind looking at ^^? [20:55:55] Sure [20:58:26] (CR) XenoRyet: [C: 2] Update SmashPig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300635 (owner: Ejegg) [20:58:46] !log disabled Worldpay audit parser job [20:58:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:00:35] (Merged) jenkins-bot: Update SmashPig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300635 (owner: Ejegg) [21:00:52] (PS2) Ejegg: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/300652 [21:01:38] (CR) Ejegg: [C: 2] Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/300652 (owner: Ejegg) [21:02:20] (PS1) Aaron Schulz: Convert callers to startAtomic/endAtomic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/300658 [21:03:51] (Merged) jenkins-bot: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/300652 (owner: Ejegg) [21:04:23] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/300659 [21:04:41] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/300659 (owner: Ejegg) [21:05:08] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/300659 (owner: Ejegg) [21:10:34] !log updated civicrm from 2f4805fa2d2a7c57881408be2b3a017d26d8f43e to d657255e1edebeccfc0a03bea70b78eb11375cf8 [21:10:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:47:45] XenoRyet / AndyRussG|drivin : tiny correction to vagrant DonationInterface queue settings https://gerrit.wikimedia.org/r/300666 [21:50:31] ejegg: Looks good to me, but I actually don't have +2 authority for vagrant. [21:50:54] ah word, well just apply that locally [21:51:30] I'm having trouble reading stuff out of the redis queue with that ConsumePendingQueue maintenance script [21:51:54] not sure if it's just a config thing, or if we need to change code [21:54:40] oho, it's the way we're sending it. Think we need to push instead of set [21:57:33] (CR) Ejegg: [C: -1] "no more K/V style ->set for new queue" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [22:17:43] gotta relocate [22:25:05] (CR) Krinkle: [C: 2] Convert callers to startAtomic/endAtomic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/300658 (owner: Aaron Schulz) [22:33:24] (Merged) jenkins-bot: Convert callers to startAtomic/endAtomic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/300658 (owner: Aaron Schulz) [22:50:26] (PS1) Ejegg: REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) [22:51:14] XenoRyet: ^^ wasted almost two hours on that and another silly bug with queue defaults [22:51:30] Sounds fun [22:52:16] (CR) XenoRyet: [C: 2] REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [22:52:32] (CR) jenkins-bot: [V: -1] REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [22:53:25] Oh, right. Gotta fix the tests too [22:53:53] word, will do [22:53:57] (CR) jenkins-bot: [V: -1] REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [22:57:49] (PS2) Ejegg: REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) [22:59:23] (PS3) Ejegg: REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) [22:59:37] (CR) jenkins-bot: [V: -1] REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [23:01:40] XenoRyet: ok, ps3 oughtta pass [23:03:27] (CR) XenoRyet: [C: 2] REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [23:06:23] (CR) Ejegg: WIP: Write all limbo queues to new pending queue. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [23:10:37] XenoRyet: think your +2 landed on the wrong patch set [23:10:52] Weird. Let me check it out. [23:11:40] I was looking at PS3 when I hit the button, but who knows. [23:11:48] (CR) XenoRyet: [C: 2] REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [23:12:07] Looks like that one landed right. [23:12:16] thanks! [23:12:35] Might've been something with the new gerrit UI. Takes some getting used to, but I think I like it better overall. [23:13:20] yeah, i'm still a bit lost in it [23:13:53] (Merged) jenkins-bot: REALLY add order_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300677 (https://phabricator.wikimedia.org/T133195) (owner: Ejegg) [23:13:58] That new little up button is my favorite. [23:14:05] (PS4) Ejegg: WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [23:15:55] (PS5) Ejegg: WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [23:16:58] (PS6) Ejegg: WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [23:19:43] sweet, with PS6 it's writing messages that don't blow up when you run ConsumePendingQueue.php [23:20:03] not sure where it's writing those tho... [23:22:54] my drupal db??? huh [23:24:27] derp, .fundraising/SmashPig.yaml exists [23:41:37] (PS3) Ejegg: WIP generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 [23:43:40] sweet, ^^^ generates usable fake auth IPN messages for Adyen [23:43:50] enough for today [23:44:00] have a great weekend fr-tech! [23:44:08] You too. See you on Monday