[00:44:15] (PS12) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [00:44:17] (PS1) Awight: [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [00:44:19] (PS1) Awight: [WIP] WmfFramework-ization of some MediaWiki assumptions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300805 (https://phabricator.wikimedia.org/T131798) [00:45:14] (PS2) Awight: [WIP] Orphan rectification for Drush [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T131275) [00:46:03] (CR) jenkins-bot: [V: -1] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [00:46:50] (CR) jenkins-bot: [V: -1] [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [00:47:06] (CR) jenkins-bot: [V: -1] [WIP] WmfFramework-ization of some MediaWiki assumptions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300805 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [00:55:22] (PS3) Awight: [WIP] Orphan rectification for Drush [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T131275) [05:47:12] fundraising-tech-ops, Operations, netops, ops-eqiad: put pfw1- ge-2/0/11 in the 'fundraising' vlan for new host frqueue1001 - https://phabricator.wikimedia.org/T140991#2483556 (faidon) I configured pfw-eqiad port ge-2/0/11 to be in the fundraising VLAN. You might want to open a new #ops-eqiad tas... [09:11:16] (PS1) Awight: [WIP] More request cleanup (squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300834 [09:12:42] (CR) jenkins-bot: [V: -1] [WIP] More request cleanup (squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300834 (owner: Awight) [09:22:54] (PS2) Awight: [WIP] More request cleanup (squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300834 [09:24:31] (CR) jenkins-bot: [V: -1] [WIP] More request cleanup (squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300834 (owner: Awight) [09:35:45] (PS3) Awight: [WIP] More request cleanup (squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300834 [09:37:00] (CR) jenkins-bot: [V: -1] [WIP] More request cleanup (squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300834 (owner: Awight) [12:04:40] Seddon: hi! how's it going? I see you were able to create a new geotargeted campaign for WMLN GLBT 2016, thx!! (https://phabricator.wikimedia.org/T141236) [14:38:55] fundraising-tech-ops, Operations, netops, ops-eqiad: put pfw1- ge-2/0/11 in the 'fundraising' vlan for new host frqueue1001 - https://phabricator.wikimedia.org/T140991#2492084 (Jgreen) That's great news re. additional available interfaces, I'll create a new #ops-eqiad to do the cable swap and su... [16:15:37] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, Patch-For-Review: Move payments to MediaWiki 1.27 - https://phabricator.wikimedia.org/T138016#2492436 (Jgreen) [16:15:39] Fundraising Sprint Muggle Baiting, Fundraising-Backlog, fundraising-tech-ops, Schema-change: Migrate paymentswiki database to 1.27 schema - https://phabricator.wikimedia.org/T140855#2492435 (Jgreen) Open>Resolved [16:33:16] I think I made some good progress modernizing the orphan rectifier... ejegg you might be interested to hear that I switched back to using PendingDB::fetchOldest... [16:33:40] ah, interesting. I'll take a look [16:34:13] If you feel like some CR, here are the most blockingest patches: https://gerrit.wikimedia.org/r/#/c/300745/ https://gerrit.wikimedia.org/r/#/c/300208/ [16:34:25] Oh, I tweaked cwd's pending mirroring thing: https://gerrit.wikimedia.org/r/299797 probably ready to un-WIP [16:34:35] Those two will get us CI at least [16:35:06] (CR) Ejegg: [C: 1] WIP: Write all limbo queues to new pending queue. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [16:36:13] (CR) Awight: [C: -1] "Needs to make delete() conditional as well." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [16:39:10] (PS2) Ejegg: Conditionally include the home directory in config search [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300208 (owner: Awight) [16:39:29] (CR) Ejegg: [C: 2] Conditionally include the home directory in config search [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300208 (owner: Awight) [16:40:21] ty [16:40:38] ugh, new gerrit makes parentage so confusing [16:40:55] (PS4) Ejegg: Method to override configuration with data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300171 (owner: Awight) [16:41:57] (CR) Ejegg: [C: 2] "Better than a different config file for each test case" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300171 (owner: Awight) [16:42:05] ejegg: oops, here's another dependency: https://gerrit.wikimedia.org/r/#/c/300073/ [16:42:38] Then of course, there's the main course but take yr time: https://gerrit.wikimedia.org/r/#/c/300173/ [16:43:00] right on [16:43:06] I think it'll V+2 once the dependencies are merged [16:43:25] Looking forward to having tests for that little monster [16:44:15] Hmmm where _does_ new gerrit show dependencies? [16:44:50] (CR) Awight: [C: -1] "Considering abandoning this, I'm not sure we need it. We can leave unmerged until there's a use case, at least." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [16:45:29] AndyRussG: ]: it seems to be in "related changes", with no indication of the type of dependency [16:46:34] (CR) Ejegg: "With this patch, I was able to get an Adyen pending message sent to ActiveMQ and Redis, and get the Redis message consumed to the pending " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [16:46:36] (Merged) jenkins-bot: Method to override configuration with data [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300171 (owner: Awight) [16:46:38] (PS3) Awight: Conditionally include the home directory in config search [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300208 [16:47:11] awight: ah K thx! Heh well, simplify, simplify, simplify! [16:48:16] The deal breaker, if negotiations were still happening, is that the Gerrit UI grabs control-keys now, at least on Linux+FF [16:50:23] Hahah yeah I just faced that! Control-T for a new tab? Ah noooo, you mean, edit topic! [16:51:13] AndyRussG: oh hey. The dependencies thing isn't as bad as I thought--it's actually in order, so entries above the ">" current patch are dependents, entries below it are dependencies [16:51:31] AndyRussG: I'm gonna make so many accidental AJAX edits to these tasks... [16:51:40] Ah K I see [16:51:44] I hope Ctrl-F isn't an alias for abandon (as in, "f*** this patch") [16:52:16] harr [16:52:20] "?" still works, at least [16:52:42] (CR) Ejegg: [C: 2] Conditionally include the home directory in config search [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300208 (owner: Awight) [16:52:43] Ah heh I didn't even know that one.... [16:53:41] (Merged) jenkins-bot: Conditionally include the home directory in config search [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300208 (owner: Awight) [16:54:53] (PS3) Awight: Add order_id to sparse donation messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300417 (https://phabricator.wikimedia.org/T140484) (owner: Ejegg) [16:55:02] (CR) Awight: [C: 2] Add order_id to sparse donation messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300417 (https://phabricator.wikimedia.org/T140484) (owner: Ejegg) [16:55:47] (PS2) Awight: No default values for final status message properties [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299819 (https://phabricator.wikimedia.org/T137590) (owner: Ejegg) [16:55:55] (CR) Awight: [C: 2] No default values for final status message properties [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299819 (https://phabricator.wikimedia.org/T137590) (owner: Ejegg) [16:55:59] (Merged) jenkins-bot: Add order_id to sparse donation messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300417 (https://phabricator.wikimedia.org/T140484) (owner: Ejegg) [16:56:53] (Merged) jenkins-bot: No default values for final status message properties [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/299819 (https://phabricator.wikimedia.org/T137590) (owner: Ejegg) [16:57:47] Just this one remaining... https://gerrit.wikimedia.org/r/#/c/300745 [17:00:06] awight: it's sitting on top of the 'primary id plus offset' patch [17:00:12] d'oh [17:00:26] that explains why I couldn't rebase... one moment please [17:01:21] (PS3) Awight: New fetch by primary id plus offset, for incomplete consumption [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) [17:01:23] (PS3) Awight: Singleton PDO For the pending database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300745 [17:02:39] (PS4) Awight: Singleton PDO For the pending database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300745 [17:03:37] (CR) jenkins-bot: [V: -1] Singleton PDO For the pending database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300745 (owner: Awight) [17:04:26] oops! [17:06:34] (PS4) Awight: New fetch by primary id plus offset, for incomplete consumption [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) [17:06:36] (PS5) Awight: Singleton PDO For the pending database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300745 [17:09:56] (PS1) Awight: Relax private access control [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300906 [17:17:18] (CR) Ejegg: [C: 2] "Would sometimes be nice to be able to reset the singleton to make sure we're starting from scratch." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300745 (owner: Awight) [17:17:34] (Abandoned) Awight: [WIP] WmfFramework-ization of some MediaWiki assumptions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300805 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [17:17:40] (Abandoned) Awight: [WIP] More request cleanup (squash) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300834 (owner: Awight) [17:18:14] (Merged) jenkins-bot: Singleton PDO For the pending database [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300745 (owner: Awight) [17:18:25] sigh. I can't even copy+paste in new gerrit [17:18:38] "C" already means something :,-| [17:19:12] blarg [17:19:55] (CR) Awight: "> Would sometimes be nice to be able to reset the singleton to make sure we're starting from scratch." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300745 (owner: Awight) [17:20:06] (CR) Ejegg: "update to pull in 'singleton pdo for pending?'" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299913 (owner: Awight) [17:20:18] (CR) Awight: "recheck" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [17:27:34] * awight digs out cwd|afk's DonationInterface divorce madness [17:41:44] (CR) Awight: WIP: Write all limbo queues to new pending queue. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [17:49:36] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [17:58:36] (PS13) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [17:58:38] (PS2) Awight: [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [17:58:41] (PS1) Awight: Put LogPrefixProvider in its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300915 [18:00:22] (CR) jenkins-bot: [V: -1] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [18:01:01] (CR) jenkins-bot: [V: -1] [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [18:01:22] Fundraising-Backlog, fundraising-tech-ops, Operations, Patch-For-Review: Allow Fundraising to A/B test wikipedia.org as send domain - https://phabricator.wikimedia.org/T135410#2493042 (CCogdill_WMF) Confirmed with IBM that the updated key works, and we've done some validation — looks like DKIM an... [18:05:05] (CR) Ejegg: "I still like it as is, even if it means deployment of this patch requires the pending-new queue to be set up and working." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [18:06:39] ejegg: What does the if...oldqueue thing gain us, though? [18:07:05] awight: makes sure we don't send 'completed' messages to pending-new [18:07:36] ah, that's right :) [18:08:37] how about, test for "{$queue}-new" and mirror only if it's configured? [18:09:10] The main thing I'm interested in is having a configurable kill switch for the mirroring... [18:10:32] Sure, that's nicer than having to point to PDO/memory [18:10:50] (PS3) Awight: [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [18:10:52] (PS1) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [18:11:00] I think we only need pending-new, though - we don't want to send ingenico cc to a separate redis queue [18:12:11] We could copy the configuration over, but you're right that makes our consolidation less obvious [18:12:14] k [18:12:25] (CR) jenkins-bot: [V: -1] [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [18:12:56] (CR) jenkins-bot: [V: -1] WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [18:13:16] (CR) Awight: "Ready to go once the mirroring can be disabled by configuration..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [18:17:42] ejegg: omg https://packagist.org/packages/wikimedia/smash-pig [18:17:52] 1,407 installs?? I hope that was all us [18:18:34] whoa! [18:18:38] ejegg: heya, how do you make packagist scan for newer versions? [18:18:44] Oh hey, I think CI might be inflating that :) [18:18:49] whew! [18:18:53] awight, are you an owner? [18:19:02] Now we know how these numbers come about [18:19:05] no, I don't think so [18:19:25] ah, let me make you one [18:19:40] stupid--oauth signup but I still need to create a password [18:19:55] user "adamwight" [18:20:02] cool, one sec [18:20:16] nice thx [18:20:27] ok, added to di and smashpig [18:20:38] so on the package page you should see a green 'update' button [18:22:00] Works! [18:22:04] nice [18:22:09] (PS7) Ejegg: Write all limbo queues to new pending queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [18:22:37] (PS14) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [18:22:39] (PS2) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [18:22:41] (PS4) Awight: [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [18:22:43] (PS2) Awight: Put LogPrefixProvider in its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300915 [18:22:45] (PS3) Awight: Depend on SmashPig; use looser caret versioning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299913 [18:23:06] * awight puts on green sunglasses to avoid being startled by expectation of green lights [18:24:15] (CR) jenkins-bot: [V: -1] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [18:24:57] (CR) jenkins-bot: [V: -1] [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [18:25:03] wat [18:25:25] (CR) jenkins-bot: [V: -1] WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [18:26:59] (PS15) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [18:27:01] (PS3) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [18:27:03] (PS5) Awight: [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [18:27:05] (PS3) Awight: Put LogPrefixProvider in its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300915 [18:27:07] (PS4) Awight: Depend on SmashPig; use looser caret versioning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299913 [18:29:15] (CR) jenkins-bot: [V: -1] [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [18:30:06] oh good. ejegg fwiw, https://gerrit.wikimedia.org/r/#/c/300173/ should be safe to merge cos it doesn't affect the legacy orphans.php job [18:30:33] no rush of course, beyond the exposure to merge conflicts... [18:40:59] (PS6) Awight: [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [18:41:36] cool [18:42:14] phew, trying to test my fake IPN message thing, and i'm not sure if my correlation-id troubles are caused by a new version of activemq [18:42:34] having a hell of a time getting the old version to run on ubuntu 16.04 [18:43:04] you could try the vagrant puppet if you're feeling brave... [18:43:21] meh, no way will that work [18:43:28] really? [18:43:35] I was hoping it would... [18:43:50] oh it'll work in vagrant I believe [18:43:59] but too dangerous to run on bare metal [18:44:23] it's usually just a few config files from what I remember [18:44:52] other than the config, it can run out of a /usr/local dir with no special installation [18:44:55] i keep getting complaints about missing beans [18:45:02] oh... [18:46:15] (CR) jenkins-bot: [V: -1] [WIP] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [18:46:33] ejegg: There seems to be an package? http://packages.ubuntu.com/xenial/activemq [18:46:53] scary stuff [18:51:50] (CR) Awight: [C: 2] "It works! It would be nice to log the fact that we're mirroring, but there's a dearth of logging in the class anyway." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [18:53:17] (Merged) jenkins-bot: Write all limbo queues to new pending queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299797 (https://phabricator.wikimedia.org/T133195) (owner: Cdentinger) [18:54:39] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, and 13 others: [Epic] All pending producers should write to a single pending queue - https://phabricator.wikimedia.org/T133195#2493303 (awight)... [19:09:31] ejegg: oh, another trick would be to omit activemq entirely. You can set the wgDonationInterfaceDefaultQueueServer to redis... [19:10:15] It seems unlikely that there would be side effects of the new code would only affect activemq legacy queues [19:10:57] awight: yeah, but I want to test the code that compares amq and redis messages [19:11:15] awight: little fix for vagrant queue config: https://gerrit.wikimedia.org/r/300666 [19:11:28] ah kay [19:17:40] (PS7) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [19:19:24] (CR) jenkins-bot: [V: -1] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [19:29:14] ugh, the vagrant config is now overriding the whole accountInfo array with the puppetized test account, so even 01-DonationInterface.php settings are clobbered [19:29:26] need to put stuff AFTER 10-, and clobber harder [19:29:42] I think we should just remove those test account settings [19:30:27] I could get on board with that. [19:30:59] What would we be losing by not having them in there? [19:31:37] well, I guess we need some kind of account settings to just load forms [19:34:13] (PS1) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [19:34:30] I guess weigh the pain of folks having to set that up manually against how often this thing bites us. [19:35:02] Anyway, gotta go make lunch for the boy, back in a few. [19:35:18] It doesn't sound quite right--if the settings are being clobbered, we lose the ability to override anything at all. [19:36:01] ooh, maybe this is caused by extension registration [19:36:07] (CR) jenkins-bot: [V: -1] More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [19:36:17] There's some funkiness with merging hashes [19:37:39] and, nasty: CI is not pulling all the composer dependencies [19:38:34] awight: in puppet-managed/10-DonationInterface.php : $wgAdyenGatewayAccountInfo = array( "test" => array( "AccountName" => "test", "PublicKey" => "test", "SharedSecret" => "test", "SkinCode" => "test" ) ); [19:39:06] Think we need to specify the settings different in the puppet manifest now? [19:39:35] lessee. [19:39:38] so it just sets $wgAdyenGatewayAccountInfo['test'] instead of the whole array [19:39:47] also, i just got bit by the old composer deps too [19:40:15] includes/registration/ExtensionProcessor.php -> mergeStrategies is interesting [19:40:52] right, but that wouldn't make a difference in how the .php files overwrite each other, would it? [19:40:57] you can define strategies in the global using the '_merge_strategy' key fwiw [19:41:02] does it change how settings.d entries are processed? [19:41:04] ooh right [19:41:17] I thought they were just included one after another [19:41:42] * awight starts printfing like mad [19:41:44] yeah, our fight is with mediawiki-vagrant [19:42:18] hehe, you may have summoned gurus [19:42:29] nice~ [19:42:49] * bd808 feels a great disturbance in the force [19:42:52] yeah \ is causing some hairpull today [19:43:20] It does exactly what it is configured to do ;) [19:43:40] computer: what was the configured question [19:43:51] * AndyRussG protects remaining hair(s) [19:44:14] bd808: hey, while you're here, do you know of anything new about how settings.d is processed? [19:44:48] new? Nope. Nothing has changed there in quite a while AFAIK [19:44:51] think I found the place to make sure composer is updated [19:45:17] awight: I think the new thing is in how mediawiki::extension creates the settings files [19:46:07] it may have implicitly created arrays with $wgFoo['bar'] = 'setting'; before [19:46:17] are you having troubles with extensions preferring exension.json or something? [19:46:26] and now is doing $wgFoo = array( 'bar' => 'setting' ); [19:47:12] ejegg: I'm back on the extension registration tip, actually--note how 10-DonationInterface.php calls wfLoadExtension, which would have changed in the last few weeks [19:47:45] bd808: no, we've been putting settings that we need to come first in arrays into not-puppet-managed 01-DonationInterface.php [19:47:58] which worked till recently [19:48:08] ejegg: It does make sense to declare our overrides after 10- tho [19:48:38] now, why did that work previously, when DI.php just clobbered everything?? [19:48:39] awight yeah, i moved the stuff to 20-account.php and changed it to clobber the whole arrays [19:48:45] cool [19:48:52] it works? [19:48:54] awight: DI.php never had account settings in it [19:49:05] not managed by puppet because secrets of some sort or ...? [19:49:05] hrm [19:49:10] awight: yeah, 20-account + redeclare all arrays does work [19:49:12] bd808: exactly [19:49:38] awight: I'm just going to update the instructions [19:49:53] bd808: here's our crappy howto for dealing with this issue up 'til now: https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/payments/files/Main_Page.wiki [19:50:05] #configuration [19:51:57] bd808 while we've got your attention, is there a way to ensure php::composer::install runs each time you provision? We've got some stale dependencies hanging around [19:54:14] ejegg: iono, that's similar to managing the repos using git, which is up to the developer after the initial clone [19:54:25] You sure you want vagrant doing that? [19:54:42] ah, maybe not [19:55:33] ejegg: Was that what you were talking about re. composer a minute ago? I'm getting burned by something else, I guess: https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-non-voting/1192/console [19:55:46] note how the composer plugins don't include any of the new stuff! [19:55:51] e.g. SmashPig [19:57:49] ejegg: each time you provision, each time you run `vagrant git-update` should already be the case [19:58:05] * each time you provision no [19:58:52] oh, neat! [19:59:38] awight: you can also do something like this with a git hook -- https://phabricator.wikimedia.org/P3571 [19:59:50] I have that on my mediawiki/core.git clone [20:09:11] dstrine-away: standup if you're around... [20:21:20] (PS2) Ejegg: Reword docs; stop doing popAtomic(function () {}) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/300054 (owner: Awight) [20:45:22] (CR) Ejegg: [C: 2] Reword docs; stop doing popAtomic(function () {}) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/300054 (owner: Awight) [20:46:00] (Merged) jenkins-bot: Reword docs; stop doing popAtomic(function () {}) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/300054 (owner: Awight) [20:52:50] eileen: that Sarah Silverman piece is great, thx! [21:11:37] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [21:55:18] Fundraising Sprint Nitpicking, Fundraising-Backlog, Continuous-Integration-Config, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Continuous integration mw-ext composer behavior is not predictable - https://phabricator.wikimedia.org/T141309#2493985 (awight) [22:17:19] (PS1) Awight: Dependencies += SmashPig [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/301010 [22:19:23] (PS8) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [22:19:25] (PS2) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [22:22:14] Fundraising Sprint Nitpicking, Fundraising-Backlog, Continuous-Integration-Config, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Continuous integration mw-ext composer behavior is not predictable - https://phabricator.wikimedia.org/T141309#2494084 (awight) Reedy suggested I t... [22:36:33] (PS4) Ejegg: Generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 [22:38:35] (PS9) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [22:39:54] (CR) Awight: Generate IPN messages matching pending db (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [22:42:11] (PS10) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [22:43:37] (PS11) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [22:45:08] (CR) Ejegg: "Maybe move the selection into the maint class?" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [22:47:12] ejegg: I still don't understand what you mean--fetch*Oldest doesn't pop messages... [22:47:35] Totally fine though, it's already a loose API and we can cull it later. [22:47:36] awight: no, but to test a new message you have to delete the old ones [22:47:39] I was just curious [22:47:49] I guess I was hoping to be able to test processing a few messages at a time [22:47:49] eh? [22:48:06] fetchOldest only works if you're deleting as you go [22:48:16] *only works for multiple messages [22:48:19] oho right sorry [22:48:30] and I opted out of paging by sinceId [22:48:34] ehh, it's ugly as heck in general [22:50:14] Awesome that you're writing these high-level tools as we go, though! [22:50:39] It's silly of me to be protective about debt in the core classes at this point [22:51:54] I'm just looking for ways to procrastinate, I launched an attack against Zuul a minute ago [22:52:08] seems to have been very effective [22:52:53] Actually, ejegg you must have run into this bug, too, that CI doesn't pick up vendor libraries reliably? [22:53:30] I still haven't figured out how it *sometimes* correctly installs libs in the first place :-/ [22:54:15] Fundraising Sprint Nitpicking, Fundraising-Backlog, Continuous-Integration-Config, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Continuous integration mw-ext composer behavior is not predictable - https://phabricator.wikimedia.org/T141309#2494218 (awight) *Don't* try what I... [22:54:21] awight: the manifests have php::composer::install in them [22:54:31] which runs the first time you provision [22:54:38] but doesn't seem to run again [22:56:39] ejegg: for vagrant sure, but I'm talking about wmf CI [23:01:15] awight: ooh [23:01:42] awight: oops, I'm getting undefined index errors for SERVER['HOME'] since the 'conditionally include' patch [23:01:53] wat, *since* the patch?? [23:02:03] can you paste an error msg [23:02:11] err, no wait, silly me [23:02:20] checkout instead of cherrypick [23:02:31] No idea why that's happening in the first place [23:02:46] I'm hoping it's just a harmless... phpunit internals thing [23:13:26] (PS1) Eileen: Hack out version & extension checks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301023 (https://phabricator.wikimedia.org/T138334) [23:13:46] awight: sorry, I was on a different revision than I thought [23:14:01] (PS5) Ejegg: Generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 [23:16:08] (PS6) Ejegg: Generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 [23:20:52] Anyone remember where to find our wiki page with the current database schema explained? [23:21:27] dang, nope [23:22:44] It's unfindable [23:22:46] I did just get an astropay message all the way from DonationInterface to CiviCRM via a fake IPN message, though. Queue consumer compared amq entry with db entry and found 'em equal! [23:23:50] collabwiki, of course [23:23:55] ejegg: WOW [23:24:24] i've been keeping https://etherpad.wikimedia.org/p/Fundraising_End_To_End up to date [23:25:25] Amazon's exactly the same when it comes to queue messages, so I'm hoping it works too, but testing is tough [23:25:43] I need to make a mock IPN handler or something [23:26:15] which means i should really try to reconcile my fork with upstream [23:26:44] ehhh, seems like a ways off the queue track [23:28:07] hehe [23:28:13] me too. here I am orphan rectifying. [23:29:41] hmm, that also means getting DI runnable under CRM again, huh? [23:35:47] exactly. [23:35:53] didyu see the fun patches so far? [23:36:13] https://gerrit.wikimedia.org/r/#/c/300918 https://gerrit.wikimedia.org/r/#/c/300804 [23:36:21] https://gerrit.wikimedia.org/r/#/c/300933 [23:36:27] Fun as in, not fun. [23:42:28] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [23:42:35] yeah, been squinting at them from a distance so far [23:42:55] hehe wfm [23:43:05] but yeah--it does mean making DI work again. [23:43:22] Tedious, but I'm glad it's forcing me to look at all the places were illicitly dipping into the non-request [23:44:30] *we were [23:44:37] *where we were [23:45:08] * awight feigns to not have fear of non-DRY speech [23:53:21] (PS1) Ejegg: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) [23:53:54] Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ, FR-Smashpig: SmashPig tasks which read from pending queue should compare to pending db - https://phabricator.wikimedia.org/T140959#2494335 (Ejegg) a:Ejegg [23:54:21] (CR) jenkins-bot: [V: -1] Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg)