[00:22:15] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [00:25:07] (PS2) Ejegg: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) [00:25:16] Fundraising Tech Backlog: Please add me to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2494397 (Eileenmcnaughton) [00:26:08] (CR) Ejegg: [C: 2] Put LogPrefixProvider in its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300915 (owner: Awight) [00:30:46] (PS5) Ejegg: Depend on SmashPig; use looser caret versioning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299913 (owner: Awight) [00:31:07] (CR) Ejegg: [C: 2] "Doesn't break stuff on my machine!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299913 (owner: Awight) [00:31:46] (PS4) Ejegg: Put LogPrefixProvider in its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300915 (owner: Awight) [00:32:32] (Merged) jenkins-bot: Depend on SmashPig; use looser caret versioning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299913 (owner: Awight) [00:33:19] ejegg: Thanks! Need any quid pro? [00:33:53] I think the CI situation should be resolved by tomorrow--DI hhvm was using the non-composer job, and we can just drop the 1.25 job [00:34:10] if you want to try testing the crm completion message stuff (using the fake ipn message stuff), that would be cool! [00:34:34] twentyafterfour did merge the blocking part where you removed 1.25 jobs, but we're still waiting on the zuul restart. [00:34:44] ejegg: cool, I'll try that now [00:34:47] ah, word [00:34:51] thanks! [00:35:44] (CR) Ejegg: [C: 2] Put LogPrefixProvider in its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300915 (owner: Awight) [00:38:12] (PS2) Eileen: Hack out version & extension checks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301023 (https://phabricator.wikimedia.org/T138334) [00:41:10] (Merged) jenkins-bot: Put LogPrefixProvider in its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300915 (owner: Awight) [00:42:15] ejegg: So this is the main one to review? https://gerrit.wikimedia.org/r/#/c/301026/ [00:42:25] Such a great idea! [00:43:14] awight: I just banged that one out, but the CRM equivalents are more considered [00:44:06] though they may need an on/off switch to avoid logspam if we deploy code before infrastructure [00:47:01] All that extra key capture in gerrit-new, and no "]" [00:48:09] ejegg: ah https://gerrit.wikimedia.org/r/#/c/299816/ [00:48:53] hmm, I guess we should delete from the pending db as we delete from the queue [00:49:27] (CR) Awight: Compare pending db and queue in Adyen capture job (4 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [00:51:36] awight: ohhhh, tagged logger is a not-for-failmail thing? I never realized! [00:52:26] I was trying to remember, the other day. mwalker|away wrote that and it was from the future. [00:52:57] Yeah, apparently there are configurable, secure file drops for each transaction [00:53:00] It's a great idea [00:53:48] cool, I'll take a look! [00:54:01] (CR) Awight: Compare pending db and queue in Adyen capture job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [01:00:10] (CR) Awight: Compare pending db and queue in Adyen capture job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [01:01:38] awight: so does it need a special tag like RawData? [01:01:50] (CR) Awight: [C: -1] "Provisionally blocking to ask that we be robust to pendingDb = null" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [01:02:32] ejegg: here's an example I662686f257a32d22df623b6c2def58405356c51f [01:03:17] Maybe there's a config wiggle to do in synchrony [01:03:39] awight: the new patch is using the same logger object... [01:04:13] cool, we'll see if it winds up in failmail [01:11:50] (CR) Awight: "CR0'ing, I'm fine with the loud and clear migration to relying on the pending db." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [01:12:35] (PS3) Ejegg: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) [01:19:13] good night fr-tech, good night moon [01:19:35] Me too [01:22:10] (CR) Awight: Compare pending db and queue in Adyen capture job (4 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [01:35:07] (PS1) Eileen: Revert "CRM-18744 - Remember quicksearch field selection" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301043 (https://phabricator.wikimedia.org/T140293) [01:38:42] rats. mediawiki-vagrant adyen_gateway: Exception setting up GatewayPage with adapter class AdyenAdapter: DB connection error: Can't connect to local MySQL server through socket '/dev/null' (111) () #0 /vagrant/mediawiki-fr/includes/db/DatabaseMysqlBase.php(119): .... [01:47:36] On vagrant? [01:49:41] Yeah. It seems to be in the puppet module config, the mysql hostname is off. [01:50:50] Hmmm [01:52:23] Is yours still acting up? [01:52:49] It did the base install stuff more or less OK, didn't take it further than that yet :/ [01:53:03] Are u looking at a new patch? [01:53:20] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2494538 (Dzahn) a:Jgreen>None [01:53:43] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2297258 (Dzahn) a:Dzahn [02:01:27] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2494556 (Dzahn) Open>Resolved all 3 users have been created now (details in subtasks) [02:02:03] Fundraising-Backlog, fundraising-tech-ops: access request for users at fundraising analytics consultant CPS Data Consulting - https://phabricator.wikimedia.org/T135392#2494561 (Dzahn) [02:04:03] AndyRussG: I'm smoke testing ejegg|away's https://gerrit.wikimedia.org/r/#/c/299816/ at the moment [02:04:16] He did a few interesting patches, inspired by your parallel consumption idea. [02:04:37] awight: ah cool :) [02:04:47] We fetch an ActiveMQ message, then check the new "pending database" to compare message contents [02:05:50] * awight suddenly has second thoughts about how useful that is [02:06:11] Hmmm [02:07:04] I suppose it gives us a nice guarantee that we could switch over where we get the messages and have no side effects [02:07:21] Right hmm [02:07:25] It feels weird though, cos we're testing really trivial stuff--we're either mirroring the message or not... [02:07:34] Right [02:07:40] Well, the sum of the trivial is the complex [02:07:46] O_O [02:07:49] totally [02:07:54] That's why unit tests [02:08:14] They sometimes seem like just a rewriting of the same code, but then you change something unwittingly and it borks [02:08:22] We could always add additional warnings that test riskier pending db calculations or later steps in processing the message [02:08:32] Yeah also! [02:08:52] In any case, a bunch of trivial tests also seem good [02:09:33] That way, as the switch to the new queue progresses, you have some guarantee that this trivial bit didn't get twisted and torn [02:09:41] * AndyRussG gets down from pulpit and tries to program [02:09:51] It's cool also because it's a very safe change, essentially a no-op, but it puts all the PendingDatabase machinery where we need it [02:09:55] hehe [02:09:56] thx [02:10:14] au contraire :) [02:11:30] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, and 2 others: Handle refund mismatch more correctly - https://phabricator.wikimedia.org/T138542#2494567 (Eileenmcnaughton) So there are 2 issues here I believe 1) according... [02:16:52] awight: all the autoload classes in the CN patch in extension.json were autogenerated, right? I guess not much sense in ticking them off one by one? [02:18:10] AndyRussG: hmm--this is terrible but you could run the extension convertor again locally and compare the output [02:18:34] Cos I could have lost classes during my sloppy conflict resolution [02:21:06] here's the script, https://www.mediawiki.org/wiki/Manual:Extension_registration#Migration_for_extension_developers [02:28:13] awight: hey great idea! not terrible at all :) thx [02:35:17] (CR) Awight: [C: -1 V: 1] "It works! Great idea and execution, I would merge but you probably want to fix the error on an empty queue." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [02:35:34] * awight uses software to send mixed signals :p [02:38:04] (CR) Awight: Generate IPN messages matching pending db (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [02:39:43] (CR) Awight: Generate IPN messages matching pending db (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [02:43:06] tomorrowz! [02:43:32] see ya :) [02:49:42] (CR) Awight: "Off topic, I ran into this when running the StompJobRunner:" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) (owner: Ejegg) [02:51:09] (CR) Awight: "(sorry, previous comment was in reference to @I1d306caa9aabc1e85be485775ba536c8b9bf8528 )" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299816 (https://phabricator.wikimedia.org/T140484) (owner: Ejegg) [02:59:51] (CR) Awight: "I'm having trouble running the ProcessCaptureRequestJob--where do we tell Configuration that the job should run in the "adyen" config view" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [03:12:55] (CR) Awight: "Argh, I've hit rock bottom. I see the ActiveMQ message for my transaction, but still SmashPig can't retrieve it, so the comparison code i" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [05:37:22] (PS2) Awight: Remove pre-1.27 compatibility shims [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [05:38:51] (CR) jenkins-bot: [V: -1] Remove pre-1.27 compatibility shims [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [05:53:12] (CR) Awight: "Heads-up, this installer is currently being picked up by CRM composer, which causes the lib to be placed in crm/extensions/DonationInterfa" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298136 (owner: Ejegg) [06:35:45] (PS1) Awight: [WIP] shovel in more DonationInterface configuration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301067 [06:36:47] (PS1) Awight: [WIP] Unacceptable hacks for batch processing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301068 [06:38:06] (CR) jenkins-bot: [V: -1] [WIP] shovel in more DonationInterface configuration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301067 (owner: Awight) [06:39:04] (CR) jenkins-bot: [V: -1] [WIP] Unacceptable hacks for batch processing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301068 (owner: Awight) [10:17:17] Fundraising Tech Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2495174 (Danny_B) [14:24:33] ^ cwd starts a new tmux session [14:32:57] * cwd waves at AndyRussG [14:33:25] :) [14:35:38] how are things going? i'm just catching up on email [14:35:48] and new gerrit [14:36:43] new gerrit and I are on the road to acquaintanceship [14:37:23] I'm remembering that summer weeks with no day camp can be a bit hairy [14:37:29] How are u? := [14:37:31] :) [14:37:39] oooh man https://gerrit.wikimedia.org/r/#/c/300429/1/composer.json@32 we can finally link to line numbers [14:37:43] (Sorry the := was meant to be a :) ) [14:37:45] that alone makes the upgrade worthwhile [14:38:13] i am doing well, here at dani's sister's place near scranton PA [14:38:19] Woohoo! [14:38:23] had a suffocatingly hot week in NYC [14:38:36] Hmmm [14:38:48] but the conference was fun and it was great to see the old crew [14:39:15] rms and cory doctorow were there [14:39:49] Ah neat! [14:40:12] Yeah it's pretty toasty here too [14:41:17] ...wish I had a few brain cycles available for stuff like conferences :) [14:41:51] first time i've ever paid to go to a conference [14:41:59] wouldn't be surprised if it was the last [14:42:11] What conferences was it again? [14:42:56] AndyRussG: https://xi.hope.net/ [14:43:52] went 2 years ago with formerjob, and it was the best conference i ever saw [14:44:32] this year was similar, though i found that without feeling obligation to my employer to go to talks, it was hard to get motivated :) [14:45:24] hmmm seems interesting!! [15:21:10] (PS7) Ejegg: Generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 [15:26:20] (CR) Ejegg: Compare pending db and queue in Adyen capture job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [15:26:56] (PS4) Ejegg: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) [15:49:24] (CR) Cdentinger: Compare pending db and queue in Adyen capture job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [15:51:11] (PS1) Ejegg: WIP compare pending db/queue in RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) [15:52:10] ejegg|afk: nm my comment, i see what you are doing now [15:55:09] (CR) Cdentinger: "> (1 comment)" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [15:57:52] Fundraising-Backlog: Add field to Silverpop export: highest_native_amount - https://phabricator.wikimedia.org/T135407#2495972 (CCogdill_WMF) p:Normal>High I'm bumping priority on this because I realized using the highest_usd_amount field is forcing us to serve an inaccurate experience to donors. We... [16:10:32] (CR) Cdentinger: Compare pending db and queue in Adyen capture job (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [16:31:59] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 6 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2496061 (awight) [16:41:40] (PS5) Ejegg: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) [16:46:21] (PS6) Ejegg: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) [16:56:33] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah Hernandez - https://phabricator.wikimedia.org/T138100#2496184 (Jgreen) [16:58:17] awight: hey! any idea whom I should ping for nitty questions about extension reg? [16:59:31] AndyRussG: I think legoktm would be your guy [16:59:46] I just ran the script and it gives a different format for extension.json... all default values for globals in the value property of a new level in the json data structure (e.g., "NoticeListComplementThreshold": { [16:59:48] "value": 0.75 [16:59:50] }, [16:59:52] ) [16:59:54] Ah cool thx! [17:00:49] I guess you didn't get that on the first run? Maybe I'm missing an option, or I should revert to an older version of the script.... [17:01:13] AndyRussG: I would go with the newer format... [17:01:23] Good question to ask an author tho [17:01:35] Mmmm yeah I guess ur right about newerism [17:04:42] (PS7) Ejegg: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) [17:06:16] AndyRussG: also heads-up, LZia is doing a lot of volunteer work for Wiki Loves Monuments, and she wants to pull banner numbers. [17:06:51] I tried to explain beacon/recordimpression, pointed to a few mw:Extension:CentralNotice docs, and started a task to get her access [17:07:00] But I think docs might be the weak point, fwiw [17:07:18] (CR) Ejegg: [C: -1] "I'm going to put the update thing before this" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [17:08:25] (PS1) Ejegg: Update pending db to match queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) [17:12:51] (PS2) Ejegg: WIP Compare pending db/queue in Adyen RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) [17:23:37] awight: K thx :) [17:25:24] whu, whoa... > Archives directory /vagrant/cache/apt/partial is missing. [17:25:42] BTW thx for the idea of re-running the script, already caught a minor detail from an intervening change, that we would have never noticed! [17:25:51] whew! [17:26:09] Glad it didn't do anything surprising [17:26:15] awight: known issue. https://phabricator.wikimedia.org/T69976 [17:26:16] awight: I think you need to update your guest vb whatever within the vagrant guest [17:26:57] that vbclient plugin is a pain in the butt [17:27:00] bd808: ty [17:27:44] bd808: I was thinking of fixing the sudo prompt for /etc/exports, too. IMO it should print the line you need and give you the choice to do it manually or type in sudo pw. Once the line exists, it should *stop asking* [17:28:10] It's always disappointing to come back 10 minutes later and see the prompt :( [17:28:51] bd808: awight: this is something I recall having to do pretty often, I think it did solve some apt issue (sorry for the extra noise if irrelevant) https://gist.github.com/fernandoaleman/5083680 [17:29:21] interesting! [17:30:07] Whenever my vb upgraded [17:30:15] awight: the sudo prompt is upstream with Vagrant, but check out https://www.vagrantup.com/docs/synced-folders/nfs.html#root-privilege-requirement [17:31:34] Or do what I do and just disable NFS with `vagrant config nfs_shares off` and never think about it again [17:31:35] bd808: verra nice [17:31:39] hehe [17:31:49] I get sync hell trying to run it like that, though [17:31:52] that won't work with LXC though where we need nfs [17:32:37] Looks like vagrant destroy && vagrant up solved my issues this time... [17:32:59] yeah that should always work [17:33:00] 10 minutes well spent, to be sure! [17:33:13] (as long as I'm on the office network :-/) [17:33:48] the breakage happens when you have an existing VM that has had our puppet applied to it and then the vbupdate plugin decides on `vagrant up` that it needs to talk to apt [17:34:08] hrm [17:34:27] Yeah I jiggled something bad by attempting virtualbox 5.1 [17:34:42] It was unsupported & vagrant was too hard to install from src, so I dropped back to 5.0 [17:34:51] our puppet has told apt that cache is on a shared dir; shared aren't active when the plugin runs [17:38:17] (CR) Awight: [C: -1] "Great! I have questions about the MediaWiki requirement, though..." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [17:39:59] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [17:40:25] bd808: do you primarily use LXC by now and if not why not? i haven't tried it yet but am interested [17:41:46] cwd: I use it in Labs. My laptop is OSX so no LXC support there [17:42:24] oh bummer, i hadn't thought of that [17:42:32] i bet someone will port it eventually [17:42:43] although, maybe all of systemd comes with it [17:43:49] cwd: LXC is very closely tied to the Linux kernel which I doubt that Apple is going to adopt [17:44:15] there is a container thing for OSX though that docker's betas are using [17:44:27] ejegg|afk: I ran into something yesterday, the queue messages are not quite in normalized form... See DonationQueue::queueMessageToNormalized [17:45:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496368 (awight) [17:46:16] cwd: How's the librarization going? I've been a bit worried that we're setting you up for failure there--holler if it's feeling that way to you [17:47:07] awight: hi! i've just been getting caught up on the progress today [17:47:22] we are in PA at wife's sister's house [17:48:11] it does seem like full steam ahead building this into smash pig. my inclination at this point is to give up the library thing so as to no stymie progress [17:48:19] cwd: Bricks and burbs [17:48:35] k. That sounds quite sane [17:48:42] we are in the country near scranton [17:49:05] I really did want to see it standalone, but seems like it would have to depend on SP anyway, so absorption FTW [17:49:14] there is a peacock on the nearby farm making some eerie noises [17:49:43] A pleasant coal mining community [17:50:03] with a generations old underground tire fire [17:50:28] cwd: note that bug I just filed, too--DonationQueue is currently emitting a slightly bad format: T141383 [17:50:54] T141383: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383 [17:51:21] awight: the queue consumer meaning the thing that reads redis? [17:51:37] erp, lemme fix the bug. no, CRM/queue2civicrm [17:52:26] ooh, gotcha [17:52:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496418 (awight) [17:53:09] We could even roll T131272 into that [17:53:10] T131272: [Epic] Formalize schema for all message types - https://phabricator.wikimedia.org/T131272 [17:53:20] to avoid the guesswork... [17:53:25] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: Do not show donation form error message: "No processors available". Fix UI and plug holes. - https://phabricator.wikimedia.org/T117872#2496420 (... [17:54:22] (PS3) Awight: donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [17:54:24] awight: hmm yeah. isn't the message a json blob now? do we want to move away from that? [17:54:37] (CR) Awight: "There's one small unit test failure..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [17:54:55] cwd: I think it's a decent format, just needs a type: field or something [17:55:27] In the distant future, I'd prefer if all code treats the messages as objects rather than arrays, but that's probably not a good thing to do piecemeal [17:55:38] Fundraising-Backlog: Temporarily use Ingenico for Latin America credit card - https://phabricator.wikimedia.org/T141040#2496425 (Pcoombe) Open>declined Nevermind, T101129 was fixed so Astropay should be working again now. [17:56:00] (CR) jenkins-bot: [V: -1] donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [17:56:22] awight: just for syntax? or do you want to load the json into something with methods? [17:56:55] (PS3) Ejegg: Compare pending db/queue in Adyen RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) [17:57:44] cwd: Probably not SmartRecords, but I'd like to get field validation at least so we get compiler error about $msg->fname not being a thing [17:58:02] makes sense [17:58:17] It would be a nice way to encapsulate message type, also [17:58:37] Not that's a big issue... Most consumers only see one type of message, ever. [18:00:11] sounds like a good interface though [18:02:14] (PS2) Awight: Don't default to _test queues [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/296185 (owner: Ejegg) [18:02:19] (CR) Awight: [C: 2] Don't default to _test queues [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/296185 (owner: Ejegg) [18:02:39] (CR) Awight: "abandon?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281485 (owner: Ejegg) [18:04:21] (Merged) jenkins-bot: Don't default to _test queues [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/296185 (owner: Ejegg) [18:05:04] (Abandoned) Cdentinger: WIP: move PendingQueue into a library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300429 (owner: Cdentinger) [18:05:05] Fundraising-Backlog, FR-Adyen: Adyen in Ukrainian in Ukraine - https://phabricator.wikimedia.org/T124228#2496463 (Pcoombe) Open>Resolved a:Pcoombe [18:06:05] (CR) Awight: Fix some PHPDoc comments (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [18:06:14] (CR) Awight: [C: 2] Fix some PHPDoc comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [18:06:17] (PS3) Awight: Fix some PHPDoc comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [18:06:22] (CR) Awight: Fix some PHPDoc comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [18:06:29] (CR) Awight: [C: 2] Fix some PHPDoc comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [18:08:37] (Merged) jenkins-bot: Fix some PHPDoc comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281479 (owner: Ejegg) [18:09:28] (PS8) Ejegg: Generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 [18:09:43] (CR) Awight: [C: 2] Generate IPN messages matching pending db (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [18:09:51] awight: when you ran the extension registration script, it picked up the autoload classes automatically? Somehow the new one isn't.... [18:10:07] AndyRussG: strange! Yeah I'm pretty certain it worked [18:10:41] (Merged) jenkins-bot: Generate IPN messages matching pending db [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300575 (owner: Ejegg) [18:11:30] ejegg|afk: ^ fun--edited that one in gerrit [18:11:51] awight: K thx... I'm just gonna put this on pause 'till I talk to legoktm then ;) [18:12:32] awight: did you notice we can link to line numbers now? [18:12:38] that alone is worth the upgrade imo [18:12:52] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah Hernandez - https://phabricator.wikimedia.org/T138100#2496502 (Jgreen) Hannah's lutetium and database accounts are set up, and I emailed her login instructions. @CCogdill_WMF Does Hannah need Civi access? Also you re... [18:13:09] AndyRussG: This is definitely one of the trickiest extensions to migration to registration, fwiw [18:13:28] cwd: yeah who needs my silly keyboard shortcuts like ^C anyway :p [18:13:44] heh does it map that? [18:13:59] It doesn't know about modifier keys, and snarfs all keyboard input. [18:14:03] Try ^T for example [18:14:16] Mmm thx... I'm sure the script is pretty good! I'm just trying to keep my brain from imploding [18:14:46] haha [18:14:48] sigh [18:14:59] this must be disable-able [18:15:22] Looks like the new extension.json schema is required.... https://phabricator.wikimedia.org/diffusion/MW/browse/master/docs/extension.schema.json [18:16:21] maybe not [18:16:23] drag [18:17:17] AndyRussG: weird, I really don't see how the convertExtension script pulls AutoloadClasses [18:21:53] awight: maybe u homebrewed some kind of script or rough command line processing? [18:22:15] * AndyRussG jiggles awight's memory [18:22:29] noo... [18:22:31] or I guess a previous version.... [18:22:49] Or from a patchset someone else uploated? [18:23:00] I see something in there that relates to AutoloadClasses, where it ties it to a "removeAbsolutePath" function, but I don't see the rest of the glue [18:23:40] Maybe invisible [18:24:09] har. I'm missing resources on this vagrant install, e.g. http://payments.wiki.local.wmftest.net:8080/w/extensions/DonationInterface/gateway_forms/includes/padlock.gif [18:24:34] strange cos it was distinctly working on the other computer [18:25:32] Fundraising-Backlog: Create Adyen forms for CA, GB, AU, NZ and IE - https://phabricator.wikimedia.org/T138456#2496530 (DStrine) [18:27:09] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, Epic: [Epic] Create Adyen forms for CA, GB, AU, NZ and IE - https://phabricator.wikimedia.org/T138456#2496532 (awight) [18:27:26] dstrine: sorry :) [18:28:22] awight: nifty, thanks for the inline fixup! [18:28:47] awight: it's fine. I noticed it was lost in the tech backlog.I was just about to do all that. [18:29:05] dstrine: I got excited when I was multiple countries in one ticket ;) [18:29:47] ejegg: I'll bug you later today about the adyen completion job... I had one successful run last night, followed by nothing but air [18:29:54] got to lunch. [18:30:09] awight: yes it was written incorrectly [18:31:00] 299939 [18:31:08] focusfail [18:31:53] in the new gerrit, for the related changes column, is that the dependency chain? if so, does it start at the top? [18:32:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: "Impression diet" needs to be turned ON by default - https://phabricator.wikimedia.org/T139683#2496543 (DStrine) [18:35:45] (CR) XenoRyet: [C: 2] Revert "CRM-18744 - Remember quicksearch field selection" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301043 (https://phabricator.wikimedia.org/T140293) (owner: Eileen) [18:35:51] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah Hernandez - https://phabricator.wikimedia.org/T138100#2496547 (Jgreen) p:High>Low [18:36:50] fundraising-tech-ops, Operations, ops-eqiad, Patch-For-Review: decommission aluminium, replace it with frqueue1002 - https://phabricator.wikimedia.org/T140676#2496549 (Jgreen) Open>Resolved [18:37:55] (Merged) jenkins-bot: Revert "CRM-18744 - Remember quicksearch field selection" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301043 (https://phabricator.wikimedia.org/T140293) (owner: Eileen) [18:39:21] cwd higher ones depend on lower ones, i think [18:39:52] that's confusing [18:40:01] but nice you can see all of them at once anyway [18:40:46] (CR) XenoRyet: [C: 2] Hack out version & extension checks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301023 (https://phabricator.wikimedia.org/T138334) (owner: Eileen) [18:41:28] (CR) Ejegg: "Ah, I should probably wait for this till we get your additional WmfFramework stuff done" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [18:43:23] (Merged) jenkins-bot: Hack out version & extension checks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/301023 (https://phabricator.wikimedia.org/T138334) (owner: Eileen) [18:48:02] (CR) Ejegg: "awight: you need to run the job runner with --config-node adyen. (Which means we should probably have different job queues for different g" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [19:02:05] cwd: waffling over whether the job queue needs transitional code [19:02:21] awight|foodsrc: cwd ejegg XenoRyet Looking at this sentence in the general Overhaul plan: "However, more partitions will eventually allow us to support parallel consumption." [19:02:35] ( https://www.mediawiki.org/wiki/Fundraising_tech/Message_queues/Overhaul ) [19:02:52] AndyRussG: yeah, that'll require a LOT of reviewing for concurrency issues [19:03:02] Right that's what I was wondering [19:03:19] K so that's not being considered yet? For now consumption can be assumed to go in the same FIFO order? [19:03:27] yeah [19:03:32] K cool thx :) [19:04:08] parallel consumers might be able to do "select for update" to avoid stepping on each other's toes [19:05:59] I mean, it sounds like it's a "far-enough-in-the-future" thing that it doesn't have to be factored into the design for now, I guess? [19:06:49] that would be my opinion [19:07:09] http://c2.com/cgi/wiki?MakeItWorkMakeItRightMakeItFast [19:07:55] cwd: sweet! [19:16:14] ejegg: hopefully we don't need the transitional code, but maybe it's better than bombing if we space something [19:18:04] (CR) Ejegg: "I'm feeling like this logic should be in the drush wrapper, not in DonationInterface. It should be able to query Civi to see which are alr" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [19:20:21] cwd hoping we don't. I think we can 1) shut down IPN listener 2) run existing Stomp jobs till queue is empty 3) point data-store/jobs setting to redis [19:20:29] 4) turn on IPN long enough to catch 1 [19:20:50] 5) turn it back off, run QueueJobRunner and make sure it does the right thing [19:21:22] if so, 6) turn it back on and permanently switch over the jenkins job [19:21:36] if not, just switch settings back and turn listener back on [19:21:45] sorry, gotta relocate again! [19:23:29] yeah, that sounds low risk to me [19:27:09] Will the jobs that read from the pending database still be run by Jenkins? [19:27:31] I guess that's corollary and not really matterful... [19:28:57] Also, why should the orphan rectifier "be moved out of the payments cluster"? [19:31:21] AndyRussG: that one is cause it needs to read from a db that is not in pci scope [19:32:26] as far as jenkins, as much as we should stop using it for that yeah i think it is orthogonal to the queue replacement [19:33:37] AndyRussG: what's up? [19:40:56] (Abandoned) Ejegg: Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/281485 (owner: Ejegg) [19:41:49] (CR) Ejegg: "Unfortunately, that unit test failure points to why there was test code in prod in the first place." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [19:48:31] ejegg: Did you ever remember what it was we needed to configure to get vagrant playing nicely with PHPStorm again? [19:49:23] XenoRyet: We had to set a bunch of the standard xdebug config vars in /etc/hhvm/php.ini [19:49:48] And we had to figure out what IP address the VM uses to talk to the real machine [19:50:22] But I'm still not sure how to set those in a way they won't be clobbered the next time you provision the machine [19:50:29] Ah, that's right. Been poking around in various .ini but that one's looking familiar. [19:50:54] We probably do have a fair bit of provisioning in our near future. [19:51:10] Probably just make a copy for now. [19:57:45] (CR) Awight: [C: 1] "I don't think there are many conflicts--mind if I merge?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [19:58:59] cwd: ah thx! Hmmm which non-scope db will it read from? [19:59:24] legoktm: hi! Just wanted a few tips on extension.json and related script, one sec... [19:59:36] AndyRussG: in the future it will be the pending DB (mysql). right now it's activemq. [20:00:04] cwd: K, so the pending db won't be in scope? [20:00:14] nope [20:00:47] AndyRussG: also, it's taking up an entire payments server and running in our most secure environment, all for no reason [20:01:01] hmmm [20:01:09] heh i guess that's ok to say in pubchan [20:01:47] hehe [20:04:27] legoktm: so my main question is if the script to migrate to extension registration no longer creates the autoload classes section of extension.json? [20:04:59] legoktm: we have this oldish patch which we're trying to update and push out https://gerrit.wikimedia.org/r/#/c/186899/ [20:06:01] Just to check things, I re-ran the script on the current (unmigrated) master... But the extension.json that that created didn't have any autoloaded classes (in addition to a somewhat new format, which I assume we'll have to update to)... Thanks!!! [20:08:22] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice geotargeting broken - https://phabricator.wikimedia.org/T141236#2496823 (AndyRussG) [20:10:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Store referrer outside of 'donor' key - https://phabricator.wikimedia.org/T141152#2496830 (DStrine) p:Triage>High [20:11:14] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface gateway/config/*.yaml should be overrideable by deployed configuration - https://phabricator.wikimedia.org/T140947#2496833 (DStrine) p:Triage>Normal [20:17:42] Fundraising Sprint Killing Time, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, and 3 others: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2496844 (DStrine) a:Ejegg [20:18:20] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special... - https://phabricator.wikimedia.org/T139439#2496847 [20:18:43] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, and 3 others: CentralNotice: finalize list of wild useless cookies for slurp, and push config change - https://phabricator.wikimedia.org/T135090#2496848 (D... [20:19:09] Fundraising Sprint Nitpicking, Fundraising-Backlog, Continuous-Integration-Config, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Continuous integration mw-ext composer behavior is not predictable - https://phabricator.wikimedia.org/T141309#2496849 (DStrine) a:awight [20:22:06] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496867 (cwdent) a:cwdent [20:24:41] Is FundraisingEmailUnsubscribe still used? [20:25:44] Yup [20:25:44] [submodule "extensions/DonationEmailUnsubscribe"] [20:25:44] path = extensions/DonationEmailUnsubscribe [20:25:44] url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/FundraisingEmailUnsubscribe.git [20:25:50] Why 2 different names? :/ [20:26:43] Fundraising Tech Backlog: Convert FundraisingEmailUnsubscribe to use extension registration - https://phabricator.wikimedia.org/T108764#1529881 (Reedy) >>! In T108764#2446182, @Paladox wrote: > @awright hi, is this extension even used any more. I thought we use the donation extension now (I could think of th... [20:28:27] AndyRussG: it should work. but iirc CentralNotice did weird things like adding the autoload entries in an extensionfunction that the script can't auto-detect [20:31:59] legoktm: ah yeah that's where they are [20:32:20] I could copy them to CentralNotice.php just for the purposes of running the script and making sure they're all in extension.json [20:33:44] Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496910 (awight) [20:33:47] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2496908 (awight) [20:35:41] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#1560019 (awight) [20:35:43] Fundraising Sprint Hermit Crab Husbandry, Fundraising Sprint Internet Exploring, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: [Epic] Formalize schema for all message types - https://phabricator.wikimedia.org/T131272#2496916 (awight) [20:35:49] AndyRussG: that would work [20:36:48] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2496931 (cwdent) a:cwdent [20:37:28] legoktm: cool beans, thx! [20:37:36] so also we should indeed use the new format, right? [20:38:05] (as per https://phabricator.wikimedia.org/diffusion/MW/browse/master/docs/extension.schema.json ) [20:38:09] ? ^ legoktm [20:39:06] AndyRussG: uh, don't use manifest_version: 2 yet, stick with 1 for now since this is a pretty large extension. you might need to use an older core version to generate it using version 1 [20:39:29] AndyRussG: mostly becuase 2 is still in a state where we might be making breaking changes. and I haven't formally announced it yet [20:40:08] legoktm: ah OK... So I should use an older version of the script to generate a version 1 of extension.json? I assume then later there will be an automatic script to translate from version 1 to 2? [20:41:04] yes [20:41:22] (the script has already been written too :)) [20:42:41] legoktm: K great... maybe could you point me to the revision of the script I should be using for the best version 1? [20:43:54] (the script to convert the extension) [20:45:07] AndyRussG: the revision before 85b84f73b3dfb305fd44658c8c8c582bb3de1aa1 [20:45:23] legoktm: gotcha :) [20:47:44] (PS1) Ejegg: Configurable adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301206 [20:49:04] so I see the rollback now (thanks! didn't spot it yesterday). The mark_refund code does processing when there is a mismatch & throws an exception so people know. I think it should probably notify about the mismatch in some other way - do we have a precedent for that? [20:53:54] https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#related-changes [20:55:10] eileen: that sounds perfect. Yeah, there are a few things we can do. We can continue processing the message if you think that's correct, and we can log at any level or send the failmail anyway. [20:55:24] Sending the failmail is not a bad choice if we really need to hear about it. [20:55:43] But it seems like we should continue processing the message, so we at least have the data in our system? [20:56:59] awight|meeting: yeah - which was the point of the code in the first place & it seemed to work better at first & then started reversing [20:57:21] so just call failmail where I had the exception? [20:57:32] yup. lemme find a good example [20:58:44] eileen: yeah just wmf_common_failmail [20:59:10] thx [20:59:24] Watch out what you put into the third parameter btw, we're trying to cut down on the amount of PII to go out over email [20:59:54] good point [21:00:58] ok to include a link to the record though? [21:10:06] (PS2) Ejegg: Update pending db to match queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301166 (https://phabricator.wikimedia.org/T140959) [21:12:21] (CR) Ejegg: "Please go ahead and merge awight" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [21:22:38] cwd / XenoRyet: updated instructions for the account settings file in vagrant: https://gerrit.wikimedia.org/r/301286 [21:23:06] (PS3) Ejegg: Remove pre-1.27 compatibility shims [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) [21:24:29] ejegg|meeting: great. such a nasty shim we have to do there though [21:25:16] yeah, i think things blow up before you even see a form if there's no account info, or I'd say we should just take the settings out of puppet-managed [21:30:06] could we stick them in the localsettings template instead? [21:30:26] not our sandbox credentials [21:30:47] but what about just these template creds? [21:31:00] so it doesn't blow up but is not overridden in a mysterious place [21:31:49] oh yeah, I guess we could - they're in that mysterious place because that's where mediawiki::extension puts things [21:32:46] oh, but is localsettings clobbered by puppet on provision anyway? [21:33:05] it's possible [21:33:22] i wonder if there's a way to make localsettings take precedence? [21:34:08] ehh, i'm inclined to leave well enough alone at this point, as long as there's some way to make it work [21:34:32] heh yeah, don't mean to derail [21:34:44] it's just something that cost me a few hours of confusion recently [21:36:12] i guess it would be more proper to say it gifted me a few hours of confusion [21:36:19] hah [21:44:28] pretty mixed feelings about 1-click +2 [21:44:46] i wear my seatbelt [21:45:08] That one makes me nervous too. [21:46:27] amusing that the notification about new changes looks identical to gmail [21:46:54] Heh, indeed. [21:53:59] (CR) Cdentinger: [C: 2] Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [21:54:24] (CR) Awight: [C: 2] Remove pre-1.27 compatibility shims [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [21:55:22] (Merged) jenkins-bot: Compare pending db and queue in Adyen capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301026 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [21:55:59] (Merged) jenkins-bot: Remove pre-1.27 compatibility shims [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299939 (https://phabricator.wikimedia.org/T138016) (owner: Ejegg) [21:58:30] gotta cook dinner! [22:02:54] (CR) Ejegg: "awight, think I72d235e7849a is a better solution, or overboard?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [22:07:23] (CR) Awight: [C: 2] "No more rummaging for yr classes in the morning!" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301206 (owner: Ejegg) [22:07:29] (PS2) Awight: Configurable adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301206 (owner: Ejegg) [22:07:34] (CR) Awight: Configurable adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301206 (owner: Ejegg) [22:07:37] (CR) Awight: [C: 2] Configurable adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301206 (owner: Ejegg) [22:08:34] (CR) Awight: "(I merged the other one)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [22:08:53] (Merged) jenkins-bot: Configurable adapter classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301206 (owner: Ejegg) [22:09:59] thanks awight ! [22:10:15] I feel like we'd been talking about doing that forever [22:10:30] nice fine tuning! [22:10:36] was way less work than i'd imagined [22:10:44] I wanted to chat about introducing SmashPig config btw. [22:10:51] oho! [22:10:55] It gives us nice things. [22:11:18] But I'm not sure how to make it play nice with extension.json, and how to do it incrementally. [22:11:18] like dependency injection [22:11:21] yes [22:11:23] especially that [22:12:12] hmm, something like the overrides to push mediawiki globals into smashPig config? [22:12:21] i mean your overrideWithData thing... [22:12:26] meh [22:12:30] I don't really like that mechanism [22:12:38] yeah I guess like an abstracted configuration source [22:12:56] then we can do whatev we need under the hood, like merge $wg globals with /etc/fundraising/SmashPig.yaml for now [22:12:59] Would be nice to have the SmashPig context & config all set up in one spot, as soon as we knew what adapter we cared about [22:13:05] +1 [22:14:02] SmashPig config could be the authoritative source for account credentials [22:14:29] as long as we clear up the silly nested adyen: payment-providers: adyen: credentials: stuff [22:14:46] hehe. [22:15:21] the more we put in sp config, the more urgent it is to talk to Jeff_Green about getting us a way to manage it [22:15:56] yah that's still hanging, eh? [22:16:03] yep [22:16:47] well that's a blocker anyway [22:17:02] where am I... [22:17:20] The real thing I'm stuck on at the moment is what to do about lightly scattered session and request access [22:18:05] argh, those are so nasty [22:18:21] oh dang, I said I was going to redeploy yesterday [22:18:25] I should deal with that [22:19:14] There are mad edge cases in the request+session stuff, I'm afraid. [22:19:52] I also can't face the scope creep--that's a lot of the code I have to either work around or fix. [22:20:00] [22:20:36] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2497146 (awight) [22:23:00] (PS1) Eileen: Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) [22:25:08] (CR) jenkins-bot: [V: -1] Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [22:26:27] awight: is there any precedent for mocking the failmail process - I'm getting this error https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/2749/console [22:26:37] (locally too) [22:27:17] (CR) Awight: [C: -1] "Great idea to include the admin link!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [22:27:57] eileen: ooh I think we have a test for wmf_communication emails, lemme see... [22:27:59] (CR) Eileen: "> (1 comment)" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [22:29:09] dang. maybe no longer [22:29:33] eileen: Try this perhaps, modules/wmf_campaigns/tests/WmfCampaignTest.php [22:30:12] thanks [22:30:16] eileen: I'm not even sure what Mailer interface that overrides, though [22:30:41] I'll find out... [22:30:52] ah--good news is that failmail.php uses the Drupal mailer, so I think TestMailer will give you the mocking you need. [22:31:18] dang. or not [22:31:25] what a roller coaster ;) [22:31:50] Feel free to refactor the failmail class to use wmf_communication\Mailer [22:34:00] (Abandoned) Awight: [WIP] Unacceptable hacks for batch processing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301068 (owner: Awight) [22:36:14] (PS12) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [22:36:16] (PS3) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [22:36:32] (CR) jenkins-bot: [V: -1] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [22:36:50] (CR) jenkins-bot: [V: -1] More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [22:37:30] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2497210 (DStrine) Here is a new link on staging: https://civicrm.frdev.wikimedia.org/civicrm/report/instance/91?reset=1&force=1 @RLewis please review [22:38:43] (PS16) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [22:38:45] (PS4) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [22:49:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2497238 (DStrine) @Eileenmcnaughton and @RLewis I have created a test report here: https://civicrm.frdev.wikimedia.org/civicrm/report/instance/95?reset=1&force=1 @Eil... [22:49:40] (Abandoned) Awight: [WIP] shovel in more DonationInterface configuration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301067 (owner: Awight) [22:51:33] "gut review" [22:51:35] (PS4) Awight: [WIP] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T131275) [22:51:38] cheap thrills [22:54:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Report does not save reports to any UI by default - https://phabricator.wikimedia.org/T141406#2497248 (DStrine) [22:56:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2497266 (Eileenmcnaughton) I feel like there was a reason it wasn't added - but I can't find it reading back through the ticket. One thing Major Gifts might like is some... [23:01:42] (PS5) Awight: [DO NOT MERGE] New fetch by primary id plus offset, for incomplete consumption [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) [23:01:49] (CR) jenkins-bot: [V: -1] [DO NOT MERGE] New fetch by primary id plus offset, for incomplete consumption [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:02:02] (CR) Awight: [C: -1] "Stalling this one cos it seems we don't need this interface." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:06:12] (PS13) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [23:06:14] (PS4) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [23:07:32] (CR) jenkins-bot: [V: -1] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [23:07:46] (CR) jenkins-bot: [V: -1] More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [23:08:52] !log updated payments from 79cb53998c41f72d0fa49130ed1f66dc112b478c to 79d2b67067fd7e579372b63e0d619eccfa3b9143 [23:08:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:09:11] (PS14) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [23:09:13] (PS5) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [23:10:44] awight: I'm just looking at refactoring failmail to use the Mailier & trying to figure out what makes sense. The drupal_mail function it uses calls hooks - among them the hook to change the body based on the $params. That hook isn't called in our drupal Mailer class. I feel like I can make it call it with an unhealthy use of duplciationg code from drupal_mail to our Mailer implementation.... [23:11:01] ack [23:11:46] Doesn't look like we're doing anything useful in the hook, though [23:12:24] well - we just re-format our data to create the body [23:12:35] that can just be a static argument tho [23:12:55] yeah - we could create the html & plaintext body & pass them in [23:13:00] rather than using the hook [23:13:42] I think html/plaintext is done inside of Mailer, transparent to the caller [23:13:57] yeah, "wrapHtmlSnippet" [23:14:19] ah nope [23:14:23] good - I was just noting it said at the top of the class it was a required key in the send function [23:14:28] normalizeContent [23:14:54] ty, and feel free to not do this of course, if it's tedious [23:16:05] hmm - I think I need to do something to make the tests pass… [23:16:20] so this is OK - I'm just figuring out what we need for what [23:20:06] (PS1) Ejegg: Use IDENTIFIER constants instead of strings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301311 [23:20:49] (Abandoned) Ejegg: donation.api cleanup, no test code in prod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/298035 (owner: Ejegg) [23:22:13] (PS17) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [23:22:15] (PS5) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [23:22:17] (PS15) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [23:22:19] (PS6) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [23:23:18] (CR) jenkins-bot: [V: -1] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:23:28] (CR) jenkins-bot: [V: -1] WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [23:23:43] (CR) jenkins-bot: [V: -1] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [23:23:54] (CR) jenkins-bot: [V: -1] More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [23:33:49] (PS4) Ejegg: Compare pending db/queue in Adyen RecordCaptureJob [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301145 (https://phabricator.wikimedia.org/T140959) [23:40:08] (PS18) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [23:41:33] (CR) jenkins-bot: [V: -1] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight)