[00:04:11] aaaargh [00:04:40] (PS1) Ejegg: WIP DO NOT MERGE: kill SmashPig pending queue code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 [00:04:42] u ok? [00:05:10] awight|brb: heh just getting in an extra "aaarg" to save up in case of future frustration [00:05:14] thx 4 asking :) [00:05:24] hehehe I wish I had a cool name like you and cwd [00:05:38] (CR) jenkins-bot: [V: -1] WIP DO NOT MERGE: kill SmashPig pending queue code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (owner: Ejegg) [00:05:45] awight: eh? ur name is great! [00:06:03] no programming reference tho [00:06:07] D: [00:06:08] ehh, it's awight [00:06:15] wank you [00:06:20] :P [00:06:22] lol [00:06:38] I few batter all weddy [00:07:11] oh. this reminds me. https://www.exploratorium.edu/exhibits/ladle/ [00:07:23] I loved that book! [00:07:34] did your folks give it to my folks? [00:07:45] Or vice-versa [00:09:38] (PS19) Awight: [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [00:09:40] (PS6) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [00:09:40] gotta run! [00:09:42] (PS16) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [00:09:44] (PS7) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [00:11:09] (CR) jenkins-bot: [V: -1] WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [00:11:29] (CR) jenkins-bot: [V: -1] Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [00:11:45] (CR) jenkins-bot: [V: -1] More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [00:11:56] (CR) jenkins-bot: [V: -1] [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [00:13:01] Water grate buck! [00:14:21] Batter den washing dead invention [00:39:42] (PS1) Eileen: Remove a bunch of trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301317 [00:39:44] (PS1) Eileen: Alter wmf_common_failmail signature so that does no mix strings & Exceptions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301318 (https://phabricator.wikimedia.org/T138542) [00:41:39] Sorry, I meant, "Batter den washing deck invention." [00:42:03] (CR) jenkins-bot: [V: -1] Alter wmf_common_failmail signature so that does no mix strings & Exceptions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301318 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [00:43:01] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301318 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [00:43:04] (CR) jenkins-bot: [V: -1] Remove a bunch of trailing spaces [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301317 (owner: Eileen) [00:51:14] Fundraising-Backlog, FR-Smashpig, MediaWiki-Codesniffer: Write mutant code style config for SmashPig, or fully adopt MediaWiki style - https://phabricator.wikimedia.org/T133576#2236348 (Krinkle) Note that most style violations can be fixed automatically by running the `phpcbf` utility that comes with... [01:05:10] !log rolled back paymentswiki from 79d2b67067fd7e579372b63e0d619eccfa3b9143 to 79cb53998c41f72d0fa49130ed1f66dc112b478c [01:05:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:48:06] (PS1) Eileen: Refactor failmail to use the Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) [01:52:09] (PS2) Eileen: Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) [01:54:11] (CR) jenkins-bot: [V: -1] Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [02:46:50] (PS3) Eileen: Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) [02:49:03] (PS1) Eileen: Fix ProcessMessageTest to not fail on exchange rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301325 (https://phabricator.wikimedia.org/T138542) [02:50:38] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301317 (owner: Eileen) [02:53:53] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301318 (https://phabricator.wikimedia.org/T138542) (owner: Eileen) [02:57:29] (PS2) Eileen: Fix ProcessMessageTest to not fail on exchange rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301325 (https://phabricator.wikimedia.org/T138542) [02:57:31] (PS2) Eileen: Refactor failmail to use the Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) [02:57:33] (PS4) Eileen: Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) [02:59:11] (PS3) Eileen: Fix ProcessMessageTest to not fail on exchange rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301325 (https://phabricator.wikimedia.org/T138542) [02:59:13] (PS3) Eileen: Refactor failmail to use the Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301321 (https://phabricator.wikimedia.org/T138542) [02:59:15] (PS5) Eileen: Send failmail instead of throwing exception on mismatched refund. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301304 (https://phabricator.wikimedia.org/T138542) [08:48:47] (PS2) Awight: Relax private access control [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300906 [10:40:11] Fundraising Tech Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2498383 (Aklapper) * https://phabricator.wikimedia.org/p/Eileenmcnaughton/ is associated to https://www.mediawiki.org/wiki/User:Eileenmcnaughton * https://www.mediawiki.or... [10:40:32] Fundraising Tech Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2498384 (Aklapper) p:Triage>Normal [12:06:59] arg! [12:07:46] mornin! [12:27:16] Fundraising-Backlog, Composer: Use composer-merge-plugin for FR MW - https://phabricator.wikimedia.org/T141434#2498557 (cwdent) [15:46:38] (PS1) Awight: Declare an autoloaded file in the top directory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301392 [15:46:50] (PS2) Awight: Declare an autoloaded file in the top directory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301392 [15:47:47] fr-tech: ^ That one is causing particularly nasty composer snafus, some CR would be great! [16:03:05] * awight waves [16:03:11] hullo [16:03:21] peeking at yr autoload thang [16:03:24] ah thx [16:03:55] The class became more important to find when I started using DI dependency injection and calling from the CRM... [16:04:05] odd that only the one has the .php extension [16:04:17] oh, the rest are dirs [16:04:45] mind updating the .lock as well? [16:04:56] +1 good, thx [16:05:05] durn commentless file [16:08:11] (PS1) Awight: Catch up composer.lock with new libs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301396 [16:08:47] ejegg: What do you think about that composer installer, now? Doesn't it feel wrong in the CRM repo? [16:09:28] Maybe we can override the install script with a spot of code [16:11:26] awight: yeah, I don't think it's necessary at all [16:11:54] there's so much infrastructure around payments that anybody developing is going to use vagrant [16:13:40] (CR) Ejegg: [C: 2] Declare an autoloaded file in the top directory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301392 (owner: Awight) [16:14:00] ejegg: Is the ">=1.0.1" required to be identical with a core requirement, or can I switch that to caret style? [16:19:47] (Merged) jenkins-bot: Declare an autoloaded file in the top directory [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301392 (owner: Awight) [16:21:26] (PS2) Ejegg: Catch up composer.lock with new libs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301396 (owner: Awight) [16:21:37] (CR) Ejegg: [C: 2] Catch up composer.lock with new libs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301396 (owner: Awight) [16:21:41] alias orphank='gitk --all `git reflog | cut -c1-7`' [16:21:59] (long version https://gist.github.com/matthewmccullough/988077) [16:22:03] awight: err, I have no idea! [16:22:14] (on the >=1.0.1 thing) [16:22:41] gotta relocate... [16:23:13] (Merged) jenkins-bot: Catch up composer.lock with new libs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301396 (owner: Awight) [16:23:42] (PS1) Awight: Go carets on the required versions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301398 [16:25:07] (CR) jenkins-bot: [V: -1] Go carets on the required versions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301398 (owner: Awight) [16:30:15] (PS2) Awight: Go carets on the required versions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301398 [16:31:44] (CR) jenkins-bot: [V: -1] Go carets on the required versions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301398 (owner: Awight) [16:38:31] (PS20) Awight: [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [16:38:33] (PS7) Awight: WmfFramework-ize some HTTP request functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) [16:38:35] (PS17) Awight: Some decoupling of GatewayPage from GatewayType [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300804 (https://phabricator.wikimedia.org/T131798) [16:38:37] (PS8) Awight: More places where batch jobs shouldn't be pulling from the request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300933 (https://phabricator.wikimedia.org/T131798) [16:38:51] I flipped around the order of those patches, btw. [16:40:30] (CR) jenkins-bot: [V: -1] [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [16:52:20] Fundraising Tech Backlog: Set up lutetium access (plus mysql, pgehres), yubikey for Hannah Hernandez - https://phabricator.wikimedia.org/T138100#2499348 (CCogdill_WMF) @Jgreen I don't think she needs Civi access for now, at least not for my work. Thanks! @Pcoombe are you the person I should ask for ecom? Do... [17:01:28] fr-tech I've got a dr's appointment - can anybody attend scrum of scrums for me? [17:05:03] ejegg: I could but I don't feel like I'm at all the best candidate. If no one else can take it, I will, but hopefully someone else could? cwd|afk awight XenoRyet|afk ? [17:05:31] I was about to walk to the library (10 min away)... I'll check back before SoS would start to see :) [17:06:08] ejegg: do you have a summary for this week? [17:06:35] why not AndyRussG ? i feel like Central Notice is the thing that affects other groups moat [17:07:44] just that queue work continues [17:08:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2499424 (RLewis) @Eileenmcnaughton that's a good point. We definitely need something to help us determine how to prioritize the list. I'm guessing %Likelihood is the fiel... [17:12:37] fr-tech: I have a thing for tomorrow's tech chat, maybe... Starting to like the idea of a second channel for contribution tracking data. [17:13:48] It wouldn't solve the sequence generator and migrating to UUIDs problem, but would allow us to decouple the places that we write to the table. [17:14:30] It could simply be a queue that buffers the writes, and any jobs relying on c_t data would wait until that information had landed in the database. [17:15:13] I'll try to tease out a new column on the queue overhaul workboard... [17:15:52] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 6 others: [Epic] Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2499438 (awight) a:awight [17:16:29] ejegg awight just not reeling really well today... But I can do it, as a last resort [17:17:52] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2499440 (RLewis) @DStrine and @CaitVirtue all the field requested as present. I do have a few concerns: - I did notice was duplicate rows for the same donors with the same contact ID, why does... [17:18:14] AndyRussG|walkin: sorry to hear, yeah don't do it then! [17:19:31] awight: can you take SoS? [17:20:39] awight: it's really nice to have ct_id in the logs from the start of the donation [17:21:35] ejegg: right, this wouldn't help on payments where we need the sequence [17:27:10] ejegg: Sure, thanks for calling it out. Probably wise that I step away from this orphan problem for a minute, too, and have b-fast... [17:28:20] Something mysterious is causing us to skip making API calls, I'm currently populating code with printf grappling hooks in desperation [17:28:53] what is the channel for SoS? [17:29:40] huh, none I guess [17:30:49] fr-tech: Sorry for trivial but--I don't see how to join SoS! [17:32:00] * awight|eet calendar stalks [17:32:16] gotit [17:32:28] awight|eet: thx!!!! [17:33:13] awight|eet: there's also an etherpad.... [17:40:05] everyone says the drivers where they live are the worst drivers [17:40:30] but east coast drivers are truly the worst drivers [17:40:52] In the places I've lived it's different sort of worstnesses [17:40:58] different sorts [17:41:00] Southern California drivers are only bad when it rains. [17:42:05] just drove back from scranton to queens [17:42:31] it wasn't even the city drivers that terrified me. they are just a predictable kind of aggressive. it was on the interstate [17:43:38] Basically anywhere there are rules people follow, and there are rules people don't follow, and a certain percentage of drivers are assholes [17:43:40] usually everyone is going about the same speed except a few outliers. through PA and NJ it was like 50% going approximately the speed limit, 25% going 10 over, another 25% going 20 over [17:44:01] so it was a constant battle of passing and being passed [17:44:11] Yeah that happens around here for sure [17:44:21] we were almost hit by oblivious mergers like a dozen times [17:44:29] Ouch [17:44:34] or people passing me and then going slow [17:44:42] every kind of awful driving [17:44:44] it was stressful [17:45:11] It's crazy when you're going just a little bit over, so passing people, and then you get aggressively tailgateted by someone wanting to burn up the asphalt (and risk a major accident) [17:45:29] That passing and then slowing down shit bugs the piss out of me. [17:45:39] so frustrating [17:45:42] It's not a race, just drive whatever speed you want to drive. [17:45:54] heh [17:46:37] also getting tailed by semis. usually truck drivers are under some pretty severe scrutiny and drive fairly reasonably. i don't know what the difference is here. [17:46:54] Ouch [17:47:05] but getting tailed by a semi means turning a minor fender bender into a getting crushed to death situation [17:47:25] Yea, semis are pretty gnarly like that. [17:48:08] it takes a long distance to stop a 50 ton load at 70mph [17:48:22] * cwd exhales [17:48:24] Luckily the worst thing they do out here is block up the I-5 by passing each other because one of them is doing 64.8 MPH and the other wants to go 65.2, meanwhile all the cars are trying to go 80. [17:48:25] thanks for letting me rant [17:48:27] Semis are usually way nicer to me when I'm driving my truck. But all other cars treat me like I'm a lunatic and never let me switch lanes or merge [17:48:45] But I am also pissed off by everything already stated above [17:48:47] hehe [17:50:01] my wife's dad commuted from east stroudsburg to manhattan for like 20 years. i can't believe he's still alive [17:57:01] * awight|eet wonders if he's gotten in too late to bash on car culture [17:58:05] never too late [17:58:59] thanks awight! sorry, forwarded that email blindly thinking it had meeting links in it [17:59:24] no worries--it was good to get the black-box QA of hyperlink discipline [17:59:52] I would add everything to the wiki page, but it's so conspicuous of an absence that I decided to ask on the etherpad before being bold. [18:00:29] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2499604 (DStrine) I'm not sure about the duplicate rows. @Eileenmcnaughton can you tell what's happening there? for your other points: The report I generated is an test. MG needs to play with thes... [18:04:56] aha, I think I found the moth in my tests [18:09:06] You know you're off the rails when: spl_object_hash seems like a reasonable choice [18:11:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2499618 (RLewis) @DStrine - Ah sorry I see the Next Step field on the actual Prospect tab but not in the Column options for the report. [18:28:36] fundraising-tech-ops: build two queue servers to replace silicon - https://phabricator.wikimedia.org/T137150#2499649 (Jgreen) [18:29:20] fundraising-tech-ops: build two queue servers to replace silicon - https://phabricator.wikimedia.org/T137150#2358871 (Jgreen) +frqueue1001 and frqueue1002 are up and replicating +iptables policies are deployed [18:30:24] fundraising-tech-ops: build two queue servers to replace silicon - https://phabricator.wikimedia.org/T137150#2499659 (Jgreen) [18:30:26] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Provision Redis cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2499660 (Jgreen) [18:30:28] fundraising-tech-ops, Operations, netops, ops-eqiad: put pfw1- ge-2/0/11 in the 'fundraising' vlan for new host frqueue1001 - https://phabricator.wikimedia.org/T140991#2499657 (Jgreen) Open>Resolved a:Jgreen [18:32:14] fundraising-tech-ops, Operations, netops, ops-eqiad: put pfw1- ge-2/0/11 in the 'fundraising' vlan for new host frqueue1001 - https://phabricator.wikimedia.org/T140991#2483556 (Jgreen) [18:37:21] (PS21) Awight: [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [18:37:23] (PS1) Awight: Rename "data" variable to a more specific name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301417 [18:37:25] (PS1) Awight: Reverse sense of an orphan conditional [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301418 [18:37:42] ejegg: Why, do you think? ^ https://gerrit.wikimedia.org/r/301418 [18:38:40] looking [18:39:07] (CR) jenkins-bot: [V: -1] [WIP] Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [18:39:17] oh god, that function [18:46:18] (Abandoned) Awight: Reverse sense of an orphan conditional [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301418 (owner: Awight) [18:50:12] (PS33) AndyRussG: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [18:57:01] fundraising-tech-ops: build two queue servers to replace silicon - https://phabricator.wikimedia.org/T137150#2499753 (Jgreen) [19:08:05] (PS22) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [19:08:07] (PS1) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 [19:08:10] whew! Okay if that passes tests, I'm leaving it alone. [19:10:29] Argh. But it seems the hooks aren't firing at all now [19:10:51] * awight wafts chili oil under nose [19:14:36] (PS1) Ejegg: (WIP) Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) [19:16:08] (CR) jenkins-bot: [V: -1] (WIP) Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [19:16:57] omg the orphan adapter has an explicit override for pre_process_g_s [19:18:02] barrrrrf [19:18:40] (CR) Awight: [C: -2] "Not quite right..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 (owner: Awight) [19:19:00] getting fud, back soon [19:19:20] (PS1) Ejegg: Catch exceptions in setClientVariables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301428 [19:23:06] gotta roll, will be back on from the airport later [19:28:51] (PS23) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [19:28:53] (PS2) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 [19:29:03] (CR) Awight: Don't run redundant fraud checks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301424 (owner: Awight) [19:38:29] (PS2) Ejegg: Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) [19:44:54] (PS1) Ejegg: Fix documentation for CustomFiltersFunctions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301429 [19:47:34] (PS3) Ejegg: Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) [19:50:04] awight: how are you avoiding trying to rectify things we've already recorded as complete? [19:52:27] ejegg: That would be a good idea ;) [19:52:46] I was assuming that queue2civicrm completion is going to delete from the pending db after draining it of info. [19:55:02] gotcha [20:00:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Donation import should merge and delete pending db info - https://phabricator.wikimedia.org/T141477#2500034 (awight) [20:05:04] AndyRussG: meeting? [20:06:36] cwd|afk: youdoing the thing [20:07:13] oh right--airport [20:26:25] awight: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2016-17_Q1_Goals#Fundraising_Tech [20:26:57] dstrine: lol excellent [20:27:54] Well, we defined another goal that paints us into a corner... seems to be happening every quarter [20:29:24] AndyRussG: wikified here: https://www.mediawiki.org/wiki/Fundraising_tech/Queue_testing [20:32:29] fr-tech: I'd like to re-deploy or revert that 'stop processing on GatewayReady fail'. To re-deploy, i'd need at least this redirect loop fix: https://gerrit.wikimedia.org/r/301427 [20:32:45] ejegg: on it [20:33:55] thanks! [20:34:58] heading back into the library, brb [20:41:48] ugh, laptop fanning is going like crazy at 0.02 load [20:41:54] so is the one in my head [20:55:44] (CR) Awight: [C: 2] "I think it worked." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [20:55:54] (PS4) Awight: Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [20:56:00] (CR) Awight: Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [20:56:05] (CR) Awight: [C: 2] Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [20:56:16] thanks awight! [20:57:56] (Merged) jenkins-bot: Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301427 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [20:59:28] AndyRussG: cwd|afk: fyi, I'm pulling tasks that you were looking at into a "later" column... [20:59:33] Open for discussion, of course [21:01:33] Fundraising-Backlog, FR-ActiveMQ: Python fundraising-tools queue module should be abstracted and support Redis - https://phabricator.wikimedia.org/T130308#2500180 (awight) [21:01:46] I'm just going to cherry-pick that onto deployment and try again [21:02:08] Fundraising-Backlog, FR-ActiveMQ: Write specialized delay queue and handlers - https://phabricator.wikimedia.org/T131282#2500182 (awight) We might be able to... delay or invalidate this task. [21:04:09] (PS1) Ejegg: Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/301491 (https://phabricator.wikimedia.org/T137374) [21:04:20] (CR) Ejegg: [C: 2] Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/301491 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [21:04:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, Epic: [Epic] Deploy pilot new queue consumer - https://phabricator.wikimedia.org/T130306#2132077 (awight) [21:05:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, Epic: Deploy pilot new queue consumer - https://phabricator.wikimedia.org/T130306#2132077 (awight) [21:05:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, Epic: Deploy pilot new queue consumer - https://phabricator.wikimedia.org/T130306#2132077 (awight) Looks like this will be the pending queue. [21:05:30] (Merged) jenkins-bot: Make RapidFail rapid, avoid redirect loop [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/301491 (https://phabricator.wikimedia.org/T137374) (owner: Ejegg) [21:06:29] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301493 [21:06:42] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301493 (owner: Ejegg) [21:10:39] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/301493 (owner: Ejegg) [21:12:07] Fundraising-Backlog, FR-ActiveMQ, MediaWiki-extensions-DonationInterface: DonationInterface should mirror outbound queue messages - https://phabricator.wikimedia.org/T141483#2500232 (awight) [21:13:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 2 others: Audit processors should mirror outbound queue messages - https://phabricator.wikimedia.org/T141484#2500246 (awight) [21:13:56] Fundraising-Backlog, FR-ActiveMQ, FR-Smashpig, MediaWiki-extensions-DonationInterface: Listeners should mirror outbound queue messages - https://phabricator.wikimedia.org/T141485#2500261 (awight) [21:16:28] fr-tech: I cleaned up the queue overhaul board and it's less of a swamp: https://phabricator.wikimedia.org/project/board/1895/ [21:16:43] Nice [21:16:52] awesome, thanks awight! [21:17:16] !log updated payments from 79cb53998c41f72d0fa49130ed1f66dc112b478c to 2d9dd79507a42ced0a99bde87b3c45b804610e40 [21:17:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:18:53] The epics need unpacking, fwiw [21:19:04] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2500284 (awight) [21:19:18] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ, and 3 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2500300 (awight) [21:19:38] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ, and 3 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2500284 (awight) p:Normal>High [21:21:24] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 5 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2500303 (awight) [21:22:03] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ, and 4 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2500284 (awight) [21:29:19] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, and 3 others: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#2500326 (AndyRussG) [[ https://www.mediawiki.org/wiki/Extension:... [21:30:55] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: Quit looking in pending queue for completion message information - https://phabricator.wikimedia.org/T122641#2500327 (Ejegg) [21:31:56] (PS2) Ejegg: DO NOT MERGE: kill SmashPig pending queue code [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/301313 (https://phabricator.wikimedia.org/T122641) [21:42:06] awight: hey... any idea why this line in the old CentralNotice.hooks.php wrapped the value in an array? $wgHooks[ 'SkinTemplateNavigation::SpecialPage' ][ ] = array( 'CentralNotice::addNavigationTabs' ); [21:43:23] L32 https://phabricator.wikimedia.org/diffusion/ECNO/browse/master/CentralNotice.hooks.php [21:44:51] AndyRussG: it's an optional syntax that means the same thing. I was probably going for increased inconsistency ;) [21:46:52] Ah K.... BTW it wasn't ur doing, just thought u might know some history and possible relevance :) anyway it works fine without, so all good [21:47:48] cool, thanks for preventing another outbreak of debt lice! [21:49:10] mmm np, actually you did the prevention (you fixed it in your extension reg patch) I'm just snooping around in a white coat with a clipboard and a checklist ;p [21:51:56] Love the structure of the old version of CentralNotice.hooks.php... It's so quaint [21:52:46] brb. [21:58:15] awight: ejegg https://github.com/civicrm/civicrm-core/pull/8769/files :-) [21:59:12] taking a look! [22:01:02] yowza, that's huge! Putting all the generated stuff in git? [22:05:20] (PS34) AndyRussG: Migrate to extension registration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [22:06:01] ejegg: yeah - I've been pushing for that & I guess I won…. [22:06:29] nice to have something you can run right out of the repo [22:09:19] (PS24) Awight: Convert orphan rectifier to use the PendingDatabase [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300173 (https://phabricator.wikimedia.org/T131275) [22:09:56] All code generated? Wicked! [22:10:29] ejegg: +1 CG is def a development tool and not production quality [22:12:05] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2500371 (RLewis) [22:12:41] php /vagrant/srv/SmashPig/Maintenance/ConsumePendingQueue.php [22:12:49] oh that is so rad [22:12:53] Down with parameters! [22:13:32] heh, got a simple case for one thing, at least! [22:14:00] Hey, I just had a status 25 cancelled correctly from drush orphan-rectify [22:14:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2500400 (RLewis) [22:14:44] And there goes a status 800 [22:14:57] whoa, nice! [22:20:40] (PS5) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T131275) [22:20:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2500416 (Eileenmcnaughton) @DStrine I think we should have a policy of always pulling new field requests into the current sprint -... [22:21:24] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, FR-ActiveMQ, and 4 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2500419 (awight) [22:22:44] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [22:22:46] Fundraising Sprint Nitpicking, Fundraising-Backlog, Continuous-Integration-Config, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Continuous integration: DonationInterface needs composer variant - https://phabricator.wikimedia.org/T141309#2500420 (awight) [22:24:41] (CR) Ejegg: "Not seeing any breakage yet. But if you consider these static functions just stopgaps, why add them to more places than we need for the ca" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/300918 (https://phabricator.wikimedia.org/T131798) (owner: Awight) [22:31:40] eileen: hey, I saw your comment on that civi task. do new fields require much review from anyone else? My hesitation in "always pulling them in" is a possible roadblock on reviewing tasks. [22:32:55] ah true - so there are 2 things to that [22:33:04] 1) rosie CAN just add them [22:33:10] but it won't add the triggers [22:33:19] untill we get Jeff involved [22:33:57] 2) awight made the (sensible) suggestion last time we do it through code in order to keep our dev environments in sync [22:34:19] (it could be argued that matters a lot less for fields we don't interact with via code) [22:34:37] is there a way we can isolate this to just you, Rosie and Jeff and still maintain good QA and team workflow? [22:35:20] yeah - I guess you need to ask awight ejegg|meet as to whether the QA involved in adding those fields via code is light enough not to impose too much [22:37:10] It's an interesting problem. eileen what do you think about a generated, declarative list of custom fields, and a generic database migration script (can be called from more places than just hook_install) that ensures the schema is correct on dev boxen? [22:37:30] Otherwise, yeah I'm fine with getting four eyes on even these tiny patches [22:37:33] awight: as in generated from live? [22:37:34] Writing them is the annoying part [22:37:37] yeah exactly [22:37:55] What does the process of generating look like? [22:38:53] Do we hand fix up a list & then deploy & on any site where they don't match a message is thrown up [22:39:06] & if that happens on live it tells us to update the list? [22:39:26] eileen: maybe we run a drush script on staging to get the schema. We could even use that to install to production after tweaking the settings [22:39:37] just for the record: I'm trying to avoid the "death by a thousand cuts" scenario where we have 20+ tiny things to review at once. [22:39:51] +1 we would need to keep an eye on volume [22:40:01] It's low, but constant [22:40:09] one alternative is to ask MG to batch these requests and then we do them once a month. [22:40:32] I really like having them perform them self-serve on staging [22:40:39] so whatever else we do, let's keep that step. [22:41:13] awight: yeah this^^ and if they get a bunch "ready" we do them at one go [22:41:14] We could say 'go ahead & create the fields' on live & we will have an aggregate ticket to put them into dev scripts & update the triggers - until that is done the data wouldn't be recorded [22:41:42] so they get the fields (without logging) straight away & we do a tidy-up after the fact [22:42:09] eileen: maybe--but live has the restriction on deleting a field. [22:42:32] btw, I'm pretty sure there's an alternative mode we can run mariadb in which doesn't require SUPER to do trigger modifications. [22:42:46] The issue is some interplay between triggers and a certain replication mode [22:42:47] yes - we just have to continue to tell them NEVER DELETE A FIELD [22:42:57] :( [22:42:58] (but they haven't disobeyed on that so far :-) [22:43:10] Actually... They never want to delete a field anyway. That's fine. [22:43:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2500537 (DStrine) That policy could cause a traffic jam when it comes to reviewing/QA. We are currently discussing this in another... [22:43:36] It's like with kids - telling them 'don't tidy your room' works 100% of the time [22:43:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team (Long-Lived-Branches), Spike, Wikimedia-Incident: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904#2500538 (greg) [22:44:02] Yeah--you've convinced me that having the admins tweak their own custom data, live, is the future [22:44:02] eileen: LOL [22:44:15] teach them to fish! [22:44:24] plus I have the odd impulse to do the dishes [22:44:44] ok - so we'll go back & say - create away - but log us a ticket to fix up the triggers & be aware that your data won't be audit logged until we get to it? [22:47:05] Yeah that sounds great. We could suggest they do it ticket-first, for their own remembrance [22:47:51] cool [22:49:37] eileen: Can we conditionally disable the code path that deletes custom fields? [22:49:51] nice to have, I guess [22:50:00] awight: you mean hack out the lines that do the delete? [22:50:01] eileen: awight as long as this is safe for them and it doesn't lead to run-away-QA-of-many-tiny-things.. then I'm cool with it [22:50:42] dstrine: just updating the ticket about this - I note it's assigned to Rosie - do you want me to tell her to assign to someone specific when she has created them on live? Or some other ticket-action on her part? [22:51:14] It sort of still does lead to madness. Perhaps we schedule our task to solve this the right way, next year [22:51:32] The nice part about this plan is that we're never blocking MG, just inflicting a bit of paperwork [22:52:04] yeah - agree on both points [22:52:27] Thanks for figuring that out! [22:55:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2500581 (Eileenmcnaughton) @RLewis we just discussed this on IRC - with the goal of our work not being a bottle neck on this. Ther... [22:58:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding additional details to a current Custom Field - Benefactor Page Listing - https://phabricator.wikimedia.org/T141489#2500590 (DStrine) Can you add [Tidy-Up] to the task description? that will stand out better in a list of tasks. [23:01:35] (CR) Awight: "I've smoke tested this with status 25 (don't fill out the form), 600 (disable transactionConfirm_CreditCard or unplug your network cable l" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [23:03:04] (PS6) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [23:05:03] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:05:31] (CR) Awight: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:05:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Pipeline Report - https://phabricator.wikimedia.org/T128818#2500625 (Eileenmcnaughton) This is actually not showing because the field is not set to searchable. {F4313336} I suspect I didn't think we'd want to be searching the nex... [23:10:49] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2500631 (Eileenmcnaughton) @dstrine https://civicrm.frdev.wikimedia.org/civicrm/report/instance/91?reset=1&force=1 is a contribution-based report - so it's given a row for every contribution the pe... [23:18:09] (PS7) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [23:20:22] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:33:45] (PS8) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [23:33:47] (PS1) Awight: Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 [23:34:01] (PS9) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [23:35:45] (CR) jenkins-bot: [V: -1] Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [23:36:29] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:40:05] (PS2) Awight: Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 [23:41:48] (CR) jenkins-bot: [V: -1] Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [23:43:01] (PS10) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [23:43:20] (CR) Awight: "Well, this depends on @@Ic73baedd1 too." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [23:44:56] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:48:45] Fundraising-Backlog: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2500679 (DStrine) I could have sworn I started with a donor report. Is there a way to switch once you've made it? If not, I'll retry with a donor report template later. [23:52:29] (CR) Awight: "Please note that you can (hopefully) make the test failures go away by updating to the draft DonationInterface patch. This change is read" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight)